Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudr...@intel.com wrote: >On 4/10/2018 8:43 AM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 05:27:48PM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/10/2018 8:22 AM, Jiri Pirko wrote: >> > > Tue, Apr 10, 2018 at 05:13:40PM CEST,

Re: TCP one-by-one acking - RFC interpretation question

On Fri, Apr 06, 2018 at 09:49:58AM -0700, Eric Dumazet wrote: > Cc Neal and Yuchung if they missed this thread. > > On 04/06/2018 08:03 AM, Michal Kubecek wrote: > > On Fri, Apr 06, 2018 at 05:01:29AM -0700, Eric Dumazet wrote: > >> > >> > >> On 04/06/2018 03:05 AM, Michal Kubecek wrote: > >>>

[PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

The Cinterion AHS8 is a 3G device with one embedded WWAN interface using cdc_ether as a driver. The modem is controlled via AT commands through the exposed TTYs. AT+CGDCONT write command can be used to activate or deactivate a WWAN connection for a PDP context defined with

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >     using cdc_ether as a driver. > >     The modem is  controlled via AT commands through the exposed TTYs. > >     AT+CGDCONT write command can be used to

[PATCH] lan78xx: Correctly indicate invalid OTP

lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP content, but the value gets overwritten before it is returned and the read goes ahead anyway. Make the read conditional as it should be and preserve the error code. Signed-off-by: Phil Elwell ---

[PATCH v1 net 3/3] lan78xx: Lan7801 Support for Fixed PHY

Adding Fixed PHY support to the lan78xx driver. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J --- drivers/net/usb/Kconfig | 1 + drivers/net/usb/lan78xx.c | 42

Re: KASAN: slab-out-of-bounds Read in pfkey_add

On Wed, Apr 11, 2018 at 8:18 AM, Kevin Easton wrote: > On Mon, Apr 09, 2018 at 01:56:36AM -0400, Kevin Easton wrote: >> On Sun, Apr 08, 2018 at 09:04:33PM -0700, Eric Biggers wrote: >> ... >> > >> > Looks like this is going to be fixed by >> >

Re: [PATCH v3] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

On 04/11/2018 06:24 PM, Jia-Ju Bai wrote: > tipc_mon_create() is never called in atomic context. > > The call chain ending up at tipc_mon_create() is: > [1] tipc_mon_create() <- tipc_enable_bearer() <- tipc_nl_bearer_enable() > tipc_nl_bearer_enable() calls rtnl_lock(), which indicates this

[RFC/PATCH] Add a socketoption IPV6_MULTICAST_ALL analogue to the IPV4 version

Hi. I was running into a problem, when trying to join multiple multicast groups on a single socket and thus binding to the any-address on said socket. I received traffic from multicast groups, I did not join on that socket and was at first surprised by that. After reading some old

Re: [PATCH v2] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

On 04/10/2018 09:17 AM, Jia-Ju Bai wrote: > tipc_mon_create() is never called in atomic context. > > The call chain ending up at dn_route_init() is: Sorry, I don't think there is any relationship between the following call chain with dn_route_init(). > [1] tipc_mon_create() <-

[PATCH v2 net] slip: Check if rstate is initialized before uncompressing

On receiving a packet the state index points to the rstate which must be used to fill up IP and TCP headers. But if the state index points to a rstate which is unitialized, i.e. filled with zeros, it gets stuck in an infinite loop inside ip_fast_csum trying to compute the ip checsum of a header

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

Wed, Apr 11, 2018 at 01:28:51AM CEST, m...@redhat.com wrote: >On Tue, Apr 10, 2018 at 02:26:08PM -0700, Stephen Hemminger wrote: >> On Tue, 10 Apr 2018 11:59:50 -0700 >> Sridhar Samudrala wrote: >> >> > Use the registration/notification framework supported by the

[PATCH net] rds: MP-RDS may use an invalid c_path

rds_sendmsg() calls rds_send_mprds_hash() to find a c_path to use to send a message. Suppose the RDS connection is not yet up. In rds_send_mprds_hash(), it does if (conn->c_npaths == 0) wait_event_interruptible(conn->c_hs_waitq,

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On 2018/4/11 16:03, Greg KH wrote: On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: On 2018/4/11 14:41, Greg KH wrote: On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: stir421x_fw_upload() is never called in atomic context. The call chain ending up at

Re: [PATCH v2] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

On 2018/4/11 18:11, Ying Xue wrote: On 04/10/2018 09:17 AM, Jia-Ju Bai wrote: tipc_mon_create() is never called in atomic context. The call chain ending up at dn_route_init() is: Sorry, I don't think there is any relationship between the following call chain with dn_route_init(). [1]

[PATCH v1 net 2/3] lan78xx: Add support to dump lan78xx registers

In order to dump lan78xx family registers using ethtool, add support at lan78xx driver level. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J --- v0->v1: * Return device

[PATCH v1 net 1/3] lan78xx: PHY DSP registers initialization to address EEE link drop issues with long cables

The patch is to configure DSP registers of PHY device to handle Gbe-EEE failures with >40m cable length. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J --- v0->v1: * Use

[PATCH v1 net 0/3] lan78xx: Fixes and enhancements

These series of patches have fix and enhancements for lan78xx driver. Raghuram Chary J (3): lan78xx: PHY DSP registers initialization to address EEE link drop issues with long cables lan78xx: Add support to dump lan78xx registers lan78xx: Lan7801 Support for Fixed PHY

Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

Tue, Apr 10, 2018 at 11:26:08PM CEST, step...@networkplumber.org wrote: >On Tue, 10 Apr 2018 11:59:50 -0700 >Sridhar Samudrala wrote: > >> Use the registration/notification framework supported by the generic >> bypass infrastructure. >> >> Signed-off-by: Sridhar

Re: [patch net] devlink: convert occ_get op to separate registration

On Tue, Apr 10, 2018 at 08:43:31PM +, Sasha Levin wrote: > >Bots are starting to overwhelm actual content from human beings > >on this list, and I want to put my foot on the brake right now > >before it gets even more out of control. > > I think we're just hitting the limitations of using a

[iproute PATCH] iproute: Abort if nexthop cannot be parsed

Attempt to add a multipath route where a nexthop definition refers to a non-existent device causes 'ip' to crash and burn due to stack buffer overflow: # ip -6 route add fd00::1/64 nexthop dev fake1 Cannot find device "fake1" Cannot find device "fake1" Cannot find device "fake1" ...

Re: [RFC bpf-next v2 8/8] bpf: add documentation for eBPF helpers (58-64)

On Tue, 10 Apr 2018 15:41:57 +0100 Quentin Monnet wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 7343af4196c8..db090ad03626 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -1250,6 +1250,51 @@ union

[PATCH] lan78xx: Avoid spurious kevent 4 "error"

lan78xx_defer_event generates an error message whenever the work item is already scheduled. lan78xx_open defers three events - EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware of the likelihood (or certainty) of an error message, the DEV_OPEN event is added to the set of pending

Re: [PATCH] net: dsa: b53: Replace mdelay with msleep in b53_switch_reset_gpio

On 2018/4/11 13:30, Phil Reid wrote: On 11/04/2018 09:51, Jia-Ju Bai wrote: b53_switch_reset_gpio() is never called in atomic context. The call chain ending up at b53_switch_reset_gpio() is: [1] b53_switch_reset_gpio() <- b53_switch_reset() <- b53_reset_switch() <- b53_setup()

Re: [RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

Wed, Apr 11, 2018 at 08:24:43AM CEST, sridhar.samudr...@intel.com wrote: >On 4/10/2018 11:03 PM, Jiri Pirko wrote: >> Tue, Apr 10, 2018 at 05:59:02PM CEST, sridhar.samudr...@intel.com wrote: >> > On 4/10/2018 8:43 AM, Jiri Pirko wrote: >> > > Tue, Apr 10, 2018 at 05:27:48PM CEST,

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: > > > On 2018/4/11 14:41, Greg KH wrote: > > On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: > > > stir421x_fw_upload() is never called in atomic context. > > > > > > The call chain ending up at stir421x_fw_upload() is: > >

Re: [PATCH net-next] netns: filter uevents correctly

On Tue, Apr 10, 2018 at 10:04:46AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > On Mon, Apr 09, 2018 at 06:21:31PM -0500, Eric W. Biederman wrote: > >> Christian Brauner writes: > >> > >> > On Thu, Apr 05,

[PATCH v3] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

tipc_mon_create() is never called in atomic context. The call chain ending up at tipc_mon_create() is: [1] tipc_mon_create() <- tipc_enable_bearer() <- tipc_nl_bearer_enable() tipc_nl_bearer_enable() calls rtnl_lock(), which indicates this function is not called in atomic context. Despite never

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On Wed, Apr 11, 2018 at 04:11:00PM +0800, Jia-Ju Bai wrote: > > > On 2018/4/11 16:03, Greg KH wrote: > > On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: > > > > > > On 2018/4/11 14:41, Greg KH wrote: > > > > On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: > > > > >

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: > stir421x_fw_upload() is never called in atomic context. > > The call chain ending up at stir421x_fw_upload() is: > [1] stir421x_fw_upload() <- stir421x_patch_device() <- irda_usb_probe() > > irda_usb_probe() is set as ".probe" in

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On 2018/4/11 14:41, Greg KH wrote: On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote: stir421x_fw_upload() is never called in atomic context. The call chain ending up at stir421x_fw_upload() is: [1] stir421x_fw_upload() <- stir421x_patch_device() <- irda_usb_probe()

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On 2018/4/11 16:17, Greg KH wrote: On Wed, Apr 11, 2018 at 04:11:00PM +0800, Jia-Ju Bai wrote: On 2018/4/11 16:03, Greg KH wrote: On Wed, Apr 11, 2018 at 03:17:10PM +0800, Jia-Ju Bai wrote: On 2018/4/11 14:41, Greg KH wrote: On Wed, Apr 11, 2018 at 09:29:34AM +0800, Jia-Ju Bai wrote:

RE: [PATCH v3] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

> -Original Message- > From: Ying Xue [mailto:ying@windriver.com] > Sent: Wednesday, April 11, 2018 06:27 > To: Jia-Ju Bai ; Jon Maloy > ; da...@davemloft.net > Cc: netdev@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- >

Re: [PATCH net 4/6] bnxt_en: Support max-mtu with VF-reps

From: Michael Chan Date: Tue, 10 Apr 2018 23:58:11 -0400 > From: Sriharsha Basavapatna > > While a VF is configured with a bigger mtu (> 1500), any packets that > are punted to the VF-rep (slow-path) get dropped by OVS

[PATCH net 2/2] net: aquantia: oops when shutdown on already stopped device

In case netdev is closed at the moment of pci shutdown, aq_nic_stop gets called second time. napi_disable in that case hangs indefinitely. In other case, if device was never opened at all, we get oops because of null pointer access. We should invoke aq_nic_stop conditionally, only if device is

[PATCH net 1/2] net: aquantia: Regression on reset with 1.x firmware

On ASUS XG-C100C with 1.5.44 firmware a special mode called "dirty wake" is active. With this mode when motherboard gets powered (but no poweron happens yet), NIC automatically enables powersave link and watches for WOL packet. This normally allows to powerup the PC after AC power failures. Not

[PATCH net 0/2] Aquantia atlantic critical fixes 04/2018

Two regressions on latest 4.16 driver reported by users Some of old FW (1.5.44) had a link management logic which prevents driver to make clean reset. Driver of 4.16 has a full hardware reset implemented and that broke the link and traffic on such a cards. Second is oops on shutdown callback in

[PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

pf->cmp_addr() is called before binding a v6 address to the sock. It should not check ports, like in sctp_inet_cmp_addr. But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, sctp_v6_cmp_addr where it also compares the ports. This would cause that

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote: > lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP > content, but the value gets overwritten before it is returned and the > read goes ahead anyway. Make the read conditional as it should be > and preserve the error

[PATCH][next] iwlwifi: mvm: remove division by size of sizeof(struct ieee80211_wmm_rule)

From: Colin Ian King The subtraction of two struct ieee80211_wmm_rule pointers leaves a result that is automatically scaled down by the size of the size of pointed-to type, hence the division by sizeof(struct ieee80211_wmm_rule) is bogus and should be removed. Detected

Re: [PATCH] vhost: Fix vhost_copy_to_user()

On Wed, Apr 11, 2018 at 03:30:38PM +0200, Eric Auger wrote: > vhost_copy_to_user is used to copy vring used elements to userspace. > We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. > > Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache") > Signed-off-by: Eric Auger

[PATCH 3/5] net: stmmac: dwmac-sun8i: Allow getting syscon regmap from device

From: Chen-Yu Tsai On the Allwinner R40 SoC, the "GMAC clock" register is in the CCU address space; on the A64 SoC this register is in the SRAM controller address space, and with a different offset. To access the register from another device and hide the internal difference

Re: [PATCH net] rds: MP-RDS may use an invalid c_path

On 4/11/18 12:57 AM, Ka-Cheong Poon wrote: rds_sendmsg() calls rds_send_mprds_hash() to find a c_path to use to send a message. Suppose the RDS connection is not yet up. In rds_send_mprds_hash(), it does if (conn->c_npaths == 0)

[PATCH 4/5] drivers: soc: sunxi: export a regmap for EMAC clock reg on A64

The A64 SRAM controller memory zone has a EMAC clock register, which is needed by the Ethernet MAC driver (dwmac-sun8i). Export a regmap for this register on A64. Signed-off-by: Icenowy Zheng --- drivers/soc/sunxi/sunxi_sram.c | 48 -- 1

[PATCH 5/5] arm64: allwinner: a64: add SRAM controller device tree node

Allwinner A64 has a SRAM controller, and in the device tree currently we have a syscon node to enable EMAC driver to access the EMAC clock register. As SRAM controller driver can now export regmap for this register, replace the syscon node to the SRAM controller device node, and let EMAC driver to

[PATCH] vhost: Fix vhost_copy_to_user()

vhost_copy_to_user is used to copy vring used elements to userspace. We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache") Signed-off-by: Eric Auger --- This fixes a stall observed when running an

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 > Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Also, all of your networking submissions have been dropped

Re: [PATCH v3 2/2] vhost: return bool from *_access_ok() functions

On Wed, Apr 11, 2018 at 10:35:41AM +0800, Stefan Hajnoczi wrote: > Currently vhost *_access_ok() functions return int. This is error-prone > because there are two popular conventions: > > 1. 0 means failure, 1 means success > 2. -errno means failure, 0 means success > > Although vhost mostly

Re: [PATCH v3 1/2] vhost: fix vhost_vq_access_ok() log check

On Wed, Apr 11, 2018 at 10:35:40AM +0800, Stefan Hajnoczi wrote: > Commit d65026c6c62e7d9616c8ceb5a53b68bcdc050525 ("vhost: validate log > when IOTLB is enabled") introduced a regression. The logic was > originally: > > if (vq->iotlb) > return 1; > return A && B; > > After the patch

[PATCH 2/5] net: stmmac: dwmac-sun8i: Use regmap_field for syscon register access

From: Chen-Yu Tsai In several SoCs the EMAC register is in the range of another device, either the SRAM controller (e.g. A64) or the clock controlling unit (e.g. R40). In this situation we're going to let the device to export a regmap which contains only the EMAC register, for the

[PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i is in another device's memory space. In this situation dwmac-sun8i can use a regmap exported by the other device with only the EMAC clock register. Document this situation in the dwmac-sun8i device tree binding documentation.

Re: [PATCH] vhost: Fix vhost_copy_to_user()

On 2018年04月11日 21:30, Eric Auger wrote: vhost_copy_to_user is used to copy vring used elements to userspace. We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache") Signed-off-by: Eric Auger --- This

Re: WARNING: possible recursive locking detected

On Wed, Apr 11, 2018 at 4:02 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) > Merge tag 'ceph-for-4.17-rc1' of

Re: [PATCH net] rds: MP-RDS may use an invalid c_path

From: Ka-Cheong Poon Date: Wed, 11 Apr 2018 00:57:25 -0700 > rds_sendmsg() calls rds_send_mprds_hash() to find a c_path to use to > send a message. Suppose the RDS connection is not yet up. In > rds_send_mprds_hash(), it does > > if (conn->c_npaths == 0) >

Re: [PATCH] vhost: Fix vhost_copy_to_user()

Hi Jason, On 11/04/18 15:44, Jason Wang wrote: > > > On 2018年04月11日 21:30, Eric Auger wrote: >> vhost_copy_to_user is used to copy vring used elements to userspace. >> We should use VHOST_ADDR_USED instead of VHOST_ADDR_DESC. >> >> Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache")

WARNING: possible recursive locking detected

Hello, syzbot hit the following crash on upstream commit b284d4d5a6785f8cd07eda2646a95782373cd01e (Tue Apr 10 19:25:30 2018 +) Merge tag 'ceph-for-4.17-rc1' of git://github.com/ceph/ceph-client syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=3c43eecd7745a5ce1640 So far

Re: [PATCH v1 net 0/3] lan78xx: Fixes and enhancements

From: Raghuram Chary J Date: Wed, 11 Apr 2018 12:54:47 +0530 > These series of patches have fix and enhancements for > lan78xx driver. Two problems with this series: 1) Only bug fixes are appropriate at this time. Features and "enhancements" belong

[PATCH 0/5] Add support in dwmac-sun8i for accessing EMAC clock

On some Allwinner SoCs, the EMAC clock register is in another device's emory space, e.g. on A64 it's in the memory space of SRAM controller. This patchset adds the possibility for the device to export the EMAC clock register as a single-register regmap. PATCH 1 adds the device tree binding for

Re: TCP one-by-one acking - RFC interpretation question

On Wed, Apr 11, 2018 at 12:58:37PM +0200, Michal Kubecek wrote: > There is something else I don't understand, though. In the case of > acking previously sacked and never retransmitted segment, > tcp_clean_rtx_queue() calculates the parameters for tcp_ack_update_rtt() > using > > if

Re: [RFC PATCH v2 00/14] Introducing AF_XDP support

2018-04-10 16:14 GMT+02:00 William Tu : > On Mon, Apr 9, 2018 at 11:47 PM, Björn Töpel wrote: [...] >>> >> >> So you've setup two identical UMEMs? Then you can just forward the >> incoming Rx descriptor to the other netdev's Tx queue. Note, that you >>

Re: [PATCH linux] net: fix deadlock while clearing neighbor proxy table

David Miller wrote: > From: Wolfgang Bumiller > Date: Tue, 10 Apr 2018 11:15:14 +0200 > > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > > index 7b7a14abba28..601df647588c 100644 > > --- a/net/core/neighbour.c > > +++ b/net/core/neighbour.c > > @@ -292,7

Re: [PATCH v1 net 0/3] lan78xx: Fixes and enhancements

On Wed, Apr 11, 2018 at 12:54:47PM +0530, Raghuram Chary J wrote: > These series of patches have fix and enhancements for > lan78xx driver. Hi Raghuram Please separate the fixes from the enhancements. The enhancements need to wait until net-next re-opens in a weeks time. The first patch, which

Re: [PATCH] lan78xx: Correctly indicate invalid OTP

Hi Andrew. On 11/04/2018 13:57, Andrew Lunn wrote: > On Wed, Apr 11, 2018 at 10:59:17AM +0100, Phil Elwell wrote: >> lan78xx_read_otp tries to return -EINVAL in the event of invalid OTP >> content, but the value gets overwritten before it is returned and the >> read goes ahead anyway. Make the

Re: [PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check

On Wed, Apr 11, 2018 at 10:35:39AM +0800, Stefan Hajnoczi wrote: > v3: > * Rebased onto net/master and resolved conflict [DaveM] > > v2: > * Rewrote the conditional to make the vq access check clearer [Linus] > * Added Patch 2 to make the return type consistent and harder to misuse > [Linus]

Re: [PATCH] make net_gso_ok return false when gso_type is zero(invalid)

> Note that TCP stack now works with GSO being always on. > 0a6b2a1dc2a2 ("tcp: switch to GSO being always on") I've tested on the latest net-next branch 17dec0a949153d9ac00760ba2f5b78cb583e995f. The problem still exists. My patch won't work. Reverting commit 0a6b2a1dc2a2 won't help.

Re: [PATCH 1/2] staging: irda: Replace mdelay with usleep_range in stir421x_fw_upload

On 2018/4/11 22:26, David Miller wrote: From: Jia-Ju Bai Date: Wed, 11 Apr 2018 16:20:22 +0800 Okay, I now know why many of my patches were not replied. Many of your patches are not responded to because you handle patch feedback poorly sometimes. Okay, thanks for

RE: [PATCH] lan78xx: Don't reset the interface on open

Hi Phil, > Hi Nisar, > > On 10/04/2018 15:16, nisar.sa...@microchip.com wrote: > > Thanks Phil, for identifying the issues. > > > >> - ret = lan78xx_reset(dev); > >> - if (ret < 0) > >> - goto done; > >> - > >>phy_start(net->phydev); > >> > >>netif_dbg(dev, ifup, dev->net,

Re: [PATCH linux] net: fix deadlock while clearing neighbor proxy table

From: Wolfgang Bumiller Date: Wed, 11 Apr 2018 14:17:01 +0200 > David Miller wrote: >> Another way is to rename pneigh_ifdown() to "pneigh_ifdown_and_unlock()". > > Sure, I can send a v2 with whichever is preferred - personally I prefer > the rename as it'll be visible

RE: [PATCH v1 net 0/3] lan78xx: Fixes and enhancements

> > > These series of patches have fix and enhancements for lan78xx driver. > > Two problems with this series: > > 1) Only bug fixes are appropriate at this time. Features and "enhancements" >belong in net-next which is not open right now. > > 2) Patch #3 doesn't even apply cleanly.

[PATCH v2 net 0/2] ibmvnic: Fix parameter change request handling

When updating parameters for the ibmvnic driver there is a possibility of entering an infinite loop if a return value other that a partial success is received from sending the login CRQ. Also, a deadlock can occur on the rtnl lock if netdev_notify_peers() is called during driver reset for a

[PATCH v2 net 2/2] ibmvnic: Do not notify peers on parameter change resets

When attempting to change the driver parameters, such as the MTU value or number of queues, do not call netdev_notify_peers(). Doing so will deadlock on the rtnl_lock. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |3 ++- 1 file changed, 2

[RFC bpf-next v2 1/8] bpf: add script and prepare bpf.h for new helpers documentation

2018-04-10 11:16 UTC-0700 ~ Alexei Starovoitov > On Tue, Apr 10, 2018 at 03:41:50PM +0100, Quentin Monnet wrote: >> Remove previous "overview" of eBPF helpers from user bpf.h header. >> Replace it by a comment explaining how to process the new documentation >> (to

[PATCH v2] net: samsung: sxgbe: Replace mdelay with usleep_range in sxgbe_sw_reset

sxgbe_sw_reset() is never called in atomic context. sxgbe_sw_reset() is only called by sxgbe_drv_probe(), which is only called by sxgbe_platform_probe(). sxgbe_platform_probe() is set as ".probe" in struct platform_driver. This function is not called in atomic context. Despite never getting

Re: [PATCH] net: samsung: sxgbe: Replace mdelay with usleep_range in sxgbe_sw_reset

Hi Jia-Ju, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.16 next-20180411] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: WARNING: kobject bug in br_add_if

On Wed, Apr 11, 2018 at 5:15 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) > Merge branch 'perf-urgent-for-linus' of >

[PATCH] selftests: net: add in_netns.sh to TEST_PROGS

Script in_netns.sh isn't installed. running psock_fanout test ./run_afpackettests: line 12: ./in_netns.sh: No such file or directory [FAIL] running psock_tpacket test ./run_afpackettests: line 22: ./in_netns.sh: No

[RFC bpf-next v2 3/8] bpf: add documentation for eBPF helpers (12-22)

2018-04-10 15:43 UTC-0700 ~ Alexei Starovoitov > On Tue, Apr 10, 2018 at 03:41:52PM +0100, Quentin Monnet wrote: >> Add documentation for eBPF helper functions to bpf.h user header file. >> This documentation can be parsed with the Python script provided in >>

[RFC bpf-next v2 2/8] bpf: add documentation for eBPF helpers (01-11)

2018-04-10 10:56 UTC-0700 ~ Alexei Starovoitov > On Tue, Apr 10, 2018 at 03:41:51PM +0100, Quentin Monnet wrote: >> Add documentation for eBPF helper functions to bpf.h user header file. >> This documentation can be parsed with the Python script provided in >>

[PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

This is enhanced from the proposed patch by Igor Maravic in 2011 to support per interface IPv4 stats. The enhancement is mainly adding a kernel configuration option CONFIG_IP_IFSTATS_TABLE. Signed-off-by: Stephen Suryaputra --- drivers/net/vrf.c | 2 +-

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares

Re: [PATCH net 0/2] Aquantia atlantic critical fixes 04/2018

From: Igor Russkikh Date: Wed, 11 Apr 2018 15:23:23 +0300 > Two regressions on latest 4.16 driver reported by users > > Some of old FW (1.5.44) had a link management logic which prevents > driver to make clean reset. Driver of 4.16 has a full hardware reset >

Re: [PATCH] dec: tulip: de4x5: Replace mdelay with usleep_range in de4x5_hw_init

Hi Jia-Ju, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on v4.16 next-20180411] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

WARNING: kobject bug in br_add_if

Hello, syzbot hit the following crash on upstream commit 10b84daddbec72c6b440216a69de9a9605127f7a (Sat Mar 31 17:59:00 2018 +) Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip syzbot dashboard link:

Re: [PATCH net 1/2] ibmvnic: Handle all login error conditions

On 04/11/2018 10:07 AM, David Miller wrote: > From: Nathan Fontenot > Date: Wed, 11 Apr 2018 09:37:21 -0500 > >> There is a bug in handling the possible return codes from sending the >> login CRQ. The current code treats any non-success return value, >> minus failure to

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

From: Xin Long Date: Thu, 12 Apr 2018 00:16:58 +0800 > What do you think of: > > static int sctp_v6_cmp_addr(const union sctp_addr *addr1, > const union sctp_addr *addr2) > { > return __sctp_v6_cmp_addr(addr1, addr2) && >

[PATCH net 0/2] ibmvnic: Fix parameter change request handling

When updating parameters for the ibmvnic driver there is a possibility of entering an infinite loop if a return value other that a partial success is received from sending the login CRQ. Also, a deadlock can occur on the rtnl lock if netdev_notify_peers() is called during driver reset for a

Re: [PATCH v3 0/2] vhost: fix vhost_vq_access_ok() log check

From: "Michael S. Tsirkin" Date: Wed, 11 Apr 2018 16:24:02 +0300 > On Wed, Apr 11, 2018 at 10:35:39AM +0800, Stefan Hajnoczi wrote: >> v3: >> * Rebased onto net/master and resolved conflict [DaveM] >> >> v2: >> * Rewrote the conditional to make the vq access check clearer

[PATCH v2 net] lan78xx: PHY DSP registers initialization to address EEE link drop issues with long cables

The patch is to configure DSP registers of PHY device to handle Gbe-EEE failures with >40m cable length. Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver") Signed-off-by: Raghuram Chary J --- v0->v1: * Use

[PATCH v2 net 1/2] ibmvnic: Handle all login error conditions

There is a bug in handling the possible return codes from sending the login CRQ. The current code treats any non-success return value, minus failure to send the crq and a timeout waiting for a login response, as a need to re-send the login CRQ. This can put the drive in an infinite loop of trying

Re: [PATCH net-next] Per interface IPv4 stats (CONFIG_IP_IFSTATS_TABLE)

On Tue, 10 Apr 2018 22:55:35 -0400 Stephen Suryaputra wrote: > This is enhanced from the proposed patch by Igor Maravic in 2011 to > support per interface IPv4 stats. The enhancement is mainly adding a > kernel configuration option CONFIG_IP_IFSTATS_TABLE. > >

Re: [PATCH] net/tls: Remove VLA usage

On 04/10/18 05:52 PM, Kees Cook wrote: > In the quest to remove VLAs from the kernel[1], this replaces the VLA > size with the only possible size used in the code, and adds a mechanism > to double-check future IV sizes. > > [1] >

Re: [PATCH] lan78xx: Avoid spurious kevent 4 "error"

From: Phil Elwell Date: Wed, 11 Apr 2018 12:02:47 +0100 > lan78xx_defer_event generates an error message whenever the work item > is already scheduled. lan78xx_open defers three events - > EVENT_STAT_UPDATE, EVENT_DEV_OPEN and EVENT_LINK_RESET. Being aware > of the

Re: [PATCH v2 net] slip: Check if rstate is initialized before uncompressing

From: Tejaswi Tanikella Date: Wed, 11 Apr 2018 16:34:47 +0530 > On receiving a packet the state index points to the rstate which must be > used to fill up IP and TCP headers. But if the state index points to a > rstate which is unitialized, i.e. filled with zeros, it

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares

Re: [PATCH] cdc_ether: flag the Cinterion AHS8 modem by gemalto as WWAN

From: Oliver Neukum Date: Wed, 11 Apr 2018 13:25:38 +0200 > Am Mittwoch, den 11.04.2018, 13:15 +0200 schrieb Bassem Boubaker: >>     The Cinterion AHS8 is a 3G device with one embedded WWAN interface >>     using cdc_ether as a driver. >> >>     The modem is  controlled via AT

Re: [linux-sunxi] [PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

On Mittwoch, 11. April 2018 16:16:37 CEST Icenowy Zheng wrote: > On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i is > in another device's memory space. In this situation dwmac-sun8i can use > a regmap exported by the other device with only the EMAC clock register. > >

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

From: Xin Long Date: Wed, 11 Apr 2018 20:58:05 +0800 > @@ -863,10 +863,31 @@ static int sctp_inet6_cmp_addr(const union sctp_addr > *addr1, > if (sctp_is_any(sk, addr1) || sctp_is_any(sk, addr2)) > return 1; > > - if (addr1->sa.sa_family !=

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 11:42:41AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > > pf->cmp_addr() is called before binding a v6 address to the sock. It > > should not check ports, like in sctp_inet_cmp_addr. > > > > But sctp_inet6_cmp_addr

Re: WARNING in kobject_add_internal

On Fri, Jan 5, 2018 at 10:41 PM, syzbot wrote: > syzkaller has found reproducer for the following crash on > 89876f275e8d562912d9c238cd888b52065cf25c >

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 10:36:07AM -0400, Neil Horman wrote: > On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > > pf->cmp_addr() is called before binding a v6 address to the sock. It > > should not check ports, like in sctp_inet_cmp_addr. > > > > But sctp_inet6_cmp_addr checks the addr

  1   2   >