Re: [RFC PATCH bpf-next 12/12] i40e: implement Tx zero-copy

2018-05-17 Thread Björn Töpel
2018-05-17 23:31 GMT+02:00 Jesper Dangaard Brouer : > > On Tue, 15 May 2018 21:06:15 +0200 Björn Töpel wrote: > >> From: Magnus Karlsson >> >> Here, the zero-copy ndo is implemented. As a shortcut, the existing >> XDP Tx rings

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-17 Thread Alexei Starovoitov
On 5/16/18 11:46 PM, Björn Töpel wrote: 2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: On 05/02/2018 01:01 PM, Björn Töpel wrote: From: Björn Töpel This patch set introduces

[PATCH v2] net: qcom/emac: Allocate buffers from local node

2018-05-17 Thread Hemanth Puranik
Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik --- Change since v1: - Addressed comments related to ordering drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Eric Dumazet
On 05/17/2018 07:36 PM, Ryan Mounce wrote: > On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: >> Eric Dumazet writes: >> >>> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >>> We don't do full parsing of SACKs, no; we were trying to

Re: [net-next PATCH v2 1/4] net: Refactor XPS for CPUs and Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > Refactor XPS code to support Tx queue selection based on > CPU map or Rx queue map. > > Signed-off-by: Amritha Nambiar > --- > include/linux/cpumask.h | 11 ++ >

Re: pull-request: bpf 2018-05-18

2018-05-17 Thread David Miller
From: Daniel Borkmann Date: Fri, 18 May 2018 02:26:17 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git

[PATCH bpf-next v2 2/7] bpf: introduce bpf subcommand BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH bpf-next v2 4/7] tools/bpf: add ksym_get_addr() in trace_helpers

2018-05-17 Thread Yonghong Song
Given a kernel function name, ksym_get_addr() will return the kernel address for this function, or 0 if it cannot find this function name in /proc/kallsyms. This function will be used later when a kernel address is used to initiate a kprobe perf event. Signed-off-by: Yonghong Song

[RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static

2018-05-17 Thread kbuild test robot
Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK") Signed-off-by: kbuild test robot --- tcp_recovery.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_recovery.c b/net/ipv4/tcp_recovery.c index 30cbfb6..71593e4 100644 ---

[net-next:master 1200/1233] net/ipv4/tcp_recovery.c:24:5: sparse: symbol 'tcp_rack_reo_wnd' was not declared. Should it be static?

2018-05-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 538e2de104cfb4ef1acb35af42427bff42adbe4d commit: 20b654dfe1beaca60ab51894ff405a049248433d [1200/1233] tcp: support DUPACK threshold in RACK reproduce: # apt-get install sparse git checkout

Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Ryan Mounce
On 17 May 2018 at 22:41, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: >> >>> >>> We don't do full parsing of SACKs, no; we were trying to keep things >>> simple... We do detect the presence

Re: [net-next PATCH v2 2/4] net: Enable Tx queue selection based on Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > This patch adds support to pick Tx queue based on the Rx queue map > configuration set by the admin through the sysfs attribute > for each Tx queue. If the user configuration for receive > queue map does not

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Cong Wang
On Thu, May 17, 2018 at 4:23 AM, Toke Høiland-Jørgensen wrote: > Eric Dumazet writes: > >> On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >>> The ACK filter is an optional feature of CAKE which is designed to improve >>> performance on links with very

Re: [PATCH bpf 5/6] tools: bpftool: resolve calls without using imm field

2018-05-17 Thread Sandipan Das
Hi Jakub, On 05/18/2018 12:21 AM, Jakub Kicinski wrote: > On Thu, 17 May 2018 12:05:47 +0530, Sandipan Das wrote: >> Currently, we resolve the callee's address for a JITed function >> call by using the imm field of the call instruction as an offset >> from __bpf_call_base. If bpf_jit_kallsyms is

[net-next:master 1230/1233] arch/sparc/include/asm/io_64.h:177:20: note: in expansion of macro 'writel'

2018-05-17 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 538e2de104cfb4ef1acb35af42427bff42adbe4d commit: 2652113ff043ca2ce1cb3be529b5ca9270c421d4 [1230/1233] net: ethernet: ti: Allow most drivers with COMPILE_TEST config: sparc64-allyesconfig (attached as

[PATCH bpf-next v2 3/7] tools/bpf: sync kernel header bpf.h and add bpf_trace_event_query in libbpf

2018-05-17 Thread Yonghong Song
Sync kernel header bpf.h to tools/include/uapi/linux/bpf.h and implement bpf_trace_event_query() in libbpf. The test programs in samples/bpf and tools/testing/selftests/bpf, and later bpftool will use this libbpf function to query kernel. Signed-off-by: Yonghong Song ---

[PATCH bpf-next v2 0/7] bpf: implement BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
Currently, suppose a userspace application has loaded a bpf program and attached it to a tracepoint/kprobe/uprobe, and a bpf introspection tool, e.g., bpftool, wants to show which bpf program is attached to which tracepoint/kprobe/uprobe. Such attachment information will be really useful to

[PATCH bpf-next v2 7/7] tools/bpftool: add perf subcommand

2018-05-17 Thread Yonghong Song
The new command "bpftool perf [show | list]" will traverse all processes under /proc, and if any fd is associated with a perf event, it will print out related perf event information. Documentation is also added. Below is an example to show the results using bcc commands. Running the following 4

[PATCH bpf-next v2 5/7] samples/bpf: add a samples/bpf test for BPF_TASK_FD_QUERY

2018-05-17 Thread Yonghong Song
This is mostly to test kprobe/uprobe which needs kernel headers. Signed-off-by: Yonghong Song --- samples/bpf/Makefile | 4 + samples/bpf/task_fd_query_kern.c | 19 ++ samples/bpf/task_fd_query_user.c | 379 +++ 3 files changed,

[PATCH bpf-next v2 6/7] tools/bpf: add two BPF_TASK_FD_QUERY tests in test_progs

2018-05-17 Thread Yonghong Song
The new tests are added to query perf_event information for raw_tracepoint and tracepoint attachment. For tracepoint, both syscalls and non-syscalls tracepoints are queries as they are treated slightly differently inside the kernel. Signed-off-by: Yonghong Song ---

Re: [net-next PATCH v2 0/4] Symmetric queue selection using XPS for Rx queues

2018-05-17 Thread Tom Herbert
On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar wrote: > This patch series implements support for Tx queue selection based on > Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue > using sysfs attribute. If the user configuration for Rx queues

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
On Thu, May 17, 2018 at 2:45 PM, Sean Young wrote: > Hi, > > Again thanks for a thoughtful review. This will definitely will improve > the code. > > On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wrote: >> >

[PATCH bpf-next v2 1/7] perf/core: add perf_get_event() to return perf_event given a struct file

2018-05-17 Thread Yonghong Song
A new extern function, perf_get_event(), is added to return a perf event given a struct file. This function will be used in later patches. Signed-off-by: Yonghong Song --- include/linux/perf_event.h | 5 + kernel/events/core.c | 8 2 files changed, 13

[PATCH bpf 2/6] bpf: powerpc64: add JIT support for multi-function programs

2018-05-17 Thread Sandipan Das
This adds support for bpf-to-bpf function calls in the powerpc64 JIT compiler. The JIT compiler converts the bpf call instructions to native branch instructions. After a round of the usual passes, the start addresses of the JITed images for the callee functions are known. Finally, to fixup the

[PATCH bpf 6/6] bpf: fix JITed dump for multi-function programs via syscall

2018-05-17 Thread Sandipan Das
Currently, for multi-function programs, we cannot get the JITed instructions using the bpf system call's BPF_OBJ_GET_INFO_BY_FD command. Because of this, userspace tools such as bpftool fail to identify a multi-function program as being JITed or not. With the JIT enabled and the test program

[PATCH bpf 3/6] bpf: get kernel symbol addresses via syscall

2018-05-17 Thread Sandipan Das
This adds new two new fields to struct bpf_prog_info. For multi-function programs, these fields can be used to pass a list of kernel symbol addresses for all functions in a given program and to userspace using the bpf system call with the BPF_OBJ_GET_INFO_BY_FD command. When bpf_jit_kallsyms is

[PATCH bpf 0/6] bpf: enhancements for multi-function programs

2018-05-17 Thread Sandipan Das
This patch series introduces the following: [1] Support for bpf-to-bpf function calls in the powerpc64 JIT compiler. [2] Provide a way for resolving function calls because of the way JITed images are allocated in powerpc64. [3] Fix to get JITed instruction dumps for multi-function programs

[PATCH bpf 5/6] tools: bpftool: resolve calls without using imm field

2018-05-17 Thread Sandipan Das
Currently, we resolve the callee's address for a JITed function call by using the imm field of the call instruction as an offset from __bpf_call_base. If bpf_jit_kallsyms is enabled, we further use this address to get the callee's kernel symbol's name. For some architectures, such as powerpc64,

[PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable Signed-off-by: Greg

[PATCH net-next 1/3] net: mvpp2: avoid checking for free aggregated descriptors twice

2018-05-17 Thread Antoine Tenart
From: Yan Markman Avoid repeating the check for free aggregated descriptors when it already failed at the beginning of the function. Signed-off-by: Yan Markman [Antoine: commit message] Signed-off-by: Antoine Tenart ---

[PATCH net-next 3/3] net: mvpp2: print rx error with rate-limit

2018-05-17 Thread Antoine Tenart
From: Yan Markman Prevent flood of RX error prints during heavy traffic with weak signal in link by checking net_ratelimit() before using netdev_err(). Signed-off-by: Yan Markman [Antoine: small rework, commit message] Signed-off-by: Antoine Tenart

[PATCH net-next] net: stmmac: Populate missing callbacks in HWIF initialization

2018-05-17 Thread Jose Abreu
Some HW specific setusp, like sun8i, do not populate all the necessary callbacks, which is what HWIF helpers were expecting. Fix this by always trying to get the generic helpers and populate them if they were not previously populated by HW specific setup. Signed-off-by: Jose Abreu

[patch net-next] nfp: flower: set sysfs link to device for representors

2018-05-17 Thread Jiri Pirko
From: Jiri Pirko Do this so the sysfs has "device" link correctly set. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/netronome/nfp/flower/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/flower/main.c

[patch net-next] nfp: flower: fix error path during representor creation

2018-05-17 Thread Jiri Pirko
From: Jiri Pirko Don't store repr pointer to reprs array until the representor is successfully created. This avoids message about "representor destruction" even when it was never created. Also it cleans-up the flow. Also, check return value after port alloc. Signed-off-by:

[PATCH net-next v3 10/10] arm64: dts: marvell: 7040-db: describe the 10G interface as fixed-link

2018-05-17 Thread Antoine Tenart
This patch adds a fixed-link node to the 10G interface of the 7040-db board. This is required as the mvpp2 driver now uses phylink. The best solution would have been to describe the SFP cage but they are not wired correctly, and thus unusable, so we chose to use fixed-link instead. Signed-off-by:

Re: [PATCH bpf-next v3 00/15] Introducing AF_XDP support

2018-05-17 Thread Björn Töpel
2018-05-04 1:38 GMT+02:00 Alexei Starovoitov : > On Fri, May 04, 2018 at 12:49:09AM +0200, Daniel Borkmann wrote: >> On 05/02/2018 01:01 PM, Björn Töpel wrote: >> > From: Björn Töpel >> > >> > This patch set introduces a new address family

[PATCH net-next 2/3] net: mvpp2: set mac address does not require the stop/start sequence

2018-05-17 Thread Antoine Tenart
From: Yan Markman Remove special stop/start handling from the set_mac_address callback. All this special care is not needed, and can be removed. It also simplifies the up/down status in the driver and helps avoiding possible link status mismatch issues. Signed-off-by: Yan

Re: [BUG] net: stmmac: dwmac-sun8i broken in linux-next

2018-05-17 Thread Jose Abreu
Hi Corentin, On 16-05-2018 19:32, Corentin Labbe wrote: > Hello > > The dwmac-sun8i driver is broken in next-20180515, symptom are no RX and TX > errors as shown by ifconfig: > eth0: flags=4163 mtu 1500 > inet 192.168.1.204 netmask 255.255.255.0

Re: xdp and fragments with virtio

2018-05-17 Thread Jason Wang
On 2018年05月17日 10:55, David Ahern wrote: On 5/16/18 1:24 AM, Jason Wang wrote: On 2018年05月16日 11:51, David Ahern wrote: Hi Jason: I am trying to test MTU changes to the BPF fib_lookup helper and seeing something odd. Hoping you can help. I have a VM with multiple virtio based NICs and tap

Re: [RFC PATCH bpf-next 05/12] xdp: add MEM_TYPE_ZERO_COPY

2018-05-17 Thread Björn Töpel
2018-05-17 7:57 GMT+02:00 Jesper Dangaard Brouer : > On Tue, 15 May 2018 21:06:08 +0200 > Björn Töpel wrote: > >> @@ -82,6 +88,10 @@ struct xdp_frame *convert_to_xdp_frame(struct xdp_buff >> *xdp) >> int metasize; >> int headroom; >> >> +

[PATCH net-next v3 01/10] net: mvpp2: align the ethtool ops definition

2018-05-17 Thread Antoine Tenart
Cosmetic patch to align the ethtool functions to ops definitions. This patch does not change in any way the driver's behaviour. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 24 1 file changed, 12 insertions(+), 12

[PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Dave, Russell, This series convert the Marvell PPv2 driver to phylink (models the MAC to PHY link). One important point is the PPv2 driver supports two probe modes: device tree and ACPI. This series only brings phylink support for the device tree mode, as the ACPI one will need further work.

[PATCH net-next v3 04/10] phy: cp110-comphy: 2.5G SGMII mode

2018-05-17 Thread Antoine Tenart
This patch allow the CP110 comphy to configure some lanes in the 2.5G SGMII mode. This mode is quite close to SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 17 ++--- 1 file

[PATCH net-next v3 09/10] arm64: dts: marvell: 8040-db: describe the 10G interfaces as fixed-link

2018-05-17 Thread Antoine Tenart
This patch adds a fixed-link node to both 10G interfaces of the 8040-db board. This is required as the mvpp2 driver now uses phylink. The best solution would have been to describe the SFP cages but they are not wired correctly, and thus unusable, so we chose to use fixed-link instead.

[PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
When allocating a xt_table_info structure, we should be clearing out the full amount of memory that was allocated, not just the "header" of the structure. Otherwise odd values could be passed to userspace, which is not a good thing. Cc: stable Signed-off-by: Greg

Re: [PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

2018-05-17 Thread Christoph Hellwig
On Thu, May 17, 2018 at 12:28:01AM -0500, Eric W. Biederman wrote: > > struct pid_namespace *proc_pid_namespace(struct inode *inode) > > { > > // maybe warn on for s_magic not on procfs?? > > return inode->i_sb->s_fs_info; > > } > > That should work. Ideally out of line for the proc_fs.h

[PATCH bpf 1/6] bpf: support 64-bit offsets for bpf function calls

2018-05-17 Thread Sandipan Das
The imm field of a bpf instruction is a signed 32-bit integer. For JIT bpf-to-bpf function calls, it stores the offset of the start address of the callee's JITed image from __bpf_call_base. For some architectures, such as powerpc64, this offset may be as large as 64 bits and cannot be accomodated

[PATCH bpf 4/6] tools: bpf: sync bpf uapi header

2018-05-17 Thread Sandipan Das
Syncing the bpf.h uapi header with tools so that struct bpf_prog_info has the two new fields for passing on the addresses of the kernel symbols corresponding to each function in a JITed program. Signed-off-by: Sandipan Das --- tools/include/uapi/linux/bpf.h | 2 ++

Re: [RFC PATCH bpf-next 05/12] xdp: add MEM_TYPE_ZERO_COPY

2018-05-17 Thread Björn Töpel
2018-05-17 9:08 GMT+02:00 Björn Töpel : > 2018-05-17 7:57 GMT+02:00 Jesper Dangaard Brouer : >> On Tue, 15 May 2018 21:06:08 +0200 >> Björn Töpel wrote: >> >>> @@ -82,6 +88,10 @@ struct xdp_frame *convert_to_xdp_frame(struct

Re: [PATCH 1/3] sh_eth: add RGMII support

2018-05-17 Thread Sergei Shtylyov
On 5/16/2018 11:37 PM, Andrew Lunn wrote: What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, Oops, totally forgot about those... :-/ Everybody does. I keep intending to write a email template for this, and

[PATCH net-next v3 06/10] net: mvpp2: 2500baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 2500Base-X PHY mode support in the Marvell PPv2 driver. 2500Base-X is quite close to 1000Base-X and SGMII modes and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 51

[PATCH net-next v3 05/10] net: mvpp2: 1000baseX support

2018-05-17 Thread Antoine Tenart
This patch adds the 1000Base-X PHY mode support in the Marvell PPv2 driver. 1000Base-X is quite close the SGMII and uses nearly the same code path. Signed-off-by: Antoine Tenart --- drivers/net/ethernet/marvell/mvpp2.c | 72 1 file

[PATCH net-next 0/3] net: mvpp2: small improvements

2018-05-17 Thread Antoine Tenart
Hi all, Those 3 patches are small improvements to the Marvell PPv2 driver. The series does not conflict with the one sent about phylink and 1000/2500baseX support, so the two series can live in parallel. Thanks! Antoine Yan Markman (3): net: mvpp2: avoid checking for free aggregated

[PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Antoine Tenart
The SFF,SFP documentation is clear about making all the DT properties, with the exception of the compatible, optional. In practice this is not the case and without an i2c-bus property provided the SFP code will throw NULL pointer exceptions. This patch is an attempt to fix this. Signed-off-by:

Re: [patch net-next RFC 00/12] devlink: introduce port flavours and common phys_port_name generation

2018-05-17 Thread Jiri Pirko
Thu, Mar 22, 2018 at 08:25:46PM CET, andrew.gospoda...@broadcom.com wrote: >On Thu, Mar 22, 2018 at 01:10:38PM -0600, David Ahern wrote: >> On 3/22/18 11:49 AM, Jiri Pirko wrote: >> > Thu, Mar 22, 2018 at 04:34:07PM CET, dsah...@gmail.com wrote: >> >> On 3/22/18 4:55 AM, Jiri Pirko wrote: >> >>>

Re: net: ieee802154: 6lowpan: fix frag reassembly

2018-05-17 Thread Greg KH
On Mon, May 14, 2018 at 05:22:18PM +0200, Stefan Schmidt wrote: > Hello. > > > Please apply f18fa5de5ba7f1d6650951502bb96a6e4715a948 > > (net: ieee802154: 6lowpan: fix frag reassembly) to the 4.16.x stable tree. > > > Earlier trees are not needed as the problem was introduced in 4.16.

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Russell King - ARM Linux
On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > Since v2: > - Removed the SFP description from the DB boards, as their SFP cages > are wired properly. We now use fixed-link. I think you mean "improperly" here. -- RMK's Patch system:

Re: [PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 10:59:51AM +0200, Michal Kubecek wrote: > On Thu, May 17, 2018 at 10:44:42AM +0200, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not just the "header" of the > >

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Eric Dumazet
On 05/17/2018 02:34 AM, Greg Kroah-Hartman wrote: > When allocating a xt_table_info structure, we should be clearing out the > full amount of memory that was allocated, not just the "header" of the > structure. Otherwise odd values could be passed to userspace, which is > not a good thing. > >

Re: linux-next: manual merge of the net-next tree with the vfs tree

2018-05-17 Thread Christoph Hellwig
> + /* Create a new file under /proc/net/ipconfig */ > + static int ipconfig_proc_net_create(const char *name, > + const struct file_operations *fops) > + { > + char *pname; > + struct proc_dir_entry *p; > + > + if (!ipconfig_dir) > + return

[PATCH net-next v3 03/10] phy: add 2.5G SGMII mode to the phy_mode enum

2018-05-17 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart Acked-by: Kishon Vijay Abraham I --- include/linux/phy/phy.h | 1 +

[PATCH net-next v3 02/10] net: mvpp2: phylink support

2018-05-17 Thread Antoine Tenart
Convert the PPv2 driver to implement phylink helpers, and use phylink in DT mode. The other mode supported is ACPI, which will need further work in order to be entirely compatible with phylink. The MAC and GoP configuration functions were completely moved to fit into the phylink helpers. When a

[PATCH net-next 2/2] net: phy: sfp: warn the user when no tx_disable pin is available

2018-05-17 Thread Antoine Tenart
In case no Tx disable pin is available the SFP modules will always be emitting. This could be an issue when using modules using laser as their light source as we would have no way to disable it when the fiber is removed. This patch adds a warning when registering an SFP cage which do not have its

[PATCH net-next v3 08/10] arm64: dts: marvell: mcbin: enable the fourth network interface

2018-05-17 Thread Antoine Tenart
This patch enables the fourth network interface on the Marvell Macchiatobin. It is configured in the 2500Base-X PHY mode. The SFP cage is also described. Signed-off-by: Antoine Tenart --- .../boot/dts/marvell/armada-8040-mcbin.dts| 32 +++ 1 file

[PATCH net-next 0/2] net: sfp: small improvements

2018-05-17 Thread Antoine Tenart
Hi Russell, This series was part of the mvpp2 phylink one but as we reworked it to use fixed-link on the DB boards, the SFP commits weren't needed anymore for our use case. Two of the three patches still are needed I believe (I ditched the one about non-wired SFP cages), so they are sent here in

[PATCH net-next v3 07/10] arm64: dts: marvell: mcbin: add 10G SFP support

2018-05-17 Thread Antoine Tenart
From: Russell King This patch adds the SFP cage description in the Marvell Armada 8040 mcbin, for both 10G interfaces. Signed-off-by: Russell King [Antoine: small reworks, commit message] Signed-off-by: Antoine Tenart

Re: [PATCH 3/3] sh_eth: add R8A77980 support

2018-05-17 Thread Simon Horman
On Wed, May 16, 2018 at 11:00:29PM +0300, Sergei Shtylyov wrote: > Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) -- > it's the only R-Car gen3 SoC having the GEther controller -- others have > only EtherAVB... > > Based on the original (and large) patch by Vladimir

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 02:55:42AM -0700, Eric Dumazet wrote: > > > On 05/17/2018 02:34 AM, Greg Kroah-Hartman wrote: > > When allocating a xt_table_info structure, we should be clearing out the > > full amount of memory that was allocated, not just the "header" of the > > structure. Otherwise

pull-request: wireless-drivers-next 2018-05-17

2018-05-17 Thread Kalle Valo
Hi Dave, here's a pull request to net-next for 4.18. I forgot to mention in the signed tag was that one id is added to include/linux/mmc/sdio_ids.h but that was acked by Ulf. I suspect hat because of my merge of wireless-drivers into wireless-drivers-next the diffstat from request-pull was wrong

Re: [PATCH] xen-netfront: fix xennet_start_xmit()'s return type

2018-05-17 Thread Juergen Gross
On 24/04/18 15:18, Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, but the implementation in this > driver returns an 'int'. > > Fix this by returning 'netdev_tx_t' in this driver too. > > Signed-off-by: Luc

Re: [PATCH 2/3] sh_eth: add EDMR.NBST support

2018-05-17 Thread Simon Horman
On Wed, May 16, 2018 at 10:58:26PM +0300, Sergei Shtylyov wrote: > The R-Car V3H (AKA R8A77980) GEther controller adds the DMA burst mode bit > (NBST) in EDMR and the manual tells to always set it before doing any DMA. > > Based on the original (and large) patch by Vladimir Barinov. > >

[PATCH] net: qcom/emac: Allocate buffers from local node

2018-05-17 Thread Hemanth Puranik
Currently we use non-NUMA aware allocation for TPD and RRD buffers, this patch modifies to use NUMA friendly allocation. Signed-off-by: Hemanth Puranik --- drivers/net/ethernet/qualcomm/emac/emac-mac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Michal Kubecek
On Thu, May 17, 2018 at 10:44:42AM +0200, Greg Kroah-Hartman wrote: > When allocating a xt_table_info structure, we should be clearing out the > full amount of memory that was allocated, not just the "header" of the > structure. Otherwise odd values could be passed to userspace, which is > not a

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Antoine Tenart
Hi Russell, On Thu, May 17, 2018 at 10:18:56AM +0100, Russell King - ARM Linux wrote: > On Thu, May 17, 2018 at 10:29:29AM +0200, Antoine Tenart wrote: > > Since v2: > > - Removed the SFP description from the DB boards, as their SFP cages > > are wired properly. We now use fixed-link. > >

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Jan Engelhardt
On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: >> > --- a/net/netfilter/x_tables.c >> > +++ b/net/netfilter/x_tables.c >> > @@ -1183,11 +1183,10 @@ struct xt_table_info *xt_alloc_table_info(unsigned >> > int size) >> > * than shoot all processes down before realizing there is

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/16/2018 01:29 PM, Toke Høiland-Jørgensen wrote: >> The ACK filter is an optional feature of CAKE which is designed to improve >> performance on links with very asymmetrical rate limits. On such links >> (which are unfortunately quite

[PATCH bpf-next v6 4/6] bpf: Split lwt inout verifier structures

2018-05-17 Thread Mathieu Xhonneux
The new bpf_lwt_push_encap helper should only be accessible within the LWT BPF IN hook, and not the OUT one, as this may lead to a skb under panic. At the moment, both LWT BPF IN and OUT share the same list of helpers, whose calls are authorized by the verifier. This patch separates the verifier

[PATCH bpf-next v6 1/6] ipv6: sr: make seg6.h includable without IPv6

2018-05-17 Thread Mathieu Xhonneux
include/net/seg6.h cannot be included in a source file if CONFIG_IPV6 is not enabled: include/net/seg6.h: In function 'seg6_pernet': >> include/net/seg6.h:52:14: error: 'struct net' has no member named 'ipv6'; did you mean 'ipv4'? return

[PATCH bpf-next v6 6/6] selftests/bpf: test for seg6local End.BPF action

2018-05-17 Thread Mathieu Xhonneux
Add a new test for the seg6local End.BPF action. The following helpers are also tested: - bpf_lwt_push_encap within the LWT BPF IN hook - bpf_lwt_seg6_action - bpf_lwt_seg6_adjust_srh - bpf_lwt_seg6_store_bytes A chain of End.BPF actions is built. The SRH is injected through a LWT BPF IN hook

[PATCH bpf-next v6 3/6] bpf: Add IPv6 Segment Routing helpers

2018-05-17 Thread Mathieu Xhonneux
The BPF seg6local hook should be powerful enough to enable users to implement most of the use-cases one could think of. After some thinking, we figured out that the following actions should be possible on a SRv6 packet, requiring 3 specific helpers : - bpf_lwt_seg6_store_bytes: Modify

Re: [PATCH 00/14] Modify action API for implementing lockless actions

2018-05-17 Thread Vlad Buslov
On Wed 16 May 2018 at 21:51, Jiri Pirko wrote: > Wed, May 16, 2018 at 11:23:41PM CEST, vla...@mellanox.com wrote: >> >>On Wed 16 May 2018 at 17:36, Roman Mashak wrote: >>> Vlad Buslov writes: >>> On Wed 16 May 2018 at 14:38, Roman

[PATCH 0/2] bpf: sockmap, fix uninitialized variable and double-free

2018-05-17 Thread Gustavo A. R. Silva
This patchset aims to fix an uninitialized variable issue and a double-free issue in __sock_map_ctx_update_elem. Both issues were reported by Coverity. Thanks. Gustavo A. R. Silva (2): bpf: sockmap, fix uninitialized variable bpf: sockmap, fix double-free kernel/bpf/sockmap.c | 3 +-- 1

[PATCH net-next 0/4] tcp: implement SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but

[PATCH net-next 4/4] tcp: add TCPAckCompressed SNMP counter

2018-05-17 Thread Eric Dumazet
This counter tracks number of ACK packets that the host has not sent, thanks to ACK compression. Sample output : $ nstat -n;sleep 1;nstat|egrep "IpInReceives|IpOutRequests|TcpInSegs|TcpOutSegs|TcpExtTCPAckCompressed" IpInReceives123250 0.0 IpOutRequests

[PATCH net-next 1/4] tcp: use __sock_put() instead of sock_put() in tcp_clear_xmit_timers()

2018-05-17 Thread Eric Dumazet
Socket can not disappear under us. Signed-off-by: Eric Dumazet --- include/net/tcp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

[PATCH net-next 3/4] tcp: add SACK compression

2018-05-17 Thread Eric Dumazet
When TCP receives an out-of-order packet, it immediately sends a SACK packet, generating network load but also forcing the receiver to send 1-MSS pathological packets, increasing its RTX queue length/depth, and thus processing time. Wifi networks suffer from this aggressive behavior, but

[PATCH net-next 2/4] tcp: do not force quickack when receiving out-of-order packets

2018-05-17 Thread Eric Dumazet
As explained in commit 9f9843a751d0 ("tcp: properly handle stretch acks in slow start"), TCP stacks have to consider how many packets are acknowledged in one single ACK, because of GRO, but also because of ACK compression or losses. We plan to add SACK compression in the following patch, we must

Re: [PATCH net-next 1/2] net: phy: sfp: make the i2c-bus property really optional

2018-05-17 Thread Andrew Lunn
On Thu, May 17, 2018 at 02:56:48PM +0200, Antoine Tenart wrote: > Hi Andrew, > > On Thu, May 17, 2018 at 02:41:28PM +0200, Andrew Lunn wrote: > > On Thu, May 17, 2018 at 10:29:06AM +0200, Antoine Tenart wrote: > > > The SFF,SFP documentation is clear about making all the DT properties, > > > with

[PATCH net-next 1/1] tc-testing: fixed copy-pasting error in ife tests

2018-05-17 Thread Roman Mashak
Reported-by: Vlad Buslov Reported-by: Davide Caratti Signed-off-by: Roman Mashak --- .../selftests/tc-testing/tc-tests/actions/ife.json | 28 +++--- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

2018-05-17 Thread Roopa Prabhu
On Wed, May 16, 2018 at 7:36 PM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 16 May 2018 13:30:28 -0700 > >> yes, but we hold rcu read lock before calling the reply function for >> fib result. I did consider allocating the skb before the

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Quentin Monnet
2018-05-16 22:04 UTC+0100 ~ Sean Young > Add support for BPF_PROG_RAWIR_EVENT. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using the

Re: [PATCH net-next v3 00/10] net: mvpp2: phylink conversion

2018-05-17 Thread Gregory CLEMENT
Hi Antoine, On jeu., mai 17 2018, Antoine Tenart wrote: > Hi Dave, Russell, > > This series convert the Marvell PPv2 driver to phylink (models the MAC > to PHY link). > > One important point is the PPv2 driver supports two probe modes: device > tree and ACPI. This

[PATCH bpf-next] bpf: change eBPF helper doc parsing script to allow for smaller indent

2018-05-17 Thread Quentin Monnet
Documentation for eBPF helpers can be parsed from bpf.h and eventually turned into a man page. Commit 6f96674dbd8c ("bpf: relax constraints on formatting for eBPF helper documentation") changed the script used to parse it, in order to allow for different indent style and to ease the work for

Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter

2018-05-17 Thread Toke Høiland-Jørgensen
Eric Dumazet writes: > On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote: > >> >> We don't do full parsing of SACKs, no; we were trying to keep things >> simple... We do detect the presence of SACK options, though, and the >> presence of SACK options on an ACK will

KASAN: use-after-free Read in vhost_chr_write_iter

2018-05-17 Thread DaeRyong Jeong
We report the crash: KASAN: use-after-free Read in vhost_chr_write_iter This crash has been found in v4.17-rc1 using RaceFuzzer (a modified version of Syzkaller), which we describe more at the end of this report. Our analysis shows that the race occurs when invoking two syscalls concurrently,

Re: STMMAC driver with TSO enabled issue

2018-05-17 Thread Jose Abreu
Hi Bhadram, On 15-05-2018 07:44, Bhadram Varka wrote: > Hi Jose, > > On 5/10/2018 9:15 PM, Jose Abreu wrote: >> >> >> On 10-05-2018 16:08, Bhadram Varka wrote: >>> Hi Jose, >>> >>> On 5/10/2018 7:59 PM, Jose Abreu wrote: Hi Bhadram, On 10-05-2018 09:55, Jose Abreu wrote: >

Re: [RFC v4 3/5] virtio_ring: add packed ring support

2018-05-17 Thread Jason Wang
On 2018年05月16日 22:33, Tiwei Bie wrote: On Wed, May 16, 2018 at 10:05:44PM +0800, Jason Wang wrote: On 2018年05月16日 21:45, Tiwei Bie wrote: On Wed, May 16, 2018 at 08:51:43PM +0800, Jason Wang wrote: On 2018年05月16日 20:39, Tiwei Bie wrote: On Wed, May 16, 2018 at 07:50:16PM +0800, Jason Wang

Re: [patch net-next] nfp: flower: set sysfs link to device for representors

2018-05-17 Thread Or Gerlitz
On Thu, May 17, 2018 at 1:05 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Do this so the sysfs has "device" link correctly set. please no This is likely to create bunch of issues with respect to how libvirt deals with the representors. We were discussing

Re: [PATCH v2] netfilter: properly initialize xt_table_info structure

2018-05-17 Thread Greg Kroah-Hartman
On Thu, May 17, 2018 at 12:42:00PM +0200, Jan Engelhardt wrote: > > On Thursday 2018-05-17 12:09, Greg Kroah-Hartman wrote: > >> > --- a/net/netfilter/x_tables.c > >> > +++ b/net/netfilter/x_tables.c > >> > @@ -1183,11 +1183,10 @@ struct xt_table_info > >> > *xt_alloc_table_info(unsigned int

[iproute2-next v3 1/1] tipc: fixed node and name table listings

2018-05-17 Thread Jon Maloy
We make it easier for users to correlate between 128-bit node identities and 32-bit node hash number by extending the 'node list' command to also show the hash number. We also improve the 'nametable show' command to show the node identity instead of the node hash number. Since the former

  1   2   3   4   >