Re: tg3 module problem with suspend2

2006-07-30 Thread Michael Chan
Lamarque Souza wrote: I have this problem since I first tried to use suspend. The first kernel I tried was 2.6.13 I guess. Since that time I reload the driver, then I do not know if it works with kernel 2.6.14, 2.6.15 or 2.6.16 without reloading. I just tried SOFTWARE_SUSPEND on

Re: [RFC 1/4] kevent: core files.

2006-07-30 Thread Ulrich Drepper
Nicholas Miell wrote: [...] and was wondering if you were familiar with the Solaris port APIs* and, I wasn't. if so, you could please comment on how your proposed event channels are different/better. There indeed is not much difference. The differences are in the details. The way those

Re: Bug#380411: 3c59x broken after swsuspend

2006-07-30 Thread maximilian attems
hello michael, sending bugreport to netdev. On Sun, 30 Jul 2006, Michael Banck wrote: Package: linux-2.6 Version: 2.6.17-4 after hibernate, my 3Com Corporation 3c556 Hurricane CardBus [Cyclone] (rev 10) (3c59x driver) fails to come back up. This is written on the console/xterm:

[2.6 patch] net/*/nf_conntrack_*.c:possible cleanups

2006-07-30 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global functions static: - net/netfilter/nf_conntrack_core.c: nf_conntrack_register_cache() - net/netfilter/nf_conntrack_core.c: nf_conntrack_unregister_cache() - net/netfilter/nf_conntrack_core.c:

Re: [PATCH] include/linux/netfilter_bridge.h: header cleanup

2006-07-30 Thread David Woodhouse
On Sat, 2006-07-29 at 11:45 +0400, Alexey Dobriyan wrote: Header doesn't use anything from atomic.h. It fixes headers_check warning: include/linux/netfilter_bridge.h requires asm/atomic.h, which does not exist Compile tested on alpha arm i386-up sparcsparc64-up x86_64

Subsystem/prefix in patch submission format

2006-07-30 Thread Ilpo Järvinen
Hi, I have read through http://linux.yyz.us/patch-format.html, which uses $subsystem as prefix for summary. Could you please clarify what is appropriate prefix for the actual summary in a case where patch touches only a part of a subsystem, that is in my case, FRTO. Should the subsystem be

Re: Regarding offloading IPv6 addrconf and ndisc

2006-07-30 Thread Hugo Santos
Hi, On the other hand, if a ND daemon loose the synchronization, it is unpredicable, I guess. What do you mean by synchronization in this context? My idea was to keep the ND state machine inside the kernel, and instead have the daemon be reactive. That means it would send messages on

Re: skge driver oops

2006-07-30 Thread Krzysztof Oledzki
On Sun, 23 Jul 2006, Krzysztof Oledzki wrote: On Fri, 26 May 2006, Stephen Hemminger wrote: Please give this a try, it rearranges the transmit buffer management, and may avoid issues with partial completions causing SKB reuse. CUT Plase excuse me, I overlooked this patch. Anyway, it

IPv6 source address selection

2006-07-30 Thread Baruch Even
Hello, My network has several IPv6 addresses and they don't route between themselves, due to the current source address selection it means that many times the network is simply not operational since Linux will choose an address for a different network than targeted for the connection. I have

Re: [PATCH] NET: fix kernel panic from no dev-hard_header_len space

2006-07-30 Thread Krzysztof Halasa
Hello Alexey, Can you clarify this for me, please? Do the semantics (I'm not talking about bugs) allow skb passed to dev-hard_header() (if defined) and then to dev-hard_start_xmit() to have less link layer header space than dev-hard_header_len? I.e., is dev-hard_header_len only advisory? --

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

2006-07-30 Thread Kyle McMartin
On Sat, Jul 29, 2006 at 06:43:39PM -0600, Grant Grundler wrote: I just wanted to warn that some of the changes are already in akpm 's tree (-mm). Becuase off hand I've forgotten which ones, would it be better to diff against -mm instead? tulip-fix-shutdown-dma-irq-race.patch tulip: fix

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

2006-07-30 Thread Andrew Morton
On Sun, 30 Jul 2006 12:56:07 -0400 Kyle McMartin [EMAIL PROTECTED] wrote: On Sat, Jul 29, 2006 at 06:43:39PM -0600, Grant Grundler wrote: I just wanted to warn that some of the changes are already in akpm 's tree (-mm). Becuase off hand I've forgotten which ones, would it be better to

[PATCH] 3x59x: fix PCI resource management

2006-07-30 Thread Sergei Shtylylov
The driver wrongly claimed I/O ports at an address returned by pci_iomap() -- even if it was passed an MMIO address. Fix this by claiming/releasing all PCI resources in the PCI driver probe/remove handlers instead and get rid of the must_free_region flag weirdness (why would Cardbus claim

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

2006-07-30 Thread Kyle McMartin
On Sun, Jul 30, 2006 at 11:35:32AM -0700, Andrew Morton wrote: hm. A couple of those patches have been futzing around in -mm for over a year and have been nacked by Jeff and are a regular source of grumpygrams. I've been sitting on them in the pathetic hope that someone will one day get down

[PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Jesper Juhl
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() We are not freeing 'tbuf' on error. Patch below fixes that. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- net/ipv4/tcp_probe.c |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) ---

Linux TCP in the presence of delays or drops...

2006-07-30 Thread Oumer Teyeb
Hi all, I have some questions regarding Linux TCP in the presence of delays or packet drops. It is somehow long mail, but the questions are two or three, just wanted to provide a detailed information so that the problem is clear. thanx for the patience!! Best regards, Oumer Note that for

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Stephen Hemminger
On Sun, 30 Jul 2006 21:38:02 +0200 Jesper Juhl [EMAIL PROTECTED] wrote: There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() We are not freeing 'tbuf' on error. Patch below fixes that. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Agreed, thanks for catching it. The

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread James Morris
On Sun, 30 Jul 2006, Stephen Hemminger wrote: On Sun, 30 Jul 2006 21:38:02 +0200 Jesper Juhl [EMAIL PROTECTED] wrote: There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() We are not freeing 'tbuf' on error. Patch below fixes that. Signed-off-by: Jesper Juhl

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Jesper Juhl
On 30/07/06, James Morris [EMAIL PROTECTED] wrote: On Sun, 30 Jul 2006, Stephen Hemminger wrote: On Sun, 30 Jul 2006 21:38:02 +0200 Jesper Juhl [EMAIL PROTECTED] wrote: There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() We are not freeing 'tbuf' on error. Patch

IBM (Lenovo) T60: e1000 driver high latency

2006-07-30 Thread Thomas Glanzmann
Hello, I recently aquired a Lenovo (IBM) T60 with a e1000 network card. I experience high latency with this networkcard: Pings last upto 1 second where the ping should be around 25 ms. I googled a bit and found the following: - Enable NAPI, which didn't worked for me. 64 bytes from

Re: [PATCH 3/23] [PATCH] [XFRM]: Add Kconfig to enable advanced transformation.

2006-07-30 Thread James Morris
On Sat, 29 Jul 2006, Masahide NAKAMURA wrote: This option is for enhanced transformation features and it will be used by Mobile IPv6. Based on MIPL2 kernel patch. --- net/xfrm/Kconfig |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/net/xfrm/Kconfig

Re: [PATCH 1/20] [PATCH] [IPV6]: Add Kconfig to enable Mobile IPv6.

2006-07-30 Thread James Morris
On Sat, 29 Jul 2006, Masahide NAKAMURA wrote: +config IPV6_MIP6 + bool IPv6: Mobility (EXPERIMENTAL) + depends on IPV6 EXPERIMENTAL + select XFRM + select XFRM_ADVANCED Why 'select' here instead of 'depends on'? The overall kernel config is getting very messed up because

Re: Subsystem/prefix in patch submission format

2006-07-30 Thread David Miller
From: Ilpo Järvinen [EMAIL PROTECTED] Date: Sun, 30 Jul 2006 14:01:09 +0300 (EEST) [TCP] FRTO: summary here This looks perfectly fine. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] NET: fix kernel panic from no dev-hard_header_len space

2006-07-30 Thread David Miller
From: Krzysztof Halasa [EMAIL PROTECTED] Date: Sun, 30 Jul 2006 18:40:04 +0200 Do the semantics (I'm not talking about bugs) allow skb passed to dev-hard_header() (if defined) and then to dev-hard_start_xmit() to have less link layer header space than dev-hard_header_len? I.e., is

Re: [PATCH 1/20] [PATCH] [IPV6]: Add Kconfig to enable Mobile IPv6.

2006-07-30 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Sun, 30 Jul 2006 18:20:46 -0400 (EDT) The overall kernel config is getting very messed up because of all of these selects. The idea is that the user should be shielded from having to know what random kernel internal subsystem is necessary in order

Re: [PATCH] include/linux/netfilter_bridge.h: header cleanup

2006-07-30 Thread David Miller
From: Alexey Dobriyan [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 11:45:45 +0400 Header doesn't use anything from atomic.h. It fixes headers_check warning: include/linux/netfilter_bridge.h requires asm/atomic.h, which does not exist Compile tested on alpha arm i386-up sparc

Re: Subsystem/prefix in patch submission format

2006-07-30 Thread Sam Ravnborg
On Sun, Jul 30, 2006 at 03:28:46PM -0700, David Miller wrote: From: Ilpo J?rvinen [EMAIL PROTECTED] Date: Sun, 30 Jul 2006 14:01:09 +0300 (EEST) [TCP] FRTO: summary here This looks perfectly fine. Looking 100 commits back or so it is obvious we have two distinct notations:

Re: [NET]: Fix ___pskb_trim when entire frag_list needs dropping

2006-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 21:45:25 +1000 [NET]: Fix ___pskb_trim when entire frag_list needs dropping When the trim point is within the head and there is no paged data, ___pskb_trim fails to drop the first element in the frag_list. This patch fixes this by

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of ip6_dst_lookup can be divided into two classes: 1) The caller holds no locks and is in user-context (UDP). 2) The caller does not want to

Re: linux- 2.6.17.7 undefined reference to `alloc_ltalkdev'

2006-07-30 Thread David Miller
From: Toralf Förster [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 20:55:11 +0200 Subject: linux- 2.6.17.7 undefined reference to `alloc_ltalkdev' Bug is that appletalk is built modular, which is where alloc_ltalkdev is exported from, but we allow users of this symbol, such as the cops driver, to be

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

2006-07-30 Thread Jeff Garzik
Andrew Morton wrote: hm. A couple of those patches have been futzing around in -mm for over a year and have been nacked by Jeff and are a regular source of grumpygrams. I've been sitting on them in the pathetic hope that someone will one day get down and address the bugs which they fix in an

Re: [parisc-linux] [git patches] tulip fixes from parisc-linux

2006-07-30 Thread Jeff Garzik
Kyle McMartin wrote: parisc-linux merged Francois' tulip workqueue patch some time ago, and have been running with it since without issue. This defers the tulip_select_media work to process context, and so should be less of an issue. Good to hear. That's definitely my preference for future

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread David Miller
From: Jesper Juhl [EMAIL PROTECTED] Date: Sun, 30 Jul 2006 23:51:20 +0200 Looks ok to me. I've applied James's version of the fix, thanks everyone. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Subsystem/prefix in patch submission format

2006-07-30 Thread David Miller
From: Sam Ravnborg [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 00:45:43 +0200 From a pure eye-candy perspective it would be nice to use same format all over. From Documentation/SubmittingPatches: -- 12) The canonical patch format The canonical patch subject line is:

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-07-30 Thread Russell Stuart
On Thu, 2006-07-20 at 14:56 +1000, Russell Stuart wrote: On Wed, 2006-07-19 at 16:50 +0200, Patrick McHardy wrote: Please excuse my silence, I was travelling and am still catching up with my mails. Sorry. Had I realised you were busy I would of waited. - As it stands, it doesn't

Re: [PATCH 7/23] [PATCH] [XFRM] STATE: Add a hook to find where to be inserted header in outbound.

2006-07-30 Thread James Morris
On Sat, 29 Jul 2006, Masahide NAKAMURA wrote: - hdr_len = ip6_find_1stfragopt(skb, prevhdr); + if (x-type-place_find) + hdr_len = x-type-place_find(x, skb, prevhdr); + else + hdr_len = ip6_find_1stfragopt(skb,

Re: [PATCH 8/23] [PATCH] [XFRM] STATE: Add a hook to obtain local/remote outbound address.

2006-07-30 Thread James Morris
On Sat, 29 Jul 2006, Masahide NAKAMURA wrote: + remote = (xfrm[i]-type-remote_addr) ? + (struct in6_addr*)xfrm[i]-type-remote_addr(xfrm[i], (xfrm_address_t *)remote): + (struct in6_addr*)xfrm[i]-id.daddr; +

Re: Runtime power management for network interfaces

2006-07-30 Thread Randy.Dunlap
On Tue, 25 Jul 2006 09:20:06 -0700 Auke Kok wrote: Alan Stern wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend their devices (if possible) whenever: (1) The interface is

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread Matt Domsch
On Sun, Jul 30, 2006 at 03:44:16PM -0700, David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of ip6_dst_lookup can be divided into two classes: 1) The caller holds no

Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes

2006-07-30 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 18:25:34 +0900 (JST) Changesets, on top of 2.6.18-rc2, are available on branch addr-lifetime-20060728b at: git://git.skbuff.net/gitroot/yoshfuji/linux-2.6.18-rc2-addr-lifetime Pulled, thank you very much. - To unsubscribe

Re: [PATCH] SNMPv2 tcpAttemptFails counter error

2006-07-30 Thread David Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 07:40:37 -0400 I have changed my patch with your advice and it looks more effective. ... Signed-off-by: Wei Yongjun [EMAIL PROTECTED] This looks very nice, patch applied. Thank you very much. - To unsubscribe from this list: send the

Re: [PATCH][SECURITY] secmark: nul-terminate secdata

2006-07-30 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 17:00:15 -0400 (EDT) The patch below fixes a problem in the iptables SECMARK target, where the user-supplied 'selctx' string may not be nul-terminated. Applied, thanks James. - To unsubscribe from this list: send the line unsubscribe

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-30 Thread David Miller
From: Ben Greear [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 14:55:17 -0700 The skb_bond method assigns skb-dev when it does the 'keep', but the VLAN code immediately over-writes the skb-dev when searching for the vlan device. What is the purpose of assinging skb-dev to the master device?

Re: [PATCH Round 5 0/3] Network Event Notifier Mechanism

2006-07-30 Thread David Miller
From: Steve Wise [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 13:28:49 -0500 Dave/Roland, is this patchset about ready to go? All 3 patches applied, thanks Steve. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [XFRM]: Fix protocol field value for outgoing IPv6 GSO packets

2006-07-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 06:06:37 +0200 Herbert Xu wrote: On Tue, Jul 25, 2006 at 02:09:26AM +0200, Patrick McHardy wrote: [XFRM]: Fix protocol field value for outgoing IPv6 GSO packets Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Acked-by:

Re: Subsystem/prefix in patch submission format

2006-07-30 Thread Sam Ravnborg
On Sun, Jul 30, 2006 at 03:59:56PM -0700, David Miller wrote: From: Sam Ravnborg [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 00:45:43 +0200 From a pure eye-candy perspective it would be nice to use same format all over. From Documentation/SubmittingPatches: -- 12) The

BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread David Coulson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This machine has four NICs running the e1000 kernel module. Other than the BUG() messages, it seems to be running fine. I was running 2.6.15.4 without any issues on the same hardware, although I noticed the e1000 has been updated (and I went for rc3

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread Patrick McHardy
David Coulson wrote: This machine has four NICs running the e1000 kernel module. Other than the BUG() messages, it seems to be running fine. I was running 2.6.15.4 without any issues on the same hardware, although I noticed the e1000 has been updated (and I went for rc3 since I was hitting the

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-30 Thread Matt Domsch
On Sun, Jul 30, 2006 at 10:32:10PM -0500, Matt Domsch wrote: On Sun, Jul 30, 2006 at 03:44:16PM -0700, David Miller wrote: From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 29 Jul 2006 14:33:25 +1000 [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls The current users of

eth2.100: received packet with own address as source address

2006-07-30 Thread David Coulson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I have a machine running 2.6.18-rc3 with a bridge config that looks like this: cr1:~# brctl show bridge name bridge id STP enabled interfaces vlan100 36b0.0007e90f40c1 yes eth0.100

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread Andrew Morton
On Mon, 31 Jul 2006 00:16:21 -0400 David Coulson [EMAIL PROTECTED] wrote: This machine has four NICs running the e1000 kernel module. Other than the BUG() messages, it seems to be running fine. I was running 2.6.15.4 without any issues on the same hardware, although I noticed the e1000 has

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 06:24:31 +0200 This is a known problem with NAT and HW checksum and will probably get fixed in 2.6.19. I would like to see this fixed for 2.6.18, no later. Either that or disable the bug trap, but taking this route is severely

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread Patrick McHardy
David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 06:24:31 +0200 This is a known problem with NAT and HW checksum and will probably get fixed in 2.6.19. I would like to see this fixed for 2.6.18, no later. Either that or disable the bug trap, but

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-07-30 Thread David Coulson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Now, I started the heartbeat process on the same machine, and it blew up trying to do something with IPaddr. I can't even sysrq the box back into life at this point :-/ BUG: unable to handle kernel paging request at virtual address 9e045900 printing