On Thu, 20 Dec 2007, David Miller wrote:
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 13:40:51 +0200 (EET)
[PATCH] [TCP]: Fix TSO deferring
I'd say that most of what tcp_tso_should_defer had in between
there was dead code because of this.
Signed-off-by: Ilpo
YOSHIFUJI Hideaki / 吉藤英明 a écrit :
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 08:06:32 +0100), Eric Dumazet
[EMAIL PROTECTED] says:
YOSHIFUJI Hideaki / 吉藤英明 a écrit :
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet
[EMAIL PROTECTED] says:
Because
Since 'goal' is a signed int, compiler may emit an integer divide
to compute goal/2.
Using a right shift is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index e35076e..10915bb 100644
--- a/net/ipv4/route.c
+++
On 21-12-2007 03:24, Satoru SATOH wrote:
2007/12/21, Jarek Poplawski [EMAIL PROTECTED]:
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
but since it's your patch, I hope you do some additional checking
if it's always like this...
...or maybe only changing this all a little bit will make
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 11:24:54 +0900), Satoru
SATOH [EMAIL PROTECTED] says:
2007/12/21, Jarek Poplawski [EMAIL PROTECTED]:
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
but since it's your patch, I hope you do some additional checking
if it's always
nl_fib_input re-reuses incoming skb to send the reply. This means that this
packet will be freed twice, namely in:
- netlink_unicast_kernel
- on receive path
Use clone to send as a cure, the caller is responsible for kfree_skb on error.
Thanks to Alexey Dobryan, who originally found the problem.
On Fri, 21 Dec 2007, Bill Fink wrote:
I meant to ask about this a while back but then got distracted by
other things. But now since the subject has come up, I had a couple
of more questions about this code.
What's with all the shifting back and forth? Here with:
((jiffies1)1) -
Hi David,
On Fri, 14 Dec 2007 01:48:52 -0500
David Woodhouse [EMAIL PROTECTED] wrote:
--- linux-2.6.23.ppc64/drivers/net/ps3_gelic_net.c~ 2007-12-14
01:31:50.0 -0500
+++ linux-2.6.23.ppc64/drivers/net/ps3_gelic_net.c2007-12-14
01:39:25.0 -0500
@@ -1139,7
From: Bill Fink [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 03:06:48 -0500
What's with all the shifting back and forth? Here with:
((jiffies1)1) - (tp-tso_deferred1)
and later with:
/* Ok, it looks like it is advisable to defer. */
tp-tso_deferred = 1 | (jiffies1);
On Fri, 21 Dec 2007, Ilpo Järvinen wrote:
On Fri, 21 Dec 2007, Bill Fink wrote:
If so it seems like a lot of unnecessary
work just to avoid a 1 in 4 billion event, since it's my understanding
that the whole tcp_tso_should_defer function is just an optimization
and not a criticality to
On Fri, Dec 21, 2007 at 01:27:20AM -0800, David Miller wrote:
It's two shifts, and this gets scheduled along with the other
instructions on many cpus so it's effectively free.
I don't see why this is even worth mentioning and discussing.
I totally agree. Two shifts are way better than a
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 12:00:43 +0300
nl_fib_input re-reuses incoming skb to send the reply. This means that this
packet will be freed twice, namely in:
- netlink_unicast_kernel
- on receive path
Use clone to send as a cure, the caller is responsible
David Miller wrote:
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 12:00:43 +0300
nl_fib_input re-reuses incoming skb to send the reply. This means that this
packet will be freed twice, namely in:
- netlink_unicast_kernel
- on receive path
Use clone to send as a cure, the
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 08:39:24 +0100
I didnt chose this path, because David was against changing some
fields from 'int' to 'unsigned'. If you look in other parts of
networking, we have many 1 or 2 already there.
I don't remember making this statement,
From: YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 16:48:11 +0900 (JST)
Several length variables cannot be negative, so convert int to
unsigned int. This also allows us to do sane shift operations
on those variables.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
From: Denis V. Lunev [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 12:39:36 +0300
David Miller wrote:
What introduced this bug? This code didn't have this
problem previously.
commit cd40b7d3983c708aabe3d3008ec64ffce56d33b0
Author: Denis V. Lunev [EMAIL PROTECTED]
Date: Wed Oct 10 21:15:29
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 07:18:40 +0100
Because sk_wmem_queued, sk_sndbuf are signed, a divide per two
forces compiler to use an integer divide. We can instead use
a right shift.
SK_STREAM_MEM_QUANTUM deserves to be declared as an unsigned
quantity, so
-- Forwarded message --
From: Sourav Chakraborty [EMAIL PROTECTED]
Date: Dec 21, 2007 1:28 PM
Subject: Increasing initial cwnd size
To: [EMAIL PROTECTED]
Hello,
We are trying to test with kernel version 2.6.20,the RFC 3390
implementation of increased initial congestion window
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 09:20:50 +0100
Since 'goal' is a signed int, compiler may emit an integer divide
to compute goal/2.
Using a right shift is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
Applied, thanks.
--
To
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 17:29:27 +0800
On Fri, Dec 21, 2007 at 01:27:20AM -0800, David Miller wrote:
It's two shifts, and this gets scheduled along with the other
instructions on many cpus so it's effectively free.
I don't see why this is even worth
From: Paul Moore [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 16:42:25 -0500
This patch adds a number of new IPsec audit events to meet the auditing
requirements of RFC4303. This includes audit hooks for the following events:
* Could not find a valid SA [sections 2.1, 3.4.2]
.
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 06:56:17 +0100
Before submiting a patch to change a divide to a right shift, I felt
necessary to create a helper function tcp_mtu_probing() to reduce length of
lines exceeding 100 chars in tcp_write_timeout().
Signed-off-by: Eric
[ACKVEC]: Need to ignore Ack Vectors on request sockets
This fixes an oversight (mine) from an earlier patch and is in principle a
bug-fix, although the bug will with the current code not become visible.
The issue is that Ack Vectors must not be parsed on request sockets, since
the Ack Vector
On Fri, 21 Dec 2007, David Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 17:29:27 +0800
On Fri, Dec 21, 2007 at 01:27:20AM -0800, David Miller wrote:
It's two shifts, and this gets scheduled along with the other
instructions on many cpus so it's
From: Evgeniy Polyakov [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 13:34:12 +0300
Yep, I saw him couple of times and will try to contact.
:-)
Do not unsubscribe me :)
Ok!
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
On Thu, Dec 20, 2007 at 08:34:59PM -0800, David Miller ([EMAIL PROTECTED])
wrote:
If someone has a way other than email to contact Evgeniy, could
you please let him know that his email is bouncing in strange
ways.
Yep, I saw him couple of times and will try to contact.
I'll have to
On Fri, 21 Dec 2007 01:55:43 -0800 (PST)
David Miller [EMAIL PROTECTED] wrote:
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 07:18:40 +0100
Because sk_wmem_queued, sk_sndbuf are signed, a divide per two
forces compiler to use an integer divide. We can instead use
a right
On Fri, 21 Dec 2007, YOSHIFUJI Hideaki wrote:
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 11:24:54 +0900), Satoru
SATOH [EMAIL PROTECTED] says:
2007/12/21, Jarek Poplawski [EMAIL PROTECTED]:
Jarek Poplawski wrote, On 12/20/2007 09:24 PM:
...
but since it's your patch, I
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Wed, 19 Dec 2007 15:30:03 +0200 (EET)
On Wed, 19 Dec 2007, Gavin McCullagh wrote:
Will do. I gather I should use the latest net- tree in future when
submitting patches.
Doh, I owe you apology as I was probably too hasty to point you towards
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 11:40:51 +0100
On Fri, 21 Dec 2007 01:55:43 -0800 (PST)
David Miller [EMAIL PROTECTED] wrote:
Please tell me if you are OK with this solution, or if you prefer
I change sk_forward_alloc to be unsigned :)
When I was playing with
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 06:26:48 -0500
YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 07:03:58 +0100), Eric
Dumazet [EMAIL PROTECTED] says:
Because tot_len is signed in tcp_v6_send_ack(), tot_len/4 forces compiler
Greg KH [EMAIL PROTECTED] writes:
On Sat, Dec 01, 2007 at 02:06:58AM -0700, Eric W. Biederman wrote:
Now that we have network namespace support merged it is time to
revisit the sysfs support so we can remove the dependency on !SYSFS.
snip
Oops, I forgot to apply this to my tree. Eric,
On Friday 21 December 2007 4:43:10 am David Miller wrote:
From: Paul Moore [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 16:42:25 -0500
This patch adds a number of new IPsec audit events to meet the auditing
requirements of RFC4303. This includes audit hooks for the following
events:
*
Em Fri, Dec 21, 2007 at 04:30:26AM -0800, David Miller escreveu:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 10:23:16 -0200
Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu:
+static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct
David Miller [EMAIL PROTECTED] wrote:
When I was playing with this crap a long time ago I
think I remember that sk-sk_forward_alloc can become
negative in some circumstances.
Or maybe that was just a bug :-)
Yeah we had a few bugs there in the early days of TSO but it's
been quiet for the
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 14:32:41 +0100
tcp_mtu_to_mss() being signed, compiler might emit an integer divide
to compute tcp_mtu_to_mss()/2 .
Using a right shift is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
Applied, thanks
Arjan van de Ven [EMAIL PROTECTED] writes:
Rank 8: __change_page_attr
BUG at arch/x86/mm/pageattr_64.c:176
Reported 2 times
Reported this week for 2.6.24-rc5; history goes back to 2.6.15
There is no BUG on this line on 2.6.24-rc5. Since there are many
BUG_ONs in
Huh? Do you mean a PIX blade in a Cisco switch-router chassis? It
would be very useful if you could be less vague about the
equipment in use.
Right it's a PIX blade in Cisco chassis. The PIX is running ASA version 7.0(6)
That depends more on your customers' networking attributes
then
On Friday 21 December 2007 8:27:23 am Paul Moore wrote:
On Friday 21 December 2007 4:43:10 am David Miller wrote:
From: Paul Moore [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 16:42:25 -0500
This patch adds a number of new IPsec audit events to meet the auditing
requirements of RFC4303.
I agree.
I mistakenly thought hz in that context must be larger than 1000..
As it's uncertain, your's looks much simpler and better.
(btw, the lines else div = 1 is not needed, is it?)
Thanks,
Satoru SATOH
2007/12/21, YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED]:
(snip)
Why don't you
tcp_mtu_to_mss() being signed, compiler might emit an integer divide
to compute tcp_mtu_to_mss()/2 .
Using a right shift is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c
index ea111e9..ea85bc0 100644
---
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 10:23:16 -0200
Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu:
+static void tcp_mtu_probing(struct inet_connection_sock *icsk, struct sock
*sk)
+{
+ int mss;
- int mss;
+
Em Fri, Dec 21, 2007 at 06:56:17AM +0100, Eric Dumazet escreveu:
Before submiting a patch to change a divide to a right shift, I felt
necessary to create a helper function tcp_mtu_probing() to reduce length of
lines exceeding 100 chars in tcp_write_timeout().
Signed-off-by: Eric Dumazet
David Miller wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 06:26:48 -0500
YOSHIFUJI Hideaki / 吉藤英明 wrote:
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 07:03:58 +0100), Eric Dumazet
[EMAIL PROTECTED] says:
Because tot_len is signed in tcp_v6_send_ack(), tot_len/4
While checking Gavin's patch I noticed that the returned seq_rtt
is not used by the caller.
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
I think it shouldn't introduce new conflicts between net-2.6.25 and
net-2.6 (tested with git-am -3 to both).
net/ipv4/tcp_input.c |7 ++-
1
On Friday 21 December 2007 9:02:41 am David Miller wrote:
From: Paul Moore [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 08:51:22 -0500
Ah, looks like I may not be crazy after all! It looks like the XFRM
patches from Masahide NAKAMURA were pulled into net-2.6.25 just before
mine last night
These two patches are coming from Eric Biederman patchset
to make the neighbouring aware of the namespaces.
The description in the patch headers is big enough to add
more comments here :)
Changelog:
v2 :
fixed bad coding style
v1 :
initial post
--
--
To unsubscribe from
I'm actually surprised at how much was involved. At first glance it appears
that the neighbour table data structures are already split by network device
so all that should be needed is to modify the user interface commands
to filter the set of neighbours by the network namespace of their devices.
Hi David
This is the last one of this boring patch suite.
I prefered to not change sk_forward_alloc type, I prefer to wait
18 months more before taking this responsibility :)
Merry Christmas everybody
Eric
[SOCK] Avoid divides in sk_stream_pages() and __sk_stream_mem_reclaim()
It's spelled unsigned.
Signed-off-by: Paul Moore [EMAIL PROTECTED]
---
net/ipv4/tcp_ipv4.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 9cb92b8..9aea88b 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 22:49:59 +0900), Satoru
SATOH [EMAIL PROTECTED] says:
I agree.
I mistakenly thought hz in that context must be larger than 1000..
As it's uncertain, your's looks much simpler and better.
(btw, the lines else div = 1 is not needed, is
On Fri, 21 Dec 2007, David Miller wrote:
When Gavin respins the patch I'll look at in the context of submitting
it as a bug fix. So Gavin please generate the patch against Linus's
vanilla GIT tree or net-2.6, your choise.
The existing patch was against Linus' linux-2.6.git from a few days
This patch adds a number of new IPsec audit events to meet the auditing
requirements of RFC4303. This includes audit hooks for the following events:
* Could not find a valid SA [sections 2.1, 3.4.2]
. xfrm_audit_state_notfound()
. xfrm_audit_state_notfound_simple()
* Sequence number
Based on the net-2.6.25 tree from about an hour ago. The first patch was
dropped because it is already applied.
--
paul moore
linux security @ hp
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
David, I failed to include this statistics codes since I didn't notice
the conflict with the latest Herbert XFRM fix.
Please apply this, too.
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
net/xfrm/xfrm_output.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff
From: Paul Moore [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 08:47:13 -0500
It's spelled unsigned.
Signed-off-by: Paul Moore [EMAIL PROTECTED]
Applied, thanks.
I swore I did an allmodconfig test build with that change
added, looks like I didn't :-/
--
To unsubscribe from this list: send the
From: Paul Moore [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 08:51:22 -0500
Ah, looks like I may not be crazy after all! It looks like the XFRM patches
from Masahide NAKAMURA were pulled into net-2.6.25 just before mine last
night which caused my patches to conflict ...
Sorry. I had double
From: Eric Dumazet [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 15:05:51 +0100
tcp_win_from_space() being signed, compiler might emit an integer divide
to compute tcp_win_from_space()/2 .
Using right shifts is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
Applied,
From: Gavin McCullagh [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 13:31:06 +
On Fri, 21 Dec 2007, David Miller wrote:
When Gavin respins the patch I'll look at in the context of submitting
it as a bug fix. So Gavin please generate the patch against Linus's
vanilla GIT tree or net-2.6,
On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote:
do {
err = xfrm_state_check_space(x, skb);
- if (err)
+ if (err) {
+ XFRM_INC_STATS(LINUX_MIB_XFRMOUTERROR);
goto error_nolock;
+
tcp_win_from_space() being signed, compiler might emit an integer divide
to compute tcp_win_from_space()/2 .
Using right shifts is OK here and less expensive.
Signed-off-by: Eric Dumazet [EMAIL PROTECTED]
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 6931946..145b51a 100644
---
On Fri, 21 Dec 2007, Gavin McCullagh wrote:
On Fri, 21 Dec 2007, David Miller wrote:
When Gavin respins the patch I'll look at in the context of submitting
it as a bug fix. So Gavin please generate the patch against Linus's
vanilla GIT tree or net-2.6, your choise.
The existing patch
On Fri, 21 Dec 2007, Ilpo Järvinen wrote:
On Fri, 21 Dec 2007, Gavin McCullagh wrote:
I'm just checking through the existing CA modules. I don't see the rtt
used for RTO anywhere. This is what I gather they're each using rtt for.
I meant more timeout like fashion (e.g., to timeout
Rank 2: uart_flush_buffer
Warning at drivers/serial/serial_core.c:544 in uart_flush_buffer()
Reported 16 times
No specific version information reported; bug present in 2.6.24-rc5
Caused by a bug in the Bluetooth line discipline/tty code
Rank 7: uart_write
On Fri, 2007-12-21 at 16:48 +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 93980c3..3b4169c 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -985,7 +985,7 @@ static void tcp_v6_send_reset(struct sock *sk, struct
sk_buff *skb)
Andi Kleen wrote:
Arjan van de Ven [EMAIL PROTECTED] writes:
Rank 8: __change_page_attr
BUG at arch/x86/mm/pageattr_64.c:176
Reported 2 times
Reported this week for 2.6.24-rc5; history goes back to 2.6.15
There is no BUG on this line on 2.6.24-rc5. Since
Prevent unloading mii bus driver module when other modules have references to
some
phydevs on that bus. Added a new member (module owner) to struct mii_bus and
added
code to increment the mii bus owner module usage count on phy_connect and
decrement
it on phy_disconnect
Set the module owner in
Hello David,
I'm sorry, the previous mail contains wrong code:
David, I failed to include this statistics codes since I didn't notice
the conflict with the latest Herbert XFRM fix.
Please apply this, too.
Signed-off-by: Masahide NAKAMURA [EMAIL PROTECTED]
---
[snip]
do {
According to RFC4303, section 3.3.3 we need to drop outgoing packets which
cause the replay counter to overflow:
3.3.3. Sequence Number Generation
The sender's counter is initialized to 0 when an SA is established.
The sender increments the sequence number (or ESN) counter for this
Split ucc_geth_driver into 2 modules:
- one module for the mii bus (phy devices register to this bus).
- one module for the ethernet driver (uses phy_connect to get a phydev
from the mii bus)
Updated Makefile, Kconfig files and defconfigs (mpc836x, mpc832x_mds,
mpc832x_rdb).
In the presence of multiple network namespaces the logic needed
to allocate the a default parameter table is just barely non-trivial.
So add a function to automate it to make everyone's life easier.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
Signed-off-by: Daniel Lezcano [EMAIL PROTECTED]
in this case this is really all the version information available ;(
it seems to be a patched kernel without patched EXTRAVERSION.
But in the future if I have more specific information (eg it's only 1
kernel version) I'll mention it in more detail.
It gets unwieldy if there's 500 reports for
This is a resubmission of a new driver for Solarflare network controllers.
The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six
different 10G and 1G boards.
The previous thread was:
[PATCH] [RFC] New driver sfc for Solarstorm SFC4000 controller
On Fri, 21 Dec 2007 22:58:04 +0900 (JST)
YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote:
In article [EMAIL PROTECTED] (at Fri, 21 Dec 2007 22:49:59 +0900), Satoru
SATOH [EMAIL PROTECTED] says:
I agree.
I mistakenly thought hz in that context must be larger than 1000..
As it's
On Mon, 17 Dec 2007 16:06:38 +0300
Vitaliy Gusev [EMAIL PROTECTED] wrote:
get_link_kind() fails for statically linked modules (vlan, veth, etc.) if
ip
was linked without export-dynamic.
Signed-off-by: Vitaliy Gusev [EMAIL PROTECTED]
applied thanks
--
Stephen Hemminger [EMAIL
On Tue, 18 Dec 2007 15:15:38 +0300
Vitaliy Gusev [EMAIL PROTECTED] wrote:
module link_veth
Signed-off-by: Vitaliy Gusev [EMAIL PROTECTED]
---
Applied both patches, and moved veth.h from ip/veth.h to include/net/veth.h
so that the header file will be correctly updated if ABI changes.
On Fri, 21 Dec 2007 16:53:40 + Robert Stonehouse wrote:
This is a resubmission of a new driver for Solarflare network controllers.
The driver supports several types of PHY (10Gbase-T, XFP, CX4) on six
different 10G and 1G boards.
The previous thread was:
[PATCH] [RFC] New driver
On Thu, 2007-12-20 at 20:39 -0800, David Miller wrote:
Michael, please fix this, thanks :-)
drivers/net/bnx2.c: In function 'bnx2_init_napi':
drivers/net/bnx2.c:7329: warning: no return statement in function returning
non-void
[BNX2]: Fix compiler warning.
Change bnx2_init_napi() to
Hi David,
David Miller schrieb:
inet_timewait_sock begins with a struct sock_common
which is where the atomic_t is, and:
#define tw_refcnt __tw_common.skc_refcnt
So you would have to change struct sock_common over to kref, and thus
the entire networking, in order to make such
Randy Dunlap wrote:
On Fri, 21 Dec 2007 16:53:40 + Robert Stonehouse wrote:
This is a resubmission of a new driver for Solarflare network controllers.
snip
The last two patches were marked with RFC but I now think that this driver
is ready (withstanding any further review comments)
iproute2 source uses headers that result from make headers_install.
The header files net/tcp_states.h and net/veth.h are both being used
but are not processed.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
This patch is not urgent but it would be good to get it in 2.6.24.
---
On Fri, 21 Dec 2007, Bill Fink wrote:
Or perhaps even:
/* Ok, it looks like it is advisable to defer. */
tp-tso_deferred = jiffies;
/* need to return a non-zero value to defer, which means won't
* defer if jiffies == 0 but it's only a 1 in 4 billion event
On Thu, 20 Dec 2007, David Miller wrote:
From: Herbert Xu [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 22:00:12 +0800
On Thu, Dec 20, 2007 at 04:00:37AM -0800, David Miller wrote:
In the most ideal sense, tcp_window_allows() should probably
be changed to only return MSS multiples.
On Fri, 21 Dec 2007, Bill Fink wrote:
On Fri, 21 Dec 2007, Bill Fink wrote:
Or perhaps even:
/* Ok, it looks like it is advisable to defer. */
tp-tso_deferred = jiffies;
/* need to return a non-zero value to defer, which means won't
* defer if jiffies == 0 but
On Fri, 21 Dec 2007, Ilpo Järvinen wrote:
How about this, I had to use another approach due to reasons
outlined in the commit message:
--
[PATCH] [TCP]: Force TSO splits to MSS boundaries
If snd_wnd - snd_nxt wasn't multiple of MSS, skb was split on
odd boundary by the callers of
On Fri, 21 Dec 2007, Ilpo Järvinen wrote:
On Fri, 21 Dec 2007, Bill Fink wrote:
On Fri, 21 Dec 2007, Bill Fink wrote:
Or perhaps even:
/* Ok, it looks like it is advisable to defer. */
tp-tso_deferred = jiffies;
/* need to return a non-zero value to defer, which
Tested-by: Emil Medve [EMAIL PROTECTED]
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Nicu Ioan Petru
Sent: Friday, December 21, 2007 7:57 AM
To: netdev@vger.kernel.org
Cc: Nicu Ioan Petru
Subject: [PATCH 1/2] ucc_geth: split ucc_geth into two
Tested-by: Emil Medve [EMAIL PROTECTED]
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of Nicu Ioan Petru
Sent: Friday, December 21, 2007 7:58 AM
To: netdev@vger.kernel.org
Cc: Nicu Ioan Petru
Subject: [PATCH 2/2] phylib: add module owner to the
[ETH]: Combine format_addr() with print_mac().
print_mac() used by most net drivers and format_addr() used by
net-sysfs.c are very similar and they can be integrated.
format_addr() is also identically redefined in the qla4xxx iscsi
driver.
Export a new function format_mac_addr() to be used by
From: Paul Moore [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 09:15:00 -0500
According to RFC4303, section 3.3.3 we need to drop outgoing packets which
cause the replay counter to overflow:
3.3.3. Sequence Number Generation
The sender's counter is initialized to 0 when an SA is
From: Paul Moore [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 09:14:55 -0500
This patch adds a number of new IPsec audit events to meet the auditing
requirements of RFC4303. This includes audit hooks for the following events:
* Could not find a valid SA [sections 2.1, 3.4.2]
.
On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote:
[ETH]: Combine format_addr() with print_mac().
print_mac() used by most net drivers and format_addr() used by
net-sysfs.c are very similar and they can be integrated.
format_addr() is also identically redefined in the qla4xxx iscsi
From: Michael Chan [EMAIL PROTECTED]
Date: Fri, 21 Dec 2007 10:34:15 -0800
[BNX2]: Fix compiler warning.
Change bnx2_init_napi() to void.
Warning was noted by DaveM.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Applied, thanks!
--
To unsubscribe from this list: send the line
On Fri, 21 Dec 2007 15:57:31 +0200
Ionut Nicu [EMAIL PROTECTED] wrote:
Prevent unloading mii bus driver module when other modules have references to
some
phydevs on that bus. Added a new member (module owner) to struct mii_bus and
added
code to increment the mii bus owner module usage
David Miller wrote:
From: Hideo AOKI [EMAIL PROTECTED]
Date: Thu, 20 Dec 2007 23:18:54 -0500
Also, the memory accounting is done at different parts in
the socket code paths for stream vs. datagram. This is why
everything is inconsistent, and, a mess.
Could you tell me more detailed
This is part of a large patchset which finally fixes labeled networking,
which we're hoping to get into 2.6.25.
Thread @ http://thread.gmane.org/gmane.linux.kernel.lsm/4894
The patch below is the only one which is not self-contained impacts on
core networking code.
If anyone has any
Reduce the amount of locking in the TX path. Instead of using both
netif_tx_lock and dev-priv-lock on transmitting, a single private lock
(dev-priv-tx_lock) is used. This method is similar to that of the e1000
driver, including the logic to stop the queue in the start xmit functions, and
the
Subject: [XFRM] Documentaion: Fix error example at XFRMOUTSTATEMODEERROR. (Re:
[XFRM]: Fix outbound statistics.)
Hello,
On Fri, 21 Dec 2007 23:11:11 +0800
Herbert Xu [EMAIL PROTECTED] wrote:
On Fri, Dec 21, 2007 at 11:25:00PM +0900, Masahide NAKAMURA wrote:
do {
err =
On Fri, 21 Dec 2007 17:41:34 -0800 (PST)
[EMAIL PROTECTED] (Tom Herbert) wrote:
Reduce the amount of locking in the TX path. Instead of using both
netif_tx_lock and dev-priv-lock on transmitting, a single private lock
(dev-priv-tx_lock) is used. This method is similar to that of the e1000
On Fri, 2007-12-21 at 14:36 -0800, Joe Perches wrote:
On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote:
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 6b2e454..f760d41 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -359,10 +359,33 @@ struct net_device
1 - 100 of 117 matches
Mail list logo
