Re: [PATCH] net: tulip: update MAINTAINER status to Orphan

On 20.11.2015 03:41, Grant Grundler wrote: > On Thu, Nov 19, 2015 at 6:29 PM, Florian Fainelli > wrote: >> On 19/11/15 17:56, Grant Grundler wrote: >>> From: Grant Grundler >>> >>> I haven't had any PCI tulip HW for the past ~5 years. I have >>> been reviewing tulip patches and can continue doin

rhashtable: how to deal with that rhashtable_lookup_insert_key return -EBUSY

when I use rhashtable_lookup_insert_key, sometimes it will return -EBUSY. im not sure if there is a good way to workabout it. or I should just try again and again until it's inserted successfully ? I have seen some use in kernel by now, but it seems that no one consider this issue for their cases

RE: [PATCH] e1000e: fix division by zero on jumbo MTUs

> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Leonid Bloch > Sent: Tuesday, October 13, 2015 2:48 AM > To: linux-ker...@vger.kernel.org > Cc: Kirsher, Jeffrey T ; Brandeburg, Jesse > ; Nelson, Shannon > ; Wyborny, Carolyn > ; Skidmore, Donald C > ; Vick,

Re: [PATCH 2/7] kernfs: implement kernfs_walk_and_get()

On Thu, Nov 19, 2015 at 01:52:46PM -0500, Tejun Heo wrote: > Implement kernfs_walk_and_get() which is similar to > kernfs_find_and_get() but can walk a path instead of just a name. > > v2: Use strlcpy() instead of strlen() + memcpy() as suggested by > David. > > Signed-off-by: Tejun Heo > Cc

RE: [Intel-wired-lan] [PATCH v2] igb: improve handling of disconnected adapters

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Jarod Wilson > Sent: Monday, October 19, 2015 8:52 AM > To: linux-ker...@vger.kernel.org > Cc: netdev@vger.kernel.org; Jarod Wilson ; intel-wired- > l...@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH v2]

[PATCH] [V2] net: fsl: expands dependencies of NET_VENDOR_FREESCALE

From: Shaohui Xie Freescale hosts some ARMv8 based SoCs, and a generic convention ARCH_LAYERSCAPE is used to cover such SoCs. Adding ARCH_LAYERSCAPE to dependencies of NET_VENDOR_FREESCALE to support networking on those SoCs. The ARCH_LAYERSCAPE is introduced by: commit: 53a5fde05 arm64: Use gen

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

On Thu, Nov 19, 2015 at 09:12:30PM +0100, Hannes Frederic Sowa wrote: > On Thu, Nov 19, 2015, at 19:32, Alexei Starovoitov wrote: > > On Thu, Nov 19, 2015 at 07:19:24PM +0100, Hannes Frederic Sowa wrote: > > > On Thu, Nov 19, 2015, at 11:56, Daniel Borkmann wrote: > > > > Add a handler for show_fdi

Re: Hit regression with TCP_TW REUSE/RECYCLE

Eric, On Tue, Nov 17, 2015 at 8:07 PM, Eric Dumazet wrote: > On Tue, 2015-11-17 at 14:35 +0800, Ethan Zhao wrote: >> Tested the same case with 4.4-RC1, it was fixed in 4.4-RC1. >> But don't know which commit fixed it. >> >> # echo 1024 65535 > /proc/sys/net/ipv4/ip_local_port_range >> # cat /p

[PATCH v2 net-next 0/2] DSA: GPIO to reset switches

These two patches add support for using a GPIO to hard reset a switch during reset. v2: Thanks to a clue from Neil Armstrong, i figured out how to convert the gpio into a gpiod, while keeping the ACTIVE_LOW flag, so simplifiying the set/reset code. I have not included the Tested-by: from Phil Re

[PATCH v2 net-next 1/2] net: dsa: Add support for a switch reset gpio

Some boards have a gpio line tied to the switch reset pin. Allow this gpio to be retrieved from the device tree, and take the switch out of reset before performing the probe. Signed-off-by: Andrew Lunn --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 3 +++ include/net/dsa.h

[PATCH v2 net-next 2/2] dsa: mv88e6xxx.c: Hardware reset the chip if available

The device tree binding now allows a gpio to be specified which is attached to the switch chips reset line. If it is defined, perform a hardware reset on the switch during setup. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 10 ++ 1 file changed, 10 insertions(+) diff --

Re: r8169 regression: UDP packets dropped intermittantly

On Thu, Nov 19, 2015 at 01:56:08AM +0100, Francois Romieu wrote: > Jonathan Woithe : > [...] > > I could try. What's the most reliable way to determine this? Use regular > > ethtool queries about the time of the failures? > > If you are neither space nor cpu constrained: > > while : ; do >

dccp->bind_conflict jump to null.

I've been trying to figure this one out for a while. It smells like a race, but I can't figure out any more than the clues below, and I've not really got the time to dig into it. After running Trinity for a while, I saw the machine just suddenly reboot. I managed to capture a partial trace over se

Re: [PATCH] net: tulip: update MAINTAINER status to Orphan

On Thu, Nov 19, 2015 at 6:29 PM, Florian Fainelli wrote: > On 19/11/15 17:56, Grant Grundler wrote: >> From: Grant Grundler >> >> I haven't had any PCI tulip HW for the past ~5 years. I have >> been reviewing tulip patches and can continue doing that. >> >> Signed-off-by: Grant Grundler >> --- >

Re: [PATCH] net: tulip: update MAINTAINER status to Orphan

On 19/11/15 17:56, Grant Grundler wrote: > From: Grant Grundler > > I haven't had any PCI tulip HW for the past ~5 years. I have > been reviewing tulip patches and can continue doing that. > > Signed-off-by: Grant Grundler > --- > I'm also proposing to add linux-parisc to the list since AFAIK,

Re: Add a SOCK_DESTROY operation to close sockets from userspace

> No, I mean something that kills connections where previously this did > not happen. The fact that this is done at the process level does not > justify that it is a right to at do connections. Besides, if you > really intend to do this then provide a privileged process a means to > close *any* ope

[PATCH] net: tulip: update MAINTAINER status to Orphan

From: Grant Grundler I haven't had any PCI tulip HW for the past ~5 years. I have been reviewing tulip patches and can continue doing that. Signed-off-by: Grant Grundler --- I'm also proposing to add linux-parisc to the list since AFAIK, all parisc systems but the C8000 workstations (PA8800/PA8

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Fri, Nov 20, 2015 at 9:55 AM, David Miller wrote: > Netfilter could perform signalling on skb->sk when it drops packets. > > Your example is actually a argument _for_ doing this in the kernel. > > :-) Well, I did say that was a simple example. :-) How do I make the VPN case work? In that case,

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

On Thu, Nov 19, 2015 at 3:50 PM, Francois Romieu wrote: > Grant Grundler : > [...] >> Some additional minor refactoring of the code could convert this into >> a "multi-bus driver" if there is any system that could incorporate >> both a platform device and a PCI device. >> >> I expect the conversi

Re: Add a SOCK_DESTROY operation to close sockets from userspace

>> In this case, userspace knows that that app's connections are now >> unusable because it configured an iptables rule to block them. The >> kernel doesn't really know until it the time comes to send a packet, >> and maybe not even then. > > Netfilter could perform signalling on skb->sk when it dr

Re: Add a SOCK_DESTROY operation to close sockets from userspace

From: Lorenzo Colitti Date: Fri, 20 Nov 2015 09:19:25 +0900 > In this case, userspace knows that that app's connections are now > unusable because it configured an iptables rule to block them. The > kernel doesn't really know until it the time comes to send a packet, > and maybe not even then. N

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 2:53 PM, David Miller wrote: > What I object to is userspace making reachability decisions, not > whether SOCK_DESTROY closes the socket in one way or the other. To be fair: userspace already makes reachability decisions. Using iptables and ip rules, it can configure arbit

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 4:09 PM, Lorenzo Colitti wrote: > On Fri, Nov 20, 2015 at 9:04 AM, Tom Herbert wrote: >> or to start killing connections based on some arbitrary policy when >> under memory pressure. > > You mean like the OOM killer starts killing entire processes based on > some arbitrary

Re: Add a SOCK_DESTROY operation to close sockets from userspace

> Having comments like "look, just implement application keepalives" is > not going to work [1][2]. This is terrible, and show lack of > understanding of the problem. We are not dealing with DC communications > here. (I wish !) There's a 3rd reason: keepalives (tcp or application) are actually und

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Fri, Nov 20, 2015 at 9:04 AM, Tom Herbert wrote: > or to start killing connections based on some arbitrary policy when > under memory pressure. You mean like the OOM killer starts killing entire processes based on some arbitrary policy when under memory pressure? :-) -- To unsubscribe from thi

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 2:33 PM, Eric Dumazet wrote: > On Thu, 2015-11-19 at 14:14 -0800, Tom Herbert wrote: >> On Thu, Nov 19, 2015 at 2:07 PM, Eric Dumazet wrote: >> > On Thu, 2015-11-19 at 13:53 -0800, Tom Herbert wrote: >> > >> >> That covers the case where the local address is removed, but t

Re: Add a SOCK_DESTROY operation to close sockets from userspace

> Ack. With emphasis of *application*. :) The problem with application anything is that changing apps is outright impossible. There are far too many of them written by far too many people. And until you fix them all (which is infeasible) and roll those changes out (unlikely) users will continue to

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue (w/ Fixes:)

An AF_UNIX datagram socket being the client in an n:1 association with some server socket is only allowed to send messages to the server if the receive queue of this socket contains at most sk_max_ack_backlog datagrams. This implies that prospective writers might be forced to go to sleep despite no

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

Grant Grundler : [...] > Some additional minor refactoring of the code could convert this into > a "multi-bus driver" if there is any system that could incorporate > both a platform device and a PCI device. > > I expect the conversion to DMA API to be straight forward as the next > patch shows:

Re: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue (w/ Fixes:)

Rainer Weikusat writes: > Rainer Weikusat writes: > > [...] > >> The basic options would be >> >> - return EAGAIN even if sending became possible (Jason's most >> recent suggestions) >> >> - retry sending a limited number of times, eg, once, before >> returning EAGAI

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Fri, Nov 20, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > On Thu, Nov 19, 2015, at 19:27, Hannes Frederic Sowa wrote: >> I will research the semantics behind tcpdrop: >>

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 2:38 PM, Hannes Frederic Sowa wrote: > > > On Thu, Nov 19, 2015, at 23:33, Lorenzo Colitti wrote: >> On Fri, Nov 20, 2015 at 2:38 AM, Tom Herbert wrote: >> >> I actually don't have an issue with killing from user space that much. I >> >> still recommend (and actually have

[PATCH net] net, scm: fix PaX detected msg_controllen overflow in scm_detach_fds

David and HacKurx reported a following/similar size overflow triggered in a grsecurity kernel, thanks to PaX's gcc size overflow plugin: (Already fixed in later grsecurity versions by Brad and PaX Team.) [ 1002.296137] PAX: size overflow detected in function scm_detach_fds net/core/scm.c:314

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015, at 19:27, Hannes Frederic Sowa wrote: > I will research the semantics behind tcpdrop: > Fyi, my research shows that it just sends RST and discards comp

Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

> >What phy is it? > >Micrel KSZ8041RNLI for sh_eth, KSZ9031 for ravb. > > >Do you have phy DT properties in the MAC node? > >I have PHY subnodes (with props) in the MAC node. O.K, so this could be the same problems as https://lkml.org/lkml/2015/10/15/726 https://www.mail-archive.com/

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Fri, Nov 20, 2015 at 1:33 AM, David Miller wrote: >> Every-time I make a change in linux TCP stack, this code breaks, and >> this a real pain because Android changes need to be carried over to >> vendors. > > I'm very glad that you felt the pain enough that you finally had > to reluctantly try

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015, at 23:33, Lorenzo Colitti wrote: > On Fri, Nov 20, 2015 at 2:38 AM, Tom Herbert wrote: > >> I actually don't have an issue with killing from user space that much. I > >> still recommend (and actually have started to look at it today) to add a > >> new substate for TCP TIMEW

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 23:31 +0100, Hannes Frederic Sowa wrote: > I thought it would be necessary to support multipathing in QUIC? It is not necessary ;) There are billions of flows sharing Internet pipes, no need to double their numbers, it wont help at all. Simply use one path with appropriate

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Fri, Nov 20, 2015 at 2:38 AM, Tom Herbert wrote: >> I actually don't have an issue with killing from user space that much. I >> still recommend (and actually have started to look at it today) to add a >> new substate for TCP TIMEWAIT and don't have any issue if we block the >> socket for 60 sec

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 14:14 -0800, Tom Herbert wrote: > On Thu, Nov 19, 2015 at 2:07 PM, Eric Dumazet wrote: > > On Thu, 2015-11-19 at 13:53 -0800, Tom Herbert wrote: > > > >> That covers the case where the local address is removed, but the not > >> the case where the network manager is informed o

Re: [PATCH iproute2 1/2] Avoid in6_addr redefinition

On Thu, 19 Nov 2015 22:05:39 +0100 Thomas Petazzoni wrote: > diff --git a/include/libiptc/ipt_kernel_headers.h > b/include/libiptc/ipt_kernel_headers.h > index 7e87828..9566be5 100644 > --- a/include/libiptc/ipt_kernel_headers.h > +++ b/include/libiptc/ipt_kernel_headers.h > @@ -15,12 +15,10 @@

Re: [PATCH iproute2 2/2] Add missing include

On Thu, 19 Nov 2015 22:05:40 +0100 Thomas Petazzoni wrote: > The u_intXX_t types are defined in , so it should be > included before using those types. Otherwise, with certain C > libraries, the build fails with: > > In file included from ../include/iptables.h:4:0, > from m_ipt.c

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015, at 23:15, Eric Dumazet wrote: > On Thu, 2015-11-19 at 23:09 +0100, Hannes Frederic Sowa wrote: > > > My point is the "eventually" and the very much increased latency until > > the kernel learns about new better source addresses it has available. I > > would monitor link qua

Re: WARN due to local_bh_disable called with interrupts disabled

>> >> The call gic_handle_irq() sounds like a hardware IRQ func/context. >> >> The flush_backlog() call is due to the device is being unregistered. >> Yes, this is the ARM interrupt controller. It appeared as if wifi was getting torn down around this. >> I'm surprised to see kfree_skb() being cal

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 2:07 PM, Eric Dumazet wrote: > On Thu, 2015-11-19 at 13:53 -0800, Tom Herbert wrote: > >> That covers the case where the local address is removed, but the not >> the case where the network manager is informed of an error in the path >> and wants to signal the application. M

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 23:09 +0100, Hannes Frederic Sowa wrote: > My point is the "eventually" and the very much increased latency until > the kernel learns about new better source addresses it has available. I > would monitor link quality over time and decide source address based on > this on the

Re: [PATCH v2 23/27] rt2x00: move under ralink vendor directory

On Wed, 18 Nov 2015 16:46:02 +0200, Kalle Valo wrote: > Part of reorganising wireless drivers directory and Kconfig. > > Signed-off-by: Kalle Valo For Ralink you could probably drop the rt2x00 directory. RaLink Tech. doesn't exist any more and rt2x00 contains drivers for all of their devices.

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015, at 23:04, Eric Dumazet wrote: > On Thu, 2015-11-19 at 22:53 +0100, Hannes Frederic Sowa wrote: > > > > > You don't steer QUIC source addresses at all? I think most networking > > failures are of transient nature thus the kernel routing subsystem is > > not aware of link qu

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 13:53 -0800, Tom Herbert wrote: > That covers the case where the local address is removed, but the not > the case where the network manager is informed of an error in the path > and wants to signal the application. My understanding was that > SIOCKILLADDR would work for the f

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 22:53 +0100, Hannes Frederic Sowa wrote: > > You don't steer QUIC source addresses at all? I think most networking > failures are of transient nature thus the kernel routing subsystem is > not aware of link quality and packets get lost anyway e.g. in the air? > Thus binding

Re: r8169 regression: UDP packets dropped intermittantly

On Thu, 2015-11-19 at 22:44 +0100, Francois Romieu wrote: > Eric Dumazet : > [...] > > This looks like a race when/if RX happens very shortly after one > > transmit. > > > > Francois, are we really saving lot of cpu cycles testing status ? > > I'm not sure. An extra smp_rmb and three cache lines

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

On Thu, Nov 19, 2015 at 12:29 PM, Florian Fainelli wrote: > On 19/11/15 04:26, Will Deacon wrote: ... >> /me waits for on-soc tulip integration. > > FWIW, this already happened, the ADMtek/Infineon ADM8668 actually > integrated a Tulip chip. I have not submitted these patches below from > the Open

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015 at 1:41 PM, Eric Dumazet wrote: > On Thu, 2015-11-19 at 13:29 -0800, Tom Herbert wrote: >> > We (TCP stack) compete with QUIC, based on UDP, which has no issues like >> > that. We need to allow TCP sessions being signaled of a non temporary >> > network disruption. >> > >> >>

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, Nov 19, 2015, at 22:41, Eric Dumazet wrote: > On Thu, 2015-11-19 at 13:29 -0800, Tom Herbert wrote: > > > We (TCP stack) compete with QUIC, based on UDP, which has no issues like > > > that. We need to allow TCP sessions being signaled of a non temporary > > > network disruption. > > > >

Re: r8169 regression: UDP packets dropped intermittantly

Eric Dumazet : [...] > This looks like a race when/if RX happens very shortly after one > transmit. > > Francois, are we really saving lot of cpu cycles testing status ? I'm not sure. An extra smp_rmb and three cache lines at most when there really isn't any work ? Probably not worth it. Can yo

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

On Thu, 2015-11-19 at 16:06 -0500, Aaron Conole wrote: > > > > Would the following be an appropriate change in addition to the one > you've posted, then? If so I can repost as a formal patch, if you'd > like. At present, there's only one user of napi_frags_skb(), and your > patch removes the NULL

Re: Add a SOCK_DESTROY operation to close sockets from userspace

On Thu, 2015-11-19 at 13:29 -0800, Tom Herbert wrote: > > We (TCP stack) compete with QUIC, based on UDP, which has no issues like > > that. We need to allow TCP sessions being signaled of a non temporary > > network disruption. > > > > Eric, can you provide some detail on this statement? > > I d

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

On Thu, Nov 19, 2015 at 4:26 AM, Will Deacon wrote: > On Thu, Nov 19, 2015 at 11:42:26AM +0100, Arnd Bergmann wrote: >> The tulip driver causes annoying build-time warnings for allmodconfig >> builds for all recent architectures: >> >> dec/tulip/winbond-840.c:910:2: warning: #warning Processor arc

Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

Hello. On 11/20/2015 12:06 AM, Andrew Lunn wrote: From: David Daney commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent") changed the parent of PHY devices from the bus to the bus parent. Then, commit 4dea547fef1b ("phylib: rework to prepare for OF registration of PHYs") mov

Re: Add a SOCK_DESTROY operation to close sockets from userspace

> We (TCP stack) compete with QUIC, based on UDP, which has no issues like > that. We need to allow TCP sessions being signaled of a non temporary > network disruption. > Eric, can you provide some detail on this statement? I don't understand why QUIC wouldn't have this same issue. Seems like it

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

Eric Dumazet writes: > On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote: >> Eric Dumazet writes: >> >> > How many times should we crash before napi_frags_skb() returns NULL ? >> .. >> > return NULL; >> >> Huh? Now I'm lost here, too. > > > Well, Ethernet drivers sho

Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

On Thu, Nov 19, 2015 at 11:51:37PM +0300, Sergei Shtylyov wrote: > Hello. > > On 08/22/2015 02:16 AM, David Daney wrote: > > >From: David Daney > > > >commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent") > >changed the parent of PHY devices from the bus to the bus parent. > > >

[PATCH iproute2 1/2] Avoid in6_addr redefinition

Due to both and being included, the in6_addr is being redefined: once from the C library headers and once from the kernel headers. This causes some build failures with for example the musl C library: In file included from ../include/linux/xfrm.h:4:0, from xfrm.h:29,

[PATCH iproute2 2/2] Add missing include

The u_intXX_t types are defined in , so it should be included before using those types. Otherwise, with certain C libraries, the build fails with: In file included from ../include/iptables.h:4:0, from m_ipt.c:18: ../include/iptables_common.h:47:16: error: unknown type name ‘u_int3

[PATCH iproute2 0/2] Build fixes for the musl C library

Hello, The following two patches fixing build issues that occur when trying to build iproute2 with the musl C library (http://musl-libc.org). Thanks, Thomas Thomas Petazzoni (2): Avoid in6_addr redefinition Add missing include include/iptables_common.h| 2 ++ include/libiptc/

Re: [PATCH] phylib: Make PHYs children of their MDIO bus, not the bus' parent.

Hello. On 08/22/2015 02:16 AM, David Daney wrote: From: David Daney commit 18ee49ddb0d2 ("phylib: rename mii_bus::dev to mii_bus::parent") changed the parent of PHY devices from the bus to the bus parent. Then, commit 4dea547fef1b ("phylib: rework to prepare for OF registration of PHYs") mov

[PATCH V3 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

This patchset adds support of Hisilicon Hip06 SoC to the existing HNS ethernet driver. The changes in the driver are mainly due to changes in the DMA descriptor provided by the Hip06 ethernet hardware. These changes need to co-exist with already present Hip05 DMA descriptor and its operating funct

[PATCH V3 net-next 3/5] net:hns: Add Hip06 "TSO(TCP Segment Offload)" support HNS Driver

This patch adds the support of "TSO (TCP Segment Offload)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. Enabling this feature would help offload the TCP Segmentation process to the Hip06 ethernet hardware. This eventually would help in saving precious cpu cycles. Si

[PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

This patch adds the support of "RSS (Receive Side Scaling)" feature provided by the Hip06 ethernet hardware to the HNS ethernet driver. This feature helps in distributing the different flows (mapped as hash by hardware using Toeplitz Hash) to different Queues asssociated with the processor cores.

[PATCH V3 net-next 5/5] net:hns: Add the init code to disable Hip06 "Hardware VLAN assist"

This patch adds the initializzation code to disable the hardware vlan support for VLAN Tag stripping by default for now. Proper support of "hardware VLAN assitance" feature would soon come in the next coming patches. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe

[PATCH V3 net-next 4/5] net:hns: Add support of ethtool TSO set option for Hip06 in HNS

From: Salil This patch adds the support of ethtool TSO option to V1 patch, meant to add support of Hip06 SoC to HNS Signed-off-by: Salil Mehta Signed-off-by: lisheng --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 47 + 1 file changed, 47 insertions(+) diff --gi

[PATCH V3 net-next 0/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem

This PATCH V3 addresses the comment floated by David Miller and has been created over PATCH V2 sent earlier. PATCH V2: 1) Bug Fixes and Clean-up: Internally identified 2) Addresses internal review comments by Kenneth Lee and by Huang Daode 3) Addresses the review comment from "Yisen.Zhuang(Zhu

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

On Thu, 2015-11-19 at 21:20 +0100, Bjørn Mork wrote: > Eric Dumazet writes: > > > How many times should we crash before napi_frags_skb() returns NULL ? > .. > > return NULL; > > Huh? Now I'm lost here, too. Well, Ethernet drivers should not feed GRO with frames with le

[PATCH net-next 2/2] net: Add support for vrf-global TCP servers

Allow a process to have a "VRF-global" listen socket. In this case the listen socket is not bound to a VRF device but child sockets derived from it are bound to the VRF device the original packet was received on. This avoids the need to replicate services or create additional listen sockets as VRF

[PATCH net-next 1/2] net: l3mdev: Add master device lookup by index

Add helper to lookup master index given a device index. Signed-off-by: David Ahern --- include/net/l3mdev.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/net/l3mdev.h b/include/net/l3mdev.h index 774d85b2d5d9..786226f8e77b 100644 --- a/include/net/l3mdev.h

Re: [PATCH] net: tulip: turn compile-time warning into dev_warn()

On 19/11/15 04:26, Will Deacon wrote: > On Thu, Nov 19, 2015 at 11:42:26AM +0100, Arnd Bergmann wrote: >> The tulip driver causes annoying build-time warnings for allmodconfig >> builds for all recent architectures: >> >> dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture >> u

[PATCH net-next] net: IPv6 fib lookup tracepoint

Add tracepoint to show fib6 table lookups and result. Signed-off-by: David Ahern --- include/trace/events/fib6.h | 76 + net/core/net-traces.c | 4 +++ net/ipv6/route.c| 10 ++ 3 files changed, 90 insertions(+) create mode 10064

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

Eric Dumazet writes: > How many times should we crash before napi_frags_skb() returns NULL ? .. > return NULL; Huh? Now I'm lost here, too. Bjørn -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org

Re: [PATCH net-next] bpf: add show_fdinfo handler for maps

On Thu, Nov 19, 2015, at 19:32, Alexei Starovoitov wrote: > On Thu, Nov 19, 2015 at 07:19:24PM +0100, Hannes Frederic Sowa wrote: > > On Thu, Nov 19, 2015, at 11:56, Daniel Borkmann wrote: > > > Add a handler for show_fdinfo() to be used by the anon-inodes > > > backend for eBPF maps, and dump the

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

On Thu, 2015-11-19 at 11:54 -0800, Alexei Starovoitov wrote: > On Thu, Nov 19, 2015 at 11:42:50AM -0800, Eric Dumazet wrote: > > From: Eric Dumazet > > > > Checking if skb is NULL in napi_gro_frags() is too late. > > > > If skb was NULL, we would crash earlier in napi_frags_skb() > > > > Driver

[PATCH net-next] net: avoid NULL deref in napi_get_frags()

From: Eric Dumazet napi_alloc_skb() can return NULL. We should not crash should this happen. Fixes: 93f93a440415 ("net: move skb_mark_napi_id() into core networking stack") Signed-off-by: Eric Dumazet --- net/core/dev.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 11/15] emulex: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/emulex/benet/be.h | 1 + drivers/net/ethernet/emulex/benet/be_main.c | 30 + 2 files changed, 23 insertions(+

[PATCH RFC 00/15] net: The beginning of the end for NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM

Background: This patch set starts to address one front in the battle against protocol ossification. Protocol ossification describes the state that we have arrived at in the evolution of the Internet where we are materially limited to only using a very narrow range of protocols and protocol feature

[PATCH 10/15] bnxt: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/b

[PATCH 14/15] mlx4: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 6 +++--- drivers/net/ethernet/mellanox/mlx4/en_tx.c | 16 ++-- 2 files changed, 17 insertions(+),

[PATCH 05/15] net: Eliminate NETIF_F_GEN_CSUM and NETIF_F_V[46]_CSUM

These netif flags are unnecessary convolutions. It is more straightforward to just use NETIF_F_HW_CSUM, NETIF_F_IP_CSUM, and NETIF_F_IPV6_CSUM directly. This patch also: - Cleans up can_checksum_protocol - Simplifies netdev_intersect_features Signed-off-by: Tom Herbert --- drivers/net/e

[PATCH 08/15] net: Elaborate on checksum offload interface description

Add specifics and details the description of the interface between the stack and drivers for doing checksum offload. This description is meant to be as specific and complete as possible. Signed-off-by: Tom Herbert --- include/linux/skbuff.h | 138 ++---

[PATCH 06/15] tcp: Fix conditions to determine checksum offload

In tcp_send_sendpage and tcp_sendmsg we check the route capabilities to determine if checksum offload can be performed. This check currently does not take the IP protocol into account for devices that advertise only one of NETIF_F_IPV6_CSUM or NETIF_F_IP_CSUM. This patch adds a function to check ca

[PATCH 04/15] net: Rename NETIF_F_ALL_CSUM to NETIF_F_CSUM_MASK

The name NETIF_F_ALL_CSUM is a misnomer. This does not correspond to the set of features for offloading all checksums. This a mask of the checksum offload related features bits. It is incorrect to set both NETIF_F_HW_CSUM and NETIF_F_IP_CSUM or NETIF_F_IPV6 at the same time for features of a device

[PATCH 15/15] qlogic: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 10 +++--- drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 16 ++-- drivers/net/ethernet/qlogi

[PATCH 13/15] ixgbe: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 41 +++ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 03/15] fcoe: Use CHECKSUM_PARTIAL to indicate CRC offload

When setting up CRC offload set ip_summed to CHECKSUM_PARTIAL instead of CHECKSUM_UNNECESSARY. This is consistent with the definition of CHECKSUM_PARTIAL. The only driver that seems to be advertising NETIF_F_FCOE_CRC is ixgbe. AFICT the driver does not look at ip_summed for FCOE and just assumes t

[PATCH 12/15] fm10k: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/intel/fm10k/fm10k_main.c | 16 ++-- drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 5 ++--- 2 files changed, 16 insertions(+)

[PATCH 02/15] sctp: Rename NETIF_F_SCTP_CSUM to NETIF_F_SCTP_CRC

The SCTP checksum is really a CRC and is very different from the standards 1's complement checksum that serves as the checksum for IP protocols. This offload interface is also very different. Rename NETIF_F_SCTP_CSUM to NETIF_F_SCTP_CRC to highlight these differences. The term CSUM should be reserv

[PATCH 09/15] bnx2x: Convert to advertise NETIF_F_HW_CSUM

The skb_csum_offload_chk is used to resolve checksums that are unable to be offloaded to the device. Signed-off-by: Tom Herbert --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 15 +-- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 6 +++--- 2 files changed, 16 insertions(

[PATCH 07/15] net: Add driver helper functions to determine checksum offloadability

Add skb_csum_offload_chk driver helper function to determine if a device with limited checksum offload capabilities is able to offload the checksum for a given packet. This patch includes: - The skb_csum_offload_chk function. Returns true if checksum is offloadable, else false. Optionally, i

[PATCH 01/15] net: Add skb_inner_transport_offset function

Same thing as skb_transport_offset but returns the offset of the inner transport header (when skb->encpasulation is set). Signed-off-by: Tom Herbert --- include/linux/skbuff.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index c9c394b..

Re: [PATCH net-next] net: remove useless check in napi_gro_frags()

On Thu, Nov 19, 2015 at 11:42:50AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > Checking if skb is NULL in napi_gro_frags() is too late. > > If skb was NULL, we would crash earlier in napi_frags_skb() > > Drivers normally catch napi_get_frags() NULL return value > before calling napi_gro

Re: Asterisk deadlocks since Kernel 4.1

Am 19.11.2015 um 14:19 schrieb Florian Weimer: On 11/19/2015 01:46 PM, Stefan Priebe - Profihost AG wrote: I can try Kernel 4.4-rc1 next week. Or something else? I found this bug report which indicates that 4.1.10 works: But in yo

[PATCH net-next] net: remove useless check in napi_gro_frags()

From: Eric Dumazet Checking if skb is NULL in napi_gro_frags() is too late. If skb was NULL, we would crash earlier in napi_frags_skb() Drivers normally catch napi_get_frags() NULL return value before calling napi_gro_frags() Signed-off-by: Eric Dumazet --- net/core/dev.c |3 --- 1 file

  1   2   >