Re: [PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-21 Thread Mugunthan V N
On Thursday 21 April 2016 11:20 PM, David Rivshin (Allworx) wrote: > From: David Rivshin > > The first patch fixes a bug that makes dual_emac mode break if > either slave uses the phy-handle property in the devicetree. > > The second patch fixes some cosmetic problems with error messages, > and

[v8, 2/7] ARM64: dts: ls2080a: add device configuration node

2016-04-21 Thread Yangbo Lu
Add the dts node for device configuration unit that provides general purpose configuration and status for the device. Signed-off-by: Yangbo Lu Acked-by: Scott Wood --- Changes for v5: - Added this patch Changes for v6: - None Changes for v7: - None Changes for v8:

[v8, 6/7] MAINTAINERS: add entry for Freescale SoC specific driver

2016-04-21 Thread Yangbo Lu
Add maintainer entry for Freescale SoC specific driver including the QE library and the GUTS driver. Also add entry for GUTS driver and add maintainer for QE library. Signed-off-by: Yangbo Lu --- Changes for v8: - Added this patch --- MAINTAINERS | 16 +++- 1 file changed, 15

[v8, 0/7] Fix eSDHC host version register bug

2016-04-21 Thread Yangbo Lu
This patchset is used to fix a host version register bug in the T4240-R1.0-R2.0 eSDHC controller. To get the SoC version and revision, it's needed to add the GUTS driver to access the global utilities registers. So, the first four patches are to add the GUTS driver. The following patches except th

[v8, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-04-21 Thread Yangbo Lu
The eSDHC of T4240-R1.0-R2.0 has incorrect vender version and spec version. Acturally the right version numbers should be VVN=0x13 and SVN = 0x1. This patch adds the GUTS driver support for eSDHC driver to get SVR(System version register). And fix host version to avoid that incorrect version number

[v8, 5/7] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-04-21 Thread Yangbo Lu
Move mpc85xx.h to include/linux/fsl and rename it to svr.h as a common header file. It has been used for mpc85xx and it will be used for ARM-based SoC as well. Signed-off-by: Yangbo Lu Acked-by: Wolfram Sang Acked-by: Stephen Boyd Acked-by: Scott Wood Acked-by: Joerg Roedel --- Changes for v2

[v8, 3/7] soc: fsl: add GUTS driver for QorIQ platforms

2016-04-21 Thread Yangbo Lu
The global utilities block controls power management, I/O device enabling, power-onreset(POR) configuration monitoring, alternate function selection for multiplexed signals,and clock control. This patch adds GUTS driver to manage and access global utilities block. Signed-off-by: Yangbo Lu Acked-

[v8, 4/7] dt: move guts devicetree doc out of powerpc directory

2016-04-21 Thread Yangbo Lu
Move guts devicetree doc to Documentation/devicetree/bindings/soc/fsl/ since it's used by not only PowerPC but also ARM. And add a specification for 'little-endian' property. Signed-off-by: Yangbo Lu Acked-by: Scott Wood Acked-by: Rob Herring --- Changes for v4: - Added this patch Chang

[v8, 1/7] Documentation: DT: update Freescale DCFG compatible

2016-04-21 Thread Yangbo Lu
Update Freescale DCFG compatible with 'fsl,-dcfg' instead of 'fsl,ls1021a-dcfg' to include more chips. Signed-off-by: Yangbo Lu --- Changes for v8: - Added this patch --- Documentation/devicetree/bindings/arm/fsl.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc

RE: [PATCH net 1/1] net: fec: update dirty_tx even if no skb

2016-04-21 Thread Fugang Duan
From: Troy Kisky Sent: Friday, April 22, 2016 10:01 AM > To: netdev@vger.kernel.org; da...@davemloft.net; Fugang Duan > ; lzn...@gmail.com > Cc: Fabio Estevam ; l.st...@pengutronix.de; > and...@lunn.ch; trem...@gmail.com; g...@uclinux.org; linux-arm- > ker...@lists.infradead.org; johan...@sipsolu

[PATCH net-next v2 3/4] qed*: Conditions for changing link

2016-04-21 Thread Yuval Mintz
There's some inconsistency in current logic determining whether the link settings of a given interface can be changed; I.e., in all modes other than the so-called `deault' mode the interfaces are forbidden from changing the configuration - but even this rule is not applied to all user APIs that may

[PATCH net-next v2 4/4] qed: add support for link pause configuration.

2016-04-21 Thread Yuval Mintz
From: Sudarsana Reddy Kalluru The APIs for making this sort of configuration [e.g., via ethtool] are already present in qede, but the current configuration flow in qed doesn't respect it. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed

[PATCH net-next v2 1/4] qed*: Align statistics names

2016-04-21 Thread Yuval Mintz
There's a difference in statsitics' names starting at qed and propagating to qede, where egress counters indicate ranges while ingress counters indiciate high-end. Align all statistcs to follow the same conventions - name indicates range. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogi

[PATCH net-next v2 2/4] qede: Add support for ethtool private flags

2016-04-21 Thread Yuval Mintz
Adds a getter for the interfaces private flags. The only parameter currently supported is whether the interface is a coupled function [required for supporting 100g]. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 23 +++ 1 file changed, 23 in

[PATCH net-next v2 0/4] qed*: driver updates

2016-04-21 Thread Yuval Mintz
[Was previous termed 'eeprom access et al.', but seemed a bit inappropriate given we've dropped the eeprom patch for now. Still waiting for some inputs on that one, BTW] This patch series contains some ethtool-related enhancements. Dave, Please consider applying this to `net-next'. Thanks [and

Re: [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute

2016-04-21 Thread David Miller
From: Nicolas Dichtel Date: Fri, 22 Apr 2016 00:00:09 +0200 > Le 21/04/2016 20:28, David Miller a écrit : >> >> Applied to net-next. >> >> I did a quick scan and the following jumped out at me as cases we need >> to fix up as well: > Did you grep something or just catch this by code review? It w

[PATCH net-next] net: better drop monitoring in ip{6}_recv_error()

2016-04-21 Thread Eric Dumazet
From: Eric Dumazet We should call consume_skb(skb) when skb is properly consumed, or kfree_skb(skb) when skb must be dropped in error case. Signed-off-by: Eric Dumazet --- net/ipv4/ip_sockglue.c | 10 +- net/ipv6/datagram.c| 10 +- 2 files changed, 10 insertions(+), 10

[PATCH net-next] tcp: SYN packets are now simply consumed

2016-04-21 Thread Eric Dumazet
From: Eric Dumazet We now have proper per-listener but also per network namespace counters for SYN packets that might be dropped. We replace the kfree_skb() by consume_skb() to be drop monitor [1] friendly, and remove an obsolete comment. FastOpen SYN packets can carry payload in them just fine.

Re: [PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c

2016-04-21 Thread Siva Reddy Kallam
On Thu, Apr 14, 2016 at 8:42 AM, wrote: > > From: Zhaoxiu Zeng > > Signed-off-by: Zhaoxiu Zeng Looks good to me. Acked-by: Siva Reddy Kallam > --- > drivers/net/ethernet/broadcom/tg3.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/t

Re: [RFC PATCH v3 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-21 Thread Martin KaFai Lau
On Thu, Apr 21, 2016 at 05:14:37PM -0400, Soheil Hassas Yeganeh wrote: > On another note, do you think putting this is a self-documenting > helper function, say tcp_can_collapse_to(), would help readability? Sure. I will move unlikely(TCP_SKB_CB(to)->eor) to a new helper function tcp_skb_can_colla

[PATCH] net: ipv6: Delete host routes on an ifdown

2016-04-21 Thread David Ahern
It was a simple idea -- save IPv6 configured addresses on a link down so that IPv6 behaves similar to IPv4. As always the devil is in the details and the IPv6 stack as too many behavioral differences from IPv4 making the simple idea more complicated than it needs to be. The current implementation

[PATCH net 1/1] net: fec: update dirty_tx even if no skb

2016-04-21 Thread Troy Kisky
If dirty_tx isn't updated, then dma_unmap_single will be called twice. This fixes a [ 58.420980] [ cut here ] [ 58.425667] WARNING: CPU: 0 PID: 377 at /home/schurig/d/mkarm/linux-4.5/lib/dma-debug.c:1096 check_unmap+0x9d0/0xab8() [ 58.436405] fec 2188000.ethernet: DM

Re: linux-next: manual merge of the net-next tree with the net tree

2016-04-21 Thread Vivien Didelot
Hi David, Stephen Rothwell writes: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/dsa/mv88e6xxx.c > > between commit: > > 207afda1b503 ("net: dsa: mv88e6xxx: share the same default FDB") > > from the net tree and commit: > > 009a2b9843bf ("ne

[PATCH v2] ixgbevf: Change the relaxed order settings in VF driver for sparc

2016-04-21 Thread Babu Moger
We noticed performance issues with VF interface on sparc compared to PF. Setting the RX to IXGBE_DCA_RXCTRL_DATA_WRO_EN brings it on far with PF. Also this matches to the default sparc setting in PF driver. Signed-off-by: Babu Moger Acked-by: Sowmini Varadhan --- v2: Alexander had concerns abo

Re: qdisc spin lock

2016-04-21 Thread Michael Ma
2016-04-21 5:41 GMT-07:00 Eric Dumazet : > On Wed, 2016-04-20 at 22:51 -0700, Michael Ma wrote: >> 2016-04-20 15:34 GMT-07:00 Eric Dumazet : >> > On Wed, 2016-04-20 at 14:24 -0700, Michael Ma wrote: >> >> 2016-04-08 7:19 GMT-07:00 Eric Dumazet : >> >> > On Thu, 2016-03-31 at 16:48 -0700, Michael Ma

Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action

2016-04-21 Thread Jamal Hadi Salim
On 16-04-21 05:41 PM, Jamal Hadi Salim wrote: On 16-04-21 05:36 PM, Stephen Hemminger wrote: On Thu, 21 Apr 2016 21:27:39 + Jamal Hadi Salim wrote: I use checkpatch from kernel source to check iproute code now. ah. It was wrong in this specific case. In any case I just resent the patc

Re: [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute

2016-04-21 Thread Nicolas Dichtel
Le 21/04/2016 20:28, David Miller a écrit : From: Nicolas Dichtel Date: Thu, 21 Apr 2016 18:58:23 +0200 Here is a proposal to add more helpers in the libnetlink to manage 64-bit alignment issues. Note that this series was only tested on x86 by tweeking CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS an

Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action

2016-04-21 Thread Jamal Hadi Salim
On 16-04-21 05:36 PM, Stephen Hemminger wrote: On Thu, 21 Apr 2016 21:27:39 + Jamal Hadi Salim wrote: I use checkpatch from kernel source to check iproute code now. ah. It was wrong in this specific case. In any case I just resent the patch with the fixes. cheers, jamal

[iproute2 PATCH v3 1/1] tc: introduce IFE action

2016-04-21 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This action allows for a sending side to encapsulate arbitrary metadata which is decapsulated by the receiving end. The sender runs in encoding mode and the receiver in decode mode. Both sender and receiver must specify the same ethertype. At some point we hope to have a re

Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action

2016-04-21 Thread Stephen Hemminger
On Thu, 21 Apr 2016 21:27:39 + Jamal Hadi Salim wrote: > > The code has also gotten deeply intended creating lots of lines that are > > too long. > > > > Is this you or the script saying the above? How is the conclusion that > we have deep indentation come about? > I checked there are som

[PATCH net V1 1/8] net/mlx5_core: Fix soft lockup in steering error flow

2016-04-21 Thread Saeed Mahameed
From: Maor Gottlieb In the error flow of adding flow rule to auto-grouped flow table, we call to tree_remove_node. tree_remove_node locks the node's parent, however the node's parent is already locked by mlx5_add_flow_rule and this causes a deadlock. After this patch, if we failed to add the flo

[PATCH net V1 4/8] net/mlx5e: Device's mtu field is u16 and not int

2016-04-21 Thread Saeed Mahameed
For set/query MTU port firmware commands the MTU field is 16 bits, here I changed all the "int mtu" parameters of the functions wrapping those firmware commands to be u16. Signed-off-by: Saeed Mahameed --- drivers/infiniband/hw/mlx5/main.c |4 ++-- drivers/net/ethernet/mellan

[PATCH net V1 3/8] net/mlx5_core: Add ConnectX-5 to list of supported devices

2016-04-21 Thread Saeed Mahameed
From: Majd Dibbiny Add the upcoming ConnectX-5 devices (PF and VF) to the list of supported devices by the mlx5 driver. Signed-off-by: Majd Dibbiny Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/main.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) dif

[PATCH net V1 5/8] net/mlx5e: Fix minimum MTU

2016-04-21 Thread Saeed Mahameed
Minimum MTU that can be set in Connectx4 device is 68. This fixes the case where a user wants to set invalid MTU, the driver will fail to satisfy this request and the interface will stay down. It is better to report an error and continue working with old mtu. Signed-off-by: Saeed Mahameed ---

[PATCH net V1 2/8] net/mlx5e: Fix MLX5E_100BASE_T define

2016-04-21 Thread Saeed Mahameed
From: Rana Shahout Bit 25 of eth_proto_capability in PTYS register is 1000Base-TT and not 100Base-T. Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality') Signed-off-by: Rana Shahout Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5

[PATCH net V1 0/8] mlx5 driver updates and fixes

2016-04-21 Thread Saeed Mahameed
Hi Dave, Changes from V0: - Dropped: ("net/mlx5e: Reset link modes upon setting speed to zero") - Fixed compilation issue introduced to mlx5_ib driver. - Rebased to df637193906a ('Revert "Prevent NUll pointer dereference with two PHYs on cpsw"') This series has few bug f

[PATCH net V1 7/8] net/mlx5_core: Remove static from local variable

2016-04-21 Thread Saeed Mahameed
From: Eli Cohen The static is not required and breaks re-entrancy if it will be required. Fixes: 2530236303d9 ("net/mlx5_core: Flow steering tree initialization") Signed-off-by: Eli Cohen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c |2 +- 1 files ch

[PATCH net V1 6/8] net/mlx5e: Use vport MTU rather than physical port MTU

2016-04-21 Thread Saeed Mahameed
Set and report vport MTU rather than physical MTU, Driver will set both vport and physical port mtu and will rely on the query of vport mtu. SRIOV VFs have to report their MTU to their vport manager (PF), and this will allow them to work with any MTU they need without failing the request. Also fo

[PATCH net-next] hv_netvsc: Fix the list processing for network change event

2016-04-21 Thread Haiyang Zhang
RNDIS_STATUS_NETWORK_CHANGE event is handled as two "half events" -- media disconnect & connect. The second half should be added to the list head, not to the tail. So all events are processed in normal order. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netv

[PATCH net V1 8/8] net/mlx5: Add pci shutdown callback

2016-04-21 Thread Saeed Mahameed
From: Majd Dibbiny This patch introduces kexec support for mlx5. When switching kernels, kexec() calls shutdown, which unloads the driver and cleans its resources. In addition, remove unregister netdev from shutdown flow. This will allow a clean shutdown, even if some netdev clients did not rele

Re: [net-next PATCH iproute2 v2 1/1] tc: introduce IFE action

2016-04-21 Thread Jamal Hadi Salim
Sorry dropped the ball on this.. On 16-03-14 02:26 AM, Stephen Hemminger wrote: On Wed, 9 Mar 2016 07:04:36 -0500 Jamal Hadi Salim wrote: This code has diverged way from the general rule that ip utilities display format should match the command format. For example the properties shown on "

Re: [RFC PATCH v3 net-next 2/3] tcp: Handle eor bit when coalescing skb

2016-04-21 Thread Soheil Hassas Yeganeh
On Thu, Apr 21, 2016 at 12:56 PM, Martin KaFai Lau wrote: > On Wed, Apr 20, 2016 at 04:04:54PM -0400, Soheil Hassas Yeganeh wrote: >> > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c >> > index a6e4a83..96bdf98 100644 >> > --- a/net/ipv4/tcp_output.c >> > +++ b/net/ipv4/tcp_output.c >>

Re: [PATCH] wcn36xx: Set SMD timeout to 10 seconds

2016-04-21 Thread John Stultz
On Thu, Apr 21, 2016 at 2:09 PM, Bjorn Andersson wrote: > After booting the wireless subsystem and uploading the NV blob to the > WCNSS_CTRL service the remote continues to do things and will not start > servicing wlan-requests for another 2-5 seconds (measured). > > The downstream code does not h

[PATCH] wcn36xx: Set SMD timeout to 10 seconds

2016-04-21 Thread Bjorn Andersson
After booting the wireless subsystem and uploading the NV blob to the WCNSS_CTRL service the remote continues to do things and will not start servicing wlan-requests for another 2-5 seconds (measured). The downstream code does not have any special handling for this case, but has a timeout of 10 se

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 12:39 PM, Babu Moger wrote: > Hi Alex, > > On 4/21/2016 2:22 PM, Alexander Duyck wrote: >> On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck >> wrote: >>> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: Current code writes the tx/rx relaxed order without reading

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

2016-04-21 Thread Willem de Bruijn
On Tue, Apr 19, 2016 at 2:24 PM, Soheil Hassas Yeganeh wrote: > On Tue, Apr 19, 2016 at 2:18 PM, Martin KaFai Lau wrote: >> On Tue, Apr 19, 2016 at 10:35:52AM -0700, Eric Dumazet wrote: >>> On Tue, Apr 19, 2016 at 10:28 AM, Martin KaFai Lau wrote: >>> >>> > A bit off topic, I feel like the SKBTX

[PATCH net] ipv4/fib: don't warn when primary address is missing if in_dev is dead

2016-04-21 Thread Paolo Abeni
After commit fbd40ea0180a ("ipv4: Don't do expensive useless work during inetdev destroy.") when deleting an interface, fib_del_ifaddr() can be executed without any primary address present on the dead interface. The above is safe, but triggers some "bug: prim == NULL" warnings. This commit avoids

RE: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Keller, Jacob E
> On Thu, 2016-04-21 at 15:47 -0400, David Miller wrote: > > From: "Keller, Jacob E" > > Date: Thu, 21 Apr 2016 19:44:24 + > > > > > Dave, please don't pull this patch. Krishneil found an issue with > > > this patch, and I sent a corrected fix to squash in but it didn't > > > make it into this

Re: [PATCH net 0/2] tcp: Merge timestamp info when coalescing skbs

2016-04-21 Thread Willem de Bruijn
On Wed, Apr 20, 2016 at 1:39 AM, Martin KaFai Lau wrote: > This series is separated from the RFC series related to > tcp_sendmsg(MSG_EOR) and it is targeting for the net branch. > This patchset is focusing on fixing cases where TCP > timestamp could be lost after coalescing skbs. Thanks for fixin

[GIT] Networking

2016-04-21 Thread David Miller
1) Fix memory leak in iwlwifi, from Matti Gottlieb. 2) Add missing registration of netfilter arp_tables into initial namespace, from Florian Westphal. 3) Fix potential NULL deref in DecNET routing code. 4) Restrict NETLINK_URELEASE to truly bound sockets only, from Dmitry Ivanov. 5) Fix

Re: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Jeff Kirsher
On Thu, 2016-04-21 at 15:47 -0400, David Miller wrote: > From: "Keller, Jacob E" > Date: Thu, 21 Apr 2016 19:44:24 + > > > Dave, please don't pull this patch. Krishneil found an issue with > > this patch, and I sent a corrected fix to squash in but it didn't > > make it into this one. I'd lik

Re: [PATCH net-next 1/2] tcp: Carry txstamp_ack in tcp_fragment_tstamp

2016-04-21 Thread Willem de Bruijn
On Wed, Apr 20, 2016 at 1:50 AM, Martin KaFai Lau wrote: > When a tcp skb is sliced into two smaller skbs (e.g. in > tcp_fragment() and tso_fragment()), it does not carry > the txstamp_ack bit to the newly created skb if it is needed. > The end result is a timestamping event (SCM_TSTAMP_ACK) will

Re: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread David Miller
From: "Keller, Jacob E" Date: Thu, 21 Apr 2016 19:44:24 + > Dave, please don't pull this patch. Krishneil found an issue with > this patch, and I sent a corrected fix to squash in but it didn't > make it into this one. I'd like to get the fix squashed in a resend > before this is pulled into

RE: [net-next 15/17] fm10k: fix possible null pointer deref after kcalloc

2016-04-21 Thread Keller, Jacob E
> -Original Message- > From: Kirsher, Jeffrey T > Sent: Wednesday, April 20, 2016 11:09 PM > To: da...@davemloft.net > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com; > Kirsher, Jeffrey T > Subject: [net-next 15/17] fm10k: fix p

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Hi Alex, On 4/21/2016 2:22 PM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck > wrote: >> On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >>> Current code writes the tx/rx relaxed order without reading it first. >>> This can lead to unintended consequences as we a

Re: [PATCH net-next 0/7] net: network drivers should not depend on geneve/vxlan

2016-04-21 Thread David Miller
From: Hannes Frederic Sowa Date: Thu, 21 Apr 2016 09:43:11 +0200 > Hi David, > > On Wed, Apr 20, 2016, at 03:11, David Miller wrote: >> From: Hannes Frederic Sowa >> Date: Wed, 20 Apr 2016 03:06:13 +0200 >> >> > On Wed, Apr 20, 2016, at 02:27, David Miller wrote: >> >> From: Hannes Frederic So

Re: [PATCH v2 0/4] net: thunderx: Add multiqset support for DPDK

2016-04-21 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 21 Apr 2016 12:27:48 +0530 > This patch series mainly adds support for userspace application > like DPDK with a VNIC VF attached to request additional QSets > for having morethan the default 8 queues. I don't think it's appropriate to add facilities for no

Re: [PATCH net] Driver: Vmxnet3: set CHECKSUM_UNNECESSARY for IPv6 packets

2016-04-21 Thread David Miller
From: Shrikrishna Khare Date: Wed, 20 Apr 2016 18:12:29 -0700 > For IPv6, if the device indicates that the checksum is correct, set > CHECKSUM_UNNECESSARY. > > Reported-by: Subbarao Narahari > Signed-off-by: Shrikrishna Khare > Signed-off-by: Jin Heo Applied.

Re: [PATCH net] openvswitch: use flow protocol when recalculating ipv6 checksums

2016-04-21 Thread David Miller
From: Simon Horman Date: Thu, 21 Apr 2016 11:49:15 +1000 > When using masked actions the ipv6_proto field of an action > to set IPv6 fields may be zero rather than the prevailing protocol > which will result in skipping checksum recalculation. > > This patch resolves the problem by relying on th

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 11:13 AM, Alexander Duyck wrote: > On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: >> Current code writes the tx/rx relaxed order without reading it first. >> This can lead to unintended consequences as we are forcibly writing >> other bits. > > The consequences were v

Re: [PATCH net] atl2: Disable unimplemented scatter/gather feature

2016-04-21 Thread David Miller
From: Ben Hutchings Date: Wed, 20 Apr 2016 23:23:08 +0100 > atl2 includes NETIF_F_SG in hw_features even though it has no support > for non-linear skbs. This bug was originally harmless since the > driver does not claim to implement checksum offload and that used to > be a requirement for SG. >

Re: [net-next PATCH v2 0/3] Feature tweaks/fixes follow-up to GSO partial patches

2016-04-21 Thread David Miller
From: Alexander Duyck Date: Wed, 20 Apr 2016 10:49:00 -0400 > This patch series is a set of minor fix-ups and tweaks following the GSO > partial and TSO with IPv4 ID mangling patches. It mostly is just meant to > make certain that if we have GSO partial support at the device we can make > use of

Re: [PATCH net-next V3 00/11] Mellanox 100G mlx5 driver receive path optimizations

2016-04-21 Thread David Miller
From: Saeed Mahameed Date: Wed, 20 Apr 2016 22:02:08 +0300 ... > This series includes Some RX modifications and optimizations for > the mlx5 Ethernet driver. ... Series applied, thanks.

Re: [PATCH net-next 0/2] net: bcmsysport: utilize newer NAPI APIs

2016-04-21 Thread David Miller
From: Florian Fainelli Date: Wed, 20 Apr 2016 11:37:07 -0700 > These two patches are very analoguous to what was already submitted for > BCMGENET and switch the SYSTEMPORT driver to utilizing > __napi_schedule_irqoff() > and napi_complete_done for the RX NAPI context. Applied, thanks.

Re: [PATCH net 0/4] Mellaox 40G driver fixes for 4.6-rc

2016-04-21 Thread David Miller
From: Or Gerlitz Date: Wed, 20 Apr 2016 16:01:14 +0300 > With the fix for ARM bug being under the works, these are > few other fixes for mlx4 we have ready to go. > > Eran addressed the problematic/wrong reporting of dropped packets, Daniel > fixed some matters related to PPC EEH's and Jenny's

Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero

2016-04-21 Thread Saeed Mahameed
On Thu, Apr 21, 2016 at 9:04 PM, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 19 Apr 2016 15:33:42 +0300 > >> Upon ethtool request to set speed to 0 we handle it as a special request >> to reset link modes to Device's defaults. >> >> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to

Re: [PATCH] net: phy: spi_ks8895: Don't leak references to SPI devices

2016-04-21 Thread David Miller
From: Mark Brown Date: Wed, 20 Apr 2016 12:54:05 +0100 > The ks8895 driver is using spi_dev_get() apparently just to take a copy > of the SPI device used to instantiate it but never calls spi_dev_put() > to free it. Since the device is guaranteed to exist between probe() and > remove() there sho

Re: [PATCH 2/2] net: ethernet: davinci_emac: Fix platform_data overwrite

2016-04-21 Thread David Miller
From: Neil Armstrong Date: Wed, 20 Apr 2016 10:56:45 +0200 > When the DaVinci emac driver is removed and re-probed, the actual > pdev->dev.platform_data is populated with an unwanted valid pointer saved by > the previous davinci_emac_of_get_pdata() call, causing a kernel crash when > calling priv

Re: [PATCH 1/2] net: ethernet: davinci_emac: Fix Unbalanced pm_runtime_enable

2016-04-21 Thread David Miller
From: Neil Armstrong Date: Wed, 20 Apr 2016 10:56:13 +0200 > In order to avoid an Unbalanced pm_runtime_enable in the DaVinci > emac driver when the device is removed and re-probed, and a > pm_runtime_disable() call in davinci_emac_remove(). > > Actually, using unbind/bind on a TI DM8168 SoC giv

Re: [PATCH net-next 0/2] tcp: Handle txstamp_ack when fragmenting/coalescing skbs

2016-04-21 Thread David Miller
From: Martin KaFai Lau Date: Tue, 19 Apr 2016 22:50:46 -0700 > The second patch depends on the recently posted series > for the net branch: > "tcp: Merge timestamp info when coalescing skbs" I'll therefore apply this after I do my next merge of net into net-next, just FYI...

Re: [PATCH v2 net 0/3] qede: Bug fixes

2016-04-21 Thread David Miller
From: Manish Chopra Date: Wed, 20 Apr 2016 03:03:26 -0400 > This series fixes - > > * various memory allocation failure flows for fastpath > * issues with respect to driver GRO packets handling > > V1->V2 > > * Send series against net instead of net-next. > > Please consider applying this ser

[PATCH net v2 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same codepath as if the phy-

Re: [PATCH net 0/2] tcp: Merge timestamp info when coalescing skbs

2016-04-21 Thread David Miller
From: Martin KaFai Lau Date: Tue, 19 Apr 2016 22:39:27 -0700 > This series is separated from the RFC series related to > tcp_sendmsg(MSG_EOR) and it is targeting for the net branch. > This patchset is focusing on fixing cases where TCP > timestamp could be lost after coalescing skbs. > > A BPF p

Re: [PATCH net-next] macvlan: fix failure during registration v2

2016-04-21 Thread Francesco Ruggeri
On Thu, Apr 21, 2016 at 10:44 AM, Eric W. Biederman wrote: < >> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c >> index 95394ed..e770221 100644 >> --- a/drivers/net/macvtap.c >> +++ b/drivers/net/macvtap.c >> @@ -1303,6 +1303,8 @@ static int macvtap_device_event(struct notifier_block

Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

2016-04-21 Thread David Miller
From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:09:49 +0300 > The cpsw_ndo_open() could try to access CPSW registers before > calling pm_runtime_get_sync(). This will trigger L3 error: > > WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 > l3_interrupt_handler+0x220/0x34c() > 44

[PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was specified and the subsequent of_phy_c

Re: [PATCH net-next v2 0/4] libnl: enhance API to ease 64bit alignment for attribute

2016-04-21 Thread David Miller
From: Nicolas Dichtel Date: Thu, 21 Apr 2016 18:58:23 +0200 > Here is a proposal to add more helpers in the libnetlink to manage 64-bit > alignment issues. > Note that this series was only tested on x86 by tweeking > CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS and adding some traces. > > The first pa

[PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be in cpsw_slave_data rather than cpsw_priv. This wou

Re: [net-next PATCH 2/2] veth: Update features to include all tunnel GSO types

2016-04-21 Thread David Miller
From: Alexander Duyck Date: Tue, 19 Apr 2016 14:02:26 -0400 > This patch adds support for the checksum enabled versions of UDP and GRE > tunnels. With this change we should be able to send and receive GSO frames > of these types over the veth pair without needing to segment the packets. > > Sig

Re: [net-next PATCH 1/2] netdev_features: Fold NETIF_F_ALL_TSO into NETIF_F_GSO_SOFTWARE

2016-04-21 Thread David Miller
From: Alexander Duyck Date: Tue, 19 Apr 2016 14:02:19 -0400 > This patch folds NETIF_F_ALL_TSO into the bitmask for NETIF_F_GSO_SOFTWARE. > The idea is to avoid duplication of defines since the only difference > between the two was the GSO_UDP bit. > > Signed-off-by: Alexander Duyck Applied.

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: > Current code writes the tx/rx relaxed order without reading it first. > This can lead to unintended consequences as we are forcibly writing > other bits. The consequences were very much intended as there are situations where enabling relaxed o

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-21 Thread Hannes Frederic Sowa
On 21.04.2016 15:31, Eric Dumazet wrote: > On Thu, 2016-04-21 at 05:05 -0400, valdis.kletni...@vt.edu wrote: >> On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: >>> Hi, >>> >>> On Thu, Apr 21, 2016, at 02:30, Valdis Kletnieks wrote: linux-next 20160420 is whining at an incredible

Re: [patch -next] geneve: testing the wrong variable in geneve6_build_skb()

2016-04-21 Thread David Miller
From: Dan Carpenter Date: Tue, 19 Apr 2016 17:30:56 +0300 > We intended to test "err" and not "skb". > > Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int > and doesn't free skb') > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero

2016-04-21 Thread David Miller
From: David Miller Date: Thu, 21 Apr 2016 14:04:54 -0400 (EDT) > From: Saeed Mahameed > Date: Tue, 19 Apr 2016 15:33:42 +0300 > >> Upon ethtool request to set speed to 0 we handle it as a special request >> to reset link modes to Device's defaults. >> >> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend

[PATCH net 1/1] qlcnic: Update version to 5.3.64

2016-04-21 Thread Manish Chopra
Just updating the version as many fixes got accumulated over 5.3.63 Signed-off-by: Manish Chopra --- drivers/net/ethernet/qlogic/qlcnic/qlcnic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic.h b/drivers/net/ethernet/qlogic/qlcn

Re: [PATCH net 9/9] net/mlx5e: Reset link modes upon setting speed to zero

2016-04-21 Thread David Miller
From: Saeed Mahameed Date: Tue, 19 Apr 2016 15:33:42 +0300 > Upon ethtool request to set speed to 0 we handle it as a special request > to reset link modes to Device's defaults. > > Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4 > Ethernet functionality") > Signed-off-by:

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-21 Thread Timur Tabi
Florian Fainelli wrote: Well, PHYLIB does prefer using MDIO accesses to "speak" to PHYs, built-in or external, but there is always the option of investing into some custom development with the subsystem to make it play nicely with your HW. So I've done some more research, and I believe that th

Re: [PATCH net-next] NLA_BINARY misuse bug in HSR

2016-04-21 Thread David Miller
From: Peter Heise Date: Tue, 19 Apr 2016 13:34:28 +0200 > Removed .type field from NLA to do proper length checking. > Reported by Daniel Borkmann and Julia Lawall. > > Signed-off-by: Peter Heise Applied.

Re: [PATCHv3 net-next] net: use jiffies_to_msecs to replace EXPIRES_IN_MS in inet/sctp_diag

2016-04-21 Thread David Miller
From: Xin Long Date: Tue, 19 Apr 2016 15:10:01 +0800 > EXPIRES_IN_MS macro comes from net/ipv4/inet_diag.c and dates > back to before jiffies_to_msecs() has been introduced. > > Now we can remove it and use jiffies_to_msecs(). > > Signed-off-by: Xin Long Applied, thanks.

[PATCH v2 net-next] tcp-tso: do not split TSO packets at retransmit time

2016-04-21 Thread Eric Dumazet
Linux TCP stack painfully segments all TSO/GSO packets before retransmits. This was fine back in the days when TSO/GSO were emerging, with their bugs, but we believe the dark age is over. Keeping big packets in write queues, but also in stack traversal has a lot of benefits. - Less memory overhe

Re: [PATCH net-next] macvlan: fix failure during registration v2

2016-04-21 Thread Eric W. Biederman
Francesco Ruggeri writes: > If macvlan_common_newlink fails in register_netdevice after macvlan_init > then it decrements port->count twice, first in macvlan_uninit (from > register_netdevice or rollback_registered) and then again in > macvlan_common_newlink. > A similar problem may exist in the

[PATCH net v2 0/3] drivers: net: cpsw: phy-handle fixes

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin The first patch fixes a bug that makes dual_emac mode break if either slave uses the phy-handle property in the devicetree. The second patch fixes some cosmetic problems with error messages, and also makes the binding documentation more explicit. The third patch cleans up th

Re: [PATCH net-next] perf, bpf: minimize the size of perf_trace_() tracepoint handler

2016-04-21 Thread David Miller
From: Alexei Starovoitov Date: Mon, 18 Apr 2016 20:11:50 -0700 > move trace_call_bpf() into helper function to minimize the size > of perf_trace_*() tracepoint handlers. > text data bss dechex filename > 10541679 5526646 2945024 190133491221ee5 vmlinu

Re: drop all fragments inside tx queue if one gets dropped

2016-04-21 Thread Michael Richardson
Rick Jones wrote: > I don't recall seeing similar poor behaviour in Linux; I would have > assumed > that the intra-stack flow-control "took care" of it. Perhaps there is > something specific to wpan which precludes that? The major user of big UDP packets in the 1990s was NFS. I

Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

2016-04-21 Thread David Miller
From: Martin KaFai Lau Date: Mon, 18 Apr 2016 15:39:53 -0700 > Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, > it could incorrectly think that a skb has already > been acked and queue a SCM_TSTAMP_ACK cmsg to the > sk->sk_error_queue. > > In tcp_ack_tstamp(), it checks > 'b

Re: [PATCH net-next] net: dsa: remove tag_protocol from dsa_switch

2016-04-21 Thread David Miller
From: Vivien Didelot Date: Mon, 18 Apr 2016 18:24:04 -0400 > Having the tag protocol in dsa_switch_driver for setup time and in > dsa_switch_tree for runtime is enough. Remove dsa_switch's one. > > Signed-off-by: Vivien Didelot Applied.

Re: [PATCHv2 net] openvswitch: Orphan skbs before IPv6 defrag

2016-04-21 Thread David Miller
From: Joe Stringer Date: Mon, 18 Apr 2016 14:51:47 -0700 > This is the IPv6 counterpart to commit 8282f27449bf ("inet: frag: Always > orphan skbs inside ip_defrag()"). > > Prior to commit 029f7f3b8701 ("netfilter: ipv6: nf_defrag: avoid/free > clone operations"), ipv6 fragments sent to nf_ct_fra

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

2016-04-21 Thread Edward Cree
On 19/04/16 14:37, Edward Cree wrote: > Also involved adding a way to run a netfilter hook over a list of packets. Turns out, this breaks the build if netfilter is *disabled*, because I forgot to add a stub in that case. Next version of patch (if there is one) will have the following under #ifndef

[PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Babu Moger
Current code writes the tx/rx relaxed order without reading it first. This can lead to unintended consequences as we are forcibly writing other bits. We noticed this problem while testing VF driver on sparc. Relaxed order settings for rx queue were all messed up which was causing performance drop

[PATCH net-next v2 4/4] ip6mr: align RTA_MFC_STATS on 64-bit

2016-04-21 Thread Nicolas Dichtel
Signed-off-by: Nicolas Dichtel --- net/ipv6/ip6mr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index a10e77103c88..bf678324fd52 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -2268,7 +2268,7 @@ static int __ip6mr_fill_mrout

  1   2   >