Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/net/atl1/atl1_main.c
+++ b/drivers/net/atl1/atl1_main.c
@@ -634,14 +634,13 @@ static void atl1_intr_tx(struct atl1_adapter *adapter
Code will do local_irq_save() on it.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/macmace.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/macmace.c
+++ b/drivers/net/macmace.c
@@ -577,7 +577,7 @@ static irqreturn_t mace_interrupt(int irq, void
* Use __be16, __be32.
* Add SCTP_NL() in the spirit of SCTP_U32() and friends.
* Tiny tweak in sctp_chunk_assign_ssn().
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/sctp.h | 60 ++---
include/net/sctp/command.h |2
[linux-kernel dropped, netdev added]
On Fri, Jul 29, 2005 at 08:15:20PM +0800, [EMAIL PROTECTED] wrote:
We want to extract our LAN card driver from tulip core driver and make a
new file uli526x.c at tulip folder,
because we have added some ethtool interface support and non-eprom support
in
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/TUNABLE | 11 ---
1 files changed, 11 deletions(-)
--- linux-vanilla/net/TUNABLE
+++ linux-net-TUNABLE/net/TUNABLE
@@ -15,30 +15,19 @@ AX25_DEF_N2
AX25_DEF_AXDEFMODE 8 = normal 128 is PE1CHL extended
AX25_DEF_IPDEFMODE
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
Documentation/feature-removal-schedule.txt |8
1 files changed, 8 insertions(+)
--- linux-vanilla/Documentation/feature-removal-schedule.txt
+++ linux-farsync/Documentation/feature-removal-schedule.txt
@@ -121,6 +121,14 @@ Who
The rest of endian warnings now belongs to tr.c exclusively.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/hippidevice.h |3 +--
include/linux/if_fc.h |2 +-
include/linux/if_fddi.h |2 +-
include/linux/if_hippi.h|6 +++---
net/802/fc.c
* usual s/u32/__be32/.
* add svc_getnl(), svc_putnl() in spirit of svc_getu32(), svc_putu32().
They return and accept __be32 instead of __u32, respectively.
* convert to svc_getnl(), svc_putnl().
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/sunrpc/auth.h | 16
On Mon, Sep 05, 2005 at 09:48:57PM +0100, [EMAIL PROTECTED] wrote:
On Mon, Sep 05, 2005 at 10:55:58PM +0400, Alexey Dobriyan wrote:
* add svc_getnl(), svc_putnl() in spirit of svc_getu32(), svc_putu32().
They return and accept __be32 instead of __u32, respectively.
* convert to svc_getnl
On 9/6/05, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
On Tue, Sep 06, 2005 at 12:21:05PM +0400, Alexey Dobriyan wrote:
* add svc_getnl():
Take network-endian value from buffer, convert to host-endian
one and return it.
* add svc_putnl():
Take host-endian value, convert
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/wireless/atmel.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/atmel.c
+++ b/drivers/net/wireless/atmel.c
@@ -2217,7 +2217,7 @@ static int atmel_get_range(struct net_de
int k,i,j
From: Clemens Buchacher [EMAIL PROTECTED]
It's deprecated. Use %s, __FUNCTION__ instead.
Signed-off-by: Clemens Buchacher [EMAIL PROTECTED]
Signed-off-by: Maximilian Attems [EMAIL PROTECTED]
Signed-off-by: Domen Puncer [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Index
From: Christophe Lucas [EMAIL PROTECTED]
Signed-off-by: Christophe Lucas [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Index: linux-kj/drivers/net/wireless/atmel.c
===
--- linux-kj.orig/drivers/net/wireless
From: Tobias Klauser [EMAIL PROTECTED]
grep gt64240eth -r . didn't show anything.
Signed-off-by: Tobias Klauser [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Index: linux-kj/drivers/net/gt64240eth.h
From: Tobias Klauser [EMAIL PROTECTED]
grep lmc_prot\. -r . didn't show anything.
Signed-off-by: Tobias Klauser [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Index: linux-kj/drivers/net/wan/lmc/lmc_prot.h
From: Carlo Perassi [EMAIL PROTECTED]
Reading this driver I noticed some trailing whitespaces and tabs so I
removed them with some 80th column fitting and a few more similar
things.
Signed-off-by: Carlo Perassi [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net
It looks like diffs array is write-only. It also looks like ipv4
occurences use some csum_fold() trickery. Was is forgotten here? Should
diffs be removed?
20 static unsigned int ip6t_hl_target(struct sk_buff **pskb,
21 const struct net_device *in,
Only authors of proprietary modules you loaded can debug this.
Please, redirect this and all futher oopses to them.
On 9/18/06, Joe Jin [EMAIL PROTECTED] wrote:
while I try to transmit a 8k data by send() on my laptap T60, kernel
panic occured:
Modules linked in: rds cisco_ipsec parport_pc
sparse defined twice warning
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/netfilter/xt_policy.c |2 --
1 file changed, 2 deletions(-)
--- a/net/netfilter/xt_policy.c
+++ b/net/netfilter/xt_policy.c
@@ -171,7 +171,6 @@ static struct xt_match policy_match = {
.match
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/wireless/prism54/isl_oid.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
--- a/drivers/net/wireless/prism54/isl_oid.h
+++ b/drivers/net/wireless/prism54/isl_oid.h
@@ -106,14 +106,14 @@ struct
From: Andi Drebes [EMAIL PROTECTED]
textdata bss dec hex filename
20015 480 28 20523502b drivers/atm/he.o
19997 480 28 205055019 drivers/atm/he.o
Signed-off-by: Andi Drebes [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED
On Sun, Dec 17, 2006 at 07:28:06PM +0100, Adrian Bunk wrote:
On Sun, Dec 17, 2006 at 03:56:22PM +0300, Alexey Dobriyan wrote:
From: Andi Drebes [EMAIL PROTECTED]
textdata bss dec hex filename
20015 480 28 20523502b drivers/atm/he.o
19997 480
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/netfilter/xt_hashlimit.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/netfilter/xt_hashlimit.c
+++ b/net/netfilter/xt_hashlimit.c
@@ -745,7 +745,7 @@ static int __init xt_hashlimit_init(void
On 1/11/07, Adrian Bunk [EMAIL PROTECTED] wrote:
This patch contains the following cleanups:
- make the following needlessly global functions static:
- lock_adapter_irq()
- unlock_adapter_irq()
These are 1:1 wrappers around spinlock_irqsave/restore. Just remove them.
-
To unsubscribe from
igmpv3_newpack() uses alloc_skb() with GFP_ATOMIC.
It fails, igmpv3_newpack() returns NULL.
add_grhead(), sees NULL, returns NULL.
At one place add_grhead() return value fed into skb_put() which
dereferences it.
net/ipv4/igmp.c:
454 if (first) {
455
On Tue, Jan 30, 2007 at 03:34:18AM -0800, David Stevens wrote:
I think you're correct-- looks like it needs:
if (!skb)
return NULL;
just before the skb_put(), since an allocation (and failure)
could occur in either the igmpv3_newpack() call or in
OK, now that we aren't seeing crashes which can be attributed to these
NULL dereferences any longer.
--
add_grhead() allocates memory with GFP_ATOMIC and in at least two places skb
from it passed to skb_put() without checking.
Signed-off-by: Alexey Dobriyan
On Thu, Apr 20, 2006 at 06:55:58PM -0400, Jeff Garzik wrote:
Also, janitors, there are more NIC specs at
http://gkernel.sourceforge.net/specs/ than are listed on the wiki. What
I posted is just a starter list. If someone were to comb through each
PDF in the /specs/ sub-directories, and make
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
--- a/net/ipv6/netfilter/ip6t_eui64.c
+++ b/net/ipv6/netfilter/ip6t_eui64.c
@@ -38,11 +38,11 @@ match(const struct sk_buff *skb,
return 0;
}
memset(eui64, 0, sizeof(eui64));
- if (eth_hdr(skb)-h_proto
Casting BE16 to int and back may or may not work. Correct, to be sure.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
--- a/net/ipx/af_ipx.c
+++ b/net/ipx/af_ipx.c
@@ -944,9 +944,9 @@ out:
return rc;
}
-static int ipx_map_frame_type(unsigned char type)
+static __be16
A single caller passes __u32. Inside function net is compared with
__u32 (__be32 really, just wasn't annotated).
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
--- a/net/ipx/ipx_route.c
+++ b/net/ipx/ipx_route.c
@@ -119,7 +119,7 @@ out:
return rc;
}
-static int ipxrtr_delete
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/ipcomp.c |2 +-
net/ipv4/xfrm4_policy.c |2 +-
net/ipv6/ipcomp6.c |2 +-
net/xfrm/xfrm_input.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
--- a/net/ipv4/ipcomp.c
+++ 1/net/ipv4/ipcomp.c
GRE keys are 16 bit.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/netfilter/ip_nat_proto_gre.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/net/ipv4/netfilter/ip_nat_proto_gre.c
+++ 1/net/ipv4/netfilter/ip_nat_proto_gre.c
@@ -49,15 +49,15
GRE keys are 16 bit.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/netfilter/ip_nat_proto_gre.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
--- a/net/ipv4/netfilter/ip_nat_proto_gre.c
+++ 1/net/ipv4/netfilter/ip_nat_proto_gre.c
@@ -81,14 +81,14
I'm talking about net/netfilter/nfnetlink_log.c::^nfulnl_recv_config
below. I'm totally confused and beer supply almost ended, so can someone else
also look at it...
Put your attention at line 905:
net/netfilter/nfnetlink_log.c:
902 if (nfula[NFULA_CFG_FLAGS-1]) {
903
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
--- a/net/irda/iriap.c
+++ 1/net/irda/iriap.c
@@ -544,7 +544,8 @@ static void iriap_getvaluebyclass_respon
{
struct sk_buff *tx_skb;
int n;
- __u32 tmp_be32, tmp_be16;
+ __u32 tmp_be32;
+ __be16 tmp_be16
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
--- a/include/net/irda/irlmp.h
+++ 1/include/net/irda/irlmp.h
@@ -112,7 +112,7 @@ struct lsap_cb {
struct timer_list watchdog_timer;
- IRLMP_STATE lsap_state; /* Connection state */
+ LSAP_STATE lsap_state
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/ieee1394/eth1394.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/drivers/ieee1394/eth1394.c
+++ 1/drivers/ieee1394/eth1394.c
@@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap(
*(u32
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/atmbr2684.h |4 ++--
include/linux/atmmpc.h|8
net/atm/br2684.c |2 +-
net/atm/clip.c|4 ++--
net/atm/lec.c |2 +-
net/atm/mpc.c | 20
- Forwarded message from Paul P Komkoff Jr [EMAIL PROTECTED] -
From: Paul P Komkoff Jr [EMAIL PROTECTED]
To: Linux Kernel Mailing List linux-kernel@vger.kernel.org
Subject: Was change to ip_push_pending_frames intended to break udp (more
specifically, WCCP?)
Hello!
I have a userspace
GRE keys are 16-bit wide.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/netfilter/ip_conntrack_proto_gre.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- a/net/ipv4/netfilter/ip_conntrack_proto_gre.c
+++ b/net/ipv4/netfilter/ip_conntrack_proto_gre.c
All users except two expect 32-bit big-endian value. One is of
-multiaddr = -multiaddr
variety. And last one is %08lX.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/igmp.h |2 +-
net/ipv4/igmp.c |2 +-
2 files changed, 2 insertions(+), 2 deletions
On Sat, May 27, 2006 at 12:05:40PM +0200, Stefan Richter wrote:
Alexey Dobriyan wrote on 2006-05-16:
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
...
@@ -935,7 +935,7 @@ static inline u16 ether1394_parse_encap(
*(u32*)arp_ptr = arp1394-sip; /* move sender IP addr
All users pass 32-bit values as addresses and internally they're compared with
32-bit entities. So, change laddr and raddr types to __be32.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/net/raw.h |2 +-
net/ipv4/raw.c|2 +-
2 files changed, 2 insertions(+), 2
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
Also, there is the following snippet in net/ipx/af_ipx.c, line 1174
f.ipx_special = sipx-sipx_special;
The former is unsigned char and is compared with 1 and 2. The latter is
__be16 if I'm not mistaken. Is there a bug hiding
On Mon, Jun 05, 2006 at 09:07:07PM -0700, David Miller wrote:
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Sun, 28 May 2006 01:09:32 +0400
All users pass 32-bit values as addresses and internally they're compared
with
32-bit entities. So, change laddr and raddr types to __be32
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/bnx2.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -1820,7 +1820,7 @@ reuse_rx:
skb-protocol = eth_type_trans(skb, bp-dev
From: Marcelo Feitoza Parisi [EMAIL PROTECTED]
They deal with wrapping correctly and are nicer to read. Also make
jiffies-holding variables unsigned long.
Signed-off-by: Marcelo Feitoza Parisi [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/3c523.c
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/chelsio/cpl5_cmd.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-vanilla/drivers/net/chelsio/cpl5_cmd.h2005-12-22
17:04:34.0 +0300
+++ linux-endian/drivers/net/chelsio/cpl5_cmd.h 2005-12
Turning struct iphdr::tot_len into __be16 added sparse warning.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index cefb0c0..729a107 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -3650,7 +3650,7 @@ static int tg3_start_xmit(struct
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/if_vlan.h |2 +-
net/8021q/vlan_dev.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -44,7 +44,7 @@ struct vlan_ethhdr {
unsigned char
And fix trivial warnings that emerged.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/ip.h | 10 +-
net/ipv4/ip_fragment.c |2 +-
net/ipv4/ip_output.c |4 ++--
net/ipv4/ipvs/ip_vs_xmit.c |2 +-
4 files changed, 9 insertions(+), 9
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/inet.h |2 +-
net/core/utils.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/include/linux/inet.h
+++ b/include/linux/inet.h
@@ -45,6 +45,6 @@
#ifdef __KERNEL__
#include linux/types.h
-extern
From: Eric Sesterhenn [EMAIL PROTECTED]
Since get_settings() returns a signed int and it gets checked
for 0 to catch an error, res should be a signed int too.
Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/bonding/bond_main.c
From: Eric Sesterhenn [EMAIL PROTECTED]
tmp in ace_init is u32 thus rendering read_eeprom_byte() return values
checks useless.
Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
--- a/drivers/net/acenic.c
+++ b/drivers/net/acenic.c
@@ -1002,6
It's not used. Fix the following on alpha-eb66 as a side effect:
In file included from drivers/net/lp486e.c:75:
include/asm/io.h:20:1: warning: SLOW_DOWN_IO redefined
drivers/net/lp486e.c:59:1: warning: this is the location of the previous
definition
Signed-off-by: Alexey Dobriyan [EMAIL
priv-eeprom is a pointer.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/wireless/ipw2200.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/wireless/ipw2200.c
+++ b/drivers/net/wireless/ipw2200.c
@@ -2456,7 +2456,7 @@ static void
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
ppp is the biggest offender.
drivers/net/ppp_async.c | 34 ++--
drivers/net/ppp_generic.c | 128 +++---
drivers/net/ppp_synctty.c | 26 -
drivers/net/pppoe.c |2
4
Main griefs:
a) home-grown lock debugger (what can it do what lockdep can't?)
b) lack of endian annotations.
c) driver fallbacks to USA regulatory domain if it can't find valid one
from the list. My gut feeling is that this can bring an unattentive Linux
user to police on bad day.
lesser
On Wed, Nov 01, 2006 at 03:06:24PM +0100, Florian Westphal wrote:
convert sprintf(a,b) to strcpy(a,b). Make tipc_bclink_name[] const.
Ahhh, I missed the start of threads.
Patch is useless because it changes one unbounded string function into
another unbounded string function.
---
On Mon, Nov 06, 2006 at 03:21:48PM +0100, Adrian Bunk wrote:
This patch fixes a use-after-free for skb spotted by the Coverity
checker.
--- linux-2.6/drivers/net/wireless/hostap/hostap_80211_rx.c.old
+++ linux-2.6/drivers/net/wireless/hostap/hostap_80211_rx.c
@@ -1004,10 +1004,10 @@ void
6.5.7(5): The result of E1 E2 is E1 right-shifted E2 bit positions.
...
If E1 has a signed type and a negative value, the resulting value
is implementation defined.
So, cast -1 to unsigned type to make result well-defined.
Signed-off-by: Alexey Dobriyan [EMAIL
On Tue, Nov 28, 2006 at 03:33:25PM -0800, David Miller wrote:
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Wed, 22 Nov 2006 00:22:51 +0300
[CCing netdev, bug in pktgen]
[build modular pktgen]
while true; do modprobe pktgen rmmod pktgen; done
BUG: warning at fs/proc
On 11/30/06, David Miller [EMAIL PROTECTED] wrote:
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Wed, 29 Nov 2006 23:04:37 +0300
Looks like worker thread strategically clears it if scheduled at wrong
moment.
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -3292,7 +3292,6 @@ static void
On 12/1/06, Robert Olsson [EMAIL PROTECTED] wrote:
David Miller writes:
Agreed.
Robert, please fix this by using a completion so that we can
wait for the threads to start up, something like this:
Included. It passes my test but Alexey and others test.
Confused now. Is my t-control =
David Binderman's icc logs:
net/rose/rose_route.c(399): remark #593: variable err was set but never used
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/rose/rose_route.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/net/rose/rose_route.c
+++ b/net/rose
* d_alloc() in sock_attach_fd() fails leaving -f_dentry of new file NULL
* bail out to out_fd label, doing fput()/__fput() on new file
* but __fput() assumes valid -f_dentry and dereferences it
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/socket.c |7 ++-
1 file changed, 6
On Fri, Mar 30, 2007 at 07:39:04AM -0700, Kok, Auke wrote:
Alexey Dobriyan wrote:
CC [M] drivers/net/e1000/e1000_main.o
drivers/net/e1000/e1000_main.c: In function 'e1000_tso':
drivers/net/e1000/e1000_main.c:2968: error: dereferencing pointer to
incomplete type
...
can you send
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
Compile-tested only.
drivers/net/ehea/ehea_main.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -1799,14 +1799,15 @@ static void ehea_xmit3(struct
Copied from b44 driver, but it works:
netconsole: device eth0 not up yet, forcing it
atl1: eth0 link is up 100 Mbps full duplex
netconsole: network logging started
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c | 12
1 file changed, 12
On Wed, Feb 08, 2006 at 02:45:08PM -0800, David Stevens wrote:
[EMAIL PROTECTED] wrote on 02/08/2006 02:19:20 PM:
James Carlson [EMAIL PROTECTED] wrote:
Alexey Dobriyan writes:
- if (ap == 0)
+ if (!ap)
And the solution is to treat it as a boolean instead?! I'm
On Fri, Mar 03, 2006 at 01:42:34PM -0800, Chris Leech wrote:
Any socket recv of less than this ammount will not be offloaded
There is no documentation update.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
From: Eric Sesterhenn [EMAIL PROTECTED]
memset() is called before check.
Signed-off-by: Eric Sesterhenn [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/chelsio/espi.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/net/chelsio
On Fri, Apr 07, 2006 at 06:11:34PM -0500, Linas Vepstas wrote:
--- linux-2.6.17-rc1.orig/drivers/net/e100.c
+++ linux-2.6.17-rc1/drivers/net/e100.c
+ * @state: The current pci conneection state
connection
+static pci_ers_result_t e100_io_error_detected(struct pci_dev *pdev,
On Mon, Feb 05, 2007 at 07:00:44PM +0200, Ahmed S. Darwish wrote:
A trivial patch to use ARRAY_SIZE macro.
You're supposed to remove it ans use ARRAY_SIZE where old macro is used.
--- a/drivers/net/wireless/wavelan.p.h
+++ b/drivers/net/wireless/wavelan.p.h
@@ -450,7 +450,7 @@ static const
On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote:
A patch to use ARRAY_SIZE macro already defined in kernel.h.
Remove it and use ARRAY_SIZE instead.
--- a/drivers/net/ixgb/ixgb_param.c
+++ b/drivers/net/ixgb/ixgb_param.c
@@ -245,7 +245,7 @@ ixgb_validate_option(int *value,
On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote:
A patch to use ARRAY_SIZE macro already defined in kernel.h.
OK, but checks you're changing are strange. idx there is signed so
BUG_ON(idx 0 || idx ARRAY_SIZE());
should be more appropriate.
---
On Thu, Feb 08, 2007 at 10:14:31AM +1100, ahendry wrote:
echo 1 /proc/sys/net/x25/x25_forward
To turn on x25_forwarding, defaults to off
--- linux-2.6.20-vanilla/include/linux/sysctl.h
+++ linux-2.6.20/include/linux/sysctl.h
@@ -699,7 +699,8 @@ enum {
NET_X25_CALL_REQUEST_TIMEOUT=2,
On Thu, Feb 08, 2007 at 11:19:09PM +0300, Alexey Dobriyan wrote:
On Thu, Feb 08, 2007 at 10:14:31AM +1100, ahendry wrote:
echo 1 /proc/sys/net/x25/x25_forward
To turn on x25_forwarding, defaults to off
--- linux-2.6.20-vanilla/include/linux/sysctl.h
+++ linux-2.6.20/include/linux
[removing l-k from CC, and switching to netdev]
Please, send your .config.
Is it reproducible?
On Mon, Feb 12, 2007 at 03:16:04PM +0100, Charles-Edouard Ruault wrote:
i upgraded to vanilla kernel 2.6.20 and while i was using strongswan
2.8.2 to setup an IPSEC VPN i got the following kernel
ANK says: It is rarely used, that's wy it was not noticed.
But in the places, where it is used, it should be disaster.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/core/skbuff.c |1 +
1 file changed, 1 insertion(+)
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -463,6
On 3/20/07, Keiichi KII [EMAIL PROTECTED] wrote:
This patch contains the following changes for supporting multiple logging
agents.
+#define CONFIG_SEPARATOR ;
CONFIG_* is reserved for configuration options. Since you use
it in only one place just use semicolon directly.
-
To unsubscribe
On 3/20/07, Keiichi KII [EMAIL PROTECTED] wrote:
We add ioctls for adding/removing target.
If we use NETCONSOLE_ADD_TARGET ioctl,
we can dynamically add netconsole target.
If we use NETCONSOLE_REMOVE_TARGET ioctl,
we can dynamically remoe netconsole target.
We attach a sample program for ioctl.
From: Christophe Lucas [EMAIL PROTECTED]
Signed-off-by: Christophe Lucas [EMAIL PROTECTED]
Signed-off-by: Domen Puncer [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/3c59x.c |2 +-
drivers/net/8139cp.c
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
--- a/drivers/net/sunlance.c
+++ b/drivers/net/sunlance.c
@@ -1537,7 +1537,7 @@ static int __init sparc_lance_init(void)
{
if ((idprom-id_machtype == (SM_SUN4|SM_4_330)) ||
(idprom-id_machtype == (SM_SUN4|SM_4_470
-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/netfilter_bridge.h |1 -
1 file changed, 1 deletion(-)
--- a/include/linux/netfilter_bridge.h
+++ b/include/linux/netfilter_bridge.h
@@ -6,7 +6,6 @@ #define __LINUX_BRIDGE_NETFILTER_H
#include linux/netfilter.h
#if defined(__KERNEL__
On Sat, Jul 29, 2006 at 12:55:28AM -0700, Andrew Morton wrote:
On Sat, 29 Jul 2006 11:45:45 +0400
Alexey Dobriyan [EMAIL PROTECTED] wrote:
Header doesn't use anything from atomic.h.
OK, but..
It fixes headers_check warning:
include/linux/netfilter_bridge.h requires asm/atomic.h
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/x86_64/kernel/smp.c |2 +-
include/net/netdma.h |2 +-
net/core/dev.c |4 ++--
net/ipv4/tcp.c |2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
--- a/arch/x86_64/kernel/smp.c
+++ b/arch
FYI, drivers/scsi/esp.c was broken by same changes.
drivers/scsi/esp.c: In function `esp_sun4_probe':
drivers/scsi/esp.c:1149: error: `esp_dev' undeclared (first use in this
function)
drivers/scsi/esp.c:1149: error: (Each undeclared identifier is reported only
once
drivers/scsi/esp.c:1149:
On Wed, Aug 02, 2006 at 05:02:11AM +0200, Andi Kleen wrote:
--- a/arch/x86_64/kernel/smp.c
+++ b/arch/x86_64/kernel/smp.c
@@ -203,7 +203,7 @@ int __cpuinit init_smp_flush(void)
{
int i;
for_each_cpu_mask(i, cpu_possible_map) {
-
On Wed, Aug 09, 2006 at 10:38:20AM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c
+++ kernel/drivers/net/ehea/ehea_main.c
+static inline u64 get_swqe_addr(u64 tmp_addr, int addr_seg)
+{
+ u64 addr;
+ addr = tmp_addr;
+ return addr;
+}
+
+static inline u32 map_swqe_size(u8 swqe_enc_size)
+{
+ return 128 swqe_enc_size;
+}^
+ |
+static inline u32|map_rwqe_size(u8 rwqe_enc_size)
+{|
+ return 128 rwqe_enc_size;
^
+}|
Compile out dead code for CONFIG_PM=n users.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/net/amd8111e.c | 10 +-
drivers/net/b44.c |4
drivers/net/bnx2.c |4
drivers/net/tg3.c |4
4 files changed, 21 insertions(+), 1 deletion
On Fri, Aug 11, 2006 at 06:49:43PM -0700, Andrew Morton wrote:
On Sat, 12 Aug 2006 04:46:23 +0400
Alexey Dobriyan [EMAIL PROTECTED] wrote:
+#ifdef CONFIG_PM
static int amd8111e_suspend(struct pci_dev *pci_dev, pm_message_t state)
{
struct net_device *dev = pci_get_drvdata(pci_dev
On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
Was there noticeable performance difference when explicit prefetching is
removed? At some (invisible) point CPUs will become smarter about prefetching
than programmers and this code will be slower than possible.
+static inline
On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c
+++ kernel/drivers/net/ehea/ehea_ethtool.c
+static int netdev_get_settings(struct net_device *dev, struct ethtool_cmd
*cmd)
+{
+ u64 hret = H_HARDWARE;
useless
On Fri, Aug 18, 2006 at 01:34:57PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h
+++ kernel/drivers/net/ehea/ehea.h
+#include linux/version.h
Not needed.
+#include linux/module.h
+#include linux/moduleparam.h
Really?
+#include linux/kernel.h
On Fri, Aug 18, 2006 at 01:37:44PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4/drivers/net/Kconfig
+++ patched_kernel/drivers/net/Kconfig
@@ -2277,6 +2277,12 @@ config CHELSIO_T1
To compile this driver as a module, choose M here: the module
will be called cxgb.
On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c
+++ kernel/drivers/net/ehea/ehea_main.c
+static struct net_device_stats *ehea_get_stats(struct net_device *dev)
+{
+ int i;
+ u64 hret = H_HARDWARE;
Useless
On Fri, Aug 18, 2006 at 01:30:21PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c
+++ kernel/drivers/net/ehea/ehea_phyp.c
+ hret = ehea_hcall_9arg_9ret(H_QUERY_HEA_QP,
+ hcp_adapter_handle, /* R4 */
+
1 - 100 of 231 matches
Mail list logo
