[PATCH net-next 3/8] pci: add Annapurna Labs PCI id

2017-02-03 Thread Antoine Tenart
Adds the Annapurna Labs vendor id. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 73dda0edcb97..8a11e2d8f35f 100644 --- a/include

[PATCH net-next 7/8] net: ethernet: annapurna: add eee helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Add the get_eee() and set_eee() helpers to support the Energy-Efficient (EEE) feature in the Annapurna Labs Alpine driver. --- drivers/net/ethernet/annapurna/al_eth.c| 44 +++ drivers/net/ethernet/annapurna/al_hw_eth.h | 28 +++

[PATCH net-next 2/8] soc: alpine: add udma helpers

2017-02-03 Thread Antoine Tenart
. The Alpine UDMA is a full-duplex DMA consisting of a Tx (memory to stream -m2s-) and an Rx (stream to memory -s2m-) DMA engines. Multiple queues are available per DMA, with each a description and a completion ring. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drive

[PATCH net-next 8/8] net: ethernet: annapurna: add the coalesce helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Add the get_coalesce() and set_coalesce() helpers to the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 81 + 1 file changed, 81 insertions(+) diff --git a/drivers/net/ethernet/annapurna/al_eth.c

[PATCH net-next 1/8] alpine: add I/O fabric interrupt controller (iofic) helpers

2017-02-03 Thread Antoine Tenart
-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- include/linux/soc/alpine/iofic.h | 165 +++ 1 file changed, 165 insertions(+) create mode 100644 include/linux/soc/alpine/iofic.h diff --git a/include/linux/soc/alpine/iofic.h b/include/linux/soc/

[PATCH net-next 6/8] net: ethernet: annapurna: add wol helpers to the Alpine driver

2017-02-03 Thread Antoine Tenart
Implement the get_wol() and set_wol() helpers in the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 44 + 1 file changed, 44 insertions(+) diff --git a/drivers/net/ethernet/annapurna/al_eth.c

[PATCH net-next 5/8] net: ethernet: annapurna: add statistics helper

2017-02-03 Thread Antoine Tenart
Add the ndo_get_stats64() helper in the Annapurna Labs Alpine Ethernet driver. --- drivers/net/ethernet/annapurna/al_eth.c | 36 drivers/net/ethernet/annapurna/al_hw_eth.h | 9 + drivers/net/ethernet/annapurna/al_hw_eth_main.c | 225 3 files changed,

[PATCH net-next 0/8] ARM: Alpine: Ethernet support

2017-02-03 Thread Antoine Tenart
s per UDMA), and offloading helpers (TSO, checksum offloads...). This was tested on an Alpine v2 (ARM64) platform, and applies on top of net-next (8fe809a99263). Thanks, Antoine Tenart (8): alpine: add I/O fabric interrupt controller (iofic) helpers soc: alpine: add udma helpers pci: add Anna

Re: [PATCH net-next 6/8] net: ethernet: annapurna: add wol helpers to the Alpine driver

2017-02-10 Thread Antoine Tenart
Hi! On Mon, Feb 06, 2017 at 11:35:49AM +, David Laight wrote: > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On > Behalf Of Sergei Shtylyov > > Sent: 03 February 2017 18:22 > > On 02/03/2017 09:12 PM, Antoine Tenart wrote: > > > >

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-07-25 Thread Antoine Tenart
Hi Sergei, On Mon, Jul 24, 2017 at 07:40:01PM +0300, Sergei Shtylyov wrote: > On 07/24/2017 04:48 PM, Antoine Tenart wrote: > > > + /* Set the SMI PHY address */ > > + if (of_property_read_u32(port->phy_node, "reg", _addr)) { > > + netdev_err(po

Re: [PATCH net-next 09/18] net: mvpp2: use named interrupts

2017-07-25 Thread Antoine Tenart
Hi Sergei, On Mon, Jul 24, 2017 at 07:49:03PM +0300, Sergei Shtylyov wrote: > On 07/24/2017 04:48 PM, Antoine Tenart wrote: > > + if (of_get_property(port_node, "interrupt-names", NULL)) { > > + port->irq = of_irq_get_byname(port_node, "rx-shared"

Re: [PATCH net-next 00/18] net: mvpp2: MAC/GoP configuration and optional PHYs

2017-07-25 Thread Antoine Tenart
Hi Marcin, On Tue, Jul 25, 2017 at 01:56:57AM +0200, Marcin Wojtas wrote: > > I stressed 10G interfaces with bidirectional traffic on A8040-DB, did > some up/down sequences and overall it seems stable (of course I needed > fix mentioned in patch 10/18). In a spare moment I'll give other >

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

2017-07-25 Thread Antoine Tenart
Hi Marcin, On Tue, Jul 25, 2017 at 12:58:20AM +0200, Marcin Wojtas wrote: > > This patch requires also: > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 4694d4f..369819f 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++

[PATCH net-next 18/18] arm64: dts: marvell: 8040-db: enable the SFP ports

2017-07-24 Thread Antoine Tenart
This patch enables the SFP ports on the Armada 8040 DB as these ports are now supported by the PPv2 driver (since the PHY is now optional). Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- @Dave: Hi! This patch should go through the mvebu tree. Thanks! arch/arm64/bo

[PATCH net-next 11/18] Documentation/bindings: net: marvell-pp2: add the system controller

2017-07-24 Thread Antoine Tenart
This patch documents the new marvell,system-controller property used by the Marvell ppv2 network driver. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documen

[PATCH net-next 17/18] arm64: dts: marvell: 7040-db: enable the SFP port

2017-07-24 Thread Antoine Tenart
This patch enables the SFP port on the Armada 7040 DB as this port is now supported by the PPv2 driver (since the PHY is now optional). Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- @Dave: Hi! This patch should go through the mvebu tree. Thanks! arch/arm64/bo

[PATCH net-next 00/18] net: mvpp2: MAC/GoP configuration and optional PHYs

2017-07-24 Thread Antoine Tenart
). If that's an issue for this series to be reviewed/merged, I can easily split it into two series, with a dependency of one on the other. @Dave: Patches 13 to 18 should go through the mvebu tree, thanks :) Thanks! Antoine Antoine Tenart (18): net: mvpp2: unify register definitions coding style net

[PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-07-24 Thread Antoine Tenart
When connecting to the PHY, explicitly set the SMI PHY address in the controller registers to configure a given port to be connected to the selected PHY. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 14 ++ 1 file c

[PATCH net-next 05/18] net: mvpp2: initialize the GMAC when using a port

2017-07-24 Thread Antoine Tenart
-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 112 +++ 1 file changed, 87 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c

[PATCH net-next 02/18] net: mvpp2: fix the synchronization module bypass macro name

2017-07-24 Thread Antoine Tenart
The macro defining the bit to toggle to bypass or not the synchronization module is wrongly named. Writing 1 will disable bypass. This patch s/MVPP22_CTRL4_SYNC_BYPASS/MVPP22_CTRL4_SYNC_BYPASS_DIS/. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/et

[PATCH net-next 09/18] net: mvpp2: use named interrupts

2017-07-24 Thread Antoine Tenart
This patch update the Marvell PPv2 driver to use named interrupts. A compatibility path is kept to allow using device trees using the old dt bindings. This change is needed as other interrupts will be used by the PPv2 driver at some point. Signed-off-by: Antoine Tenart <antoine.ten...@f

[PATCH net-next 01/18] net: mvpp2: unify register definitions coding style

2017-07-24 Thread Antoine Tenart
Cosmetic patch to use the same formatting rules on all register definitions. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 88 ++-- 1 file changed, 44 insertions(+), 44 deletions(-) diff

[PATCH net-next 04/18] net: mvpp2: move the mii configuration in the ndo_open path

2017-07-24 Thread Antoine Tenart
This moves the mii configuration in the ndo_open path, to allow handling different mii configurations later and to switch between these configurations at runtime. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 2 +- 1 file chan

[PATCH net-next 08/18] net: mvpp2: make the phy optional

2017-07-24 Thread Antoine Tenart
atch makes the PHY optional, and aligns the PPv2 driver on its device tree documentation. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/driv

[PATCH net-next 07/18] net: mvpp2: initialize the GoP

2017-07-24 Thread Antoine Tenart
The patch adds GoP (group of ports) initialization functions. The mvpp2 driver was relying on the firmware/bootloader initialization; this patch moves this setup to the mvpp2 driver. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c

[PATCH net-next 14/18] arm64: dts: marvell: cp110: add PPv2 port interrupts

2017-07-24 Thread Antoine Tenart
Ports interrupts are used by the PPv2 driver when no PHY is connected to a port. This patch adds a description of these interrupts. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- @Dave: Hi! This patch should go through the mvebu tree. Thanks! arch/arm64/boot/dts/m

[PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

2017-07-24 Thread Antoine Tenart
ports not connected to a PHY cannot work. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 157 ++- 1 file changed, 154 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp

[PATCH net-next 12/18] Documentation/bindings: net: marvell-pp2: add the interrupt-names

2017-07-24 Thread Antoine Tenart
An interrupt-names property can be used in the PPv2 port description bindings when more than a single interrupt (for rx) is used. Document this new optional property. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- Documentation/devicetree/bindings/net/marvell-pp2.t

[PATCH net-next 16/18] arm64: dts: marvell: mcbin: enable more networking ports

2017-07-24 Thread Antoine Tenart
This patch enables the two GE/SFP ports. They are configured in 10GKR mode by default. To do this the cpm_xdmio is enabled as well, and two phy descriptions are added. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- @Dave: Hi! This patch should go through the mveb

[PATCH net-next 15/18] arm64: dts: marvell: add a reference to the sysctrl syscon in the ppv2 node

2017-07-24 Thread Antoine Tenart
The network driver on Marvell SoC (7k/8k) needs to access some registers in the system controller to configure its ports at runtime. This patch adds a phandle reference to the syscon system controller node in the ppv2 node. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.

[PATCH net-next 06/18] net: mvpp2: initialize the XLG MAC when using a port

2017-07-24 Thread Antoine Tenart
, but it helps reducing the gap. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c

[PATCH net-next 13/18] arm64: dts: marvell: cp110: use named interrupts for the Ethernet ports

2017-07-24 Thread Antoine Tenart
The PPv2 driver now uses named interrupts. Add the interrupt-names property to the Ethernet ports to use this new functionality. This is needed as other interrupt descriptions will be added to the Ethernet ports at some point. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.

Re: [PATCH net-next 04/18] net: mvpp2: move the mii configuration in the ndo_open path

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:11:11PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:34PM +0200, Antoine Tenart wrote: > > This moves the mii configuration in the ndo_open path, to allow handling > > different mii configurations later and to

Re: [PATCH net-next 08/18] net: mvpp2: make the phy optional

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:20:00PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:38PM +0200, Antoine Tenart wrote: > > SFP ports do not necessarily need to have an Ethernet PHY between the > > SoC and the actual physical port. However, the driver

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-07-27 Thread Antoine Tenart
Hi Andrew, On Wed, Jul 26, 2017 at 06:08:06PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:33PM +0200, Antoine Tenart wrote: > > > > + if (priv->hw_version != MVPP22) > > + return 0; > > + > > + /* Set the SMI PHY address */ &

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

2017-07-25 Thread Antoine Tenart
Hi Thomas, On Tue, Jul 25, 2017 at 03:17:48PM +0200, Thomas Petazzoni wrote: > On Mon, 24 Jul 2017 15:48:40 +0200, Antoine Tenart wrote: > > + > > + port->link_irq = of_irq_get_byname(port_node, "link"); > > + if (port->link_irq == -EPROBE

Re: [PATCH net-next v2 00/10] net: mvpp2: MAC/GoP configuration

2017-08-22 Thread Antoine Tenart
Hi Andrew, On Tue, Aug 22, 2017 at 08:07:57PM +0200, Andrew Lunn wrote: > On Tue, Aug 22, 2017 at 07:08:20PM +0200, Antoine Tenart wrote: > > > > This is based on net-next (e2a7c34fb285). > > > > I removed the GoP interrupt and PHY optional parts in this v2 to

[PATCH net-next v2 04/10] net: mvpp2: initialize the GMAC when using a port

2017-08-22 Thread Antoine Tenart
-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> --- drivers/net/ethernet/marvell/mvpp2.c | 123 --- 1 file changed, 98 insertions(+), 25 deletions(-) diff --git a/drivers/net/ethernet/marvel

[PATCH net-next v2 07/10] net: mvpp2: initialize the GoP

2017-08-22 Thread Antoine Tenart
The patch adds GoP (group of ports) initialization functions. The mvpp2 driver was relying on the firmware/bootloader initialization; this patch moves this setup to the mvpp2 driver. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@sem

[PATCH net-next v2 03/10] net: mvpp2: move the mii configuration in the ndo_open path

2017-08-22 Thread Antoine Tenart
This moves the mii configuration in the ndo_open path, to allow handling different mii configurations later and to switch between these configurations at runtime. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> ---

[PATCH net-next v2 01/10] net: mvpp2: unify register definitions coding style

2017-08-22 Thread Antoine Tenart
Cosmetic patch to use the same formatting rules on all register definitions. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> --- drivers/net/ethernet/marvell/mvpp2.c | 88 ++-- 1 file

[PATCH net-next v2 08/10] Documentation/bindings: net: marvell-pp2: add the system controller

2017-08-22 Thread Antoine Tenart
This patch documents the new marvell,system-controller property used by the Marvell ppv2 network driver. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 1 + 1

[PATCH net-next v2 02/10] net: mvpp2: fix the synchronization module bypass macro name

2017-08-22 Thread Antoine Tenart
The macro defining the bit to toggle to bypass or not the synchronization module is wrongly named. Writing 1 will disable bypass. This patch s/MVPP22_CTRL4_SYNC_BYPASS/MVPP22_CTRL4_SYNC_BYPASS_DIS/. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Woj

[PATCH net-next v2 06/10] net: mvpp2: set maximum packet size for 10G ports

2017-08-22 Thread Antoine Tenart
From: Stefan Chulski <stef...@marvell.com> Set maximum packet size for XLG 10G ports. Missing maximum packet size for XLG configuration will cause kernel panic if oversized packet is received by port. Signed-off-by: Stefan Chulski <stef...@marvell.com> Signed-off-by: Antoine Tenart

[PATCH net-next v2 05/10] net: mvpp2: initialize the XLG MAC when using a port

2017-08-22 Thread Antoine Tenart
, but it helps reducing the gap. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> --- drivers/net/ethernet/marvell/mvpp2.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/net/ethernet/mar

[PATCH net-next v2 09/10] arm64: dts: marvell: add a reference to the sysctrl syscon in the ppv2 node

2017-08-22 Thread Antoine Tenart
The network driver on Marvell SoC (7k/8k) needs to access some registers in the system controller to configure its ports at runtime. This patch adds a phandle reference to the syscon system controller node in the ppv2 node. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com>

[PATCH net-next v2 00/10] net: mvpp2: MAC/GoP configuration

2017-08-22 Thread Antoine Tenart
support for all RGMII variants. - Added a patch from Stefan Chulski improving / fixing 10G support. - Various small fixes. Antoine Tenart (9): net: mvpp2: unify register definitions coding style net: mvpp2: fix the synchronization module bypass macro name net: mvpp2: move the mii

[PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports

2017-08-22 Thread Antoine Tenart
This patch enables the two GE/SFP ports. They are configured in 10GKR mode by default. To do this the cpm_xdmio is enabled as well, and two phy descriptions are added. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Tested-by: Marcin Wojtas <m...@semihalf.com> ---

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

2017-08-22 Thread Antoine Tenart
Hi Andrew, On Fri, Jul 28, 2017 at 06:21:53AM +0200, Andrew Lunn wrote: > On Thu, Jul 27, 2017 at 06:49:05PM -0700, Antoine Tenart wrote: > > On Wed, Jul 26, 2017 at 06:08:06PM +0200, Andrew Lunn wrote: > > > On Mon, Jul 24, 2017 at 03:48:33PM +0200, An

Re: [PATCH net-next v2 10/10] arm64: dts: marvell: mcbin: enable more networking ports

2017-08-23 Thread Antoine Tenart
Hi Baruch, On Wed, Aug 23, 2017 at 10:28:42AM +0300, Baruch Siach wrote: > On Tue, Aug 22, 2017 at 07:08:30PM +0200, Antoine Tenart wrote: > > This patch enables the two GE/SFP ports. They are configured in 10GKR > > mode by default. To do this the cpm_xdmio is enabled as well,

[PATCH net-next 1/3] net: define the TSO header size in net/tso.h

2017-08-23 Thread Antoine Tenart
The TSO header size was defined in many drivers. Factorize the code and define its size in net/tso.h. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 1 - drivers/net/ethernet/freescale/fec_main.c | 1 - d

[PATCH net-next 2/3] net: mvpp2: unify the txq size define use

2017-08-23 Thread Antoine Tenart
The txq size is defined by MVPP2_AGGR_TXQ_SIZE, which is sometime not used directly but through variables. As it is a fixed value use the define everywhere in the driver. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

2017-08-23 Thread Antoine Tenart
Hi Andrew, Russell, On Wed, Jul 26, 2017 at 06:26:48PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:40PM +0200, Antoine Tenart wrote: > > This patch adds the GoP link interrupt support for when a port isn't > > connected to a PHY. Because of this the phylib callback

[PATCH net-next 0/3] net: mvpp2: software TSO support

2017-08-23 Thread Antoine Tenart
(from 25% to 15%). Thanks! Antoine Antoine Tenart (3): net: define the TSO header size in net/tso.h net: mvpp2: unify the txq size define use net: mvpp2: software tso support drivers/net/ethernet/cavium/thunder/nicvf_queues.h | 1 - drivers/net/ethernet/freescale/fec_main.c | 1

[PATCH net-next 3/3] net: mvpp2: software tso support

2017-08-23 Thread Antoine Tenart
The patch uses the tso API to implement the tso functionality in Marvell PPv2 driver. Using iperf and 10G ports, using TSO shows a significant performance improvement by a factor 2 to reach around 9.5Gbps in TX; as well as a significant CPU usage drop (from 25% to 15%). Signed-off-by: Antoine

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
On Thu, Jun 08, 2017 at 10:45:15AM +0200, Antoine Tenart wrote: > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > > b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > > index 2a99f

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Hi Gregory, On Thu, Jun 08, 2017 at 10:55:01AM +0200, Gregory CLEMENT wrote: > On jeu., juin 08 2017, Antoine Tenart <antoine.ten...@free-electrons.com> > wrote: > > On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > >> diff --git a/arch/arm64/bo

[PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-08 Thread Antoine Tenart
interface is used by 10GbE devices. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- .../devicetree/bindings/net/marvell-orion-mdio.txt | 6 +- drivers/net/ethernet/marvell/Kconfig | 6 +- drivers/net/ethernet/marvell/mvmdio.c

[PATCH v2 0/8] net: mvmdio: add xSMI support

2017-06-08 Thread Antoine Tenart
addition. - Fixed the is_read_valid logic. - Updated to use static const variables for ops. - Added 3 Reviewed-by tags from Florian (I dropped another one as the patch changed in v2). Antoine Tenart (8): net: mvmdio: reorder headers alphabetically net: mvmdio: use tabs for defines net

[PATCH v2 5/8] net: mvmdio: introduce an ops structure

2017-06-08 Thread Antoine Tenart
Introduce an ops structure to add an indirection on functions accessing the registers. This is needed to add the xMDIO support later. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 71 ++-

[PATCH v2 6/8] net: mvmdio: put the poll intervals in the ops structure

2017-06-08 Thread Antoine Tenart
Put the two poll intervals (min and max) in the driver's ops structure. This is needed to add the xmdio support later. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 10 -- 1 file changed, 8 insertions(+), 2 del

[PATCH v2 2/8] net: mvmdio: use tabs for defines

2017-06-08 Thread Antoine Tenart
Cosmetic patch replacing spaces by tabs for defined values. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 26 +- 1 file changed, 13 inser

[PATCH v2 4/8] net: mvmdio: move the read valid check into its own function

2017-06-08 Thread Antoine Tenart
Move the read valid check in its own function. This is needed as a requirement to factorize the driver to add the xMDIO support in the future. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 11 +++ 1 file chan

[PATCH v2 1/8] net: mvmdio: reorder headers alphabetically

2017-06-08 Thread Antoine Tenart
Cosmetic fix reordering headers alphabetically. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --g

[PATCH v2 3/8] net: mvmdio: use GENMASK for masks

2017-06-08 Thread Antoine Tenart
Cosmetic patch to use the GENMASK helper for masks. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v2 8/8] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Add the description of the xMDIO bus for the Marvell Armada 7k and Marvell Armada 8k; for both CP110 slave and master. This bus is found on Marvell Ethernet controllers and provides an interface with the xMDIO bus. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> ---

Re: [PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-08 Thread Antoine Tenart
Hi Gregory, On Wed, Jun 07, 2017 at 10:38:10AM +0200, Antoine Tenart wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > b/arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi > index 2a99ff8fca2a..594356243ddb 100644 > --- a/arch/arm64/boot/dts/marvell/

[PATCH net-next] net: mvpp2: enable basic 10G support

2017-06-12 Thread Antoine Tenart
-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvpp2.c | 49 ++-- 1 file changed, 41 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 33c901

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > This patch adds the xMDIO interface support in the mvmdio driver. This > > interface is used in Ethernet controllers on Marvell 370, 7k and 8k (as > > of now

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hello Florian, Andrew, On Thu, Jun 08, 2017 at 06:55:46PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > On 06/08/2017 02:26 AM, Antoine Tenart wrote: > > > This patch adds the xMDIO interface support in the mvmdio driver. Th

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Thu, Jun 08, 2017 at 06:03:31PM +0200, Andrew Lunn wrote: > On Thu, Jun 08, 2017 at 11:26:52AM +0200, Antoine Tenart wrote: > > +#define MVMDIO_XSMI_MGNT_REG 0x0 > > +#define MVMDIO_XSMI_READ_VALIDBIT(29) > > +#define MVMDIO_XSMI

Re: [PATCH 7/9] net: mvmdio: add xmdio support

2017-06-07 Thread Antoine Tenart
Hi Florian, On Wed, Jun 07, 2017 at 08:48:06AM -0700, Florian Fainelli wrote: > On 06/07/2017 01:38 AM, Antoine Tenart wrote: > > > + if (of_device_is_compatible(np, "marvell,orion-mdio")) { > > + ops->is_done = smi_is_done; > > + o

[PATCH v2] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-07 Thread Antoine Tenart
Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Acked-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Since v1: - Added the Fixes tag. - Added Thomas' Acked-by. drivers/net/ethernet/marvell/mvpp2.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 7/9] net: mvmdio: add xmdio support

2017-06-07 Thread Antoine Tenart
interface is used by 10GbE devices. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/Kconfig | 6 +- drivers/net/ethernet/marvell/mvmdio.c | 121 -- 2 files changed, 104 insertions(+), 23 deletions(-) diff

[PATCH 0/9] net: mvmdio: add xSMI support

2017-06-07 Thread Antoine Tenart
the SMI interface was still working. Thanks, Antoine Antoine Tenart (9): net: mvmdio: reorder headers alphabetically net: mvmdio: use tabs for defines net: mvmdio: use GENMASK for masks net: mvmdio: move the read valid check into its own function net: mvmdio: introduce an ops structure

[PATCH 6/9] net: mvmdio: put the poll intervals in the private structure

2017-06-07 Thread Antoine Tenart
Put the two poll intervals (min and max) in the driver's private structure. This is needed to add the xmdio support later. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 9 +++-- 1 file changed, 7 insertions(+), 2 del

[PATCH 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-07 Thread Antoine Tenart
Add the description of the xMDIO bus for the Marvell Armada 7k and Marvell Armada 8k; for both CP110 slave and master. This bus is found on Marvell Ethernet controllers and provides an interface with the xMDIO bus. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- arch

[PATCH 8/9] dt-bindings: orion-mdio: document the new xmdio compatible

2017-06-07 Thread Antoine Tenart
A new compatible for Marvell xMDIO interfaces was added into the Marvell MDIO driver. Document this new compatible. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- Documentation/devicetree/bindings/net/marvell-orion-mdio.txt | 8 1 file changed, 4 insertions

[PATCH 1/9] net: mvmdio: reorder headers alphabetically

2017-06-07 Thread Antoine Tenart
Cosmetic fix reordering headers alphabetically. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/et

[PATCH 5/9] net: mvmdio: introduce an ops structure

2017-06-07 Thread Antoine Tenart
Introduce an ops structure to add an indirection on functions accessing the registers. This is needed to add the xMDIO support later. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 65 +++

[PATCH 4/9] net: mvmdio: move the read valid check into its own function

2017-06-07 Thread Antoine Tenart
Move the read valid check in its own function. This is needed as a requirement to factorize the driver to add the xMDIO support in the future. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 11 +++ 1 file chan

[PATCH 3/9] net: mvmdio: use GENMASK for masks

2017-06-07 Thread Antoine Tenart
Cosmetic patch to use the GENMASK helper for masks. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/et

[PATCH 2/9] net: mvmdio: use tabs for defines

2017-06-07 Thread Antoine Tenart
Cosmetic patch replacing spaces by tabs for defined values. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/m

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Antoine Tenart
Hello Thomas, On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > On Tue, 6 Jun 2017 15:36:15 +0200, Antoine Tenart wrote: > > The mvpp22_port_mii_set() function was added by 2697582144dd, but the > > function directly returns without doing anything. This return wa

Re: [PATCH] net: mvpp2: do not bypass the mvpp22_port_mii_set function

2017-06-06 Thread Antoine Tenart
Hi Florian, On Tue, Jun 06, 2017 at 07:24:35AM -0700, Florian Fainelli wrote: > On 06/06/2017 06:51 AM, Antoine Tenart wrote: > > On Tue, Jun 06, 2017 at 03:45:35PM +0200, Thomas Petazzoni wrote: > > > >> I am wondering if we shouldn't Cc: stable as well. I don't think

Re: [PATCH 7/9] net: mvmdio: add xmdio support

2017-06-07 Thread Antoine Tenart
Hi Andrew, On Wed, Jun 07, 2017 at 02:12:05PM +0200, Andrew Lunn wrote: > On Wed, Jun 07, 2017 at 10:38:08AM +0200, Antoine Tenart wrote: > > This patch adds the xMDIO interface support in the mvmdio driver. This > > interface is used in Ethernet controllers on Marvell

Re: [PATCH 4/9] net: mvmdio: move the read valid check into its own function

2017-06-07 Thread Antoine Tenart
Hello, On Wed, Jun 07, 2017 at 01:00:21PM +0300, Sergei Shtylyov wrote: > On 6/7/2017 11:38 AM, Antoine Tenart wrote: > > > > - val = readl(dev->regs); > > - if (!(val & MVMDIO_SMI_READ_VALID)) { > > + if (orion_mdio_smi_is_read_valid(dev)) { > >

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Fri, Jun 09, 2017 at 03:26:24PM +0200, Andrew Lunn wrote: > On Fri, Jun 09, 2017 at 10:25:41AM +0200, Antoine Tenart wrote: > > On Thu, Jun 08, 2017 at 09:42:21AM -0700, Florian Fainelli wrote: > > > > > > If I get this right, the xMDIO contro

Re: [PATCH v2 7/8] net: mvmdio: add xmdio support

2017-06-09 Thread Antoine Tenart
Hi Andrew, On Fri, Jun 09, 2017 at 04:49:36PM +0200, Andrew Lunn wrote: > On Fri, Jun 09, 2017 at 04:09:22PM +0200, Antoine Tenart wrote: > > > > The MDIO/xMDIO registers are embedded into the network controller. The > > mvmdio driver was created at first to abstra

Re: [PATCH v4 10/11] dt-bindings: orion-mdio: document the new xmdio compatible

2017-06-15 Thread Antoine Tenart
Hi Andrew, On Wed, Jun 14, 2017 at 06:35:37PM +0200, Andrew Lunn wrote: > On Wed, Jun 14, 2017 at 05:49:10PM +0200, Antoine Tenart wrote: > > > > The Ethernet controllers of the Marvel Kirkwood, Dove, Orion5x, > > -MV78xx0, Armada 370 and Armada XP have an identic

Re: [PATCH v4 10/11] dt-bindings: orion-mdio: document the new xmdio compatible

2017-06-15 Thread Antoine Tenart
Hi Andrew, On Thu, Jun 15, 2017 at 03:12:32PM +0200, Andrew Lunn wrote: > > Agreed, your description is better :) > > I'll respin this patch only, if there is no other comment. > > I assume these patches are going via net-next? Dave will not like a > respin of a single patch. You need to post

[PATCH net-next v5 04/11] net: mvmdio: remove duplicate locking

2017-06-15 Thread Antoine Tenart
From: Russell King The MDIO layer already provides per-bus locking, so there's no need for MDIO bus drivers to do their own internal locking. Remove this. Signed-off-by: Russell King Reviewed-by: Florian Fainelli

[PATCH net-next v5 03/11] net: mvmdio: use GENMASK for masks

2017-06-15 Thread Antoine Tenart
Cosmetic patch to use the GENMASK helper for masks. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 3/9] net: mvmdio: use GENMASK for masks

2017-06-12 Thread Antoine Tenart
Cosmetic patch to use the GENMASK helper for masks. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH v3 1/9] net: mvmdio: reorder headers alphabetically

2017-06-12 Thread Antoine Tenart
Cosmetic fix reordering headers alphabetically. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --g

[PATCH v3 5/9] net: mvmdio: introduce an ops structure

2017-06-12 Thread Antoine Tenart
Introduce an ops structure to add an indirection on functions accessing the registers. This is needed to add the xMDIO support later. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 71 ++-

[PATCH v3 9/9] arm64: marvell: dts: add xmdio nodes for 7k/8k

2017-06-12 Thread Antoine Tenart
Add the description of the xMDIO bus for the Marvell Armada 7k and Marvell Armada 8k; for both CP110 slave and master. This bus is found on Marvell Ethernet controllers and provides an interface with the xMDIO bus. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> ---

[PATCH v3 2/9] net: mvmdio: use tabs for defines

2017-06-12 Thread Antoine Tenart
Cosmetic patch replacing spaces by tabs for defined values. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> Reviewed-by: Florian Fainelli <f.faine...@gmail.com> --- drivers/net/ethernet/marvell/mvmdio.c | 26 +- 1 file changed, 13 inser

[PATCH v3 0/9] net: mvmdio: add xMDIO xSMI support

2017-06-12 Thread Antoine Tenart
). Antoine Tenart (9): net: mvmdio: reorder headers alphabetically net: mvmdio: use tabs for defines net: mvmdio: use GENMASK for masks net: mvmdio: move the read valid check into its own function net: mvmdio: introduce an ops structure net: mvmdio: put the poll intervals in the ops

[PATCH v3 4/9] net: mvmdio: move the read valid check into its own function

2017-06-12 Thread Antoine Tenart
Move the read valid check in its own function. This is needed as a requirement to factorize the driver to add the xMDIO support in the future. Signed-off-by: Antoine Tenart <antoine.ten...@free-electrons.com> --- drivers/net/ethernet/marvell/mvmdio.c | 11 +++ 1 file chan

  1   2   3   4   5   >