it message.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
security-4.9.mbox
Description: application/mbox
it message.
Ben.
--
Ben Hutchings, Software Developer Codethink Ltd
https://www.codethink.co.uk/ Dale House, 35 Dale Street
Manchester, M1 2HF, United Kingdom
security-4.4.mbox
Description: application/mbox
2cad88269ea704eb270d7ac6e69e8a544c:
>
> cxgb4: update firmware to revision 1.16.63.0 (2017-09-27 08:14:29 -0700)
>
> --------
--
Ben Hutchings
Humour is the best antidote to reality.
signature.asc
Description: This is a digitally signed message part
> -Support flow ID in aRFS flow.
>
> Signed-off-by: Rahul Verma
> ---
> qed/qed_init_values_zipped-8.30.16.0.bin | Bin 0 -> 837008 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
> create mode 100755 qed/qed_init_values_zipped-8.30.16.0.bin
[...]
The new fil
r any stringset other than ETH_SS_STATS.
Fixes: 511e6bc071db ("net: add Hisilicon Network Subsystem DSAF support")
Fixes: 412b65d15a7f ("net: hns: fix ethtool_get_strings overflow ...")
Signed-off-by: Ben Hutchings
---
drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 17 +
The driver-internal string operations are only ever used for
statistics, so remove the stringset parameters and rename them
accordingly.
Signed-off-by: Ben Hutchings
---
drivers/net/ethernet/hisilicon/hns/hnae.h | 13
drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 37
o this (only non-commercial
distributors can do that). So the source needs to be published too.
Adding the complete Linux kernel source code to linux-firmware.git
doesn't seem like a sensible step, so maybe this particular firmware
needs to live elsewhere.
Ben.
--
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.
signature.asc
Description: This is a digitally signed message part
ode around here was
largely rewritten in 4.14 by commit f1174f77b50c "bpf/verifier: rework
value tracking". The bug can be detected by the bpf/verifier sub-test
"pointer/scalar confusion in state equality check (way 1)".
Signed-off-by: Ben Hutchings
Cc: Edward Cree
Cc: Jan
or crash in some error cases. Reorder
cleanup again to fix this.
Fixes: 15e668070a64 ("ipv6: reorder icmpv6_init() and ip6_mr_init()")
Signed-off-by: Ben Hutchings
---
This fix is untested and based only on my review of the earlier commit.
Ben.
net/ipv6/af_inet6.c | 6 +++---
1 file
On Wed, 2018-01-10 at 14:25 -0800, Cong Wang wrote:
> On Tue, Jan 9, 2018 at 10:21 AM, Ben Hutchings
> wrote:
> > Commit 15e668070a64 reordered the initialisation in inet6_init() to
> > fix a crash on an error path further down the call stack. It also
> > reordered clea
ity is to avoid breaking currently working user-space. That
means that ugly and inconsistent APIs won't get fixed if it causes a
regression for the programs people actually use. If the API never
worked like it was supposed to on some architectures, that's not a
regression, and is lower p
On Sun, 2020-08-02 at 19:29 +, Thorsten Glaser wrote:
> Ben Hutchings dixit:
>
> >ip(7) also doesn't document IP_PKTOPIONS.
>
> Hmm, I don’t use IP_PKTOPIONS though. I’m not exactly sure I found
> the correct place in the kernel for what I do.
The first inst
On Sun, 2020-08-02 at 22:44 +0200, Thorsten Glaser wrote:
> On Sun, 2 Aug 2020, Ben Hutchings wrote:
>
> > The RFC says that the IPV6_TCLASS option's value is an int, and that
>
> for setsockopt (“option's”), not cmsg
>
> > No, the wording is *not* clear.
&
This series adds log messages for all patching done by the verifier,
and a test case to verify that the patch to defend against SSB
exploitation is applied where needed.
Ben.
Ben Hutchings (3):
bpf/verifier: Log instruction patching when verbose logging is enabled
selftests/bpf: Add the
This is needed to test that code is being patched when it should be.
Signed-off-by: Ben Hutchings
---
tools/testing/selftests/bpf/test_verifier.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_verifier.c
b/tools/testing
Test that the defence added by commit af86ca4e3088 "bpf: Prevent
memory disambiguation attack" is actually being applied.
Signed-off-by: Ben Hutchings
---
tools/testing/selftests/bpf/test_verifier.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tools/testing/sel
User-space does not have access to the patched eBPF code, but we
need to be able to test that patches are being applied. Therefore
log distinct messages for each case that requires patching.
Signed-off-by: Ben Hutchings
---
kernel/bpf/verifier.c | 13 +
1 file changed, 13
? If not, is every driver that does TSO
expected to check this?
Also, should these fixes go to stable? I'm not sure whether you're
still handling stable patches for any of the unfixed versions (< 4.16)
now.
Ben.
--
Ben Hutchings, Software Developer
On Fri, 2018-11-23 at 21:10 +0100, Daniel Borkmann wrote:
> On 11/23/2018 07:34 PM, Ben Hutchings wrote:
> > User-space does not have access to the patched eBPF code, but we
> > need to be able to test that patches are being applied. Therefore
> > log distinct messages for ea
+2076,7 @@ static int do_gchannels(struct cmd_context *ctx)
>
> static int do_gcoalesce(struct cmd_context *ctx)
> {
> - struct ethtool_coalesce ecoal;
> + struct ethtool_coalesce ecoal = {};
> int err;
>
> if (ctx->argc != 0)
--
Ben Hutchings
I
ej Żenczykowski
> ---
> ethtool-copy.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index 6bfbb85f9402..7772a4970987 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -14,6 +14,12 @@
> #ifndef _LINUX_ET
) define
CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS, which seems to imply that
NET_IP_ALIGN should be 0.
Remove the overriding definitions for ppc64 and x86 and define
NET_IP_ALIGN solely based on CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS.
Signed-off-by: Ben Hutchings
---
arch/powerpc/include/asm/processor.h
04fd22200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
fb
[ 64.049993]
==
Ben.
--
Ben Hutchings
The world is coming to an end. Please log off.
signature.asc
Description: This is a digitally signed message part
> [2]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5c25f65fd1e42685f7ccd80e0621829c105785d9
> [3]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ad646c81b2182f7fa67ec0c8c825e0ee165696d
> [4] https://www.spinics.net/lists/netdev/m
Good to know. I will send all three patches cherry-picked on top of the
> current 3.16 stable branch. Could you have a look please?
I've now queued these all up.
Ben.
--
Ben Hutchings
If you seem to know what you are doing, you'll be given more to do.
signature.asc
Description: This is a digitally signed message part
00755 qed/qed_init_values_zipped-8.33.1.0.bin
[...]
Applied; sorry for the delay.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
> 1 file changed, 0 insertions(+), 0 deletions(-)
> create mode 100644 cavium/pki-cluster.bin
When adding a file you also need to update WHENCE to include its
copyright details.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
liquidio/lio_210sv_nic.bin | Bin 1159096 -> 1163128 bytes
> liquidio/lio_23xx_nic.bin | Bin 1266528 -> 1271456 bytes
> liquidio/lio_410nv_nic.bin | Bin 1261080 -> 1265368 bytes
> 5 files changed, 4 insertions(+), 4 deletions(-)
Pulled, thanks.
Ben.
--
Ben Hutchings
When in d
ellanox/mlxsw_spectrum-13.1530.152.mfa2
Applied both of these, thanks.
Ben.
--
Ben Hutchings
When in doubt, use brute force. - Ken Thompson
signature.asc
Description: This is a digitally signed message part
On Tue, 2017-11-28 at 11:09 -0600, Steven J. Hill wrote:
> On 11/22/2017 07:40 PM, Ben Hutchings wrote:
> > On Tue, 2017-10-31 at 17:05 -0500, Steven J. Hill wrote:
> > > Hello.
> > >
> > > Would like to add firmware for our Octeon III PKI driver. Thanks.
>
avoid a
regression when reading modules with this problem.
* In other error cases, the error code is propagated.
Reported-by: Yannis Aribaud
References: https://bugs.debian.org/960702
Fixes: 7202da8b7f71 ("ethtool, net/mlx4_en: Cable info, get_module_info/...")
Signed-off-by: Ben
On Mon, 2020-05-18 at 16:47 +, Saeed Mahameed wrote:
> On Sun, 2020-05-17 at 18:20 +0100, Ben Hutchings wrote:
> > mlx4_en_get_module_eeprom() returns 0 even if it fails. This results
> > in copying an uninitialised (or partly initialised) buffer back to
> > user-space.
32_FORMAT) {
[...]
usbnet_read_cmd() doesn't do any byte-swapping, so it looks like
curr_ntb_format will have little-endian byte order (__le16 not u16).
The comparison will then need to be done using
le16_to_cpu(curr_ntb_format).
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
to work through, but I will get to this
eventually.
Ben.
--
Ben Hutchings
Kids! Bringing about Armageddon can be dangerous. Do not attempt it in
your own home. - Terry Pratchett and Neil Gaiman, `Good Omens'
signature.asc
Description: This is a digitally signed message part
ot updated, so it
currently returns 0 for all sockets for which IPV6_AUTOFLOWLABEL is
not explicitly enabled. Fix it to return the effective value, whether
that has been set at the socket or net namespace level.
Fixes: 513674b5a2c9 ("net: reevalulate autoflowlabel setting after sysctl ..."
Please queue up this commit for stable:
69c64866ce07 dccp: CVE-2017-8824: use-after-free in DCCP code
Ben.
--
Ben Hutchings
Software Developer, Codethink Ltd.
xfrm6_find_1stfragopt() may now return an error code and we must
not treat it as a length.
Fixes: 2423496af35d ("ipv6: Prevent overrun when parsing v6 header options")
Signed-off-by: Ben Hutchings
---
Commits 2423496af35d "ipv6: Prevent overrun when parsing v6 header
options&qu
If I'm not mistaken, ipv6_gso_segment() now leaks segs if
ip6_find_1stfragopt() fails. I'm not sure whether the fix would be as
simple as adding a kfree_skb(segs) or whether more complex cleanup is
needed.
Ben.
--
Ben Hutchings
Lowery's Law:
If it jams, force it. I
l.org/linus/d821a4c4d11ad160925dab2bb009b8444beff484
I think e1000 may still be unfixed, so this might be the same bug.
Ben.
--
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.
signature.asc
Description: This is a digitally signed message part
g the per-protocol handler, which means by default nothing leaks.
Only cases where msg_namelen is set but msg_name[] is not initialised
up to that length are a problem. I would have thought they were not
too hard to find and fix.
Ben.
> msg_sys->msg_name = &addr;
>
>
https://support.solarflare.com/netdev/net-2.6.25-sfc-2.2.0019.patch
The new files may also be downloaded as a tarball:
https://support.solarflare.com/netdev/net-2.6.25-sfc-2.2.0019.tar.gz
And for verification there is:
https://support.solarflare.com/netdev/MD5SUMS
Ben.
--
Ben Hutchings, Senio
rted this lack on Sourceforge a while back:
<http://sourceforge.net/tracker/index.php?func=detail&aid=1798807&group_id=3242&atid=103242>
Is anyone reading bugs reported there?
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my empl
Kok, Auke wrote:
> Ben Hutchings wrote:
> > Auke Kok wrote:
> >> From: Jesse Brandeburg <[EMAIL PROTECTED]>
> >>
> >> there is missing support in ethtool for reporting 1baseT
> >> as SUPPORTED_1baseT_Full. The code seems to be half
>
oes the driver not use the kernel
> infrastructure for these?
We are not currently using the kernel infrastructure for those.
I'm not sure whether we could do.
I think everyone working on the net driver here will be away until
the new year, so please forgive our silence in the mean time.
Ben.
be changed use Linux's software LRO.
Even with these optimisations, if all RX processing is done on a
single CPU this can become a bottleneck. Does the test system have
multiple CPUs? Are IRQs for the multiple NICs balanced across
multiple CPUs?
Ben.
--
Ben Hutchings, Senior Software Engin
sfc driver, which we should be re-posting later today.
Signed-off-by: Ben Hutchings <[EMAIL PROTECTED]>
diff --git a/ethtool.c b/ethtool.c
index 3adf843..cfe7c9f 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -151,7 +151,8 @@ static struct option {
"
ode size.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More
evice: waiting for ppp0 to become
> free. Usage count = 1
This is a known bug which doesn't just affect PPP:
<http://bugzilla.kernel.org/show_bug.cgi?id=9778>.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the mar
On Fri, 2015-04-24 at 21:53 +0300, Sergei Shtylyov wrote:
> On 04/23/2015 02:22 AM, Florian Fainelli wrote:
>
> [...]
>
> +if (ecmd->duplex == DUPLEX_FULL)
> +priv->duplex = 1;
> +else
> +priv->duplex = 0;
>
> >>> Why not use what priv->phydev->duplex
AM on supported controllers
so we can always use the NOUFLO bit.
Cc:
Cc:
Cc: Don Fry
Signed-off-by: Markos Chandras
Signed-off-by: David S. Miller
Signed-off-by: Ben Hutchings
---
drivers/net/ethernet/amd/pcnet32.c | 31 +--
1 file changed, 29 insertions(+), 2 dele
mitted frame.
>
> Fix by calculating the delta as a signed long.
Told you I hadn't tested it.
Ben.
> Cc: Ben Hutchings
> Reported-by: Florian Bruhin
> Fixes: 7a1e890e2168 ("usbnet: Fix tx_bytes statistic running backward in
> cdc_ncm")
> Signed-off-by: Bj
timestamp support
This is purely based on the commit messages, not on bug reports or my
own experience of the bugs. I leave it to the e1000e maintainers to
judge whether they're important enough.
Ben.
--
Ben Hutchings
If more than one person is responsible for a bug, no one is at fault.
signatur
an application tell the difference between an IRQ handler
being renamed, or being unregistered and re-registered under a different
name? I'm fairly sure it can't tell.
> Therefore, it is mandatory that the name string is at the time you call
> request_irq().
It certainly ought to be something non-null and a useful identifier for
the device. But the convention of including the net device name means
that either the interrupt handler should be registered only when the
device is up, or it should be renamed when the device is.
There are certainly some network drivers that handle interrupts while
the device is down, e.g. because they have a PHC. Should those
interrupt handlers be named after the PCI device instead?
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
alled from other files in the
> > 'net/core'. So the fix is applied to the 'ethtool_get_settings()'
> > which is only called in the context of the 'ethtool'.
> >
> > Signed-off-by: Arun Parameswaran
> > Reviewed-by: Ray Jui
> > Revi
connected to the net device's MAC, an ETHTOOL_SSET operation can be
used to change that PHY address.
The ethtool API is not meant for controlling other PHYs that aren't
connected to the MAC; if you want to do that then create more net
devices for them or use the MDIO ioctls.
Ben.
ted way to write '= req_hfunc;'...
> > - Better support in combination of hash functions/attributes
>
> Ben Hi,
>
> Could you take a look at this patch?
Didn't we agree that only one hash function should be selected at once?
Can you send a new version that implements that?
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
> {
> sff8079_show_identifier(id);
> @@ -385,5 +421,10 @@ void sff8079_show_all(const __u8 *id)
> sff8079_show_oui(id);
> sff8079_show_ascii(id, 40, 55, "Vendor PN");
> sff8079_show_ascii(id, 56, 59, "Vendor rev");
> + sff8079_show_options(id);
> + sff8079_show_value_with_unit(id, 66, "BR margin, max", 1, "%");
> + sff8079_show_value_with_unit(id, 67, "BR margin, min", 1, "%");
> + sff8079_show_ascii(id, 68, 83, "Vendor SN");
> + sff8079_show_ascii(id, 84, 91, "Date code");
> }
> }
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
+ 1)
> -#define EMAC4_ETHTOOL_REGS_VER 1
> -#define EMAC4_ETHTOOL_REGS_SIZE(dev) ((dev)->rsrc_regs.end - \
> - (dev)->rsrc_regs.start + 1)
> +#define EMAC4_ETHTOOL_REGS_VER 1
> +#define EMAC4SYNC_ETHTOOL_REGS_VER 2
>
> #endif /* __IBM_NEWEMAC_CORE_H */
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Description: This is a digitally signed message part
truct emac_regs, u1)
EMAC4: offsetof(struct emac_regs, u1.emac4) + sizeof(p->u1.emac4)
EMAC4SYNC: offsetof(struct emac_regs, u1.emac4sync) + sizeof(p->u1.emac4sync)
Ben.
--
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.
signature.asc
Descri
divisible by 8 (-x option)
* Fix: Add missing Advertised speeds (no option and -s option)
* Feature: Add support to get expansion ROM version (-i option)
* Feature: Include SFP serial number and date in EEPROM dump
(-m option)
Ben.
--
Ben Hutchings
Reality is just a
On Sun, 2015-05-31 at 17:19 -0700, David Miller wrote:
> From: Ben Hutchings
> Date: Sun, 31 May 2015 20:54:06 +0100
>
> > On Fri, 2015-05-22 at 16:15 -0400, David Miller wrote:
> >> From: Arun Parameswaran
> >> Date: Wed, 20 May 2015 14:35:30 -0700
> >
On Mon, 2015-06-01 at 16:30 +0400, Ivan Mikhaylov wrote:
> On Mon, 1 June 2015 12:57 +0400
> Ben Hutchings wrote:
>
> >On Thu, 2015-05-21 at 19:09 +0400, Ivan Mikhaylov wrote:
> >> In ibm_emac.c in ethtool size of emac structure which passing through
> >>
On Mon, 2015-06-01 at 10:14 -0700, Arun Parameswaran wrote:
> On 15-05-31 12:59 PM, Ben Hutchings wrote:
> > On Fri, 2015-05-22 at 15:43 -0700, Arun Parameswaran wrote:
> >> Hi,
> >> The patch fixes 2 issues with 'ethtool' getting/setting parametres
On Mon, 2015-06-01 at 12:12 -0700, Arun Parameswaran wrote:
> On 15-06-01 11:07 AM, Ben Hutchings wrote:
> > On Mon, 2015-06-01 at 10:14 -0700, Arun Parameswaran wrote:
> >> On 15-05-31 12:59 PM, Ben Hutchings wrote:
> >>> On Fri, 2015-05-22 at 15:43 -0700, Arun
utomatically detect which PHY address to use, or where the MAC can be
attached to one of several different PHYs. This is what the 'phyad'
parameter is used for. I think the only remaining driver that supports
changing the PHY address like this is natsemi.
Ben.
--
Ben Hutchings
The
Compile-tested only.
Signed-off-by: Ben Hutchings
---
Re-sent using mutt since Evolution 3.18 mangles patches.
Ben.
drivers/isdn/i4l/isdn_ppp.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c
index c4198fa..86f9abe 100644
callers accordingly.
Compile-tested only.
Reported-by: 郭永刚
References: http://article.gmane.org/gmane.comp.security.oss.general/17908
Signed-off-by: Ben Hutchings
---
Re-sent using mutt since Evolution 3.18 mangles patches.
Ben.
drivers/isdn/i4l/isdn_ppp.c | 10 --
drivers/net/ppp
On Fri, 2015-10-16 at 00:46 -0700, David Miller wrote:
> From: Ben Hutchings
> Date: Wed, 14 Oct 2015 18:51:14 +0100
>
> > Compile-tested only.
> >
> > Signed-off-by: Ben Hutchings
> > ---
> > drivers/isdn/i4l/isdn_ppp.c | 6 ++
> > 1 file c
On Fri, 2015-10-30 at 09:03 -0400, Josh Boyer wrote:
> On Fri, Oct 16, 2015 at 3:46 AM, David Miller
> wrote:
> > From: Ben Hutchings
> > Date: Wed, 14 Oct 2015 18:51:14 +0100
> >
> > > Compile-tested only.
> > >
> > > Signed-off-by: Ben Hutc
On Tue, 2016-05-10 at 11:24 +, David Laight wrote:
> From: Ben Hutchings
> >
> > Sent: 09 May 2016 01:17
> > On Sun, 2016-05-08 at 13:55 -0700, Shrikrishna Khare wrote:
> > >
> > >
> > > On Sat, 7 May 2016, Ben Hutchings wrote:
> >
; ETH_MODULE_SFF_8436_LEN then start > 0 here and this
overruns the output buffer.
I think that 'data' should be incremented along with 'start' in the
previous if-block.
Ben.
> + }
> + return rc;
> +}
[...]
--
Ben Hutchings
For every action, there
ntainer.
Ben.
> I know we discussed last netconf that we should look at possibly a new tool
> to address the shortcomings of ethtool, but I was not aware we had
> abandoned maintaining the current ethtool already before any replacement
> tool has been developed.
--
Ben Hutchings
Time is nature's way of making sure that everything doesn't happen at
once.
signature.asc
Description: This is a digitally signed message part
t realise that.
> So, why is there no source in the tree, but just the link to it?
An oversight which we need to fix.
> Because, I would like to do basically the same
> for carl9170fw and just add a link to the carl9170fw repository and
> save everyone this source update "song and dan
t_device *dev, void
> __user *useraddr)
> {
> - struct ethtool_pauseparam pauseparam = { ETHTOOL_GPAUSEPARAM
> };
> + struct ethtool_pauseparam pauseparam;
> +
> + memset(&pauseparam, 0, sizeof(pauseparam));
> + pauseparam.cmd = ETHTOOL_GPAUSEPARAM;
>
> if
[email protected]
Cc: [email protected]
Signed-off-by: Vijay Pandurangan
Acked-by: Cong Wang
Signed-off-by: David S. Miller
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings
---
drivers/net/veth.c | 6 --
1 file changed, 6 deletions(-)
--- a/drivers/ne
On Wed, 2016-04-27 at 08:59 -0700, Ben Greear wrote:
> On 04/26/2016 04:02 PM, Ben Hutchings wrote:
> >
> > 3.2.80-rc1 review patch. If anyone has any objections, please let me know.
> I would be careful about this. It causes regressions when sending
> PACKET_SOCKET buffe
tributed in binary form, then a per-device option might be
necessary so users can keep those applications working before they're
updated.
Ben.
--
Ben Hutchings
Tomorrow will be cancelled due to lack of interest.
signature.asc
Description: This is a digitally signed message part
On Thu, 2016-04-28 at 12:29 +0200, Sabrina Dubroca wrote:
> Hello,
>
> 2016-04-27, 17:14:44 -0700, Ben Greear wrote:
> >
> > On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote:
> > >
> > > Hi Ben,
> > >
> > > On Wed, Apr 27, 2016, at 20:
#x27;t maintain
that pointer, they should be changed to do so. Then they can
use generic implementations of {get,set}_link_ksettings provided by
phylib.
Ben.
--
Ben Hutchings
Editing code like this is akin to sticking plasters on the bleeding stump
of a severed limb. - me, 29 June 1999
signature
fields that
are denominated in microseconds (especially not for 0, which is the
correct way to specify 'no coalescing'). If the current
ethtool_coalesce structure is inadequate, propose an extension.
Ben.
--
Ben Hutchings
Editing code like this is akin to sticking plasters on the
On Sun, 2016-05-08 at 00:56 +0200, Philippe Reynes wrote:
> On 07/05/16 13:59, Ben Hutchings wrote:
> >
> > On Sat, 2016-05-07 at 01:18 +0200, Philippe Reynes wrote:
> > >
> > > The callback {get|set}_link_ksettings are often defined
> > > in a very clos
you need to assign ndev->phydev here
[...]
> @@ -2875,8 +2869,7 @@ fec_enet_close(struct net_device *ndev)
> fec_stop(ndev);
> }
>
> - phy_disconnect(fep->phy_dev);
> - fep->phy_dev = NULL;
> + phy_disconnect(ndev->phydev);
[...]
and you need to
On Mon, 2016-05-09 at 00:47 +0200, Philippe Reynes wrote:
> On 09/05/16 00:22, Ben Hutchings wrote:
> >
> > On Sun, 2016-05-08 at 23:44 +0200, Philippe Reynes wrote:
> > >
> > > The private structure contain a pointer to phydev, but the structure
> > > n
On Sun, 2016-05-08 at 13:55 -0700, Shrikrishna Khare wrote:
>
> On Sat, 7 May 2016, Ben Hutchings wrote:
>
> > On Fri, 2016-05-06 at 16:12 -0700, Shrikrishna Khare wrote:
> > [...]
> > > +static int
> > > +vmxnet3_set_coalesce(struct net_device *net
d perhaps you should
rename the 'tos' fields to something like 'tclass'. (Definitely not
just 'class' as UAPI headers have to be C++ compatible.)
Ben.
--
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert Einstein
signature.asc
Description: This is a digitally signed message part
return -EINVAL;
> + spec.match_flags |= EFX_FILTER_MATCH_LOC_HOST;
> + memcpy(spec.loc_host, uip6_entry->ip6dst,
> sizeof(spec.loc_host));
> + }
> + if (!ip6_mask_is_empty(ip6_mask->ip6src)) {
[...]
Same here.
Ben.
--
Ben Hutchings
It is a miracle that curiosity survives formal education. - Albert Einstein
signature.asc
Description: This is a digitally signed message part
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote:
> Signed-off-by: Edward Cree
Reviewed-by: Ben Hutchings
> ---
> include/uapi/linux/ethtool.h | 70
>
> 1 file changed, 64 insertions(+), 6 deletions(-)
>
> diff --git
On Fri, 2016-02-05 at 11:16 +, Edward Cree wrote:
> Signed-off-by: Edward Cree
Reviewed-by: Ben Hutchings
> ---
> drivers/net/ethernet/sfc/ethtool.c | 184
> +
> 1 file changed, 184 insertions(+)
>
> diff --git a/drivers/net/e
;m
not sure why you think it needs to be avoided.
> I'd be willing to change this accordingly if someone
> thinks the queue limit should apply to send-to-self.
If we don't check the queue limit here, does anything else prevent the
queue growing to the point it's a DoS?
Ben.
--
Ben Hutchings
I say we take off; nuke the site from orbit. It's the only way to be sure.
signature.asc
Description: This is a digitally signed message part
On Fri, 2016-02-12 at 20:17 +, Rainer Weikusat wrote:
> Ben Hutchings writes:
> > On Fri, 2016-02-12 at 13:25 +, Rainer Weikusat wrote:
> > > Philipp Hahn writes:
> > > > Hello Rainer,
> > > >
> > > > Am 11.02.2016 um 20:37 sch
een a useful micro-optimisation, avoiding an extra branch in the
successful case, but gcc now appears to do that itself. So it makes
the code less clear and runs the risk of introducing this sort of bug,
for no obvious benefit.
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything
Signed-off-by: David Decotigny
Reviewed-by: Ben Hutchings
[...]
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
signature.asc
Description: This is a digitally signed message part
/bin/sh
> +# Runs bitmap infrastructure tests using test_bitmap kernel module
> +
> +if /sbin/modprobe -q test_bitmap; then
> + /sbin/modprobe -q -r test_bitmap
> + echo "bitmap: ok"
> +else
> + echo "bitmap: [FAIL]"
> + exit 1
> +fi
--
Be
settings and reduce the risk of confusion between old and new commands.
However, you didn't reply to that review. Do you have any objection to
doing this?
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
signature.asc
Description: This is a digitally signed message part
On Mon, 2016-02-08 at 02:45 -0500, Kan Liang wrote:
> From: Kan Liang
>
> Introduce a new ioctl ETHTOOL_PERQUEUE for per queue parameters setting.
> The following patches will enable some SUB_COMMANDs for per queue
> setting.
>
> Signed-off-by: Kan Liang
[...]
Revie
struct ethtool_coalesce *);
[...]
Please change the queue number to be unsigned, so driver authors don't
need to consider whether they need to check for negative values.
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
signature.asc
Description: This is a digitally signed message part
= 0)
> + goto roll_back;
> +
> + useraddr += sizeof(coalesce);
> + }
> +
> +roll_back:
> + if (ret != 0) {
> + tmp = backup;
> + for_each_set_bit(i, queue_mask, bit) {
> + dev->ethtool_ops->set_per_queue_coalesce(dev, i, tmp);
> + tmp += sizeof(struct ethtool_coalesce);
[...]
Again, increment by 1.
Ben.
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.
signature.asc
Description: This is a digitally signed message part
+ queue = 0;
> + } else if (queue >= vsi->num_queue_pairs) {
> + netif_info(pf, drv, netdev, "Invalid queue value, queue range
> is 0 - %d\n",
> + vsi->num_queue_pairs - 1);
[...]
Don't log this error message;
The old inet_lro library has been deprecated ever since GRO was
introduced, but there are still a few drivers using it. Convert
them to GRO and remove it.
Ben.
Ben Hutchings (3):
pasemi_mac: Replace LRO with GRO
RDMA/nes: Replace LRO with GRO
ipv4: Remove inet_lro library
drivers
GRO is simpler to use than the old inet_lro library, and is compatible
with forwarding and bridging configurations.
Compile-tested only.
Signed-off-by: Ben Hutchings
---
drivers/net/ethernet/pasemi/Kconfig | 5 +--
drivers/net/ethernet/pasemi/pasemi_mac.c | 50
1 - 100 of 253 matches
Mail list logo
