[PATCH] smc91x: fix one source of spurious interrupts

usage of the max IRQ loop count value). Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c index c91e2e8..1021108 100644 --- a/drivers/net/smc91x.c +++ b/drivers/net/smc91x.c @@ -155,6 +155,12 @@ MODULE_LICENSE(GPL); #define MEMORY_WAIT_TIME

[PATCH] smc91x: allow for dynamic bus access configs

and easier to understand, and ultimately allowing people to define configuration symbols in terms of variables if they really want to dynamically support multiple bus configurations at the same time (with the unavoidable performance cost). Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] --- Index

Re: [PATCH] smc91x: allow for dynamic bus access configs

On Mon, 9 Jan 2006, Jeff Garzik wrote: Nicolas Pitre wrote: All accessor's different methods are now selected with C code and unused ones statically optimized away at compile time instead of being selected with #if's and #ifdef's. This has many advantages such as allowing the compiler

[PATCH] smc91x: allow for dynamic bus access configs

and easier to understand, and ultimately allowing people to define configuration symbols in terms of variables if they really want to dynamically support multiple bus configurations at the same time (with the unavoidable performance cost). Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] --- Index

Re: [PATCH] smc91x: add support for LogicPD PXA270 platform

On Tue, 28 Mar 2006, Lennert Buytenhek wrote: This patch adds support for the smc91x on the LogicPD PXA270 to the smc91x driver. Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED] Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] Index: linux-2.6.16/drivers/net/smc91x.h

Re: [patch 32/41] lockdep: fix smc91x

think the patch is correct. The lock validator is rightfully complaining and the patch is correct. Acked-by: Nicolas Pitre [EMAIL PROTECTED] Nicolas - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] add support for smc91x ethernet interface on zylonite

of smc91x driver, but it looks quite difficult for the moment, so ugly #ifdef is still used here. Signed-off-by: Aleksey Makarov [EMAIL PROTECTED] Acked-by: eric miao [EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.h | 15 +++ 1 files

Re: [PATCH] SMC91x: don't flag spurious interrupts when polling

trigger the spurious warning when in polling mode. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] Signed-off-by: Nicolas Pitre [EMAIL PROTECTED] NAK Kevin: you sent the wrong patch ! Nicolas -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 00/04] smc91x: request bus width using platform data

On Wed, 20 Feb 2008, Magnus Damm wrote: These patches make it possible to request bus width in the platform data. Instead of keep on updating smc91x.h with board specific configuration, use platform data to pass along bus width and irq flags to the driver. This change is designed to be

Re: [PATCH 01/04] smc91x: pass along private data

On Wed, 20 Feb 2008, Magnus Damm wrote: Pass a private data pointer to macros and functions. This makes it easy to later on make run time decisions. This patch does not change any logic. These changes should be optimized away during compilation. Signed-off-by: Magnus Damm [EMAIL PROTECTED]

Re: [PATCH 02/04] smc91x: introduce platform data flags

On Wed, 20 Feb 2008, Magnus Damm wrote: This patch introduces struct smc91x_platdata and modifies the driver so bus width is checked during run time using SMC_nBIT() instead of SMC_CAN_USE_nBIT. Signed-off-by: Magnus Damm [EMAIL PROTECTED] --- NAK. The SMC91C111 (for example) is often

Re: [PATCH 04/04] smc91x: add insw/outsw to default config

On Wed, 20 Feb 2008, Magnus Damm wrote: This patch makes sure SMC_insw()/SMC_outsw() are defined for the default configuration. Without this change BUG()s will be triggered when using 16-bit only platform data and the default configuration. Signed-off-by: Magnus Damm [EMAIL PROTECTED] You

Re: [PATCH 02/04] smc91x: introduce platform data flags

On Thu, 21 Feb 2008, Magnus Damm wrote: On Thu, Feb 21, 2008 at 12:58 AM, Nicolas Pitre [EMAIL PROTECTED] wrote: On Wed, 20 Feb 2008, Magnus Damm wrote: This patch introduces struct smc91x_platdata and modifies the driver so bus width is checked during run time using SMC_nBIT

Re: [PATCH 01/04] smc91x: pass along private data

On Thu, 21 Feb 2008, Magnus Damm wrote: On Thu, Feb 21, 2008 at 12:42 AM, Nicolas Pitre [EMAIL PROTECTED] wrote: On Wed, 20 Feb 2008, Magnus Damm wrote: Pass a private data pointer to macros and functions. This makes it easy to later on make run time decisions. This patch does

Re: [PATCH 01/04] smc91x: pass along private data V2

to lp. Signed-off-by: Magnus Damm [EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.c | 301 +- drivers/net/smc91x.h | 254 +- 2 files changed, 280 insertions

Re: [PATCH 02/04] smc91x: introduce platform data flags V2

[EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.c | 34 drivers/net/smc91x.h | 57 +--- include/linux/smc91x.h | 13 ++ 3 files changed, 77 insertions(+), 27

Re: [PATCH 03/04] smc91x: add insw/outsw to default config V2

] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.h |2 ++ 1 file changed, 2 insertions(+) --- 0003/drivers/net/smc91x.h +++ work/drivers/net/smc91x.h 2008-02-22 15:25:39.0 +0900 @@ -476,6 +476,8 @@ static inline void LPD7_SMC_outsw (unsig #define SMC_outb(v

Re: [PATCH 04/04] smc91x: make superh use default config V2

On Fri, 22 Feb 2008, Magnus Damm wrote: Removes superh board specific configuration from the header file. These boards will instead be configured using platform data. Signed-off-by: Magnus Damm [EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.h | 30

Re: [PATCH] iwlegacy: mark il_adjust_beacon_interval as noinline

ly file > that shows the behavior, by marking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Nicolas Pitre <n...@linaro.org> > > diff --g

Re: [PATCH 0/4] SA11x0 Clocks and removal of Neponset SMC91x hack

hack to assert the enable signal > > This results in the platform specific includes being removed from the > SMC91x driver. > > Please ack these changes; due to the dependencies, I wish to merge > them through my tree. Thanks. Looks nice to me. Acked-by: Nicolas Pitre <n...@lin

Re: [PATCH] net: smsc: remove build warning of duplicate definition

On Wed, 31 Aug 2016, Sudip Mukherjee wrote: > The build of m32r was giving warning: > > In file included from drivers/net/ethernet/smsc/smc91x.c:92:0: > drivers/net/ethernet/smsc/smc91x.h:448:0: warning: "SMC_inb" redefined > #define SMC_inb(ioaddr, reg) ({ BUG(); 0; }) > >

[PATCH 1/2] ptp_clock: allow for it to be optional

(). The pch_gbe driver is a bit special as it relies on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> Acked-by: Richard Cochran <richardcoch...@gmail.com>

[PATCH 2/2] posix-timers: make it configurable

-by: Nicolas Pitre <n...@linaro.org> --- drivers/ptp/Kconfig | 2 +- include/linux/posix-timers.h | 28 +- include/linux/sched.h| 10 init/Kconfig | 17 +++ kernel/signal.c | 4 ++ kernel/time/Kconfig | 1 + kerne

[PATCH 0/2] make POSIX timers configurable

Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* it in their Kconfig

Re: [PATCH 1/2] ptp_clock: allow for it to be optional

On Mon, 19 Sep 2016, Jiri Benc wrote: > On Sun, 18 Sep 2016 23:51:09 -0400, Nicolas Pitre wrote: > > And to make it possible for PTP to be configured out, the select statement > > in the Kconfig entry for those ethernet drivers is changed from selecting >

Re: [PATCH 1/2] ptp_clock: allow for it to be optional

On Mon, 19 Sep 2016, Josh Triplett wrote: > But it does seem unfortunate that this can't happen at build time via > Kconfig. CCing linux-kbuild in case someone has an idea for how to fix > this. I hoped something like this could work: config FOO prompt "Blah-blah" tristate if

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Thomas Gleixner wrote: > I think the whole approach is wrong because it makes the PTP split at the > wrong level. > > Currently we have: > > DRIVER_X > tristate "Driver X" > select PTP > > In order to make POSIX_CLOCK configurable we should have >

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Richard Cochran wrote: > On Tue, Sep 20, 2016 at 03:56:38PM -0400, Nicolas Pitre wrote: > > - Add a warning for the case where PTP clock subsystem is modular and a > > driver providing a clock is built-in rather than silently ignoring it. > > S

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Richard Cochran wrote: > On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote: > > After this series, if I don't pay enough attention to dmesg, then I > > have lost functionality that I had in step #1. That sucks, and it has > > nothing to do with the tinification

[PATCH 1/2] ptp_clock: allow for it to be optional

(). The pch_gbe driver is a bit special as it relies on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> Acked-by: Richard Cochran <richardcoch...@gmail.com&

[PATCH 2/2] posix-timers: make it configurable

-by: Nicolas Pitre <n...@linaro.org> --- drivers/ptp/Kconfig | 2 +- include/linux/posix-timers.h | 28 +- include/linux/sched.h| 10 init/Kconfig | 17 +++ kernel/signal.c | 4 ++ kernel/time/Kconfig | 1 + kerne

[PATCH v2 0/2] make POSIX timers optional

Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* it in their Kconfig

[PATCH] ptp_clock: future-proofing drivers against PTP subsystem becoming optional

Drivers must be ready to accept NULL from ptp_clock_register() if the PTP clock subsystem is configured out. This patch documents that and ensures that all drivers cope well with a NULL return. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Eugenia Emantayev <euge...@mel

Re: [PATCH 2/2] smc91x: remove ARM hack for unaligned 16-bit writes

On Thu, 25 Aug 2016, Arnd Bergmann wrote: > The ARM specific I/O operations are almost the same as the generic > ones, with the exception of the SMC_outw macro that works around > a problem of some platforms that cannot write to 16-bit registers > at an address that is not 32-bit aligned. > > By

Re: [PATCH v2 1/2] smc91x: always use 8-bit access if necessary

On Thu, 25 Aug 2016, Arnd Bergmann wrote: > As Russell King found out the hard way, a change I did to fix multiplatform > builds with this driver broke the old Assabet/Neponset platform: It turns > out that while the driver is runtime configurable in principle, the > runtime configuration does

Re: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help

On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > From: Nicolas Pitre <nicolas.pi...@linaro.org> > > Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help > > This doesn't work. I received this me

Re: [PATCH v2 2/5] kconfig: introduce the "suggest" keyword

On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > Similar to "imply" but with no added restrictions on the target symbol's > > value. Useful for providing a default value to another symbol. > > > > Suggeste

Re: [PATCH v2 1/5] kconfig: introduce the "imply" keyword

On Thu, 27 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > SUBSYSTEM_X can still be configured out, and it can be set as a > > module when none of the drivers are selected or all of them are also > > modular. > > Short not

Re: [PATCH v2 5/5] posix-timers: make it configurable

On Wed, 26 Oct 2016, Richard Cochran wrote: > On Wed, Oct 26, 2016 at 09:56:13AM -0400, Nicolas Pitre wrote: > > So if my Fedora usage doesn't need them, we can infer that > > the number of embedded systems also not needing them might tend towards > > a high percentage.

[PATCH v2 1/5] kconfig: introduce the "imply" keyword

tristate This is much cleaner, and way more flexible than "select". SUBSYSTEM_X can still be configured out, and it can be set as a module when none of the drivers are selected or all of them are also modular. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh

[no subject]

From: Nicolas Pitre <nicolas.pi...@linaro.org> Subject: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, t

[PATCH v2 3/5] kconfig: regenerate *.c_shipped files after previous changes

Signed-off-by: Nicolas Pitre <n...@linaro.org> --- scripts/kconfig/zconf.hash.c_shipped | 228 ++--- scripts/kconfig/zconf.tab.c_shipped | 1631 -- 2 files changed, 888 insertions(+), 971 deletions(-) diff --git a/scripts/kconfig/zconf.hash.c_shipped b/s

[PATCH v2 5/5] posix-timers: make it configurable

the vast majority of use cases with very little code. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> --- drivers/ptp/Kconfig | 2 +- include/linux/posix-timers.h | 28 +- include/linux/sched.h| 10

[PATCH v2 2/5] kconfig: introduce the "suggest" keyword

Similar to "imply" but with no added restrictions on the target symbol's value. Useful for providing a default value to another symbol. Suggested by Edward Cree. Signed-off-by: Nicolas Pitre <n...@linaro.org> --- Documentation/kbuild/kconfig-language.txt | 6 ++ script

[PATCH v2 4/5] ptp_clock: allow for it to be optional

s on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> --- drivers/Makefile

Re: [PATCH v2 1/5] kconfig: introduce the "imply" keyword

On Fri, 28 Oct 2016, Paul Bolle wrote: > On Thu, 2016-10-27 at 23:10 -0400, Nicolas Pitre wrote: > > On Fri, 28 Oct 2016, Paul Bolle wrote: > > > What happens when a tristate symbol is implied by a symbol set to 'y' > > > and by a symbol set to 'm'? > >

Re: [PATCH v3 0/4] make POSIX timers optional with some Kconfig help

On Mon, 7 Nov 2016, Nicolas Pitre wrote: > Many embedded systems don't need the full POSIX timer support. > Configuring them out provides a nice kernel image size reduction. > > When POSIX timers are configured out, the PTP clock subsystem should be > left out as well.

Re: [PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

On Mon, 7 Nov 2016, Josh Triplett wrote: > [snipping large patch] > > One suggestion that might make this patch easier to review: you might > consider first regenerating the unchanged parser with Bison 3.0.4, then > regenerating it again after the "imply" change. I think that'd > eliminate

[PATCH v3 2/4] kconfig: regenerate *.c_shipped files after previous changes

Signed-off-by: Nicolas Pitre <n...@linaro.org> --- scripts/kconfig/zconf.hash.c_shipped | 30 +- scripts/kconfig/zconf.tab.c_shipped | 1581 -- 2 files changed, 753 insertions(+), 858 deletions(-) diff --git a/scripts/kconfig/zconf.hash.c_shipped b/s

[PATCH v3 4/4] posix-timers: make it configurable

the vast majority of use cases with very little code. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> Acked-by: Richard Cochran <richardcoch...@gmail.com> --- drivers/ptp/Kconfig | 2 +- include/linux/posix-timers.h | 28 +

[PATCH v3 3/4] ptp_clock: allow for it to be optional

s on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> Acked-by: Richard Cochran <richardcoch..

[PATCH v3 1/4] kconfig: introduce the "imply" keyword

SUBSYSTEM_X tristate This is much cleaner, and way more flexible than "select". SUBSYSTEM_X can still be configured out, and it can be set as a module when none of the drivers are configured in or all of them are modular. Signed-off-by: Nicolas Pitre <n...@linaro.org> Re

[PATCH v3 0/4] make POSIX timers optional with some Kconfig help

Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* the later in their

Re: [PATCH v3 4/4] posix-timers: make it configurable

On Tue, 8 Nov 2016, John Stultz wrote: > One spot of concern is that the > tools/testing/selftests/timers/posix_timers.c test hangs testing > virtual itimers. Looking through the code I'm not seeing where an > error case is missed. > > The strace looks like: > ... > write(1, "Testing posix

[PATCH v4 4/6] timer: move sys_alarm from timer.c to itimer.c

Move the only user of alarm_setitimer to itimer.c where it is defined. This allows for making alarm_setitimer static, and dropping it from the build when __ARCH_WANT_SYS_ALARM is not defined. Signed-off-by: Nicolas Pitre <n...@linaro.org> --- include/linux/time.h | 2 -- kernel/time/it

[PATCH v4 5/6] posix_cpu_timers_exit: wrong place to collect entropy

There is no logical relation between add_device_randomness() and posix_cpu_timers_exit(). Let's move the former to where the later is called. This way, when posix-cpu-timers.c is compiled out, there is no need to worry about not losing a call to add_device_randomness(). Signed-off-by: Nicolas

[PATCH v4 0/6] make POSIX timers optional with some Kconfig help

Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* the later in their

[PATCH v4 1/6] kconfig: introduce the "imply" keyword

SUBSYSTEM_X tristate This is much cleaner, and way more flexible than "select". SUBSYSTEM_X can still be configured out, and it can be set as a module when none of the drivers are configured in or all of them are modular. Signed-off-by: Nicolas Pitre <n...@linaro.org> Re

[PATCH v4 2/6] kconfig: regenerate *.c_shipped files after previous changes

Signed-off-by: Nicolas Pitre <n...@linaro.org> --- scripts/kconfig/zconf.hash.c_shipped | 30 +- scripts/kconfig/zconf.tab.c_shipped | 1581 -- 2 files changed, 753 insertions(+), 858 deletions(-) diff --git a/scripts/kconfig/zconf.hash.c_shipped b/s

[PATCH v4 6/6] posix-timers: make it configurable

only which should cover the vast majority of use cases with very little code. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> Acked-by: Richard Cochran <richardcoch...@gmail.com> Acked-by: Thomas Gleixner <t...@linutronix.de>

[PATCH v4 3/6] ptp_clock: allow for it to be optional

s on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> Reviewed-by: Josh Triplett <j...@joshtriplett.org> Acked-by: Richard Cochran <richardcoch...@gm

bad commit touching stmmac_ptp.c

Hello, I noticed a recently added commit 7086605a6a ("stmmac: fix error check when init ptp") to the mainline linux tree from you. This commit is wrong. The affected code now reads as: int stmmac_ptp_register(struct stmmac_priv *priv) { spin_lock_init(>ptp_lock);

[PATCH 0/4] make POSIX timers optional with some Kconfig help

Many embedded systems don't need the full POSIX timer support. Configuring them out provides a nice kernel image size reduction. When POSIX timers are configured out, the PTP clock subsystem should be left out as well. However a bunch of ethernet drivers currently *select* the later in their

[PATCH 4/4] posix-timers: make it configurable

-by: Nicolas Pitre <n...@linaro.org> --- drivers/ptp/Kconfig | 2 +- include/linux/posix-timers.h | 28 +- include/linux/sched.h| 10 init/Kconfig | 17 +++ kernel/signal.c | 4 ++ kernel/time/Makefile | 10 +++- kerne

[PATCH 2/4] kconfig: re-generate *.c_shipped files after previous change

Signed-off-by: Nicolas Pitre <n...@linaro.org> --- scripts/kconfig/zconf.hash.c_shipped | 30 +- scripts/kconfig/zconf.tab.c_shipped | 1581 -- 2 files changed, 753 insertions(+), 858 deletions(-) diff --git a/scripts/kconfig/zconf.hash.c_shipped b/s

[PATCH 3/4] ptp_clock: allow for it to be optional

s on extra code in drivers/ptp/ptp_pch.c. Therefore we let the make process descend into drivers/ptp/ even if PTP_1588_CLOCK is unselected. Signed-off-by: Nicolas Pitre <n...@linaro.org> --- drivers/Makefile| 2 +- drivers/net/ethernet/adi/Kconfig

[PATCH 1/4] kconfig: introduce the "imply" keyword

tristate This is much cleaner, and way more flexible than "select". SUBSYSTEM_X can still be configured out, and it can be set as a module when none of the drivers are selected or all of them are also modular. Signed-off-by: Nicolas Pitre <n...@linaro.org> --- Documentation/

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

On Thu, 20 Oct 2016, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:52PM -0400, Nicolas Pitre wrote: > > +static inline void ptp_clock_event(struct ptp_clock *ptp, > > + struct ptp_clock_event *event) > > +{ (void)event; } > > Ju

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

On Thu, 20 Oct 2016, Edward Cree wrote: > On 20/10/16 00:42, Nicolas Pitre wrote: > > diff --git a/Documentation/kbuild/kconfig-language.txt > > b/Documentation/kbuild/kconfig-language.txt > > index 069fcb3eef..c96127f648 100644 > > --- a/Documentation/kbuild/kco

Re: [PATCH 4/4] posix-timers: make it configurable

On Thu, 20 Oct 2016, Richard Cochran wrote: > On Wed, Oct 19, 2016 at 07:42:53PM -0400, Nicolas Pitre wrote: > > +config POSIX_TIMERS > > + bool "Posix Clocks & timers" if EXPERT > > + default y > > + help > > + This includes native support

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

On Thu, 20 Oct 2016, Edward Cree wrote: > On 20/10/16 18:04, Nicolas Pitre wrote: > > On Thu, 20 Oct 2016, Edward Cree wrote: > >> Also, I don't think having any FOO=y should preclude BAZ=m. Suppose both > >> FOO and FOO2 imply BAZ, FOO=y and FOO2=m. > > Some peo

Re: [PATCH 0/4] make POSIX timers optional with some Kconfig help

On Thu, 20 Oct 2016, Thomas Gleixner wrote: > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > Therefore this series also includes kconfig changes to implement a new > > keyword to express some reverse dependencies like "select" does, named > > "imply",

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

On Thu, 20 Oct 2016, Edward Cree wrote: > On 20/10/16 19:29, Nicolas Pitre wrote: > > On Thu, 20 Oct 2016, Edward Cree wrote: > >> But the desire is a property of the user, not of the driver. If you're > >> willing to add CONFIG_FOO_BAZ to every combin

Re: [PATCH 1/4] kconfig: introduce the "imply" keyword

On Thu, 20 Oct 2016, Nicolas Pitre wrote: > On Thu, 20 Oct 2016, Edward Cree wrote: > > > I'm interpreting "imply" as being more a way of saying "if you want FOO you > > probably want BAZ as well". But maybe that should be yet another new > > key

Re: [PATCH 3/4] ptp_clock: allow for it to be optional

On Thu, 20 Oct 2016, Thomas Gleixner wrote: > On Wed, 19 Oct 2016, Nicolas Pitre wrote: > > The pch_gbe driver is a bit special as it relies on extra code in > > drivers/ptp/ptp_pch.c. Therefore we let the make process descend into > > drivers/ptp/ even if PTP_158

Re: [PATCH (net.git)] stmmac: fix and review the ptp registration.

the HW. > > Signed-off-by: Giuseppe Cavallaro <peppe.cavall...@st.com> > Cc: Alexandre TORGUE <alexandre.tor...@st.com> > Cc: Rayagond Kokatanur <rayag...@vayavyalabs.com> > Cc: Dan Carpenter <dan.carpen...@oracle.com> > Cc: Nicolas Pitre <n...@linaro.org> A

Re: [PATCH v2 1/5] kconfig: introduce the "imply" keyword

On Fri, 28 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > The "imply" keyword is a weak version of "select" where the target > > config symbol can still be turned off, avoiding those pitfalls that

Re: [PATCH v2 5/5] posix-timers: make it configurable

On Wed, 26 Oct 2016, Richard Cochran wrote: > On Tue, Oct 25, 2016 at 10:28:51PM -0400, Nicolas Pitre wrote: > > +config POSIX_TIMERS > > + bool "Posix Clocks & timers" if EXPERT > > + default y > > + help > > + This includes native support

Re: [PATCH v2 0/5] make POSIX timers optional with some Kconfig help

On Sat, 29 Oct 2016, Paul Bolle wrote: > On Tue, 2016-10-25 at 22:28 -0400, Nicolas Pitre wrote: > > When POSIX timers are configured out, the PTP clock subsystem should be > > left out as well. However a bunch of ethernet drivers currently *select* > > the later in

Re: [PATCH net 1/3] cpsw/netcp: cpts depends on posix_timers

On Fri, 16 Dec 2016, Arnd Bergmann wrote: > With posix timers having become optional, we get a build error with > the cpts time sync option of the CPSW driver: > > drivers/net/ethernet/ti/cpts.c: In function 'cpts_find_ts': > drivers/net/ethernet/ti/cpts.c:291:23: error: implicit declaration of

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

> is a result of the combination. Changing the new option to 'imply' > as well fixes it. > > Fixes: 111fc64a237f ("liquidio CN23XX: VF registration") > Fixes: d1cbfd771ce8 ("ptp_clock: Allow for it to be optional") > Signed-off-by: Arnd Bergmann <a...@arndb

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On Mon, 5 Dec 2016, David Miller wrote: > From: Nicolas Pitre <nicolas.pi...@linaro.org> > Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > > > On Sat, 3 Dec 2016, David Miller wrote: > > > >> From: Arnd Bergmann <a...@arndb.de> > >> Date: S

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

On Sat, 3 Dec 2016, David Miller wrote: > From: Arnd Bergmann > Date: Sat, 3 Dec 2016 00:04:32 +0100 > > > ptp now depends on the optional POSIX_TIMERS setting and fails to build > > if we select it without that: > > > > warning: (LIQUIDIO_VF && TI_CPTS) selects PTP_1588_CLOCK

Re: [PATCH] [v2, -net] cpsw/netcp: cpts depends on posix_timers

a73d9e478f ("posix-timers: Make them configurable") > Cc: Nicolas Pitre <nicolas.pi...@linaro.org> > Cc: sta...@vger.kernel.org > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Nicolas Pitre <n...@linaro.org> > --- > v2: use 'depends on' instead of 'select'

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

On Mon, 13 Mar 2017, Nicolas Pitre wrote: > So unless I'm mistaken I don't see any problem using "depends on > PTP_1588_CLOCK" here. Furthermore that wouldn't be a first. See for example PTP_1588_CLOCK_GIANFAR, PTP_1588_CLOCK_IXP46X, DP83640_PHY, etc. Nicolas

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

on POSIX_TIMERS. Adding 'depends on PTP_1588_CLOCK' > might also work, but has the risk of circular dependencies when > mixed with other drivers using 'imply'. Could you elaborate on that risk please? > Fixes: baa73d9e478f ("posix-timers: Make them configurable") >

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

On Mon, 13 Mar 2017, Arnd Bergmann wrote: > On Mon, Mar 13, 2017 at 9:09 PM, Nicolas Pitre <nicolas.pi...@linaro.org> > wrote: > > On Mon, 13 Mar 2017, Arnd Bergmann wrote: > > > >> With posix timers having become optional, we get a build error with > >

Re: [PATCH 06/47] net: smsc: remove m32r specific smc91x configuration

On Wed, 14 Mar 2018, Arnd Bergmann wrote: > The m32r architecture is getting removed, so this part can be > cleaned up as well. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Nicolas Pitre <n...@fluxnic.net> > --- > drivers/net/ethernet/smsc/Kco