On Tue, 2018-04-03 at 10:02 -0700, Florian Fainelli wrote:
> On 04/02/2018 07:18 PM, Sean Wang wrote:
> > On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote:
> >> We would be passing 0 instead of NULL as the rsp argument to
> >> mt7530_fdb_cmd(), fix that.
> &
On Mon, 2018-04-02 at 16:24 -0700, Florian Fainelli wrote:
> We would be passing 0 instead of NULL as the rsp argument to
> mt7530_fdb_cmd(), fix that.
>
Acked-by: Sean Wang <sean.w...@mediatek.com>
BTW, does the part of the commit message should be updated with "passi
On Fri, 2017-12-15 at 11:10 +0100, Andrew Lunn wrote:
> On Fri, Dec 15, 2017 at 02:55:03PM +0800, Sean Wang wrote:
> > Hi Sergei,
> >
> > Recently I found the patch commit bafbdd527d56 (phylib: Add device reset
> > GPIO support) would have the impact on MT7530 drive
Hi Sergei,
Recently I found the patch commit bafbdd527d56 (phylib: Add device reset
GPIO support) would have the impact on MT7530 driver. Which causes the
DSA MT7530 device (it's the child node under mdio bus) gets the
reset-gpios fails because the same GPIO seems already be held in the
earlier
On Tue, 2017-12-12 at 09:28 +0100, Andrew Lunn wrote:
> On Tue, Dec 12, 2017 at 03:21:21PM +0800, Sean Wang wrote:
> > On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote:
> > > > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct
On Tue, 2017-12-12 at 09:24 +0100, Felix Fietkau wrote:
> On 2017-12-07 07:06, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > MT7530 can treat each port as either VLAN-unware port or VLAN-ware port
> Shouldn't that be VLAN-u
On Thu, 2017-12-07 at 16:30 +0100, Andrew Lunn wrote:
> > @@ -25,20 +28,37 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb,
> > {
> > struct dsa_port *dp = dsa_slave_to_port(dev);
> > u8 *mtk_tag;
> > + bool is_vlan_skb = true;
>
> ..
>
> > + /* Mark tag attribute on
Hi, Andrew
All sounds reasonable. All will be fixed in the next version.
Sean
On Thu, 2017-12-07 at 16:24 +0100, Andrew Lunn wrote:
> > static void
> > +mt7530_port_set_vlan_unware(struct dsa_switch *ds, int port)
> > +{
> > + struct mt7530_priv *priv = ds->priv;
> > + int i;
> >
On Fri, 2017-10-20 at 10:37 +, Reshetova, Elena wrote:
> > On Fri, 2017-10-20 at 10:23 +0300, Elena Reshetova wrote:
> > > atomic_t variables are currently used to implement reference
> > > counters with the following properties:
> > > - counter is initialized to 1 using atomic_set()
> > > -
On Fri, 2017-10-20 at 10:23 +0300, Elena Reshetova wrote:
> atomic_t variables are currently used to implement reference
> counters with the following properties:
> - counter is initialized to 1 using atomic_set()
> - a resource is freed upon counter reaching zero
> - once counter reaches zero,
working. Just make sure that
> ds->cpu_port_mask is set prior to the first call to get_tag_protocol,
> thus restoring the expected contract. In case of error, the CPU port bit
> is cleared.
>
> Fixes: 14be36c2c96c ("net: dsa: Initialize all CPU and enabled ports masks in
> dsa_d
break;
> - }
>
> if (skb != (struct sk_buff *)MTK_DMA_DUMMY_DESC) {
> bytes[mac] += skb->len;
Acked-by: Sean Wang <sean.w...@mediatek.com>
On Mon, 2017-07-17 at 15:38 +0200, Andrew Lunn wrote:
> On Mon, Jul 17, 2017 at 06:06:22PM +0800, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > The patch adds the supplements in the dt-binding document for MediaTek
> > M
On Wed, 2017-07-12 at 16:50 +0200, Andrew Lunn wrote:
> > +static int mtk_clk_enable(struct mtk_eth *eth)
> > +{
> > + int clk, ret;
> > +
> > + for (clk = 0; clk < MTK_CLK_MAX ; clk++) {
> > + if (eth->clks[clk]) {
> > + ret = clk_prepare_enable(eth->clks[clk]);
>
Hi, Gustavo
It indeed is useless at the current time point.
but actually I will add new SoC support to the driver in the next week,
which requires the variable match :-(
Sean
On Fri, 2017-07-07 at 15:23 -0500, Gustavo A. R. Silva wrote:
> Remove useless local variables _match_,
Hi Andrew
On Fri, 2017-03-24 at 15:19 +0100, Andrew Lunn wrote:
> On Tue, Mar 21, 2017 at 05:35:10PM +0800, sean.w...@mediatek.com wrote:
>
> Hi Sean
>
> > + /* Lower Tx Driving */
> > + for (i = 0 ; i < 6 ; i++)
>
> Could MT7530_CPU_PORT be used here?
>
I should create meaningful
Hi Andrew,
Add comment as below inline
On Fri, 2017-03-24 at 15:02 +0100, Andrew Lunn wrote:
> Hi Sean
>
> > + regmap = devm_regmap_init(ds->dev, NULL, priv,
> > + _regmap_config);
> > + if (IS_ERR(regmap))
> > + dev_warn(priv->dev, "phy regmap
Hi Florian,
Thank for taking your time on reviewing. Add comment as inline.
On Wed, 2017-03-22 at 11:39 -0700, Florian Fainelli wrote:
> On 03/21/2017 02:35 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > MT7530 is a 7-po
Hi Andrew,
The purpose for the regmap table registered is to
provide a way which helps us to look up a specific
register on the switch through regmap-debugfs.
And not all ranges of register is defined
so I only include the meaningful ones in a sparse way
for the table.
Sean
On
On Tue, 2017-03-14 at 00:11 +0100, Andrew Lunn wrote:
> > +static int
> > +mt7530_setup(struct dsa_switch *ds)
> > +{
> > + struct mt7530_priv *priv = ds->priv;
> > + int ret, i, phy_mode;
> > + u8 cpup_mask = 0;
> > + u32 id, val;
> > + struct regmap *regmap;
> > +
> > + /* Make sure
On Mon, 2017-03-13 at 09:47 -0700, Florian Fainelli wrote:
> On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > Add device-tree binding for Mediatek MT7530 switch.
> >
> > Cc: devicet...@vger.kernel.o
On Mon, 2017-03-13 at 12:59 -0400, Vivien Didelot wrote:
> Hi Sean,
>
> sean.w...@mediatek.com writes:
>
> > + mtk_tag[1] = (1 << p->port) & MTK_HDR_XMIT_DP_BIT_MASK;
>
> This won't apply, the port index in now stored in p->dp->index.
>
> Thanks,
>
> Vivien
Hi Vivien,
It seems
On Mon, 2017-03-13 at 09:35 -0700, Florian Fainelli wrote:
> On 03/13/2017 09:11 AM, sean.w...@mediatek.com wrote:
> > From: Sean Wang <sean.w...@mediatek.com>
> >
> > Add the support for the 4-bytes tag for DSA port distinguishing inserted
> > allowing receivin
On Mon, 2017-03-13 at 17:36 +0100, Andrew Lunn wrote:
> > +- mediatek,reset-pin: Phandle to the pinctrl node used for the reset. Which
> > + must be required if the property mediatek,mcm of specified as
> > + "disabled". See
> > + Documentation/devicetree/bindings/pinctrl/pinctrl-mt65xx.txt
Date: Thu, 22 Sep 2016 14:30:53 +0300, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
>>Hello.
>
>On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote:
>
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> adds PHY-mode "trgmii"
Date: Thu, 22 Sep 2016 19:48:47 +0300, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
>On 09/22/2016 07:16 PM, sean.w...@mediatek.com wrote:
>
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> fix typo in mediatek-net.txt and add phy-mode "trg
Date: Thu, 22 Sep 2016 14:28:36 +0300, Sergei Shtylyov
<sergei.shtyl...@cogentembedded.com> wrote:
>Hello.
>
>On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote:
>
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> Add the dts property for the capability
Date: Wed, 21 Sep 2016 16:17:20 +0200, Andrew Lunn <and...@lunn.ch> wrote:
>On Wed, Sep 21, 2016 at 02:16:30PM +0800, Sean Wang wrote:
>> Date: Tue, 20 Sep 2016 21:37:58 +0200, Andrew Lunn <and...@lunn.ch> wrote:
>> >On Tue, Sep 20, 2016 at 03:59:20PM +0800
Date: Tue, 20 Sep 2016 14:23:24 -0700, Florian Fainelli <f.faine...@gmail.com>
wrote:
>On 09/20/2016 12:59 AM, sean.w...@mediatek.com wrote:
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> adds PHY-mode "trgmii" as an extension for the operati
Date: Tue, 20 Sep 2016 21:37:58 +0200, Andrew Lunn <and...@lunn.ch> wrote:
>On Tue, Sep 20, 2016 at 03:59:20PM +0800, sean.w...@mediatek.com wrote:
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> Add the dts property for the capability if TRGMII supported on GAM
Date: Mon, 29 Aug 2016 15:15:58 +0200,Andrew Lunn wrote:
>On Mon, Aug 29, 2016 at 01:03:23PM +0800, sean.w...@mediatek.com wrote:
>> From: Sean Wang <sean.w...@mediatek.com>
>>
>> return -ENODEV if no child is found in MDIO bus.
>
>Hi Sean
>
>Why is it an er
Date: Fri, 26 Aug 2016 16:17:59 +0200, Andrew Lunn wrote:
>> Hi Andrew,
>>
>> Here pinctrl is used to setup what function the group of the pins is
>> for.
>
>Agreed.
>
>> The group of the pins could be configured for the function provided
>> by the SoC, such as general purpose I/O or specific
Date: Thu, 25 Aug 2016 15:35:34 +0200, John Crispin wrote:
>On 25/08/2016 12:44, Sean Wang wrote:
>> 1) mtk_stop() must be called to stop for freeing DMA resources
>> acquired and restoring state changed by mtk_open() when module
>> removal.
>>
>> 2) grou
On Date: Thu, 25 Aug 2016 15:49:10 +0200, John Crispin wrote:
>On 25/08/2016 12:44, Sean Wang wrote:
>> If the return value of devm_clk_get is EPROBE_DEFER, we should
>> defer probing the driver. The change is verified and works based
>> on 4.8-rc1 staying with the latest clk
On Thu, 25 Aug 2016 15:30:34 +0200, Andrew Lunn wrote:
>On Thu, Aug 25, 2016 at 06:44:57PM +0800, Sean Wang wrote:
>> ommited the setting about pin-mux which results in incorrect signals
>> being routed on GMAC2.
>
>Hi Sean
>
>Please could you explain this some more.
original mdio_cleanup is not in the symmetric place against where
mdio_init is, so relocate mdio_cleanup to the right one.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
If the return value of devm_clk_get is EPROBE_DEFER, we should
defer probing the driver. The change is verified and works based
on 4.8-rc1 staying with the latest clk-next code for MT7623.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.
use skb_free_frag() instead of legacy put_page()
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
a couple of fixes come out from integrating with linux-4.8 rc1
they all are verified and workable on linux-4.8 rc1
Sean Wang (10):
net: ethernet: mediatek: fix fails from TX housekeeping due to
incorrect port setup
net: ethernet: mediatek: fix incorrect return value of devm_clk_get
return -ENODEV if no child is found in MDIO bus.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
in the later series of patches.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
these irqs are not used for shared irq and disabled during ethernet stops.
irq requested by devm_request_irq is safe to be freed automatically on
driver detach.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 --
1 file changed, 2 del
ommited the setting about pin-mux which results in incorrect signals
being routed on GMAC2.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 14 ++
drivers/net/ethernet/mediatek/mtk_eth_soc.h | 3 +++
2 files changed, 17 inse
which net device the SKB is complete for depends on the forward port
on txd4 on the corresponding TX descriptor, but the information isn't
set up well in case of SKB fragments that would lead to watchdog timeout
from the upper layer, so fix it up.
Signed-off-by: Sean Wang <sean.w...@mediatek.
This patch adds the missing of_node_put() after finishing the usage
of of_get_child_by_name.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_so
a lot of parts in the driver uses devm_* APIs to gain benefits from the
device resource management, so devm_mdiobus_alloc is also used instead
of mdiobus_alloc to have more elegant code flow.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.
nd add indents before comments.
Sean Wang (2):
net: ethernet: mediatek: enhance RX path by reducing the frequency of
the memory barrier used
net: ethernet: mediatek: enhance RX path by aggregating more SKBs
into NAPI
drivers/net/ethernet/mediatek/mtk_eth_soc.c
The patch adds support for aggregating more SKBs feed into NAPI in
order to get more benefits from generic receive offload (GRO) by
peeking at the RX ring status and moving more packets right before
returning from NAPI RX polling handler if NAPI budgets are still
available.
Signed-off-by: Sean
based on the setup with one port
using Giga PHY and 256 RX descriptors for DMA to move.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/me
The patch fixes up the incorrect setup of reduced MII (RMII) on GMAC
and adds the supplement for the setup of reverse MII (REVMII) on GMAC
, and rearranges the error handling for invalid PHY argument.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/me
This patch set fixes the following warning and issues
v1 -> v2: Fix message typos and add coverletter
v2 -> v3: Split from the previous series for submitting bug fixes
as a series targeting 'net'
Sean Wang (3):
net: ethernet: mediatek: fix RMII mode and add REVMII supported by
GMAC
proper handling on
the both GMAC with the shared common logic.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index e
.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index e
The patch adds support for aggregating more skbs feed into NAPI in
order to get more benifits from generic receive offload (GRO) by
peeking at the RX ring status and moving more packets right before
returning from NAPI RX polling handler if NAPI budgets are still
available.
Signed-off-by: Sean
The patch adds the supplement for the setup of reverse MII (REVMII)
on GMAC, fixes up the incorrect setup of reduced MII (RMII) on GMAC
and rearranges the error handling for invalid phy argument.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth
er handling on
the both GMAC with the shared common logic.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
This patch set fixes the following warning and issues and gives some
enhancements about RX path handling.
v1 -> v2: fix message typos and add coverletter
Sean Wang (5):
net: ethernet: mediatek: add REVMII and fix RMII mode supported by
GMAC
net: ethernet: mediatek: fix flow cont
on the setup with one port
using gigaphy and 256 RX descriptors for DMA to move.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/me
The patch adds support for aggregrating more skbs feed into NAPI in
order to get benifits from generic receive offload (GRO) by peeking
at the RX ring status and moving more packet right before returning
from NAPI rx handler if NAPI budgets is still available.
Signed-off-by: Sean Wang <sea
gigaphy and 256 rx descriptors for
DMA to move.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/et
The patch adds the supplement for the setup of reverse MII (REVMII)
on GMAC, fixes up incorrect setup of reduced mii (RMII) on GMAC and
rearranges the error handling path for invalid phy argument.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth
.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index e
er handling on
the both GMAC with the shared common logic.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
b/drivers/net/ethernet/me
This patch adds the missing of_node_put() after finishing the usage
of of_parse_phandle() or of_node_get() used by fixed_phy.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drive
To fix runtime warning with lockdep is enabled due that u64_stats_sync
is not initialized well, so add it.
Signed-off-by: Sean Wang <sean.w...@mediatek.com>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/me
66 matches
Mail list logo
