On 3/29/21 10:52 PM, Ido Schimmel wrote:
ip_route_me_harder() does not set source / destination port in the
flow key, so it explains why fib rules that use them are not hit after
mangling the packet. These keys were added in 4.17, but I
don't think this use case every worked. You have a differen
On 3/29/21 10:52 PM, Ido Schimmel wrote:
On Sun, Mar 28, 2021 at 04:05:29PM +0200, Michal Soltys wrote:
Hi,
I'm not sure how it behaved in earlier kernels (can check later), but it is
/ looks bugged in at least recent 5.x+ ones (tests were done with 5.11.8 and
5.10.25).
Consider foll
On 3/28/21 4:05 PM, Michal Soltys wrote:
Hi,
iptables -t mangle -A OUTPUT -j MARK --set-mark 1
After some extra checks, the exact same issue happens if we mangle tos
instead of mark, so ...
iptables -t mangle -A OUTPUT -j TOS --set-tos 0x02
... will cause same routing issues with
Hi,
I'm not sure how it behaved in earlier kernels (can check later), but it
is / looks bugged in at least recent 5.x+ ones (tests were done with
5.11.8 and 5.10.25).
Consider following setup:
# ip -o ad sh
1: loinet 127.0.0.1/8 scope host lo
2: right1inet 10.0.10.2/24 scope global
3
Hi,
This got me a bit surprised actually and I'm wondering if it's intended.
While both options are somewhat similar in their function, they do
different things after all (and for different protocols):
- arp_filter - whether all interfaces should consider responding for arp
request (which th
ffect on bond interfaces
Fixes: 6a9e461f6fe4 (bonding: pass link-local packets to bonding master also.)
Reported-by: Vincent Bernat
Signed-off-by: Michal Soltys
---
drivers/net/bonding/bond_main.c | 35 +
1 file changed, 14 insertions(+), 21 deletions(-)
diff --
d code, I will submit v2 patch with
added comment explaining basic logic (or you could submit if you prefer).
On Thu, Jan 17, 2019 at 4:27 PM Michal Soltys wrote:
On 19/01/14 03:01, Maciej Żenczykowski wrote:
> So I don't remember the specifics...
>
> (note I'm writing
On 19/01/14 03:01, Maciej Żenczykowski wrote:
So I don't remember the specifics...
(note I'm writing this all from memory without looking it up/testing
it - I may be utterly wrong or dreaming)
But I seem to recall that the core problem we were trying to solve was
that a daemon listening
on an A
On 19/01/15 03:19, Mahesh Bandewar (महेश बंडेवार) wrote:
On Mon, Jan 14, 2019 at 12:00 AM Vincent Bernat wrote:
❦ 13 janvier 2019 18:01 -08, Maciej Żenczykowski :
> But I seem to recall that the core problem we were trying to solve was
> that a daemon listening
> on an AF_PACKET ethertype 88
On 19/01/14 03:01, Maciej Żenczykowski wrote:
So I don't remember the specifics...
(note I'm writing this all from memory without looking it up/testing
it - I may be utterly wrong or dreaming)
But I seem to recall that the core problem we were trying to solve was
that a daemon listening
on an A
ation to packet(7).
See v2.6.21-350-g80feaacb8a64 for details about PACKET_ORIGDEV.
Michal Soltys (1):
bonding: fix PACKET_ORIGDEV regression on bonding masters
drivers/net/bonding/bond_main.c | 21 -
1 file changed, 21 deletions(-)
--
2.20.1
e 4.12.
The patch reverts to pre-b89f04c61efe state, so:
- both master and original (via PACKET_ORIGDEV) devices are available
when listening on the master
- original device is available when listening directly on one of its
slaves
Reported-by: Vincent Bernat
Signed-off-by: Michal Soltys
---
dri
On 18/12/20 06:55, Vincent Bernat wrote:
> ❦ 19 décembre 2018 23:57 +01, Michal Soltys :
>
>>>> Commit b89f04c61efe ("bonding: deliver link-local packets with
>>>> skb->dev set to link that packets arrived on") changed the behavior
>>>>
On 18/11/30 22:32, Vincent Bernat wrote:
> ❦ 15 juillet 2018 19:12 -0700, Mahesh Bandewar :
>
>> Commit b89f04c61efe ("bonding: deliver link-local packets with
>> skb->dev set to link that packets arrived on") changed the behavior
>> of how link-local-multicast packets are processed. The change i
On 2018-07-19 18:20, Michal Soltys wrote:
> On 07/19/2018 01:41 AM, Mahesh Bandewar wrote:
>> From: Mahesh Bandewar
>>
>> Commit b89f04c61efe ("bonding: deliver link-local packets with
>> skb->dev set to link that packets arrived on") changed the behavio
local packets with skb->dev set to link
that packets arrived on")
Reported-by: Michal Soltys
Signed-off-by: Mahesh Bandewar
---
v2: Added Fixes tag.
v1: Initial patch.
drivers/net/bonding/bond_main.c | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff -
On 2018-07-17 11:32, Michal Soltys wrote:
> On 07/17/2018 01:53 AM, Mahesh Bandewar (महेश बंडेवार) wrote:
>> On Mon, Jul 16, 2018 at 2:24 PM, Jay Vosburgh
>> wrote:
>>> Mahesh Bandewar wrote:
>>>
>>>> From: Mahesh Bandewar
>>>>
>>&g
ed
on as well as passes to the bonding-master device to preserve the
legacy use case.
Reported-by: Michal Soltys
Signed-off-by: Mahesh Bandewar
Thanks for fixing this.
Why not add a Fixes: tag instead of just talking about the commit?
That helps the stable maintainers know which versions of th
On 07/17/2018 01:53 AM, Mahesh Bandewar (महेश बंडेवार) wrote:
On Mon, Jul 16, 2018 at 2:24 PM, Jay Vosburgh
wrote:
Mahesh Bandewar wrote:
From: Mahesh Bandewar
Commit b89f04c61efe ("bonding: deliver link-local packets with
skb->dev set to link that packets arrived on") changed the behavior
On 07/13/2018 02:15 AM, Mahesh Bandewar (महेश बंडेवार) wrote:
On Thu, Jul 12, 2018 at 4:14 PM, Michal Soltys wrote:
On 2018-07-13 00:03, Jay Vosburgh wrote:
Mahesh Bandewar (महेश बंडेवार) wrote:
On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh
wrote:
Michal Soltys wrote:
On 07/12/2018 04
On 2018-07-13 00:03, Jay Vosburgh wrote:
> Mahesh Bandewar (महेश बंडेवार) wrote:
>
>>On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh
>> wrote:
>>> Michal Soltys wrote:
>>>
>>>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote:
>>>>> Mahesh B
On 2018-07-12 23:26, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh
> wrote:
>> Michal Soltys wrote:
>>
>>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote:
>>>> Mahesh Bandewar (महेश बंडेवार) wrote:
>>>>
&
On 07/12/2018 04:51 PM, Jay Vosburgh wrote:
Mahesh Bandewar (महेश बंडेवार) wrote:
On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote:
Hi,
As weird as that sounds, this is what I observed today after bumping
kernel version. I have a setup where 2 bonds are attached to linux
bridge and
Hi,
As weird as that sounds, this is what I observed today after bumping
kernel version. I have a setup where 2 bonds are attached to linux
bridge and physically are connected to two switches doing MSTP (and
linux bridge is just passing them).
Initially I suspected some changes related to bridge
>
> At this point I'm a bit lost what I'm doing wrong.
>
Just in case (erhm... for sake of completness and archiving) to answer
my own borderline silly question - handles and classids are in hex.
Hi,
I have hit some weird (probably missing some detail) issue with drr.
Originally it was tested between two machines, then I quickly double
checked between namespaces (same behaviour) - the configuration follows:
# setup namespace
ip netns add drrtest
ip li add name left type veth peer name ri
On 2016-09-08 04:03, Toshiaki Makita wrote:
> On 2016/09/08 3:22, Michal Soltys wrote:
> ...
>> 4.7.2
>> git describe on that commit suggests it's been available since 4.6.x
>>
>> What I did in details:
>>
>> ip li add name port1b type veth peer na
On 2016-09-07 02:19, Eric Dumazet wrote:
> On Tue, 2016-09-06 at 23:00 +0200, Michal Soltys wrote:
>> On 2016-09-06 22:21, Alexander Duyck wrote:
>> > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote:
>> >> Hi,
>> >>
>> >> I've been
On 2016-09-07 02:44, Toshiaki Makita wrote:
> On 2016/09/07 6:59, Michal Soltys wrote:
>> Consider following scenario:
>>
>> - create vlan aware bridge (say br0)
>> - setup br0's vlans, e.g.
>>
>> bridge vlan add dev br0 vid 10 self
>>
On 2016-09-07 02:19, Eric Dumazet wrote:
> On Tue, 2016-09-06 at 23:00 +0200, Michal Soltys wrote:
>> On 2016-09-06 22:21, Alexander Duyck wrote:
>> > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote:
>> >> Hi,
>> >>
>> >> I've been
Consider following scenario:
- create vlan aware bridge (say br0)
- setup br0's vlans, e.g.
bridge vlan add dev br0 vid 10 self
This will add necessary fdb entries directing appropriate traffic to the
bridge itself.
- create appropriate vlan interfaces on top of it, for example:
ip li add link
On 2016-09-06 22:21, Alexander Duyck wrote:
> On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote:
>> Hi,
>>
>> I've been testing different configurations and I didn't manage to get XPS to
>> "behave" correctly - so I'm probably misunderstand
Hi,
I've been testing different configurations and I didn't manage to get XPS to
"behave" correctly - so I'm probably misunderstanding or forgetting something.
The nic in question (under tg3 driver - BCM5720 and BCM5719 models) was
configured to 3 tx and 4 rx queues. 3 irqs were shared (tx and
The patch fixes this bug and keepis vt and fsc in sync (virtual times
are cumulative, not local to the backlog period).
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 44
1 file changed, 12 insertions(+), 32 deletions(-)
diff --git a/net/sche
The code using this variable has been commented out in the past as it
was causing issues in upperlimited link-sharing scenarios.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched
l and Am2_3real is what actually
happens due to rtsc_min() calculating minimum from corrected and uncorrected
curves.
Michal Soltys (2):
net/sched/sch_hfsc.c: keep fsc and virtual times in sync; fix an old
bug
net/sched/sch_hfsc.c: remove unused cl_myfadj
net/sched/
h fixes this bug and keepis vt and fsc in sync (virtual times
are cumulative, not local to the backlog period).
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 44
1 file changed, 12 insertions(+), 32 deletions(-)
diff --git a/net/sched/sch_
The part of the code using it is commented out, so the needless use
of this variable can be commented out as well.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
other
commented out piece of code.
Michal Soltys (2):
net/sched/sch_hfsc.c: keep fsc and virtual times in sync; fix an old
bug
net/sched/sch_hfsc.c: comment out cl_myfadj
net/sched/sch_hfsc.c | 56 +---
1 file changed, 23 insertions(+
On 2016-07-26 22:06, Alexander Duyck wrote:
> On Tue, Jul 26, 2016 at 12:52 PM, Michal Soltys wrote:
>> Hi,
>>
>> I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520
>> servers - and all of them have certain peculiarity: they claim to have
>>
Hi,
I have a few of BCM5720 and BCM5719 kinds sitting in Dell R320 and R520
servers - and all of them have certain peculiarity: they claim to have
up to 4 TX and RX rings (and this can be set/verified just fine through
ethtool -l/-L, with driver defaulting to 4 rings), indirection table
(ethtool -
- baseclass: major handle must match that of class's, Y defaults to 1
- flow map example: maps to 1-256, not 1-257
Signed-off-by: Michal Soltys
---
man/man8/tc-flow.8 | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/man/man8/tc-flow.8 b/man/man8/tc-flow.8
On 2016-07-04 16:22, Florian Westphal wrote:
> hfsc_sched is huge (size: 920, cachelines: 15), but we can get it to 14
> cachelines by placing level after filter_cnt (covering 4 byte hole) and
> reducing period/nactive/flags to u32 (period is just a counter,
> incremented when class becomes active
.SH "AUTHOR"
.
-Manpage created by Michal Soltys (sol...@ziu.info)
+Manpage created by Michal Soltys (sol...@ziu.info)
diff --git a/man/man8/tc-hfsc.8 b/man/man8/tc-hfsc.8
index 5444118..fd0df8f 100644
--- a/man/man8/tc-hfsc.8
+++ b/man/man8/tc-hfsc.8
@@ -54,8 +54,8 @@ parameters, you will
mirror those from concave intersection)
But these are eventually for later.
Michal Soltys (5):
net/sched/sch_hfsc.c: handle corner cases where head may change invalidating
calculated deadline
net/sched/sch_hfsc.c: add unlikely() in qdisc_peek_len()
net/sched/sch_hfsc.c: remove leftover dlist
cl->cl_vt alone is relative only to the current backlog period, while
the curve operates on cumulative virtual time. This patch adds missing
cl->cl_vtoff.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net
The condition can only succeed on wrong configurations.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 6d6df6b..e2244bb 100644
--- a/net/sched/sch_hfsc.c
+++ b/net/sched
every subsequent hfsc_dequeue() call uses packet peeked by
the previous call.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
index 8cb5eff..6d6df6b 100644
--- a/net/
This is update to:
commit a09ceb0e08140a ("sched: remove qdisc->drop")
That commit removed qdisc->drop, but left alone dlist and droplist
that no longer serve any meaningful purpose.
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 8
1 file changed, 8 deletion
ctive /without/ its parent going passive - with cl_vt lagging one
packet behind - comparison made in init_vf() will be affected (same
period).
Signed-off-by: Michal Soltys
---
net/sched/sch_hfsc.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git
On 2016-06-24 23:09, Elad Raz wrote:
On Fri, Jun 24, 2016 at 10:14 PM, Michal Soltys wrote:
Hi,
The switch respected BPDUs sent to it (if applicable) - for example it
complied properly if it's priority was less (numerically higher) than
linux's - showing linux box as root bridge, m
Hi,
In the last week I've been trying to get STP on the linux side (both its
builtin STP implementation as well as mstpd userspace daemon). Initially
I started with more complex setups (vlan aware bridge, bonds, mst) and
gradually (with identical problems on each step) ended with the most
bas
52 matches
Mail list logo
