Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Denys wrote: Possible i discovered bug, but maybe specific to my setup. In your sources (tc/tc_core.h) i notice #define TIME_UNITS_PER_SEC10 When i change it to #define TIME_UNITS_PER_SEC 100.0 (it was value before in sources) everythign works fine. Otherwise

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Denys
Dear Sir Already i sent. I will copy here also Normal patched by me iproute2 /sbin/tc qdisc del dev ppp0 root /sbin/tc qdisc add dev ppp0 root handle 1: prio /sbin/tc qdisc add dev ppp0 parent 1:1 handle 2: tbf buffer 1024kb latency 500ms rate 128kbit peakrate 256kbit minburst 16384

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Denys wrote: /sbin/tc2 qdisc del dev ppp0 root /sbin/tc2 qdisc add dev ppp0 root handle 1: prio /sbin/tc2 qdisc add dev ppp0 parent 1:1 handle 2: tbf buffer 1024kb latency 500ms rate 128kbit peakrate 256kbit minburst 16384 /sbin/tc2 filter add dev ppp0 parent 1:0 protocol ip prio 10 u32

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Please don't remove CCs. Denys wrote: 1024kb (if i am not wrong 1Mbyte) is huge? For me it is ok, as soon as i have RAM. Its not about the memory, its about the resulting queueing delay. If you buffer packets for 64 seconds the sender will retransmit them and you end up wasting bandwidth.

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Denys
Dear sir Sorry, i forgot to CC other members of discussion. 1024kb (if i am not wrong 1Mbyte) is huge? For me it is ok, as soon as i have RAM. Another thing, it is working well with old tc. Just really if i have plenty of RAM's and i want 32second buffer, why i cannot have that, and if i

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Denys
On Thu, 22 Mar 2007 14:23:01 +0100, Patrick McHardy wrote Please don't remove CCs. Denys wrote: 1024kb (if i am not wrong 1Mbyte) is huge? For me it is ok, as soon as i have RAM. Its not about the memory, its about the resulting queueing delay. If you buffer packets for 64 seconds

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Denys wrote: Another thing, it is working well with old tc. Just really if i have plenty of RAM's and i want 32second buffer, why i cannot have that, and if i see it is really possible before? I know it worked before. But I can't think of a reason why anyone would want a buffer that large. Why

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Denys
Hi again On Thu, 22 Mar 2007 14:43:43 +0100, Patrick McHardy wrote Denys wrote: Another thing, it is working well with old tc. Just really if i have plenty of RAM's and i want 32second buffer, why i cannot have that, and if i see it is really possible before? I know it worked before.

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Stephen Hemminger
On Thu, 22 Mar 2007 14:09:06 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: Denys wrote: /sbin/tc2 qdisc del dev ppp0 root /sbin/tc2 qdisc add dev ppp0 root handle 1: prio /sbin/tc2 qdisc add dev ppp0 parent 1:1 handle 2: tbf buffer 1024kb latency 500ms rate 128kbit peakrate 256kbit

Re: iproute2-2.6.20-070313 bug ?

2007-03-22 Thread Patrick McHardy
Stephen Hemminger wrote: tc should check for overflows and doesn't. Do you want to make a patch for the obvious cases? I agree. I'll take care of it once I'm done with my patches for 2.6.22. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

iproute2-2.6.20-070313 bug ?

2007-03-21 Thread Denys
Possible i discovered bug, but maybe specific to my setup. In your sources (tc/tc_core.h) i notice #define TIME_UNITS_PER_SEC10 When i change it to #define TIME_UNITS_PER_SEC 100.0 (it was value before in sources) everythign works fine. Otherwise tbf not working at all,