Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-27 Thread Kalle Valo
punit vara writes: > Will my other patches which are already correct be added to wireless > tree ? or I have to resend everything ? Yes, please resend the whole patchset. I don't apply patches individually from a patchset, it's just too time consuming and error prone.

pull-request: wireless-drivers-next 2015-10-27

2015-10-27 Thread Kalle Valo
Hi Dave, here's a bigger pull request for 4.4. The diffstat looks scary as we created a new directory realtek for all realtek drivers. In the future I'm planning to create similar directories for all vendors, currently we just have ath, mediatek and realtek. This change has been in linux-next for

Re: [PATCH V5 1/1] bpf: control events stored in PERF_EVENT_ARRAY maps trace data output when perf sampling

2015-10-27 Thread xiakaixu
于 2015/10/23 23:12, Peter Zijlstra 写道: > On Fri, Oct 23, 2015 at 02:52:11PM +0200, Peter Zijlstra wrote: >> On Thu, Oct 22, 2015 at 06:28:22PM +0800, Wangnan (F) wrote: >>> information to analysis when glitch happen. Another way we are trying to >>> implement >>> now is to dynamically turn events

Re: [PATCHv2 net 2/2] ipv4: update RTNH_F_LINKDOWN flag on UP event

2015-10-27 Thread Julian Anastasov
Hello, On Tue, 27 Oct 2015, Andy Gospodarek wrote: > I tested this patch and I now see that your reported problem is a result > of dummy never taking carrier down. There was a presumption that > carrier notification would go down when hardware went down (or when the > logical device

[PATCH] net: hns: fixes the bug tested XGE by ethtool -p

2015-10-27 Thread yankejian
From: Li Peng delete action of ETHTOOL_ID_ON/ETHTOOL_ID_OFF in XGE ethtool -p, so Hardware control the LED state instead of software. Signed-off-by: Li Peng Signed-off-by: Yisen Zhuang Signed-off-by: yankejian

[PATCH net-next] gianfar: Increase TX_TIMEOUT to 5HZ

2015-10-27 Thread Abhimanyu
Increased TX_TIMEOUT to 5HZ to accommodate worst case situation for traffic and CPU intensive use cases Signed-off-by: Priyanka Jain Signed-off-by: Abhimanyu --- drivers/net/ethernet/freescale/gianfar.c |2 +- 1 files changed, 1

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-27 Thread Vladimir Davydov
On Mon, Oct 26, 2015 at 01:22:16PM -0400, Johannes Weiner wrote: > On Thu, Oct 22, 2015 at 09:45:10PM +0300, Vladimir Davydov wrote: > > Hi Johannes, > > > > On Thu, Oct 22, 2015 at 12:21:28AM -0400, Johannes Weiner wrote: > > ... > > > Patch #5 adds accounting and tracking of socket memory to

Re: [PATCH v1 1/3] virtio-net: Using single MSIX IRQ for TX/RX Q pair

2015-10-27 Thread Michael S. Tsirkin
On Mon, Oct 26, 2015 at 10:52:47AM -0700, Ravi Kerur wrote: > Ported earlier patch from Jason Wang (dated 12/26/2014). > > This patch tries to reduce the number of MSIX irqs required for > virtio-net by sharing a MSIX irq for each TX/RX queue pair through > channels. If transport support channel,

RE: [PATCH net-next] gianfar: Increase TX_TIMEOUT to 5HZ

2015-10-27 Thread Manoil Claudiu
>-Original Message- >From: Abhimanyu [mailto:abhima...@freescale.com] >Sent: Tuesday, October 27, 2015 10:48 AM >To: David S. Miller ; netdev@vger.kernel.org >Cc: Manoil Claudiu-B08782 ; Saini >Abhimanyu-B49017 ;

[PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread Michael S. Tsirkin
commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian support for legacy devices") introduced a minor regression: even with cross-endian disabled, and even on LE host, vhost_is_little_endian is checking is_le flag so there's always a branch. To fix, simply check

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Richard Cochran
On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > > netstamp_needed is toggled for all socket families if they request > > > timestamping. But

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread Greg Kurz
On Tue, 27 Oct 2015 11:37:39 +0200 "Michael S. Tsirkin" wrote: > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian is >

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Casper . Dik
>And no, I'm not fond of such irregular ways to pass file descriptors, but >we can't kill ioctl(2) with all weirdness hiding behind it, more's the pity... Yeah, there are a number of calls which supposed work on one but have a second argument which is also a file descriptor; mostly part of

Kernel Panic: DM9601 Fast Ethernet Adapter on ARMv7

2015-10-27 Thread Strongly Typed
Dear list, Peter as the maintainer from MAINTAINERS is not reachable by mail (mail delivery failed) so I send this to the list directly. I am experiencing a kernel oops on a regular basis with a DM9601 Fast Ethernet Adapter on an Raspberry Pi 2 Model B. I collected as much information as

Jó nap,

2015-10-27 Thread CORPORATE LENDERS PLC
-- Jó nap, Én vagyok Mr. Laurence Howard, egy végrehajtó ügynök egy jól ismert legitim hitelező társaság nevén Vállalati hitelezők. Van egy rossz hitel, vagy ha szükségük van a pénz a számlák kifizetéséhez? a kamatláb 3%. Töltse ki az alábbi űrlapot, ha érdekel. Teljes név: Nem:

Re: [PATCH net] macvtap: unbreak receiving of gro skb with frag list

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 10:58:25AM +0800, Jason Wang wrote: > > > On 10/26/2015 04:30 PM, Michael S. Tsirkin wrote: > > On Mon, Oct 26, 2015 at 02:53:38PM +0800, Jason Wang wrote: > >> > >> On 10/26/2015 02:09 PM, Michael S. Tsirkin wrote: > >>> On Mon, Oct 26, 2015 at 11:15:57AM +0800, Jason

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Alan Burlison
On 27/10/2015 09:08, casper@oracle.com wrote: Generally I wouldn't see that as a problem, but in the case of a socket blocking on accept indefinitely, I do see it as a problem especially as the thread actually wants to stop listening. But in general, this is basically a problem with the

Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-27 Thread Stephen Hemminger
> + > +static struct ethtool_ops nb8800_ethtool_ops = { Ops should be const > + .get_settings = nb8800_get_settings, > + .set_settings = nb8800_set_settings, > + .nway_reset = nb8800_nway_reset, > + .get_link = ethtool_op_get_link, >

stmmac: Reporting ethtool_ts_info

2015-10-27 Thread Phil Reid
G'day All, The stmmac driver checks (priv->hwts_tx_en) && (priv->hwts_rx_en) before reporting WHTSTAMP capabilities. No other driver seems to do this. hwts_*_en indicate if timestamping is enabled, not if the interface is capable of it. Instead they check there capabilities. Which would be

Re: [PATCH v7 05/10] ss: replaced old output with new generic output mechanisms

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:03PM +0200, Matthias Tafelmeier wrote: > This patch just adds the -j and --json flag to ss. Also it ensures proper > stats components bracketization – that goes for ex. TCP, UDP, NETLINK etc. > > Moreover, this patch prevents human readable headers to be printed. >

Re: [PATCH v7 07/10] ss: symmetrical subhandler output extension example

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:05PM +0200, Matthias Tafelmeier wrote: > This small sized patch shall convey the locations which have to be > changed for a symmetrical output extension. Symmetrical means in this > context all existing semantically related handlers in the diverse > formatters (for hr

Re: 802.3 ad bonding mode min-links doesn't work correctly once slave port link status is up again

2015-10-27 Thread Nikolay Aleksandrov
On 10/27/2015 01:55 PM, Arjun Pandey wrote: > Hi Nikolay > > But based on this output i think they are part of same aggregator. > cat /sys/class/net/bond/bonding/slaves > eth2 eth1 > I am adding slave ports via ifenslave bond eth1 eth2 > Hi again, Please don't top post. You've shown that

Re: [PATCH v7 08/10] ss: symmetrical formatter extension example

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:06PM +0200, Matthias Tafelmeier wrote: > This commit shall show shortly where to place changes when one wants to > extend an ss output formatter with a new handler (format print > procedure). The extension is done symmetrically. That means, every up to > now existing

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread David Miller
From: Alan Burlison Date: Tue, 27 Oct 2015 10:52:46 + > an implicit shutdown() it would mean that well-written applications > that handled the scoping, sharing and reuse of FDs properly could just > call close() and have it work the same way across *NIX platforms.

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-27 Thread Phil Sutter
On Tue, Oct 27, 2015 at 06:47:53AM -0700, David Miller wrote: > > Please do not quote an entire large patch in a reply just to common on > one particular section of the change. > > Instead, trim it to just the necessary context. OK, I'll make sure to remember this. Better don't read my other

Re: 802.3 ad bonding mode min-links doesn't work correctly once slave port link status is up again

2015-10-27 Thread Arjun Pandey
Hi Nikolay But based on this output i think they are part of same aggregator. cat /sys/class/net/bond/bonding/slaves eth2 eth1 I am adding slave ports via ifenslave bond eth1 eth2 Each individual slave port seems to be getting a different aggr id. I confirmed this by adding an additional port

Re: [PATCH v7 06/10] ss: renaming and export of current_filter

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:04PM +0200, Matthias Tafelmeier wrote: > Exported current_filter as ss_current_filter, because in > the fmt handlers, I need that piece of info to resolve out issues of json. This patch should come before the patches using the new name. > Signed-off-by: Matthias

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread David Miller
From: "Michael S. Tsirkin" Date: Tue, 27 Oct 2015 11:37:39 +0200 > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > support for legacy devices") introduced a minor regression: even with > cross-endian disabled, and even on LE host, vhost_is_little_endian

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 12:15 +0100, Hannes Frederic Sowa wrote: > Also counter question: why is the netstamp code protected by a > static_key otherwise if not for trying to suppress the code path as > often as possible if not used? ;) Any idea of why timestamping is asked on AF_UNIX in the first

Re: [PATCH v7 09/10] ss: fixed free on local array for valid json output

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:07PM +0200, Matthias Tafelmeier wrote: > Minor fix to enable json output. Freeing of automatic char array name > which will get freed after function stack cleanup. Another one after > tcp_stats_fmt for freeing automatic tcpstats struct instance. > > Signed-off-by:

Re: [PATCH v7 10/10] ss: activate json_writer excluded logic

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:08PM +0200, Matthias Tafelmeier wrote: > This small patch extends the lib json_writer module for formerly > deactivated functionality. Why was it deactivated in the first place? > > Signed-off-by: Matthias Tafelmeier > --- >

Re: 802.3 ad bonding mode min-links doesn't work correctly once slave port link status is up again

2015-10-27 Thread Nikolay Aleksandrov
On 10/27/2015 02:16 PM, Nikolay Aleksandrov wrote: > On 10/27/2015 01:55 PM, Arjun Pandey wrote: >> Hi Nikolay >> >> But based on this output i think they are part of same aggregator. >> cat /sys/class/net/bond/bonding/slaves >> eth2 eth1 >> I am adding slave ports via ifenslave bond eth1 eth2 >>

Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-10-27 Thread David Miller
From: Jakub Kicinski Date: Tue, 27 Oct 2015 11:16:03 + > On Mon, 26 Oct 2015 18:23:07 -0700 (PDT), David Miller wrote: >> From: Jakub Kicinski >> Date: Fri, 23 Oct 2015 19:58:11 +0100 >> >> > +struct nfp_net_tx_buf { >> > +

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-27 Thread David Miller
Please do not quote an entire large patch in a reply just to common on one particular section of the change. Instead, trim it to just the necessary context. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread David Miller
From: Michal Hocko Date: Tue, 27 Oct 2015 13:26:47 +0100 > On Mon 26-10-15 12:56:19, Johannes Weiner wrote: > [...] >> Or any other combination of pick-and-choose consumers. But >> honestly, nowadays all our paths are lockless, and the counting is an >> atomic-add-return with

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 12:09, Hannes Frederic Sowa wrote: > Hi Richard, > > On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > > > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > > > On Mon, Oct 26,

Re: [PATCH 2/2] net: add driver for Netronome NFP4000/NFP6000 NIC VFs

2015-10-27 Thread Jakub Kicinski
On Mon, 26 Oct 2015 18:23:07 -0700 (PDT), David Miller wrote: > From: Jakub Kicinski > Date: Fri, 23 Oct 2015 19:58:11 +0100 > > > +struct nfp_net_tx_buf { > > + struct sk_buff *skb; > > + dma_addr_t dma_addr; > > + short int fidx; > > + u16 pkt_cnt; > > +

[PATCH net-next v2] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread Roopa Prabhu
From: Roopa Prabhu Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "is_local" to 1 and in

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Alan Burlison
On 27/10/2015 12:01, Eric Dumazet wrote: Are non multi threaded applications considered well written ? listener = socket(...); bind(listener, ...); listen(fd, 1); Loop 1 10 if (fork() == 0) do_accept(listener) Now if a child does a close(listener), or is killed, you propose that

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread Michal Hocko
On Mon 26-10-15 12:56:19, Johannes Weiner wrote: [...] > Now you could argue that there might exist specialized workloads that > need to account anonymous pages and page cache, but not socket memory > buffers. Exactly, and there are loads doing this. Memcg groups are also created to limit

[PATCH RESEND v2 net-next] net: hisilicon: updates HNS config and documents

2015-10-27 Thread huangdaode
From: yankejian updates the bindings documents and dtsi file according to the review comments[https://lkml.org/lkml/2015/9/21/670] from Rob Herring Acked-by: Rob Herring Signed-off-by: yankejian Signed-off-by:

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Jesper Dangaard Brouer
On Tue, 27 Oct 2015 12:15:16 +0100 Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 12:09, Hannes Frederic Sowa wrote: > > Hi Richard, > > > > On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > > > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes

Re: 802.3 ad bonding mode min-links doesn't work correctly once slave port link status is up again

2015-10-27 Thread Nikolay Aleksandrov
On 10/27/2015 01:17 PM, Arjun Pandey wrote: > Hi > > I have configured a bond with 2 slave bond ports in 802.3 ad mode. > I have also set min-links=2 and miimon=100 > > > root@foo bonding]# cat /proc/net/bonding/bond > Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011) > > Bonding Mode:

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 12:27 +, Alan Burlison wrote: > On 27/10/2015 12:01, Eric Dumazet wrote: > > > Are non multi threaded applications considered well written ? > > > > listener = socket(...); > > bind(listener, ...); > > listen(fd, 1); > > Loop 1 10 > >if (fork() == 0) > >

Re: [PATCH net-next] sock: don't enable netstamp for af_unix sockets

2015-10-27 Thread Hannes Frederic Sowa
Hi Richard, On Tue, Oct 27, 2015, at 11:11, Richard Cochran wrote: > On Mon, Oct 26, 2015 at 02:32:59PM +0100, Hannes Frederic Sowa wrote: > > On Mon, Oct 26, 2015, at 14:19, Richard Cochran wrote: > > > On Mon, Oct 26, 2015 at 01:51:37PM +0100, Hannes Frederic Sowa wrote: > > > > netstamp_needed

Re: [PATCH v7 02/10] ss: created formatters for json and hr

2015-10-27 Thread Phil Sutter
On Thu, Sep 10, 2015 at 09:35:00PM +0200, Matthias Tafelmeier wrote: > This patch creates a central formatter module that acts as a kind of > switch. From there, more specific handler modules for the certain output > formats are called. Up to now, humand readable and json do exist. > > That

Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller

2015-10-27 Thread Måns Rullgård
Stephen Hemminger writes: >> +.get_settings = nb8800_get_settings, >> +.set_settings = nb8800_set_settings, >> +.nway_reset = nb8800_nway_reset, >> +.get_link = ethtool_op_get_link, >> +}; >> + > > Since

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Eric Dumazet
On Tue, 2015-10-27 at 10:52 +, Alan Burlison wrote: > Unfortunately Hadoop isn't the only thing that pulls the shutdown() > trick, so I don't think there's a simple fix for this, as discussed > earlier in the thread. Having said that, if close() on Linux also did an > implicit shutdown()

Re: [PATCH net-next] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread roopa
u/bridge-set-is_local-and-is_static-before-fdb-entry-is-added-to-the-fdb-hashtable/20151027-120635 > config: i386-randconfig-x009-201543 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All errors (new ones pref

Re: [PATCH net-next V17 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-10-27 Thread Thomas F Herbert
On 10/26/15 8:14 AM, Albino B Neto wrote: 2015-10-25 22:11 GMT-02:00 Thomas F Herbert : Signed-off-by: Thomas F Herbert --- include/linux/if_vlan.h | 16 1 file changed, 16 insertions(+) diff --git

802.3 ad bonding mode min-links doesn't work correctly once slave port link status is up again

2015-10-27 Thread Arjun Pandey
Hi I have configured a bond with 2 slave bond ports in 802.3 ad mode. I have also set min-links=2 and miimon=100 root@foo bonding]# cat /proc/net/bonding/bond Ethernet Channel Bonding Driver: v3.7.1 (April 27, 2011) Bonding Mode: IEEE 802.3ad Dynamic link aggregation Transmit Hash Policy:

Re: [PATCH v7 3/3] geneve: add IPv6 bits to geneve_fill_metadata_dst

2015-10-27 Thread Sergei Shtylyov
Hello. On 10/27/2015 12:01 AM, John W. Linville wrote: Signed-off-by: John W. Linville --- v7 -- initial version (numbered to match earlier patches in series) drivers/net/geneve.c | 28 +--- 1 file changed, 21 insertions(+), 7 deletions(-)

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread Johannes Weiner
On Tue, Oct 27, 2015 at 01:26:47PM +0100, Michal Hocko wrote: > On Mon 26-10-15 12:56:19, Johannes Weiner wrote: > [...] > > Now you could argue that there might exist specialized workloads that > > need to account anonymous pages and page cache, but not socket memory > > buffers. > > Exactly,

Re: [PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one > of those warn about them once and handle them gracefully by recalculating > the checksum. > > Cc: Eric Dumazet

Re: [PATCH] vhost: fix performance on LE hosts

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 06:32:55AM -0700, David Miller wrote: > From: "Michael S. Tsirkin" > Date: Tue, 27 Oct 2015 11:37:39 +0200 > > > commit 2751c9882b947292fcfb084c4f604e01724af804 ("vhost: cross-endian > > support for legacy devices") introduced a minor regression: even

Re: [PATCH 0/8] mm: memcontrol: account socket memory in unified hierarchy

2015-10-27 Thread Johannes Weiner
On Tue, Oct 27, 2015 at 11:43:21AM +0300, Vladimir Davydov wrote: > On Mon, Oct 26, 2015 at 01:22:16PM -0400, Johannes Weiner wrote: > > I'm not getting rid of those knobs, I'm just reusing the old socket > > accounting infrastructure in an attempt to make the memory accounting > > feature useful

Re: [PATCH net v2 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
On Tue, Oct 27, 2015, at 17:04, Tom Herbert wrote: > On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa > wrote: > > We cannot reliable calculate packet size on MSG_MORE corked sockets > > and thus cannot decide if they are going to be fragmented later on, > > so

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread Johannes Weiner
On Tue, Oct 27, 2015 at 05:15:54PM +0100, Michal Hocko wrote: > On Tue 27-10-15 11:41:38, Johannes Weiner wrote: > > On Tue, Oct 27, 2015 at 01:26:47PM +0100, Michal Hocko wrote: > > > On Mon 26-10-15 12:56:19, Johannes Weiner wrote: > > > [...] > > > > Now you could argue that there might exist

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Alan Burlison
On 27/10/2015 14:39, David Miller wrote: You will never be able to assume it is available everywhere under Linux. Ever. This is the fundamental issue that you seem to completely not understand. If that was true in general then Linux would be dead and there would be no point ever adding any

[PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-27 Thread Neil Armstrong
Avoids: Unable to handle kernel NULL pointer dereference at virtual address 0064 Workqueue: events_power_efficient phy_state_machine PC is at phy_state_machine+0x28/0x480 Signed-off-by: Frode Isaksen Signed-off-by: Neil Armstrong ---

[PATCH 4/6] net: dsa: Add missing master netdev dev_put() calls

2015-10-27 Thread Neil Armstrong
Upon probe failure or unbinding, add missing dev_put() calls. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index acbf854..9240a46 100644 --- a/net/dsa/dsa.c +++

[PATCH net v2 2/4] ipv4: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Cc: Eric Dumazet Cc: Vlad Yasevich Cc: Benjamin Coddington Cc: Tom

[PATCH net v2 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
We cannot reliable calculate packet size on MSG_MORE corked sockets and thus cannot decide if they are going to be fragmented later on, so better not use CHECKSUM_PARTIAL in the first place. Cc: Eric Dumazet Cc: Vlad Yasevich Cc: Benjamin Coddington

[PATCH net v2 4/4] ipv6: add defensive check for CHECKSUM_PARTIAL skbs in ip_fragment

2015-10-27 Thread Hannes Frederic Sowa
CHECKSUM_PARTIAL skbs should never arrive in ip_fragment. If we get one of those warn about them once and handle them gracefully by recalculating the checksum. Fixes: commit 32dce968dd987 ("ipv6: Allow for partial checksums on non-ufo packets") See-also: commit 72e843bb09d45 ("ipv6:

[PATCH net v2 0/4] net: clean up interactions of CHECKSUM_PARTIAL and fragmentation

2015-10-27 Thread Hannes Frederic Sowa
This series fixes wrong checksums on the wire for IPv4 and IPv6. Large send buffers and especially NFS lead to wrong checksums in both IPv4 and IPv6. CHECKSUM_PARTIAL skbs should not receive the respective fragmentations functions, so we add WARN_ON_ONCE to those functions to fix up those as soon

[PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Hannes Frederic Sowa
We cannot reliable calculate packet size on MSG_MORE corked sockets and thus cannot decide if they are going to be fragmented later on, so better not use CHECKSUM_PARTIAL in the first place. The IPv6 code also intended to protect and not use CHECKSUM_PARTIAL in the existence of IPv6 extension

[Regression/Oops] nsc-ircc: 4.3.0rc6/rc7 No backlight on Thinkpad T60P

2015-10-27 Thread Simon Wood
Tried the latest kernel and have the issue where the LCD backlight does not light (ie dark screen) after the kernel has booted. It appears that there is a 'oops' with the nsc-ircc driver, and I assume that this is the root of the problem. 4.3.0rc6 and rc7 are bad, rc2 seems OK. -- Oct 23

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Florian Fainelli
On 27/10/15 07:48, Neil Armstrong wrote: > Some switch drivers might request interrupts, remap register ranges, > allow such drivers to implement a "remove" callback doing just that. > > Suggested-by: Florian Fainelli This should probably be a Signed-off-by tag, but there

Re: [PATCH net v2 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 9:34 AM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 17:04, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa >> wrote: >> > We cannot reliable calculate packet size on MSG_MORE

[PATCH net-next v3] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread Roopa Prabhu
From: Roopa Prabhu Problem Description: We can add fdbs pointing to the bridge with NULL ->dst but that has a few race conditions because br_fdb_insert() is used which first creates the fdb and then, after the fdb has been published/linked, sets "is_local" to 1 and in

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Neil Armstrong
Hi, On 10/27/2015 04:39 PM, Florian Fainelli wrote: > On 27/10/15 07:48, Neil Armstrong wrote: >> Some switch drivers might request interrupts, remap register ranges, >> allow such drivers to implement a "remove" callback doing just that. >> >> Suggested-by: Florian Fainelli

Re: [PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-27 Thread Florian Fainelli
(don't top post please) On 27/10/15 08:53, Frode Isaksen wrote: > What will you need in the oops ? I presume you don' want everything or ? > > The PHY state machine is not stopped with a PHY disconnect. It is stopped with a phy_disconnect(): /** * phy_disconnect - disable interrupts, stop

Re: [PATCH net v2 1/4] ipv4: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > We cannot reliable calculate packet size on MSG_MORE corked sockets > and thus cannot decide if they are going to be fragmented later on, > so better not use CHECKSUM_PARTIAL in the first place. > MSG_MORE

[PATCH] xfrm: dst_entries_init() per-net dst_ops

2015-10-27 Thread dan . streetman
From: Dan Streetman The ipv4 and ipv6 xfrms each create a template dst_ops object, and perform dst_entries_init() on the template objects. Then each net namespace has its net.xfrm.xfrm[46]_dst_ops field set to the template values. The problem with that is the

Re: [PATCH 5/8] mm: memcontrol: account socket memory on unified hierarchy

2015-10-27 Thread Michal Hocko
On Tue 27-10-15 11:41:38, Johannes Weiner wrote: > On Tue, Oct 27, 2015 at 01:26:47PM +0100, Michal Hocko wrote: > > On Mon 26-10-15 12:56:19, Johannes Weiner wrote: > > [...] > > > Now you could argue that there might exist specialized workloads that > > > need to account anonymous pages and page

Stable-4.2 inclusion request for e1000e fix

2015-10-27 Thread Stefan Bader
This was attempted to get into 4.2 before release but did not seem to be successful[1]. But was now reported to us and verified[2] that adding this prevents issues when the NIC is not connected. Could the patch below be added to the stable queue for 4.2. Thanks. -Stefan [1]

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread David Miller
From: Alan Burlison Date: Tue, 27 Oct 2015 14:39:56 + > On 27/10/2015 14:39, David Miller wrote: > >> Making this worse is that there isn't going to be a straightforward >> nor reliable way to test for the presence of this at run time. > > I attached a test case

Re: [Bug 106241] New: shutdown(3)/close(3) behaviour is incorrect for sockets in accept(3)

2015-10-27 Thread Alan Burlison
On 27/10/2015 15:04, David Miller wrote: I said "run time". Like when your final code runs on a target system. Not at build tree configure time. Yes, you could do it then as well. -- Alan Burlison -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

[PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Neil Armstrong
Some switch drivers might request interrupts, remap register ranges, allow such drivers to implement a "remove" callback doing just that. Suggested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- include/net/dsa.h | 1 + net/dsa/dsa.c |

[PATCH 0/6] Further fix for dsa unbinding

2015-10-27 Thread Neil Armstrong
This serie fixes further issues for DSA dynamic unbinding. Frode Isaksen's patches make usage of delayed work and fixes kernel crashes when dsa is unbind. The other patches are simple fixes to permit cleanup and avoid netdev related crashes. Frode Isaksen (3): net: dsa: Use delayed work instead

[PATCH 1/6] net: dsa: Use delayed work instead of timer+work for polling

2015-10-27 Thread Neil Armstrong
Simplifies the code and avoids a crash when removing the module: dsa dsa ethmv2 (unregistering): Link is Down device eth1 left promiscuous mode Unable to handle kernel paging request at virtual address bacc5cf6 ... (run_timer_softirq) from [] (__do_softirq+0xcc/0x320) (__do_softirq) from []

[PATCH 3/6] net: dsa: cleanup resources upon module removal

2015-10-27 Thread Neil Armstrong
Make sure that we unassign the master_netdev dsa_ptr to make the packet processing go through the regular Ethernet receive path. Suggested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 8 1 file changed, 8

[PATCH net 2/2] net/mlx4: Copy/set only sizeof struct mlx4_eqe bytes

2015-10-27 Thread Or Gerlitz
From: Carol L Soto When doing memcpy/memset of EQEs, we should use sizeof struct mlx4_eqe as the base size and not caps.eqe_size which could be bigger. If caps.eqe_size is bigger than the struct mlx4_eqe then we corrupt data in the master context. When using a 64

[PATCH net 0/2] Mellanox mlx4 driver fixes for 4.3-rc7

2015-10-27 Thread Or Gerlitz
Hi Dave, Jack's fix is for a regression introduced in 4.3-rc1 Carol's fix addresses an issue which exists for while and turns to beat us hard on PPC, please queue for -stable. Or. Carol L Soto (1): net/mlx4: Copy/set only sizeof struct mlx4_eqe bytes Jack Morgenstein (1): net/mlx4_en:

[PATCH net 1/2] net/mlx4_en: Explicitly set no vlan tags in WQE ctrl segment when no vlan is present

2015-10-27 Thread Or Gerlitz
From: Jack Morgenstein We do not set the ins_vlan field to zero when no vlan id is present in the packet. Since WQEs in the TX ring are not zeroed out between uses, this oversight could result in having vlan flags present in the WQE ctrl segment when no vlan is

[PATCH 5/6] net: dsa: Do not reschedule polling if driver removed

2015-10-27 Thread Neil Armstrong
Do not reschedule the delayed work used for polling when the driver is removed, by testing the 'poll_link_needed' flag. Avoids this crash: dsa dsa ethmv2 (unregistering): Link is Down device eth1 left promiscuous mode Unable to handle kernel paging request at virtual address bacc5cf6 ...

Re: [PATCH net-next v2] bridge: set is_local and is_static before fdb entry is added to the fdb hashtable

2015-10-27 Thread roopa
On 10/27/15, 7:02 AM, David Miller wrote: > From: Nikolay Aleksandrov > Date: Tue, 27 Oct 2015 14:31:48 +0100 > >> On 10/27/2015 01:12 PM, Roopa Prabhu wrote: >>> From: Roopa Prabhu >>> >>> Problem Description: >>> We can add fdbs pointing

Re: [PATCH 6/6] net: phy: Stop 'phy-state-machine' and 'phy_change' work on remove

2015-10-27 Thread Florian Fainelli
On 27/10/15 07:49, Neil Armstrong wrote: > Avoids: > Unable to handle kernel NULL pointer dereference at virtual address 0064 > Workqueue: events_power_efficient phy_state_machine > PC is at phy_state_machine+0x28/0x480 Stripped down oops can sometimes be missing critical pieces of

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 8:02 AM, Hannes Frederic Sowa wrote: > We cannot reliable calculate packet size on MSG_MORE corked sockets > and thus cannot decide if they are going to be fragmented later on, > so better not use CHECKSUM_PARTIAL in the first place. > > The

[RFC PATCH 0/3] net: dsa: cleanup dsa driver

2015-10-27 Thread Neil Armstrong
With the previously introduced remove callback for DSA driver in : http://marc.info/?i=562F8ED7.2000804%40baylibre.com Add remove callback for bcm_sf2 and mv88e6xxx drivers. This patch was not tested due of a lack of hardware. Neil Armstrong (3): net: dsa: bcm_sf2: cleanup resources in remove

Re: [PATCH net-next V18 3/3] 802.1AD: Flow handling, actions, vlan parsing and netlink attributes

2015-10-27 Thread Thomas F Herbert
On 10/26/15 10:10 PM, Pravin Shelar wrote: Thanks for the review. On Sun, Oct 25, 2015 at 5:11 PM, Thomas F Herbert wrote: Add support for 802.1ad including the ability to push and pop double tagged vlans. Add support for 802.1ad to netlink parsing and flow

[PATCH net-next] enic: assign affinity hint to interrupts

2015-10-27 Thread Govindarajulu Varadarajan
The affinity hint is used by the user space daemon, irqbalancer, to indicate a preferred CPU mask for irqs. This patch sets the irq affinity hint to local numa core first, when exhausted we try non-local numa cores. Introduce enic module global variable enic_numa_count[] to store the number of

RE: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc for certain function calls

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Nicholas Krause Sent: Friday, October 9, 2015 8:53 AM To: Kirsher, Jeffrey T Cc: linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org;

[PATCHv2 1/2] pci_ids: add Netronome Systems vendor

2015-10-27 Thread Jakub Kicinski
Add PCI vendor id for Netronome Systems. Signed-off-by: Jakub Kicinski Signed-off-by: Rolf Neugebauer --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h

[PATCHv2 0/2] Netronome NFP4000/NFP6000 NIC VF driver

2015-10-27 Thread Jakub Kicinski
This patchset adds support for VFs of Netronome's NFP-4000 and NFP-6000 based NICs. We are currently also preparing the submission for the PF driver, but it is not quite ready yet. The PF driver can be found on GitHub: https://github.com/Netronome/nfp-drv-kmods changes since v1: - reorganize

Re: [PATCH net v2 3/4] ipv6: no CHECKSUM_PARTIAL on MSG_MORE corked sockets

2015-10-27 Thread Tom Herbert
On Tue, Oct 27, 2015 at 11:29 AM, Hannes Frederic Sowa wrote: > On Tue, Oct 27, 2015, at 18:32, Tom Herbert wrote: >> On Tue, Oct 27, 2015 at 9:44 AM, Hannes Frederic Sowa >> wrote: >> > >> > >> > On Tue, Oct 27, 2015, at 17:36, Tom Herbert

Re: [PATCH 2/6] net: dsa: allow switch drivers to cleanup their resources

2015-10-27 Thread Vivien Didelot
On Oct. Tuesday 27 (44) 04:43 PM, Neil Armstrong wrote: > Hi, > On 10/27/2015 04:39 PM, Florian Fainelli wrote: > > On 27/10/15 07:48, Neil Armstrong wrote: > >> Some switch drivers might request interrupts, remap register ranges, > >> allow such drivers to implement a "remove" callback doing just

RE: [Intel-wired-lan] [net PATCH 2/3] fm10k: Fix handling of napi budget when multiple queues are enabled per vector

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Alexander Duyck Sent: Tuesday, September 22, 2015 2:36 PM To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org Subject: [Intel-wired-lan] [net PATCH 2/3] fm10k: Fix handling

Re: [RFC PATCH 1/3] net: dsa: bcm_sf2: cleanup resources in remove callback

2015-10-27 Thread kbuild test robot
Hi Neil, [auto build test ERROR on net/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base] url: https://github.com/0day-ci/linux/commits/Neil-Armstrong/net-dsa-cleanup-dsa-driver/20151028-003842 config: x86_64-allmodconfig (attached as .config)

RE: [Intel-wired-lan] [PATCH] fm10k:Fix error handling in the function fm10k_setup_tc

2015-10-27 Thread Singh, Krishneil K
-Original Message- From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On Behalf Of Nicholas Krause Sent: Tuesday, October 20, 2015 2:05 PM To: Kirsher, Jeffrey T Cc: linux-ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org;

  1   2   3   >