RE: [PATCH -v2] drivers: net: ethernet: intel: e1000e: fix ethtool autoneg off for non-copper

2016-04-08 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Daniel Walker > Sent: Tuesday, April 5, 2016 11:30 AM > To: Ruinskiy, Dima ; Kirsher, Jeffrey T > ; Brandeburg, Jesse > ;

Re: [RFC PATCH 07/11] GENEVE: Add option to mangle IP IDs on inner headers when using TSO

2016-04-08 Thread Jesse Gross
On Thu, Apr 7, 2016 at 8:52 PM, Alexander Duyck wrote: > Just a thought. What if I replaced NETIF_F_TSO_FIXEDID with something > that meant we could mange the IP ID like a NETIF_F_TSO_IPID_MANGLE > (advice for better name welcome). Instead of the feature flag meaning

Re: [net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Jesse Gross
On Fri, Apr 8, 2016 at 5:33 PM, Alexander Duyck wrote: > This patch adds support for TSO using IPv4 headers with a fixed IP ID > field. This is meant to allow us to do a lossless GRO in the case of TCP > flows that use a fixed IP ID such as those that convert IPv6 header to

[PATCH RFT 1/2] phylib: add device reset GPIO support

2016-04-08 Thread Sergei Shtylyov
The PHY devices sometimes do have their reset signal (maybe even power supply?) tied to some GPIO and sometimes it also does happen that a boot loader does not leave it deasserted. So far this issue has been attacked from (as I believe) a wrong angle: by teaching the MAC driver to manipulate the

Re: [net-next PATCH 2/5] GSO: Add GSO type for fixed IPv4 ID

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 2:41 PM, Jesse Gross wrote: > On Fri, Apr 8, 2016 at 5:33 PM, Alexander Duyck wrote: >> This patch adds support for TSO using IPv4 headers with a fixed IP ID >> field. This is meant to allow us to do a lossless GRO in the case of TCP

[PATCH RFT 2/2] macb: kill PHY reset code

2016-04-08 Thread Sergei Shtylyov
With the 'phylib' now being aware of the "reset-gpios" PHY node property, there should be no need to frob the PHY reset in this driver anymore... Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/cadence/macb.c | 17 -

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Timur Tabi
Bjorn Andersson wrote: It sounds like you're trying to say that the pins used can be are muxed as GPIO or MDIO, in the TLMM. I'm not 100% sure, but I think that's correct. If you don't want to have normal networking, you could connect those external pins to some GPIO device (like an LED or

Re: [PATCH v4] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Julian Anastasov
Hello, On Fri, 8 Apr 2016, Chris Friesen wrote: > For local routes that require a particular output interface we do not want > to cache the result. Caching the result causes incorrect behaviour when > there are multiple source addresses on the interface. The end result > being that if

[PATCH iproute2 -master 3/3] tc, bpf: add support for map pre/allocation

2016-04-08 Thread Daniel Borkmann
Follow-up to kernel commit 6c9059817432 ("bpf: pre-allocate hash map elements"). Add flags support, so that we can pass in BPF_F_NO_PREALLOC flag for disallowing preallocation. Update examples accordingly and also remove the BPF_* map helper macros from them as they were not very useful.

[PATCH iproute2 -master 1/3] tc, bpf: add new csum and tunnel signatures

2016-04-08 Thread Daniel Borkmann
Add new signatures for BPF_FUNC_csum_diff, BPF_FUNC_skb_get_tunnel_opt and BPF_FUNC_skb_set_tunnel_opt. Signed-off-by: Daniel Borkmann --- include/bpf_api.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/bpf_api.h b/include/bpf_api.h index

[PATCH iproute2 -master 2/3] tc, bpf: further improve error reporting

2016-04-08 Thread Daniel Borkmann
Make it easier to spot issues when loading the object file fails. This includes reporting in what pinned object specs differ, better indication when we've reached instruction limits. Don't retry to load a non relo program once we failed with bpf(2), and report out of bounds tail call key. Also,

[PATCH iproute2 -master 0/3] Minor tc/bpf updates

2016-04-08 Thread Daniel Borkmann
Some minor updates to improve error reporting, add signatures and recently introduced map flags attribute. Set is against master branch. Thanks! Daniel Borkmann (3): tc, bpf: add new csum and tunnel signatures tc, bpf: further improve error reporting tc, bpf: add support for map

[net-next][PATCH 1/2] RDS: fix endianness for dp_ack_seq

2016-04-08 Thread Santosh Shilimkar
From: Qing Huang dp->dp_ack_seq is used in big endian format. We need to do the big endianness conversion when we assign a value in host format to it. Signed-off-by: Qing Huang Signed-off-by: Santosh Shilimkar ---

[net-next][PATCH 2/2] RDS: Fix the atomicity for congestion map update

2016-04-08 Thread Santosh Shilimkar
Two different threads with different rds sockets may be in rds_recv_rcvbuf_delta() via receive path. If their ports both map to the same word in the congestion map, then using non-atomic ops to update it could cause the map to be incorrect. Lets use atomics to avoid such an issue. Full credit to

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: > From: Petri Gynther > Date: Tue, 5 Apr 2016 17:50:01 -0700 > >> Add Byte Queue Limits (BQL) support to bcmgenet driver. >> >> Signed-off-by: Petri Gynther > > As Eric Dumazet

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Alexander Duyck
On Fri, Apr 8, 2016 at 6:56 PM, Eric Dumazet wrote: > On Fri, 2016-04-08 at 18:39 -0700, Petri Gynther wrote: >> On Fri, Apr 8, 2016 at 1:36 PM, David Miller wrote: >> > From: Petri Gynther >> > Date: Tue, 5 Apr 2016 17:50:01

[PATCH RFT 0/2] Teach phylib hard-resetting devices

2016-04-08 Thread Sergei Shtylyov
Hello. Here's the set of 2 patches against DaveM's 'net-next.git' repo. They add to 'phylib' support for resetting devices via GPIO and do some clean up after doing that... [1/2] phylib: add device reset GPIO support [2/2] macb: kill PHY reset code MBR, Sergei

Re: How do I avoid recvmsg races with IP_RECVERR?

2016-04-08 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 5:33 PM, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: >> On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa >> wrote: >> >> My proposal would be to make the error conversion

Re: [PATCH net-next 1/8] perf: optimize perf_fetch_caller_regs

2016-04-08 Thread Steven Rostedt
On Tue, 5 Apr 2016 14:06:26 +0200 Peter Zijlstra wrote: > On Mon, Apr 04, 2016 at 09:52:47PM -0700, Alexei Starovoitov wrote: > > avoid memset in perf_fetch_caller_regs, since it's the critical path of all > > tracepoints. > > It's called from perf_sw_event_sched,

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

2016-04-08 Thread Bjorn Andersson
On Fri, Apr 8, 2016 at 12:06 PM, Timur Tabi wrote: > Andrew Lunn wrote: > >> There are two different things here. One is configuring the pin to be >> a GPIO. The second is using the GPIO as a GPIO. In this case, >> bit-banging the MDIO bus. >> >> The firmware could be doing

Re: [PATCH net-next v2] vxlan: synchronously and race-free destruction of vxlan sockets

2016-04-08 Thread Hannes Frederic Sowa
On Sat, Apr 9, 2016, at 01:24, Cong Wang wrote: > On Fri, Apr 8, 2016 at 1:55 PM, Hannes Frederic Sowa > wrote: > > Due to the fact that the udp socket is destructed asynchronously in a > > work queue, we have some nondeterministic behavior during shutdown of > >

[PATCH V3 4/8] net: mediatek: fix stop and wakeup of queue

2016-04-08 Thread John Crispin
The driver supports 2 MACs. Both run on the same DMA ring. If we go above/below the TX rings threshold value, we always need to wake/stop the queue of both devices. Not doing to can cause TX stalls and packet drops on one of the devices. Signed-off-by: John Crispin ---

[PATCH V3 0/8] net: mediatek: make the driver pass stress tests

2016-04-08 Thread John Crispin
While testing the driver we managed to get the TX path to stall and fail to recover. When dual MAC support was added to the driver, the whole queue stop/wake code was not properly adapted. There was also a regression in the locking of the xmit function. The fact that watchdog_timeo was not set and

[PATCH V3 8/8] net: mediatek: do not set the QID field in the TX DMA descriptors

2016-04-08 Thread John Crispin
The QID field gets set to the mac id. This made the DMA linked list queue the traffic of each MAC on a different internal queue. However during long term testing we found that this will cause traffic stalls as the multi queue setup requires a more complete initialisation which is not part of the

[PATCH V3 1/8] net: mediatek: watchdog_timeo was not set

2016-04-08 Thread John Crispin
The original commit failed to set watchdog_timeo. This patch sets watchdog_timeo to HZ. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c

[PATCH net-next] sock: tigthen lockdep checks for sock_owned_by_user

2016-04-08 Thread Hannes Frederic Sowa
sock_owned_by_user should not be used without socket lock held. It seems to be a common practice to check .owned before lock reclassification, so provide a little help to abstract this check away. Cc: linux-c...@vger.kernel.org Cc: linux-blueto...@vger.kernel.org Cc: linux-...@vger.kernel.org

[PATCH] iproute2: tc_bpf.c: fix building with musl libc

2016-04-08 Thread Gustavo Zacarias
We need limits.h for PATH_MAX, fixes: tc_bpf.c: In function ‘bpf_map_selfcheck_pinned’: tc_bpf.c:222:12: error: ‘PATH_MAX’ undeclared (first use in this function) char file[PATH_MAX], buff[4096]; Signed-off-by: Gustavo Zacarias --- tc/tc_bpf.c | 1 + 1 file changed,

Re: [PATCH] iproute2: tc_bpf.c: fix building with musl libc

2016-04-08 Thread Daniel Borkmann
On 04/08/2016 02:59 PM, Gustavo Zacarias wrote: We need limits.h for PATH_MAX, fixes: tc_bpf.c: In function ‘bpf_map_selfcheck_pinned’: tc_bpf.c:222:12: error: ‘PATH_MAX’ undeclared (first use in this function) char file[PATH_MAX], buff[4096]; Signed-off-by: Gustavo Zacarias

Re: [RFC PATCH v2 4/5] mlx4: add support for fast rx drop bpf program

2016-04-08 Thread Jesper Dangaard Brouer
On Thu, 7 Apr 2016 21:48:49 -0700 Brenden Blanco wrote: > +int mlx4_call_bpf(struct bpf_prog *prog, void *data, unsigned int length) > +{ > + struct sk_buff *skb = this_cpu_ptr(_bpf_phys_dev_md); > + int ret; > + > + build_bpf_phys_dev_md(skb, data, length); >

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Jesper Dangaard Brouer
On Fri, 8 Apr 2016 12:36:14 +0200 Jesper Dangaard Brouer wrote: > > +/* user return codes for PHYS_DEV prog type */ > > +enum bpf_phys_dev_action { > > + BPF_PHYS_DEV_DROP, > > + BPF_PHYS_DEV_OK, > > +}; > > I can imagine these extra return codes: > >

Please get back to me.

2016-04-08 Thread Nawal
Hi, my name is Nawal denison, i need your assistance to move my family out of Egypt to your country due to the conflict and killings going on here . I have $3. million dollars. which i will use to Establish A viable joint company with you for your help, attach is my pic and my daughter Thank

[PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Daniel Borkmann
The original tokenized iid support implemented via f53adae4eae5 ("net: ipv6: add tokenized interface identifier support") didn't allow for clearing a device token as it was intended that this addressing mode was the only one active for globally scoped IPv6 addresses. Later we relaxed that

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Hannes Frederic Sowa
On 08.04.2016 15:55, Daniel Borkmann wrote: The original tokenized iid support implemented via f53adae4eae5 ("net: ipv6: add tokenized interface identifier support") didn't allow for clearing a device token as it was intended that this addressing mode was the only one active for globally scoped

Re: [PATCH] ipv6: rework the lock in addrconf_permanent_addr

2016-04-08 Thread Sergei Shtylyov
Hello. On 4/8/2016 12:22 PM, roy.qing...@gmail.com wrote: From: Li RongQing 1. nothing of idev is changed, so read lock is enough 2. ifp is changed, so used ifp->lock or cmpxchg to protect it Signed-off-by: Li RongQing --- net/ipv6/addrconf.c

[PATCH V3 7/8] net: mediatek: move the pending_work struct to the device generic struct

2016-04-08 Thread John Crispin
The worker always touches both netdevs. It is ethernet core and not MAC specific. We only need one worker, which belongs into the ethernets core struct. Signed-off-by: John Crispin --- Changes in V3 * make the patch bisectable drivers/net/ethernet/mediatek/mtk_eth_soc.c |

[PATCH V3 5/8] net: mediatek: fix TX locking

2016-04-08 Thread John Crispin
Inside the TX path there is a lock inside the tx_map function. This is however too late. The patch moves the lock to the start of the xmit function right before the free count check of the DMA ring happens. If we do not do this, the code becomes racy leading to TX stalls and dropped packets. This

[PATCH V3 3/8] net: mediatek: remove superfluous reset call

2016-04-08 Thread John Crispin
HW reset is triggered in the mtk_hw_init() function. There is no need to also reset the core during probe. Signed-off-by: John Crispin --- drivers/net/ethernet/mediatek/mtk_eth_soc.c |4 1 file changed, 4 deletions(-) diff --git

[PATCH] ipv6: rework the lock in addrconf_permanent_addr

2016-04-08 Thread roy . qing . li
From: Li RongQing 1. nothing of idev is changed, so read lock is enough 2. ifp is changed, so used ifp->lock or cmpxchg to protect it Signed-off-by: Li RongQing --- net/ipv6/addrconf.c | 26 -- 1 file changed, 20

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Daniel Borkmann
On 04/08/2016 12:36 PM, Jesper Dangaard Brouer wrote: On Thu, 7 Apr 2016 21:48:46 -0700 Brenden Blanco wrote: Add a new bpf prog type that is intended to run in early stages of the packet rx path. Only minimal packet metadata will be available, hence a new context type,

Re: [PATCH net] tuntap: restore default qdisc

2016-04-08 Thread Phil Sutter
On Fri, Apr 08, 2016 at 01:26:48PM +0800, Jason Wang wrote: > After commit f84bb1eac027 ("net: fix IFF_NO_QUEUE for drivers using > alloc_netdev"), default qdisc was changed to noqueue because > tuntap does not set tx_queue_len during .setup(). This patch restores > default qdisc by setting

[PATCH net-next] net: ethernet: stmmac: GMAC4.xx: Fix TX descriptor preparation

2016-04-08 Thread Alexandre TORGUE
On GMAC4.xx each descriptor contains 2 buffers of 16KB (each). Initially, those 2 buffers was filled in dwmac4_rd_prepare_tx_desc but it is actually not needed. Indeed, stmmac driver supports frame up to 9000 bytes (jumbo). So only one buffer is needed. Reported-by: Dan Carpenter

[PATCH RESEND] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

2016-04-08 Thread Wolfram Sang
From: Wolfram Sang The clk API may return 0 on clk_get_rate, so we should check the result before using it as a divisor. Signed-off-by: Wolfram Sang Acked-by: Sergei Shtylyov --- The

[PATCH V3 2/8] net: mediatek: mtk_cal_txd_req() returns bad value

2016-04-08 Thread John Crispin
The code used to also support the PDMA engine, which had 2 packet pointers per descriptor. Because of this we had to divide the result by 2 and round it up. This is no longer needed as the code only supports QDMA. Signed-off-by: John Crispin ---

[PATCH V3 6/8] net: mediatek: fix mtk_pending_work

2016-04-08 Thread John Crispin
The driver supports 2 MACs. Both run on the same DMA ring. If we hit a TX timeout we need to stop both netdevs before restarting them again. If we don't do this, mtk_stop() wont shutdown DMA and the consecutive call to mtk_open() wont restart DMA and enable IRQs. Signed-off-by: John Crispin

Re: [RFC PATCH v2 2/5] net: add ndo to set bpf prog in adapter rx

2016-04-08 Thread Jesper Dangaard Brouer
On Thu, 7 Apr 2016 21:48:47 -0700 Brenden Blanco wrote: > Add two new set/get netdev ops for drivers implementing the > BPF_PROG_TYPE_PHYS_DEV filter. > > Signed-off-by: Brenden Blanco [...] > > diff --git a/include/linux/netdevice.h

Re: [PATCH ethtool] ethtool.c: fix memory leaks

2016-04-08 Thread Ivan Vecera
On 18.3.2016 13:24, Ivan Vecera wrote: Memory allocated at several places is not appropriately freed. Signed-off-by: Ivan Vecera Ben, ping. I. --- ethtool.c | 60 +--- 1 file changed, 45 insertions(+), 15

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Jesper Dangaard Brouer
On Thu, 7 Apr 2016 21:48:46 -0700 Brenden Blanco wrote: > Add a new bpf prog type that is intended to run in early stages of the > packet rx path. Only minimal packet metadata will be available, hence a > new context type, struct bpf_phys_dev_md, is exposed to userspace.

[PATCH net-next v3] packet: uses kfree_skb() for errors.

2016-04-08 Thread Weongyo Jeong
consume_skb() isn't for error cases that kfree_skb() is more proper one. At this patch, it fixed tpacket_rcv() and packet_rcv() to be consistent for error or non-error cases letting perf trace its event properly. Signed-off-by: Weongyo Jeong --- net/packet/af_packet.c

Re: [PATCH v2] packet: uses kfree_skb() for drops or errors.

2016-04-08 Thread Weongyo Jeong
On Thu, Apr 07, 2016 at 12:06:12PM -0400, Willem de Bruijn wrote: > On Wed, Apr 6, 2016 at 5:14 PM, Weongyo Jeong wrote: > > consume_skb() isn't for drop or error cases > > for drop or error -> for error > > > that kfree_skb() is more proper > > one. At this patch, it

Re: [patch net-next 0/5] mlxsw: small driver update

2016-04-08 Thread Jiri Pirko
Fri, Apr 08, 2016 at 07:07:37PM CEST, da...@davemloft.net wrote: >From: Jiri Pirko >Date: Fri, 8 Apr 2016 17:51:55 +0200 > >> Fri, Apr 08, 2016 at 05:45:20PM CEST, j...@resnulli.us wrote: >>>From: Jiri Pirko >>> >>>Cosmetics, in preparation to sharedbuffer

[patch net-next 2/6] mlxsw: Move devlink port registration into common core code

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Remove devlink port reg/unreg from spectrum and switchx2 code and rather do the common work in core. That also ensures code separation where devlink is only used in core.c. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel

Re: [patch net-next 0/5] mlxsw: small driver update

2016-04-08 Thread David Miller
From: Jiri Pirko Date: Fri, 8 Apr 2016 17:51:55 +0200 > Fri, Apr 08, 2016 at 05:45:20PM CEST, j...@resnulli.us wrote: >>From: Jiri Pirko >> >>Cosmetics, in preparation to sharedbuffer patchset. > > Dave, I just realized there is dependency on: > "devlink:

Re: [PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
Due to mail server malfunction, this patch was sent twice. Please ignore this duplicate. Thanks, David Daney On 03/31/2016 06:01 PM, David Daney wrote: From: David Daney commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER

Re: [net-next,2/2] rxrpc: do not pull udp headers on receive

2016-04-08 Thread Thierry Reding
On Thu, Apr 07, 2016 at 11:44:59AM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Commit e6afc8ace6dd modified the udp receive path by pulling the udp > header before queuing an skbuff onto the receive queue. > > Rxrpc also calls skb_recv_datagram to dequeue an

Re: [PATCH net] tuntap: restore default qdisc

2016-04-08 Thread Michael S. Tsirkin
On Fri, Apr 08, 2016 at 01:26:48PM +0800, Jason Wang wrote: > After commit f84bb1eac027 ("net: fix IFF_NO_QUEUE for drivers using > alloc_netdev"), default qdisc was changed to noqueue because > tuntap does not set tx_queue_len during .setup(). This patch restores > default qdisc by setting

Re: [net-next,1/2] sunrpc: do not pull udp headers on receive

2016-04-08 Thread Thierry Reding
ed-off-by: Willem de Bruijn <will...@google.com> > --- > net/sunrpc/socklib.c | 2 +- > net/sunrpc/svcsock.c | 5 ++--- > net/sunrpc/xprtsock.c | 5 ++--- > 3 files changed, 5 insertions(+), 7 deletions(-) Applying this and patch 2/2 (along with a couple of unrelated regulat

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-08 Thread Yang Yingliang
On 2016/4/7 22:51, Eric Dumazet wrote: On Thu, 2016-04-07 at 03:21 -0700, Eric Dumazet wrote: Please do not send patches before really understanding the issue you have. Having a backlog of 12506206 bytes is ridiculous. Dropping packets is absolutely fine if this ever happens. Something is

[PATCHv3 net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm

2016-04-08 Thread Xin Long
There are some repetitive codes in forward_delay_store, we can remove them by calling store_bridge_parm. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git

[PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
From: David Daney commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, so the extra call

[PATCH] net: thunderx: Fix broken of_node_put() code.

2016-04-08 Thread David Daney
From: David Daney commit b7d3e3d3d21a ("net: thunderx: Don't leak phy device references on -EPROBE_DEFER condition.") incorrectly moved the call to of_node_put() outside of the loop. Under normal loop exit, the node has already had of_node_put() called, so the extra call

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Brenden Blanco
On Fri, Apr 08, 2016 at 01:09:30PM +0200, Daniel Borkmann wrote: > On 04/08/2016 12:36 PM, Jesper Dangaard Brouer wrote: > >On Thu, 7 Apr 2016 21:48:46 -0700 > >Brenden Blanco wrote: > > > >>Add a new bpf prog type that is intended to run in early stages of the > >>packet

Re: [PATCH net-next] net: bcmgenet: add BQL support

2016-04-08 Thread Petri Gynther
On Wed, Apr 6, 2016 at 1:25 PM, Florian Fainelli wrote: > > 2016-04-05 17:50 GMT-07:00 Petri Gynther : > > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > > > Signed-off-by: Petri Gynther > > Signed-off-by: Florian

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-08 Thread David Miller
From: Eric Dumazet Date: Fri, 08 Apr 2016 07:44:25 -0700 > On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote: > >> I expand tcp_adv_win_scale and tcp_rmem. It has no effect. > > Try : > > echo -2 >/proc/sys/net/ipv4/tcp_adv_win_scale > > And restart your flows.

[PATCHv3 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if

2016-04-08 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink

[PATCHv3 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm

2016-04-08 Thread Xin Long
There are some repetitive codes in flush_store, we can remove them by calling store_bridge_parm, also, it would send rtnl notification after we add it in store_bridge_parm in the following patches. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 14 +++--- 1

[PATCHv3 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl

2016-04-08 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink

[PATCHv3 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm

2016-04-08 Thread Xin Long
There are some repetitive codes in stp_state_store, we can remove them by calling store_bridge_parm. Signed-off-by: Xin Long --- net/bridge/br_sysfs_br.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/net/bridge/br_sysfs_br.c

Re: [Lsf] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-08 Thread Alexander Duyck
On Thu, Apr 7, 2016 at 1:38 PM, Jesper Dangaard Brouer wrote: > On Thu, 7 Apr 2016 19:48:50 + > "Waskiewicz, PJ" wrote: > >> On Thu, 2016-04-07 at 16:17 +0200, Jesper Dangaard Brouer wrote: >> > (Topic proposal for MM-summit) >> > >> > Network

[PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl

2016-04-08 Thread Xin Long
This patchset is used to support sending rntl info to user in some places, and ensure that whenever those attributes change internally or from sysfs, that a netlink notification is sent out to listeners. It also make some adjustment in bridge sysfs so that we can implement this easily. I've done

[PATCHv3 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br

2016-04-08 Thread Xin Long
Now when we change the attributes of bridge or br_port by netlink, a relevant netlink notification will be sent, but if we change them by ioctl or sysfs, no notification will be sent. We should ensure that whenever those attributes change internally or from sysfs/ioctl, that a netlink

Re: [net-next 00/18][pull request] 10GbE Intel Wired LAN Driver Updates 2016-04-07

2016-04-08 Thread David Miller
From: Jeff Kirsher Date: Thu, 7 Apr 2016 20:20:55 -0700 > This series contains updates to ixgbe and ixgbevf. Pulled, thanks Jeff.

Re: [PATCH net] mpls: find_outdev: check for err ptr in addition to NULL check

2016-04-08 Thread David Miller
From: Roopa Prabhu Date: Thu, 7 Apr 2016 21:28:38 -0700 > From: Roopa Prabhu > > find_outdev calls inet{,6}_fib_lookup_dev() or dev_get_by_index() to > find the output device. In case of an error, inet{,6}_fib_lookup_dev() > returns error

Re: [RFC PATCH v2 1/5] bpf: add PHYS_DEV prog type for early driver filter

2016-04-08 Thread Brenden Blanco
On Fri, Apr 08, 2016 at 02:33:40PM +0200, Jesper Dangaard Brouer wrote: > > On Fri, 8 Apr 2016 12:36:14 +0200 Jesper Dangaard Brouer > wrote: > > > > +/* user return codes for PHYS_DEV prog type */ > > > +enum bpf_phys_dev_action { > > > + BPF_PHYS_DEV_DROP, > > > +

Re: [RFC PATCH v2 4/5] mlx4: add support for fast rx drop bpf program

2016-04-08 Thread Brenden Blanco
On Fri, Apr 08, 2016 at 01:41:58PM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 7 Apr 2016 21:48:49 -0700 Brenden Blanco > wrote: > > > +int mlx4_call_bpf(struct bpf_prog *prog, void *data, unsigned int length) > > +{ > > + struct sk_buff *skb =

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 12:53 -0400, David Miller wrote: > From: Eric Dumazet > Date: Fri, 08 Apr 2016 07:44:25 -0700 > > > On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote: > > > >> I expand tcp_adv_win_scale and tcp_rmem. It has no effect. > > > > Try : > > > >

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Daniel Borkmann
On 04/08/2016 05:36 PM, Hannes Frederic Sowa wrote: On 08.04.2016 17:25, Bjørn Mork wrote: Hannes Frederic Sowa writes: On Fri, Apr 8, 2016, at 16:18, Bjørn Mork wrote: Daniel Borkmann writes: if (!token) return -EINVAL; -

[patch net-next] devlink: share user_ptr pointer for both devlink and devlink_port

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Ptr to devlink structure can be easily obtained from devlink_port->devlink. So share user_ptr[0] pointer for both and leave user_ptr[1] free for other users. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel ---

[PATCH] net: force inlining of netif_tx_start/stop_queue, sock_hold, __sock_put

2016-04-08 Thread Denys Vlasenko
Sometimes gcc mysteriously doesn't inline very small functions we expect to be inlined. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66122 Arguably, gcc should do better, but gcc people aren't willing to invest time into it, asking to use __always_inline instead. With this .config:

[patch net-next 2/2] devlink: share user_ptr pointer for both devlink and devlink_port

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Ptr to devlink structure can be easily obtained from devlink_port->devlink. So share user_ptr[0] pointer for both and leave user_ptr[1] free for other users. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel ---

Re: [patch net-next 0/5] mlxsw: small driver update

2016-04-08 Thread Jiri Pirko
Fri, Apr 08, 2016 at 05:45:20PM CEST, j...@resnulli.us wrote: >From: Jiri Pirko > >Cosmetics, in preparation to sharedbuffer patchset. Dave, I just realized there is dependency on: "devlink: remove implicit type set in port register" which I sent couple of minutes after this

[patch net-next 1/6] devlink: remove implicit type set in port register

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko As we rely on caller zeroing or correctly set the struct before the call, this implicit type set is either no-op (DEVLINK_PORT_TYPE_NOTSET is 0) or it rewrites wanted value. So remove this. Signed-off-by: Jiri Pirko --- net/core/devlink.c

[patch net-next 5/6] mlxsw: reg: Share direction enum between SBPR, SBCM, SBPM

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Same field, same values, so share the same enum. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 23 +++---

[patch net-next 3/6] mlxsw: Pass mlxsw_core as a param of mlxsw_core_skb_transmit*

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Instead of passing around driver priv, pass struct mlxsw_core * directly. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c | 15 +++

[patch net-next 4/6] mlxsw: Do not pass around driver_priv directly

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Instead of that, pass mlxsw_core and use a helper to get driver priv from driver code. Looks much cleaner that way. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c

[patch net-next 0/6] mlxsw: small driver update + one tiny devlink dependency

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Cosmetics, in preparation to sharedbuffer patchset. First patch is here to allow patch number two. Jiri Pirko (6): devlink: remove implicit type set in port register mlxsw: Move devlink port registration into common core code mlxsw: Pass mlxsw_core as a

[patch net-next 6/6] mlxsw: reg: Fix SBPM register name

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Fix copy error and state the name of SBPM register correctly. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[patch net-next 2/5] mlxsw: Pass mlxsw_core as a param of mlxsw_core_skb_transmit*

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Instead of passing around driver priv, pass struct mlxsw_core * directly. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c | 15 +++

Re: FWD: [PATCH v2] Marvell phy: add fiber status check for some components

2016-04-08 Thread Charles-Antoine Couret
Le 04/04/2016 15:25, Andrew Lunn a écrit : > Should we be using the old mechanism to swap between TP, BNC and AUI > to swap between copper and fibre? > >Andrew What is this method ? A specific ioctl ? Regards, Charles-Antoine

Re: [RFC PATCH v2 2/5] net: add ndo to set bpf prog in adapter rx

2016-04-08 Thread Brenden Blanco
On Fri, Apr 08, 2016 at 11:38:58AM +0200, Jesper Dangaard Brouer wrote: > > On Thu, 7 Apr 2016 21:48:47 -0700 Brenden Blanco > wrote: > > > Add two new set/get netdev ops for drivers implementing the > > BPF_PROG_TYPE_PHYS_DEV filter. > > > > Signed-off-by: Brenden

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Hannes Frederic Sowa
On Fri, Apr 8, 2016, at 16:18, Bjørn Mork wrote: > Daniel Borkmann writes: > > > > > if (!token) > > return -EINVAL; > > - if (ipv6_addr_any(token)) > > - return -EINVAL; > > if (dev->flags & (IFF_LOOPBACK | IFF_NOARP)) > >

Re: qdisc spin lock

2016-04-08 Thread Eric Dumazet
On Thu, 2016-03-31 at 16:48 -0700, Michael Ma wrote: > I didn't really know that multiple qdiscs can be isolated using MQ so > that each txq can be associated with a particular qdisc. Also we don't > really have multiple interfaces... > > With this MQ solution we'll still need to assign transmit

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-08 Thread Bjørn Mork
Daniel Borkmann writes: > > if (!token) > return -EINVAL; > - if (ipv6_addr_any(token)) > - return -EINVAL; > if (dev->flags & (IFF_LOOPBACK | IFF_NOARP)) > return -EINVAL; Not directly related to the patch in

Re: [PATCH RFC] net: decrease the length of backlog queue immediately after it's detached from sk

2016-04-08 Thread Eric Dumazet
On Fri, 2016-04-08 at 19:18 +0800, Yang Yingliang wrote: > I expand tcp_adv_win_scale and tcp_rmem. It has no effect. Try : echo -2 >/proc/sys/net/ipv4/tcp_adv_win_scale And restart your flows.

[PATCH] [linux-next] Doc: networking: Fix typo in dsa

2016-04-08 Thread Masanari Iida
This patch fix typos in Documentation/networking/dsa. Signed-off-by: Masanari Iida --- Documentation/networking/dsa/bcm_sf2.txt | 2 +- Documentation/networking/dsa/dsa.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH] possible bug in handling of ipv4 route caching

2016-04-08 Thread Chris Friesen
On 04/07/2016 03:20 PM, Julian Anastasov wrote: On Thu, 7 Apr 2016, Chris Friesen wrote: Hi, We think we may have found a bug in the handling of ipv4 route caching, and are curious what you think. For local routes that require a particular output interface we do not want to cache the result.

[patch net-next 3/5] mlxsw: Do not pass around driver_priv directly

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Instead of that, pass mlxsw_core and use a helper to get driver priv from driver code. Looks much cleaner that way. Signed-off-by: Jiri Pirko Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c

[patch net-next 0/5] mlxsw: small driver update

2016-04-08 Thread Jiri Pirko
From: Jiri Pirko Cosmetics, in preparation to sharedbuffer patchset. Jiri Pirko (5): mlxsw: Move devlink port registration into common core code mlxsw: Pass mlxsw_core as a param of mlxsw_core_skb_transmit* mlxsw: Do not pass around driver_priv directly mlxsw: reg:

[PATCH v2] route: do not cache fib route info on local routes with oif

2016-04-08 Thread Chris Friesen
For local routes that require a particular output interface we do not want to cache the result. Caching the result causes incorrect behaviour when there are multiple source addresses on the interface. The end result being that if the intended recipient is waiting on that interface for the

Re: [PATCH] [linux-next] Doc: networking: Fix typo in dsa

2016-04-08 Thread Andrew Lunn
On Sat, Apr 09, 2016 at 12:00:25AM +0900, Masanari Iida wrote: > This patch fix typos in Documentation/networking/dsa. > > Signed-off-by: Masanari Iida Reviewed-by: Andrew Lunn Thanks Andrew > --- > Documentation/networking/dsa/bcm_sf2.txt | 2

Re: [RFC v5 0/5] Add virtio transport for AF_VSOCK

2016-04-08 Thread Ian Campbell
On Fri, 2016-04-01 at 15:23 +0100, Stefan Hajnoczi wrote: > This series is based on Michael Tsirkin's vhost branch (v4.5-rc6). > > I'm about to process Claudio Imbrenda's locking fixes for virtio-vsock but > first I want to share the latest version of the code.  Several people are > playing with

  1   2   >