Re: [PATCH] fs/select: add vmalloc fallback for select(2)

On 09/27/2016 01:42 PM, Nicholas Piggin wrote: On Tue, 27 Sep 2016 11:37:24 + David Laight wrote: From: Nicholas Piggin > Sent: 27 September 2016 12:25 > On Tue, 27 Sep 2016 10:44:04 +0200 > Vlastimil Babka wrote: > > > What's your customer doing

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

>> * Is it still correct nowadays that the function "gigaset_initcs" did not >> call the function "kfree" after a later function call failed? > > Yes, if it is handled in another place, Paul already did show you the place. To which source code place do you refer here? >> * Do you expect that

Re: [PATCH] Fix link error in 32bit arch because of 64bit division

On Tue, 2016-09-27 at 03:42 -0400, Vishwanath Pai wrote: > Fix link error in 32bit arch because of 64bit division > > Division of 64bit integers will cause linker error undefined reference > to `__udivdi3'. Fix this by replacing divisions with div64_64 > > Signed-off-by: Vishwanath Pai

[PATCH v7 1/8] thunderbolt: Macro rename

This first patch updates the NHI Thunderbolt controller registers file to reflect that it is not only for Cactus Ridge. No functional change intended. Signed-off-by: Amir Levy Signed-off-by: Andreas Noever --- drivers/thunderbolt/nhi_regs.h |

[PATCH v7 2/8] thunderbolt: Updating the register definitions

Adding more Thunderbolt(TM) register definitions and some helper macros. Signed-off-by: Amir Levy --- drivers/thunderbolt/nhi_regs.h | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/thunderbolt/nhi_regs.h

[PATCH v7 0/8] thunderbolt: Introducing Thunderbolt(TM) Networking

This driver enables Thunderbolt Networking on non-Apple platforms running Linux. Thunderbolt Networking provides peer-to-peer connections to transfer files between computers, perform PC migrations, and/or set up small workgroups with shared storage. This is a virtual connection that emulates an

[PATCH v7 8/8] thunderbolt: Adding maintainer entry

Add Amir Levy as maintainer for Thunderbolt(TM) ICM driver Signed-off-by: Amir Levy --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 01bff8e..a4a4614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v7 5/8] thunderbolt: Networking state machine

This patch builds the peer to peer communication path. Communication is established by a negotiation process whereby messages are sent back and forth between the peers until a connection is established. This includes the Thunderbolt Network driver communication with the second peer via Intel

Re: [PATCH v4 2/7] proc: Reduce cache miss in snmp_seq_show

From: Jia He Date: Mon, 26 Sep 2016 16:09:10 +0800 > +static int snmp_seq_show_tcp_udp(struct seq_file *seq, void *v) > +{ > + int i; > + unsigned long buff[TCPUDP_MIB_MAX]; > + struct net *net = seq->private; Please always order local variables from longest to

[PATCH v7 4/8] thunderbolt: Communication with the ICM (firmware)

This patch provides the communication protocol between the Intel Connection Manager(ICM) firmware that is operational in the Thunderbolt controller in non-Apple hardware. The ICM firmware-based controller is used for establishing and maintaining the Thunderbolt Networking connection - we need to

[PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

From: Raju Lakkaraju All the review comments updated and resending for review. Edge-rate: As system and networking speeds increase, a signal's output transition, also know as the edge rate or slew rate (V/ns), takes on greater importance because high-speed signals

[PATCH v7 6/8] thunderbolt: Networking transmit and receive

This patch provides the handling interface for sending and receiving network packets between the hosts over the full communication route (using the communication path established in the previous patch). The Thunderbolt Network driver interfaces the Linux network stack and the hardware controller

[PATCH v7 7/8] thunderbolt: Networking doc

Adding Thunderbolt(TM) networking documentation. Signed-off-by: Amir Levy --- Documentation/00-INDEX | 2 + Documentation/thunderbolt/networking.txt | 132 +++ 2 files changed, 134 insertions(+) create mode 100644

[PATCH v7 3/8] thunderbolt: Kconfig for Thunderbolt Networking

Update to the Kconfig Thunderbolt description to add Thunderbolt networking as an option. The menu item "Thunderbolt support" now offers: "Apple Hardware Support" (existing) and/or "Thunderbolt Networking" (new) You can choose the driver for your platform or build both drivers - each

Re: [PATCH net-next] bnx2x: free the mac filter group list before freeing the cmd

From: Jason Baron Date: Mon, 26 Sep 2016 11:00:44 -0400 > The group list must be freed prior to freeing the command otherwise > we have a use-after-free. > > Signed-off-by: Jason Baron Applied, thanks for the quick fixup Jason.

Re: [PATCH net v3 0/2] Fix tc-ife bugs

From: Yotam Gigi Date: Mon, 26 Sep 2016 13:45:24 +0300 > This patch-set contains two bugfixes in the tc-ife action, one fixing some > random behaviour in encode side, and one fixing the decode side packet > parsing logic. > > v2->v3 > - Fix the encode side instead of the

RE: [PATCH RFC 1/3] net: Add dev_set_env_hdr_len to accept envelope frames

> +/* return envelope header length */ > +static inline int netif_get_env_hdr_len(struct net_device *dev) { > + if (dev->netdev_ops->ndo_set_env_hdr_len) > + return dev->env_hdr_len; > + > + if (netif_reduces_vlan_mtu(dev)) > + return 0; > + > + return 4; /*

Re: [PATCH net-next 0/2] net: ethernet: mediatek: some bug fixes for PDAM and HW LRO

From: Nelson Chang Date: Mon, 26 Sep 2016 14:33:48 +0800 > 1) Add to stop PDMA while stopping the frame engine > 2) Modify the register settings for LRO relinquishments > 3) Jump out from the waiting loop while LRO relinquishments are done Series applied, but like

[PATCH v2] netfilter: xt_hashlimit: Fix link error in 32bit arch because of 64bit division

v2: Remove unnecessary div64_u64 around constants -- Fix link error in 32bit arch because of 64bit division Division of 64bit integers will cause linker error undefined reference to `__udivdi3'. Fix this by replacing divisions with div64_64 Signed-off-by: Vishwanath Pai ---

Re: [PATCH v7 4/8] thunderbolt: Communication with the ICM (firmware)

On Tue, Sep 27, 2016 at 04:43:37PM +0300, Amir Levy wrote: > This patch provides the communication protocol between the > Intel Connection Manager(ICM) firmware that is operational in the > Thunderbolt controller in non-Apple hardware. > The ICM firmware-based controller is used for establishing

Re: [PATCH v7 5/8] thunderbolt: Networking state machine

On Tue, Sep 27, 2016 at 04:43:38PM +0300, Amir Levy wrote: > This patch builds the peer to peer communication path. > Communication is established by a negotiation process whereby messages are > sent back and forth between the peers until a connection is established. > This includes the

Re: kernel BUG at net/unix/garbage.c:149!"

[Added Dave Miller to see what's the status of this patch] On 08/30/2016 12:18 PM, Miklos Szeredi wrote: > On Tue, Aug 30, 2016 at 12:37 AM, Miklos Szeredi wrote: >> On Sat, Aug 27, 2016 at 11:55 AM, Miklos Szeredi wrote: > >> crash> list -H

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

> index 000..7ba3855 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/mscc-phy-vsc8531.txt > @@ -0,0 +1,61 @@ > +* Microsemi - vsc8531 Giga bit ethernet phy > + > +Required properties: > +- compatible : Should contain phy id as "ethernet-phy-id." > + If the

Re: [PATCH v7 5/8] thunderbolt: Networking state machine

On Tue, Sep 27, 2016 at 04:43:38PM +0300, Amir Levy wrote: > This patch builds the peer to peer communication path. > Communication is established by a negotiation process whereby messages are > sent back and forth between the peers until a connection is established. > This includes the

Re: [PATCH v7 3/8] thunderbolt: Kconfig for Thunderbolt Networking

On Tue, Sep 27, 2016 at 04:43:36PM +0300, Amir Levy wrote: > Update to the Kconfig Thunderbolt description to add > Thunderbolt networking as an option. > The menu item "Thunderbolt support" now offers: > "Apple Hardware Support" (existing) > and/or > "Thunderbolt Networking" (new) > >

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

On Tue, Sep 27, 2016, at 14:52, SF Markus Elfring wrote: > >> * Is it still correct nowadays that the function "gigaset_initcs" did not > >> call the function "kfree" after a later function call failed? > > > > Yes, if it is handled in another place, Paul already did show you the place. > > To

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 09/27/2016 04:18 PM, Shmulik Ladkani wrote: On Tue, 27 Sep 2016 09:44:41 -0400 (EDT), da...@davemloft.net wrote: From: Daniel Borkmann Date: Tue, 27 Sep 2016 12:39:34 +0200 Any reason why dev_forward_skb() is not preferred over direct netif_receive_skb() you're

[PATCH nf-next v2 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole ---

[PATCH nf-next v2 2/2] nf_set_hooks_head: acommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole --- net/netfilter/core.c | 15 +++ 1 file changed, 11 insertions(+),

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

From: Daniel Borkmann Date: Tue, 27 Sep 2016 12:39:34 +0200 > Any reason why dev_forward_skb() is not preferred over direct > netif_receive_skb() you're using? It would, for example, implicitly > assure that pkt_type is always PACKET_HOST, etc. dev_forward_skb() will pull

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On Tue, 27 Sep 2016 09:44:41 -0400 (EDT), da...@davemloft.net wrote: > From: Daniel Borkmann > Date: Tue, 27 Sep 2016 12:39:34 +0200 > > > Any reason why dev_forward_skb() is not preferred over direct > > netif_receive_skb() you're using? It would, for example, implicitly >

Re: [PATCH v3 net-next] net: phy: Add Edge-rate driver for Microsemi PHYs.

Hi Andrew, > > +Optional properties: > > +- vsc8531,edge-rate : Edge rate sets the drive strength of the MAC > > + interface output signals. Changing the drive > > + strength will affect the edge rate of the output > > + signal.

Re: kernel BUG at net/unix/garbage.c:149!"

On Tue, Sep 27, 2016, at 16:16, Nikolay Borisov wrote: > Dave, > > What's the status of https://patchwork.ozlabs.org/patch/664062/ , is > this going to be picked up ? Not sure if we actually fix a bug with this. Miklos could you maybe enhance the changelog then? Thanks, Hannes

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

On Tue, 2016-09-27 at 10:13 +0200, Vlastimil Babka wrote: > I doubt anyone runs that in production, especially if performance is of > concern. > I doubt anyone serious runs select() on a large fd set in production. Last time I used it was in last century.

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 16-09-27 04:07 AM, Shmulik Ladkani wrote: Hi David, On Tue, 27 Sep 2016 01:56:06 -0400 (EDT), da...@davemloft.net wrote: The discussion on this patch has ventured off into what to do about recursion. But it unclear to me where this specific patch, and this series, stands right now.

Re: [PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

On Tue, 2016-09-27 at 23:59 +0300, Shmulik Ladkani wrote: > Up until now, 'action mirred' supported only egress actions (either > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > This patch implements the corresponding ingress actions > TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. > - if

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

On 09/27/2016 05:58 PM, Michael Chan wrote: On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli wrote: From: Milton Miller While the driver is probing the adapter, an error may occur before the netdev structure is allocated and attached to

Re: [PATCH net] tg3: Avoid NULL pointer dereference in tg3_io_error_detected()

On Tue, Sep 27, 2016 at 2:27 PM, Guilherme G. Piccoli wrote: > On 09/27/2016 05:58 PM, Michael Chan wrote: >> >> On Tue, Sep 27, 2016 at 1:05 PM, Guilherme G. Piccoli >> wrote: >>> >>> From: Milton Miller >>> >>>

Re: [PATCH v2 net-next 4/4] net/sched: act_mirred: Implement ingress actions

Hi, On Tue, 27 Sep 2016 14:27:13 -0700 Eric Dumazet wrote: > On Tue, 2016-09-27 at 23:59 +0300, Shmulik Ladkani wrote: > > Up until now, 'action mirred' supported only egress actions (either > > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > > > This patch implements the

[RFC v2 0/4] Add support for led triggers on phy link state change

Fix two net drivers that declared enum constants that conflict with enum constants in linux/leds.h Create function that encapsulates actions taken during the adjust phy link step of phy state changes. Add support for led triggers on phy link state changes by adding a config option. When set the

[RFC v2 1/4] skge: Change LED_OFF to LED_REG_OFF in marvel skge driver to avoid conflicts with leds namespace

Adding led support for phy causes namespace conflicts for some phy drivers. The marvel skge driver declared an enum for representing the states of Link LED Register. The enum contained constant LED_OFF which conflicted with declartation found in linux/leds.h. LED_OFF changed to LED_REG_OFF

[RFC v2 2/4] staging: rtl8712: Change _LED_STATE enum in rtl871x driver to avoid conflicts with LED namespace

Adding led support for phy causes namespace conflicts for some phy drivers. The rtl871 driver declared an enum for representing LED states. The enum contains constant LED_OFF which conflicted with declaration found in linux/leds.h. LED_OFF changed to LED_STATE_OFF In order to avoid a possible

[RFC v2 4/4] phy,leds: add support for led triggers on phy link state change

From: Josh Cartwright Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a set of led triggers for each instantiated PHY device. There is one LED trigger per link-speed, per-phy. This allows for a user to configure their system to allow a set of LEDs

[RFC v2 3/4] phy: Encapsulate actions performed during link state changes into function phy_adjust_link

During phy state machine state transitions some set of actions should occur whenever the link state changes. These actions should be encapsulated into a single function. This patch adds the phy_adjust_link function, which is called whenever phydev->adjust_link would have been called before.

[PATCH v5 7/7] ipv6 addrconf: change default MAX_RTR_SOLICITATIONS from 3 to -1 (unlimited)

From: Maciej Żenczykowski This changes: /proc/sys/net/ipv6/conf/all/router_solicitations /proc/sys/net/ipv6/conf/default/router_solicitations from 3 to unlimited. This is the https://tools.ietf.org/html/rfc7559 recommended default. Signed-off-by: Maciej Żenczykowski

Re: [PATCH net 2/5] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

> > Maybe wrap this in a macro? i.e.: > #define chunk_retransmitted(chunk) (chunk->sent_count > 1) > > For readability? > That's a nice suggestion. chunk->sent_count == 1 is confusing there for reading. will improve it in v2. Thanks.

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

> Good point. Using ms should actually be easy, instead of > proc_dointvec_jiffies you can use proc_dointvec_ms_jiffies. Yes, I'm aware of this, but 'proc_dointvec_ms_jiffies' seems to be a bit of a hack, and especially for large settings like this exporting them to userspace in units of ms

Re: [PATCH v5 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > This allows setting /proc/sys/net/ipv6/conf/*/router_solicitations > to -1 meaning an unlimited number of retransmits. > We could say "< 0 means infinite" and we can reduce changes here. --yoshfuji > Signed-off-by:

Re: [PATCH v4 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff

[cc Vishwanath Pai] On 27.09.2016 11:42, Maciej Żenczykowski wrote: >> Please just use do_div here and go back to the first version of the >> patch. Variable names could be more aligned with the RFC maybe? > > So I tried: > > static inline s32 rfc3315_s14_backoff_init(s32 irt) > { >/*

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

Arend Van Spriel writes: > On 27-9-2016 11:14, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> Flowrings contain skbs waiting for transmission that were passed to us >> by netif. It means we checked every one of them looking for 802.1x >>

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27-9-2016 13:27, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Flowrings contain skbs waiting for transmission that were passed to us >>> by netif. It means we checked

Re: [PATCH v3 net-next 0/3] net: bcmgenet: only use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Mon, 26 Sep 2016 22:31:54 +0200 > Some times ago, a serie of patches were committed : > - commit 62469c76007e ("net: ethernet: bcmgenet: use phydev from struct > net_device") > - commit 6b352ebccbcf ("net: ethernet: broadcom: bcmgenet: use new api

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

Am 27.09.2016 um 13:32 schrieb SF Markus Elfring: >>> I got the impression that the exception handling was incomplete in the >>> implementation of the function "gigaset_initcs". >> >> That impression is wrong. Careful reading of the code will confirm that. > > * Is it still correct nowadays that

Re: [1/3] ath10k: use devm_clk_get() instead of clk_get()

Masahiro Yamada wrote: > Use the managed variant of clk_get() to simplify the failure path > and the .remove callback. > > Signed-off-by: Masahiro Yamada 3 patches applied to ath-next branch of ath.git, thanks. 828662753d60 ath10k:

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

On Tue, 27 Sep 2016 10:44:04 +0200 Vlastimil Babka wrote: > On 09/23/2016 06:47 PM, Jason Baron wrote: > > Hi, > > > > On 09/23/2016 03:24 AM, Nicholas Piggin wrote: > >> On Fri, 23 Sep 2016 14:42:53 +0800 > >> "Hillf Danton" wrote: > >> > >

Re: [PATCH 0/3] net: fec: updates to align IP header

From: Eric Nelson Date: Sat, 24 Sep 2016 07:42:16 -0700 > This patch series is the outcome of investigation into very high > numbers of alignment faults on kernel 4.1.33 from the linux-fslc > tree: > https://github.com/freescale/linux-fslc/tree/4.1-1.0.x-imx > > The first

RE: [PATCH] fs/select: add vmalloc fallback for select(2)

From: Nicholas Piggin > Sent: 27 September 2016 12:25 > On Tue, 27 Sep 2016 10:44:04 +0200 > Vlastimil Babka wrote: > > > On 09/23/2016 06:47 PM, Jason Baron wrote: > > > Hi, > > > > > > On 09/23/2016 03:24 AM, Nicholas Piggin wrote: > > >> On Fri, 23 Sep 2016 14:42:53 +0800 > >

Re: [PATCH v5 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

Hi, Maciej Żenczykowski wrote: > From: Maciej Żenczykowski > > Signed-off-by: Maciej Żenczykowski > --- > net/ipv6/addrconf.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c >

Re: [PATCH net-next 1/4] net/sched: act_mirred: Rename tcfm_ok_push to tcfm_mac_header_xmit

On 09/22/2016 03:21 PM, Shmulik Ladkani wrote: From: Shmulik Ladkani 'tcfm_ok_push' specifies whether a mac_len sized push is needed upon egress to the target device (if action is performed at ingress). Rename it to 'tcfm_mac_header_xmit' as this is actually an

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27 September 2016 at 13:27, Kalle Valo wrote: > Arend Van Spriel writes: > >> On 27-9-2016 11:14, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> Flowrings contain skbs waiting for transmission that were passed to us

[PATCH] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2f1f5d439788..11fa1a5564d4 100644 ---

Re: ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

You're in Eliza mode again. (Hat tip to Björn Mork, https://lkml.org/lkml/2016/1/4/259). Paul Bolle

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

Hi, as longtime maintainer of the code in question I feel compelled to chime in at this point. On Tue, Sep 27, 2016, at 11:34, SF Markus Elfring wrote: > >> Will it matter here if the function "kfree" will be called for the > >> data structure members "bcs" and "inbuf" after a later function

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

>> I got the impression that the exception handling was incomplete in the >> implementation of the function "gigaset_initcs". > > That impression is wrong. Careful reading of the code will confirm that. * Is it still correct nowadays that the function "gigaset_initcs" did not call the

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27-9-2016 11:14, Rafał Miłecki wrote: > From: Rafał Miłecki > > Flowrings contain skbs waiting for transmission that were passed to us > by netif. It means we checked every one of them looking for 802.1x > Ethernet type. When deleting flowring we have to use freeing function

Re: linux-next: Tree for Sep 27

Hello, On (09/27/16 16:40), Stephen Rothwell wrote: > > Changes since 20160923: > seems that commit e3b37f11e6e4e6b6 ("netfilter: replace list_head with single linked list") breaks the build on !CONFIG_NETFILTER_INGRESS systems accessing ->nf_hooks_ingress static void nf_set_hooks_head(struct

Re: [PATCH v3] fs/select: add vmalloc fallback for select(2)

On Tue 27-09-16 10:45:36, Vlastimil Babka wrote: > The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows > with the number of fds passed. We had a customer report page allocation > failures of order-4 for this allocation. This is a costly order, so it might > easily fail, as

Re: [PATCH] Fix link error in 32bit arch because of 64bit division

Hi Vishwanath Pai, 2016-09-27 15:42 GMT+08:00 Vishwanath Pai : > Fix link error in 32bit arch because of 64bit division This should be "netfilter: xt_hashlimit: fix ... " > > --- a/net/netfilter/xt_hashlimit.c > +++ b/net/netfilter/xt_hashlimit.c > @@ -465,19 +465,20 @@ static

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27-9-2016 13:58, Rafał Miłecki wrote: > On 27 September 2016 at 13:44, Rafał Miłecki wrote: >> On 27 September 2016 at 13:27, Kalle Valo wrote: >>> Arend Van Spriel writes: >>> On 27-9-2016 11:14, Rafał Miłecki wrote:

Re: ath10k: Spelling and miscellaneous neatening

Joe Perches wrote: > Correct some trivial comment typos. > Remove unnecessary parentheses in a long line. > Convert a return; before the end of a void function definition to just ; > > Signed-off-by: Joe Perches > Reviewed-by: Julian Calaby

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27 September 2016 at 14:04, Arend Van Spriel wrote: > On 27-9-2016 13:58, Rafał Miłecki wrote: >> On 27 September 2016 at 13:44, Rafał Miłecki wrote: >>> On 27 September 2016 at 13:27, Kalle Valo wrote: Arend Van

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

Rafał Miłecki writes: > Kalle: this isn't important enough for 4.8 as it's too late for that. > > I'd like to get it for 4.9 however, as this fixes bug that could lead > to WARNING on every add_key/del_key call. We was struggling with these > WARNINGs for

Re: [Gigaset307x-common] ISDN-Gigaset: Release memory in gigaset_initcs() after an allocation failure

On Tue, Sep 27, 2016, at 13:32, SF Markus Elfring wrote: > >> I got the impression that the exception handling was incomplete in the > >> implementation of the function "gigaset_initcs". > > > > That impression is wrong. Careful reading of the code will confirm that. > > * Is it still correct

Re: [PATCH v4 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

On 27.09.2016 04:30, Maciej Żenczykowski wrote: >> Is seconds granular enough? > > The only reason why one would ever want to go into fractions of > seconds would be some sort of unittesting with very low delays. > > In any normal environment the max is going to be tens if not hundreds > or

Re: [PATCH] fs/select: add vmalloc fallback for select(2)

On Tue, 27 Sep 2016 11:37:24 + David Laight wrote: > From: Nicholas Piggin > > Sent: 27 September 2016 12:25 > > On Tue, 27 Sep 2016 10:44:04 +0200 > > Vlastimil Babka wrote: > > > > > On 09/23/2016 06:47 PM, Jason Baron wrote: > > > > Hi, > > >

Re: [PATCH net] Revert "net: ethernet: bcmgenet: use phydev from struct net_device"

From: Florian Fainelli Date: Sat, 24 Sep 2016 12:58:30 -0700 > This reverts commit 62469c76007e ("net: ethernet: bcmgenet: use phydev > from struct net_device") because it causes GENETv1/2/3 adapters to > expose the following behavior after an ifconfig down/up sequence: >

[PATCH V2 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

From: Rafał Miłecki Flowrings contain skbs waiting for transmission that were passed to us by netif. It means we checked every one of them looking for 802.1x Ethernet type. When deleting flowring we have to use freeing function that will check for 802.1x type as well. Freeing

[PATCH v5 6/7] ipv6 addrconf: change default RTR_SOLICITATION_MAX_INTERVAL from 4s to 1h

From: Maciej Żenczykowski This changes: /proc/sys/net/ipv6/conf/all/router_solicitation_max_interval /proc/sys/net/ipv6/conf/default/router_solicitation_max_interval from 4 seconds to 1 hour. This is the https://tools.ietf.org/html/rfc7559 recommended default.

[PATCH v5 5/7] ipv6 addrconf: implement RFC7559 router solicitation backoff

From: Maciej Żenczykowski This implements: https://tools.ietf.org/html/rfc7559 Backoff is performed according to RFC3315 section 14: https://tools.ietf.org/html/rfc3315#section-14 Signed-off-by: Maciej Żenczykowski --- include/net/if_inet6.h | 1 +

[PATCH v5 2/7] ipv6 addrconf: remove addrconf_sysctl_hop_limit()

From: Maciej Żenczykowski replace with extra1/2 magic Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index

[PATCH v5 0/7] implement rfc7559 ipv6 router solicitation backoff

Hi, This patch series implements RFC7559 style backoff of IPv6 router solicitation requests. Patches 1 and 2 are minor cleanup and stand on their own. Patch 3 allows a (potentially) infinite number of RS'es to be sent when the rtr_solicits sysctl is set to -1 (this depends on patch 1). Patch 4

[PATCH v5 4/7] ipv6 addrconf: add new sysctl 'router_solicitation_max_interval'

From: Maciej Żenczykowski Accessible via: /proc/sys/net/ipv6/conf/*/router_solicitation_max_interval For now we default it to the same value as the normal interval. Signed-off-by: Maciej Żenczykowski --- include/linux/ipv6.h | 1 +

[PATCH v5 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

From: Maciej Żenczykowski This allows setting /proc/sys/net/ipv6/conf/*/router_solicitations to -1 meaning an unlimited number of retransmits. Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 ++ 1 file changed, 6 insertions(+), 4

[PATCH v5 1/7] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 2f1f5d439788..11fa1a5564d4 100644 ---

Re: [PATCH] brcmfmac: replace WARNING on timeout with a simple error message

On 27-9-2016 12:12, Rafał Miłecki wrote: > From: Rafał Miłecki > > Even with timeout increased to 950 ms we get WARNINGs from time to time. > It mostly happens on A-MPDU stalls (e.g. when station goes out of > range). It may take up to 5-10 secods for the firmware to recover

Re: [PATCH v2] net: hns: mark symbols static where possible

From: Baoyou Xie Date: Mon, 26 Sep 2016 17:13:38 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous > prototype for 'hns_ae_get_handle' [-Wmissing-prototypes] >

Re: [PATCH] VSOCK: Don't dec ack backlog twice for rejected connections

From: Jorgen Hansen Date: Mon, 26 Sep 2016 23:59:53 -0700 > If a pending socket is marked as rejected, we will decrease the > sk_ack_backlog twice. So don't decrement it for rejected sockets > in vsock_pending_work(). > > Testing of the rejected socket path was done through

Re: [PATCH 4.9] brcmfmac: use correct skb freeing helper when deleting flowring

On 27 September 2016 at 13:44, Rafał Miłecki wrote: > On 27 September 2016 at 13:27, Kalle Valo wrote: >> Arend Van Spriel writes: >> >>> On 27-9-2016 11:14, Rafał Miłecki wrote: From: Rafał Miłecki

Let me hear from you

Hello Dear Friend, My name is. Samfo Abudu I have decided to seek a confidential co-operation with you in the execution of the deal described here-under for our both mutual benefit and I hope you will keep it a top secret because of the nature of the transaction, During the course of our bank

Re: [PATCH trival -resend 1/2] bpf: clean up put_cpu_var usage

On Tue, Sep 27, 2016 at 08:42:41AM -0700, Shaohua Li wrote: > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Cc: Alexei Starovoitov > Signed-off-by: Shaohua Li

Re: [PATCH trival -resend 2/2] lib: clean up put_cpu_var usage

On Tue, Sep 27, 2016 at 08:42:42AM -0700, Shaohua Li wrote: > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Signed-off-by: Shaohua Li Acked-by: Tejun Heo

Re: [PATCH trival -resend 2/2] lib: clean up put_cpu_var usage

From: Shaohua Li Date: Tue, 27 Sep 2016 08:42:42 -0700 > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Signed-off-by: Shaohua Li Applied.

Re: [PATCH trival -resend 1/2] bpf: clean up put_cpu_var usage

From: Shaohua Li Date: Tue, 27 Sep 2016 08:42:41 -0700 > put_cpu_var takes the percpu data, not the data returned from > get_cpu_var. > > This doesn't change the behavior. > > Cc: Tejun Heo > Cc: Alexei Starovoitov > Signed-off-by: Shaohua Li

Re: [PATCH v3] Net Driver: Add Cypress GX3 VID=04b4 PID=3610.

From: Date: Tue, 27 Sep 2016 09:57:50 -0600 > From: Chris Roth > > From Allan Chou > From: Chris Roth Three From lines, it's actually quite amazing how you were able to achieve this. Please take some time,

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

2016-09-28 11:08 GMT+08:00 Liping Zhang : > Hi Feng, > > 2016-09-28 9:23 GMT+08:00 Feng Gao : >> Hi Aaraon, >> >> On Tue, Sep 27, 2016 at 9:38 PM, Aaron Conole wrote: >>> It's possible for nf_hook_entry_head to return NULL if two >>>

Re: [net-next v2 0/4][pull request] 1GbE Intel Wired LAN Driver Updates 2016-09-27

From: Jeff Kirsher Date: Tue, 27 Sep 2016 19:04:57 -0700 > This series contains updates to igb and igbvf. Pulled, thanks Jeff.

Re: [PATCH v3 net-next] tcp: Change txhash on every SYN and RTO retransmit

Neal and Yuchung, thank you for the feedback. I¹ve submitted v4 with your recommended changes. Thanks, Larry On 9/27/16, 6:28 PM, "Neal Cardwell" wrote: >On Tue, Sep 27, 2016 at 8:18 PM, Yuchung Cheng wrote: >> On Tue, Sep 27, 2016 at 4:31 PM, Lawrence

[PATCH] mwifiex: report wakeup for wowlan

Enable notifying wakeup source to the PM core. This allow darkresume to correctly track wakeup source and mark mwifiex_plt as 'automatic' wakeup source. Signed-off-by: Wei-Ning Huang Signed-off-by: Rajat Jain Tested-by: Wei-Ning Huang

[PATCH v2] mwifiex: report wakeup for wowlan

Enable notifying wakeup source to the PM core in case of a wake on wireless LAN event. Signed-off-by: Wei-Ning Huang Signed-off-by: Rajat Jain Tested-by: Wei-Ning Huang Reviewed-by: Eric Caruso --- v2: Fix

  1   2   3   >