Re: [net-next PATCH 0/4] Improve bpf ELF-loader under samples/bpf

On Tue, 02 May 2017 23:10:04 +0200 Daniel Borkmann wrote: > On 05/02/2017 02:31 PM, Jesper Dangaard Brouer wrote: > > This series improves and fixes bpf ELF loader and programs under > > samples/bpf. The bpf_load.c created some hard to debug issues when > > the struct

Re: [PATCH iproute2 net 0/8] tc/act_pedit: Support offset relative to conventional header

On Mon, May 01, 2017 at 09:26:25AM -0700, Stephen Hemminger wrote: > On Sun, 23 Apr 2017 15:53:48 +0300 > Amir Vadai wrote: > > > Hi Stephen, > > > > This patchset extends pedit to support modifying a field in an offset > > relative > > to the conventional network headers

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

> From: Xin Long [mailto:lucien@gmail.com] > Sent: Wednesday, May 3, 2017 1:38 PM > On Wed, May 3, 2017 at 10:07 AM, Gao Feng > wrote: > >> From: netdev-ow...@vger.kernel.org > >> [mailto:netdev-ow...@vger.kernel.org] > >> On Behalf Of Xin Long > >> Sent: Wednesday,

Re: [PATCH net-next] net/esp4: Fix invalid esph pointer crash

On Sun, Apr 30, 2017 at 04:34:38PM +0300, il...@mellanox.com wrote: > From: Ilan Tayari > > Both esp_output and esp_xmit take a pointer to the ESP header > and place it in esp_info struct prior to calling esp_output_head. > > Inside esp_output_head, the call to

[PATCH v3] iov_iter: don't revert iov buffer if csum error

The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve ->msg_iter on error) will revert the iov buffer if copy to iter failed, but it didn't copy any datagram if the skb_checksum_complete error, so no need to revert any data at this place. v2: Sabrina notice that return -EFAULT when

[PATCH] ipv4, ipv6: ensure raw socket message is big enough to hold an IP header

raw_send_hdrinc() and rawv6_send_hdrinc() expect that the buffer copied from the userspace contains the IPv4/IPv6 header, so if too few bytes are copied, parts of the header may remain uninitialized. This bug has been detected with KMSAN. Signed-off-by: Alexander Potapenko

Re: [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality

On Wed, May 03, 2017 at 02:44:31PM +1000, Gavin Shan wrote: > This series supports NCSI debugging infrastructure by adding several > ethtool commands and one debugfs file. It was inspired by the reported > issues: No available package and channel are probed successfully. > Obviously, we don't have

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On Tue, May 2, 2017 at 11:43 PM, David Ahern wrote: > Andrey reported a warning triggered by the rcu code: > > [ cut here ] > WARNING: CPU: 1 PID: 5911 at lib/debugobjects.c:289 > debug_print_object+0x175/0x210 > ODEBUG: activate active (active state 1)

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

From: David Ahern Date: Tue, 2 May 2017 14:43:44 -0700 > Andrey reported a warning triggered by the rcu code: ... > Andrey's reproducer program runs in a very tight loop, calling > 'unshare -n' and then spawning 2 sets of 14 threads running random ioctl > calls. The relevant

Re: [PATCH] test_bpf: Use ULL suffix for 64-bit constants

From: Geert Uytterhoeven Date: Wed, 3 May 2017 13:31:04 +0200 > On 32-bit: > > lib/test_bpf.c:4772: warning: integer constant is too large for ‘unsigned > long’ type > lib/test_bpf.c:4772: warning: integer constant is too large for ‘unsigned > long’ type >

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

From: Geert Uytterhoeven Date: Wed, 3 May 2017 14:18:43 +0200 > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > build will fail with: > > net/built-in.o: In function `nf_conntrack_init_start': > (.text+0x9baf6): undefined reference to

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

On Tue, May 2, 2017 at 9:30 PM, Casey Leedom wrote: > | From: Alexander Duyck > | Date: Tuesday, May 2, 2017 11:10 AM > | ... > | So for example, in the case of x86 it seems like there are multiple > | root complexes that have issues, and the gains

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On Wed, May 3, 2017 at 4:16 PM, Mike Manning wrote: > On reflection, please put this on hold subject to testing with syzkaller. I > have not had a repro of the issue and so the fix even though harmless may not > be effective. Hi Mike, I didn't see your patch, you think

[PATCH net] ah: use crypto_memneq to check the ICV

Signed-off-by: Sabrina Dubroca --- net/ipv4/ah4.c | 5 +++-- net/ipv6/ah6.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/net/ipv4/ah4.c b/net/ipv4/ah4.c index 22377c8ff14b..207350b30f88 100644 --- a/net/ipv4/ah4.c +++ b/net/ipv4/ah4.c @@ -1,5

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello Giuseppe, On Wed, 3 May 2017 10:13:56 +0200, Giuseppe CAVALLARO wrote: > this was initially set by using the hw->link.port; both the core_init > and adjust callback > should invoke the hook and tuning the PS bit according to the speed and > mode. But this doesn't work: core_init and

Re: [PATCH] net/sched: remove redundant null check on head

Wed, May 03, 2017 at 04:21:15PM CEST, wha...@bfs.de wrote: > > >Am 03.05.2017 15:50, schrieb Colin King: >> From: Colin Ian King >> >> head is previously null checked and so the 2nd null check on head >> is redundant and therefore can be removed. >> >> Detected by

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

From: David Miller Date: Wed, 03 May 2017 09:52:51 -0400 (EDT) > From: Alexei Starovoitov > Date: Tue, 2 May 2017 21:14:43 -0700 > >> -D__x86_64__ workaround was used to make /usr/include/features.h >> to follow expected path through the system include

Re: x86: warning: kernel stack regs has bad 'bp' value

On Wed, May 3, 2017 at 3:30 PM, Josh Poimboeuf wrote: > On Wed, May 03, 2017 at 02:48:28PM +0200, Andrey Konovalov wrote: >> Hi, >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit 89c9fea3c8034cdb2fd745f551cde0b507fd6893

Re: sock_create_kern() and (lack of) get_net()

On Wed, May 3, 2017 at 4:39 AM, David Laight wrote: > I suspect that many of the sockets created with 'kern=1' are not 'special' > and should hold a reference to the namespace. They are special if they are created in net init, which means they have the same life-time

Re: [iproute PATCH] man: ip.8: Document -brief flag

On Wed, 3 May 2017 11:07:58 +0200 Phil Sutter wrote: > Brief output is especially useful for new users, so at least mention > it's existence in ip man page. > > Signed-off-by: Phil Sutter Applied. thanks.

Re: [PATCH v4 net-next 00/11] ibmvnic: Updated reset handler and code fixes

From: Nathan Fontenot Date: Wed, 03 May 2017 14:04:20 -0400 > This set of patches multiple code fixes and a new rest handler > for the ibmvnic driver. In order to implement the new reset handler > for the ibmvnic driver resource initialization needed to be moved to >

Re: [patch iproute2 v2 0/2] devlink: Add support for pipeline

On Wed, 3 May 2017 13:25:21 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Arkadi says: > > Add support for pipeline debug (dpipe). As a preparation step the netlink > attribute validation was changed before adding new dpipe attributes. > --- > v1->v2 > -

Re: [PATCH v4 net-next 08/10] net/ncsi: Support NCSI packet generation

On Wed, May 03, 2017 at 02:44:39PM +1000, Gavin Shan wrote: > This introduces /sys/kernel/debug/ncsi/eth0/pkt. The debugfs entry > can accept parameters to produce NCSI command packet. The received > NCSI response packet is dumped on read. Below is an example to send > CIS command and dump its

Re: [net-next PATCH 1/4] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for traceex2, tracex3 and tracex4

From: Alexei Starovoitov Date: Tue, 2 May 2017 17:53:16 -0700 > On Tue, May 02, 2017 at 02:31:50PM +0200, Jesper Dangaard Brouer wrote: >> Needed to adjust max locked memory RLIMIT_MEMLOCK for testing these bpf >> samples >> as these are using more and larger maps

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

From: Alexei Starovoitov Date: Tue, 2 May 2017 21:14:43 -0700 > -D__x86_64__ workaround was used to make /usr/include/features.h > to follow expected path through the system include headers. > This is not portable. > Instead define dummy stubs.h which is used by 'clang -target bpf'

Re: [PATCH net-next] selftests/bpf: add a test case to check verifier pointer arithmetic

From: Alexei Starovoitov Date: Tue, 2 May 2017 19:58:14 -0700 > From: Yonghong Song > > With clang/llvm 4.0+, the test case is able to generate > the following pattern: > > 440: (b7) r1 = 15 > 441: (05) goto pc+73 > 515: (79) r6 = *(u64 *)(r10 -152) > 516: (bf)

Re: [PATCH] net/sched: remove redundant null check on head

Am 03.05.2017 15:50, schrieb Colin King: > From: Colin Ian King > > head is previously null checked and so the 2nd null check on head > is redundant and therefore can be removed. > > Detected by CoverityScan, CID#1399505 ("Logically dead code") > > Signed-off-by:

Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

On 05/03/2017 02:11 PM, Quentin Schulz wrote: > This adds Power Management deep Suspend/Resume support for Bosch M_CAN > chip. > > When the chip resumes from deep sleep, the RAM needs to be initialized > as it is done when the driver probes. The net interface also needs to be > closed and

Re: [PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

Hum, forgot the changelog. On 03/05/2017 14:37, Quentin Schulz wrote: > This adds Power Management deep Suspend/Resume support for Bosch M_CAN > chip. > > When the system resumes from deep sleep, the chip needs to be fully > reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional. >

Re: [net-next PATCH 0/4] Improve bpf ELF-loader under samples/bpf

From: Jesper Dangaard Brouer Date: Tue, 02 May 2017 14:31:45 +0200 > This series improves and fixes bpf ELF loader and programs under > samples/bpf. The bpf_load.c created some hard to debug issues when > the struct (bpf_map_def) used in the ELF maps section format changed >

[PATCH v2 net] tcp: do not inherit fastopen_req from parent

From: Eric Dumazet Under fuzzer stress, it is possible that a child gets a non NULL fastopen_req pointer from its parent at accept() time, when/if parent morphs from listener to active session. We need to make sure this can not happen, by clearing the field after socket

[PATCH v4 net-next 04/11] ibmvnic: Delete napi's when releasing driver resources

The napi structs allocated at drivier initializatio need to be free'ed when releasing the drivers resources. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v4 net-next 00/11] ibmvnic: Updated reset handler and code fixes

This set of patches multiple code fixes and a new rest handler for the ibmvnic driver. In order to implement the new reset handler for the ibmvnic driver resource initialization needed to be moved to its own routine, a state variable is introduced to replace the various is_* flags in the driver,

[PATCH v4 net-next 02/11] ibmvnic: Replace is_closed with state field

Replace the is_closed flag in the ibmvnic adapter strcut with a more comprehensive state field that tracks the current state of the driver. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 20 +---

Re: [PATCH] net/sched: remove redundant null check on head

Wed, May 03, 2017 at 03:50:40PM CEST, colin.k...@canonical.com wrote: >From: Colin Ian King > >head is previously null checked and so the 2nd null check on head >is redundant and therefore can be removed. > >Detected by CoverityScan, CID#1399505 ("Logically dead code") >

[PATCH v2 net] xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY

When CONFIG_XFRM_SUB_POLICY=y, xfrm_dst stores a copy of the flowi for that dst. Unfortunately, the code that allocates and fills this copy doesn't care about what type of flowi (flowi, flowi4, flowi6) gets passed. In multiple code paths (from raw_sendmsg, from TCP when replying to a FIN, in

[PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the build will fail with: net/built-in.o: In function `nf_conntrack_init_start': (.text+0x9baf6): undefined reference to `__compiletime_assert_1893' or ERROR: "__compiletime_assert_1893"

Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

Hi Marc, On 03/05/2017 14:16, Marc Kleine-Budde wrote: > On 05/03/2017 02:11 PM, Quentin Schulz wrote: >> This adds Power Management deep Suspend/Resume support for Bosch M_CAN >> chip. >> >> When the chip resumes from deep sleep, the RAM needs to be initialized >> as it is done when the driver

Re: [PATCH 2/2] can: m_can: add deep Suspend/Resume support

On 05/03/2017 02:28 PM, Quentin Schulz wrote: > Hi Marc, > > On 03/05/2017 14:16, Marc Kleine-Budde wrote: >> On 05/03/2017 02:11 PM, Quentin Schulz wrote: >>> This adds Power Management deep Suspend/Resume support for Bosch M_CAN >>> chip. >>> >>> When the chip resumes from deep sleep, the RAM

RE: [PATCH net v3] driver: veth: Fix one possbile memleak when fail to register_netdevice

> From: Xin Long [mailto:lucien@gmail.com] > Sent: Wednesday, May 3, 2017 7:26 PM > On Wed, May 3, 2017 at 2:37 PM, Gao Feng wrote: > >> From: Xin Long [mailto:lucien@gmail.com] > >> Sent: Wednesday, May 3, 2017 1:38 PM > >> On Wed, May 3, 2017 at 10:07 AM, Gao

Re: [PATCH 1/1] net: usb: qmi_wwan: add Telit ME910 support

From: Daniele Palmas Date: Wed, 3 May 2017 10:30:11 +0200 > This patch adds support for Telit ME910 PID 0x1100. > > Signed-off-by: Daniele Palmas Applied and queued up for -stable, thanks.

Re: [PATCH net] tg3: don't clear stats while tg3_close

From: YueHaibing Date: Wed, 3 May 2017 15:51:32 +0800 > Now tg3 NIC's stats will be cleared after ifdown/ifup. bond_get_stats traverse > its salves to get statistics,cumulative the increment.If a tg3 NIC is added to > bonding as a slave,ifdown/ifup will cause bonding's

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

On Wed, May 03, 2017 at 09:55:16AM -0400, David Miller wrote: > From: Geert Uytterhoeven > Date: Wed, 3 May 2017 14:18:43 +0200 > > > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > > build will fail with: > > > > net/built-in.o: In function

[PATCH] ath5k: fix memory leak on buf on failed eeprom read

From: Colin Ian King The AR5K_EEPROM_READ macro returns with -EIO if a read error occurs causing a memory leak on the allocated buffer buf. Fix this by explicitly calling ath5k_hw_nvram_read and exiting on the via the freebuf label that performs the necessary free'ing

[PATCH v2 2/2] can: m_can: add deep Suspend/Resume support

This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When the system resumes from deep sleep, the chip needs to be fully reinitialized (RAM, chip, clocks, irq, candev, ...) to be functional. Signed-off-by: Quentin Schulz ---

[PATCH v2 1/2] can: m_can: move Message RAM initialization to function

To avoid possible ECC/parity checksum errors when reading an uninitialized buffer, the entire Message RAM is initialized when probing the driver. This initialization is done in the same function reading the Device Tree properties. This patch moves the RAM initialization to a separate function so

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

From: Andrew Lunn Date: Wed, 3 May 2017 14:47:22 +0200 > On Wed, May 03, 2017 at 02:44:37PM +1000, Gavin Shan wrote: >> This adds ethtool command (ETHTOOL_GNCSISTATS) to retrieve the >> NCSI hardware statistics. > > Hi Gavin > > I've not been following this patchset, so maybe

Re: [PATCH v6 net-next]smsc911x: Adding support for Micochip LAN9250 Ethernet controller

From: Date: Tue, 2 May 2017 20:59:14 + > From: David Cai > > Adding support for Microchip LAN9250 Ethernet controller. > > Signed-off-by: David Cai Applied. Please fix the "From: " field of your outgoing patch

Re: [PATCH] xdp: use common helper for netlink extended ack reporting

From: Daniel Borkmann Date: Wed, 3 May 2017 00:39:17 +0200 > Small follow-up to d74a32acd59a ("xdp: use netlink extended ACK reporting") > in order to let drivers all use the same NL_SET_ERR_MSG_MOD() helper macro > for reporting. This also ensures that we consistently add

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

On Wed, May 3, 2017 at 2:18 PM, Geert Uytterhoeven wrote: > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > build will fail with: > > net/built-in.o: In function `nf_conntrack_init_start': > (.text+0x9baf6): undefined reference to

Re: x86: warning: kernel stack regs has bad 'bp' value

On Wed, May 03, 2017 at 02:48:28PM +0200, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 89c9fea3c8034cdb2fd745f551cde0b507fd6893 (4.11.0+). > > A reproducer and .config are attached. > > The reproducer open SCTP

[PATCH net] tcp: do not inherit fastopen_req from parent

From: Eric Dumazet Under fuzzer stress, it is possible that a child gets a non NULL fastopen_req pointer from its parent at accept() time, when/if parent morphs from listener to active session. We need to make sure this can not happen, by clearing the field after socket

Re: [PATCH 00/16] Netfilter/IPVS/OVS fixes for net

From: Pablo Neira Ayuso Date: Wed, 3 May 2017 11:31:55 +0200 > The following patchset contains a rather large batch of Netfilter, IPVS > and OVS fixes for your net tree. This includes fixes for ctnetlink, the > userspace conntrack helper infrastructure, conntrack OVS

[PATCH v4 net-next 05/11] ibmvnic: Whitespace correction in release_rx_pools

Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index d52d98c..bbbd57e 100644 ---

[PATCH v4 net-next 08/11] ibmvnic: Check for driver reset first in ibmvnic_xmit

Move the check for the driver resetting to the first thing in ibmvnic_xmit(). Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c

[PATCH v4 net-next 06/11] ibmvnic: Clean up tx pools when closing

When closing the ibmvnic driver, most notably during the reset path, the tx pools need to be cleaned to ensure there are no hanging skbs that need to be free'ed. The need for this was found during debugging a loss of network traffic after handling a driver reset. The underlying cause was some

[PATCH v4 net-next 09/11] ibmvnic: Continue skb processing after skb completion error

There is not a need to stop processing skbs if we encounter a skb that has a receive completion error. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v4 net-next 03/11] ibmvnic: Updated reset handling

The ibmvnic driver has multiple handlers for resetting the driver depending on the reason the reset is needed (failover, lpm, fatal erors,...). All of the reset handlers do essentially the same thing, this patch moves this work to a common reset handler. By doing this we also allow the driver to

[PATCH v4 net-next 01/11] ibmvnic: Move resource initialization to its own routine

Move all of the calls to initialize resources for the driver to a separate routine. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 71 1 file changed, 39 insertions(+), 32 deletions(-) diff --git

[PATCH v4 net-next 11/11] ibmvnic: Move queue restarting in ibmvnic_tx_complete

Restart of the subqueue should occur outside of the loop processing any tx buffers instead of doing this in the middle of the loop. Signed-off-by: Nathan Fontenot --- v2: Use __netif_subqueue_stopped() instead of netif_subqueue_stopped() to avoid possible using

[PATCH v4 net-next 07/11] ibmvnic: Wait for any pending scrqs entries at driver close

When closing the ibmvnic driver we need to wait for any pending sub crq entries to ensure they are handled. Signed-off-by: Nathan Fontenot --- drivers/net/ethernet/ibm/ibmvnic.c | 47 +--- 1 file changed, 27 insertions(+), 20

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On reflection, please put this on hold subject to testing with syzkaller. I have not had a repro of the issue and so the fix even though harmless may not be effective. Thanks Mike On 02/05/17 19:30, Mike Manning wrote: > While this is not reproducible manually, Andrey's syzkaller program hit >

[PATCH v4 net-next 10/11] ibmvnic: Record SKB RX queue during poll

From: Thomas Falcon Map each RX SKB to the RX queue associated with the driver's RX SCRQ. This should improve the RX CPU load balancing issues seen by the performance team. Signed-off-by: Thomas Falcon ---

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

From: Mike Manning Date: Wed, 3 May 2017 15:16:20 +0100 > On reflection, please put this on hold subject to testing with > syzkaller. I have not had a repro of the issue and so the fix even > though harmless may not be effective. Ok.

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote: > Hello Thomas > > this was initially set by using the hw->link.port; both the core_init > and adjust callback > should invoke the hook and tuning the PS bit according to the speed and > mode. > So maybe the ->set_ps is

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

Geert Uytterhoeven wrote: > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > build will fail with: > > net/built-in.o: In function `nf_conntrack_init_start': > (.text+0x9baf6): undefined reference to `__compiletime_assert_1893' > > or > >

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

Hi Arnd, On Wed, May 3, 2017 at 2:32 PM, Arnd Bergmann wrote: > On Wed, May 3, 2017 at 2:18 PM, Geert Uytterhoeven > wrote: >> If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the >> build will fail with: >> >> net/built-in.o: In

Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure

On Wed, May 3, 2017 at 2:47 PM, Geert Uytterhoeven wrote: > Hi Arnd, > > On Wed, May 3, 2017 at 2:32 PM, Arnd Bergmann wrote: >> On Wed, May 3, 2017 at 2:18 PM, Geert Uytterhoeven >> wrote: >>> If gcc (e.g. 4.1.2) decides not to inline

[PATCH] net/sched: remove redundant null check on head

From: Colin Ian King head is previously null checked and so the 2nd null check on head is redundant and therefore can be removed. Detected by CoverityScan, CID#1399505 ("Logically dead code") Signed-off-by: Colin Ian King ---

Re: net/smc and the RDMA core

On 05/02/2017 08:39 PM, Bart Van Assche wrote: > On Tue, 2017-05-02 at 14:25 +0200, Ursula Braun wrote: >> if you can point out specific issues, we will be happy to work with you >> to get them addressed! > > Hello Ursula, > > My list of issues that I would like to see addressed can be found

[PATCH 1/2] can: m_can: move Message RAM initialization to function

To avoid possible ECC/parity checksum errors when reading an uninitialized buffer, the entire Message RAM is initialized when probing the driver. This initialization is done in the same function reading the Device Tree properties. This patch moves the RAM initialization to a separate function so

[PATCH 2/2] can: m_can: add deep Suspend/Resume support

This adds Power Management deep Suspend/Resume support for Bosch M_CAN chip. When the chip resumes from deep sleep, the RAM needs to be initialized as it is done when the driver probes. The net interface also needs to be closed and reopened to be fully functional. Signed-off-by: Quentin Schulz

Re: [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics

On Wed, May 03, 2017 at 02:44:37PM +1000, Gavin Shan wrote: > This adds ethtool command (ETHTOOL_GNCSISTATS) to retrieve the > NCSI hardware statistics. Hi Gavin I've not been following this patchset, so maybe i'm about to ask a question which has already been asked and answered. Why cannot use

Re: x86: warning: kernel stack regs has bad 'bp' value

On Wed, May 3, 2017 at 2:48 PM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 89c9fea3c8034cdb2fd745f551cde0b507fd6893 (4.11.0+). > > A reproducer and .config are attached. > > The reproducer

Maximum MPLS labels on Linux network stack

I watched one forum, there is listed in the properties of one license for Cisco, it says: Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license • MPLS VPN; requires Advanced IP Feature license • 26 VRFs • 8192 MPLS labels Especially interested in the figure 8192 MPLS

[PATCH v2] aquantia: Fix driver name reported by ethtool

From: Pavel Belous V2: using "aquantia" subsystem tag. The command "ethtool -i ethX" should display driver name (driver: atlantic) instead vendor name (driver: aquantia). Signed-off-by: Pavel Belous ---

Re: net/ipv6: GPF in rt6_device_match

On 5/3/17 11:02 AM, Cong Wang wrote: > A quick glance shows we need to simply check local->rt6i_idev > since we do the same check for sprt right above. As I recall, rt6i_idev is set for all routes except null_entry and it is not set on null_entry only because of initialization order. > > diff

Re: Maximum MPLS labels on Linux network stack

On 5/3/17 11:33 AM, Алексей Болдырев wrote: > I watched one forum, there is listed in the properties of one license for > Cisco, it says: > > Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license > • MPLS VPN; requires Advanced IP Feature license > • 26 VRFs There is no

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On 03/05/17 18:58, Cong Wang wrote: > On Tue, May 2, 2017 at 11:30 AM, Mike Manning wrote: >> While this is not reproducible manually, Andrey's syzkaller program hit >> the warning "IPv6: Freeing alive inet6 address" with this part trace: >> >>

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

From: Alexei Starovoitov Date: Wed, 3 May 2017 09:54:42 -0700 > /usr/include/asm/types.h -> asm-generic/int-ll64.h > as far as I can see that should be the same on most archs. > Why doesn't it work for sparc? You can't assume anything about the kernel headers installed, on my

[PATCH] net:ethernet:aquantia:atlantic: Fix driver name reported by ethtool

From: Pavel Belous The command "ethtool -i ethX" should display driver name (driver: atlantic) instead vendor name (driver: aquantia). Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_cfg.h | 2 +- 1 file changed,

Re: [PATCH] net:ethernet:aquantia:atlantic: Fix driver name reported by ethtool

From: Pavel Belous Date: Wed, 3 May 2017 21:06:04 +0300 > From: Pavel Belous > > The command "ethtool -i ethX" should display driver name (driver: atlantic) > instead vendor name (driver: aquantia). > > Signed-off-by: Pavel Belous

Re: [PATCH 2/6] wl1251: Use request_firmware_prefer_user() for loading NVS calibration data

On 3-1-2017 18:59, Luis R. Rodriguez wrote: > On Mon, Dec 26, 2016 at 05:35:59PM +0100, Pavel Machek wrote: >> >> Right question is "should we solve it without user-space help"? >> >> Answer is no, too. Way too complex. Yes, it would be nice if hardware >> was designed in such a way that getting

[PATCH] net:ethernet:aquantia:atlantic: Switch to use napi_gro_receive

From: Pavel Belous Add support for GRO (generic receive offload) for aQuantia Atlantic driver. This results in a perfomance improvement when GRO is enabled. Signed-off-by: Pavel Belous --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c |

Re: [PATCH v2 net] tcp: do not inherit fastopen_req from parent

> From: Eric Dumazet > > Under fuzzer stress, it is possible that a child gets a non NULL > fastopen_req pointer from its parent at accept() time, when/if parent > morphs from listener to active session. > > We need to make sure this can not happen, by clearing the field

Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__

On 5/3/17 9:06 AM, David Miller wrote: From: David Miller Date: Wed, 03 May 2017 09:52:51 -0400 (EDT) From: Alexei Starovoitov Date: Tue, 2 May 2017 21:14:43 -0700 -D__x86_64__ workaround was used to make /usr/include/features.h to follow expected path

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 9:33 AM, Andrey Konovalov wrote: > Hi David, > > Got another report related to fib6. > > I'm on 89c9fea3c8034cdb2fd745f551cde0b507fd6893 with your last patch applied. > > A reproducer and .config are attached. > > kasan: CONFIG_KASAN_INLINE enabled >

Re: [PATCH] net: ipv6: Fix warning of freeing alive inet6 address

On Tue, May 2, 2017 at 11:30 AM, Mike Manning wrote: > While this is not reproducible manually, Andrey's syzkaller program hit > the warning "IPv6: Freeing alive inet6 address" with this part trace: > > inet6_ifa_finish_destroy+0x12e/0x190 c:894 > in6_ifa_put

Re: Get amount of fast retransmissions from TCP info

2017-04-25 0:20 GMT+02:00 Andreas Petlund : > >> On 24 Apr 2017, at 23:31, Lars Erik Storbukås >> wrote: >> >> 2017-04-24 23:00 GMT+02:00 Neal Cardwell : >>> On Mon, Apr 24, 2017 at 4:20 PM, Lars Erik Storbukås >>>

Re: Maximum MPLS labels on Linux network stack

On 3 May 2017 at 11:14, David Ahern wrote: > On 5/3/17 11:33 AM, Алексей Болдырев wrote: >> I watched one forum, there is listed in the properties of one license for >> Cisco, it says: >> >> Layer 3 VPN • Multi-VRF CE (VRF-lite); requires IP Services Feature license >> • MPLS

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On 5/3/17 3:22 PM, Cong Wang wrote: >> Andrey's reproducer program runs in a very tight loop, calling >> 'unshare -n' and then spawning 2 sets of 14 threads running random ioctl >> calls. The relevant networking sequence: >> >> 1. New network namespace created via unshare -n >> - ip6tnl0 device is

Re: Maximum MPLS labels on Linux network stack

Is it possible to increase this limit in OpenVswitch? 03.05.2017, 23:21, "Joe Stringer" : > On 3 May 2017 at 11:14, David Ahern wrote: >>  On 5/3/17 11:33 AM, Алексей Болдырев wrote: >>>  I watched one forum, there is listed in the properties of one license for

Re: Maximum MPLS labels on Linux network stack

As I understand it, it's enough to just set the variable in the source #define FLOW_MAX_MPLS_LABELS 3 on #define FLOW_MAX_MPLS_LABELS 7 Or is there somehow still pitfalls? 04.05.2017, 00:22, "Joe Stringer" : > On 3 May 2017 at 14:19, Алексей Болдырев >

Re: Get amount of fast retransmissions from TCP info

On Wed, May 3, 2017 at 3:47 PM, Lars Erik Storbukås wrote: > I also want to count the amount of ECN signals received. Do anyone > have any input on where to place an ECN signal count? > > Is any of these locations a logical place to increase the ECN counter > (which I've

Re: [PATCH 0/9] net: thunderx: Adds XDP support

Thanks, Sunil. >with network stack: 0.32 Mpps >with XDP (XDP_TX): 3 Mpps >and XDP_DROP: 3.8 Mpps Interesting; May I ask - which packet size did you use ? Regards, Rami Rosen

Re: [PATCH v4 net-next 05/10] net/ncsi: Ethtool operation to get NCSI channel info

Hi Gavin, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Gavin-Shan/net-ncsi-Add-debugging-functionality/20170503-185932 config: alpha-allyesconfig (attached as .config) compiler: alpha-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

Re: Maximum MPLS labels on Linux network stack

On 3 May 2017 at 14:19, Алексей Болдырев wrote: > Is it possible to increase this limit in OpenVswitch? Yes.

Re: [PATCH net] net: ipv6: Do not duplicate DAD on link up

On Tue, May 2, 2017 at 2:43 PM, David Ahern wrote: > Andrey reported a warning triggered by the rcu code: > > [ cut here ] > WARNING: CPU: 1 PID: 5911 at lib/debugobjects.c:289 > debug_print_object+0x175/0x210 > ODEBUG: activate active (active state 1)

Re: net/ipv6: GPF in rt6_device_match

On Wed, May 3, 2017 at 3:09 PM, David Ahern wrote: > On 5/3/17 4:02 PM, Cong Wang wrote: >> On Wed, May 3, 2017 at 11:22 AM, David Ahern wrote: >>> On 5/3/17 11:02 AM, Cong Wang wrote: A quick glance shows we need to simply check local->rt6i_idev

Re: [PATCH net-next 00/15] netvsc: misc patches

From: Stephen Hemminger Date: Wed, 3 May 2017 16:01:02 -0700 > Mostly these are performance related. There is also one bug fix for > incorrect handling of NAPI on device removal Stephen, the net-next tree is closed as we are in the merge window. Please resubmit

  1   2   >