Preliminary bug report for kernel 4.4.118 - drivers/net/ethernet/realtek/r8169.c

This is a preliminary bug report. Slackware 14.2 64 bit. Kernel 4.4.18. File drivers/net/ethernet/realtek/r8169.c. This is an issue that: Exists in the 4.4.88 kernel Currently exists in the 4.4.118 kernel Does not exist in the older 4.4.13 kernel Does not exist in the 4.13.5 kernel I have not

Re: [PATCH] hv_netvsc: fix multicast flags and sync

On Tue, 6 Mar 2018 20:40:51 -0800 Stephen Hemminger wrote: > This addresses two problems with recent multicast flags synchronization. > The wrong filter value was being computed (and therefore ARP would > not work on WS2016). And the uc/mc sync logic had locking

[PATCH] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()

f7c83bcbfaf5 ("net: xfrm: use __this_cpu_read per-cpu helper") added a __this_cpu_read() call inside ipcomp_alloc_tfms(). Since this call was introduced, the rules around per-cpu accessors have been tightened and __this_cpu_read() cannot be used in a preemptible context. syzkaller reported this

Re: [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters

On Tue, 6 Mar 2018 17:29:57 -0800, Vinicius Costa Gomes wrote: > This allows filters added by tc-flower and specifying MAC addresses, > Ethernet types, and the VLAN priority field, to be offloaded to the > controller. > > This reuses most of the infrastructure used by ethtool, but clsflower >

Re: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support

From: Anders Roxell Date: Tue, 6 Mar 2018 16:10:04 +0100 > The reuseport_bpf_numa test case fails there's no numa support. The > test shouldn't fail if there's no support it should be skipped with a > pass. > > Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for

Re: [pci PATCH v3 0/3] Add support for unmanaged SR-IOV

On Tue, Mar 6, 2018 at 10:46 PM, Christoph Hellwig wrote: > On Tue, Mar 06, 2018 at 11:29:08AM -0800, Alexander Duyck wrote: >> This series is meant to add support for SR-IOV on devices when the VFs are >> not managed by the kernel. Examples of recent patches attempting to do

Re: [PATCH net 5/5] tcp: send real dupACKs by locking advertized window for non-SACK flows

On Wed, 2018-03-07 at 22:09 +0200, Ilpo Järvinen wrote: > Thanks for taking a look. > > On Wed, 7 Mar 2018, Eric Dumazet wrote: > > On Wed, 2018-03-07 at 14:59 +0200, Ilpo Järvinen wrote: > > > Currently, the TCP code is overly eager to update window on > > > every ACK. It makes some of the ACKs

Re: [PATCH] net: don't unnecessarily load kernel modules in dev_ioctl()

From: Paul Moore Date: Tue, 6 Mar 2018 17:32:47 -0500 > On Tue, Mar 6, 2018 at 5:27 PM, Paul Moore wrote: >> From: Paul Moore >> >> Starting with v4.16-rc1 we've been seeing a higher than usual number >> of requests for the kernel to

Re: linux-next: manual merge of the selinux tree with the net-next tree

From: Paul Moore Date: Wed, 7 Mar 2018 15:20:33 -0500 > I suppose the right thing would have been for net-next > to pull selinux/next, yes? Nope.

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

On Wed, 2018-03-07 at 15:31 -0500, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 6 Mar 2018 22:35:03 -0800 > > > This series includes shared code updates for mlx5 core driver for both > > netdev and rdma subsystems. This series should be pulled to both > > trees

Re: [Outreachy kernel] Re: [PATCH v2] net: ethernet: Drop unnecessary continue

On Wed, 7 Mar 2018, Arushi Singhal wrote: > > > On Wed, Mar 7, 2018 at 9:09 PM, David Miller wrote: > From: Arushi Singhal > Date: Sat, 3 Mar 2018 21:44:56 +0530 > > > Continue at the bottom of a loop are removed. >

Re: [patch net-next 1/2] selftests: forwarding: fix "ok" action test

From: Jiri Pirko Date: Wed, 7 Mar 2018 13:57:59 +0100 > From: Jiri Pirko > > Fix the "ok" action test so it checks that packet that is okayed does not > continue to be processed by other rules. Fix error message as well. > > Signed-off-by: Jiri Pirko

Re: [patch net-next 2/2] selftests: forwarding: fix flags passed to first drop rule in gact_drop_and_ok_test

From: Jiri Pirko Date: Wed, 7 Mar 2018 13:58:00 +0100 > From: Jiri Pirko > > Fix copy error and pass proper flags. > > Signed-off-by: Jiri Pirko > Reviewed-by: Ido Schimmel Applied.

Re: [PATCH v2] cxgb3: remove VLA usage

From: "Gustavo A. R. Silva" Date: Wed, 7 Mar 2018 12:03:33 -0600 > Remove VLA usage and change the 'len' argument to a u8 and use a 256 > byte buffer on the stack. Notice that these lengths are limited by the > encoding field in the VPD structure, which is a u8 [1]. > >

Re: [PATCH bpf] tools: bpftool: fix compilation with older headers

On 03/06/2018 02:50 PM, Jiri Benc wrote: > Compilation of bpftool on a distro that lacks eBPF support in the installed > kernel headers fails with: > > common.c: In function ‘is_bpffs’: > common.c:96:40: error: ‘BPF_FS_MAGIC’ undeclared (first use in this function) > return (unsigned

[PATCH bpf] bpf, x64: increase number of passes

In Cilium some of the main programs we run today are hitting 9 passes on x64's JIT compiler, and we've had cases already where we surpassed the limit where the JIT then punts the program to the interpreter instead, leading to insertion failures due to CONFIG_BPF_JIT_ALWAYS_ON or insertion failures

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Wed, 7 Mar 2018 09:50:50 -0800 Alexander Duyck wrote: > On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: > > On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander Duyck wrote: > >> > I definitelly vote for a separate common shared code for

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen wrote: > A bogus undo may/will trigger when the loss recovery state is > kept until snd_una is above high_seq. If tcp_any_retrans_done > is zero, retrans_stamp is cleared in this transient state. On > the next ACK,

Re: [PATCH net] net: Fix hlist corruptions in inet_evict_bucket()

From: Kirill Tkhai Date: Tue, 06 Mar 2018 18:46:39 +0300 > inet_evict_bucket() iterates global list, and > several tasks may call it in parallel. All of > them hash the same fq->list_evictor to different > lists, which leads to list corruption. > > This patch makes fq be

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

On Tue, 2018-03-06 at 22:35 -0800, Saeed Mahameed wrote: > Hi Dave and Doug, > > This series includes shared code updates for mlx5 core driver for both > netdev and rdma subsystems. This series should be pulled to both > trees so we can continue netdev and rdma specific submissions separately. >

Re: [for-next V2 12/13] {net,IB}/mlx5: Add flow steering helpers

On Tue, 2018-03-06 at 22:35 -0800, Saeed Mahameed wrote: > diff --git a/include/linux/mlx5/fs_helpers.h b/include/linux/mlx5/fs_helpers.h > new file mode 100644 > index ..7b476bbae731 > --- /dev/null > +++ b/include/linux/mlx5/fs_helpers.h > @@ -0,0 +1,134 @@ > +/* > + * Copyright (c)

Re: [for-next V2 03/13] net/mlx5e: Wait for FPGA command responses with a timeout

On Wed, 2018-03-07 at 13:25 +0300, Kirill Tkhai wrote: > On 07.03.2018 09:35, Saeed Mahameed wrote: > > From: Aviad Yehezkel > > > > Generally, FPGA IPSec commands must always complete. > > We want to wait for one minute for them to complete gracefully also > > when killing

Re: [PATCH net] tcp: purge write queue upon aborting the connection

From: Soheil Hassas Yeganeh Date: Tue, 6 Mar 2018 17:15:12 -0500 > From: Soheil Hassas Yeganeh > > When the connection is aborted, there is no point in > keeping the packets on the write queue until the connection > is closed. > > Similar to

Re: [PATCH net] cxgb4: copy adap index to PF0-3 adapter instances

From: Ganesh Goudar Date: Wed, 7 Mar 2018 13:08:45 +0530 > instantiation of VF's on different adapters fails, copy > adapter index and chip type to PF0-3 adapter instances > to fix the issue. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net] cxgb4: do not set needs_free_netdev for mgmt dev's

From: Ganesh Goudar Date: Wed, 7 Mar 2018 13:10:24 +0530 > Do not set 'needs_free_netdev' as we do call free_netdev > for mgmt net devices, doing both hits BUG_ON. > > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net-next 1/2] net: kalmia: clean up bind error path

From: Johan Hovold Date: Wed, 7 Mar 2018 10:46:57 +0100 > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface()

Re: [PATCH net-next 2/2] net: cdc_eem: clean up bind error path

From: Johan Hovold Date: Wed, 7 Mar 2018 10:46:58 +0100 > Drop bogus call to usb_driver_release_interface() from an error path in > the usbnet bind() callback, which is called during interface probe. At > this point the interface is not bound and usb_driver_release_interface()

Re: [PATCH] cxgb3: remove VLA

On 03/07/2018 11:25 AM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Mon, 5 Mar 2018 23:39:34 -0600 In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. Signed-off-by: Gustavo A. R. Silva All

Re: [PATCH] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()

On Wed, 2018-03-07 at 11:24 -0800, Greg Hackmann wrote: > f7c83bcbfaf5 ("net: xfrm: use __this_cpu_read per-cpu helper") added > a > __this_cpu_read() call inside ipcomp_alloc_tfms().  Since this call > was > introduced, the rules around per-cpu accessors have been tightened > and >

Re: [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size

David Miller writes: > From: Roman Mashak > Date: Tue, 6 Mar 2018 16:55:23 -0500 > >> +static size_t tcf_action_fill_size(const struct tc_action *act) >> +{ >> +if (act->ops->get_fill_size) >> +return act->ops->get_fill_size(act) + >> +

Re: [PATCH net-next 0/2] net: mvpp2: Add Unicast filtering capabilities

From: Maxime Chevallier Date: Wed, 7 Mar 2018 15:18:02 +0100 > This series adds unicast filtering support to the Marvell PPv2 controller. > > This is implemented using the header parser cababilities of the PPv2, > which allows for generic packet filtering based

Re: [PATCH net v2 RESEND] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes

From: Stefano Brivio Date: Tue, 6 Mar 2018 11:10:19 +0100 > Currently, administrative MTU changes on a given netdevice are > not reflected on route exceptions for MTU-less routes, with a > set PMTU value, for that device: > > # ip -6 route get 2001:db8::b > 2001:db8::b

Re: [PATCH net-next v3] selftests: net: Introduce first PMTU test

From: Stefano Brivio Date: Tue, 6 Mar 2018 22:16:27 +0100 > One single test implemented so far: test_pmtu_vti6_exception > checks that the PMTU of a route exception, caused by a tunnel > exceeding the link layer MTU, is affected by administrative > changes of the tunnel MTU.

Re: [PATCH net] dccp: check sk for closed state in dccp_sendmsg()

From: Alexey Kodanev Date: Tue, 6 Mar 2018 22:57:01 +0300 > dccp_disconnect() sets 'dp->dccps_hc_tx_ccid' tx handler to NULL, > therefore if DCCP socket is disconnected and dccp_sendmsg() is > called after it, it will cause a NULL pointer dereference in >

Re: [PATCH net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Mar 7, 2018 at 11:24 AM, Neal Cardwell wrote: > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > wrote: > > > > In a non-SACK case, any non-retransmitted segment acknowledged will > > set FLAG_ORIG_SACK_ACKED in tcp_clean_rtx_queue even

Re: [PATCH v2 net-next 3/4] net sched actions: calculate add/delete event message size

From: Roman Mashak Date: Tue, 6 Mar 2018 16:55:23 -0500 > +static size_t tcf_action_fill_size(const struct tc_action *act) > +{ > + if (act->ops->get_fill_size) > + return act->ops->get_fill_size(act) + > +

Re: [PATCH RESEND net-next 0/2] ntuple filters with RSS

From: Edward Cree Date: Wed, 7 Mar 2018 15:40:39 + > On 07/03/18 15:24, David Miller wrote: >> Ok. >> >> Since nobody is really working on the ethtool --> devlink/netlink conversion, >> it really isn't reasonable for me to block useful changes like your's. >> >> So

Re: [PATCH net-next] sock: Fix SO_ZEROCOPY switch case

From: Jesus Sanchez-Palencia Date: Wed, 7 Mar 2018 09:40:57 -0800 > Fix the SO_ZEROCOPY switch case on sock_setsockopt() avoiding the > ret values to be overwritten by the one set on the default case. > > Fixes: 28190752c7092 ("sock: permit SO_ZEROCOPY on

Re: [PATCH net-next] openvswitch: fix vport packet length check.

On Tue, Mar 6, 2018 at 5:56 PM, William Tu wrote: > When sending a packet to a tunnel device, the dev's hard_header_len > could be larger than the skb->len in function packet_length(). > In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen, > which is

Re: [PATCH net-next] sock: Fix SO_ZEROCOPY switch case

On (03/07/18 09:40), Jesus Sanchez-Palencia wrote: > Fix the SO_ZEROCOPY switch case on sock_setsockopt() avoiding the > ret values to be overwritten by the one set on the default case. Acked-by: Sowmini Varadhan

Re: [PATCH net-next 2/4] net: stmmac: use correct barrier between coherent memory and MMIO

On Wed, Mar 07, 2018 at 12:42:49PM -0500, David Miller wrote: > From: Niklas Cassel > Date: Wed, 7 Mar 2018 18:21:57 +0100 > > > Considering this, you can drop/revert: > > 95eb930a40a0 ("net: stmmac: use correct barrier between coherent memory and > > MMIO") > > or

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Wed, Mar 07, 2018 at 10:06:30AM -0800, Stephen Hemminger wrote: > On Wed, 7 Mar 2018 09:50:50 -0800 > Alexander Duyck wrote: > > > On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: > > > On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander

Re: linux-next: manual merge of the selinux tree with the net-next tree

On Wed, Mar 7, 2018 at 12:45 PM, David Miller wrote: > From: Paul Moore > Date: Wed, 7 Mar 2018 12:27:52 -0500 > >> I'm not sure we could have cleanly separated the core network stack >> changes from the rest of the SELinux/SCTP enablement, regardless

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

On Wed, 2018-03-07 at 15:41 -0500, Doug Ledford wrote: > On Wed, 2018-03-07 at 15:31 -0500, David Miller wrote: > > From: Saeed Mahameed > > Date: Tue, 6 Mar 2018 22:35:03 -0800 > > > > > This series includes shared code updates for mlx5 core driver for both > > > netdev

Re: [PATCH net 5/5] tcp: send real dupACKs by locking advertized window for non-SACK flows

Thanks for taking a look. On Wed, 7 Mar 2018, Eric Dumazet wrote: > On Wed, 2018-03-07 at 14:59 +0200, Ilpo Järvinen wrote: > > Currently, the TCP code is overly eager to update window on > > every ACK. It makes some of the ACKs that the receiver should > > sent as dupACKs look like they update

Re: [PATCH][net-next] net: mvpp2: make function mvpp2_check_hw_buf_num static

From: Colin King Date: Tue, 6 Mar 2018 16:25:17 +0100 > From: Colin Ian King > > The function mvpp2_check_hw_buf_num is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: >

Re: [PATCH net] l2tp: do not accept arbitrary sockets

From: Eric Dumazet Date: Tue, 06 Mar 2018 07:54:53 -0800 > From: Eric Dumazet > > syzkaller found an issue caused by lack of sufficient checks > in l2tp_tunnel_create() > > RAW sockets can not be considered as UDP ones for instance. > > In another

Re: [PATCH] net: dsa: mv88e6xxx: fix boolreturn.cocci warnings

From: kbuild test robot Date: Tue, 6 Mar 2018 23:54:07 +0800 > From: Fengguang Wu > > drivers/net/dsa/mv88e6xxx/serdes.c:66:9-10: WARNING: return of 0/1 in > function 'mv88e6352_port_has_serdes' with return type bool > > Return statements in

[PATCH v2] cxgb3: remove VLA usage

Remove VLA usage and change the 'len' argument to a u8 and use a 256 byte buffer on the stack. Notice that these lengths are limited by the encoding field in the VPD structure, which is a u8 [1]. [1] https://marc.info/?l=linux-netdev=152044354814024=2 Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support

On 03/07/2018 11:25 AM, David Miller wrote: > From: Anders Roxell > Date: Tue, 6 Mar 2018 16:10:04 +0100 > >> The reuseport_bpf_numa test case fails there's no numa support. The >> test shouldn't fail if there's no support it should be skipped with a >> pass. >> >>

[RFC] ethtool: Support ETHTOOL_GSTATS2 command.

From: Ben Greear This is similar to ETHTOOL_GSTATS, but it allows you to specify a 'level'. This level can be used by the driver to decrease the amount of stats refreshed. In particular, this helps with ath10k since getting the firmware stats can be slow.

Re: [PATCH] selftest: net: reuseport_bpf_numa: don't fail if no numa support

From: Shuah Khan Date: Wed, 7 Mar 2018 12:51:06 -0700 > That said, I am open to adding a distinct state for skipped because > can't be run. That is what I think should happen.

Re: linux-next: manual merge of the selinux tree with the net-next tree

From: Paul Moore Date: Wed, 7 Mar 2018 15:20:33 -0500 >> So you would only have to wait until my tree went in before >> sending your pull request. > > So you would want me to rebase selinux/next on top of Linus' tree in > the middle of the merge window? I'm sure that isn't

Re: [PATCH] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()

On 03/07/2018 12:21 PM, Eric Dumazet wrote: > On Wed, 2018-03-07 at 11:24 -0800, Greg Hackmann wrote: >> f7c83bcbfaf5 ("net: xfrm: use __this_cpu_read per-cpu helper") added >> a >> __this_cpu_read() call inside ipcomp_alloc_tfms().  Since this call >> was >> introduced, the rules around per-cpu

Re: [PATCH] net: smsc911x: Fix unload crash when link is up

From: Jeremy Linton Date: Tue, 6 Mar 2018 09:00:06 -0600 > The smsc911x driver will crash if it is rmmod'ed while the netdev > is up like: > > Call trace: ... > This is caused by the mdiobus being unregistered/free'd > and the code in phy_detach() attempting to

Re: [PATCH net-next] net/mlx4_en: try to use high order pages for RX rings

From: Eric Dumazet Date: Tue, 06 Mar 2018 11:12:53 -0800 > From: Eric Dumazet > > RX rings can fit most of the time in a contiguous piece of memory, > so lets use kvzalloc_node/kvfree instead of vzalloc_node/vfree > > Note that kvzalloc_node()

Re: [PATCH] enic: fix boolreturn.cocci warnings

From: kbuild test robot Date: Wed, 7 Mar 2018 02:23:23 +0800 > From: Fengguang Wu > > drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 > in function 'vnic_dev_capable_udp_rss' with return type bool > > Return

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

On Wed, Mar 7, 2018 at 10:06 AM, Stephen Hemminger wrote: > On Wed, 7 Mar 2018 09:50:50 -0800 > Alexander Duyck wrote: > >> On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: >> > On Tue, Mar 06, 2018 at 03:27:46PM

Re: [PATCH net] l2tp: do not accept arbitrary sockets

On Tue, Mar 06, 2018 at 07:54:53AM -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In another patch, we shall replace all pr_err() by less intrusive > pr_debug() so that syzkaller can find other bugs faster. > Or maybe just remove them entirely. These messages aren't

Re: [PATCH net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen wrote: > > In a non-SACK case, any non-retransmitted segment acknowledged will > set FLAG_ORIG_SACK_ACKED in tcp_clean_rtx_queue even if there is > no indication that it would have been delivered for real (the > scoreboard

Re: [PATCH v3 net-next 2/5] net/ipv6: Address checks need to consider the L3 domain

On 3/7/18 10:28 AM, David Ahern wrote: > On 3/7/18 4:53 AM, Kirill Tkhai wrote: >>> diff --git a/include/net/addrconf.h b/include/net/addrconf.h >>> index c4185a7b0e90..132e5b95167a 100644 >>> --- a/include/net/addrconf.h >>> +++ b/include/net/addrconf.h >>> @@ -69,8 +69,8 @@ int

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

From: Saeed Mahameed Date: Tue, 6 Mar 2018 22:35:03 -0800 > This series includes shared code updates for mlx5 core driver for both > netdev and rdma subsystems. This series should be pulled to both > trees so we can continue netdev and rdma specific submissions separately.

Re: [PATCH net 5/5] tcp: send real dupACKs by locking advertized window for non-SACK flows

On Wed, 7 Mar 2018, Eric Dumazet wrote: > > Currently non-SACK senders cannot identify almost any duplicate ACKs  > > because the window keeps updating for almost all ACKs. As a result,  > > non-SACK senders end up doing loss recovery only with RTO. RTO > > recovery  > > without SACK is quite

Re: [PATCH net-next] openvswitch: fix vport packet length check.

On Wed, Mar 7, 2018 at 1:18 PM, Pravin Shelar wrote: > On Tue, Mar 6, 2018 at 5:56 PM, William Tu wrote: >> When sending a packet to a tunnel device, the dev's hard_header_len >> could be larger than the skb->len in function packet_length(). >> In the case of

[PATCH 2/2] Documentation: macb: Document phy-handle optional binding

Signed-off-by: Brad Mouring --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 27966ae741e0..457d5ae16f23 100644 ---

[for-next 11/11] net/mlx5: Fix wrongly assigned CQ reference counter

From: Leon Romanovsky The kernel compiled with CONFIG_REFCOUNT_FULL produces the following error. The reason to it that initial value of refcount_t is supposed to be more than 0, change it. [3.106634] [ cut here ] [3.107756] refcount_t:

[for-next 10/11] net/mlx5: IPSec, Add support for ESN

From: Aviad Yehezkel Currently ESN is not supported with IPSec device offload. This patch adds ESN support to IPsec device offload. Implementing new xfrm device operation to synchronize offloading device ESN with xfrm received SN. New QP command to update SA state at the

[for-next 02/11] net/mlx5: IPSec, Generalize sandbox QP commands

From: Yossi Kuperman The current code assume only SA QP commands. Refactor in order to pave the way for new QP commands: 1. Generic cmd response format. 2. SA cmd checks are in dedicated functions. 3. Aligned debug prints. Signed-off-by: Yossi Kuperman

[for-next 07/11] net/mlx5: Refactor accel IPSec code

From: Aviad Yehezkel The current code has one layer that executed FPGA commands and the Ethernet part directly used this code. Since downstream patches introduces support for IPSec in mlx5_ib, we need to provide some abstractions. This patch refactors the accel code into

[for-next 08/11] net/mlx5: Add flow-steering commands for FPGA IPSec implementation

From: Aviad Yehezkel In order to add a context to the FPGA, we need to get both the software transform context (which includes the keys, etc) and the source/destination IPs (which are included in the steering rule). Therefore, we register new set of firmware like commands

Re: [PATCH net 5/5] tcp: send real dupACKs by locking advertized window for non-SACK flows

On Wed, 2018-03-07 at 23:39 +0200, Ilpo Järvinen wrote: > > The problem I'm trying to fix is due to window increasing (of > course,  > dupacks could also be masked because of decrease but that's something > I've never seen to occur in practice) so I tried to make you happy > and  > change my fix

Re: [PATCH net 2/5] tcp: prevent bogus FRTO undos with non-SACK flows

On Wed, 7 Mar 2018, Yuchung Cheng wrote: > On Wed, Mar 7, 2018 at 11:24 AM, Neal Cardwell wrote: > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > > wrote: > > > > > > In a non-SACK case, any non-retransmitted segment acknowledged will > > >

RE: [Intel-wired-lan] [next-queue PATCH v3 6/8] igb: Add MAC address support for ethtool nftuple filters

Hi, "Brown, Aaron F" writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Tuesday, March 6, 2018 5:30 PM >> To: intel-wired-...@lists.osuosl.org >> Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus

Re: [PATCH bpf] bpf, x64: increase number of passes

On Wed, 2018-03-07 at 22:10 +0100, Daniel Borkmann wrote: > In Cilium some of the main programs we run today are hitting 9 passes > on x64's JIT compiler, and we've had cases already where we surpassed > the limit where the JIT then punts the program to the interpreter > instead, leading to

Re: [RFC v3 iproute2 3/3] tc: Add support for the TBS Qdisc

Hi, On 03/06/2018 05:51 PM, Stephen Hemminger wrote: > On Tue, 6 Mar 2018 17:16:08 -0800 > Jesus Sanchez-Palencia wrote: > >> atic int tbs_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) >> +{ >> +struct rtattr *tb[TCA_TBS_MAX+1]; >> +

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

From: Eric Dumazet Date: Wed, 07 Mar 2018 14:45:45 -0800 > No, we need to be extra careful. +1

Re: [pull request][for-next V2 00/13] Mellanox, mlx5 IPSec updates 2018-02-28-1

On Wed, 2018-03-07 at 15:57 -0500, Doug Ledford wrote: > On Wed, 2018-03-07 at 15:41 -0500, Doug Ledford wrote: > > On Wed, 2018-03-07 at 15:31 -0500, David Miller wrote: > > > From: Saeed Mahameed > > > Date: Tue, 6 Mar 2018 22:35:03 -0800 > > > > > > > This series

Re: [PATCH 0/3] ibmvnic: Clean up net close and fix reset bug

On 03/07/2018 05:41 PM, Thomas Falcon wrote: > This patch set cleans up and reorganizes the driver's net_device > close function and leverages that to fix up a bug that can occur > during some device resets. Some reset cases require the backing > adapter to be disabled before continuing, but other

[RESEND PATCH 2/3 net-next] ibmvnic: Reorganize device close

Introduce a function to halt network operations and clean up any unused or outstanding socket buffers. Then, during device close, disable backing adapter before halting all queues and performing cleanup. This ensures all backing device operations will be stopped before the driver cleans up shared

[next-queue PATCH v3 0/8] igb: offloading of receive filters

Hi, Changes from v3: - Addressed review comments from Aaron F. Brown and Jakub Kicinski; Changes from v2: - Addressed review comments from Jakub Kicinski, mostly about coding style adjustments and more consistent error reporting; Changes from v1: - Addressed review comments from

[next-queue PATCH v4 4/8] igb: Add support for MAC address filters specifying source addresses

Makes it possible to direct packets to queues based on their source address. Documents the expected usage of the 'flags' parameter. Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igb/e1000_defines.h | 1 + drivers/net/ethernet/intel/igb/igb.h

[next-queue PATCH v4 7/8] igb: Add the skeletons for tc-flower offloading

This adds basic functions needed to implement offloading for filters created by tc-flower. Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igb/igb_main.c | 66 +++ 1 file changed, 66 insertions(+) diff --git

[next-queue PATCH v4 6/8] igb: Add MAC address support for ethtool nftuple filters

This adds the capability of configuring the queue steering of arriving packets based on their source and destination MAC addresses. In practical terms this adds support for the following use cases, characterized by these examples: $ ethtool -N eth0 flow-type ether dst aa:aa:aa:aa:aa:aa action 0

[next-queue PATCH v4 8/8] igb: Add support for adding offloaded clsflower filters

This allows filters added by tc-flower and specifying MAC addresses, Ethernet types, and the VLAN priority field, to be offloaded to the controller. This reuses most of the infrastructure used by ethtool, but clsflower filters are kept in a separated list, so they are invisible to ethtool.

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

On Mon, Mar 05, 2018 at 05:34:57PM -0800, Alexei Starovoitov wrote: > As the first step in development of bpfilter project [1] So meta :) The URL refers an lwn article, which in turn refers to this effort's first RFC. As someone only getting *one* of these patches in emails, It would be useful

Re: [PATCH 0/3] ibmvnic: Clean up net close and fix reset bug

From: Thomas Falcon Date: Wed, 7 Mar 2018 17:43:06 -0600 > Crud, this series is meant for the net-next tree, but I forgot to > include it in the patch tag. I know I'm really stubborn about a lot of things :-), but next time you can just reply like this explaining

Re: [PATCH net-next] ip6mr: remove synchronize_rcu() in favor of SOCK_RCU_FREE

On 07.03.2018 19:43, Eric Dumazet wrote: > From: Eric Dumazet > > Kirill found that recently added synchronize_rcu() call in > ip6mr_sk_done() > was slowing down netns dismantle and posted a patch to use it only if > the socket > was found. > > I instead suggested to get

Re: [next-queue PATCH v3 8/8] igb: Add support for adding offloaded clsflower filters

Hi, Jakub Kicinski writes: > On Tue, 6 Mar 2018 17:29:57 -0800, Vinicius Costa Gomes wrote: >> This allows filters added by tc-flower and specifying MAC addresses, >> Ethernet types, and the VLAN priority field, to be offloaded to the >> controller. >> >> This reuses most of

[PATCH v2 net] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()

f7c83bcbfaf5 ("net: xfrm: use __this_cpu_read per-cpu helper") added a __this_cpu_read() call inside ipcomp_alloc_tfms(). At the time, __this_cpu_read() required the caller to either not care about races or to handle preemption/interrupt issues. 3.15 tightened the rules around some per-cpu

[PATCH 1/2] net: macb: Add phy-handle DT support

This optional binding (as described in the ethernet DT bindings doc) directs the netdev to the phydev to use. This is useful for a phy chip that has >1 phy in it, and two netdevs are using the same phy chip (i.e. the second mac's phy lives on the first mac's MDIO bus) The devicetree snippet would

Re: [RFC v3 iproute2 3/3] tc: Add support for the TBS Qdisc

On Wed, 7 Mar 2018 14:29:23 -0800 Jesus Sanchez-Palencia wrote: > Hi, > > > On 03/06/2018 05:51 PM, Stephen Hemminger wrote: > > On Tue, 6 Mar 2018 17:16:08 -0800 > > Jesus Sanchez-Palencia wrote: > > > >> atic int

Re: pull-request: bpf 2018-03-08

From: Daniel Borkmann Date: Thu, 8 Mar 2018 02:17:16 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix various BPF helpers which adjust the skb and its GSO information >with regards to SCTP GSO. The

Re: [PATCH bpf] bpf, x64: increase number of passes

On Wed, Mar 07, 2018 at 10:10:01PM +0100, Daniel Borkmann wrote: > In Cilium some of the main programs we run today are hitting 9 passes > on x64's JIT compiler, and we've had cases already where we surpassed > the limit where the JIT then punts the program to the interpreter > instead, leading to

Re: [PATCH net-next] ip6mr: remove synchronize_rcu() in favor of SOCK_RCU_FREE

From: Eric Dumazet Date: Wed, 07 Mar 2018 08:43:19 -0800 > From: Eric Dumazet > > Kirill found that recently added synchronize_rcu() call in > ip6mr_sk_done() > was slowing down netns dismantle and posted a patch to use it only if > the socket > was

[PATCH] net: remove VLA usage

Separated snmp_seq_show_tcp_udp() to tcp and udp variants, so the usage of max_t() for the array size can be emitted. Signed-off-by: Laszlo Toth --- net/ipv4/proc.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/net/ipv4/proc.c

[next-queue PATCH v4 5/8] igb: Enable nfc filters to specify MAC addresses

This allows igb_add_filter()/igb_erase_filter() to work on filters that include MAC addresses (both source and destination). For now, this only exposes the functionality, the next commit glues ethtool into this. Later in this series, these APIs are used to allow offloading of cls_flower filters.

[next-queue PATCH v4 2/8] igb: Fix queue selection on MAC filters on i210 and i211

On the RAH registers there are semantic differences on the meaning of the "queue" parameter for traffic steering depending on the controller model: there is the 82575 meaning, which "queue" means a RX Hardware Queue, and the i350 meaning, where it is a reception pool. The previous behaviour was

[next-queue PATCH v4 1/8] igb: Fix not adding filter elements to the list

Because the order of the parameters passes to 'hlist_add_behind()' was inverted, the 'parent' node was added "behind" the 'input', as input is not in the list, this causes the 'input' node to be lost. Fixes: 0e71def25281 ("igb: add support of RX network flow classification") Signed-off-by:

[next-queue PATCH v4 3/8] igb: Enable the hardware traffic class feature bit for igb models

This will allow functionality depending on the hardware being traffic class aware to work. In particular the tc-flower offloading checks verifies that this bit is set. Signed-off-by: Vinicius Costa Gomes --- drivers/net/ethernet/intel/igb/igb_main.c | 3 +++ 1 file

[PATCH PATCH net v2 3/4] hv_netvsc: fix locking for rx_mode

The rx_mode operation handler is different than other callbacks in that is not always called with rtnl held. Therefore use RCU to ensure that references are valid. Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF") Signed-off-by: Stephen Hemminger ---

  1   2   3   4   >