[patch net-next v3 0/3] net: devlink: move reload fail indication to devlink core and expose to user

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko First two patches are dependencies of the last one. That moves devlink reload failure indication to the devlink code, so the drivers do not have to track it themselves. Currently it is only mlxsw, but I will send a follow-up patchset that introduces this in netdevsim too. Jiri P

[patch net-next v3 2/3] net: devlink: split reload op into two

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko In order to properly implement failure indication during reload, split the reload op into two ops, one for down phase and one for up phase. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx4/main.c | 19 +++ drivers/net/ethernet/mellanox/mlxsw/co

[patch net-next v3 3/3] net: devlink: move reload fail indication to devlink core and expose to user

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko Currently the fact that devlink reload failed is stored in drivers. Move this flag into devlink core. Also, expose it to the user. Signed-off-by: Jiri Pirko --- v2->v3: - make arg of devlink_is_reload_failed const v1->v2: - s/devlink failed/devlink reload failed/ in description

[patch net-next v3 1/3] mlx4: Split restart_one into two functions

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko Split the function restart_one into two functions and separate teardown and buildup. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlx4/catas.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 25 ++ drivers/net/ethernet/mellanox/mlx4/mlx

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Ido Schimmel
On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robert Beckett wrote: > On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > > On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli wrote: > > > +Ido, Jiri, > > > > > > On 9/10/19 8:41 AM, Robert Beckett wrote: > > > > This patch-set adds support

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Ido Schimmel
On Thu, Sep 12, 2019 at 12:58:41AM +0200, Andrew Lunn wrote: > So think about how your can model the Marvell switch capabilities > using TC, and implement offload support for it. +1 :)

Re: [PATCH v3 2/2] tcp: Add rcv_wnd to TCP_INFO

2019-09-12 Thread Dave Taht
On Thu, Sep 12, 2019 at 1:59 AM Neal Cardwell wrote: > > On Wed, Sep 11, 2019 at 6:32 PM Thomas Higdon wrote: > > > > Neal Cardwell mentioned that rcv_wnd would be useful for helping > > diagnose whether a flow is receive-window-limited at a given instant. > > > > This serves the purpose of addin

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Andrew Lunn
> 2. Scheduling: How to schedule between the different transmission queues > > Where the port from which the packets should egress is the CPU port, > before they cross the PCI towards the imx6. Hi Ido This is DSA, so the switch is connected via Ethernet to the IMX6, not PCI. Minor detail, but th

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-12 Thread David Miller
From: Taehee Yoo Date: Thu, 12 Sep 2019 12:56:19 +0900 > I tested with this reproducer commands without lockdep. > > ip link add dummy0 type dummy > ip link add link dummy0 name vlan1 type vlan id 1 > ip link set vlan1 up > > for i in {2..200} > do > let A=$i-1 >

[PATCH net] net/sched: fix race between deactivation and dequeue for NOLOCK qdisc

2019-09-12 Thread Paolo Abeni
The test implemented by some_qdisc_is_busy() is somewhat loosy for NOLOCK qdisc, as we may hit the following scenario: CPU1CPU2 // in net_tx_action() clear_bit(__QDISC_STATE_SCHED...); // in some_qdisc_is_b

Re: [PATCH v2 net-next 3/7] net: dsa: sja1105: Switch to hardware operations for PTP

2019-09-12 Thread David Miller
From: Vladimir Oltean Date: Tue, 10 Sep 2019 04:34:57 +0300 > static int sja1105_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > { > struct sja1105_private *priv = ptp_to_sja1105(ptp); > + const struct sja1105_regs *regs = priv->info->regs; > s64 clkrate; > + int

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-12 Thread Robert Beckett
On Thu, 2019-09-12 at 00:52 +0200, Andrew Lunn wrote: > > It is not just for broadcast storm protection. The original issue > > that > > made me look in to all of this turned out to be rx descritor ring > > buffer exhaustion due to the CPU not being able to keep up with > > packet > > reception. >

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-12 Thread Taehee Yoo
On Thu, 12 Sep 2019 at 18:38, David Miller wrote: > > From: Taehee Yoo > Date: Thu, 12 Sep 2019 12:56:19 +0900 > > > I tested with this reproducer commands without lockdep. > > > > ip link add dummy0 type dummy > > ip link add link dummy0 name vlan1 type vlan id 1 > > ip link set vlan

Re: [PATCH v2 net-next 3/7] net: dsa: sja1105: Switch to hardware operations for PTP

2019-09-12 Thread Vladimir Oltean
Hi Dave, On 12/09/2019, David Miller wrote: > From: Vladimir Oltean > Date: Tue, 10 Sep 2019 04:34:57 +0300 > >> static int sja1105_ptp_adjfine(struct ptp_clock_info *ptp, long >> scaled_ppm) >> { >> struct sja1105_private *priv = ptp_to_sja1105(ptp); >> +const struct sja1105_regs *re

Re: [PATCH v4] tun: fix use-after-free when register netdev failed

2019-09-12 Thread David Miller
From: Yang Yingliang Date: Tue, 10 Sep 2019 18:56:57 +0800 > I got a UAF repport in tun driver when doing fuzzy test: ... > tun_chr_read_iter() accessed the memory which freed by free_netdev() > called by tun_set_iff(): > > CPUA CPUB > tun_set

Re: [Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-12 Thread Linus Torvalds
On Thu, Sep 12, 2019 at 2:10 AM Cong Wang wrote: > > On Wed, Sep 11, 2019 at 2:36 PM Eric Dumazet wrote: > > > > It seems a similar fix would be needed in net/sched/sch_dsmark.c ? > > > > Yeah, or just add a NULL check in dsmark_destroy(). Well, this was why one of my suggestions was to just mak

Re: [PATCH 1/7] net/dsa: configure autoneg for CPU port

2019-09-12 Thread Andrew Lunn
> > It actually has nothing to do with PHY to PHY connections. You can > > use > > pause frames with direct MAC to MAC connections. PHY auto-negotiation > > is one way to indicate both ends support it, but there are also other > > ways. e.g. > > > > ethtool -A|--pause devname [autoneg on|off] [rx

Re: [PATCH net] net: Fix null de-reference of device refcount

2019-09-12 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Tue, 10 Sep 2019 14:02:57 -0600 > In event of failure during register_netdevice, free_netdev is > invoked immediately. free_netdev assumes that all the netdevice > refcounts have been dropped prior to it being called and as a > result frees and clears ou

[PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Steffen Klassert
The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by using the xfrm_offload() function to test for TX

Re: ANNOUNCE: rpld an another RPL implementation for Linux

2019-09-12 Thread Stefan Schmidt
Hello Alex. On 29.08.19 23:57, Alexander Aring wrote: > Hi, > > I had some free time, I wanted to know how RPL [0] works so I did a > implementation. It's _very_ basic as it only gives you a "routable" > (is that a word?) thing afterwards in a very constrained setup of RPL > messages. > > Took ~

[patch iproute2-next v4 0/2] devlink: couple forgotten flash patches

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko I was under impression they are already merged, but apparently they are not. I just rebased them on top of current iproute2 net-next tree. Jiri Pirko (2): devlink: implement flash update status monitoring devlink: implement flash status monitoring devlink/devlink.c |

[patch iproute2-next v4 2/2] devlink: implement flash status monitoring

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko Listen to status notifications coming from kernel during flashing and put them on stdout to inform user about the status. Signed-off-by: Jiri Pirko --- v3->v4: - rebased (traps, pr_x conversion) v2->v3: - added example in man v1->v2: - fixed endless loop bug in case of no notif

[patch iproute2-next v4 1/2] devlink: implement flash update status monitoring

2019-09-12 Thread Jiri Pirko
From: Jiri Pirko Kernel sends notifications about flash update status, so implement these messages for monitoring. Signed-off-by: Jiri Pirko --- v3->v4: - rebased (traps) --- devlink/devlink.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/devl

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-12 Thread David Miller
From: Taehee Yoo Date: Thu, 12 Sep 2019 19:14:37 +0900 > On Thu, 12 Sep 2019 at 18:38, David Miller wrote: >> >> From: Taehee Yoo >> Date: Thu, 12 Sep 2019 12:56:19 +0900 >> >> > I tested with this reproducer commands without lockdep. >> > >> > ip link add dummy0 type dummy >> > ip link

Re: [PATCH v2 net-next 3/7] net: dsa: sja1105: Switch to hardware operations for PTP

2019-09-12 Thread David Miller
From: Vladimir Oltean Date: Thu, 12 Sep 2019 11:17:11 +0100 > Hi Dave, > > On 12/09/2019, David Miller wrote: >> From: Vladimir Oltean >> Date: Tue, 10 Sep 2019 04:34:57 +0300 >> >>> static int sja1105_ptp_adjfine(struct ptp_clock_info *ptp, long >>> scaled_ppm) >>> { >>> struct sja1105_

Re: [Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-12 Thread David Miller
From: Linus Torvalds Date: Thu, 12 Sep 2019 11:31:06 +0100 > It depends on what you want to do, of course. Do you want to make sure > each user is being very careful? Or do you want to make the interfaces > easy to use without _having_ to be careful? There are arguments both > ways, but we've ten

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread David Miller
From: Steffen Klassert Date: Thu, 12 Sep 2019 13:01:44 +0200 > The ixgbe driver currently does IPsec TX offloading > based on an existing secpath. However, the secpath > can also come from the RX side, in this case it is > misinterpreted for TX offload and the packets are > dropped with a "bad sa

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-12 Thread Taehee Yoo
On Thu, 12 Sep 2019 at 20:37, David Miller wrote: > > From: Taehee Yoo > Date: Thu, 12 Sep 2019 19:14:37 +0900 > > > On Thu, 12 Sep 2019 at 18:38, David Miller wrote: > >> > >> From: Taehee Yoo > >> Date: Thu, 12 Sep 2019 12:56:19 +0900 > >> > >> > I tested with this reproducer commands without

Re: [PATCH v2 net-next 3/7] net: dsa: sja1105: Switch to hardware operations for PTP

2019-09-12 Thread Vladimir Oltean
On 12/09/2019, David Miller wrote: > From: Vladimir Oltean > Date: Thu, 12 Sep 2019 11:17:11 +0100 > >> Hi Dave, >> >> On 12/09/2019, David Miller wrote: >>> From: Vladimir Oltean >>> Date: Tue, 10 Sep 2019 04:34:57 +0300 >>> static int sja1105_ptp_adjfine(struct ptp_clock_info *ptp, long

Re: [patch net-next rfc 3/7] net: rtnetlink: add commands to add and delete alternative ifnames

2019-09-12 Thread Jiri Pirko
Fri, Aug 30, 2019 at 07:03:42PM CEST, j...@resnulli.us wrote: >Fri, Aug 30, 2019 at 04:35:23PM CEST, ro...@cumulusnetworks.com wrote: [...] >> >>so to summarize, i think we have discussed the following options to >>update a netlink list attribute so far: >>(a) encode an optional attribute/flag in

Re: [PATCH net v2 01/11] net: core: limit nested device depth

2019-09-12 Thread Taehee Yoo
On Thu, 12 Sep 2019 at 20:37, David Miller wrote: > > From: Taehee Yoo > Date: Thu, 12 Sep 2019 19:14:37 +0900 > > > On Thu, 12 Sep 2019 at 18:38, David Miller wrote: > >> > >> From: Taehee Yoo > >> Date: Thu, 12 Sep 2019 12:56:19 +0900 > >> > >> > I tested with this reproducer commands without

[PATCH net-next 2/2] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-12 Thread Ido Schimmel
From: Shalom Toledo While debugging packet loss towards the CPU, it is useful to be able to query the CPU port's shared buffer quotas and occupancy. Since the CPU port has no ingress buffers, all the shared buffers ingress information will be cleared. Signed-off-by: Shalom Toledo Signed-off-by

[PATCH net-next 0/2] mlxsw: spectrum_buffers: Add the ability to query the CPU port's shared buffer

2019-09-12 Thread Ido Schimmel
From: Ido Schimmel Shalom says: While debugging packet loss towards the CPU, it is useful to be able to query the CPU port's shared buffer quotas and occupancy. Patch #1 registers the CPU port with devlink. Patch #2 adds the ability to query the CPU port's shared buffer quotas and occupancy.

[PATCH net-next 1/2] mlxsw: spectrum: Register CPU port with devlink

2019-09-12 Thread Ido Schimmel
From: Shalom Toledo Register CPU port with devlink. Signed-off-by: Shalom Toledo Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core.c| 33 + drivers/net/ethernet/mellanox/mlxsw/core.h| 5 ++ .../net/ethernet/mellanox/mlxsw/spectrum.c| 47

[PATCH net] net: dsa: Fix load order between DSA drivers and taggers

2019-09-12 Thread Andrew Lunn
The DSA core, DSA taggers and DSA drivers all make use of module_init(). Hence they get initialised at device_initcall() time. The ordering is non-deterministic. It can be a DSA driver is bound to a device before the needed tag driver has been initialised, resulting in the message: No tagger for t

[no subject]

2019-09-12 Thread Dean
-- Did you get my proposal ?

Dear Friend,

2019-09-12 Thread Mrs Jessica Becker
Dear Friend, Hello how are you doing? Please, I am still waiting for your reply on the message I sent you yesterday Thanks Mrs Jessica Becker.

[bisected] UDP / xfrm: NAT-T packets with bad UDP checksum get dropped

2019-09-12 Thread Thomas Jarosch
Hello together, after updating many machines already from 3.14 to 4.19.67, one site showed a non-working IPSec VPN connection with 4.19.x. This IPSec connection is using UDP NAT traversal on port 4500. The tunnel gets established fine, but no data flows. Output of "ip xfrm state" looked sane. Th

[PATCH bpf-next] libbpf: add xsk_umem__adjust_offset

2019-09-12 Thread Kevin Laatz
Currently, xsk_umem_adjust_offset exists as a kernel internal function. This patch adds xsk_umem__adjust_offset to libbpf so that it can be used from userspace. This will take the responsibility of properly storing the offset away from the application, making it less error prone. Since xsk_umem__a

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jeff Kirsher
On Thu, 2019-09-12 at 13:43 +0200, David Miller wrote: > From: Steffen Klassert > Date: Thu, 12 Sep 2019 13:01:44 +0200 > > > The ixgbe driver currently does IPsec TX offloading > > based on an existing secpath. However, the secpath > > can also come from the RX side, in this case it is > > misin

Re: [v2 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-12 Thread Jesper Dangaard Brouer
On Thu, 12 Sep 2019 03:48:06 +0900 "Daniel T. Lee" wrote: > This commit adds CIDR parsing and IP validate helper function to parse > single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) One question: You do know that this expansion of the CIDR will also include the CIDR network broadcast IP

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Florian Fainelli
On 9/12/19 2:03 AM, Ido Schimmel wrote: > On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robert Beckett wrote: >> On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: >>> On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli wrote: +Ido, Jiri, On 9/10/19 8:41 AM, Robert Beckett wro

RE: [Intel-wired-lan] [PATCH bpf-next 1/3] i40e: fix xdp handle calculations

2019-09-12 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Ciara Loftus > Sent: Wednesday, September 11, 2019 10:25 AM > To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel, > Bjorn ; Karlsson, Magnus > ; jonathan.le...@gmail

RE: [Intel-wired-lan] [PATCH bpf-next 2/3] ixgbe: fix xdp handle calculations

2019-09-12 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Ciara Loftus > Sent: Wednesday, September 11, 2019 10:25 AM > To: netdev@vger.kernel.org; a...@kernel.org; dan...@iogearbox.net; Topel, > Bjorn ; Karlsson, Magnus > ; jonathan.le...@gmail

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jonathan Tooker
On 9/12/2019 6:01 AM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Robert Beckett
On Thu, 2019-09-12 at 09:25 -0700, Florian Fainelli wrote: > On 9/12/19 2:03 AM, Ido Schimmel wrote: > > On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robert Beckett wrote: > > > On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > > > > On Tue, Sep 10, 2019 at 09:49:46AM -0700, Florian Fainelli >

Re: [Patch net] sch_sfb: fix a crash in sfb_destroy()

2019-09-12 Thread Cong Wang
On Thu, Sep 12, 2019 at 3:31 AM Linus Torvalds wrote: > > On Thu, Sep 12, 2019 at 2:10 AM Cong Wang wrote: > > > > On Wed, Sep 11, 2019 at 2:36 PM Eric Dumazet wrote: > > > > > > It seems a similar fix would be needed in net/sched/sch_dsmark.c ? > > > > > > > Yeah, or just add a NULL check in ds

[Patch net v2] net_sched: let qdisc_put() accept NULL pointer

2019-09-12 Thread Cong Wang
When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL pointer which leads to a crash in sfb_destroy(). Similar for sch_dsmark. Instead of fixing each separately, Linus suggested to just accept NULL pointer in qdisc_put(), which would make callers easier. (For sch_dsmark, the bug prob

Re: [PATCH 0/7] net: dsa: mv88e6xxx: features to handle network storms

2019-09-12 Thread Florian Fainelli
On 9/12/19 9:46 AM, Robert Beckett wrote: > On Thu, 2019-09-12 at 09:25 -0700, Florian Fainelli wrote: >> On 9/12/19 2:03 AM, Ido Schimmel wrote: >>> On Wed, Sep 11, 2019 at 12:49:03PM +0100, Robert Beckett wrote: On Wed, 2019-09-11 at 11:21 +, Ido Schimmel wrote: > On Tue, Sep 10, 201

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Shannon Nelson
On 9/12/19 12:01 PM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by u

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Michael Marley
On 2019-09-12 07:01, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dropped with a "bad sa_idx" error. Fix this by u

Re: [v2 2/3] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing

2019-09-12 Thread Daniel T. Lee
On Fri, Sep 13, 2019 at 12:59 AM Jesper Dangaard Brouer wrote: > > On Thu, 12 Sep 2019 03:48:06 +0900 > "Daniel T. Lee" wrote: > > > This commit adds CIDR parsing and IP validate helper function to parse > > single IP or range of IP with CIDR. (e.g. 198.18.0.0/15) > > One question: You do know th

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Shannon Nelson
On 9/12/19 5:33 PM, Jonathan Tooker wrote: On 9/12/2019 6:01 AM, Steffen Klassert wrote: The ixgbe driver currently does IPsec TX offloading based on an existing secpath. However, the secpath can also come from the RX side, in this case it is misinterpreted for TX offload and the packets are dro

Re: [PATCH] ixgbe: Fix secpath usage for IPsec TX offload.

2019-09-12 Thread Jeff Kirsher
On Thu, 2019-09-12 at 11:33 -0500, Jonathan Tooker wrote: > On 9/12/2019 6:01 AM, Steffen Klassert wrote: > > The ixgbe driver currently does IPsec TX offloading > > based on an existing secpath. However, the secpath > > can also come from the RX side, in this case it is > > misinterpreted for TX o

[net] ixgbevf: Fix secpath usage for IPsec Tx offload

2019-09-12 Thread Jeff Kirsher
Port the same fix for ixgbe to ixgbevf. The ixgbevf driver currently does IPsec Tx offloading based on an existing secpath. However, the secpath can also come from the Rx side, in this case it is misinterpreted for Tx offload and the packets are dropped with a "bad sa_idx" error. Fix this by using

Re: [Patch net v2] net_sched: let qdisc_put() accept NULL pointer

2019-09-12 Thread Jiri Pirko
Thu, Sep 12, 2019 at 07:22:30PM CEST, xiyou.wangc...@gmail.com wrote: >When tcf_block_get() fails in sfb_init(), q->qdisc is still a NULL >pointer which leads to a crash in sfb_destroy(). Similar for >sch_dsmark. > >Instead of fixing each separately, Linus suggested to just accept >NULL pointer in

[net-next 0/6][pull request] 100GbE Intel Wired LAN Driver Updates 2019-09-12

2019-09-12 Thread Jeff Kirsher
This series contains updates to ice driver to implement and support loading a Dynamic Device Personalization (DDP) package from lib/firmware onto the device. Paul updates the way the driver version is stored in the driver so that we can pass the driver version to the firmware. Passing of the driv

[net-next 4/6] ice: Initialize DDP package structures

2019-09-12 Thread Jeff Kirsher
From: Tony Nguyen Add functions to initialize, parse, and clean structures representing the DDP package. Upon completion of package download, read and store the DDP package contents to these structures. This configuration is used to identify the default behavior and later used to update the HW

[net-next 6/6] ice: Bump version

2019-09-12 Thread Jeff Kirsher
From: Tony Nguyen Bump version to 0.8.1-k Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/ice/ice_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers

[net-next 3/6] ice: Implement Dynamic Device Personalization (DDP) download

2019-09-12 Thread Jeff Kirsher
From: Tony Nguyen Add the required defines, structures, and functions to enable downloading a DDP package. Before download, checks are performed to ensure the package is valid and compatible. Note that package download is not yet requested by the driver as further initialization is required to

[net-next 5/6] ice: Enable DDP package download

2019-09-12 Thread Jeff Kirsher
From: Tony Nguyen Attempt to request an optional device-specific DDP package file (one with the PCIe Device Serial Number in its name so that different DDP package files can be used on different devices). If the optional package file exists, download it to the device. If not, download the default

[net-next 2/6] ice: Fix FW version formatting in dmesg

2019-09-12 Thread Jeff Kirsher
From: Lukasz Czapnik The FW build id is currently being displayed as an int which doesn't make sense. Instead display FW build id as a hex value. Also add other useful information to the output such as NVM version, API patch info, and FW build hash. Signed-off-by: Lukasz Czapnik Signed-off-by:

[net-next 1/6] ice: send driver version to firmware

2019-09-12 Thread Jeff Kirsher
From: Paul M Stillwell Jr The driver is required to send a version to the firmware to indicate that the driver is up. If the driver doesn't do this the firmware doesn't behave properly. Signed-off-by: Paul M Stillwell Jr Signed-off-by: Tony Nguyen Tested-by: Andrew Bowers Signed-off-by: Jeff

[PATCH V1 net-next 00/11] net: ena: implement adaptive interrupt moderation using dim

2019-09-12 Thread akiyano
From: Arthur Kiyanovski In this patchset we replace our adaptive interrupt moderation implementation with the dim library implementation. The dim library showed great improvement in throughput, latency and CPU usage in different scenarios on ARM CPUs. This patchset also includes a few bug fixes t

[PATCH V1 net-next 01/11] net: ena: add intr_moder_rx_interval to struct ena_com_dev and use it

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Add intr_moder_rx_interval to struct ena_com_dev and use it as the location where the interrupt moderation rx interval is saved, instead of the interrupt moderation table. This is done as a first step before removing the old interrupt moderation code. Signed-off-by: Arth

[PATCH V1 net-next 03/11] net: ena: reimplement set/get_coalesce()

2019-09-12 Thread akiyano
From: Arthur Kiyanovski 1. Remove old adaptive interrupt moderation code from set/get_coalesce() 2. Add ena_update_rx_rings_intr_moderation() function for updating nonadaptive interrupt moderation intervals similarly to ena_update_tx_rings_intr_moderation(). 3. Remove checks of multiple uns

[PATCH V1 net-next 06/11] net: ena: remove old adaptive interrupt moderation code from ena_netdev

2019-09-12 Thread akiyano
From: Arthur Kiyanovski 1. Out of the fields {per_napi_bytes, per_napi_packets} in struct ena_ring, only rx_ring->per_napi_packets are used to determine if napi did work for dim. This commit removes all other uses of these fields. 2. Remove ena_ring->moder_tbl_idx, which is not used by d

[PATCH V1 net-next 05/11] net: ena: remove code duplication in ena_com_update_nonadaptive_moderation_interval _*()

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Remove code duplication in: ena_com_update_nonadaptive_moderation_interval_tx() ena_com_update_nonadaptive_moderation_interval_rx() functions. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 30 --- 1 file changed, 16

[PATCH V1 net-next 04/11] net: ena: enable the interrupt_moderation in driver_supported_features

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Add driver_supported_features to host_host info which is a new API used to communicate to the device which features are supported by the driver. Add the interrupt_moderation bit to host_info->driver_supported_features and enable it to signal the device that this driver su

[PATCH V1 net-next 08/11] net: ena: remove all old adaptive rx interrupt moderation code from ena_com

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Remove previous implementation of adaptive rx interrupt moderation from ena_com files. Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_com.c | 110 - drivers/net/ethernet/amazon/ena/ena_com.h | 142 -- 2 files

[PATCH V1 net-next 07/11] net: ena: remove ena_restore_ethtool_params() and relevant fields

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Deleted unused 4 fields from struct ena_adapter and their only user ena_restore_ethtool_params(). Signed-off-by: Arthur Kiyanovski --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 10 -- drivers/net/ethernet/amazon/ena/ena_netdev.h | 3 --- 2 files changed, 1

[PATCH V1 net-next 10/11] net: ena: fix retrieval of nonadaptive interrupt moderation intervals

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Nonadaptive interrupt moderation intervals are assigned the value set by the user in ethtool -C divided by ena_dev->intr_delay_resolution. Therefore when the user tries to get the nonadaptive interrupt moderation intervals with ethtool -c the code needs to multiply the sa

[PATCH V1 net-next 11/11] net: ena: fix incorrect update of intr_delay_resolution

2019-09-12 Thread akiyano
From: Arthur Kiyanovski ena_dev->intr_moder_rx/tx_interval save the intervals received from the user after dividing them by ena_dev->intr_delay_resolution. Therefore when intr_delay_resolution changes, the code needs to first mutiply intr_moder_rx/tx_interval by the previous intr_delay_resolution

[PATCH V1 net-next 09/11] net: ena: fix update of interrupt moderation register

2019-09-12 Thread akiyano
From: Arthur Kiyanovski Current implementation always updates the interrupt register with the smoothed_interval of the rx_ring. However this should be done only in case of adaptive interrupt moderation. If non-adaptive interrupt moderation is used, the non-adaptive interrupt moderation interval s

Re: [net] ixgbevf: Fix secpath usage for IPsec Tx offload

2019-09-12 Thread Shannon Nelson
On 9/12/19 8:07 PM, Jeff Kirsher wrote: Port the same fix for ixgbe to ixgbevf. The ixgbevf driver currently does IPsec Tx offloading based on an existing secpath. However, the secpath can also come from the Rx side, in this case it is misinterpreted for Tx offload and the packets are dropped wi

Re: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds

2019-09-12 Thread Marcelo Ricardo Leitner
On Thu, Sep 12, 2019 at 01:47:08AM +0800, Xin Long wrote: > On Wed, Sep 11, 2019 at 8:56 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Sep 11, 2019 at 05:38:33PM +0800, Xin Long wrote: > > > On Wed, Sep 11, 2019 at 5:21 PM Xin Long wrote: > > > > > > > > On Wed, Sep 11, 2019 at 5:03 PM Davi

[PATCH net] net/rds: Fix 'ib_evt_handler_call' element in 'rds_ib_stat_names'

2019-09-12 Thread Gerd Rausch
All entries in 'rds_ib_stat_names' are stringified versions of the corresponding "struct rds_ib_statistics" element without the "s_"-prefix. Fix entry 'ib_evt_handler_call' to do the same. Fixes: f4f943c958a2 ("RDS: IB: ack more receive completions to improve performance") Signed-off-by: Gerd Ra

Re: [PATCH net] net/rds: Fix 'ib_evt_handler_call' element in 'rds_ib_stat_names'

2019-09-12 Thread santosh . shilimkar
On 9/12/19 1:49 PM, Gerd Rausch wrote: All entries in 'rds_ib_stat_names' are stringified versions of the corresponding "struct rds_ib_statistics" element without the "s_"-prefix. Fix entry 'ib_evt_handler_call' to do the same. Fixes: f4f943c958a2 ("RDS: IB: ack more receive completions to impr

[PATCH net] udp: correct reuseport selection with connected sockets

2019-09-12 Thread Willem de Bruijn
From: Willem de Bruijn UDP reuseport groups can hold a mix unconnected and connected sockets. Ensure that connections only receive all traffic to their 4-tuple. Fast reuseport returns on the first reuseport match on the assumption that all matches are equal. Only if connections are present, retu

Re: [PATCH bpf-next v10 2/4] bpf: new helper to obtain namespace data from current task New bpf helper bpf_get_current_pidns_info.

2019-09-12 Thread Yonghong Song
On 9/12/19 3:03 PM, carlos antonio neira bustos wrote: > Yonghong, > > I think bpf_get_ns_current_pid_tgid interface is a lot better than the > one proposed in my patch, how are we going to move forward? Should I > take these changes and refactor the selftests to use this new interface > and

Re: [PATCH bpf-next 1/3] i40e: fix xdp handle calculations

2019-09-12 Thread Björn Töpel
On Wed, 11 Sep 2019 at 19:27, Ciara Loftus wrote: > > Commit 4c5d9a7fa149 ("i40e: fix xdp handle calculations") reintroduced > the addition of the umem headroom to the xdp handle in the i40e_zca_free, > i40e_alloc_buffer_slow_zc and i40e_alloc_buffer_zc functions. However, > the headroom is alread

Re: [PATCH bpf-next 2/3] ixgbe: fix xdp handle calculations

2019-09-12 Thread Björn Töpel
On Wed, 11 Sep 2019 at 19:27, Ciara Loftus wrote: > > Commit 7cbbf9f1fa23 ("ixgbe: fix xdp handle calculations") reintroduced > the addition of the umem headroom to the xdp handle in the ixgbe_zca_free, > ixgbe_alloc_buffer_slow_zc and ixgbe_alloc_buffer_zc functions. However, > the headroom is al

Re: [PATCH bpf-next] libbpf: add xsk_umem__adjust_offset

2019-09-12 Thread Björn Töpel
On Thu, 12 Sep 2019 at 17:47, Kevin Laatz wrote: > > Currently, xsk_umem_adjust_offset exists as a kernel internal function. > This patch adds xsk_umem__adjust_offset to libbpf so that it can be used > from userspace. This will take the responsibility of properly storing the > offset away from the