Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

On 01/19/2017 02:41 PM, Florian Fainelli wrote: On 01/19/2017 01:33 PM, Alexander Loktionov wrote: From: David VomLehn <voml...@texas.net> This series introduces the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v5: o Removed extra newline at the end of the files.

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

On Fri, Nov 04, 2016 at 10:05:15AM -0700, Randy Dunlap wrote: > On 11/03/16 23:53, Joe Perches wrote: > > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: > >> From: Madalin Bucur > >> Date: Wed, 2 Nov 2016 22:17:26 +0200 > >> > >>> This introduces the Freescale Data

Suggestions for new Ethernet driver?

I'm working with Aquantia to add a new 2.5/5 Gbps driver to the kernel. It looks like it's going to one of the biggest drivers in drivers/net/ethernet. The team that developed the driver is new to kernel development processes, but are working to make it checkpatch-clean and addressing sparse

Re: [PATCH v5 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

On 01/13/2017 05:38 PM, Florian Fainelli wrote: On 01/12/2017 09:02 PM, Alexander Loktionov wrote: From: David VomLehn <voml...@texas.net> v1: Initial version v2: o Make necessary drivers/net/ethernet changes to integrate software o Drop intermediate atlantic directory o

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn <voml...@texas.net> Patches to create the make and configuration files. This patch should _really_ be the last in the series not the first. Could you explain the

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On 01/12/2017 09:59 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:24 -0800, David VomLehn wrote: On 01/12/2017 09:06 PM, Joe Perches wrote: On Thu, 2017-01-12 at 21:02 -0800, Alexander Loktionov wrote: From: David VomLehn <voml...@texas.net> Patches to create the make and configu

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

On 01/14/2017 10:48 AM, Florian Fainelli wrote: On 01/14/2017 10:42 AM, David VomLehn wrote: Yes, we did have it that way at one point. But...there is also the kernel philosophy of not putting in something for future expansion; you can always do it later... Honestly, I've vacillated

Re: [PATCH v5 01/13] net: ethernet: aquantia: Make and configuration files.

, Alexander Loktionov wrote: From: David VomLehn <voml...@texas.net> Patches to create the make and configuration files. Signed-off-by: Alexander Loktionov <alexander.loktio...@aquantia.com> Signed-off-by: Dmitrii Tarakanov <dmitrii.taraka...@aquantia.com> Signed-off-by: Pavel

Re: [PATCH v2 00/12] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

On 01/06/2017 01:02 PM, David Miller wrote: From: Alexander Loktionov Date: Fri, 6 Jan 2017 00:06:01 -0800 This series introduced the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v1: Initial version v2: o Make necessary

Re: [PATCH 05/12] Support for NIC-specific code

Responses inline. On 12/27/2016 09:21 PM, Rami Rosen wrote: Hi, David, Several nitpicks and comments, from a brief overview: The commented label //err_exit: should be removed +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c @@ -0,0 +1,993 @@ +//err_exit: +//err_exit: Shouldn't

Re: [PATCH 01/12] Make and configuration files.

On 12/27/2016 08:47 PM, Rami Rosen wrote: Hi, David, For the Makefile, you should follow the pattern which is common in Linux Kernel Ethernet drivers, for example, http://lxr.free-electrons.com/source/drivers/net/ethernet/intel/i40e/Makefile or

[PATCH 03/12] Add ring spport code

Add code to support the firmware transmit and receive ring buffers. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 07/12] Vector operations

Add functions to manululate the vector of receive and transmit rings. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 10/12] Hardware interface and utility functions

Add functions to interface with the hardware and some utility functions. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 12/12] Receive side scaling

Add definitions that support receive side scaling. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_rss.h | 35

[PATCH 01/12] Make and configuration files.

Patches to create the make and configuration files. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/Kconfig | 9

[PATCH 04/12] Low-level hardware interfaces

Add definitions of functions that interface directly with the hardware. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 06/12] Atlantic A0 specific functions.

Add Atlantic A0-specific functions. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c | 934

[PATCH 09/12] Atlantic hardware abstraction layer

Add common functions for Atlantic hardware abstraction layer. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 02/12] Common functions and definitions

Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 05/12] Support for NIC-specific code

Add support for code specific to the Atlantic NIC. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c|

[PATCH 11/12] Ethtool support

Add the driver interfaces required for support by the ethtool utility. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn ---

[PATCH 08/12] PCI operations

Add functions that handle the PCI bus interface. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- .../net/ethernet/aquantia/atlantic/aq_pci_func.c |

[PATCH 01/12] Make and configuration files.

Patches to create the make and configuration files. Signed-off-by: Dmitrii Tarakanov Signed-off-by: Alexander Loktionov Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/atlantic/Kconfig | 9