. Shkandybin [EMAIL PROTECTED]
Cc: Ben Greear [EMAIL PROTECTED]
Cc: Paul Mackerras [EMAIL PROTECTED]
Cc: Michal Ostrowski [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.21-/drivers/net/ppp_generic.c 2.6.21/drivers/net/ppp_generic.c
--- 2.6.21-/drivers/net
On Fri, May 11, 2007 at 02:12:25PM -0700, Andrew Morton wrote:
On Fri, 11 May 2007 14:03:09 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 11 May 2007 16:57:19 -0400
applied
I was under the impression that this patch didn't
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 14 May 2007 08:07:00 +0200
After sending this patch I was a little confused, when next
lockdep warning report appeared, and I thought - since this is
not enough, this patch
On Mon, May 14, 2007 at 09:28:45AM +0200, Jarek Poplawski wrote:
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
...
For each unique netdev type, use a different locking class.
That will fix this forever, anything else is a situation specific
band-aid (but then again isn't
On Mon, May 14, 2007 at 02:18:31AM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 14 May 2007 09:28:45 +0200
Yes, this is very good idea, and I wonder, why you didn't try
this yourself (after my ignore).
Because you are a skilled programmer and you might
On Mon, May 14, 2007 at 10:08:29AM +0200, Jarek Poplawski wrote:
On Mon, May 14, 2007 at 09:28:45AM +0200, Jarek Poplawski wrote:
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
...
For each unique netdev type, use a different locking class.
That will fix this forever
On Sun, May 13, 2007 at 11:39:37PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Mon, 14 May 2007 08:07:00 +0200
After sending this patch I was a little confused, when next
lockdep warning report appeared, and I thought - since this is
not enough, this patch
On Tue, May 15, 2007 at 12:49:47PM +0400, Yuriy N. Shkandybin wrote:
I've patched 2.6.22-rc1 and there was no warnings from lock debugger.
Jura
Many thanks, Jura!
It seems reality is sometimes merciful...
On the other hand I wonder, how all this could stay so long:
a configuration similar
PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-/net/core/dev.c 2.6.22/net/core/dev.c
--- 2.6.22-/net/core/dev.c 2007-05-14 20:26:16.0 +0200
+++ 2.6.22/net/core/dev.c 2007-05-16 07:35:22.0 +0200
@@ -116,6 +116,7 @@
#include linux
On Tue, May 15, 2007 at 12:49:47PM +0400, Yuriy N. Shkandybin wrote:
I've patched 2.6.22-rc1 and there was no warnings from lock debugger.
So, you mean only this one patch - without previous vlan patch?
Very interesting...
Thanks once more,
Jarek P.
-
To unsubscribe from this list: send the
On Tue, May 15, 2007 at 10:47:25PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Wed, 16 May 2007 07:40:00 +0200
After initializing dev-_xmit_lock register_netdevice()
sets lockdep class according to dev-type.
Idea of this patch - by David Miller
On Tue, May 15, 2007 at 11:17:51PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Wed, 16 May 2007 08:17:32 +0200
BTW - I think some patch on vlan cannot do any harm (at
least like this previous of mine - with only ppp
considered), and maybe this all could
On Tue, May 29, 2007 at 12:56:28AM -0700, Andrew Morton wrote:
On Sat, 26 May 2007 17:40:12 +0200 Folkert van Heusden [EMAIL PROTECTED]
wrote:
When trying to remove the netconsole module, I got the following kernel
output after a while (couple of minutes iirc):
[525720.117293] BUG:
On Tue, Jun 12, 2007 at 01:02:33PM +0200, Jarek Poplawski wrote:
...
Of course such a problem should preferably be fixed by somebody who
knows the code (alas I don't know netconsole), to be sure all needed
cancels are still done after this change. I hope Jason's patch is
right but I'm a little
On 16-06-2007 23:35, Marcin .lusarz wrote:
hi
after upgrading kernel from 2.6.20 to 2.6.21.3 i'm experiencing really
strange problem - my _both_ network cards dies after random uptime -
sometimes it's a few minutes, sometimes hours, sometimes it does not
happen for a couple of days...
today
On Mon, Jun 18, 2007 at 08:10:00AM -0700, Stephen Hemminger wrote:
On Mon, 18 Jun 2007 13:08:49 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
...
It looks like skge driver enables different device than probbed.
Maybe you've something old/wrong about eth0/eth1 in /etc configs?
More likely
On Mon, Jun 18, 2007 at 08:10:00AM -0700, Stephen Hemminger wrote:
On Mon, 18 Jun 2007 13:08:49 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
On 16-06-2007 23:35, Marcin .lusarz wrote:
hi
after upgrading kernel from 2.6.20 to 2.6.21.3 i'm experiencing really
strange problem - my
On Fri, Jun 22, 2007 at 10:56:44AM +0200, Marcin Ślusarz wrote:
...
When I disable on-board network card in BIOS (controlled by skge)
ne2k-pci card is still locking up. So I think it's strictly ne2k-pci
card bug. I made some tests and I know how to reproduce it fast (on my
machine) - just make
On Tue, Jun 26, 2007 at 08:10:17AM +0200, Marcin Ślusarz wrote:
...
I reproduced it on minimal config:
...
Hm... This method is usable if you can find such minimal config
with which the bug cannot be reproduced. Then you can add more
until the bug is back. Of course, this takes time...
We know
Jean-Baptiste Vignaud [EMAIL PROTECTED],
marcin.slusarz [EMAIL PROTECTED],
shemminger [EMAIL PROTECTED]
Subject: Re: [PATCH] 8139cp dev-tx_timeout
References: [EMAIL PROTECTED] [EMAIL PROTECTED]
In-Reply-To: [EMAIL PROTECTED]
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
(second try! sorry)
On 27-06-2007 10:36, Jeff Garzik wrote:
[EMAIL PROTECTED] wrote:
Hello All,
We have been experimenting a couple of interface hangs with the 8139cp
driver. It appears that the tx buffer stops transmitting and never starts
up again in some yet unknown conditions. To be
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On 25-06-2007 11:28, Patrick McHardy wrote:
...
It is. This patch I had originally planned for 2.6.23 switches HTB
to the generic estimator, which shouldn't suffer from this.
BTW, maybe I look
On Wed, Jun 27, 2007 at 02:10:13PM +0200, Jarek Poplawski wrote:
...
- So if it's not only about kindness, feel free to do it
+ So if it's only about kindness, feel free to do it
Sorry!
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
is only initialized once.
[NET]: gen_estimator: fix locking and timer related bugs
As noticed by Jarek Poplawski [EMAIL PROTECTED], the timer removal in
gen_kill_estimator races with the timer function rearming the timer.
Additionally there are a few more related problems that seem
On Wed, Jun 27, 2007 at 04:53:48PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Wed, Jun 27, 2007 at 01:44:08PM +0200, Patrick McHardy wrote:
BTW, maybe I look at this too short, but is this del_timer()
in gen_kill_estimator() enough? I cannot see nothing against
a timer just
On Wed, Jun 27, 2007 at 05:25:45PM +0200, Patrick McHardy wrote:
...
Additionally there are a few more related problems that seem to be
relicts from the timer when the estimator was qdisc specific and
could rely on the rtnl or dev-qdisc_lock:
- the check whether the list is empty and a timer
On Thu, Jun 28, 2007 at 08:54:48AM +0200, Jarek Poplawski wrote:
...
@@ -215,10 +213,7 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
write_unlock_bh(est_lock);
kfree(est);
- killed
On Thu, Jun 28, 2007 at 02:23:36PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
@@ -202,7 +201,6 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
struct gen_estimator *est, **pest;
for (idx=0; idx = EST_MAX_INTERVAL; idx++) {
- int killed = 0
On Thu, Jun 28, 2007 at 02:24:55PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
BTW #2, I hope it's about some new policy, but I cannot see
any #ifdef CONFIG_NET_ESTIMATOR in this sch_htb patch.
One of my previous patches for 2.6.23 killed that option,
the code was always compiled
On Thu, Jun 28, 2007 at 02:55:51PM +0200, Patrick McHardy wrote:
...
Its overkill in that case. The concurrent additions and removals
can't happen.
Then the changelog needs one more change. Plus, maybe - btw,
1 line about this at the beginning of the file?
Jarek P.
-
To unsubscribe from this
On Thu, Jun 28, 2007 at 02:55:51PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Thu, Jun 28, 2007 at 02:23:36PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
@@ -202,7 +201,6 @@ void gen_kill_estimator(struct gnet_stats_basic
*bstats,
struct gen_estimator *est
On Fri, Jun 29, 2007 at 09:02:41AM +0200, Jarek Poplawski wrote:
...
same *bstats *rate_est more than once (or max twice if we let
to add, change remove them independently).
...but this doesn't look sensible at all!
So, maybe, if we would need something counted with two intervals
On Fri, Jun 29, 2007 at 10:50:20AM +0200, Jean-Baptiste Vignaud wrote:
Update...
I did 2 tests :
1) booted with option acpi=off
It booted correctly, i managed to get some load on one of the card
and after a while (10 minutes i guess) the Timeout occurs. Side effect,
at the same moment the
On Sun, Jul 01, 2007 at 09:35:58PM +0400, Oleg Nesterov wrote:
Jarek Poplawski wrote:
#1
Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
required a work function should always (unconditionally) rearm with
delay 0 - otherwise it would endlessly loop
.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-/net/core/netpoll.c 2.6.22-rc7/net/core/netpoll.c
--- 2.6.22-rc7-/net/core/netpoll.c 2007-07-02 09:03:27.0 +0200
+++ 2.6.22-rc7/net/core/netpoll.c 2007-07-02 09:32:34.0 +0200
@@ -72,8 +72,7 @@ static
from netpoll_cleanup().
PS: This patch was prepared on 2.6.22-rc7 with my other today's patch:
netconsole: fix soft lockup ...
Noticed-by: Oleg Nesterov [EMAIL PROTECTED]
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-plus-revert1-/net/core/netpoll.c
2.6.22-rc7-plus
On Mon, Jul 02, 2007 at 01:24:08PM +0400, Oleg Nesterov wrote:
On 07/02, Jarek Poplawski wrote:
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -72,7 +72,8 @@ static void queue_process(struct work_struct *work)
netif_tx_unlock(dev
On Mon, Jul 02, 2007 at 09:52:26AM +0200, Jarek Poplawski wrote:
From my recent patch:
#1
Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work()
required a work function should always (unconditionally) rearm with
delay 0 - otherwise it would endlessly
On Tue, Jul 03, 2007 at 11:47:18PM -0700, David Miller wrote:
...
I plan to apply this patch, don't worry about it :)
Now I'm really worried! Don't you evere sleep?
Good night,
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On Wed, Jul 04, 2007 at 08:41:59AM +0200, Jarek Poplawski wrote:
...
They were done on your request but it looks like Andrew
is waiting on something...
Andrew,
This time I'm not sorry for my English because I've just
found I could speak Chiefly Midland and Southern U.S..
Jarek P
On 21-06-2007 12:58, Mark Hannessen wrote:
Hi list,
I have some trouble getting my network card to run.
when I run dmesg I can clearly see it being detected
eth0: VIA Rhine II at 0xee006000, 00:e0:c5:54:88:a8, IRQ 11.
eth0: MII PHY found at address 1, status 0x786d advertising 05e1 Link
As noticed by Jarek Poplawski [EMAIL PROTECTED], the timer removal in
gen_kill_estimator races with the timer function rearming the timer.
Check whether the timer list is empty before rearming the timer
in the timer function to fix this.
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Acked
It looks like a timer function can be running and rearm
the timer after removing a ipv6 module.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-/net/ipv6/addrconf.c 2.6.22-rc7/net/ipv6/addrconf.c
--- 2.6.22-rc7-/net/ipv6/addrconf.c 2007-07-02 09:03:29.0
was prepared on 2.6.22-rc7 with my neighbouring
PATCH 1/2, but they could be applied independently too.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp 2.6.22-rc7-1_2/net/ipv6/addrconf.c 2.6.22-rc7-2_2/net/ipv6/addrconf.c
--- 2.6.22-rc7-1_2/net/ipv6/addrconf.c 2007-07-05 12:33
On 05-07-2007 12:08, Andi Kleen wrote:
...
The traditional standpoint was that having your own large skb pools
is not recommended because you won't interact well with the
rest of the system running low on memory and you tieing up
memory.
Essentially you would recreate all the problems
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
private allocations. Woudn't this save some
On Thu, Jul 05, 2007 at 02:37:40PM -0700, David Miller wrote:
From: Jarek Poplawski [EMAIL PROTECTED]
Date: Thu, 5 Jul 2007 13:12:46 +0200
It looks like a timer function can be running and rearm
the timer after removing a ipv6 module.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED
On Thu, Jul 05, 2007 at 06:59:25PM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always managed to reproduce the problem
within half hour - so far it
- Forwarded message from Ranko Zivojnovic [EMAIL PROTECTED] -
Date: Thu, 05 Jul 2007 18:59:25 +0300
From: Ranko Zivojnovic [EMAIL PROTECTED]
Subject: Re: + gen_estimator-fix-locking-and-timer-related-bugs.patch added
to -mm tree
To: Jarek Poplawski [EMAIL PROTECTED]
Cc: [EMAIL
On Fri, Jul 06, 2007 at 08:14:20AM +0200, Jarek Poplawski wrote:
...
This new lockup bug you have just found needs some time
to figure out. BTW, I wonder if you had lockdep on
(CONFIG_PROVE_LOCKING or CONFIG_LOCK_ALLOC)?
Should be:
(CONFIG_PROVE_LOCKING or CONFIG_DEBUG_LOCK_ALLOC)?
Jarek P
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 18:59 +0300, Ranko Zivojnovic wrote:
On Thu, 2007-07-05 at 17:34 +0300, Ranko Zivojnovic wrote:
Anyhow - I am currently running 2.6.22-rc6-mm1 + sch_htb patch and
running a test script that always
On Thu, Jul 05, 2007 at 03:06:40PM +0200, Andi Kleen wrote:
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean their
private allocations. Woudn't this save some
On Thu, Jul 05, 2007 at 04:28:47PM +0400, Evgeniy Polyakov wrote:
Hi, Jarek.
On Thu, Jul 05, 2007 at 02:28:50PM +0200, Jarek Poplawski ([EMAIL PROTECTED])
wrote:
I wonder if it's very unsound to think about a one way list
of destructors. Of course, not owners could only clean
On Fri, Jul 06, 2007 at 11:08:35AM +0200, Jarek Poplawski wrote:
...
BSDs were sometimes recommended for specific jobs like mail etc.
but usually linux better fitted the needs. Especially well linux
appeared for an internet gateway/router/firewall/antispam thing,
and the main reasons were
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get that parameter out of the way - I will make the same
test on a real machine.
BTW, maybe it would be better to try with something more stable
On Sat, Jul 07, 2007 at 05:10:54PM +0200, Patrick McHardy wrote:
On Sat, 7 Jul 2007, Ranko Zivojnovic wrote:
On Fri, 2007-07-06 at 16:21 +0200, Patrick McHardy wrote:
There is at least one ABBA deadlock, est_timer does:
read_lock(est_lock)
spin_lock(e-stats_lock) (which is dev-queue_lock)
On Fri, Jul 06, 2007 at 04:16:18PM +0300, Ranko Zivojnovic wrote:
On Fri, 2007-07-06 at 14:47 +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 08:45:23AM +0200, Jarek Poplawski wrote:
On Fri, Jul 06, 2007 at 09:08:43AM +0300, Ranko Zivojnovic wrote:
...
In order to get
On 12-09-2006 00:04, Jeff Garzik wrote:
John W. Linville wrote:
...
Not too explicitly, but I think Andrew mentions it in The Perfect
Patch:
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
While you are looking, you might review Jeff's version of the same idea:
On Thu, Sep 14, 2006 at 10:25:32AM +0200, Jarek Poplawski wrote:
...
Attachments are discouraged, but some corporate mail systems
provide no other way to send patches.
I thought they didn't read this but now I understand for whom
Mozilla Firefox is breaking all those lines with no mercy
On 22-09-2006 00:37, Andrew Morton wrote:
Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
CONFIG_BRIDGE_NETFILTER. Because brnf_deferred_hooks is defined in
net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c.
Or something else ;)
...
I am unsure of
On Fri, Sep 22, 2006 at 10:41:08AM +0200, Jarek Poplawski wrote:
On 22-09-2006 00:37, Andrew Morton wrote:
Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
CONFIG_BRIDGE_NETFILTER. Because brnf_deferred_hooks is defined in
net/bridge/br_netfilter.c and is referred to in net
Sorry linux-kernel - it should go to netdev.
On 22-09-2006 10:03, Jarek Poplawski wrote:
On 22-09-2006 00:37, Andrew Morton wrote:
Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon
CONFIG_BRIDGE_NETFILTER. Because brnf_deferred_hooks is defined in
net/bridge/br_netfilter.c
On Fri, Sep 22, 2006 at 11:27:31AM +0200, Jarek Poplawski wrote:
...
There is CONFIG_BRIDGE=m and this is the source of a problem:
config shouldn't allow for:
CONFIG_NETFILTER_BRIDGE=y
CONFIG_NETFILTER_XT_MATCH_PHYSDEV=y
So here is a patch proposal.
Jarek P.
diff -Nurp linux-2.6.18
On Fri, Sep 22, 2006 at 12:15:43PM +0200, Patrick McHardy wrote:
...
We should fix the physdev dependencies since this is what is causing
problems.
...
config NETFILTER_XT_MATCH_PHYSDEV
tristate 'physdev match support'
- depends on NETFILTER_XTABLES BRIDGE_NETFILTER
+ depends
On Fri, Sep 22, 2006 at 12:54:42PM +0200, Patrick McHardy wrote:
Jarek Poplawski wrote:
On Fri, Sep 22, 2006 at 12:15:43PM +0200, Patrick McHardy wrote:
...
We should fix the physdev dependencies since this is what is causing
problems.
...
config NETFILTER_XT_MATCH_PHYSDEV
On 24-09-2006 23:29, Dave Jones wrote:
=
[ INFO: inconsistent lock state ]
-
inconsistent {softirq-on-R} - {in-softirq-W} usage.
swapper/0 [HC0[0]:SC1[2]:HE1:SE0] takes:
(police_lock){-+--}, at: [f8d304fd]
On 25-09-2006 14:47, jamal wrote:
On Mon, 2006-25-09 at 14:43 +0200, Jarek Poplawski wrote:
It's probably 2.6.18 and should change a little now (git4) but
IMHO main problem stays: it looks tcf_act_police_locate in
act_police.c was preempted in read_lock (tcf_police_lookup)
- now the same
On Tue, Sep 26, 2006 at 05:20:34PM -0400, Dave Jones wrote:
On Tue, Sep 26, 2006 at 06:15:21PM +0200, Patrick McHardy wrote:
Patrick McHardy wrote:
jamal wrote:
Yes, that looks plausible. Can you try making those changes and see if
the warning is gone?
I think this
On Wed, Sep 27, 2006 at 02:07:04PM +0200, Patrick McHardy wrote:
Dave Jones wrote:
With this patch, I get no lockdep warnings, but the machine locks up
completely.
I hooked up a serial console, and found this..
u32 classifier
Performance counters on
input device check
On Wed, Sep 27, 2006 at 04:53:04PM -0700, David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Wed, 27 Sep 2006 14:07:04 +0200
...
Although the HTB bug is post-2.6.18, the other issue has been
around for a long time.
Thus I'll need to submit the second patch to -stable, but I
On Thu, Sep 28, 2006 at 02:17:51PM +0200, Patrick McHardy wrote:
[My mail provider is down, so responding manually]
Jarek Poplawski wrote:
[NET_SCHED]: Fix fallout from dev-qdisc RCU change
Sorry again but I can't abstain from some doubts:
...
diff --git a/net/core/dev.c b/net
On Thu, Sep 28, 2006 at 07:20:00AM -0700, Stephen Hemminger wrote:
On Thu, 28 Sep 2006 15:13:01 +0200
Jarek Poplawski [EMAIL PROTECTED] wrote:
On Thu, Sep 28, 2006 at 02:17:51PM +0200, Patrick McHardy wrote:
[My mail provider is down, so responding manually]
Jarek Poplawski wrote
On 30-09-2006 21:23, Ismail Donmez wrote:
Hi,
With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE
changed behaviour so it returns false when the node is empty as expected.
...
- if (!RB_EMPTY_NODE(rb)) {
+ if (RB_EMPTY_NODE(rb)) {
Maybe you have some kind of
On Mon, Oct 02, 2006 at 01:15:55PM +0200, Jarek Poplawski wrote:
...
instead of:
+ if (RB_EMPTY_NODE(rb))
should be:
+ if (RB_EMPTY_NODE(node))
Jarek P.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info
On Mon, Oct 02, 2006 at 04:49:38PM +0300, Ismail Donmez wrote:
02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski şunlar?? yazm??şt??:
On 30-09-2006 21:23, Ismail Donmez wrote:
Hi,
With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE
changed behaviour so
On Tue, Oct 03, 2006 at 12:28:32PM +0200, Jens Axboe wrote:
...
I don't see any missed changes.
And you are right!
I've checked the link from the first message of this thread
and now I see it's not current enough.
I'm sorry for this false alarm.
Jarek P.
-
To unsubscribe from this list: send
On Thu, Oct 05, 2006 at 01:52:19PM -0700, Randy Dunlap wrote:
On Thu, 14 Sep 2006 10:29:30 +0200 Jarek Poplawski wrote:
On Thu, Sep 14, 2006 at 10:25:32AM +0200, Jarek Poplawski wrote:
...
Attachments are discouraged, but some corporate mail systems
provide no other way to send
On Fri, Oct 06, 2006 at 07:57:32AM +0200, Jarek Poplawski wrote:
On Thu, Oct 05, 2006 at 01:52:19PM -0700, Randy Dunlap wrote:
On Thu, 14 Sep 2006 10:29:30 +0200 Jarek Poplawski wrote:
On Thu, Sep 14, 2006 at 10:25:32AM +0200, Jarek Poplawski wrote:
...
Mozilla Firefox is breaking all
On Fri, Oct 06, 2006 at 07:57:32AM +0200, Jarek Poplawski wrote:
On Thu, Oct 05, 2006 at 01:52:19PM -0700, Randy Dunlap wrote:
...
see http://mbligh.org/linuxdocs/Email/Clients/Thunderbird
...
dangerous feature of Thunderbird - you never could be sure
how a message will look because
On 11-10-2006 01:26, Ronghua Zhang wrote:
...
The reason I asked this is that I saw the following code in forthdeth
drvier:
#define NV_TX2_TSO_MAX_SHIFT) 14
/* add fragments to entries count */
for (i = 0; i fragments; i++) {
entries += (skb_shinfo(skb)-frags[i].size
On 09-10-2006 12:55, Shaun Kemp wrote:
...
An interface (+ connected IP network) which loses its IF_RUNNING flag (ie
unusable for routing) persists in the routing table as a kernel route.
Thus rather than responding to a dynamically announced route to this
connected network (the connected
On 07-10-2006 02:22, Andrew Morton wrote:
On Fri, 6 Oct 2006 17:18:13 -0700
[EMAIL PROTECTED] wrote:
http://bugzilla.kernel.org/show_bug.cgi?id=7278
Summary: forcedeth slowed down by traffic shaping
Kernel Version: 2.6.16
Status: NEW
Severity: normal
On Fri, Oct 13, 2006 at 05:24:39PM +0100, David Johnson wrote:
On Friday 13 October 2006 14:06, Jarek Poplawski wrote:
Probably - but only with networking. So I'd try with this debugging
like in my first reply plus maybe 2.6.19-rc1 (e1000 - btw. I hope
this other tested card was different
On Mon, Oct 16, 2006 at 03:32:38PM +0100, David Johnson wrote:
...
I've found the culprit - CPU Frequency Scaling.
With it enabled I get the reboots, with it disabled I don't. That's the same
with every kernel version I've tried (2.6.19-rc1+rc2, 2.6.17.13 Centos'
2.6.9) The system was using
On 17-10-2006 00:04, Greg KH wrote:
...
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index dfb300b..0f42544 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -197,7 +197,7 @@ static int basic_change(struct tcf_proto
if (handle)
f-handle =
.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc1-/net/ipv4/igmp.c linux-2.6.20-rc1/net/ipv4/igmp.c
--- linux-2.6.20-rc1-/net/ipv4/igmp.c 2006-12-16 20:37:18.0 +0100
+++ linux-2.6.20-rc1/net/ipv4/igmp.c2006-12-21 22:57:30.0 +0100
@@ -727,7 +727,7
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote:
On 20-12-2006 03:13, Ben Greear wrote:
This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in
active use.
From the backtrace, I am thinking this might be a generic problem,
however.
Any ideas about
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote:
[PATCH] igmp: spin_lock_bh in timer
igmp_timer_expire() uses spin_lock(im-lock)
but this lock is also taken by other igmp timers,
so it should be changed to bh version.
... but according to theory this doesn't matter.
I
On Fri, Dec 22, 2006 at 10:16:30PM +1100, Herbert Xu wrote:
Jarek Poplawski [EMAIL PROTECTED] wrote:
[PATCH] igmp: spin_lock_bh in timer
igmp_timer_expire() uses spin_lock(im-lock)
but this lock is also taken by other igmp timers,
so it should be changed to bh version.
When you're
On Fri, Dec 22, 2006 at 06:05:18AM -0800, Ben Greear wrote:
Jarek Poplawski wrote:
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote:
On 20-12-2006 03:13, Ben Greear wrote:
This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in
active use.
From the backtrace, I
On Wed, Dec 27, 2006 at 08:16:10AM -0800, Ben Greear wrote:
...
The system hangs and does not recover (well, a few processes
continue on the other processor for a few minutes before they
too deadlock...)
I am guessing this problem has been around for a while, but it
is only triggered when
() added in 2 places.
Signed-off-by: Jarek Poplawski [EMAIL PROTECTED]
---
diff -Nurp linux-2.6.20-rc2-/net/tipc/port.c linux-2.6.20-rc2/net/tipc/port.c
--- linux-2.6.20-rc2-/net/tipc/port.c 2006-11-29 22:57:37.0 +0100
+++ linux-2.6.20-rc2/net/tipc/port.c2006-12-28 11:05:17.0 +0100
On Wed, Dec 27, 2006 at 08:16:10AM -0800, Ben Greear wrote:
Jarek Poplawski wrote:
On Fri, Dec 22, 2006 at 06:05:18AM -0800, Ben Greear wrote:
Jarek Poplawski wrote:
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote:
On 20-12-2006 03:13, Ben Greear wrote:
This is from 2.6.18.2
On Mon, Jan 01, 2007 at 09:00:05PM -0800, Ben Greear wrote:
I finally had time to look through the code in this backtrace in
detail. I think it *could*
be a race between ip_rcv and inetdev_init, but I am not certain. Other
than that, I'm real
low on ideas. I found a few more stack trace
On Tue, Jan 02, 2007 at 08:39:09AM +0100, Jarek Poplawski wrote:
...
It is hard to say what kind of bug to expect
because at the same time other net_rx_action
with the same vlan dev could take place on
other processor and this inetdev_init could
do more.
Sorry! inetdev_init couldn't do more
On Tue, Jan 02, 2007 at 09:23:02AM +0100, Jarek Poplawski wrote:
On Tue, Jan 02, 2007 at 08:39:09AM +0100, Jarek Poplawski wrote:
...
The main thing is the possibility of processing
skb with not entirely open source dev which isn't
expected (and checked) by receive functions.
I think
On 02-01-2007 08:51, David Miller wrote:
From: Mariusz Kozlowski [EMAIL PROTECTED]
Date: Tue, 2 Jan 2007 00:55:51 +0100
On error we should start freeing resources at [i-1] not [i-2].
Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
Patch applied, thanks Mariusz.
diff -upr
On Tue, Jan 02, 2007 at 03:35:39PM -0800, David Stevens wrote:
I've looked at this a little too -- it'd be nice to know who holds
the write lock.
If you mean mc_list_lock - probably nobody - it's
not initialized (so the timers) for this in_device
and rtnl mutex is preempted by irq.
Actually I
1 - 100 of 612 matches
Mail list logo
