Fri, Apr 24, 2015 at 07:28:05PM CEST, t...@herbertland.com wrote:
Hi Jiri,
Thanks for this work, I think it's a good direction! Some comments below...
On Fri, Apr 24, 2015 at 8:51 AM, Jiri Pirko j...@resnulli.us wrote:
...
enum flow_dissector_key_id {
FLOW_DISSECTOR_KEY_BASIC
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 1d4c54d..6a02b26 100644
--- a/net/core/flow_dissector.c
+++ b/net/core
.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
v3-v4:
- renamed to flower and remove all references to OpenFlow
- removed internal classifier and used skb_flow_dissect instead
v2-v3:
- prepare masted key for faster matching
- use one mask per one cls_of_head as suggested by Thomas Graf
- Thomas Graf
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 13 +
net/core/flow_dissector.c| 12
2 files changed, 25 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 7c9e84c..1fa625b 100644
--- a/include
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/bonding/bond_main.c| 18 +--
drivers/net/ethernet/cisco/enic/enic_clsf.c| 27 ++--
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 10 +-
drivers/net/hyperv/netvsc_drv.c| 8 +-
include/linux
add couple of empty lines on the way.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/ethernet/cisco/enic/enic_clsf.c | 2 +-
include/linux/skbuff.h | 2 +-
include/net/flow_dissector.h| 53
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 32a7997..b67ce84 100644
--- a/include/net/flow_dissector.h
+++ b/include/net/flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 9c12692..5213d73 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/ethernet/cisco/enic/enic_clsf.c| 4 ++--
drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
include/net/flow_dissector.h | 9 ++---
include/net/ip.h | 4 ++--
include/net/ipv6
Introduce dissector infrastructure which allows user to specify which
parts of skb he wants to dissect.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 61
net/core/flow_dissector.c| 48
So far, only hashes made out of ipv6 addresses could be dissected. This
patch introduces support for dissection of full ipv6 addresses.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 13 +
net/core/flow_dissector.c| 29
next to its user. No relation to flow_dissector so it makes no sense to
have it in flow_dissector.c
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/dev.c| 78 +++
net/core/flow_dissector.c | 78
__skb_tx_hash function has no relation to flow_dissect so just muve it
to skbuff.c (it is declared in skbuff.h)
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 28
net/core/skbuff.c | 28
2 files changed
Since these functions are defined in flow_dissector.c, move header
declarations from skbuff.h into flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/skbuff.h | 4
include/net/flow_dissector.h | 3 +++
net/core/filter.c| 1 +
net/ethernet/eth.c
commit 56193d1bce (net: Add function for parsing the header length out
of linear ethernet frames) added this function declaration but it is
defined nowhere.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include
that this dissector can be also eventually used by openvswitch code.
Also, I plan to get rid of *skb_flow_get_ports(export) and *__skb_get_poff as
their functionality can be now implemented by skb_flow_dissect as well.
Ideas, comments?
Jiri Pirko (15):
net: change name of flow_dissector header
Since the definition of the function is in flow_dissector.c, it makes
sense to have the declaration in flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/skbuff.h | 1 -
include/net/flow_dissector.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff
probably want to break
away from ndo_dflt_bridge_getlink() and build the netlink skb directly in
the switchdev code.
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
Mon, May 11, 2015 at 02:08:34PM CEST, j...@mojatatu.com wrote:
On 05/09/15 09:10, Jiri Pirko wrote:
This patch introduces a flow-based filter. So far, the very essential
packet fields are supported.
This patch is only the first step. There is a lot of potential performance
improvements possible
Sun, May 10, 2015 at 06:48:01PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Rocker, bonding and team and switch over to the new
switchdev_port_bridge_dellink to avoid duplicating code in each driver.
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j
-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Introduce dissector infrastructure which allows user to specify which
parts of skb he wants to dissect.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 61
net/core/flow_dissector.c| 48
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 13 +
net/core/flow_dissector.c| 12
2 files changed, 25 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 586b123..5eac987 100644
--- a/include
add couple of empty lines on the way.
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/bonding/bond_main.c | 2 +-
drivers/net/ethernet/cisco/enic/enic_clsf.c | 2 +-
include/linux/skbuff.h | 2 +-
include/net/flow_dissector.h| 68
with new
behaviour. I tend to like it more.
Maybe you can include del part into this patch and mark is clearly as a
revert.
anyway:
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/net/flow_dissector.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 0c8d406..1add891 100644
--- a/include/net/flow_dissector.h
+++ b/include/net/flow_dissector.h
Since the definition of the function is in flow_dissector.c, it makes
sense to have the declaration in flow_dissector.h
Signed-off-by: Jiri Pirko j...@resnulli.us
---
include/linux/skbuff.h | 1 -
include/net/flow_dissector.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff
Mon, May 11, 2015 at 05:55:11PM CEST, alexander.h.du...@redhat.com wrote:
On 05/09/2015 06:10 AM, Jiri Pirko wrote:
__skb_tx_hash function has no relation to flow_dissect so just muve it
to skbuff.c (it is declared in skbuff.h)
Signed-off-by: Jiri Pirko j...@resnulli.us
Minor nit, move
Tue, May 12, 2015 at 06:10:56PM CEST, nicolas.dich...@6wind.com wrote:
Le 12/05/2015 17:58, Jiri Pirko a écrit :
Tue, May 12, 2015 at 05:17:45PM CEST, nicolas.dich...@6wind.com wrote:
[snip]
First, nobody seems to care about NETDEV_CHANGEINFODATA (commit
d4261e565000 says that it was put only
Wed, Apr 15, 2015 at 08:42:12PM CEST, da...@davemloft.net wrote:
From: Jiri Pirko j...@resnulli.us
Date: Wed, 15 Apr 2015 20:38:15 +0200
Wed, Apr 15, 2015 at 07:54:56PM CEST, go...@cumulusnetworks.com wrote:
On Mon, Apr 13, 2015 at 11:25:02PM +0200, Jiri Pirko wrote:
Turned out that switchdev
Wed, Apr 15, 2015 at 07:54:56PM CEST, go...@cumulusnetworks.com wrote:
On Mon, Apr 13, 2015 at 11:25:02PM +0200, Jiri Pirko wrote:
Turned out that switchdev sticks. So just unify all releated terms to
use this prefix.
Jiri Pirko (2):
switchdev: s/netdev_switch_/switchdev_/ and
s
Good catch.
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
transaction model)
Acked-by: Scott Feldman sfel...@gmail.com
Signed-off-by: Simon Horman simon.hor...@netronome.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Wed, May 20, 2015 at 10:46:26AM CEST, simon.hor...@netronome.com wrote:
On Wed, May 20, 2015 at 05:36:06PM +0900, Toshiaki Makita wrote:
On 2015/05/20 16:48, Simon Horman wrote:
On Wed, May 20, 2015 at 03:15:23PM +0900, Toshiaki Makita wrote:
On 2015/05/20 14:48, Simon Horman wrote:
...
, SWITCHDEV_TRANS_NONE,
-flags, ip_addr, n-ha);
+ kfree(work);
It should be kfree(nw)
I know it is the same, but looks more correct.
Other than this, this looks good to me
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line
Thu, Jun 04, 2015 at 05:43:40AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
Thu, Jun 04, 2015 at 05:43:41AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
Thu, Jun 04, 2015 at 05:43:42AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
references to ipv4_fib ops and replace with details
on SWITCHDEV_PORT_IPV4_FIB object.
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
-EOPNOTSUPP.
(This is a follow-up patch for 7d4f8d8.)
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
Fixes: 8793d0a664a8 (switchdev: add new switchdev_port_bridge_getlink)
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev
Thu, Jun 25, 2015 at 03:33:31PM CEST, da...@davemloft.net wrote:
From: Geert Uytterhoeven ge...@linux-m68k.org
Date: Thu, 25 Jun 2015 15:10:32 +0200
net/core/flow_dissector.c: In function ‘__skb_flow_dissect’:
net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized
in
Tue, Jun 23, 2015 at 07:18:49PM CEST, vivien.dide...@savoirfairelinux.com wrote:
This patch adds the glue between DSA and switchdev operations to add,
delete and dump SWITCHDEV_OBJ_PORT_VLAN objects.
This is a first step to link the bridge vlan command with hardware
entries for DSA compatible
Tue, Jun 23, 2015 at 09:52:10AM CEST, gi...@benyossef.com wrote:
Use the correct unregister function matching the register
function on the error path.
Signed-off-by: Gilad Ben-Yossef gi...@benyossef.com
CC: Gilad Ben-Yossef gil...@ezchip.com
CC: Scott Feldman sfel...@gmail.com
CC: Jiri Pirko j
Tue, Jun 16, 2015 at 06:47:47PM CEST, sfel...@gmail.com wrote:
On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.net wrote:
From: sfel...@gmail.com
Date: Sat, 13 Jun 2015 11:04:26 -0700
The switchdev port driver must do
() to netdev_err since this is a normal error path and
does not warrant the use of BUG_ON(), which is reserved for unrecoverable
errs.
Signed-off-by: Scott Feldman sfel...@gmail.com
Reported-by: Brenden Blanco bbla...@plumgrid.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list
Sat, Jun 13, 2015 at 08:04:27PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Just before queuing skb for xmit on port, check if skb has been marked by
switchdev port driver as already fordwarded by device. If so, drop skb. A
non-zero skb-fwd_mark field is set by the
Sat, Jun 13, 2015 at 08:04:29PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
If device flags ingress packet as fwd offload, mark the skb-fwd_mark
using the ingress port's dev-fwd_mark. This will be the hint to the
kernel that this packet has already been forwarded by
Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device
and maybe even unique for a sub-set of ports within device, so add
switchdev helper function to generate unique marks based
to be listed in the
dump.
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Wed, Jun 17, 2015 at 01:53:56AM CEST, sfel...@gmail.com wrote:
On Tue, Jun 16, 2015 at 2:11 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Jun 16, 2015 at 06:47:47PM CEST, sfel...@gmail.com wrote:
On Mon, Jun 15, 2015 at 11:04 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Jun 16, 2015 at 01:25:51AM
ports when stopping.
Signed-off-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tue, Jun 16, 2015 at 01:25:51AM CEST, da...@davemloft.net wrote:
From: sfel...@gmail.com
Date: Sat, 13 Jun 2015 11:04:26 -0700
The switchdev port driver must do two things:
1) Generate a fwd_mark for each switch port, using some unique key of the
switch device (and optionally port). This
Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote:
On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman sfel...@gmail.com wrote:
On Wed, Jun 10, 2015 at 2:25 PM, David Ahern dsah...@gmail.com wrote:
On 6/10/15 2:56 PM, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Fix
Sun, Jun 14, 2015 at 07:50:13PM CEST, sfel...@gmail.com wrote:
On Sat, Jun 13, 2015 at 11:56 PM, Jiri Pirko j...@resnulli.us wrote:
Sat, Jun 13, 2015 at 08:04:28PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique
Sun, Jun 14, 2015 at 08:00:11PM CEST, sfel...@gmail.com wrote:
On Sun, Jun 14, 2015 at 12:02 AM, Jiri Pirko j...@resnulli.us wrote:
Sat, Jun 13, 2015 at 08:04:29PM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
If device flags ingress packet as fwd offload, mark the skb
Thu, May 28, 2015 at 05:35:05PM CEST, john.fastab...@gmail.com wrote:
On 05/28/2015 02:42 AM, Jiri Pirko wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems where you can offload
Thu, May 21, 2015 at 07:46:54AM CEST, sfel...@gmail.com wrote:
On Tue, May 19, 2015 at 1:28 PM, David Miller da...@davemloft.net wrote:
From: Andy Gospodarek go...@cumulusnetworks.com
Date: Tue, 19 May 2015 15:47:32 -0400
Are you actually saying that if users complain loudly enough about
the
Thu, May 28, 2015 at 05:40:11PM CEST, sfel...@gmail.com wrote:
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems
Fri, May 29, 2015 at 05:12:35PM CEST, sfel...@gmail.com wrote:
On Thu, May 28, 2015 at 2:42 AM, Jiri Pirko j...@resnulli.us wrote:
Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems
Fri, May 29, 2015 at 05:39:46PM CEST, sfel...@gmail.com wrote:
On Fri, May 29, 2015 at 12:50 AM, Jiri Pirko j...@resnulli.us wrote:
Thu, May 21, 2015 at 07:46:54AM CEST, sfel...@gmail.com wrote:
On Tue, May 19, 2015 at 1:28 PM, David Miller da...@davemloft.net wrote:
From: Andy Gospodarek go
Thu, May 28, 2015 at 05:23:17AM CEST, simon.hor...@netronome.com wrote:
The rocker (switch) of a rocker_port may be trivially obtained from
the latter it seems cleaner not to pass the former to a function when
the latter is being passed anyway.
I don't understand reason for this patch. I like it
Mon, May 18, 2015 at 10:19:16PM CEST, da...@davemloft.net wrote:
From: Roopa Prabhu ro...@cumulusnetworks.com
Date: Sun, 17 May 2015 16:42:05 -0700
On most systems where you can offload routes to hardware,
doing routing in software is not an option (the cpu limitations
make routing impossible
Thu, Jun 11, 2015 at 05:03:21PM CEST, sfel...@gmail.com wrote:
On Wed, Jun 10, 2015 at 11:16 PM, Jiri Pirko j...@resnulli.us wrote:
Thu, Jun 11, 2015 at 12:00:47AM CEST, sfel...@gmail.com wrote:
On Wed, Jun 10, 2015 at 2:47 PM, Scott Feldman sfel...@gmail.com wrote:
On Wed, Jun 10, 2015 at 2:25
Fri, May 22, 2015 at 02:11:40AM CEST, t...@herbertland.com wrote:
This patch adds full IPv6 addresses into flow_keys and uses them as
input to the flow hash function. The implementation supports either
IPv4 or IPv6 addresses in a union, and selector is used to determine
how may words to input to
Fri, May 22, 2015 at 02:11:41AM CEST, t...@herbertland.com wrote:
Add a new flow key for TIPC addresses.
Signed-off-by: Tom Herbert t...@herbertland.com
---
include/net/flow_dissector.h | 10 ++
net/core/flow_dissector.c| 20 ++--
2 files changed, 24 insertions(+), 6
Fri, May 22, 2015 at 02:11:38AM CEST, t...@herbertland.com wrote:
key_basic is set twice in __skb_flow_dissect which seems unnecessary.
Remove second one.
Signed-off-by: Tom Herbert t...@herbertland.com
I have the same patch in my queue :)
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe
Fri, May 22, 2015 at 02:11:37AM CEST, t...@herbertland.com wrote:
Add uapi define for MPLS over IP.
Signed-off-by: Tom Herbert t...@herbertland.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
Fri, May 22, 2015 at 02:11:36AM CEST, t...@herbertland.com wrote:
Do break when we see routing flag or a non-zero version number in GRE
header.
Signed-off-by: Tom Herbert t...@herbertland.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev
IPv6 addresses, VLAN, flow labels etc.
without needing to resort to xor'ing which makes for a poor hash.
Signed-off-by: Tom Herbert t...@herbertland.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord
This restored previous behaviour. If caller does not want ports to be
filled, we should not break.
Fixes: 06635a35d13d (flow_dissect: use programable dissector in
skb_flow_dissect and friends)
Signed-off-by: Jiri Pirko j...@resnulli.us
---
net/core/flow_dissector.c | 14 +++---
1 file
Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote:
In flow_dissector set the flow label in flow_keys for IPv6. This also
removes the shortcircuiting of flow dissection when a non-zero label
is present, the flow label can be considered to provide additional
entropy for a hash.
:
if (!skb_flow_dissector_uses_key(flow_dissector,
FLOW_DISSECTOR_KEY_IPV6_ADDRS))
break;
flow_label = .
killing flow_label label.
Other than that,
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from
Fri, May 22, 2015 at 02:11:46AM CEST, t...@herbertland.com wrote:
In flow dissector if an MPLS header contains an entropy label this is
saved in the new keyid field of flow_keys. The entropy label is
then represented in the flow hash function input.
Signed-off-by: Tom Herbert t...@herbertland.com
Acked-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Mon, May 25, 2015 at 07:28:36AM CEST, simon.hor...@netronome.com wrote:
Mark parameters and local variables as const where possible.
Signed-off-by: Simon Horman simon.hor...@netronome.com
Acked-by: Scott Feldman sfel...@gmail.com
Acked-by: Jiri Pirko j...@resnulli.us
--
To unsubscribe from
Fri, May 22, 2015 at 05:14:21PM CEST, t...@herbertland.com wrote:
On Fri, May 22, 2015 at 1:14 AM, Jiri Pirko j...@resnulli.us wrote:
Fri, May 22, 2015 at 02:11:44AM CEST, t...@herbertland.com wrote:
In flow_dissector set the flow label in flow_keys for IPv6. This also
removes the shortcircuiting
Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote:
On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
tree /sys/kernel/debug/rocker
/sys/kernel/debug/rocker
Tue, Aug 18, 2015 at 12:36:17AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
tree /sys/kernel/debug/rocker
/sys/kernel/debug/rocker
└── 525400123501
├── fdb_tbl
├── internal_vlan_tbl
├── neigh_tbl
├── of_dpa_flow_tbl
└── of_dpa_group_tbl
1
Tue, Aug 18, 2015 at 09:21:15AM CEST, sfel...@gmail.com wrote:
On Mon, Aug 17, 2015 at 11:48 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Aug 18, 2015 at 08:14:48AM CEST, sfel...@gmail.com wrote:
On Mon, Aug 17, 2015 at 10:55 PM, Jiri Pirko j...@resnulli.us wrote:
Tue, Aug 18, 2015 at 12:36:17AM
\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Acked-by: Jiri Pirko j...@mellanox.com
--
To unsubscribe from this list: send the line unsubscribe netdev
From: Jiri Pirko j...@mellanox.com
Signed-off-by: Jiri Pirko j...@mellanox.com
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Elad Raz el...@mellanox.com
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 51 --
1 file changed, 48 insertions(+), 3
From: Jiri Pirko j...@mellanox.com
When transmit fails, it is an error, not a warning.
Do not warn when timeout happens as that is handled by a counter.
Signed-off-by: Jiri Pirko j...@mellanox.com
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Elad Raz el...@mellanox.com
From: Ido Schimmel ido...@mellanox.com
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Jiri Pirko j...@mellanox.com
Signed-off-by: Elad Raz el...@mellanox.com
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet
From: Jiri Pirko j...@mellanox.com
Ido Schimmel (1):
mlxsw: Remove duplicate included header
Jiri Pirko (2):
mlxsw: expose EMAD transactions statistics via debugfs
mlxsw: adjust log messages level in __mlxsw_emad_transmit
drivers/net/ethernet/mellanox/mlxsw/core.c | 60
Mon, Aug 17, 2015 at 05:32:06AM CEST, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
tree /sys/kernel/debug/rocker
/sys/kernel/debug/rocker
└── 525400123501
├── fdb_tbl
├── internal_vlan_tbl
├── neigh_tbl
├── of_dpa_flow_tbl
└── of_dpa_group_tbl
1
Mon, Jun 29, 2015 at 07:44:38AM CEST, neelugad...@gmail.com wrote:
Hi All,
Shall we expect these changes to be available in the upcoming 2.4 release?
or is it still in development?
Still in devel.
On Tue, Sep 16, 2014 at 9:28 PM, Jiri Pirko j...@resnulli.us wrote:
Mon, Sep 08, 2014
From: Jiri Pirko j...@mellanox.com
Add core components of Mellanox switch driver infrastructure.
Core infrastructure is designed so that it can be used by multiple
bus drivers (PCI now, I2C and SGMII are planned to be implemented
in the future). Multiple switch kind drivers can be registered
From: Jiri Pirko j...@mellanox.com
This patchset introduces Mellanox Technologies Switch driver infrastructure
and support for SwitchX-2 ASIC.
The driver is divided into 3 logical parts:
1) Bus - implements switch bus interface. Currently only PCI bus is
implemented, but more buses
From: Jiri Pirko j...@mellanox.com
Add PCI bus implementation for Mellanox Technologies Switch ASICs. This
includes firmware initialization, async queues manipulation and command
interface implementation.
Signed-off-by: Jiri Pirko j...@mellanox.com
Signed-off-by: Ido Schimmel ido...@mellanox.com
events generated by the device.
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Jiri Pirko j...@mellanox.com
Signed-off-by: Elad Raz el...@mellanox.com
Reviewed-by: Scott Feldman sfel...@gmail.com
---
v1-v2:
- removed trap_id param from rx_listener callback and
removed
From: Jiri Pirko j...@mellanox.com
Benefit from the previously introduced Mellanox Switch infrastructure and
add driver for SwitchX-2 ASIC. Note that this driver is very simple now.
It implements bare minimum for getting device to work on slow-path.
Fast-path offload functionality is going
From: Ido Schimmel ido...@mellanox.com
When removing a port's netdevice in 'rocker_remove_ports', we should
also free the allocated 'net_device' structure. Do that by calling
'free_netdev' after unregistering it.
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Jiri Pirko j
From: Ido Schimmel ido...@mellanox.com
rocker supports the transmission of scattered packets, so let the kernel
know about it by setting the NETIF_F_SG bit in the device's features.
Signed-off-by: Ido Schimmel ido...@mellanox.com
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net
Suggested-by: Scott Feldman sfel...@gmail.com
Signed-off-by: Jiri Pirko j...@resnulli.us
---
drivers/net/ethernet/rocker/rocker.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rocker/rocker.c
b/drivers/net/ethernet/rocker/rocker.c
index 730bdc0
Mon, Jul 27, 2015 at 08:17:22AM CEST, rami.ro...@intel.com wrote:
Hi, Jiri,
Keep on the good work!
The .func member of the mlxsw_rx_listener object has this prototype:
void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv);
Is the trap_id parameter needed ?
In the three use
Wed, Aug 05, 2015 at 07:31:30AM CEST, cw...@twopensource.com wrote:
On Tue, Aug 4, 2015 at 8:48 AM, Linus Torvalds
torva...@linux-foundation.org wrote:
Sorry for the spamming of random rtnetlink people, but I just resumed
my laptop at PDX, and networking was dead.
It looks like a deadlock on
I would expect better subject, perhaps something like:
fix array boundary in check_map_func_compatibility
Wed, Aug 12, 2015 at 09:39:34AM CEST, weich...@plumgrid.com wrote:
Wrong array boundary is used.
Fixes: 35578d798400 bpf: Implement function bpf_perf_event_read())
Cc: Kaixu Xia
'size_t'
[-Wformat=]
Signed-off-by: Fabio Estevam fabio.este...@freescale.com
Acked-by: Jiri Pirko j...@mellanox.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
1 - 100 of 4427 matches
Mail list logo
