[RFC] netfilter: cttimeout: remove VLA in ctnl_timeout_parse_policy

2018-03-06 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA and replace it with dynamic memory allocation. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/nfnetlink_cttimeout.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] configure: Verify libnftnl install is recent enough

2018-03-06 Thread Pablo Neira Ayuso
On Tue, Mar 06, 2018 at 02:39:26PM +1100, Duncan Roe wrote: > To get libnftnl/flowtable.h nftables now needs a newer libftnl than the latest > release. This temporary check advises the unwary of that. > This test can be removed once libnftnl 1.0.10 is released (and tested for). > > Signed-off-by:

Re: [RFC nft] tests: shell: autogenerate dump verification

2018-03-06 Thread Arturo Borrero Gonzalez
On 6 March 2018 at 11:47, Florian Westphal wrote: > Arturo Borrero Gonzalez wrote: >> On 5 March 2018 at 23:57, Laura Garcia Liebana wrote: >> >> > 141 files changed, 837 insertions(+), 526 deletions(-) >> >> Better place a new script as

Re: [RFC nft] tests: shell: autogenerate dump verification

2018-03-06 Thread Florian Westphal
Arturo Borrero Gonzalez wrote: > On 5 March 2018 at 23:57, Laura Garcia Liebana wrote: > > > 141 files changed, 837 insertions(+), 526 deletions(-) > > Better place a new script as a testcase, and all the required dump > files somewhere for it to read

Re: [RFC nft] tests: shell: autogenerate dump verification

2018-03-06 Thread Arturo Borrero Gonzalez
On 5 March 2018 at 23:57, Laura Garcia Liebana wrote: > 141 files changed, 837 insertions(+), 526 deletions(-) Better place a new script as a testcase, and all the required dump files somewhere for it to read them. Also, we have several testscases which are very long (we

Re: [PATCH] ipvs: use true and false for boolean values

2018-03-06 Thread Pablo Neira Ayuso
On Tue, Mar 06, 2018 at 09:02:08AM +0100, Simon Horman wrote: > On Mon, Mar 05, 2018 at 03:35:57PM -0600, Gustavo A. R. Silva wrote: > > Assign true or false to boolean variables instead of an integer value. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by:

Re: [PATCH nf-next] netfilter: x_tables: fix build with CONFIG_COMPAT=n

2018-03-06 Thread Pablo Neira Ayuso
On Tue, Mar 06, 2018 at 08:26:00AM +0100, Florian Westphal wrote: > I placed the helpers within CONFIG_COMPAT section, move them > outside. Applied, thanks Florian. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majord...@vger.kernel.org

Port triggering

2018-03-06 Thread Stéphane Veyret
Hi, I saw that patches have been written some years ago for port triggering in Netfilter, but no such feature is currently available in the kernel. Is there any reason for that? If I write and submit such a patch as Xtables-addons module, would it have chances to be accepted? Regards, -- Bien

Re: [PATCH] ipvs: use true and false for boolean values

2018-03-06 Thread Simon Horman
On Mon, Mar 05, 2018 at 03:35:57PM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Signed-off-by: Simon Horman