[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Tobias Klauser]

On 2016-08-08 at 16:31:11 +0200, Vadim Kochan  wrote:
> On Mon, Aug 8, 2016 at 5:24 PM, Tobias Klauser  wrote:
> > On 2016-08-06 at 11:59:05 +0200, Vadim Kochan  wrote:
> >> On Sat, Aug 6, 2016 at 12:41 PM, Tobias Klauser  
> >> wrote:
> >> > On 2016-08-05 at 22:51:54 +0200, Vadim Kochan  wrote:
> >> Yes, I understand, I said so because I really remember we talked about
> >> disabling of libnl support earier ago and you or Daniel pointed that
> >> it is better to have this dependency by default, this is how I
> >> remember this, I might be wrong, but anyway
> >> it simplifies build netsniff-ng/trafgen manually w/o searching libnl-
> >> packages on specific dist.
> >
> > I can't remember we talked about it, but that doesn't mean we didn't :)
> > In any case if we discussed a particular feature/patch/RFC/... before
> > and you patch is based on the previous discussion, please include a link
> > to the respective mailing list thread into the description. This may
> > help to remind us of past conversations ;)
> >
> > Thanks!
> 
> This is a link with our discussion (within libnl-route fix titled with
> "[PATCH] build: Check for libnl-route"), but I looked for this
> just now so I did not consider it while writing previous email, so I
> might be wrong for some conclusions):
> 
> https://groups.google.com/forum/?hl=en#!searchin/netsniff-ng/Check$20for$20libnl-route%7Csort:relevance/netsniff-ng/0Ws7ecy1H_Y/DIzprE4KBAAJ

Thanks for the link. I don't see detailled discussion of how this should
be implemented, just the general idea. And there, I think, we all agreed
that it would be fine as long as it doesn't introduce too much
additional complexity.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Vadim Kochan]

On Mon, Aug 8, 2016 at 5:24 PM, Tobias Klauser  wrote:
> On 2016-08-06 at 11:59:05 +0200, Vadim Kochan  wrote:
>> On Sat, Aug 6, 2016 at 12:41 PM, Tobias Klauser  wrote:
>> > On 2016-08-05 at 22:51:54 +0200, Vadim Kochan  wrote:
>> >> Hm,
>> >>
>> >> My version was to keep current strict dependency on libnl by default,
>> >> so if there is no libnl then
>> >> netsniff-ng & trafgen will be removed from build list, but make
>> >> possible to skip this
>> >> rule by --disable-libnl option. Now I am not sure there is a reason
>> >> for --disable-libnl as if there is no libnl
>> >> then netsniff-ng & trafgen will be added to build list, and will be
>> >> compiled w/o libnl dependency..
>> >
>> > Ok, but that intention of your patch wasn't really clear from the
>> > description, sorry.
>>
>> Yes, usually I put no so much description into patches.
>
> Please try to be as verbose as possible in patch descriptions (at least
> for non-trivial patches). The description is there to help others
> understand the rationale behind a patch (before applying it and
> especially afterwards e.g. when chasing bugs).
>
>> >> So does --disable-libnl makes sense ?
>> >
>> > If you have libnl-dev installed but want to compile netsniff-ng/trafgen
>> > without libnl support it still makes sense.
>> >
>> > IMO the current version is more in line with the behavior we already
>> > have for geoip and libz.
>> >
>> > Thanks
>> > Tobias
>>
>> Yes, I understand, I said so because I really remember we talked about
>> disabling of libnl support earier ago and you or Daniel pointed that
>> it is better to have this dependency by default, this is how I
>> remember this, I might be wrong, but anyway
>> it simplifies build netsniff-ng/trafgen manually w/o searching libnl-
>> packages on specific dist.
>
> I can't remember we talked about it, but that doesn't mean we didn't :)
> In any case if we discussed a particular feature/patch/RFC/... before
> and you patch is based on the previous discussion, please include a link
> to the respective mailing list thread into the description. This may
> help to remind us of past conversations ;)
>
> Thanks!

This is a link with our discussion (within libnl-route fix titled with
"[PATCH] build: Check for libnl-route"), but I looked for this
just now so I did not consider it while writing previous email, so I
might be wrong for some conclusions):

https://groups.google.com/forum/?hl=en#!searchin/netsniff-ng/Check$20for$20libnl-route%7Csort:relevance/netsniff-ng/0Ws7ecy1H_Y/DIzprE4KBAAJ

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Tobias Klauser]

On 2016-08-06 at 11:59:05 +0200, Vadim Kochan  wrote:
> On Sat, Aug 6, 2016 at 12:41 PM, Tobias Klauser  wrote:
> > On 2016-08-05 at 22:51:54 +0200, Vadim Kochan  wrote:
> >> Hm,
> >>
> >> My version was to keep current strict dependency on libnl by default,
> >> so if there is no libnl then
> >> netsniff-ng & trafgen will be removed from build list, but make
> >> possible to skip this
> >> rule by --disable-libnl option. Now I am not sure there is a reason
> >> for --disable-libnl as if there is no libnl
> >> then netsniff-ng & trafgen will be added to build list, and will be
> >> compiled w/o libnl dependency..
> >
> > Ok, but that intention of your patch wasn't really clear from the
> > description, sorry.
> 
> Yes, usually I put no so much description into patches.

Please try to be as verbose as possible in patch descriptions (at least
for non-trivial patches). The description is there to help others
understand the rationale behind a patch (before applying it and
especially afterwards e.g. when chasing bugs).

> >> So does --disable-libnl makes sense ?
> >
> > If you have libnl-dev installed but want to compile netsniff-ng/trafgen
> > without libnl support it still makes sense.
> >
> > IMO the current version is more in line with the behavior we already
> > have for geoip and libz.
> >
> > Thanks
> > Tobias
> 
> Yes, I understand, I said so because I really remember we talked about
> disabling of libnl support earier ago and you or Daniel pointed that
> it is better to have this dependency by default, this is how I
> remember this, I might be wrong, but anyway
> it simplifies build netsniff-ng/trafgen manually w/o searching libnl-
> packages on specific dist.

I can't remember we talked about it, but that doesn't mean we didn't :)
In any case if we discussed a particular feature/patch/RFC/... before
and you patch is based on the previous discussion, please include a link
to the respective mailing list thread into the description. This may
help to remind us of past conversations ;)

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Vadim Kochan]

On Sat, Aug 6, 2016 at 12:41 PM, Tobias Klauser  wrote:
> On 2016-08-05 at 22:51:54 +0200, Vadim Kochan  wrote:
>> Hm,
>>
>> My version was to keep current strict dependency on libnl by default,
>> so if there is no libnl then
>> netsniff-ng & trafgen will be removed from build list, but make
>> possible to skip this
>> rule by --disable-libnl option. Now I am not sure there is a reason
>> for --disable-libnl as if there is no libnl
>> then netsniff-ng & trafgen will be added to build list, and will be
>> compiled w/o libnl dependency..
>
> Ok, but that intention of your patch wasn't really clear from the
> description, sorry.

Yes, usually I put no so much description into patches.

>> So does --disable-libnl makes sense ?
>
> If you have libnl-dev installed but want to compile netsniff-ng/trafgen
> without libnl support it still makes sense.
>
> IMO the current version is more in line with the behavior we already
> have for geoip and libz.
>
> Thanks
> Tobias

Yes, I understand, I said so because I really remember we talked about
disabling of libnl support earier ago and you or Daniel pointed that
it is better to have this dependency by default, this is how I
remember this, I might be wrong, but anyway
it simplifies build netsniff-ng/trafgen manually w/o searching libnl-
packages on specific dist.

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Vadim Kochan]

Hm,

My version was to keep current strict dependency on libnl by default,
so if there is no libnl then
netsniff-ng & trafgen will be removed from build list, but make
possible to skip this
rule by --disable-libnl option. Now I am not sure there is a reason
for --disable-libnl as if there is no libnl
then netsniff-ng & trafgen will be added to build list, and will be
compiled w/o libnl dependency..

So does --disable-libnl makes sense ?

Regards,
Vadim Kochan

On Fri, Aug 5, 2016 at 12:31 PM, Vadim Kochan  wrote:
> Sorry for that copy'n'paste ...
>
> On Fri, Aug 5, 2016 at 12:29 PM, Tobias Klauser  wrote:
>> On 2016-08-04 at 18:30:20 +0200, Vadim Kochan  wrote:
>>> Add command line parsing function which allows to compile tools
>>> (trafgen, netsniff-ng) without libnl-xxx libraries.
>>
>> But it does in its current state not allow to compile
>> netsniff-ng/trafgen without libnl if libnl is not installed (i.e. not
>> found by check_libnl).
>>
>> I rewrote this patch to support this case and make it more in line with
>> the existing library checking/disabling.
>>
>> Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[netsniff-ng] Re: [PATCH v3 3/3] configure: Add option to compile tools without libnl dependency

[Tobias Klauser]

On 2016-08-04 at 18:30:20 +0200, Vadim Kochan  wrote:
> Add command line parsing function which allows to compile tools
> (trafgen, netsniff-ng) without libnl-xxx libraries.

But it does in its current state not allow to compile
netsniff-ng/trafgen without libnl if libnl is not installed (i.e. not
found by check_libnl).

I rewrote this patch to support this case and make it more in line with
the existing library checking/disabling.

Thanks!

-- 
You received this message because you are subscribed to the Google Groups 
"netsniff-ng" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to netsniff-ng+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.