Re: [PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-15 Thread Niels Möller
Dmitry Eremin-Solenikov writes: > I'll change the names t follow > gost_gc256b pattern, add documentation and submit v4. Excellent. Regards, /Niels -- Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677. Internet email is subject to wholesale government surveillance.

Re: [PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-15 Thread Dmitry Eremin-Solenikov
Please excuse me for top-posting. I'll change the names t follow gost_gc256b pattern, add documentation and submit v4. -- With best wishes Dmitry ср, 15 янв. 2020 г., 19:17 Niels Möller : > Dmitry Eremin-Solenikov writes: > > >> > +const struct ecc_curve *nettle_get_gc256b(void) > >> > +{ >

Re: [PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-15 Thread Niels Möller
Dmitry Eremin-Solenikov writes: >> > +const struct ecc_curve *nettle_get_gc256b(void) >> > +{ >> > + return &_nettle_gc256b; >> > +} >> >> Would it make sense to add "gost" to this name, in similar position as >> "secp" in other curves? > > I don't think so. Consider the names from "TLS

Re: [PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-12 Thread Dmitry Eremin-Solenikov
вс, 12 янв. 2020 г. в 23:45, Niels Möller : > > dbarysh...@gmail.com writes: > > > From: Dmitry Eremin-Solenikov > > > > Add support for GC256B curve ("TLS Supported Groups" registry, > > draft-smyshlyaev-tls12-gost-suites) also known as > > GostR3410-2001-CryptoPro-A and

Re: [PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-12 Thread Niels Möller
dbarysh...@gmail.com writes: > From: Dmitry Eremin-Solenikov > > Add support for GC256B curve ("TLS Supported Groups" registry, > draft-smyshlyaev-tls12-gost-suites) also known as > GostR3410-2001-CryptoPro-A and GostR3410-2001-CryptoPro-XchA (RFC 4357). Thanks. Some comments below: > ---

[PATCH v2 1/3] Add support for GOST GC256B curve

2020-01-11 Thread dbaryshkov
From: Dmitry Eremin-Solenikov Add support for GC256B curve ("TLS Supported Groups" registry, draft-smyshlyaev-tls12-gost-suites) also known as GostR3410-2001-CryptoPro-A and GostR3410-2001-CryptoPro-XchA (RFC 4357). Signed-off-by: Dmitry Eremin-Solenikov --- .gitignore | 1 +