Re: Deleting old AES api

2018-03-12 Thread Jeffrey Walton
On Mon, Mar 12, 2018 at 2:56 PM, Jeffrey Walton wrote: > On Mon, Mar 12, 2018 at 2:49 PM, Niels Möller wrote: >> Nikos Mavrogiannopoulos writes: >> >>> #ifdef __GNUC__ >>> # define _GNUTLS_GCC_VERSION (__GNUC__ * 1 + __GNUC_MINOR__

Re: Deleting old AES api

2018-03-12 Thread Jeffrey Walton
On Mon, Mar 12, 2018 at 2:49 PM, Niels Möller wrote: > Nikos Mavrogiannopoulos writes: > >> #ifdef __GNUC__ >> # define _GNUTLS_GCC_VERSION (__GNUC__ * 1 + __GNUC_MINOR__ * 100 + >> __GNUC_PATCHLEVEL__) >> >> # if _GNUTLS_GCC_VERSION >= 30100 >> #

Re: Deleting old AES api

2018-02-22 Thread Niels Möller
Nikos Mavrogiannopoulos writes: > How widely used are these macros? Searching debian code: > https://codesearch.debian.net/search?q=aes_set_encrypt_key=1=1 > > seems to show gnutls (in fips140 drbg code), stoken, qemu, rdup, > filezilla, pike, cmake, uanytun,

Re: Deleting old AES api (was: Re: What should nettle-3.5 be like?)

2018-02-22 Thread Nikos Mavrogiannopoulos
On Thu, 2018-02-22 at 13:51 +0300, Dmitry Eremin-Solenikov wrote: > Hello, > > 2018-02-22 13:41 GMT+03:00 Nikos Mavrogiannopoulos : > > On Thu, 2018-02-22 at 07:54 +0100, Niels Möller wrote: > > > ni...@lysator.liu.se (Niels Möller) writes: > > Thanks for bringing that up. I have

Re: Deleting old AES api (was: Re: What should nettle-3.5 be like?)

2018-02-22 Thread Dmitry Eremin-Solenikov
Hello, 2018-02-22 13:41 GMT+03:00 Nikos Mavrogiannopoulos : > On Thu, 2018-02-22 at 07:54 +0100, Niels Möller wrote: >> ni...@lysator.liu.se (Niels Möller) writes: > Thanks for bringing that up. I have a quick fix for that, although I no > longer have such systems for checking.

Re: Deleting old AES api (was: Re: What should nettle-3.5 be like?)

2018-02-22 Thread Nikos Mavrogiannopoulos
On Thu, 2018-02-22 at 07:54 +0100, Niels Möller wrote: > ni...@lysator.liu.se (Niels Möller) writes: > > > > 2. Delete the old aes_* interface, in favor of aes128_, aes192_* > > > and > > >aes256_*. > > > > I've now made a branch for this, delete-old-aes. > > And it seems building gnutls

Deleting old AES api (was: Re: What should nettle-3.5 be like?)

2018-02-21 Thread Niels Möller
ni...@lysator.liu.se (Niels Möller) writes: >> 2. Delete the old aes_* interface, in favor of aes128_, aes192_* and >>aes256_*. > > I've now made a branch for this, delete-old-aes. And it seems building gnutls with this branch fails, see https://gitlab.com/gnutls/nettle/-/jobs/53760965