On Fri, 2018-07-13 at 10:08 +0200, Niels Möller wrote:
>
> I've had a closer look now, and I think both are of similar type. In
> eratosthenes.c, we have a bitmap initialized with
>
> static void
> vector_init(unsigned long *vector, unsigned long size)
> {
> unsigned long end = (size +
On Thu, 2018-07-12 at 18:04 +0200, Niels Möller wrote:
>
> We'll see how to deal with those failures, but I don't think they
> should block merging to the master branch.
>
> There are also two "runner system failures", see
> https://gitlab.com/gnutls/nettle/-/jobs/81332562. Can that be
>
Nikos Mavrogiannopoulos writes:
> It seems
> that static analyzer in F28 finds few issues:
> https://gitlab.com/gnutls/nettle/-/jobs/81332560 (click on browse for
> artifacts)
>
> They are mem leaks on examples and one which relates to gmp-mini.
I fixed the leaks. Remaining issues listed on
On Thu, 2018-07-12 at 15:28 +0200, Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > Did you push it? I don't seem to see a pipeline with the f28 build
> > systems:
> > https://gitlab.com/gnutls/nettle/pipelines
>
> History info on https://gitlab.com/gnutls/nettle/commits/master-updat
Nikos Mavrogiannopoulos writes:
> Did you push it? I don't seem to see a pipeline with the f28 build
> systems:
> https://gitlab.com/gnutls/nettle/pipelines
History info on https://gitlab.com/gnutls/nettle/commits/master-updates
says "This project is mirrored from
On Thu, 2018-07-12 at 10:37 +0200, Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > Patch is attached adding the builds from gnutls (mips,arm,aarch64).
>
> Excellent! Now applied to the master-updates branch, together with
> arm
> fat fixes.
Did you push it? I don't seem to see a
On Thu, 2018-07-12 at 10:31 +0200, Niels Möller wrote:
>
> > btw. Note that fat-arm.c capabilities detection can be simplified
> > with
> > getauxval:
> >
> > https://community.arm.com/android-community/b/android/posts/runtime
> > -detection-of-cpu-features-on-an-armv8-a-cpu
>
> Ok, maybe we
Nikos Mavrogiannopoulos writes:
> Patch is attached adding the builds from gnutls (mips,arm,aarch64).
Excellent! Now applied to the master-updates branch, together with arm
fat fixes.
Regards,
/Niels
--
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject
Nikos Mavrogiannopoulos writes:
> The fat-arm build fails with:
>
> fat-arm.c: In function 'fat_init':
> fat-arm.c:194:7: error: '_nettle_sha1_compress_vec' undeclared (first
> use in this function); did you mean 'nettle_sha1_compress_vec'?
>_nettle_sha1_compress_vec =
On Mon, Jul 9, 2018 at 11:44 AM, Niels Möller wrote:
>> @@ -1,7 +1,7 @@
>> variables:
>>BUILD_IMAGES_PROJECT: gnutls/build-images
>> - FEDORA_BUILD: buildenv-f26
>> - FEDORA_X86_BUILD: buildenv-f26-x86
>> + FEDORA_BUILD: buildenv-f28
>> + FEDORA_X86_BUILD: buildenv-f28-x86
>>
Nikos Mavrogiannopoulos writes:
> On Sun, Jul 8, 2018 at 8:36 AM Niels Möller wrote:
>
>>We have to decide if the name of this assembly function should be
>>"nettle_sha1_compress_sha_ni" (and if so, update the macro
>>DECLARE_FAT_FUNC_VAR in fat-setup.h and all uses), or
>>
On Sun, Jul 8, 2018 at 8:36 AM Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > The attached version only exports symbols by wildcards and combines
> > patches.
>
> Thanks a lot. I've tried this out now (currently on master-updates
> branch for testing). I've noticed two problems:
>
Nikos Mavrogiannopoulos writes:
> The attached version only exports symbols by wildcards and combines
> patches.
Thanks a lot. I've tried this out now (currently on master-updates
branch for testing). I've noticed two problems:
1. x86_64 --enable-fat builds are broken, errors like
On Mon, 2018-06-18 at 13:53 +0200, Nikos Mavrogiannopoulos wrote:
> On Sun, 2018-06-17 at 19:55 +0200, Niels Möller wrote:
> > Nikos Mavrogiannopoulos writes:
> >
> > > I attach the current state. It does move all internal symbols
> > > into
> > > multiple internal headers
> >
> > Makes sense
On Sun, 2018-06-17 at 19:55 +0200, Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > I attach the current state. It does move all internal symbols into
> > multiple internal headers
>
> Makes sense to me.
>
> > The last
> > patch renames _nettle_md5_compress and _nettle_sha1_compress
Nikos Mavrogiannopoulos writes:
> I attach the current state. It does move all internal symbols into
> multiple internal headers
Makes sense to me.
> The last
> patch renames _nettle_md5_compress and _nettle_sha1_compress and
> includes it into the exported list
I think this makes sense too.
On Fri, 2018-06-08 at 13:34 +0200, Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > If you mean removing them from the public headers and placing them
> > in
> > one (or multiple) internal ones, it makes sense to me.
>
> Sounds reasonable. Then it's harder to use them without
On Fri, 2018-06-08 at 10:41 +0200, Niels Möller wrote:
> Nikos Mavrogiannopoulos writes:
>
> > Niels, I'm not sure however if that was your intention. Didn't you
> > want to deprecate some of the _nettle symbols as well like
> > _nettle_secp_256r1?
>
> I was thinking of doing something simple,
Nikos Mavrogiannopoulos writes:
> Niels, I'm not sure however if that was your intention. Didn't you
> want to deprecate some of the _nettle symbols as well like
> _nettle_secp_256r1?
I was thinking of doing something simple, with nettle_* symbols going
into the supported ABI (symbol version
Hi,
This patch makes the exported symbols explicit in the map file.
Furthermore it moves symbols only listed in internal headers in a
special section which makes them valid only for testing. I've tested
it with abi-compliance-checker and it detects the following missing
from nettle:
nettle_aeads,
20 matches
Mail list logo
