Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-29 Thread Jeff Layton
On Tue, 2017-08-29 at 13:20 +0530, Soumya Koduri wrote:
> Hi All,
> 
> I have fixed earlier delegation code-path to an extent and pushed the 
> patches to gerrit [1] now. Please take a look and let me know if there 
> is anything missing or not right.
> 
> The code needs a lot of cleanup but from my initial tests I could see 
> READ/WRITE delegations being granted and recalled from Ganesha SAL 
> layer. The delegation state reclaim during OPEN and recall support from 
> back-end glusterFS via upcall work is still pending.
> 
> Thanks,
> Soumya
> 
> [1] 
> https://review.gerrithub.io/#/q/topic:DelegSupport+(status:open+OR+status:merged)
> 

Thanks Soumya,

I've been plugging away at the same thing:

https://github.com/jtlayton/nfs-ganesha/commits/deleg

I respun your patch to add lease_op2, and added some code to wire up
ganesha to the new delegation facility in libcephfs that I've been
working on. I've been able to coax ganesha to hand out delegations with
the above set + an appropriate config file. That part has been fairly
straightforward so far.

The difficult part here is handling recalls. My first attempt at it in
the branch above is wrong, I think, so I'm looking more closely today at
the up_ops stuff (spoiler -- it's quite complicated with the layered
FSAL approach).
-- 
Jeff Layton 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-29 Thread Soumya Koduri

Hi All,

I have fixed earlier delegation code-path to an extent and pushed the 
patches to gerrit [1] now. Please take a look and let me know if there 
is anything missing or not right.


The code needs a lot of cleanup but from my initial tests I could see 
READ/WRITE delegations being granted and recalled from Ganesha SAL 
layer. The delegation state reclaim during OPEN and recall support from 
back-end glusterFS via upcall work is still pending.


Thanks,
Soumya

[1] 
https://review.gerrithub.io/#/q/topic:DelegSupport+(status:open+OR+status:merged)



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-08 Thread Soumya Koduri


- Original Message -
> From: "Soumya Koduri" 
> To: "Jeff Layton" 
> Cc: nfs-ganesha-devel@lists.sourceforge.net, "Yun-Chih Chen" 
> 
> Sent: Monday, August 7, 2017 11:59:21 AM
> Subject: Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha
> 
> 
> 
> On 08/03/2017 08:42 PM, Jeff Layton wrote:
> > On Fri, 2017-05-19 at 11:55 +0530, Soumya Koduri wrote:
> >> Hi,
> >>
> >> On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:
> >>> Hi, friends:
> >>>
> >>> I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
> >>> implemented in Linux kernel supports read delegation but not write
> >>> delegation.  I wonder if Ganesha implements write delegation?  If yes,
> >>> can it take effect if accessed by Linux NFS client?
> >>>
> >>> I use the following config file to observe delegation in Ganesha:
> >>>
> >>> EXPORT {
> >>>  Export_Id = 77;
> >>>  Path = /e;
> >>>  Pseudo = /e;
> >>>  Access_Type = RW;
> >>>  FSAL {
> >>>  Name = XFS;
> >>>  }
> >>>
> >>>  Delegations = readwrite;
> >>> }
> >>>
> >>> NFSV4 {
> >>>  Delegations = true;
> >>> }
> >>>
> >>> However, I did not see any trace of delegation under various workloads
> >>> (example: repeated read [1], repeated write [2]) using tools like
> >>> nfstrace or tcpdump.  When running in debug mode, I always got the
> >>> following in the log file:
> >>>
> >>> ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0
> >>>
> >>> indicating that delegation was not on.
> >>> Is there something wrong with my config file?  Or any other clue
> >>> regarding NFS delegation?  Thanks ( ;
> >>
> >> AFAIK except for FSAL_GPFS, other FSALs do not have support for
> >> delegations yet. Also after switching to new extended APIs
> >> (>=nfs-ganesha-2.4), delegations are disabled. It needs some additional
> >> work. We are planning to address it as part of adding this support for
> >> FSAL_GLUSTER (hopefully in 2.6 release). WRT XFS, I am not sure if
> >> anyone is actively looking at it.
> >>
> >> Thanks,
> >> Soumya
> >>
> > 
> > Hi Soumya,
> > 
> > I just started looking at delegation support in ganesha (mostly with an
> > eye toward plumbing in delegation support for Ceph).
> > 
> > I think we probably need to rework the whole delegation interface (maybe
> > even give it a dedicated FSAL op), and was wondering if you had started
> > any work along those lines.
> > 
> 
> Hi Jeff,
> 
> yes. I started it but have done only POC to mainly test the glusterfs
> lease support (which is experimental feature) at first.  I could manage
> to get leases granted from and returned to the backend.
> 
> The only changes I had done so far in the core ganesha layer is to
> uncomment earlier delegation code path to get the request all the way
> till FSAL [1]. I now intent to fix the SAL layer and happy to
> collaborate with you. Agree that instead of clubbing with lock, a
> dedicated fop shall be better.
> 
> 

I have now added new fop "lease_op2()" and pushed the changes (along with some 
more fixes) to my github repo [1]. I am yet to test it out but please let me 
know if that interface looks fine.

Thanks,
Soumya

[1] https://github.com/soumyakoduri/nfs-ganesha/commits/delegation_2_6

> Thanks,
> Soumya
> 
> 
> [1] https://review.gerrithub.io/372998
> 
> > Thanks,
> > 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
> 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-07 Thread William Allen Simpson

On 8/7/17 2:29 AM, Soumya Koduri wrote:

clubbing with lock, a dedicated fop


Amusing India'isms?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-06 Thread Soumya Koduri



On 08/03/2017 08:42 PM, Jeff Layton wrote:

On Fri, 2017-05-19 at 11:55 +0530, Soumya Koduri wrote:

Hi,

On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:

Hi, friends:

I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
implemented in Linux kernel supports read delegation but not write
delegation.  I wonder if Ganesha implements write delegation?  If yes,
can it take effect if accessed by Linux NFS client?

I use the following config file to observe delegation in Ganesha:

EXPORT {
 Export_Id = 77;
 Path = /e;
 Pseudo = /e;
 Access_Type = RW;
 FSAL {
 Name = XFS;
 }

 Delegations = readwrite;
}

NFSV4 {
 Delegations = true;
}

However, I did not see any trace of delegation under various workloads
(example: repeated read [1], repeated write [2]) using tools like
nfstrace or tcpdump.  When running in debug mode, I always got the
following in the log file:

ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0

indicating that delegation was not on.
Is there something wrong with my config file?  Or any other clue
regarding NFS delegation?  Thanks ( ;


AFAIK except for FSAL_GPFS, other FSALs do not have support for
delegations yet. Also after switching to new extended APIs
(>=nfs-ganesha-2.4), delegations are disabled. It needs some additional
work. We are planning to address it as part of adding this support for
FSAL_GLUSTER (hopefully in 2.6 release). WRT XFS, I am not sure if
anyone is actively looking at it.

Thanks,
Soumya



Hi Soumya,

I just started looking at delegation support in ganesha (mostly with an
eye toward plumbing in delegation support for Ceph).

I think we probably need to rework the whole delegation interface (maybe
even give it a dedicated FSAL op), and was wondering if you had started
any work along those lines.



Hi Jeff,

yes. I started it but have done only POC to mainly test the glusterfs 
lease support (which is experimental feature) at first.  I could manage 
to get leases granted from and returned to the backend.


The only changes I had done so far in the core ganesha layer is to 
uncomment earlier delegation code path to get the request all the way 
till FSAL [1]. I now intent to fix the SAL layer and happy to 
collaborate with you. Agree that instead of clubbing with lock, a 
dedicated fop shall be better.



Thanks,
Soumya


[1] https://review.gerrithub.io/372998


Thanks,



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-03 Thread joe
And on this end, we were hoping to have delegation support for the
FSAL_PROXY driver (NFS client side).  Any thoughts on that?

> On Fri, 2017-05-19 at 11:55 +0530, Soumya Koduri wrote:
>> Hi,
>>
>> On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:
>> > Hi, friends:
>> >
>> > I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
>> > implemented in Linux kernel supports read delegation but not write
>> > delegation.  I wonder if Ganesha implements write delegation?  If yes,
>> > can it take effect if accessed by Linux NFS client?
>> >
>> > I use the following config file to observe delegation in Ganesha:
>> >
>> > EXPORT {
>> > Export_Id = 77;
>> > Path = /e;
>> > Pseudo = /e;
>> > Access_Type = RW;
>> > FSAL {
>> > Name = XFS;
>> > }
>> >
>> > Delegations = readwrite;
>> > }
>> >
>> > NFSV4 {
>> > Delegations = true;
>> > }
>> >
>> > However, I did not see any trace of delegation under various workloads
>> > (example: repeated read [1], repeated write [2]) using tools like
>> > nfstrace or tcpdump.  When running in debug mode, I always got the
>> > following in the log file:
>> >
>> > ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0
>> >
>> > indicating that delegation was not on.
>> > Is there something wrong with my config file?  Or any other clue
>> > regarding NFS delegation?  Thanks ( ;
>>
>> AFAIK except for FSAL_GPFS, other FSALs do not have support for
>> delegations yet. Also after switching to new extended APIs
>> (>=nfs-ganesha-2.4), delegations are disabled. It needs some additional
>> work. We are planning to address it as part of adding this support for
>> FSAL_GLUSTER (hopefully in 2.6 release). WRT XFS, I am not sure if
>> anyone is actively looking at it.
>>
>> Thanks,
>> Soumya
>>
>
> Hi Soumya,
>
> I just started looking at delegation support in ganesha (mostly with an
> eye toward plumbing in delegation support for Ceph).
>
> I think we probably need to rework the whole delegation interface (maybe
> even give it a dedicated FSAL op), and was wondering if you had started
> any work along those lines.
>
> Thanks,
> --
> Jeff Layton 
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-08-03 Thread Jeff Layton
On Fri, 2017-05-19 at 11:55 +0530, Soumya Koduri wrote:
> Hi,
> 
> On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:
> > Hi, friends:
> > 
> > I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
> > implemented in Linux kernel supports read delegation but not write
> > delegation.  I wonder if Ganesha implements write delegation?  If yes,
> > can it take effect if accessed by Linux NFS client?
> > 
> > I use the following config file to observe delegation in Ganesha:
> > 
> > EXPORT {
> > Export_Id = 77;
> > Path = /e;
> > Pseudo = /e;
> > Access_Type = RW;
> > FSAL {
> > Name = XFS;
> > }
> > 
> > Delegations = readwrite;
> > }
> > 
> > NFSV4 {
> > Delegations = true;
> > }
> > 
> > However, I did not see any trace of delegation under various workloads
> > (example: repeated read [1], repeated write [2]) using tools like
> > nfstrace or tcpdump.  When running in debug mode, I always got the
> > following in the log file:
> > 
> > ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0
> > 
> > indicating that delegation was not on.
> > Is there something wrong with my config file?  Or any other clue
> > regarding NFS delegation?  Thanks ( ;
> 
> AFAIK except for FSAL_GPFS, other FSALs do not have support for 
> delegations yet. Also after switching to new extended APIs 
> (>=nfs-ganesha-2.4), delegations are disabled. It needs some additional 
> work. We are planning to address it as part of adding this support for 
> FSAL_GLUSTER (hopefully in 2.6 release). WRT XFS, I am not sure if 
> anyone is actively looking at it.
> 
> Thanks,
> Soumya
> 

Hi Soumya,

I just started looking at delegation support in ganesha (mostly with an
eye toward plumbing in delegation support for Ceph).

I think we probably need to rework the whole delegation interface (maybe
even give it a dedicated FSAL op), and was wondering if you had started
any work along those lines.

Thanks,
-- 
Jeff Layton 

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-05-19 Thread Frank Filz
> On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:
> > Hi, friends:
> >
> > I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
> > implemented in Linux kernel supports read delegation but not write
> > delegation.  I wonder if Ganesha implements write delegation?  If yes,
> > can it take effect if accessed by Linux NFS client?
> >
> > I use the following config file to observe delegation in Ganesha:
> >
> > EXPORT {
> > Export_Id = 77;
> > Path = /e;
> > Pseudo = /e;
> > Access_Type = RW;
> > FSAL {
> > Name = XFS;
> > }
> >
> > Delegations = readwrite;
> > }
> >
> > NFSV4 {
> > Delegations = true;
> > }
> >
> > However, I did not see any trace of delegation under various workloads
> > (example: repeated read [1], repeated write [2]) using tools like
> > nfstrace or tcpdump.  When running in debug mode, I always got the
> > following in the log file:
> >
> > ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0
> >
> > indicating that delegation was not on.
> > Is there something wrong with my config file?  Or any other clue
> > regarding NFS delegation?  Thanks ( ;
> 
> AFAIK except for FSAL_GPFS, other FSALs do not have support for
> delegations yet. Also after switching to new extended APIs (>=nfs-ganesha-
> 2.4), delegations are disabled. It needs some additional work. We are
> planning to address it as part of adding this support for FSAL_GLUSTER
> (hopefully in 2.6 release). WRT XFS, I am not sure if anyone is actively
looking
> at it.

Delegation support might be possible with FSAL_VFS or FSAL_XFS through use
of setlease. The big issue with VFS or XFS support is the majority of the
community is working on Ganesha from the perspective of CEPH, GLUSTER, GPFS,
and RGW FSALs. The primary purpose of FSAL_XFS is to utilize XFS's open by
handle capability for kernels that predate the general open by handle
capability, other than that FSAL_XFS is the same as FSAL_VFS.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


Re: [Nfs-ganesha-devel] NFSv4 delegation in Ganesha

2017-05-18 Thread Soumya Koduri
Hi,

On 05/18/2017 08:04 PM, Yun-Chih Chen wrote:
> Hi, friends:
>
> I'm studying the affect of NFSv4 on Linux.  As far as I know, NFS
> implemented in Linux kernel supports read delegation but not write
> delegation.  I wonder if Ganesha implements write delegation?  If yes,
> can it take effect if accessed by Linux NFS client?
>
> I use the following config file to observe delegation in Ganesha:
>
> EXPORT {
> Export_Id = 77;
> Path = /e;
> Pseudo = /e;
> Access_Type = RW;
> FSAL {
> Name = XFS;
> }
>
> Delegations = readwrite;
> }
>
> NFSV4 {
> Delegations = true;
> }
>
> However, I did not see any trace of delegation under various workloads
> (example: repeated read [1], repeated write [2]) using tools like
> nfstrace or tcpdump.  When running in debug mode, I always got the
> following in the log file:
>
> ganesha.nfsd-8999[main] display_fsinfo :FSAL :DEBUG :  delegations = 0
>
> indicating that delegation was not on.
> Is there something wrong with my config file?  Or any other clue
> regarding NFS delegation?  Thanks ( ;

AFAIK except for FSAL_GPFS, other FSALs do not have support for 
delegations yet. Also after switching to new extended APIs 
(>=nfs-ganesha-2.4), delegations are disabled. It needs some additional 
work. We are planning to address it as part of adding this support for 
FSAL_GLUSTER (hopefully in 2.6 release). WRT XFS, I am not sure if 
anyone is actively looking at it.

Thanks,
Soumya

>
> Ganesha V2.5-rc6 running on Fedora 25, accessed by CentOS 7 client.
>
> [1] repeated read: http://codepad.org/6KUat5AI
> [2] repeated write: http://codepad.org/cuBZ3XuT
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel