Patch: Prevent crit error being loggged on delete of non-existent file

2013-11-19 Thread Steven Hartland
Hi guys the attached patch prevents http file cache from logging a critical error when a file delete fails due to it not existing, which I'm sure was never the intention. N.B. Sorry if this appears as a duplicate, sent initially from the wrong email address. Regards Steve =

Re: Patch: Prevent crit error being loggged on delete of non-existent file

2013-11-19 Thread Steven Hartland
- Original Message - From: "Maxim Dounin" To: Sent: Tuesday, November 19, 2013 4:52 PM Subject: Re: Patch: Prevent crit error being loggged on delete of non-existent file Hello! On Tue, Nov 19, 2013 at 04:43:54PM -0000, Steven Hartland wrote: Hi guys the attached patc

Re: [PATCH] Upstream: add consistent hash module

2014-05-08 Thread Steven Hartland
Be good to see this in core, currently we use the 3rd party module to achieve this: http://wiki.nginx.org/HttpUpstreamRequestHashModule One question on the patch, you appear to have some commented out locking is this an oversight? Regards Steve - Original Message - From: "Jianju

header value null termination?

2014-08-21 Thread Steven Hartland
I'm creating a module in which I needed to set some of the standard headers e.g. Content-Range and Range. Looking through the core source code the standard way to do this seems to be something like this:- r->headers_in.range->value.len = ngx_sprintf(r->headers_in.range->value.data, "by

Re: header value null termination?

2014-08-25 Thread Steven Hartland
- Original Message - From: "Maxim Dounin" To: Sent: Monday, August 25, 2014 3:32 PM Subject: Re: header value null termination? Hello! On Fri, Aug 22, 2014 at 12:30:22AM +0100, Steven Hartland wrote: I'm creating a module in which I needed to set some of the s

[PATCH] Allow Partial Content responses to satisfy Range requests

2014-09-01 Thread Steven Hartland
# HG changeset patch # User Steven Hartland # Date 1409611936 0 # Mon Sep 01 22:52:16 2014 + # Node ID 0dc608b347e24b914ee193214857de15aad2ac0b # Parent 3f5f0ab59b359064db16e1aa52dfca335720dff6 Allow Partial Content responses to satisfy Range requests. Previously on 200 responsed could

Re: How does nginx keep up with logging thousands requests per second

2014-11-11 Thread Steven Hartland
For file logging it supports buffering see the docs here: http://nginx.org/en/docs/http/ngx_http_log_module.html#access_log On 11/11/2014 12:37, Alexander Todorov wrote: Hi guys, I've seen some reports on the web claiming nginx can serve in the order of 1 requests per second (correct me if

Re: [PATCH 2 of 2] Cache: send conditional requests only for cached 200 OK responses

2014-11-23 Thread Steven Hartland
We use 206 cached responses. On 23/11/2014 11:45, Piotr Sikora wrote: Hey Maxim, For example, it can be usable with 206 responses as well (and this is perfectly allowed by the RFC). 206 responses won't be cached by nginx, so that's kind of a moot point. I still think this approach is wrong,

[PATCH] Allow Partial Content responses to satisfy Range requests

2014-11-25 Thread Steven Hartland
# HG changeset patch # User Steven Hartland # Date 1416925134 0 # Tue Nov 25 14:18:54 2014 + # Node ID 0c3c06fabfc3b1c57710c0cced4837c10e3e9bbb # Parent 7d7eac6e31df1d962a644f8093c1fbb8f91620ce Allow Partial Content responses to satisfy Range requests. diff -r 7d7eac6e31df -r

Re: [PATCH] Allow Partial Content responses to satisfy Range requests

2014-11-25 Thread Steven Hartland
core, so would love to get them integrated. Regards Steve On 25/11/2014 14:22, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1416925134 0 # Tue Nov 25 14:18:54 2014 + # Node ID 0c3c06fabfc3b1c57710c0cced4837c10e3e9bbb # P

Re: [PATCH] Allow Partial Content responses to satisfy Range requests

2014-12-04 Thread Steven Hartland
On 04/12/2014 19:37, Maxim Dounin wrote: Hello! On Tue, Nov 25, 2014 at 02:22:13PM +, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1416925134 0 # Tue Nov 25 14:18:54 2014 + # Node ID 0c3c06fabfc3b1c57710c0cced4837c10e3e9bbb # Parent

[PATCH] Allow Partial Content responses to satisfy Range requests

2014-12-04 Thread Steven Hartland
# HG changeset patch # User Steven Hartland # Date 1417727204 0 # Thu Dec 04 21:06:44 2014 + # Node ID 05d3973ece9af030d0312932938fc3d1f2f139dd # Parent 1573fc7875fa09ee55763ce7ddc4e98d61e1deaf Allow Partial Content responses to satisfy Range requests diff -r 1573fc7875fa -r

Re: [PATCH] Allow Partial Content responses to satisfy Range requests

2014-12-04 Thread Steven Hartland
This time test suite passes on default compile: All tests successful. Files=141, Tests=964, 86 wallclock secs ( 0.49 usr 0.22 sys + 10.05 cusr 2.55 csys = 13.31 CPU) Result: PASS On 04/12/2014 21:07, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1417727204 0

Re: [PATCH] Allow Partial Content responses to satisfy Range requests

2014-12-05 Thread Steven Hartland
First off thanks for reviewing, comments / questions inline below On 05/12/2014 16:00, Maxim Dounin wrote: Hello! On Thu, Dec 04, 2014 at 09:07:57PM +, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1417727204 0 # Thu Dec 04 21:06:44 2014 + # Node ID

Re: Questions for X-Accel-Redirect

2014-12-21 Thread Steven Hartland
If you want to just pass the header through and not process it you can use proxy_pass_header. We do just this to pass X-Accel-Redirect though from server1 -> server2 where its then processed. e.g. proxy_pass_header X-Accel-Redirect Hope this helps. Regards Steve On 19/12/2014 06:52,

Re: [nginx] Decreased the NGX_HTTP_MAX_SUBREQUESTS limit.

2015-09-01 Thread Steven Hartland
On 01/09/2015 06:58, Yichun Zhang (agentzh) wrote: Hello! On Tue, Sep 1, 2015 at 4:29 AM, Valentin Bartenev wrote: #define NGX_HTTP_MAX_URI_CHANGES 10 -#define NGX_HTTP_MAX_SUBREQUESTS 200 +#define NGX_HTTP_MAX_SUBREQUESTS 50 Hmm, this change makes me sad. In o

[PATCH] Support FreeBSD jails for testing

2015-10-15 Thread Steven Hartland
# HG changeset patch # User Steven Hartland # Date 1444954080 0 # Fri Oct 16 00:08:00 2015 + # Node ID c22d8299e7040e0de6f85b4e96d0dd953f7af644 # Parent 78b4e12e6efe642aff591234db0f0b040cae9b5e Support FreeBSD jails for testing Ensure the test directory is read and writable to the test

Error handling from filter modules

2015-10-15 Thread Steven Hartland
I'm making changes to a filter module and when it detected an error it returned NGX_ERROR however the response generated to the client isn't the expected 500 internal server error I would have expected given said return. So the question is do filters have to manually call ngx_http_finalize_reques

Re: Error handling from filter modules

2015-10-16 Thread Steven Hartland
rned from a filter? On 16/10/2015 02:36, Steven Hartland wrote: I'm making changes to a filter module and when it detected an error it returned NGX_ERROR however the response generated to the client isn't the expected 500 internal server error I would have expected given said r

Re: Error handling from filter modules

2015-10-16 Thread Steven Hartland
On 16/10/2015 13:20, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 02:36:13AM +0100, Steven Hartland wrote: I'm making changes to a filter module and when it detected an error it returned NGX_ERROR however the response generated to the client isn't the expected 500 internal se

Re: [PATCH] Support FreeBSD jails for testing

2015-10-16 Thread Steven Hartland
On 16/10/2015 13:05, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 12:09:49AM +, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1444954080 0 # Fri Oct 16 00:08:00 2015 + # Node ID c22d8299e7040e0de6f85b4e96d0dd953f7af644 # Parent

Re: Error handling from filter modules

2015-10-19 Thread Steven Hartland
On 19/10/2015 17:59, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 06:15:30PM +0100, Steven Hartland wrote: On 16/10/2015 13:20, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 02:36:13AM +0100, Steven Hartland wrote: I'm making changes to a filter module and when it detect

Re: [PATCH] Support FreeBSD jails for testing

2015-10-19 Thread Steven Hartland
On 19/10/2015 18:57, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 06:24:11PM +0100, Steven Hartland wrote: On 16/10/2015 13:05, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 12:09:49AM +, Steven Hartland wrote: # HG changeset patch # User Steven Hartland # Date 1444954080

Re: [PATCH] Support FreeBSD jails for testing

2015-10-19 Thread Steven Hartland
On 19/10/2015 22:26, Sergey Kandaurov wrote: On Oct 19, 2015, at 8:57 PM, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 06:24:11PM +0100, Steven Hartland wrote: On 16/10/2015 13:05, Maxim Dounin wrote: Hello! On Fri, Oct 16, 2015 at 12:09:49AM +, Steven Hartland wrote: # HG

Re: nginScript documentation

2016-12-05 Thread Steven Hartland
Cool thanks for this. Looks like on http://nginx.org/en/docs/njs_about.html you have a typo on the second line "nignScript" I assume you meant nginScript ;-) On 05/12/2016 15:26, Igor Sysoev wrote: Hi! We have made recently documentation for nginScript: http://nginx.org/en/docs/http/ngx_htt