t than those two, so they've skipped them (intentionally or not).
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
Hi Sergey,
> I'd rewrote the description to be more specific:
>
> : Configure: fixed Linux crypt_r() test to add libcrypt.
> :
> : Previously, the resulting binary was successfully linked
> : because libcrypt was added in a separate test for crypt().
That's fine with me.
B
orted by type; I'd put it after u_long
Good catch, thanks!
> This makes the following slight update to the patch.
> If you're okey with it, I will commit it then.
LGTM.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.o
Hi Roman,
> Can you provide an example of a system where this fix is needed?
1. When linking against musl-libc on a system where libcrypt
is linked against glibc and thus not linkable.
2. When cross-compiling, for similar reasons.
Best regards,
Piotr Sik
ng, probably, but AWS folks are actively developing it,
so I'd expect it to led to issues sooner rather than later.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
and,
I find my version more readable.
But you're obviously welcome to commit either version.
[1] https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
patch.
LGTM, thanks!
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
IONS=suppressions=suppr.txt prove -r
Right, but that's an unnecessary step that prevents potential contributors
from using LeakSanitizer with NGINX. Also, I don't think that you're using
those tools either, likely because of those few false posit
)
Freeing memory in exit_process could result in use-after-free, since
cleanups for the cycle->pool might still access those connections.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
https://mailman.nginx.org/mailman/listinfo/nginx-devel
.
And then, there is Homebrew on Linux [6].
[1] https://formulae.brew.sh/analytics/install-on-request/30d/
[2] https://ports.macports.org/statistics/ports/
[3] https://support.apple.com/en-us/116943
[4] https://formulae.brew.sh/formula/nginx#default
[5] https://en.wikipedia.o
ood.
> Also, this change is required a corresponding change in the
> documentation on the nginx.org website.
I'm happy to submit the corresponding change if the patch
is accepted.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-dev
# HG changeset patch
# User Piotr Sikora
# Date 1708977646 0
# Mon Feb 26 20:00:46 2024 +
# Branch patch018
# Node ID ea1ab31c166c52372b40429a1cccece9ec9e003b
# Parent dd95daa55cf6131a7e845edd6ad3b429bcef6f98
Configure: fix "make install" when cross-compiling to Windows.
# HG changeset patch
# User Piotr Sikora
# Date 1708977635 0
# Mon Feb 26 20:00:35 2024 +
# Branch patch012
# Node ID 04e3155b3b9651fee708898aaf82ac35532806ee
# Parent 9b57470dc49f8d8d10abe30a5df628732d7618dc
Win32: fix unique file index calculations.
The old code was breaking strict
# HG changeset patch
# User Piotr Sikora
# Date 1708977648 0
# Mon Feb 26 20:00:48 2024 +
# Branch patch019
# Node ID 77eab4d83413b053d9681611d243335a95ee5567
# Parent ea1ab31c166c52372b40429a1cccece9ec9e003b
Configure: allow cross-compiling to Windows using Clang.
Signed-off-by: Piotr
# HG changeset patch
# User Piotr Sikora
# Date 1708977643 0
# Mon Feb 26 20:00:43 2024 +
# Branch patch017
# Node ID dd95daa55cf6131a7e845edd6ad3b429bcef6f98
# Parent bb99cbe3a343ae581d2369b990aee66e69679ca2
Configure: add support for Homebrew on Apple Silicon.
Signed-off-by: Piotr
# HG changeset patch
# User Piotr Sikora
# Date 1708977633 0
# Mon Feb 26 20:00:33 2024 +
# Branch patch011
# Node ID 9b57470dc49f8d8d10abe30a5df628732d7618dc
# Parent 480071fe7251829912a4f42301e8fc85da2d1905
Win32: include missing .
Signed-off-by: Piotr Sikora
diff -r 480071fe7251
# HG changeset patch
# User Piotr Sikora
# Date 1708977640 0
# Mon Feb 26 20:00:40 2024 +
# Branch patch015
# Node ID f58bc1041ebca635517b919d58b49923bf24f76d
# Parent 570e97dddeeddb79c71587aa8a10150b64404beb
macOS: detect cache line size at runtime.
Notably, Apple Silicon CPUs have
# HG changeset patch
# User Piotr Sikora
# Date 1708977642 0
# Mon Feb 26 20:00:42 2024 +
# Branch patch016
# Node ID bb99cbe3a343ae581d2369b990aee66e69679ca2
# Parent f58bc1041ebca635517b919d58b49923bf24f76d
Configure: set cache line sizes for more architectures.
Signed-off-by: Piotr
# HG changeset patch
# User Piotr Sikora
# Date 1708977638 0
# Mon Feb 26 20:00:38 2024 +
# Branch patch014
# Node ID 570e97dddeeddb79c71587aa8a10150b64404beb
# Parent cdc173477ea99fd6c952a85e5cd11db66452076a
Configure: link libcrypt when a feature using it is detected.
Previously
# HG changeset patch
# User Piotr Sikora
# Date 1708977637 0
# Mon Feb 26 20:00:37 2024 +
# Branch patch013
# Node ID cdc173477ea99fd6c952a85e5cd11db66452076a
# Parent 04e3155b3b9651fee708898aaf82ac35532806ee
Core: fix build without libcrypt.
libcrypt is no longer part of glibc, so
# HG changeset patch
# User Piotr Sikora
# Date 1708977630 0
# Mon Feb 26 20:00:30 2024 +
# Branch patch009
# Node ID 5e923992006199748e79b08b1e65c4ef41f07495
# Parent 3cde11b747c08c69889edc014a700317fe4d1d88
SSL: add support for AWS-LC.
AWS-LC is a fork of BoringSSL with some
# HG changeset patch
# User Piotr Sikora
# Date 1708977632 0
# Mon Feb 26 20:00:32 2024 +
# Branch patch009
# Node ID dfffc67d286b788204f60701ef4179566d933a1b
# Parent 5e923992006199748e79b08b1e65c4ef41f07495
SSL: add $ssl_curve when using AWS-LC.
Signed-off-by: Piotr Sikora
diff -r
# HG changeset patch
# User Piotr Sikora
# Date 1708977628 0
# Mon Feb 26 20:00:28 2024 +
# Branch patch008
# Node ID 3cde11b747c08c69889edc014a700317fe4d1d88
# Parent 5584232259d28489efba149f2f5ae730691ff0d4
Rewrite: fix "return" directive without response text.
# HG changeset patch
# User Piotr Sikora
# Date 1708977626 0
# Mon Feb 26 20:00:26 2024 +
# Branch patch007
# Node ID 5584232259d28489efba149f2f5ae730691ff0d4
# Parent 03e5549976765912818120e11f6b08410a2af6a9
Core: fix conversion of IPv4-mapped IPv6 addresses.
Found
# HG changeset patch
# User Piotr Sikora
# Date 1708977621 0
# Mon Feb 26 20:00:21 2024 +
# Branch patch005
# Node ID fe6f8a72d42970df176ea53f4f0aea16947ba5b8
# Parent 52936793ac076072c3544aa4e27f973d2f8fecda
Geo: fix uninitialized memory access.
Found with MemorySanitizer.
Signed-off
# HG changeset patch
# User Piotr Sikora
# Date 1708977619 0
# Mon Feb 26 20:00:19 2024 +
# Branch patch004
# Node ID 52936793ac076072c3544aa4e27f973d2f8fecda
# Parent 8edb4003177dac56301aed7f86f8d2a564b47552
Correctly initialize ngx_str_t.
Previously, only the "len" fie
# HG changeset patch
# User Piotr Sikora
# Date 1708977618 0
# Mon Feb 26 20:00:18 2024 +
# Branch patch003
# Node ID 8edb4003177dac56301aed7f86f8d2a564b47552
# Parent f8d9fb94eab212f6e640b7a68ed111562e3157d5
Upstream: cleanup at shutdown.
Add "free_upstream" callback called
# HG changeset patch
# User Piotr Sikora
# Date 1708977616 0
# Mon Feb 26 20:00:16 2024 +
# Branch patch002
# Node ID f8d9fb94eab212f6e640b7a68ed111562e3157d5
# Parent a8a592b9b62eff7bca03e8b46669f59d2da689ed
Core: free connections and read/write events at shutdown.
Found
# HG changeset patch
# User Piotr Sikora
# Date 1708977611 0
# Mon Feb 26 20:00:11 2024 +
# Branch patch001
# Node ID a8a592b9b62eff7bca03e8b46669f59d2da689ed
# Parent 89bff782528a91ad123b63b624f798e6fd9c8e68
HTTP: stop emitting server version by default.
This information is only
ugust/010439.html
http://mailman.nginx.org/pipermail/nginx-devel/2018-March/010930.html
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora
# Date 1540435636 25200
# Wed Oct 24 19:47:16 2018 -0700
# Node ID 466c154c5c53b956660211df96331b3c25669485
# Parent be5cb9c67c05ccaf22dab7abba78aa4c1545a8ee
HTTP/2: fixed handling of fully preread request bodies.
Previously, fully preread request
# HG changeset patch
# User Piotr Sikora
# Date 1494129075 25200
# Sat May 06 20:51:15 2017 -0700
# Node ID fafbb3ee41e5bb03bcfba73f7d4367b8ab7d36cc
# Parent be5cb9c67c05ccaf22dab7abba78aa4c1545a8ee
Upstream: added $upstream_bytes_sent variable.
Signed-off-by: Piotr Sikora
diff -r
shutdown or stop limiting number of requests by
default.
Best regards,
Piotr Sikora
On Wed, Aug 30, 2017 at 4:14 PM, Piotr Sikora <piotrsik...@google.com> wrote:
> Hey Valentin,
>
>> This opens a vector for dos attack. There are some configurations
>> when memory can be alloca
3"
> http header: "Accept-Encoding: gzip, deflate"
In both examples, User-Agent, Accept-Encoding and Accept-Language are the
same, and Accept is (an extension-specific?) subset of the "/" request,
which proves that this is in fact a good idea.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
eturn NGX_HTTP_CLIENT_CLOSED_REQUEST;
}
-if (n == 0 || n == NGX_ERROR) {
+if (n == NGX_ERROR) {
c->error = 1;
return NGX_HTTP_BAD_REQUEST;
}
Having said that, h
# HG changeset patch
# User Patryk Lesiewicz
# Date 1512172754 28800
# Fri Dec 01 15:59:14 2017 -0800
# Node ID 0e2e2da798261fe5105017d9678566267b07e2b9
# Parent fc0d06224edac2c7cfbfd9a4def478f285d9957b
Upstream: flush low-level buffers on write retry.
If the data to
Hey Maxim,
> Thank you for the patch. I've pushed a change which fixes tests
> with this patch (http://hg.nginx.org/nginx-tests/rev/24e175025ad8).
> Unless there are objections, I'll push this patch with the
> following mostly style changes:
Those changes look fine, thanks.
Best re
nd above patch is IMHO better than lost requests.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1504129797 25200
# Wed Aug 30 14:49:57 2017 -0700
# Node ID 49b677bf2ae7ab92499766e8184ddcbf7a4233f9
# Parent c7d4017c8876af6d8570e400320537d7d39e9578
HTTP/2: don't limit number of requests per HTTP/2 conn
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1504129931 25200
# Wed Aug 30 14:52:11 2017 -0700
# Node ID 7e1e91f9ca063563cb293136e7b1cede36e63dc6
# Parent c7d4017c8876af6d8570e400320537d7d39e9578
HTTP/2: signal 0-byte HPACK's dynamic table size.
This chang
Hey Maxim,
On Tue, Jul 25, 2017 at 6:28 PM, Piotr Sikora <piotrsik...@google.com> wrote:
> Hey Maxim,
>
>> There are serious concerns about this and with other patches.
>> Most generic ones are outlined below.
>>
>> 1. Server-side HTTP/2 code complexi
code review this patchset actually received,
i.e. if the existing code would be moved to a separate
HTTP/2-to-upstreams module, would it be acceptable or do you have
other issues with the code?
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
t;Host" header separately, via different means, would require
more drastic code changes, for little to no benefit.
Anyway, you're more than welcome to provide alternative patch, but I
don't see anything wrong with the current approach, so I'm unlikely to
rewrite it myself.
Best regards,
Piotr Si
herwise it won't look like part of the same frame, i.e.:
http2 SETTINGS frame with 3 params
http2 SETTINGS param HEADER_TABLE_SIZE: 4096
http2 SETTINGS param INITIAL_WINDOW_SIZE: 65536
http2 unknown SETTINGS param id:0xAA value:1234
Also, &qu
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491954701 25200
# Tue Apr 11 16:51:41 2017 -0700
# Node ID 432abcf285745ec6b6ee14d6487a4a42b51b7bce
# Parent cde1f42da7b26b7d2b788f916685e736b919138e
Cache: add HTTP/2 support.
Signed-off-by: Piotr Sikora <
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490769087 25200
# Tue Mar 28 23:31:27 2017 -0700
# Node ID 7eb807b056da7abe9c679b59e94595d59a1406e6
# Parent 0637acdb51e29e1f68f5f3e762115c702cab4e72
Proxy: add HTTP/2 support.
Signed-off-by: Piotr Sikora <
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID cde1f42da7b26b7d2b788f916685e736b919138e
# Parent 7eb807b056da7abe9c679b59e94595d59a1406e6
Proxy: add "proxy_pass_trailers" directive.
Sign
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489618535 25200
# Wed Mar 15 15:55:35 2017 -0700
# Node ID 0637acdb51e29e1f68f5f3e762115c702cab4e72
# Parent 068381014f256ad6e2dc490bacc2529cebbb0462
Proxy: split configured header names and values.
Previously
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489618489 25200
# Wed Mar 15 15:54:49 2017 -0700
# Node ID 068381014f256ad6e2dc490bacc2529cebbb0462
# Parent 96075d4cd2a6e8bd67caf1d7b78f8e87d757c48d
Proxy: always emit "Host" header first.
Signed-off-
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489111358 28800
# Thu Mar 09 18:02:38 2017 -0800
# Node ID 64d12a65309eca3859055a04eb02cc14f3b3168d
# Parent 24b0f9f4ebfa560edd984146548ab07925dba73f
HTTP/2: introduce stream->fake_connection.
No functiona
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489621682 25200
# Wed Mar 15 16:48:02 2017 -0700
# Node ID 96075d4cd2a6e8bd67caf1d7b78f8e87d757c48d
# Parent 154ca6c5e62a1931a616e9f2b99ef2553b7c2c8b
Proxy: add "proxy_ssl_alpn" directive.
ALPN i
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490767180 25200
# Tue Mar 28 22:59:40 2017 -0700
# Node ID 154ca6c5e62a1931a616e9f2b99ef2553b7c2c8b
# Parent 00bfd879eaf03f32373ab27110dd8f77c2b722a0
HTTP/2: add HTTP/2 to upstreams.
Signed-off-by: Piotr
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489106035 25200
# Thu Mar 09 17:33:55 2017 -0700
# Node ID 24b0f9f4ebfa560edd984146548ab07925dba73f
# Parent 912d9cf36783146e61a68d554253e70956ea9125
HTTP/2: introduce h2c->conf_ctx.
No functional changes.
S
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516711 25200
# Sun Mar 26 01:25:11 2017 -0700
# Node ID 22d178a11e30c4a8576c3ce28859dfe1cc8adec0
# Parent a147dd50ee3fb8628b79f4482c552c7c2852a732
HTTP/2: add debug logging of control frames.
Signed-off-by:
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491886301 25200
# Mon Apr 10 21:51:41 2017 -0700
# Node ID a147dd50ee3fb8628b79f4482c552c7c2852a732
# Parent 5f5d70428655db0889a2111d17d912a7383df152
Upstream keepalive: preserve c->data.
Signed-off-by: Pio
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1485917964 28800
# Tue Jan 31 18:59:24 2017 -0800
# Node ID 912d9cf36783146e61a68d554253e70956ea9125
# Parent 22d178a11e30c4a8576c3ce28859dfe1cc8adec0
HTTP/2: s/client/peer/.
No functional changes.
Sign
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491708381 25200
# Sat Apr 08 20:26:21 2017 -0700
# Node ID 5f5d70428655db0889a2111d17d912a7383df152
# Parent a39bc74873faf9e5bea616561b43f6ecc55229f9
Output chain: propagate last_buf flag to c->send_chain()
Hey Maxim,
> Full patch with the above comments below:
Applied, thanks!
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516711 25200
# Sun Mar 26 01:25:11 2017 -0700
# Node ID 1f1549823fba355a0dd1af49108be4b4898bf331
# Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3
HTTP/2: add debug logging of control frames.
Signed-off-by:
en" value a bit sooner, so that the number of params is
calculated and cannot be forgotten in subsequent commits.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491708381 25200
# Sat Apr 08 20:26:21 2017 -0700
# Node ID 3363bdf821c7110b577437bd59c962653f3a144f
# Parent d1816a2696de8c2faa1cd913a151e5f62a8620f3
Output chain: propagate last_buf flag to c->send_chain()
please consider using the same approach.
Yes, it's exactly the same use case.
I originally used c->need_last_buf, but then decided against it, since
c->send_chain() is "pluggable" and therefore we shouldn't be assuming
it's behavior, but I don't mind either way, as both solutions for w
ain one of those headers.
We could clear those headers in proxy module (I'm already doing that
for most of the headers, anyway), but it feels like a workaround for
broken clients.
Having said that, I'm fine with dropping the whole patchset.
Best regards,
Piotr Sikora
_
is used. It looks too serious,
> but the WARN level is too low.
Good catch, thanks!
This was left-over from the initial version, which skipped too long
trailers, instead of resetting stream.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
Hey Maxim,
> Series committed with the above change.
> Thanks to all involved.
Thanks! :)
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
refer.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
son to check "trailers" on each iteration.
> I think you can put it inside the "if (in == NULL)" condition.
Good catch, thanks!
> Please consider the changes below.
Applied (with removed empty lines between error message and "return N
n == 0) { ... }" in the end, but applied
rest of you changes. Thanks!
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516709 25200
# Sun Mar 26 01:25:09 2017 -0700
# Node ID e2abc3bc3fc12b788d2631d3c47215acdc4ebbe6
# Parent 6263d68cb96042d8f8974a4a3945226227ce13b9
HTTP/2: reject HTTP/2 requests with connection-specific h
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516709 25200
# Sun Mar 26 01:25:09 2017 -0700
# Node ID 6263d68cb96042d8f8974a4a3945226227ce13b9
# Parent 349648a6f91f9bd5cc80d22390b95c2239a8bfb3
HTTP/2: reject HTTP/2 requests with "Transfer-Encod
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID 46150fb672e7b92cfbe678bad71df187fcb25ae6
# Parent 73f67e06ab103e0368d1810c6f8cac5c70c4e246
Headers filter: added "add_trailer" directive.
Trai
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516709 25200
# Sun Mar 26 01:25:09 2017 -0700
# Node ID 10c3f4c37f96ef496eff859b6f6815817e79455a
# Parent e6f399a176e7cae0fa08f1183d31315bce3b9ecb
HTTP/2: reject HTTP/2 requests with "Connection"
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID 73f67e06ab103e0368d1810c6f8cac5c70c4e246
# Parent 07a5d26b49f04425ff54cc998f885aa987b7823f
HTTP/2: added support for trailers in HTTP responses.
Sign
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490516709 25200
# Sun Mar 26 01:25:09 2017 -0700
# Node ID 349648a6f91f9bd5cc80d22390b95c2239a8bfb3
# Parent 10c3f4c37f96ef496eff859b6f6815817e79455a
HTTP/2: reject HTTP/2 requests with invalid "TE&qu
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID 07a5d26b49f04425ff54cc998f885aa987b7823f
# Parent e6f399a176e7cae0fa08f1183d31315bce3b9ecb
Added support for trailers in HTTP responses.
E
dded to headers / trailers list.
I've added this extra check to avoid forcing chunked encoding with
such configuration.
Maybe we should reject it during configuration instead, or ignore this
case and let it force chunked encoding? Which one do you prefer?
Best regards,
Piotr Sikora
_
>pos = (u_char *) CRLF "0" CRLF CRLF;
b->last = b->pos + sizeof(CRLF "0" CRLF CRLF) - 1;
return cl;
}
+len += sizeof(CRLF "0" CRLF CRLF) - 1;
+
b->pos = ngx_palloc(r->pool, len);
if (b->pos == NULL) {
return NULL;
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491296505 25200
# Tue Apr 04 02:01:45 2017 -0700
# Node ID bff5ac3da350d8d9225d4204d8aded90fb670f3f
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Upstream: ignore read-readiness if request wasn't sent.
Sign
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489621682 25200
# Wed Mar 15 16:48:02 2017 -0700
# Node ID 7733d946e2651a2486a53d912703e2dfaea30421
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Proxy: add "proxy_ssl_alpn" directive.
ALPN i
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1491708381 25200
# Sat Apr 08 20:26:21 2017 -0700
# Node ID 2a48b9b6e67d91594c1787ebf721daebf5f88c91
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Output chain: propagate flush and last_buf flags to send
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489618535 25200
# Wed Mar 15 15:55:35 2017 -0700
# Node ID ff79d6887fc92d0344eac3e87339583265241e36
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Proxy: split configured header names and values.
Previously
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1489618489 25200
# Wed Mar 15 15:54:49 2017 -0700
# Node ID e472b23fdc387943ea90fb2f0ae415d9d104edc7
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Proxy: always emit "Host" header first.
Signed-off-
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID acdc80c0d4ef8aa2519e2882ff1a3bd4a316ad81
# Parent 8d74ff6c2015180f5c1f399f492214d7d0a52b3f
Headers filter: added "add_trailer" directive.
Trai
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493191954 25200
# Wed Apr 26 00:32:34 2017 -0700
# Node ID 8d74ff6c2015180f5c1f399f492214d7d0a52b3f
# Parent 41c09a2fd90410e25ad8515793bd48028001c954
HTTP/2: added support for trailers in HTTP responses.
Sign
readable to generate last-chunk in one function regardless of
> whether trailer headers are present or not.
>
> It will also make error handling better: as of now, an allocation
> error in ngx_http_chunked_create_trailers() will result in "no
> trailers" code path being tried inst
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID 41c09a2fd90410e25ad8515793bd48028001c954
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Added support for trailers in HTTP responses.
E
his check results in less consistent behavior
and doesn't solve any real problems.
Having said that, I'm going to remove it, since I don't want to spend
another few months arguing about this...
Best regards,
Piotr Sikora
___
nginx-devel mai
HTTP/2 patchset that
uses those changes.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
ot; has absolutely no
performance benefit and it results in full search instead of simple
hash comparison during header lookup, because some headers won't have
hash set to proper value.
Anyway, I'm going set it to "1" to avoid side-tracking this discussion.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
nses.
As mentioned earlier, I also removed "TE: trailers" requirement and
merged whole trailer-part into one buffer, in case of trailers.
Best regards,
Piotr Sikora
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID 52201fff87e8c5a096287cf206cdcc14c0d81ce7
# Parent e84aa49c5bc7a3250d4844b581e4bf3ed42db5f5
Headers filter: added "add_trailer" directive.
Trai
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1490351854 25200
# Fri Mar 24 03:37:34 2017 -0700
# Node ID b0a910ad494158427ba102bdac71ce01d0667f72
# Parent 716852cce9136d977b81a2d1b8b6f9fbca0dce49
Added support for trailers in HTTP responses.
E
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493191954 25200
# Wed Apr 26 00:32:34 2017 -0700
# Node ID e84aa49c5bc7a3250d4844b581e4bf3ed42db5f5
# Parent b0a910ad494158427ba102bdac71ce01d0667f72
HTTP/2: added support for trailers in HTTP responses.
Sign
n
systems where size of ssize_t was equal to size of ngx_uint_t), since
the value would overflow and result in the same negative number when
casted to ssize_t.
I updated patchset with suggested changes, please take a look.
Best regards,
Piotr Sikora
___
ng
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493067070 25200
# Mon Apr 24 13:51:10 2017 -0700
# Node ID 26c9e95a73295a344d39ac5e6d62787d26989c82
# Parent e00ba13ce421685981db6a98831409a234cc1e62
HTTP/2: don't send SETTINGS ACK before already queued DATA
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493067147 25200
# Mon Apr 24 13:52:27 2017 -0700
# Node ID d61e944f55e70a5a25c8a79bfc5c167b7f22d62e
# Parent 1738ed9658e2a9a12370f4c828761a9fd058935d
HTTP/2: send SETTINGS ACK after applying all SETTINGS
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493067124 25200
# Mon Apr 24 13:52:04 2017 -0700
# Node ID 1738ed9658e2a9a12370f4c828761a9fd058935d
# Parent ab6ef3037840393752d82fac01ea1eb4f972301c
HTTP/2: emit new frames only after applying all SETTINGS
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1493067017 25200
# Mon Apr 24 13:50:17 2017 -0700
# Node ID e00ba13ce421685981db6a98831409a234cc1e62
# Parent d61e944f55e70a5a25c8a79bfc5c167b7f22d62e
HTTP/2: make SETTINGS ACK frame reusable.
Signed-off-by:
# HG changeset patch
# User Piotr Sikora <piotrsik...@google.com>
# Date 1496272340 25200
# Wed May 31 16:12:20 2017 -0700
# Node ID a8050d50338bf127d57f820744a498517bf44b68
# Parent ab6ef3037840393752d82fac01ea1eb4f972301c
HTTP/2: reject HTTP/2 requests with invalid "TE&qu
Hey,
> # HG changeset patch
> # User Piotr Sikora <piotrsik...@google.com>
> # Date 1490516709 25200
> # Sun Mar 26 01:25:09 2017 -0700
> # Node ID b8daccea5fde213d4b7a10fa9f57070ab3b6a1ec
> # Parent 22be63bf21edaa1b8ea916c7d8cd4e5fe4892061
> HTTP/2: reject HTTP/
1 - 100 of 450 matches
Mail list logo