Discussion: websocket over http2 / http3?

Hi, websocket over http2 is defined in RFC8441, chrome and firefox support it. https://chromestatus.com/feature/6251293127475200 websocket over http3 is defined in RFC9220, neither of chrome nor firefox support it. https://chromestatus.com/feature/5080537855688704 Is there any plan to support

Re: [PATCH] Documented the http2 directive

User Yaroslav Zhuravlev # Date 1686668685 -3600 # Tue Jun 13 16:04:45 2023 +0100 # Node ID b42c78a25477b40c78c048cd3d8f44421e814fca # Parent 2fa6471cd138071038f055031a7a379a7e9ab108 Documented the http2 directive. diff --git a/xml/en/docs/http/ngx_http_core_module.xml b/xml/en/docs/http/ngx_http

Re: [PATCH] Documented the http2 directive

Hello! On Tue, Jun 13, 2023 at 02:56:50PM +0100, Yaroslav Zhuravlev wrote: > @@ -55,7 +55,9 @@ > > > server { > -listen 443 ssl http2; > +listen 443 ssl; > + > +http2 on; > > ssl_certificate server.crt; > ssl_certificate_

Re: [PATCH] Documented the http2 directive

Date 1686664161 -3600 > # Tue Jun 13 14:49:21 2023 +0100 > # Node ID d0b3b7889bfa45ce03845acdc51919463f455874 > # Parent 2fa6471cd138071038f055031a7a379a7e9ab108 > Documented the http2 directive. > > diff --git a/xml/en/docs/http/ngx_http_core_module.xml > b/xml

[PATCH] Documented the http2 directive

# Parent 2fa6471cd138071038f055031a7a379a7e9ab108 Documented the http2 directive. diff --git a/xml/en/docs/http/ngx_http_core_module.xml b/xml/en/docs/http/ngx_http_core_module.xml --- a/xml/en/docs/http/ngx_http_core_module.xml +++ b/xml/en/docs/http/ngx_http_core_module.xml @@ -10,7 +10,7

[nginx] HTTP/2: "http2" directive.

details: https://hg.nginx.org/nginx/rev/08ef02ad5c54 branches: changeset: 9119:08ef02ad5c54 user: Roman Arutyunyan date: Tue May 16 16:30:08 2023 +0400 description: HTTP/2: "http2" directive. The directive enables HTTP/2 in the current server. The previous way to enable

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

> >> +++ b/src/http/ngx_http_request.c > > > > >> @@ -318,12 +318,6 @@ ngx_http_init_connection(ngx_connection_ > > > > >> rev->handler = ngx_http_wait_request_handler; > > > > >> c-&

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

ttp/ngx_http_request.c b/src/http/ngx_http_request.c > > > >> --- a/src/http/ngx_http_request.c > > > >> +++ b/src/http/ngx_http_request.c > > > >> @@ -318,12 +318,6 @@ ngx_http_init_connection(ngx_connection_ > > > >> rev->handler

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

/http/ngx_http_request.c > > >> @@ -318,12 +318,6 @@ ngx_http_init_connection(ngx_connection_ > > >> rev->handler = ngx_http_wait_request_handler; > > >> c->write->handler = ngx_http_empty_handler; > > >> > > >> -#if (NGX_HTTP_V2)

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

bd1460c314c93 > # Parent d8272b84031bea1940ef8a5b8e2f79ec6a2dcfc1 > HTTP/2: "http2" directive. > > The directive enables HTTP/2 in the current server. The previous way to > enable HTTP/2 via "listen ... http2" is now deprecated. The new approach > allows to share HTTP/2 and HTTP/0.9

Re: Q: http2 and http1 virtual hosts both works via HTTP/2 - bug of feature?

Hello! On Wed, May 24, 2023 at 01:07:00AM +0300, Andrey Kulikov wrote: > Observed nginx's version 1.22.1 questionable behaviour with two virtual > hosts, one with H2 - enabled, second without http2 support. > Both on the same IP and port, with different domain names/server names. > W

Q: http2 and http1 virtual hosts both works via HTTP/2 - bug of feature?

Hello, Observed nginx's version 1.22.1 questionable behaviour with two virtual hosts, one with H2 - enabled, second without http2 support. Both on the same IP and port, with different domain names/server names. When browsers make requests to a second domain, h2 being ALPN-negotiated, and data

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

_request_handler; > >> c->write->handler = ngx_http_empty_handler; > >> > >> -#if (NGX_HTTP_V2) > >> -if (hc->addr_conf->http2) { > >> -rev->handler = ngx_http_v2_init; > >> -} > >> -#endif > >>

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

>> +++ b/src/http/ngx_http_request.c >> @@ -318,12 +318,6 @@ ngx_http_init_connection(ngx_connection_ >> rev->handler = ngx_http_wait_request_handler; >> c->write->handler = ngx_http_empty_handler; >> >> -#if (NGX_HTTP_V2) >> -if (hc

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

_ > rev->handler = ngx_http_wait_request_handler; > c->write->handler = ngx_http_empty_handler; > > -#if (NGX_HTTP_V2) > -if (hc->addr_conf->http2) { > -rev->handler = ngx_http_v2_init; > -} > -#endif &

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

3 +0400 > > # Branch quic > > # Node ID 735f9e501922e4b0a1b20730d62bac35ea398336 > > # Parent 38eec3d9f2c0d2e6d041efe3ee6d9c1618d8f1e6 > > HTTP/2: "http2" directive. > > > > The directive enables HTTP/2 in the current server. The previous way to > > en

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

2e6d041efe3ee6d9c1618d8f1e6 > HTTP/2: "http2" directive. > > The directive enables HTTP/2 in the current server. The previous way to > enable HTTP/2 via "listen ... http2" is now deprecated. The new approach > allows to share HTTP/2 and HTTP/0.9-1.1 on the same

Re: [PATCH 0 of 3] Directives for enabling http2 and http3

> On 7 Feb 2023, at 18:50, Roman Arutyunyan wrote: > > Hi, > > Updated the patches based on latest comments. Looks good to me. -- Sergey Kandaurov ___ nginx-devel mailing list nginx-devel@nginx.org

[PATCH 2 of 3] HTTP/2: "http2" directive

# HG changeset patch # User Roman Arutyunyan # Date 1675781276 -14400 # Tue Feb 07 18:47:56 2023 +0400 # Branch quic # Node ID 735f9e501922e4b0a1b20730d62bac35ea398336 # Parent 38eec3d9f2c0d2e6d041efe3ee6d9c1618d8f1e6 HTTP/2: "http2" directive. The directive enables HTTP/2 in t

[PATCH 0 of 3] Directives for enabling http2 and http3

Hi, Updated the patches based on latest comments. -- Roman Arutyunyan ___ nginx-devel mailing list nginx-devel@nginx.org https://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

6:49:50 2023 +0400 > > # Branch quic > > # Node ID 139b348815b3f19753176988f06b590a3e0af4c0 > > # Parent 2fcc1c60be1c89aad5464bcc06f1189d1adc885a > > HTTP/2: "http2" directive. > > > > The directive enables HTTP/2 in the current server. The previou

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

3 +0400 > > # Branch quic > > # Node ID 139b348815b3f19753176988f06b590a3e0af4c0 > > # Parent 2fcc1c60be1c89aad5464bcc06f1189d1adc885a > > HTTP/2: "http2" directive. > > > > The directive enables HTTP/2 in the current server. The previous way to > > ena

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

9aad5464bcc06f1189d1adc885a > HTTP/2: "http2" directive. > > The directive enables HTTP/2 in the current server. The previous way to > enable HTTP/2 via "listen ... http2" is now deprecated. > > diff --git a/src/http/modules/ngx_http_ssl_module.c &g

Re: [PATCH 2 of 3] HTTP/2: "http2" directive

e0af4c0 > # Parent 2fcc1c60be1c89aad5464bcc06f1189d1adc885a > HTTP/2: "http2" directive. > > The directive enables HTTP/2 in the current server. The previous way to > enable HTTP/2 via "listen ... http2" is now deprecated. It might be a good idea to describe here how it works, notably

[PATCH 2 of 3] HTTP/2: "http2" directive

# HG changeset patch # User Roman Arutyunyan # Date 1675255790 -14400 # Wed Feb 01 16:49:50 2023 +0400 # Branch quic # Node ID 139b348815b3f19753176988f06b590a3e0af4c0 # Parent 2fcc1c60be1c89aad5464bcc06f1189d1adc885a HTTP/2: "http2" directive. The directive enables HTTP/2 in t

[PATCH 0 of 3] Directives for enabling http2 and http3

Hi, Updates in this series: - Detect HTTP-level redirects to servers where the negotiated protocol is not available. Now 421 is returned. - Retained old http3 configuration for compatibility. - Reimplemented the http2 patch. Now http2 preface is read in ngx_http_wait_request_handler

Re: [PATCH 3 of 3] HTTP/2: "http2" directive

a9bb2db > # Parent 555913c358221f647bbace26165bef5eb614add4 > HTTP/2: "http2" directive. > > The directive enables HTTP/2 in the current server. The previous way to > enable HTTP/2 via "listen ... http2" is now deprecated. In no particular order: - The ngx_http_try_v2() shoul

[PATCH 3 of 3] HTTP/2: "http2" directive

# HG changeset patch # User Roman Arutyunyan # Date 1674649725 -14400 # Wed Jan 25 16:28:45 2023 +0400 # Branch quic # Node ID 819737783463d7e38ea80109a976db1d3a9bb2db # Parent 555913c358221f647bbace26165bef5eb614add4 HTTP/2: "http2" directive. The directive enables HTTP/2 in t

[PATCH 0 of 3] Directives for enabling http2 and http3

Hi, These patches change http2 and http3 configurations. Previously, both protocols were configured by "listen" parameters: listen 8800 ssl http2; listen 8443 http3; The patches introduce new directives for configuring http2 and http3 in server scope: server { liste

Re: Http2 idle connection and worker shutdown

Thanks again Maxim. Response inlined. > On Oct 20, 2022, at 6:43 PM, Maxim Dounin wrote: > > Hello! > > On Thu, Oct 20, 2022 at 06:09:11PM -0700, Jojy Varghese via nginx-devel wrote: > > [...] > >>> If you think that nginx does something wrong, you may want to >>> elaborate on the details

Re: Http2 idle connection and worker shutdown

Hello! On Thu, Oct 20, 2022 at 06:09:11PM -0700, Jojy Varghese via nginx-devel wrote: [...] > > If you think that nginx does something wrong, you may want to > > elaborate on the details of the incorrect behaviour you observe > > (as well as why you think it's incorrect, and how would you

Re: Http2 idle connection and worker shutdown

Hi Maxim Thanks for the response. Answers inline. -jojy > On Oct 20, 2022, at 2:19 PM, Maxim Dounin wrote: > > Hello! > > On Thu, Oct 20, 2022 at 10:51:06AM -0700, Jojy Varghese via nginx-devel wrote: > >> Hi >> We noticed that the Http2 idle flag >>

Re: Http2 idle connection and worker shutdown

Hello! On Thu, Oct 20, 2022 at 10:51:06AM -0700, Jojy Varghese via nginx-devel wrote: > Hi > We noticed that the Http2 idle flag > (https://github.com/nginx/nginx/blob/master/src/http/v2/ngx_http_v2.h#L126) > is initialized to `1` > (https://github.com/nginx/nginx/blob/

Http2 idle connection and worker shutdown

Hi We noticed that the Http2 idle flag (https://github.com/nginx/nginx/blob/master/src/http/v2/ngx_http_v2.h#L126) is initialized to `1` (https://github.com/nginx/nginx/blob/master/src/http/v2/ngx_http_v2.c#L335) but not reset by the http2 state machine. It also looks like Nginx does

Re: [PATCH] HTTP/2: premalloc http2 recv_buffer in init_conf

53c2d008e > HTTP/2: premalloc http2 recv_buffer in init_conf > > There is no need to check if h2mcf->recv_buffer malloced every time. > > diff -r 87d2ea860f38 -r 1532a8fca7b2 src/http/v2/ngx_http_v2.c > --- a/src/http/v2/ngx_http_v2.cMon Sep 10 18:57:39 2018 +0300 > +++ b/

[PATCH] HTTP/2: premalloc http2 recv_buffer in init_conf

# HG changeset patch # User Kasei Wang # Date 1599480224 -28800 # Mon Sep 07 20:03:44 2020 +0800 # Node ID 1532a8fca7b24c3c3aa5cddd3362402d15f57a4f # Parent 87d2ea860f380dc8418c97c0163412f53c2d008e HTTP/2: premalloc http2 recv_buffer in init_conf There is no need to check if h2mcf

http2.

Hi, I am trying to understand how the modules work when dealing with http2 traffic? Trying to find any documentation or any other info that will tells me how a module should behave when handling http2 traffic. I am assuming the actual http2 protocol parsing is done by the http2 module. How can

Re: http2 broken

Get it, I'll try it, thank you again. On Thu, Jul 12, 2018 at 1:02 AM Maxim Dounin wrote: > Hello! > > On Wed, Jul 11, 2018 at 08:56:56PM +0800, 洪志道 wrote: > > > But there are still some clients use the old version. > > Is it a way to be compatible with it? > > Or other suggestions? > > @Maxim

Re: http2 broken

Hello! On Wed, Jul 11, 2018 at 08:56:56PM +0800, 洪志道 wrote: > But there are still some clients use the old version. > Is it a way to be compatible with it? > Or other suggestions? > @Maxim Dounin As I already wrote in ticket #1397, we can try introducing a workaround in nginx, but I'm not

Re: http2 broken

Thank you. But there are still some clients use the old version. Is it a way to be compatible with it? Or other suggestions? @Maxim Dounin On Wed, Jul 11, 2018 at 5:43 PM tokers wrote: > Hello! > > There is a known issue caused by some obsolete client like old version > okhttp (incomplete

Re: http2 broken

Hello! There is a known issue caused by some obsolete client like old version okhttp (incomplete protocol implements). Here is the ticket: https://trac.nginx.org/nginx/ticket/1397. ___ nginx-devel mailing list nginx-devel@nginx.org

Re: http2 broken

log, 0, "http2 table size update: 0"); -*pos++ = (1 << 5) | 0; h2c->table_update = 0; } @@ -1010,7 +1009,6 @@ ngx_http_v2_push_resource(ngx_http_request_t *r, ngx_str_t *pat if (h2c->table_update) { ngx_log_debug0(NG

http2 broken

Hi. The client can't load the image served by nginx-1.13.6+. [App with Android 7.1.2 4.4.4 4.12 series] It works well in nginx-1.13.5, but go wrong in ngnx-1.13.6+. The change is http://hg.nginx.org/nginx/rev/12cadc4669a7. I found the similar problem.

Re: [PATCH] HTTP/2: make http2 server support http1

gt; +#endif >> + >> static ngx_int_t ngx_http_process_header_line(ngx_http_request_t *r, >>ngx_table_elt_t *h, ngx_uint_t offset); >> static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, >> @@ -325,7 +329,7 @@ ngx_http_ini

Re: [PATCH] HTTP/2: make http2 server support http1

gt; static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, > @@ -325,7 +329,7 @@ ngx_http_init_connection(ngx_connection_t *c) > > #if (NGX_HTTP_V2) > if (hc->addr_conf->http2) { > -rev->handler = ngx_http_v2_init; > +rev->hand

Re: [PATCH] HTTP/2: make http2 server support http1

ngx_int_t ngx_http_process_header_line(ngx_http_request_t *r, ngx_table_elt_t *h, ngx_uint_t offset); static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, @@ -325,7 +329,7 @@ ngx_http_init_connection(ngx_connection_t *c) #if (NGX_HTTP_V2) if (hc->addr_conf->

Re: [PATCH] HTTP/2: make http2 server support http1

On Thursday 08 March 2018 08:42:27 Haitao Lv wrote: > Sorry for disturbing. But I have to fix a buffer overflow bug. > Here is the latest patch. > > Sorry. But please make your comments. Thank you. [..] There's no way for this patch to be accepted as it breaks PROXY protocol functionality.

Re: [PATCH] HTTP/2: make http2 server support http1

ngx_uint_t request_line); >>> >>> +#if (NGX_HTTP_V2) >>> +static void ngx_http_wait_v2_preface_handler(ngx_event_t *rev); >>> +#endif >>> + >>> static ngx_int_t ngx_http_process_header_line(ngx_http_request_t *r, >>> ngx_table_elt_t *h,

Re: [PATCH] HTTP/2: make http2 server support http1

line(ngx_http_request_t *r, > >ngx_table_elt_t *h, ngx_uint_t offset); > > static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, > > @@ -321,7 +325,7 @@ ngx_http_init_connection(ngx_connection_t *c) > > > > #if (NGX_HTTP_V2) > >

Re: [PATCH] HTTP/2: make http2 server support http1

st_t *r, >ngx_table_elt_t *h, ngx_uint_t offset); > static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, > @@ -321,7 +325,7 @@ ngx_http_init_connection(ngx_connection_t *c) > > #if (NGX_HTTP_V2) >if (hc->addr_conf->http2) { > -rev->h

Re: [PATCH] HTTP/2: make http2 server support http1

->addr_conf->http2) { -rev->handler = ngx_http_v2_init; +rev->handler = ngx_http_wait_v2_preface_handler; } #endif @@ -377,6 +381,110 @@ ngx_http_init_connection(ngx_connection_t *c) } +#if (NGX_HTTP_V2) +static void +ngx_http_wait_v2_preface_handler(ngx_

Re: [PATCH] HTTP/2: make http2 server support http1

ngx_http_process_header_line(ngx_http_request_t *r, ngx_table_elt_t *h, ngx_uint_t offset); static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, @@ -321,7 +325,7 @@ ngx_http_init_connection(ngx_connection_t *c) #if (NGX_HTTP_V2) if (hc->addr_conf->http2) { -

Re: [PATCH] HTTP/2: make http2 server support http1

ngx_http_process_header_line(ngx_http_request_t *r, ngx_table_elt_t *h, ngx_uint_t offset); static ngx_int_t ngx_http_process_unique_header_line(ngx_http_request_t *r, @@ -321,7 +325,7 @@ ngx_http_init_connection(ngx_connection_t *c) #if (NGX_HTTP_V2) if (hc->addr_conf->http2) { -

Re: [PATCH] HTTP/2: make http2 server support http1

lentin, and our position is as follows: - The feature itself (autodetection between HTTP/2 and HTTP/1.x protocols) might be usable, and we can consider adding it if there will be a good and simple enough patch. (Moreover, we think that this probably should be the default if "listen ...

Re: [PATCH] HTTP/2: make http2 server support http1

Hello wbr, Thank you for reviewing this patch. > On Mar 5, 2018, at 23:06, Valentin V. Bartenev wrote: > > On Monday 05 March 2018 11:11:08 Haitao Lv wrote: > [..] >>> @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, >>> ngx_buf_t *b) >>>case

Re: [PATCH] HTTP/2: make http2 server support http1

On Monday 05 March 2018 11:11:08 Haitao Lv wrote: [..] > > @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, > > ngx_buf_t *b) > > case sw_start: > > r->request_start = p; > > > > -if (ch == CR || ch == LF) { > > -break; > > -

Re: [PATCH] HTTP/2: make http2 server support http1

> On Mar 5, 2018, at 17:02, Ruslan Ermilov wrote: > > On Mon, Mar 05, 2018 at 11:11:08AM +0800, Haitao Lv wrote: > [...] >>> @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, >>> ngx_buf_t *b) >>>case sw_start: >>>r->request_start = p;

Re: [PATCH] HTTP/2: make http2 server support http1

On Mon, Mar 05, 2018 at 11:11:08AM +0800, Haitao Lv wrote: [...] > > @@ -145,10 +152,6 @@ ngx_http_parse_request_line(ngx_http_request_t *r, > > ngx_buf_t *b) > > case sw_start: > > r->request_start = p; > > > > -if (ch == CR || ch == LF) { > > -

Re: [PATCH] HTTP/2: make http2 server support http1

+1197,7 @@ ngx_http_add_addresses(ngx_conf_t *cf, > ngx_http_core_srv_conf_t *cscf, > ngx_uint_t ssl; > #endif > #if (NGX_HTTP_V2) > +ngx_uint_t http1; > ngx_uint_t http2; > #endif > > @@ -1232,6 +1233,7 @@ ngx_http_add

Re: [PATCH] HTTP/2: make http2 server support http1

> On Mar 4, 2018, at 21:00, Valentin V. Bartenev wrote: > > On Sunday, 4 March 2018 05:53:36 MSK Haitao Lv wrote: >> Hi, wbr, >> >> Thanks for your review. I don't know why I can't receive your email. >> Let me reply directly. >> >>> It doesn't look like a useful feature.

Re: [PATCH] HTTP/2: make http2 server support http1

#if (NGX_HTTP_V2) +ngx_uint_t http1; ngx_uint_t http2; #endif @@ -1232,6 +1233,7 @@ ngx_http_add_addresses(ngx_conf_t *cf, ngx_http_core_srv_conf_t *cscf, ssl = lsopt->ssl || addr[i].opt.ssl; #endif #if (NGX_HTTP_V2) +http1 = lsopt->

Re: [PATCH] HTTP/2: make http2 server support http1

gt; # User 吕海涛 <i...@lvht.net> > # Date 1519976498 -28800 > # Fri Mar 02 15:41:38 2018 +0800 > # Node ID 200955343460c4726015180f20c03e31c0b35ff6 > # Parent 81fae70d6cb81c67607931ec3ecc585a609c97e0 > make http2 server support http1 > > diff -r 81fae70d6cb8 -r 200955343460 sr

Re: [PATCH] HTTP/2: make http2 server support http1

On Friday 02 March 2018 15:53:07 Haitao Lv wrote: > # HG changeset patch > # User 吕海涛 <i...@lvht.net> > # Date 1519976498 -28800 > # Fri Mar 02 15:41:38 2018 +0800 > # Node ID 200955343460c4726015180f20c03e31c0b35ff6 > # Parent 81fae70d6cb81c67607931ec3ecc585a609c

[PATCH] HTTP/2: make http2 server support http1

# HG changeset patch # User 吕海涛 <i...@lvht.net> # Date 1519976498 -28800 # Fri Mar 02 15:41:38 2018 +0800 # Node ID 200955343460c4726015180f20c03e31c0b35ff6 # Parent 81fae70d6cb81c67607931ec3ecc585a609c97e0 make http2 server support http1 diff -r 81fae70d6cb8 -r 200955343460 sr

Re: Contrib: http2 per server (was re: [nginx] support http2 per server)

Not that anybody has responded yet, but please find an important improvement over this patch: -if (hc->addr_conf->http2 && !sscf->h2) { +if (r->http_version == NGX_HTTP_VERSION_20 && !sscf->h2) { Full patch (with this improvement included)

Contrib: http2 per server (was re: [nginx] support http2 per server)

ements / modifications: 1. Default state is set to off during conf merge, so that existing behaviour of enabling http2 directive on the listener and having it apply to all servers is preserved. 2. Attempts to re-use a connection via the listener to access a server without ssl_h2 enabled (i.e, explicit

Re: [nginx] support http2 per server

c; c = ngx_ssl_get_connection(ssl_conn); #endif @@ -367,8 +375,9 @@ #if (NGX_HTTP_V2) hc = c->data; +sscf = ngx_http_get_module_srv_conf(hc->conf_ctx, ngx_http_ssl_module); -if (hc->addr_conf->http2) { + if (hc->addr_conf->http2 && sscf->h2) {

Re: [nginx] support http2 per server

Get it, thanks. On Fri, Jun 9, 2017 at 7:45 PM, Valentin V. Bartenev wrote: > On Friday 09 June 2017 13:40:23 洪志道 wrote: > > Hi, Valentin. > > > > " > > Also please note that with your patch clients are still able to > > negotiate HTTP/2 even if nginx doesn't announce it. > > "

Re: [nginx] support http2 per server

On Friday 09 June 2017 13:40:23 洪志道 wrote: > Hi, Valentin. > > " > Also please note that with your patch clients are still able to > negotiate HTTP/2 even if nginx doesn't announce it. > " > > Two points: > 1. The patch forbids the clients explicitly not support HTTP/2 doing v2 ( >

Re: [nginx] support http2 per server

S connection for the host > >in the URI. > > > > " > > > > > > It seems the brower can prevent the unreasonable behavior. > > > > > > In reallity, It still exist some clients that dosen't perfom well in > http2. > > > > So it

Re: [nginx] support http2 per server

ms the brower can prevent the unreasonable behavior. > > > In reallity, It still exist some clients that dosen't perfom well in http2. > > So it's kind of valuable to enable http2 by server. > > > It's not a good idea the put the patch in nginx, > > Can you help to

Re: [nginx] support http2 per server

he brower can prevent the unreasonable behavior. > > > > > > In reallity, It still exist some clients that dosen't perfom well in > http2. > > > > So it's kind of valuable to enable http2 by server. > > > > > > It's not a good idea the put the patch in

Re: [nginx] support http2 per server

>client would perform when forming a new TLS connection for the host >in the URI. > > " > > > It seems the brower can prevent the unreasonable behavior. > > > In reallity, It still exist some clients that dosen't perfom well in http2. > > So it's k

Re: [nginx] support http2 per server

t in the URI. " It seems the brower can prevent the unreasonable behavior. In reallity, It still exist some clients that dosen't perfom well in http2. So it's kind of valuable to enable http2 by server. It's not a good idea the put the patch in nginx, Can you help to check the pa

Re: [nginx] support http2 per server

On Thursday 08 June 2017 23:19:23 洪志道 wrote: > It sounds right. > > According to the same situation, how does http2 protocol force other > virtual servers to process certificate (ssl handshake). > > Example: > > server { > listen 443 http2; > a.com; >

Re: [nginx] support http2 per server

It sounds right. According to the same situation, how does http2 protocol force other virtual servers to process certificate (ssl handshake). Example: server { listen 443 http2; a.com; ssl_certi; } server { listen 443 http2; b.com; ssl_certi; } We assume sni

Re: [nginx] support http2 per server

On Thursday 08 June 2017 12:07:29 洪志道 wrote: > Hi! > Now, http2 is enabled globally for 'listen' directive with ip:port. > It seems it's possible to enable by server with sni, alpn, npn. > Take a look, please. > [..] How will "sni, alpn, npn" prevent browser from ask

Re: [nginx] support http2 per server

connection(ssl_conn); #endif @@ -367,8 +375,9 @@ #if (NGX_HTTP_V2) hc = c->data; +sscf = ngx_http_get_module_srv_conf(hc->conf_ctx, ngx_http_ssl_module); -if (hc->addr_conf->http2) { + if (hc->addr_conf->http2 && sscf->h2) { srv = (unsi

[nginx] support http2 per server

Hi! Now, http2 is enabled globally for 'listen' directive with ip:port. It seems it's possible to enable by server with sni, alpn, npn. Take a look, please. diff -r 5e05118678af src/http/modules/ngx_http_ssl_module.c --- a/src/http/modules/ngx_http_ssl_module.c Mon May 29 23:33:38 2017 +0300

[nginx] Modules compatibility: http2.

details: http://hg.nginx.org/nginx/rev/bdf64ae3376b branches: changeset: 6718:bdf64ae3376b user: Maxim Dounin <mdou...@mdounin.ru> date: Mon Oct 03 15:58:22 2016 +0300 description: Modules compatibility: http2. HTTP/2-specific fields in structures are now available unconditi

Re: 1.9.14 - http2 protocol violations

On Wednesday 13 April 2016 19:35:25 Валентин Бартенев wrote: > On Wednesday 13 April 2016 18:00:26 Валентин Бартенев wrote: > > On Wednesday 13 April 2016 15:08:29 Otto van der Schaaf wrote: > > > I'm sorry to say that the patch does not make a difference. > > > > > > I collected Chrome's http/2

Re: 1.9.14 - http2 protocol violations

On Wednesday 13 April 2016 18:00:26 Валентин Бартенев wrote: > On Wednesday 13 April 2016 15:08:29 Otto van der Schaaf wrote: > > I'm sorry to say that the patch does not make a difference. > > > > I collected Chrome's http/2 trace for a post to a non-existant url: > >

Re: 1.9.14 - http2 protocol violations

On Wednesday 13 April 2016 15:08:29 Otto van der Schaaf wrote: > I'm sorry to say that the patch does not make a difference. > > I collected Chrome's http/2 trace for a post to a non-existant url: > https://gist.github.com/oschaaf/da273f96fad5e22890981fcd4a1a4376 > > I'm wondering about that

Re: 1.9.14 - http2 protocol violations

I'm sorry to say that the patch does not make a difference. I collected Chrome's http/2 trace for a post to a non-existant url: https://gist.github.com/oschaaf/da273f96fad5e22890981fcd4a1a4376 I'm wondering about that last HTTP2_SESSION_RST_STREAM entry.. it looks like the httpv2 mod wants to

Re: 1.9.14 - http2 protocol violations

On Wednesday 13 April 2016 15:30:39 Валентин Бартенев wrote: > On Wednesday 13 April 2016 13:54:24 Otto van der Schaaf wrote: > > Sure. > > > > - This sample contains to or three requests, the last request is where rate > > limiting kicks in and the protocol error happens (the earlier requests

Re: 1.9.14 - http2 protocol violations

nx-tmpbuild --with-http_v2_module > > --with-http_ssl_module > > > > 1.9.14 seems to have introduced some behavioral changes only noticable on > > http2, there seem to be similar breakages in some of ngx_pagespeed's > flows. > > > > One thing we do is perfor

Re: 1.9.14 - http2 protocol violations

_PROTOCOL_ERROR). > > This happens with a plain nginx build, configure arguments: > --prefix=/home/oschaaf/nginx-tmpbuild --with-http_v2_module > --with-http_ssl_module > > 1.9.14 seems to have introduced some behavioral changes only noticable on > http2, there seem to be similar breaka

1.9.14 - http2 protocol violations

/oschaaf/nginx-tmpbuild --with-http_v2_module --with-http_ssl_module 1.9.14 seems to have introduced some behavioral changes only noticable on http2, there seem to be similar breakages in some of ngx_pagespeed's flows. One thing we do is perform an async lookup in the preaccess phase - doing so when

[nginx] SSL: only select HTTP/2 using NPN if "http2" is enabled.

details: http://hg.nginx.org/nginx/rev/909b5b191f25 branches: changeset: 6289:909b5b191f25 user: Valentin Bartenev <vb...@nginx.com> date: Thu Nov 05 15:01:09 2015 +0300 description: SSL: only select HTTP/2 using NPN if "http2" is enabled. OpenSSL doesn't check i

Re: subrequest error with http2

Hello! On Tue, Oct 6, 2015 at 5:33 PM, Carlos Eduardo Ferreira Rodrigues wrote: > I'm aware 1.9.5 isn't supported yet and that SPDY is mentioned in the docs as > non-working for certain API calls > as well. However, we are have been using location.capture with SPDY for a > while now and haven't

RE: subrequest error with http2

] Sent: Tuesday, October 06, 2015 4:01 To: nginx-devel@nginx.org Subject: Re: subrequest error with http2 Hello! On Wed, Sep 23, 2015 at 1:14 AM, Carlos Eduardo Ferreira Rodrigues wrote: > I just upgraded nginx to 1.9.5 on our testing enviroment, and immediately > started seeing this

Re: subrequest error with http2

Hello! On Wed, Sep 23, 2015 at 1:14 AM, Carlos Eduardo Ferreira Rodrigues wrote: > I just upgraded nginx to 1.9.5 on our testing enviroment, and immediately > started seeing this error on http2 requests: > > 2015/09/22 18:04:06 [alert] 27305#27305: *1 epoll_ctl(1, 17) failed (17: Fi

Re: subrequest error with http2

Hello! On Wed, Sep 23, 2015 at 1:34 AM, Maxim Dounin wrote: > > The lua module deeply integrates into nginx internals (far beyond > what we consider to be nginx modules API), and there is no surprise > it's broken by the changes in nginx 1.9.5. > True. This is also why ngx_lua has so many

Re: subrequest error with http2

Hello! On Tue, Sep 22, 2015 at 06:14:56PM +0100, Carlos Eduardo Ferreira Rodrigues wrote: > Hi, > > I just upgraded nginx to 1.9.5 on our testing enviroment, and immediately > started seeing this error on http2 requests: > > 2015/09/22 18:04:06 [alert] 27305#27305: *1 epoll

Re: http2 slow loading

On Monday 17 August 2015 22:50:29 Chris Vancoillie wrote: Hi Herewith attached debug log for slow loading issue testing with patch v2. The log looks incomplete, it seems you put the error_log directive with the debug option not in the main level of configuration, but in some level below. As

Re: http2 broke links in code

Thanks - work fine now! Valentin V. Bartenev mailto:vb...@nginx.com August 14, 2015 at 7:11 PM [...] Thanks for the report. Please, try the new patch: http://nginx.org/patches/http2/ wbr, Valentin V. Bartenev ___ nginx-devel mailing list nginx

http2 broke links in code

Default ssl configuration: link rel=stylesheet media=all href=//www.domain.ru/css2/reset-min.css When enable http2 link brokes link rel=stylesheet media=all href=///css2/reset-min.css ___ nginx-devel mailing list nginx-devel@nginx.org http

Re: http2 broke links in code

/lib/nginx/php-fpm.sock; fastcgi_index index.php; fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name; fastcgi_split_path_info ^(.+\.php)(/.+)$; try_files $uri =404; } When enable http2 variable HTTP_HOST absent in phpinfo If set