[GitHub] [accumulo] arvindshmicrosoft opened a new pull request #1571: Fix ArrayIndexOutOfBoundsException in importdir

arvindshmicrosoft opened a new pull request #1571: Fix ArrayIndexOutOfBoundsException in importdir URL: https://github.com/apache/accumulo/pull/1571 **Fix details** The importdirectory command implementation within the shell now checks for the expected number of arguments and safely han

[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397619369 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +

[GitHub] [accumulo] ctubbsii commented on issue #1568: Support multiple tservers / node in accumulo-service

ctubbsii commented on issue #1568: Support multiple tservers / node in accumulo-service URL: https://github.com/apache/accumulo/pull/1568#issuecomment-603600158 > @ctubbsii I have redone this PR (hence the force push). Hopefully this version is more aligned with the guiding principles for

[GitHub] [accumulo] arvindshmicrosoft commented on issue #1568: Support multiple tservers / node in accumulo-service

arvindshmicrosoft commented on issue #1568: Support multiple tservers / node in accumulo-service URL: https://github.com/apache/accumulo/pull/1568#issuecomment-603590280 @ctubbsii I have redone this PR (hence the force push). Hopefully this version is more aligned with the guiding principl

[GitHub] [accumulo] etseidl commented on issue #1445: add erasure coding and storage policy to table/namespace settings

etseidl commented on issue #1445: add erasure coding and storage policy to table/namespace settings URL: https://github.com/apache/accumulo/pull/1445#issuecomment-603555031 Gotcha. In the future I'll just merge then, and let all the merge commits get squashed later. -

[GitHub] [accumulo] ctubbsii edited a comment on issue #1438: Add Automatic-Module-Name to JAR manifest

ctubbsii edited a comment on issue #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#issuecomment-603546450 > There is an open issue that gives the same error: https://issues.apache.org/jira/browse/MJAVADOC-614 > It is for a different rea

[GitHub] [accumulo] ctubbsii commented on issue #1438: Add Automatic-Module-Name to JAR manifest

ctubbsii commented on issue #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#issuecomment-603546450 > There is an open issue that gives the same error: https://issues.apache.org/jira/browse/MJAVADOC-614 > It is for a different reason so n

[GitHub] [accumulo] milleruntime commented on issue #1438: Add Automatic-Module-Name to JAR manifest

milleruntime commented on issue #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#issuecomment-603509229 There is an open issue that gives the same error: https://issues.apache.org/jira/browse/MJAVADOC-614 It is for a different reason so n

[GitHub] [accumulo] ctubbsii edited a comment on issue #1445: add erasure coding and storage policy to table/namespace settings

ctubbsii edited a comment on issue #1445: add erasure coding and storage policy to table/namespace settings URL: https://github.com/apache/accumulo/pull/1445#issuecomment-603506903 > @ctubbsii Sorry...yes, I was trying to stave off the bit rot that was setting in relative to master. What i

[GitHub] [accumulo] ctubbsii commented on issue #1445: add erasure coding and storage policy to table/namespace settings

ctubbsii commented on issue #1445: add erasure coding and storage policy to table/namespace settings URL: https://github.com/apache/accumulo/pull/1445#issuecomment-603506903 > @ctubbsii Sorry...yes, I was trying to stave off the bit rot that was setting in relative to master. What is the p

[GitHub] [accumulo] ctubbsii commented on issue #1438: Add Automatic-Module-Name to JAR manifest

ctubbsii commented on issue #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#issuecomment-603499025 Seems like the new javadoc plugin is broken... it won't let you have a `package-info.java` file in an otherwise empty package. It fails with

[GitHub] [accumulo] milleruntime commented on a change in pull request #1438: Add Automatic-Module-Name to JAR manifest

milleruntime commented on a change in pull request #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#discussion_r397439313 ## File path: test/pom.xml ## @@ -30,6 +30,7 @@ Apache Accumulo Testing Tests for Apache Accumu

[GitHub] [accumulo] ctubbsii commented on a change in pull request #1438: Add Automatic-Module-Name to JAR manifest

ctubbsii commented on a change in pull request #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#discussion_r397435574 ## File path: test/pom.xml ## @@ -30,6 +30,7 @@ Apache Accumulo Testing Tests for Apache Accumulo.

[GitHub] [accumulo] rcarterjr commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit

rcarterjr commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit URL: https://github.com/apache/accumulo/pull/1487#discussion_r397420003 ## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ## @@ -1005,

[GitHub] [accumulo] rcarterjr commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit

rcarterjr commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit URL: https://github.com/apache/accumulo/pull/1487#discussion_r397419247 ## File path: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ## @@ -1005,

[GitHub] [accumulo] milleruntime merged pull request #1570: Drop overloaded ClientContext constructors

milleruntime merged pull request #1570: Drop overloaded ClientContext constructors URL: https://github.com/apache/accumulo/pull/1570 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [accumulo] milleruntime commented on issue #1570: Drop overloaded ClientContext constructors

milleruntime commented on issue #1570: Drop overloaded ClientContext constructors URL: https://github.com/apache/accumulo/pull/1570#issuecomment-603456834 These changes are mostly cleaning up internal code and adding comments to assist with maintainability so I am going to merge this PR.

[GitHub] [accumulo] milleruntime commented on issue #1438: Add Automatic-Module-Name to JAR manifest

milleruntime commented on issue #1438: Add Automatic-Module-Name to JAR manifest URL: https://github.com/apache/accumulo/pull/1438#issuecomment-603453765 This is passing with the latest version of the javadoc plugin. I believe the question is whether or not we still want to implement these

[GitHub] [accumulo] etseidl commented on issue #1445: add erasure coding and storage policy to table/namespace settings

etseidl commented on issue #1445: add erasure coding and storage policy to table/namespace settings URL: https://github.com/apache/accumulo/pull/1445#issuecomment-603371671 @ctubbsii Sorry...yes, I was trying to stave off the bit rot that was setting in relative to master. What is the pre

[GitHub] [accumulo] milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397293188 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +251,9

[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397259497 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +

[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397259497 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +

[GitHub] [accumulo] milleruntime opened a new pull request #1570: Drop overloaded ClientContext constructors

milleruntime opened a new pull request #1570: Drop overloaded ClientContext constructors URL: https://github.com/apache/accumulo/pull/1570 * Moved some logic to classes creating ClientContext objects * Overloaded constructors obscured the object creation and static singleton managemen

[GitHub] [accumulo] arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

arvindshmicrosoft commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397225033 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +

[GitHub] [accumulo] milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397204780 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +251,9

[GitHub] [accumulo] keith-turner commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

keith-turner commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397182330 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +251,9

[GitHub] [accumulo] milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable

milleruntime commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable URL: https://github.com/apache/accumulo/pull/1569#discussion_r397131895 ## File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java ## @@ -251,6 +251,9