[GitHub] [apisix] spacewander commented on a change in pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox
spacewander commented on a change in pull request #3815: URL: https://github.com/apache/apisix/pull/3815#discussion_r592967287 ## File path: docs/zh/latest/admin-api.md ## @@ -23,7 +23,7 @@ title: Admin API ## 目录 -- [目录](#目录) +- [目录](#%e7%9b%ae%e5%bd%95) Review comment:

[GitHub] [apisix] spacewander opened a new pull request #3816: test: make node/priority-balancer/sanity.t stable

2021-03-11 Thread GitBox
spacewander opened a new pull request #3816: URL: https://github.com/apache/apisix/pull/3816 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] tzssangglass commented on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox
tzssangglass commented on issue #3692: URL: https://github.com/apache/apisix/issues/3692#issuecomment-797297250 > Hi @tzssangglass are you still working on this 😀 I could take care of it if you do not got enough time okay, I haven't had enough time lately, so leave it to you. -

[GitHub] [apisix-dashboard] nic-chen commented on issue #1482: how to delete the historical version of the APISIX node.

2021-03-11 Thread GitBox
nic-chen commented on issue #1482: URL: https://github.com/apache/apisix-dashboard/issues/1482#issuecomment-797294000 @bisakhmondal Thanks ! I think you could try to submit a proposal for this change : ) This is

[GitHub] [apisix] spacewander merged pull request #3814: docs: use the build script which is more up-to-date.

2021-03-11 Thread GitBox
spacewander merged pull request #3814: URL: https://github.com/apache/apisix/pull/3814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: docs: use the build script which is more up-to-date. (#3814)

2021-03-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 038acfc docs: use the build script which i

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
nic-chen commented on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-797291310 Thanks! @Jaycean This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] nic-chen merged pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
nic-chen merged pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo (#1570)

2021-03-11 Thread chenjunxu
This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 48e66cd feat: rewrite e2e test(re

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox
Firstsawyou commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-797288180 Hi, @jbampton A new version of `api7/jsonschema` has been released, you can now try to update the following two parts of the code: ```shell diff --git a/rockspe

[GitHub] [apisix] membphis commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox
membphis commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-797280721 > The PR has been submitted:[api7/jsonschema#57](https://github.com/api7/jsonschema/pull/57) merged and released new version, please take a look: ![image](https://

[apisix] branch master updated (00baca2 -> 20ee3c1)

2021-03-11 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 00baca2 docs: added generated contributor over time service provider (#3813) add 20ee3c1 feat: add a safe e

[GitHub] [apisix] membphis merged pull request #3812: feat: add a safe exit to disable sync conf during start

2021-03-11 Thread GitBox
membphis merged pull request #3812: URL: https://github.com/apache/apisix/pull/3812 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-helm-chart] gxthrj merged pull request #41: fix: unified subchart value name

2021-03-11 Thread GitBox
gxthrj merged pull request #41: URL: https://github.com/apache/apisix-helm-chart/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[apisix-helm-chart] branch master updated: fix: unified subchart value name (#41)

2021-03-11 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 23b0216 fix: unified subchart value nam

[GitHub] [apisix] juzhiyuan commented on pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox
juzhiyuan commented on pull request #3815: URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273854 ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] moonming commented on pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox
moonming commented on pull request #3815: URL: https://github.com/apache/apisix/pull/3815#issuecomment-797273544 @juzhiyuan please update the dashboard repo. This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] moonming opened a new pull request #3815: doc: make the document easier to read about upstream host.

2021-03-11 Thread GitBox
moonming opened a new pull request #3815: URL: https://github.com/apache/apisix/pull/3815 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have yo

[GitHub] [apisix-website] qier222 commented on issue #259: invalid URLs in translation docs

2021-03-11 Thread GitBox
qier222 commented on issue #259: URL: https://github.com/apache/apisix-website/issues/259#issuecomment-797272642 My last PR only replace links referenced to a markdown file. eureka.lua is not an article, maybe we should place it inside the assets folder. --

[GitHub] [apisix-ingress-controller] Junnplus commented on a change in pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox
Junnplus commented on a change in pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296#discussion_r592941271 ## File path: pkg/ingress/controller/controller.go ## @@ -137,7 +137,7 @@ func NewController(cfg *config.Config) (*Controller, error) {

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox
gxthrj commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797270041 > Not till now. I am having issues in understanding what is the problem? This is an autom

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox
iamayushdas commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797264551 Not till now. I am having issues in understanding This is an automated message from the Ap

[GitHub] [apisix-website] juzhiyuan opened a new issue #259: invalid URLs in translation docs

2021-03-11 Thread GitBox
juzhiyuan opened a new issue #259: URL: https://github.com/apache/apisix-website/issues/259 # Improve Docs ## Please describe which part of docs should be improved or typo fixed Hi, we have contributors who noticed that there have some broken links in translated docs: e

[GitHub] [apisix] juzhiyuan commented on pull request #3794: docs: fixed invalid URLs in translation docs

2021-03-11 Thread GitBox
juzhiyuan commented on pull request #3794: URL: https://github.com/apache/apisix/pull/3794#issuecomment-797263301 https://github.com/apache/apisix-website/pull/257 Hi, this PR fixes most issues, we could close this PR IMO. cc @iamayushdas Thanks for your watch and contribution!

[GitHub] [apisix] juzhiyuan closed pull request #3794: docs: fixed invalid URLs in translation docs

2021-03-11 Thread GitBox
juzhiyuan closed pull request #3794: URL: https://github.com/apache/apisix/pull/3794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] juzhiyuan commented on issue #3791: invalid URLs in translation docs

2021-03-11 Thread GitBox
juzhiyuan commented on issue #3791: URL: https://github.com/apache/apisix/issues/3791#issuecomment-797262950 Hi, @qier222 , after your last PR gets merged, most issues were resolved. I noticed that there has one `lua` file which is missing. ![image](https://user-images.githubusercon

[GitHub] [apisix-ingress-controller] soulsoul commented on issue #294: architecture diagram

2021-03-11 Thread GitBox
soulsoul commented on issue #294: URL: https://github.com/apache/apisix-ingress-controller/issues/294#issuecomment-797262437 nice! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #283: docs: update deployments repository url

2021-03-11 Thread GitBox
gxthrj commented on pull request #283: URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-797261594 Any update? @stu01509 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-11 Thread GitBox
gxthrj commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-797261233 Any update? @iamayushdas This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox
gxthrj commented on a change in pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296#discussion_r592932371 ## File path: pkg/ingress/controller/controller.go ## @@ -137,7 +137,7 @@ func NewController(cfg *config.Config) (*Controller, error) {

[GitHub] [apisix] Yiyiyimu edited a comment on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox
Yiyiyimu edited a comment on issue #3692: URL: https://github.com/apache/apisix/issues/3692#issuecomment-797259563 Hi @tzssangglass are you still working on this 😀 I could take care of it if you do not got enough time This i

[GitHub] [apisix] Yiyiyimu commented on issue #3692: [discuss]: enable etcd health check

2021-03-11 Thread GitBox
Yiyiyimu commented on issue #3692: URL: https://github.com/apache/apisix/issues/3692#issuecomment-797259563 Hi @tzssangglass are you still working on this 😀 This is an automated message from the Apache Git Service. To respon

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox
Firstsawyou commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-797258954 > > 2、[api7/jsonschema](https://github.com/api7/jsonschema) has not released a new version after `sctrictly` is fixed (`sctrictly` -> `strictly`). We need to release a new ve

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox
gxthrj merged pull request #297: URL: https://github.com/apache/apisix-ingress-controller/pull/297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated (e2ddfad -> 8221ce6)

2021-03-11 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from e2ddfad fix: grammar typo (#291) add 8221ce6 chore: release 0.4.0 (#297) No new revisions wer

[GitHub] [apisix-ingress-controller] debu99 commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox
debu99 commented on issue #136: URL: https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797246675 Yes, I would like to use git/yaml to update routing info, like Kong dbless This is an automated mess

[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox
tokers commented on issue #293: URL: https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797245654 > > We should use `Networking().V1beta1().Ingress().Informer(). > > yep, I make a PR to fixed. > > > Some users running versions < Kubernetes 1.14 >

[GitHub] [apisix-ingress-controller] tokers commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox
tokers commented on issue #136: URL: https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797244660 @debu99 By using the term "standalone", what's your exact meaning? Does it mean do not rely on ETCD?

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr&el=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox
codecov-io edited a comment on pull request #297: URL: https://github.com/apache/apisix-ingress-controller/pull/297#issuecomment-797239231 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr&el=h1) Report > Merging [#297](https://codecov.io/gh/apache/api

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr&el=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox
codecov-io commented on pull request #297: URL: https://github.com/apache/apisix-ingress-controller/pull/297#issuecomment-797239231 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/297?src=pr&el=h1) Report > Merging [#297](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
Jaycean commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592913445 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
codecov-io edited a comment on pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#issuecomment-795454945 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1570?src=pr&el=h1) Report > Merging [#1570](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] starsz commented on issue #1265: use apisix-docker to manage Dockerfile

2021-03-11 Thread GitBox
starsz commented on issue #1265: URL: https://github.com/apache/apisix-dashboard/issues/1265#issuecomment-797235989 > > ref to [apache/apisix-docker#150](https://github.com/apache/apisix-docker/pull/150) > > @gxthrj That is just adding dashboard in docker-compose example.. Ye

[GitHub] [apisix-docker] starsz commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr

2021-03-11 Thread GitBox
starsz commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-797235184 Good. @pahud Can you create a PR for it? Thank you very much. This is an automated message from the Apache Git Ser

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
starsz commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592910565 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[apisix-ingress-controller] branch v0.4.0 updated (1e96f8a -> 317bbec)

2021-03-11 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to branch v0.4.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from 1e96f8a chore: modify default version to 0.4.0 add 317bbec fix: lint No new revisions were ad

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
starsz commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592909965 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [apisix-ingress-controller] gxthrj opened a new pull request #297: chore: release 0.4.0

2021-03-11 Thread GitBox
gxthrj opened a new pull request #297: URL: https://github.com/apache/apisix-ingress-controller/pull/297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[apisix-ingress-controller] tag 0.4.0 created (now 1e96f8a)

2021-03-11 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to tag 0.4.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. at 1e96f8a (commit) No new revisions were added by this update.

[apisix-website] branch master updated: fix: update sync-docs.js (#257)

2021-03-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 15572f2 fix: update sync-docs.js (#2

[GitHub] [apisix-website] juzhiyuan merged pull request #257: fix: update sync-docs.js

2021-03-11 Thread GitBox
juzhiyuan merged pull request #257: URL: https://github.com/apache/apisix-website/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-website] gxthrj merged pull request #258: docs: add docs for ingress 0.4.0

2021-03-11 Thread GitBox
gxthrj merged pull request #258: URL: https://github.com/apache/apisix-website/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix-website] branch master updated: docs: add docs for ingress 0.4.0 (#258)

2021-03-11 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 0dfff69 docs: add docs for ingress 0.4.0 (

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
Jaycean commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592899777 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [apisix-website] gxthrj opened a new pull request #258: docs: add docs for ingress 0.4.0

2021-03-11 Thread GitBox
gxthrj opened a new pull request #258: URL: https://github.com/apache/apisix-website/pull/258 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated message

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
nic-chen commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592892360 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [apisix-dashboard] nic-chen commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds

2021-03-11 Thread GitBox
nic-chen commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-797215540 ping @stu01509 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [apisix-dashboard] nic-chen commented on issue #1265: use apisix-docker to manage Dockerfile

2021-03-11 Thread GitBox
nic-chen commented on issue #1265: URL: https://github.com/apache/apisix-dashboard/issues/1265#issuecomment-797215376 > ref to [apache/apisix-docker#150](https://github.com/apache/apisix-docker/pull/150) @gxthrj That is just adding dashboard in docker-compose example.. --

[apisix] branch master updated (83537ad -> 00baca2)

2021-03-11 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 83537ad feat: load etcd configuration when apisix starts (#3799) add 00baca2 docs: added generated contri

[GitHub] [apisix] spacewander merged pull request #3813: docs: added generated contributor over time service provider

2021-03-11 Thread GitBox
spacewander merged pull request #3813: URL: https://github.com/apache/apisix/pull/3813 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] yangxikun closed issue #3804: request help: How to log upstream.name in access log?

2021-03-11 Thread GitBox
yangxikun closed issue #3804: URL: https://github.com/apache/apisix/issues/3804 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] yangxikun commented on issue #3804: request help: How to log upstream.name in access log?

2021-03-11 Thread GitBox
yangxikun commented on issue #3804: URL: https://github.com/apache/apisix/issues/3804#issuecomment-797206001 ok, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox
codecov-io commented on pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296#issuecomment-797204573 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/296?src=pr&el=h1) Report > Merging [#296](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
Jaycean commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592880742 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1570: feat: rewrite e2e test(rewrite-e2e-test-route-with-scripte-luacode-test) with ginkgo

2021-03-11 Thread GitBox
Jaycean commented on a change in pull request #1570: URL: https://github.com/apache/apisix-dashboard/pull/1570#discussion_r592880742 ## File path: api/test/e2enew/route/route_with_script_luacode_test.go ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [apisix-helm-chart] Junnplus opened a new pull request #41: fix: unified subchart value name

2021-03-11 Thread GitBox
Junnplus opened a new pull request #41: URL: https://github.com/apache/apisix-helm-chart/pull/41 before: `helm install apisix apisix/apisix --set ingressController.enabled=true --set ingress-controller.replicaCount=2` after: `helm install apisix apisix/apisix --set ingress-con

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox
Junnplus edited a comment on issue #293: URL: https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653 > We should use `Networking().V1beta1().Ingress().Informer(). yep, I make a PR to fixed. > Some users running versions < Kubernetes 1.14 I

[GitHub] [apisix-ingress-controller] Junnplus edited a comment on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox
Junnplus edited a comment on issue #293: URL: https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653 > We should use `Networking().V1beta1().Ingress().Informer(). yep, I make a PR to fixed. > Some users running versions < Kubernetes 1.14 I

[GitHub] [apisix-ingress-controller] Junnplus commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox
Junnplus commented on issue #293: URL: https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797198653 > We should use `Networking().V1beta1().Ingress().Informer(). ye, I make a PR to fixed. > Some users running versions < Kubernetes 1.14 In additi

[GitHub] [apisix-ingress-controller] Junnplus opened a new pull request #296: fix: use networking informer instead of extensions

2021-03-11 Thread GitBox
Junnplus opened a new pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - Related issues ___ ### Bugfix - Description

[apisix] branch juzhiyuan-patch-1 updated (428ced9 -> 5be7ddc)

2021-03-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 428ced9 docs: added service provider add 5be7ddc Update README.md No new revisions were added b

[GitHub] [apisix] spacewander opened a new pull request #3814: docs: use the build script which is more up-to-date.

2021-03-11 Thread GitBox
spacewander opened a new pull request #3814: URL: https://github.com/apache/apisix/pull/3814 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] juzhiyuan opened a new pull request #3813: docs: added service provider

2021-03-11 Thread GitBox
juzhiyuan opened a new pull request #3813: URL: https://github.com/apache/apisix/pull/3813 ### What this PR does / why we need it: added service provider ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[apisix] 01/01: docs: added service provider

2021-03-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git commit 428ced9eb5692154fea9e08c8a142eb7735aff0c Author: 琚致远 AuthorDate: Fri Mar 12 10:11:01 2021 +0800 docs:

[apisix] branch juzhiyuan-patch-1 created (now 428ced9)

2021-03-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. at 428ced9 docs: added service provider This branch includes the following new commits: new 428ced

[GitHub] [apisix] spacewander opened a new pull request #3812: feat: add a safe exit to disable sync conf during start

2021-03-11 Thread GitBox
spacewander opened a new pull request #3812: URL: https://github.com/apache/apisix/pull/3812 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] membphis commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox
membphis commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-797179334 > 2、[api7/jsonschema](https://github.com/api7/jsonschema) has not released a new version after `sctrictly` is fixed (`sctrictly` -> `strictly`). We need to release a new version

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1577: fix: fix fe ci failed

2021-03-11 Thread GitBox
juzhiyuan merged pull request #1577: URL: https://github.com/apache/apisix-dashboard/pull/1577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: fix: fix fe ci failed (#1577)

2021-03-11 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new afa05e7 fix: fix fe ci failed (#15

[GitHub] [apisix-docker] membphis commented on issue #149: [DISCUSS]Link access log and error log to stdout and stderr

2021-03-11 Thread GitBox
membphis commented on issue #149: URL: https://github.com/apache/apisix-docker/issues/149#issuecomment-797175798 sorry for my late reply. I was hesitant before, but after looking at other projects such as Nginx, I think this method is good. https://github.com/nginxinc/docker-

[GitHub] [apisix-ingress-controller] debu99 commented on issue #136: How does the ingress controller work well with dashboard without relying on the Apache APISIX-Admin api?

2021-03-11 Thread GitBox
debu99 commented on issue #136: URL: https://github.com/apache/apisix-ingress-controller/issues/136#issuecomment-797167805 I need standalone mode for apisix ingress controller, does it currently support? This is an automate

[GitHub] [apisix] tzssangglass commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-11 Thread GitBox
tzssangglass commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r592844344 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err =

[GitHub] [apisix-ingress-controller] tokers commented on issue #293: bug: crash when exist v1beta1.Ingress of extensions

2021-03-11 Thread GitBox
tokers commented on issue #293: URL: https://github.com/apache/apisix-ingress-controller/issues/293#issuecomment-797164418 @Junnplus Seems we have a bug here: ![image](https://user-images.githubusercontent.com/10428333/110876941-7413bd00-8313-11eb-9a22-8139cea16f10.png) We should

[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-11 Thread GitBox
spacewander commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r592841252 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err =

[GitHub] [apisix-ingress-controller] tokers commented on issue #295: request help: Both v1 and v1beta of ingress are supported

2021-03-11 Thread GitBox
tokers commented on issue #295: URL: https://github.com/apache/apisix-ingress-controller/issues/295#issuecomment-797162872 @Junnplus Kubernetes will create `v1` incarnation replica when you create a `v1beta1` version Ingress and vice versa. What the `--ingress-version` does is tell the co

[GitHub] [apisix] tokers merged pull request #3799: feat: load etcd configuration when apisix starts

2021-03-11 Thread GitBox
tokers merged pull request #3799: URL: https://github.com/apache/apisix/pull/3799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tokers closed issue #3370: bug: http service should not be started before etcd data is pulled

2021-03-11 Thread GitBox
tokers closed issue #3370: URL: https://github.com/apache/apisix/issues/3370 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[apisix] branch master updated (843a652 -> 83537ad)

2021-03-11 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 843a652 docs: update the admin-api.md document (#3805) add 83537ad feat: load etcd configuration when apisix s

[GitHub] [apisix-ingress-controller] tokers merged pull request #291: fix: grammar typo

2021-03-11 Thread GitBox
tokers merged pull request #291: URL: https://github.com/apache/apisix-ingress-controller/pull/291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: fix: grammar typo (#291)

2021-03-11 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new e2ddfad fix: grammar typo (#

[GitHub] [apisix] tokers closed issue #3802: docs: update the admin-api.md document

2021-03-11 Thread GitBox
tokers closed issue #3802: URL: https://github.com/apache/apisix/issues/3802 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[apisix] branch master updated: docs: update the admin-api.md document (#3805)

2021-03-11 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 843a652 docs: update the admin-api.md document

[GitHub] [apisix] tokers merged pull request #3805: docs: update the admin-api.md document

2021-03-11 Thread GitBox
tokers merged pull request #3805: URL: https://github.com/apache/apisix/pull/3805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander commented on issue #3811: request help: is there dbless version for apisix

2021-03-11 Thread GitBox
spacewander commented on issue #3811: URL: https://github.com/apache/apisix/issues/3811#issuecomment-797161681 Does standalone mode satisfy your requirement? https://github.com/apache/apisix/blob/master/docs/en/latest/stand-alone.md --

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox
codecov-io commented on pull request #291: URL: https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-797161470 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/291?src=pr&el=h1) Report > Merging [#291](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-ingress-controller] tokers commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox
tokers commented on pull request #291: URL: https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-797154565 @fredster33 Don't worry, I have solved these conflicts. This is an automated message from the Ap

[GitHub] [apisix-ingress-controller] fredster33 commented on pull request #291: Grammar fix

2021-03-11 Thread GitBox
fredster33 commented on pull request #291: URL: https://github.com/apache/apisix-ingress-controller/pull/291#issuecomment-796938156 > @fredster33 There are conflicting files Hmm, it seems like somebody else edited the README after my change. How could this be resolved? ---

[GitHub] [apisix] Firstsawyou commented on pull request #3253: chore: fix spelling

2021-03-11 Thread GitBox
Firstsawyou commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-796899591 > @Firstsawyou > > Do you have time to find out why the test case failed? You can submit a patch for @jbampton > > help him to finish this PR, many thx Th

  1   2   >