[GitHub] [apisix] membphis commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-29 Thread GitBox
membphis commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603401795 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -91,7 +91,8 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`. |

[GitHub] [apisix] membphis merged pull request #3927: test: enable master-worker mode by default

2021-03-29 Thread GitBox
membphis merged pull request #3927: URL: https://github.com/apache/apisix/pull/3927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix] branch master updated: test: enable master-worker mode by default (#3927)

2021-03-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 86e168e test: enable master-worker mode by

[GitHub] [apisix] membphis merged pull request #3926: ci: the last day of travis

2021-03-29 Thread GitBox
membphis merged pull request #3926: URL: https://github.com/apache/apisix/pull/3926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix] branch master updated: ci: the last day of travis (#3926)

2021-03-29 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 664c760 ci: the last day of travis (#3926)

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1685: docs: tells users where they are

2021-03-29 Thread GitBox
juzhiyuan commented on pull request #1685: URL: https://github.com/apache/apisix-dashboard/pull/1685#issuecomment-809464238 I would prefer only to update the Title, keep the path as `/create/edit/`, it's more clear for users to know what happened to this URL. As for the title,

[GitHub] [apisix] Firstsawyou opened a new issue #3939: docs: update limit-count.md document

2021-03-29 Thread GitBox
Firstsawyou opened a new issue #3939: URL: https://github.com/apache/apisix/issues/3939 # Improve Docs ## Please describe which part of docs should be improved or typo fixed In fact, the `redis-cluster` strategy in the limit-count plug-in already supports the configuration of

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-29 Thread GitBox
juzhiyuan merged pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[apisix-dashboard] branch master updated: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo (#1675)

2021-03-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new e25afe3 feat: rewrite e2e

[apisix-website] branch master updated: feat: support apisix-docker (#275)

2021-03-29 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 1bcaba3 feat: support apisix-docker

[GitHub] [apisix-website] juzhiyuan merged pull request #275: Feat #216 add project 2

2021-03-29 Thread GitBox
juzhiyuan merged pull request #275: URL: https://github.com/apache/apisix-website/pull/275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix] juzhiyuan commented on a change in pull request #3926: ci: the last day of travis

2021-03-29 Thread GitBox
juzhiyuan commented on a change in pull request #3926: URL: https://github.com/apache/apisix/pull/3926#discussion_r603370855 ## File path: Makefile ## @@ -240,11 +240,11 @@ test: ### license-check:Check Lua source code for Apache License .PHONY: license-check

[GitHub] [apisix] supermario1990 opened a new pull request #3938: docs: add chinese version of dubbo-proxy.md

2021-03-29 Thread GitBox
supermario1990 opened a new pull request #3938: URL: https://github.com/apache/apisix/pull/3938 ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ]

[GitHub] [apisix] Firstsawyou opened a new issue #3937: [discuss]: when a node in the etcd cluster fails, no error log is output

2021-03-29 Thread GitBox
Firstsawyou opened a new issue #3937: URL: https://github.com/apache/apisix/issues/3937 ### Issue description In an etcd cluster (3 nodes), when one of the nodes fails. The following error message will be printed in the error.log:

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
gxthrj commented on a change in pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603331684 ## File path: test/e2e/ingress/resourcepushing.go ## @@ -99,14 +98,56 @@ spec: err = s.EnsureNumApisixUpstreamsCreated(1)

[GitHub] [apisix-dashboard] defp commented on issue #1397: feat: Customize the configurations of Semantic-Pull-Request check in CI

2021-03-29 Thread GitBox
defp commented on issue #1397: URL: https://github.com/apache/apisix-dashboard/issues/1397#issuecomment-809411576 > By default types specified in commitizen/conventional-commit-types is used. > See: https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json

[GitHub] [apisix-dashboard] defp opened a new pull request #1688: feat: added policy for semantic-pr

2021-03-29 Thread GitBox
defp opened a new pull request #1688: URL: https://github.com/apache/apisix-dashboard/pull/1688 Please answer these questions before submitting a pull request, **or your PR will get closed**. - [x] New feature provided **What changes will this PR take into?**

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603319995 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #318: request help:

2021-03-29 Thread GitBox
gxthrj commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809382637 Please show the APISIX version, you had better use APISIX 2.4 version . -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #318: request help:

2021-03-29 Thread GitBox
pioneer-hash commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809345678 > Please add the apisix version and apisix-ingress-controller version. > > Also, please add title. apisix version is apache/apisix:latest --

[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #318: request help:

2021-03-29 Thread GitBox
pioneer-hash commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809340430 > Please add the apisix version and apisix-ingress-controller version. > > Also, please add title. The packaged image of the current master version

[GitHub] [apisix-helm-chart] tokers commented on issue #49: apisix error:failed to fetch data from etcd: xxxx could not be resolved

2021-03-29 Thread GitBox
tokers commented on issue #49: URL: https://github.com/apache/apisix-helm-chart/issues/49#issuecomment-809324765 It seems APISIX doens't use the resolver in `/etc/resolv.conf`. Could you please paste the nginx.conf in your APISIX container? -- This is an automated message from the

[GitHub] [apisix] Firstsawyou opened a new pull request #3936: docs(FAQ.md): add a configuration example in How to modify the log level

2021-03-29 Thread GitBox
Firstsawyou opened a new pull request #3936: URL: https://github.com/apache/apisix/pull/3936 Signed-off-by: Firstsawyou yuelin...@gmail.com ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR

[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809271644 > Thanks for your contribution. > However, we already have an ongoing PR: #3820 > > I take a first look at yours. Your implementation has namespaceId and groupName, and

[GitHub] [apisix] spacewander commented on pull request #3927: test: enable master-worker mode by default

2021-03-29 Thread GitBox
spacewander commented on pull request #3927: URL: https://github.com/apache/apisix/pull/3927#issuecomment-809268244 To make sure bug in https://github.com/apache/apisix/pull/3912 won't happen again. -- This is an automated message from the Apache Git Service. To respond to the message,

[apisix] branch master updated: feat(traffic-split): the upstream pass_host needs to support IP mode (#3870)

2021-03-29 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new da83328 feat(traffic-split): the upstream

[GitHub] [apisix] spacewander merged pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode

2021-03-29 Thread GitBox
spacewander merged pull request #3870: URL: https://github.com/apache/apisix/pull/3870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix] tokers commented on pull request #3927: test: enable master-worker mode by default

2021-03-29 Thread GitBox
tokers commented on pull request #3927: URL: https://github.com/apache/apisix/pull/3927#issuecomment-809265994 @spacewander Where can I find the context about why we should do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-ingress-controller] tokers commented on issue #318: request help:

2021-03-29 Thread GitBox
tokers commented on issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318#issuecomment-809263515 Please add the apisix version and apisix-ingress-controller version. Also, please add title. -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603173738 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #320: test: add e2e test cases for redirect and fault-injection plugins

2021-03-29 Thread GitBox
codecov-io commented on pull request #320: URL: https://github.com/apache/apisix-ingress-controller/pull/320#issuecomment-809257457 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/320?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander commented on pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
spacewander commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809255632 Thanks for your contribution. However, we already have an ongoing PR: https://github.com/apache/apisix/pull/3820 I take a first look at yours. Your implementation

[GitHub] [apisix-website] stu01509 commented on a change in pull request #275: Feat #216 add project 2

2021-03-29 Thread GitBox
stu01509 commented on a change in pull request #275: URL: https://github.com/apache/apisix-website/pull/275#discussion_r603169141 ## File path: website/docusaurus.config.js ## @@ -60,6 +60,17 @@ module.exports = { releaseDate: "2021-03-12", firstDocPath:

[GitHub] [apisix] spacewander commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603167933 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,324 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] benx203 commented on a change in pull request #3820: feat: add nacos support

2021-03-29 Thread GitBox
benx203 commented on a change in pull request #3820: URL: https://github.com/apache/apisix/pull/3820#discussion_r603156071 ## File path: apisix/discovery/nacos.lua ## @@ -0,0 +1,285 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor

[GitHub] [apisix] tokers commented on issue #3935: request help: Specify an upstream and remove it from all routes

2021-03-29 Thread GitBox
tokers commented on issue #3935: URL: https://github.com/apache/apisix/issues/3935#issuecomment-809234414 @hackeryutu You don't show your problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] hackeryutu opened a new issue #3935: request help: Specify an upstream and remove it from all routes

2021-03-29 Thread GitBox
hackeryutu opened a new issue #3935: URL: https://github.com/apache/apisix/issues/3935 ### Issue description request help: Specify an upstream and remove it from all routes ### Environment * apisix version (cmd: `apisix version`): * OS (cmd: `uname -a`): * OpenResty /

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #321: Add e2e test cases for plugins

2021-03-29 Thread GitBox
gxthrj commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-809228790 Great Job ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #321: Add e2e test cases for plugins

2021-03-29 Thread GitBox
gxthrj commented on issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321#issuecomment-809228552 Great Job ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] imxhf opened a new pull request #3934: feat: Discovery Nacos

2021-03-29 Thread GitBox
imxhf opened a new pull request #3934: URL: https://github.com/apache/apisix/pull/3934 Nacos is wildly used as service discovery registery. Here add the nacos in APISIX discovery. The codes considers followings: When use Nacos in produce env, nacos_username and

[GitHub] [apisix] imxhf closed pull request #3933: Feature discovery nacos

2021-03-29 Thread GitBox
imxhf closed pull request #3933: URL: https://github.com/apache/apisix/pull/3933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix-ingress-controller] tokers opened a new issue #321: Add e2e test cases for plugins

2021-03-29 Thread GitBox
tokers opened a new issue #321: URL: https://github.com/apache/apisix-ingress-controller/issues/321 ### Issue description We don't cover plugins in e2e test suites, although we support them already. Here I want to initiate a plan to add test cases for most of all plugins in Apache

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #320: test: add e2e test cases for redirect and fault-injection plugins

2021-03-29 Thread GitBox
tokers opened a new pull request #320: URL: https://github.com/apache/apisix-ingress-controller/pull/320 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] imxhf opened a new pull request #3933: Feature discovery nacos

2021-03-29 Thread GitBox
imxhf opened a new pull request #3933: URL: https://github.com/apache/apisix/pull/3933 Nacos is wildly used as service discovery registery. Here add the nacos in APISIX discovery. The codes considers followings: 1. When use Nacos in produce env, nacos_username and

[GitHub] [apisix-helm-chart] wgy-home opened a new issue #49: apisix error:failed to fetch data from etcd: xxxx could not be resolved

2021-03-29 Thread GitBox
wgy-home opened a new issue #49: URL: https://github.com/apache/apisix-helm-chart/issues/49 # way to install ```shell git clone https://github.com/apache/apisix-helm-chart.git cd apisix-helm-chart/charts/apisix helm dependency update . helm install apisix . --set

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode

2021-03-29 Thread GitBox
Firstsawyou commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603113753 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) ---

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
tokers commented on a change in pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603112153 ## File path: test/e2e/ingress/resourcepushing.go ## @@ -99,14 +98,56 @@ spec: err = s.EnsureNumApisixUpstreamsCreated(1)

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
tokers commented on a change in pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603112153 ## File path: test/e2e/ingress/resourcepushing.go ## @@ -99,14 +98,56 @@ spec: err = s.EnsureNumApisixUpstreamsCreated(1)

[GitHub] [apisix] tokers opened a new issue #3932: ret_code type in plugin redirect document is dubious

2021-03-29 Thread GitBox
tokers opened a new issue #3932: URL: https://github.com/apache/apisix/issues/3932 # Improve Docs ## Please describe which part of docs should be improved or typo fixed The type of `ret_type` in attribution descriptions is `string`.

[GitHub] [apisix-dashboard] imjoey merged pull request #1676: feat: rewrite e2e test(test-e2e-route-with-plugin-CORS) using ginkgo

2021-03-29 Thread GitBox
imjoey merged pull request #1676: URL: https://github.com/apache/apisix-dashboard/pull/1676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[apisix-dashboard] branch master updated: feat: rewrite e2e test (route with plugins cors test) using ginkgo (#1676)

2021-03-29 Thread majunjie
This is an automated email from the ASF dual-hosted git repository. majunjie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 4ebf467 feat: rewrite e2e test

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
gxthrj commented on a change in pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#discussion_r603099761 ## File path: test/e2e/ingress/resourcepushing.go ## @@ -99,14 +98,56 @@ spec: err = s.EnsureNumApisixUpstreamsCreated(1)

[GitHub] [apisix] membphis commented on pull request #3894: feat: Add ldap-auth plugin

2021-03-29 Thread GitBox
membphis commented on pull request #3894: URL: https://github.com/apache/apisix/pull/3894#issuecomment-809177116 > @membphis there is a licence in their website https://lualdap.github.io/lualdap/license > We can open a ticket if the licence needs to be at project level

[GitHub] [apisix] spacewander commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603092533 ## File path: docs/zh/latest/plugins/skywalking.md ## @@ -96,6 +96,7 @@ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:

[GitHub] [apisix] tokers opened a new issue #3931: redirect plugins add curl test for `http_to_https`

2021-03-29 Thread GitBox
tokers opened a new issue #3931: URL: https://github.com/apache/apisix/issues/3931 # Improve Docs ## Please describe which part of docs should be improved or typo fixed The document about redirect plugin contains the configuration about using `http_to_https` in redirect

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-29 Thread GitBox
Firstsawyou commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603075361 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`.

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3925: feat(skywalking): allow destory and configure report interval for rep…

2021-03-29 Thread GitBox
Firstsawyou commented on a change in pull request #3925: URL: https://github.com/apache/apisix/pull/3925#discussion_r603075361 ## File path: docs/en/latest/plugins/skywalking.md ## @@ -92,6 +92,7 @@ We can set the endpoint by specified the configuration in `conf/config.yaml`.

[GitHub] [apisix-ingress-controller] tokers commented on pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
tokers commented on pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319#issuecomment-809151542 @gxthrj Please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #319: fix: ApisixRoute update operations is not effective

2021-03-29 Thread GitBox
tokers opened a new pull request #319: URL: https://github.com/apache/apisix-ingress-controller/pull/319 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-ingress-controller] pioneer-hash opened a new issue #318: request help:

2021-03-29 Thread GitBox
pioneer-hash opened a new issue #318: URL: https://github.com/apache/apisix-ingress-controller/issues/318 ### Issue description When I install ingress-controller I start creating the route , unable to synchronize configuration. this is my ingress-log: ```

[GitHub] [apisix-ingress-controller] pioneer-hash commented on issue #317: request help: Could not resolve host:

2021-03-29 Thread GitBox
pioneer-hash commented on issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317#issuecomment-809145301 This is because I changed the name generic type of the Charts.yaml file. The Apisix address domain name in the Ingress-Controller should be consistent with

[GitHub] [apisix-ingress-controller] pioneer-hash closed issue #317: request help: Could not resolve host:

2021-03-29 Thread GitBox
pioneer-hash closed issue #317: URL: https://github.com/apache/apisix-ingress-controller/issues/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [apisix] spacewander closed issue #3145: docs: Improve proxy-rewrite plugin docs

2021-03-29 Thread GitBox
spacewander closed issue #3145: URL: https://github.com/apache/apisix/issues/3145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] spacewander merged pull request #3929: docs: Improve proxy-rewrite plugin docs

2021-03-29 Thread GitBox
spacewander merged pull request #3929: URL: https://github.com/apache/apisix/pull/3929 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix] branch master updated: docs: Improve proxy-rewrite plugin docs (#3929)

2021-03-29 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 49e4fd3 docs: Improve proxy-rewrite

[GitHub] [apisix] KMFtcy edited a comment on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy edited a comment on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809124123 Gentlemen, I have located the problems. I found I accidentally I enable a plugin in this page.

[GitHub] [apisix] KMFtcy closed issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy closed issue #3928: URL: https://github.com/apache/apisix/issues/3928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809124123 Gentlemen, I have located the problems. I found I accidentally I enable a plugins in this page.

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118653 And By the way, I have tried to create a consumer but it always says `invalid json data` like this:

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809118141 @Firstsawyou Thanks for your reply. 1. I have check and I'm sure jwt-auth is not enabled in my routes. 2. Where can I config `global_rules` ? I cannot find it in

[GitHub] [apisix] spacewander commented on a change in pull request #3870: feat(traffic-split): the upstream pass_host needs to support IP mode

2021-03-29 Thread GitBox
spacewander commented on a change in pull request #3870: URL: https://github.com/apache/apisix/pull/3870#discussion_r603046994 ## File path: apisix/plugins/traffic-split.lua ## @@ -148,26 +148,18 @@ end local function set_pass_host(ctx, upstream_info, host) ---

[GitHub] [apisix-dashboard] aiyiyi121 opened a new issue #1687: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
aiyiyi121 opened a new issue #1687: URL: https://github.com/apache/apisix-dashboard/issues/1687 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API

[GitHub] [apisix] Firstsawyou commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
Firstsawyou commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809104963 @KMFtcy You need to check the following two points: 1. Is the jwt-auth plugin configured in your consumer object? If so, you need to check whether the jwt-auth plugin is

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1675: feat: rewrite e2e test(test-e2e-route-with-method) using ginkgo

2021-03-29 Thread GitBox
codecov-io edited a comment on pull request #1675: URL: https://github.com/apache/apisix-dashboard/pull/1675#issuecomment-808024334 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1675?src=pr=h1) Report > Merging

[GitHub] [apisix] aiyiyi121 opened a new issue #3930: request help: What’s the function of export OpenAPI on the dashboard

2021-03-29 Thread GitBox
aiyiyi121 opened a new issue #3930: URL: https://github.com/apache/apisix/issues/3930 ### Issue description What’s the function of export OpenAPI on the dashboard, why can't I export the configuration of routes and upstreams correctly through it. And how can I export API

[GitHub] [apisix] Firstsawyou commented on pull request #3929: docs: Improve proxy-rewrite plugin docs

2021-03-29 Thread GitBox
Firstsawyou commented on pull request #3929: URL: https://github.com/apache/apisix/pull/3929#issuecomment-809097623 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] KMFtcy commented on issue #3928: request help: why my gateway ask for jwt when I do not set any authentication method.

2021-03-29 Thread GitBox
KMFtcy commented on issue #3928: URL: https://github.com/apache/apisix/issues/3928#issuecomment-809095854 @tokers No. Is it necessary to bind a consumer to a route? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] bisakhmondal closed issue #1682: Updating URI of an existing route causes 404 error

2021-03-29 Thread GitBox
bisakhmondal closed issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1682: Updating URI of an existing route causes 404 error

2021-03-29 Thread GitBox
bisakhmondal commented on issue #1682: URL: https://github.com/apache/apisix-dashboard/issues/1682#issuecomment-809093438 Thanks, @nic-chen, @starsz for looking into this. Actually, the error has nothing to do with manager-api. Thanks to @Jaycean, only `/hello`, `/hello_` and `/hello1`

<    1   2