[GitHub] [incubator-apisix] moonming commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin

2020-03-31 Thread GitBox
moonming commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin URL: https://github.com/apache/incubator-apisix/issues/1272#issuecomment-606453871 `required_scope` should be `scope`? others look good to me.

[GitHub] [incubator-apisix] totemofwolf opened a new pull request #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases

2020-03-31 Thread GitBox
totemofwolf opened a new pull request #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases URL: https://github.com/apache/incubator-apisix/pull/1377 ### Summary remove misc `--add-dynamic-module` for tengine since we do not set `load_module` in nginx.co

[GitHub] [incubator-apisix] membphis opened a new issue #1378: change: Should Apache APISIX use local DNS resolver by default

2020-03-31 Thread GitBox
membphis opened a new issue #1378: change: Should Apache APISIX use local DNS resolver by default URL: https://github.com/apache/incubator-apisix/issues/1378 discuss email: https://lists.apache.org/thread.html/r98384d8c6a2fe4013c1d96430d51e500c4158a7531b79e67b0daa8ab%40%3Cdev.apisix.apache

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-31 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606523059 @membphis done changes This is

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400815509 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -51,6 +51,12 @@ local schema = {

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400817477 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -82,6 +88,8 @@ function _M.check_sche

[GitHub] [incubator-apisix] sshniro opened a new pull request #1358: Updating kafka logger to use the batch processor util

2020-03-31 Thread GitBox
sshniro opened a new pull request #1358: Updating kafka logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1358 ### Summary Updating kafka logger to use the batch processor util. Depends on #1349 ---

[GitHub] [incubator-apisix] sshniro commented on issue #1358: Updating kafka logger to use the batch processor util

2020-03-31 Thread GitBox
sshniro commented on issue #1358: Updating kafka logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1358#issuecomment-606559505 Reopening PR due to the max number of timers which could be executed within a period ---

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400903642 ## File path: doc/plugin-develop-cn.md ## @@ -48,14 +48,14 @@ 插件本身提供了 init 方法。方便插件加载后做初始化动作。 -注:如果部分插件的功能实现,

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400903722 ## File path: doc/plugin-develop-cn.md ## @@ -48,14 +48,14 @@ 插件本身提供了 init 方法。方便插件加载后做初始化动作。 -注:如果部分插件的功能实现,

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400903822 ## File path: doc/plugin-develop.md ## @@ -50,15 +50,15 @@ The plugin itself provides the init method. It is con

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400903722 ## File path: doc/plugin-develop-cn.md ## @@ -48,14 +48,14 @@ 插件本身提供了 init 方法。方便插件加载后做初始化动作。 -注:如果部分插件的功能实现,

[GitHub] [incubator-apisix] membphis commented on issue #1378: change: Should Apache APISIX use local DNS resolver by default

2020-03-31 Thread GitBox
membphis commented on issue #1378: change: Should Apache APISIX use local DNS resolver by default URL: https://github.com/apache/incubator-apisix/issues/1378#issuecomment-606628086 https://github.com/apache/incubator-apisix/blob/master/conf/config.yaml#L83-L87 This configuration in

[GitHub] [incubator-apisix] dabue commented on issue #1378: change: Should Apache APISIX use local DNS resolver by default

2020-03-31 Thread GitBox
dabue commented on issue #1378: change: Should Apache APISIX use local DNS resolver by default URL: https://github.com/apache/incubator-apisix/issues/1378#issuecomment-606630594 I'll update it. 88786...@qq.com From: YuanSheng Wang Date: 2020-03-31 21:30 To: apa

[GitHub] [incubator-apisix] qiujiayu opened a new issue #1379: feature: add global name

2020-03-31 Thread GitBox
qiujiayu opened a new issue #1379: feature: add global name URL: https://github.com/apache/incubator-apisix/issues/1379 APISIX need add global name for logger sytem, zipkin, like spring boot 'spring.application.name', This is

[GitHub] [incubator-apisix] qiujiayu opened a new pull request #1380: add global name

2020-03-31 Thread GitBox
qiujiayu opened a new pull request #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380 Fix #1379 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] membphis commented on issue #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases

2020-03-31 Thread GitBox
membphis commented on issue #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases URL: https://github.com/apache/incubator-apisix/pull/1377#issuecomment-606640745 love this PR, many thx @totemofwolf -

[GitHub] [incubator-apisix] membphis merged pull request #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases

2020-03-31 Thread GitBox
membphis merged pull request #1377: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases URL: https://github.com/apache/incubator-apisix/pull/1377 This is an automated message from the Apache Git Servi

[incubator-apisix] branch master updated: bugfix: remove misc `--add-dynamic-module` for tengine branch ci test cases (#1377)

2020-03-31 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new ef76d27 bugfix: remove misc `--add-

[GitHub] [incubator-apisix] membphis commented on issue #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
membphis commented on issue #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606641992 @spacewander @moonming please take a look when you have time, many thx --

[GitHub] [incubator-apisix] qiujiayu commented on issue #1379: feature: add global name

2020-03-31 Thread GitBox
qiujiayu commented on issue #1379: feature: add global name URL: https://github.com/apache/incubator-apisix/issues/1379#issuecomment-606641936 https://github.com/apache/incubator-apisix/pull/1370 the service name of Zipkin cloud be like this `service_name = zipkin.service_name or co

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1380: add global name

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380#discussion_r400933188 ## File path: conf/config.yaml ## @@ -15,6 +15,7 @@ # limitations under the License. # apisix: + name: APISIX

[GitHub] [incubator-apisix] moonming commented on issue #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
moonming commented on issue #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606643807 need add doc and test cases. This is an automated message fr

[GitHub] [incubator-apisix] membphis commented on issue #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
membphis commented on issue #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#issuecomment-606644856 @cyxinda please take a look at the output of CI This is an automated message from

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400941457 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,8 @@ lo

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400934957 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +49,9 @@ fu

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400940623 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,8 @@ lo

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400936369 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,8 @@ lo

[GitHub] [incubator-apisix] dabue commented on issue #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
dabue commented on issue #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#issuecomment-606657510 I got the error when I use the healthcheck to get the status of upstrems. Has anyone ever had the same problem? Error: 2020/03/31 17:03:01

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-31 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606667634 @membphis @moonming if things ok can we merge this so I can work on the other issue related to

[GitHub] [incubator-apisix-website] Miss-you opened a new issue #27: Apache apisix official website part of the Chinese page is displayed in English

2020-03-31 Thread GitBox
Miss-you opened a new issue #27: Apache apisix official website part of the Chinese page is displayed in English URL: https://github.com/apache/incubator-apisix-website/issues/27 Apache apisix official website part of the Chinese page is displayed in English Such as, http://apisix.a

[GitHub] [incubator-apisix-website] Miss-you opened a new issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable

2020-03-31 Thread GitBox
Miss-you opened a new issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable URL: https://github.com/apache/incubator-apisix-website/issues/28 When I click the En button of the current page, it jumps to the official website page instead of the En

[incubator-apisix] branch master updated: feature: remove `lua` dir. (#1351)

2020-03-31 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c76e7e3 feature: remove `lua` dir. (

[GitHub] [incubator-apisix] moonming merged pull request #1351: feature: remove `lua` dir.

2020-03-31 Thread GitBox
moonming merged pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-apisix-website] sshniro commented on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable

2020-03-31 Thread GitBox
sshniro commented on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable URL: https://github.com/apache/incubator-apisix-website/issues/28#issuecomment-606698698 Hi, I have experienced this. but was thinking this was an isolated event! --

[GitHub] [incubator-apisix-website] juzhiyuan commented on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable

2020-03-31 Thread GitBox
juzhiyuan commented on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable URL: https://github.com/apache/incubator-apisix-website/issues/28#issuecomment-606725883 The easy way to fix it is just replacing current location code with target cod

[GitHub] [incubator-apisix] membphis commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-31 Thread GitBox
membphis commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606727040 @Akayeshmantha you need to rebase you PR after https://github.com/apache/incubator-apisix/commit/c76e

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #159: Adding script to verify commit message

2020-03-31 Thread GitBox
juzhiyuan commented on issue #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-606727242 Any update? This is an automated message from the Apache Git

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-31 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606743568 @membphis rebased This is an a

[GitHub] [incubator-apisix] moonming commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-31 Thread GitBox
moonming commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606965552 @spacewander please take a look This

[GitHub] [incubator-apisix-website] sshniro removed a comment on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable

2020-03-31 Thread GitBox
sshniro removed a comment on issue #28: When clicking the En button of the current page, the page it jumps to is not reasonable URL: https://github.com/apache/incubator-apisix-website/issues/28#issuecomment-606698698 Hi, I have experienced this. but was thinking this was an isolated ev

[GitHub] [incubator-apisix-dashboard] sshniro commented on issue #159: Adding script to verify commit message

2020-03-31 Thread GitBox
sshniro commented on issue #159: Adding script to verify commit message URL: https://github.com/apache/incubator-apisix-dashboard/pull/159#issuecomment-606967503 Hi @juzhiyuan , due to the work from home situation I could not get my hands on to a mac to resolve this issue. Shall we merge t

[GitHub] [incubator-apisix] qiujiayu commented on issue #1379: feature: add global name

2020-03-31 Thread GitBox
qiujiayu commented on issue #1379: feature: add global name URL: https://github.com/apache/incubator-apisix/issues/1379#issuecomment-606972937 https://github.com/apache/incubator-apisix/pull/1241 the skywalking plugin also need. --

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64

2020-03-31 Thread GitBox
lilien1010 opened a new pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64 URL: https://github.com/apache/incubator-apisix/pull/1381 ### Summary response-rewrite plugin support rewrite binary data to client ### Full changelog *

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64 URL: https://github.com/apache/incubator-apisix/pull/1381#discussion_r401345697 ## File path: apisix/plugins/response-rewrite.lua ## @@ -85,7 +90,

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401346020 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@ local

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401345965 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@ local

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401348100 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@ loca

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r401348180 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,17 @@ loca

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64 URL: https://github.com/apache/incubator-apisix/pull/1381#discussion_r401355081 ## File path: apisix/plugins/response-rewrite.lua ## @@ -33,6 +33,

[GitHub] [incubator-apisix] dabue removed a comment on issue #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
dabue removed a comment on issue #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#issuecomment-606657510 I got the error when I use the healthcheck to get the status of upstrems. Has anyone ever had the same problem? Error: 2020/03/31 1

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#discussion_r401357169 ## File path: doc/how-k8s-deploy-cn.md ## @@ -0,0 +1,449 @@ +在k8s上面搭建apisix网关 +# +## 本地安装apisix +- 使用yum安装 +``

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#discussion_r401357344 ## File path: doc/how-k8s-deploy-cn.md ## @@ -0,0 +1,449 @@ +在k8s上面搭建apisix网关 +# +## 本地安装apisix +- 使用yum安装 +``

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1376: Create how-k8s-deploy-cn.md URL: https://github.com/apache/incubator-apisix/pull/1376#discussion_r401357025 ## File path: doc/how-k8s-deploy-cn.md ## @@ -0,0 +1,449 @@ +在k8s上面搭建apisix网关 +# +## 本地安装apisix +- 使用yum安装 +``

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64 URL: https://github.com/apache/incubator-apisix/pull/1381#discussion_r401358767 ## File path: apisix/plugins/response-rewrite.lua ## @@ -85,7 +9

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64

2020-03-31 Thread GitBox
lilien1010 commented on a change in pull request #1381: feature: response-rewrite plugin rewrite binary data to client by base64 URL: https://github.com/apache/incubator-apisix/pull/1381#discussion_r401358723 ## File path: apisix/plugins/response-rewrite.lua ## @@ -33,6 +3

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r401359249 ## File path: doc/plugins/udp-logger.md ## @@ -33,15 +33,21 @@ This will provide th

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r401363228 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r401362090 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r401363026 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on a change in pull request #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#discussion_r401362947 ## File path: lua/apisix/plugins/udp-logger.lua ## @@ -46,38 +51,85 @@ function _M.

[GitHub] [incubator-apisix] membphis commented on issue #1355: Updating the UDP logger to use the batch processor util

2020-03-31 Thread GitBox
membphis commented on issue #1355: Updating the UDP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1355#issuecomment-607040726 @sshniro please rebase your branch This is an automat

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-31 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r401369512 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +49,9 @@ func

[GitHub] [incubator-apisix] lilien1010 closed pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 closed pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-31 Thread GitBox
lilien1010 opened a new pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370 ### Summary allow zipkin to set servie name so that we can track it in APM system ### Full changelog

[GitHub] [incubator-apisix] membphis commented on issue #1380: add global name

2020-03-31 Thread GitBox
membphis commented on issue #1380: add global name URL: https://github.com/apache/incubator-apisix/pull/1380#issuecomment-607071106 need test case This is an automated message from the Apache Git Service. To respond to the mes