Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4721/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/r9qXoC : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4753/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7187/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4752/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: Merge commit '722e85d0347e628da99b5e479f3a9a993e549b03' from...
Jenkins has posted comments on this change. Change subject: Merge commit '722e85d0347e628da99b5e479f3a9a993e549b03' from release-0.9.4-pre-rc .. Patch Set 1: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7185/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2907 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d3ac0768bed4271501ad3016d21f66f64ebb5fe Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7187/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3609/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/574/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3609/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Fix log directory initialization
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Fix log directory initialization .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4722/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f4e11e030a8ffa387e1fa234ed9ad9e3fe380c5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Contrib-2 Analytics Compatibility Compilation Failed https://goo.gl/1yoos6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: -Contrib Analytics Compatibility Compilation Successful https://goo.gl/FLnM4w : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3610/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7188/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Fix tuple translators with extension datasets
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2909
Change subject: Fix tuple translators with extension datasets
..
Fix tuple translators with extension datasets
Change-Id: I39f6707392085416c01e834ac85767f79a64f9d6
---
M
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad
refs/changes/09/2909/1
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
index b33dcad..fa35fd5 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
@@ -32,17 +32,17 @@
public static final ExtensionMetadataDatasetId BAD_CHANNEL_INDEX_ID = new
ExtensionMetadataDatasetId(
BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.CHANNEL_EXTENSION_NAME);
-public static final MetadataIndexImmutableProperties PROPERTIES_CHANNEL =
new MetadataIndexImmutableProperties(
-BADConstants.CHANNEL_EXTENSION_NAME,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID);
+public static final MetadataIndexImmutableProperties PROPERTIES_CHANNEL =
+new
MetadataIndexImmutableProperties(BADConstants.CHANNEL_EXTENSION_NAME,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID);
-public static final ExtensionMetadataDatasetId BAD_BROKER_INDEX_ID = new
ExtensionMetadataDatasetId(
-BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.BROKER_KEYWORD);
-public static final MetadataIndexImmutableProperties PROPERTIES_BROKER =
new MetadataIndexImmutableProperties(
-BADConstants.BROKER_KEYWORD,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1);
+public static final ExtensionMetadataDatasetId BAD_BROKER_INDEX_ID =
+new
ExtensionMetadataDatasetId(BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.BROKER_KEYWORD);
+public static final MetadataIndexImmutableProperties PROPERTIES_BROKER =
+new MetadataIndexImmutableProperties(BADConstants.BROKER_KEYWORD,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1);
public static final ExtensionMetadataDatasetId BAD_PROCEDURE_INDEX_ID =
new ExtensionMetadataDatasetId(
BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.PROCEDURE_KEYWORD);
@@ -61,7 +61,7 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.ChannelName)),
0, BADMetadataRecordTypes.CHANNEL_RECORDTYPE, true, new int[] { 0,
1 }, BAD_CHANNEL_INDEX_ID,
-new ChannelTupleTranslator(true));
+() -> new ChannelTupleTranslator(true));
@SuppressWarnings({ "rawtypes", "unchecked" })
public static final ExtensionMetadataDataset BROKER_DATASET = new
ExtensionMetadataDataset(PROPERTIES_BROKER,
@@ -69,7 +69,7 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.BrokerName)),
0, BADMetadataRecordTypes.BROKER_RECORDTYPE, true, new int[] { 0,
1 }, BAD_BROKER_INDEX_ID,
-new BrokerTupleTranslator(true));
+() -> new BrokerTupleTranslator(true));
@SuppressWarnings({ "rawtypes", "unchecked" })
public static final ExtensionMetadataDataset PROCEDURE_DATASET = new
ExtensionMetadataDataset(PROPERTIES_PROCEDURE,
@@ -77,6 +77,6 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.ProcedureName),
Arrays.asList(BADConstants.FIELD_NAME_ARITY)),
0, BADMetadataRecordTypes.PROCEDURE_RECORDTYPE, true, new int[] {
0, 1, 2 }, BAD_PROCEDURE_INDEX_ID,
-new ProcedureTupleTranslator(true));
+() -> new ProcedureTupleTranslator(true));
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2909
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id:
Change in asterixdb-bad[master]: Fix tuple translators with extension datasets
Jenkins has posted comments on this change. Change subject: Fix tuple translators with extension datasets .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-gerrit/347/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2909 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39f6707392085416c01e834ac85767f79a64f9d6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: Code-Review+2 Contrib+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
[jira] [Resolved] (ASTERIXDB-2441) Change how column aliases are inlined into order by and limit clauses
[ https://issues.apache.org/jira/browse/ASTERIXDB-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Lychagin resolved ASTERIXDB-2441. Resolution: Fixed > Change how column aliases are inlined into order by and limit clauses > -- > > Key: ASTERIXDB-2441 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2441 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Dmitry Lychagin >Assignee: Dmitry Lychagin >Priority: Minor > > Currently when a column alias is referenced by an ORDER BY or a LIMIT clause > we copy the column alias expression into that clause during query rewriting ( > SqlppQueryRewriter.inlineColumnAlias()). This may lead to suboptimal query > plans when the copied expression is complex and cannot be factored out by the > optimizer's ExtractCommonExpressionsRule (for example AGGREGATE_FN(DISTINCT > ...). In those cases the expression will be executed twice an runtime. > A better approach is to introduce a variable for that expression (LET clause) > and refer to that variable from SELECT and ORDER BY/LIMIT clauses. This way > the optimizer can decide whether this LET clause should be inlined or not. > For example. > SELECT f(x) AS y FROM ... ORDER BY y > Is currently rewritten into > SELECT f(x) AS y FROM ... ORDER BY f(x) > With the new approach it will be rewritten into > SELECT z AS y FROM ... LET z = f(x) ORDER BY z > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2908
Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators
..
[NO ISSUE][TXN] Fix extension datasets tuple translators
Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d
---
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
A
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
2 files changed, 33 insertions(+), 4 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/08/2908/1
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
index d25f488..ebb9cac 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
@@ -29,16 +29,16 @@
private static final long serialVersionUID = 1L;
private final ExtensionMetadataDatasetId indexId;
-private final transient IMetadataEntityTupleTranslator tupleTranslator;
+private final transient IMetadataEntityTupleTranslatorFactory
tupleTranslatorFactory;
public ExtensionMetadataDataset(MetadataIndexImmutableProperties
indexProperties, int numFields, IAType[] keyTypes,
List> keyNames, int numSecondaryIndexKeys,
ARecordType payloadType, boolean isPrimaryIndex,
int[] primaryKeyIndexes, ExtensionMetadataDatasetId indexId,
-IMetadataEntityTupleTranslator tupleTranslator) {
+IMetadataEntityTupleTranslatorFactory tupleTranslatorFactory) {
super(indexProperties, numFields, keyTypes, keyNames,
numSecondaryIndexKeys, payloadType, isPrimaryIndex,
primaryKeyIndexes);
this.indexId = indexId;
-this.tupleTranslator = tupleTranslator;
+this.tupleTranslatorFactory = tupleTranslatorFactory;
}
public ExtensionMetadataDatasetId getId() {
@@ -46,6 +46,6 @@
}
public IMetadataEntityTupleTranslator getTupleTranslator() {
-return tupleTranslator;
+return tupleTranslatorFactory.createTupleTranslator();
}
}
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
new file mode 100644
index 000..e472383
--- /dev/null
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.metadata.api;
+
+import java.io.Serializable;
+
+public interface IMetadataEntityTupleTranslatorFactory extends Serializable
{
+
+/**
+ * @return an instance of IMetadataEntityTupleTranslator
+ */
+IMetadataEntityTupleTranslator createTupleTranslator();
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2908
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Dmitry Lychagin has submitted this change and it was merged. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT - user model changes: no - storage format changes: no - interface changes: no Details: - Introduce LET clauses for column alias expressions instead of inlining them into ORDER BY/LIMIT clauses - Fix incorrect visitor used in SubstituteGroupbyExpressionWithVariableVisitor for rewriting LET clauses after GROUP BY Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2905 Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann Contrib: Till Westmann --- A asterixdb/asterix-app/src/test/resources/optimizerts/queries/group-by/sugar-06-distinct.sqlpp M asterixdb/asterix-app/src/test/resources/optimizerts/results/ASTERIXDB-2402.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/aggregate/constant-gby-agg.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/cust_group_no_agg.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/gby_partitioning_property_01.plan A asterixdb/asterix-app/src/test/resources/optimizerts/results/group-by/sugar-06-distinct.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-1806.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-2354.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-ASTERIXDB-2408.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/query-issue601.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/rtree-index/rtree-sidx-idxonly-01-disable-idxonly.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/in_correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1580.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan M asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias.ast M asterixdb/asterix-app/src/test/resources/parserts/results_parser_sqlpp/columnalias3.ast A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/order-by-13/order-by-13.1.ddl.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/order-by-13/order-by-13.2.update.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/flwor/order-by-13/order-by-13.3.query.sqlpp A asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/group-by/sugar-06-distinct/sugar-06-distinct.9.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access/explain_field_access.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/explain/explain_field_access_closed/explain_field_access_closed.1.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/flwor/order-by-13/order-by-13.3.adm A asterixdb/asterix-app/src/test/resources/runtimets/results/group-by/sugar-06-distinct/sugar-06-distinct.9.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/flwor/at06/at06.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/tinysocial/tinysocial-suite-open/tinysocial-suite.24.ast M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/tinysocial/tinysocial-suite/tinysocial-suite.24.ast M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/context/Scope.java M asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/rewrites/LangRewritingContext.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/clause/SelectBlock.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppFunctionBodyRewriter.java M asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/SqlppQueryRewriter.java M
[jira] [Commented] (ASTERIXDB-2441) Change how column aliases are inlined into order by and limit clauses
[ https://issues.apache.org/jira/browse/ASTERIXDB-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581188#comment-16581188 ] ASF subversion and git services commented on ASTERIXDB-2441: Commit 309c69c57a4fb790288efd9e179240299f3d in asterixdb's branch refs/heads/master from [~dlychagin-cb] [ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=309c69c ] [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT - user model changes: no - storage format changes: no - interface changes: no Details: - Introduce LET clauses for column alias expressions instead of inlining them into ORDER BY/LIMIT clauses - Fix incorrect visitor used in SubstituteGroupbyExpressionWithVariableVisitor for rewriting LET clauses after GROUP BY Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2905 Tested-by: Jenkins Contrib: Jenkins Integration-Tests: Jenkins Reviewed-by: Till Westmann Contrib: Till Westmann > Change how column aliases are inlined into order by and limit clauses > -- > > Key: ASTERIXDB-2441 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2441 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Dmitry Lychagin >Assignee: Dmitry Lychagin >Priority: Minor > > Currently when a column alias is referenced by an ORDER BY or a LIMIT clause > we copy the column alias expression into that clause during query rewriting ( > SqlppQueryRewriter.inlineColumnAlias()). This may lead to suboptimal query > plans when the copied expression is complex and cannot be factored out by the > optimizer's ExtractCommonExpressionsRule (for example AGGREGATE_FN(DISTINCT > ...). In those cases the expression will be executed twice an runtime. > A better approach is to introduce a variable for that expression (LET clause) > and refer to that variable from SELECT and ORDER BY/LIMIT clauses. This way > the optimizer can decide whether this LET clause should be inlined or not. > For example. > SELECT f(x) AS y FROM ... ORDER BY y > Is currently rewritten into > SELECT f(x) AS y FROM ... ORDER BY f(x) > With the new approach it will be rewritten into > SELECT z AS y FROM ... LET z = f(x) ORDER BY z > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4361/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4754/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9837/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8297/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4359/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/575/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4273/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4918/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2373/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4327/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/646/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4580/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4723/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
abdullah alamoudi has submitted this change and it was merged.
Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators
..
[NO ISSUE][TXN] Fix extension datasets tuple translators
Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2908
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
Reviewed-by: Murtadha Hubail
---
M
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
A
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
2 files changed, 33 insertions(+), 4 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, but someone else must approve
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
index d25f488..ebb9cac 100644
---
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/ExtensionMetadataDataset.java
@@ -29,16 +29,16 @@
private static final long serialVersionUID = 1L;
private final ExtensionMetadataDatasetId indexId;
-private final transient IMetadataEntityTupleTranslator tupleTranslator;
+private final transient IMetadataEntityTupleTranslatorFactory
tupleTranslatorFactory;
public ExtensionMetadataDataset(MetadataIndexImmutableProperties
indexProperties, int numFields, IAType[] keyTypes,
List> keyNames, int numSecondaryIndexKeys,
ARecordType payloadType, boolean isPrimaryIndex,
int[] primaryKeyIndexes, ExtensionMetadataDatasetId indexId,
-IMetadataEntityTupleTranslator tupleTranslator) {
+IMetadataEntityTupleTranslatorFactory tupleTranslatorFactory) {
super(indexProperties, numFields, keyTypes, keyNames,
numSecondaryIndexKeys, payloadType, isPrimaryIndex,
primaryKeyIndexes);
this.indexId = indexId;
-this.tupleTranslator = tupleTranslator;
+this.tupleTranslatorFactory = tupleTranslatorFactory;
}
public ExtensionMetadataDatasetId getId() {
@@ -46,6 +46,6 @@
}
public IMetadataEntityTupleTranslator getTupleTranslator() {
-return tupleTranslator;
+return tupleTranslatorFactory.createTupleTranslator();
}
}
diff --git
a/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
new file mode 100644
index 000..e472383
--- /dev/null
+++
b/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataEntityTupleTranslatorFactory.java
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.asterix.metadata.api;
+
+import java.io.Serializable;
+
+public interface IMetadataEntityTupleTranslatorFactory extends Serializable
{
+
+/**
+ * @return an instance of IMetadataEntityTupleTranslator
+ */
+IMetadataEntityTupleTranslator createTupleTranslator();
+}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2908
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Murtadha Hubail
Gerrit-Reviewer: Till Westmann
Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4727/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
..
[NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2910
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Murtadha Hubail
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/CLFLogger.java
M
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
4 files changed, 14 insertions(+), 11 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
index 59ef913..22dea9f 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/CCLogConfigurationFactory.java
@@ -18,6 +18,9 @@
*/
package org.apache.hyracks.control.cc;
+import java.io.File;
+import java.net.URI;
+
import org.apache.hyracks.control.common.controllers.CCConfig;
import org.apache.logging.log4j.Level;
import org.apache.logging.log4j.core.LoggerContext;
@@ -30,8 +33,6 @@
import org.apache.logging.log4j.core.config.builder.api.LayoutComponentBuilder;
import org.apache.logging.log4j.core.config.builder.impl.BuiltConfiguration;
-import java.net.URI;
-
public class CCLogConfigurationFactory extends ConfigurationFactory {
private CCConfig config;
@@ -40,7 +41,7 @@
}
public Configuration
createConfiguration(ConfigurationBuilder builder) {
-String logDir = config.getLogDir();
+File logDir = new File(config.getLogDir());
builder.setStatusLevel(Level.WARN);
builder.setConfigurationName("RollingBuilder");
// create a rolling file appender
@@ -50,8 +51,8 @@
.addComponent(builder.newComponent("CronTriggeringPolicy").addAttribute("schedule",
"0 0 0 * * ?"))
.addComponent(builder.newComponent("SizeBasedTriggeringPolicy").addAttribute("size",
"50M"));
AppenderComponentBuilder defaultRoll =
-builder.newAppender("default",
"RollingFile").addAttribute("fileName", logDir + "cc.log")
-.addAttribute("filePattern", logDir +
"cc-%d{MM-dd-yy}.log.gz").add(defaultLayout)
+builder.newAppender("default",
"RollingFile").addAttribute("fileName", new File(logDir, "cc.log"))
+.addAttribute("filePattern", new File(logDir,
"cc-%d{MM-dd-yy}.log.gz")).add(defaultLayout)
.addComponent(triggeringPolicy);
builder.add(defaultRoll);
@@ -60,8 +61,8 @@
LayoutComponentBuilder accessLayout =
builder.newLayout("PatternLayout").addAttribute("pattern", "%m%n");
AppenderComponentBuilder accessRoll =
-builder.newAppender("access",
"RollingFile").addAttribute("fileName", logDir + "access.log")
-.addAttribute("filePattern", logDir +
"access-%d{MM-dd-yy}.log.gz").add(accessLayout)
+builder.newAppender("access",
"RollingFile").addAttribute("fileName", new File(logDir, "access.log"))
+.addAttribute("filePattern", new File(logDir,
"access-%d{MM-dd-yy}.log.gz")).add(accessLayout)
.addComponent(triggeringPolicy);
builder.add(accessRoll);
builder.add(builder.newLogger("org.apache.hyracks.http.server.CLFLogger",
Level.forName("ACCESS", 550))
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
index 65c7ca5..07e61ba 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/controllers/ControllerConfig.java
+++
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions
..
[NO ISSUE][FUN] Allow extensions to add aggregate functions
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- Make aggregate function related methods public in BuiltInFunctions,
so product extensions can register their own aggregate functions
Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2840
Reviewed-by: abdullah alamoudi
Sonar-Qube: Jenkins
Tested-by: Jenkins
Integration-Tests: Jenkins
---
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
1 file changed, 7 insertions(+), 7 deletions(-)
Approvals:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
Objections:
Anon. E. Moose #1000171: Violations found
Jenkins: Violations found
diff --git
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
index d2c8269..1df617e 100644
---
a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
+++
b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
@@ -2046,19 +2046,19 @@
registeredFunctions.put(fi, functionInfo);
}
-private static void addAgg(FunctionIdentifier fi) {
+public static void addAgg(FunctionIdentifier fi) {
builtinAggregateFunctions.add(getAsterixFunctionInfo(fi));
}
-private static void addLocalAgg(FunctionIdentifier fi, FunctionIdentifier
localfi) {
+public static void addLocalAgg(FunctionIdentifier fi, FunctionIdentifier
localfi) {
aggregateToLocalAggregate.put(getAsterixFunctionInfo(fi),
getAsterixFunctionInfo(localfi));
}
-private static void addIntermediateAgg(FunctionIdentifier fi,
FunctionIdentifier globalfi) {
+public static void addIntermediateAgg(FunctionIdentifier fi,
FunctionIdentifier globalfi) {
aggregateToIntermediateAggregate.put(getAsterixFunctionInfo(fi),
getAsterixFunctionInfo(globalfi));
}
-private static void addGlobalAgg(FunctionIdentifier fi, FunctionIdentifier
globalfi) {
+public static void addGlobalAgg(FunctionIdentifier fi, FunctionIdentifier
globalfi) {
aggregateToGlobalAggregate.put(getAsterixFunctionInfo(fi),
getAsterixFunctionInfo(globalfi));
globalAggregateFunctions.add(getAsterixFunctionInfo(globalfi));
}
@@ -2067,15 +2067,15 @@
builtinUnnestingFunctions.put(getAsterixFunctionInfo(fi),
returnsUniqueValues);
}
-private static void addSerialAgg(FunctionIdentifier fi, FunctionIdentifier
serialfi) {
+public static void addSerialAgg(FunctionIdentifier fi, FunctionIdentifier
serialfi) {
aggregateToSerializableAggregate.put(getAsterixFunctionInfo(fi),
getAsterixFunctionInfo(serialfi));
}
-private static void addScalarAgg(FunctionIdentifier fi, FunctionIdentifier
scalarfi) {
+public static void addScalarAgg(FunctionIdentifier fi, FunctionIdentifier
scalarfi) {
scalarToAggregateFunctionMap.put(getAsterixFunctionInfo(scalarfi),
getAsterixFunctionInfo(fi));
}
-private static void addDistinctAgg(FunctionIdentifier distinctfi,
FunctionIdentifier regularscalarfi) {
+public static void addDistinctAgg(FunctionIdentifier distinctfi,
FunctionIdentifier regularscalarfi) {
distinctToRegularScalarAggregateFunctionMap.put(getAsterixFunctionInfo(distinctfi),
getAsterixFunctionInfo(regularscalarfi));
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2840
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Michael Blow
Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8305/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4925/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4369/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4335/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4759/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9845/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4281/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2381/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4588/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/580/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4367/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/654/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2912
Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes
..
[NO ISSUE][NET] Propagate Network Failure Error Codes
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Pass the network error code to the channel
to determine whether the error should be
sent to the receiver or not.
Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3
---
M
hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/PartitionManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/result/ResultPartitionReader.java
5 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/12/2912/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
index 8bee56e..334fb5c 100644
---
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
+++
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
@@ -104,8 +104,8 @@
ccb.getWriteInterface().getFullBufferAcceptor().close();
}
-public void abort() {
-
ccb.getWriteInterface().getFullBufferAcceptor().error(AbstractChannelWriteInterface.REMOTE_ERROR_CODE);
+public void abort(int ecode) {
+ccb.getWriteInterface().getFullBufferAcceptor().error(ecode);
synchronized (NetworkOutputChannel.this) {
aborted = true;
NetworkOutputChannel.this.notifyAll();
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
index 98693d0..8b02f9c 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
@@ -139,7 +139,7 @@
@Override
public void error(int ecode) {
if (noc != null) {
-noc.abort();
+noc.abort(ecode);
}
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
index 6927a58..ee821d6 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
@@ -33,6 +33,7 @@
import org.apache.hyracks.api.result.ResultSetId;
import org.apache.hyracks.comm.channels.IChannelConnectionFactory;
import org.apache.hyracks.comm.channels.NetworkOutputChannel;
+import org.apache.hyracks.net.protocols.muxdemux.AbstractChannelWriteInterface;
import org.apache.hyracks.net.protocols.muxdemux.ChannelControlBlock;
import org.apache.hyracks.net.protocols.muxdemux.IChannelOpenListener;
import org.apache.hyracks.net.protocols.muxdemux.MultiplexedConnection;
@@ -146,7 +147,7 @@
partitionManager.initializeResultPartitionReader(jobId, rsId,
partition, noc);
} catch (HyracksException e) {
LOGGER.warn("Failed to initialize result partition reader", e);
-noc.abort();
+noc.abort(AbstractChannelWriteInterface.REMOTE_ERROR_CODE);
}
}
@@ -158,7 +159,7 @@
@Override
public void error(int ecode) {
if (noc != null) {
-noc.abort();
+noc.abort(ecode);
}
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/PartitionManager.java
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2382/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2913
Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the
operation cannot be performed
..
[ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be
performed
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- substring() should return NULL if starting offset is out of bounds
for given string or length is negative
Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr01/substr01.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr04/substr04.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-3/substring2-3.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-4/substring2-4.1.adm
M asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/SubstringTypeComputer.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/Substring2Descriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SubstringDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
15 files changed, 76 insertions(+), 53 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/13/2913/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
index 1c31ea0..f792e7f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
@@ -30,6 +30,9 @@
substring("ABCD", 0, 4),
substring("UC Irvine", 3, string-length("UC Irvine") - 3),
substring("UC Irvine", 0, string-length("UC Irvine")),
-substring(substring("UC Irvine", 3), 0, string-length("Irvine"))
+substring(substring("UC Irvine", 3), 0, string-length("Irvine")),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
]
return $a
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
index ecfcd94..b0e8697 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
@@ -19,4 +19,5 @@
use dataverse test;
let $c1 := substring("HEllow",-3)
-return {"result1": $c1}
+let $c2 := substring("HEllow",-7)
+return {"result1": $c1, "result2": $c2}
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
index e1ef68b..d9f936f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
@@ -32,7 +32,10 @@
substring('ABCD',0,4),
substring('UC Irvine',3,(`string-length`('UC Irvine') - 3)),
substring('UC Irvine',0,`string-length`('UC Irvine')),
-substring(substring('UC Irvine',3),0,`string-length`('Irvine'))
+substring(substring('UC Irvine',3),0,`string-length`('Irvine')),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
] as a
;
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
index ae943d4..6b63289 100644
---
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4370/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/655/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9846/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDE...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2441][COMP] Improve column alias handling in ORDERBY/LIMIT .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7186/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2905 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If925cbb803f2ad5fe955ba343ddc62585589b894 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/J3p3ba : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
[jira] [Created] (ASTERIXDB-2442) substring() should return NULL if starting offset is out of bounds or length is negative
Dmitry Lychagin created ASTERIXDB-2442: -- Summary: substring() should return NULL if starting offset is out of bounds or length is negative Key: ASTERIXDB-2442 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2442 Project: Apache AsterixDB Issue Type: Improvement Reporter: Dmitry Lychagin Assignee: Dmitry Lychagin substring() should return NULL in the following cases: 1) if starting offset is out of bounds for given string, including the case when the starting offset is negative and therefore counted backwards from the length of the string. 2) if length is negative -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/hVs5ca : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/wVubSi : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3612/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Luo Chen has submitted this change and it was merged.
Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree
..
[NO ISSUE] Misc Fixes for Point MBR RTree
- user-model changes: no
- storage format changes: no
- interface changes: no
Details:
1. Fix the MBR calculation of Point MBR RTrees when finalizing the
bulkload process.
2. Fix the nullFlagBytes of Point MBR Rtrees.
3. Add unit test cases to cover Point MBR RTrees.
Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2911
Sonar-Qube: Jenkins
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
Reviewed-by: abdullah alamoudi
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleReferenceForPointMBR.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
M
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeBulkLoadTest.java
M
hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/RTreeTestUtils.java
A
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-rtree-test/src/test/java/org/apache/hyracks/storage/am/lsm/rtree/LSMRTreePointMBRBulkLoadTest.java
M
hyracks-fullstack/hyracks/hyracks-tests/hyracks-storage-am-lsm-rtree-test/src/test/java/org/apache/hyracks/storage/am/lsm/rtree/util/LSMRTreeTestContext.java
6 files changed, 156 insertions(+), 17 deletions(-)
Approvals:
Anon. E. Moose #1000171:
abdullah alamoudi: Looks good to me, approved
Jenkins: Verified; No violations found; ; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleReferenceForPointMBR.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleReferenceForPointMBR.java
index 1432aba..e28d5a2 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleReferenceForPointMBR.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/tuples/LSMRTreeTupleReferenceForPointMBR.java
@@ -128,7 +128,9 @@
@Override
protected int getNullFlagsBytes() {
-return BitOperationUtils.getFlagBytes(inputTotalFieldCount +
(antimatterAware ? 1 : 0));
+// stored key field count + value field count
+return BitOperationUtils.getFlagBytes(
+storedKeyFieldCount + inputTotalFieldCount -
inputKeyFieldCount + (antimatterAware ? 1 : 0));
}
@Override
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
index f12f423..635fe7a 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-rtree/src/main/java/org/apache/hyracks/storage/am/rtree/impls/RTree.java
@@ -1006,6 +1006,7 @@
//set next guide MBR
//if propagateBulk didnt have to do anything this may be
un-necessary
if (nodeFrontiers.size() > 1 && nodeFrontiers.indexOf(n) <
nodeFrontiers.size() - 1) {
+lowerFrame = nodeFrontiers.indexOf(n) != 0 ?
prevInteriorFrame : leafFrame;
lowerFrame.setPage(n.page);
((RTreeNSMFrame) lowerFrame).adjustMBR();
interiorFrameTupleWriter.writeTupleFields(((RTreeNSMFrame)
lowerFrame).getMBRTuples(), 0, mbr, 0);
diff --git
a/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeBulkLoadTest.java
b/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeBulkLoadTest.java
index 67b24a2..2d6f97c 100644
---
a/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeBulkLoadTest.java
+++
b/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/AbstractRTreeBulkLoadTest.java
@@ -30,10 +30,16 @@
public abstract class AbstractRTreeBulkLoadTest extends
AbstractRTreeTestDriver {
private final RTreeTestUtils rTreeTestUtils;
+private final boolean isPoint;
public AbstractRTreeBulkLoadTest(boolean testRstarPolicy) {
+this(testRstarPolicy, false);
+}
+
+public AbstractRTreeBulkLoadTest(boolean testRstarPolicy, boolean isPoint)
{
super(testRstarPolicy);
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4926/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4336/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4282/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8306/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4589/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4368/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4728/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIX-2430][COMP] Avoid inlining function calls in WITH i...
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIX-2430][COMP] Avoid inlining function calls in WITH in AST rewritting .. Patch Set 5: I'm worried about regressions it might introduce. For example if we take runtimets/queries_sqlpp/dapd/q2-11/q2-11.3.query.sqlpp and put a function call into a WITH expression: WITH t AS ARRAY_COUNT(.) Then it won't be inlined because of this change, but the query will fail with IndexOutOfBoundsException. java.lang.IndexOutOfBoundsException at org.apache.hyracks.data.std.util.ByteArrayAccessibleOutputStream.write(ByteArrayAccessibleOutputStream.java:75) ~[classes/:?] at java.io.DataOutputStream.write(DataOutputStream.java:107) ~[?:1.8.0_161] at org.apache.hyracks.dataflow.common.comm.io.ArrayTupleBuilder.addField(ArrayTupleBuilder.java:101) ~[classes/:?] at org.apache.hyracks.algebricks.runtime.operators.std.AssignRuntimeFactory$1.produceTuple(AssignRuntimeFactory.java:162) ~[classes/:?] I think we first need to investigate these kinds of failures when WITH variable inlining is disabled, because with this change a WITH expression becomes non-inlinable if it starts with a function call (.e.g. ARRAY_*(subquery)) . Try disabling this rule completely and run the SqlppExecutionTest. When I did that there were several different kinds of failures: IndexOutOfBounds in the above mentioned dapd/q2-11, but also NPE in tpcds/q59, type error in tpcds/q95, and q18_large_volume_customer_failure failed with out of disk space. Let's investigate those before we decide whether to make this change or not. -- To view, visit https://asterix-gerrit.ics.uci.edu/2874 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18afbe4165ca84c790d7693a7a7bd5f6fd53187a Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/kecGRb : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7192/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4758/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Contrib-2 BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3613/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7193/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7194/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb-bad[master]: Fix tuple translators with extension datasets
abdullah alamoudi has submitted this change and it was merged.
Change subject: Fix tuple translators with extension datasets
..
Fix tuple translators with extension datasets
Change-Id: I39f6707392085416c01e834ac85767f79a64f9d6
---
M
asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
1 file changed, 13 insertions(+), 13 deletions(-)
Approvals:
abdullah alamoudi: Looks good to me, but someone else must approve
Jenkins: Verified
Murtadha Hubail: Looks good to me, approved
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
index b33dcad..fa35fd5 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/metadata/BADMetadataIndexes.java
@@ -32,17 +32,17 @@
public static final ExtensionMetadataDatasetId BAD_CHANNEL_INDEX_ID = new
ExtensionMetadataDatasetId(
BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.CHANNEL_EXTENSION_NAME);
-public static final MetadataIndexImmutableProperties PROPERTIES_CHANNEL =
new MetadataIndexImmutableProperties(
-BADConstants.CHANNEL_EXTENSION_NAME,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID);
+public static final MetadataIndexImmutableProperties PROPERTIES_CHANNEL =
+new
MetadataIndexImmutableProperties(BADConstants.CHANNEL_EXTENSION_NAME,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID);
-public static final ExtensionMetadataDatasetId BAD_BROKER_INDEX_ID = new
ExtensionMetadataDatasetId(
-BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.BROKER_KEYWORD);
-public static final MetadataIndexImmutableProperties PROPERTIES_BROKER =
new MetadataIndexImmutableProperties(
-BADConstants.BROKER_KEYWORD,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1,
-
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1);
+public static final ExtensionMetadataDatasetId BAD_BROKER_INDEX_ID =
+new
ExtensionMetadataDatasetId(BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.BROKER_KEYWORD);
+public static final MetadataIndexImmutableProperties PROPERTIES_BROKER =
+new MetadataIndexImmutableProperties(BADConstants.BROKER_KEYWORD,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1,
+
MetadataIndexImmutableProperties.FIRST_AVAILABLE_EXTENSION_METADATA_DATASET_ID
+ 1);
public static final ExtensionMetadataDatasetId BAD_PROCEDURE_INDEX_ID =
new ExtensionMetadataDatasetId(
BADMetadataExtension.BAD_METADATA_EXTENSION_ID,
BADConstants.PROCEDURE_KEYWORD);
@@ -61,7 +61,7 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.ChannelName)),
0, BADMetadataRecordTypes.CHANNEL_RECORDTYPE, true, new int[] { 0,
1 }, BAD_CHANNEL_INDEX_ID,
-new ChannelTupleTranslator(true));
+() -> new ChannelTupleTranslator(true));
@SuppressWarnings({ "rawtypes", "unchecked" })
public static final ExtensionMetadataDataset BROKER_DATASET = new
ExtensionMetadataDataset(PROPERTIES_BROKER,
@@ -69,7 +69,7 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.BrokerName)),
0, BADMetadataRecordTypes.BROKER_RECORDTYPE, true, new int[] { 0,
1 }, BAD_BROKER_INDEX_ID,
-new BrokerTupleTranslator(true));
+() -> new BrokerTupleTranslator(true));
@SuppressWarnings({ "rawtypes", "unchecked" })
public static final ExtensionMetadataDataset PROCEDURE_DATASET = new
ExtensionMetadataDataset(PROPERTIES_PROCEDURE,
@@ -77,6 +77,6 @@
Arrays.asList(Arrays.asList(MetadataRecordTypes.FIELD_NAME_DATAVERSE_NAME),
Arrays.asList(BADConstants.ProcedureName),
Arrays.asList(BADConstants.FIELD_NAME_ARITY)),
0, BADMetadataRecordTypes.PROCEDURE_RECORDTYPE, true, new int[] {
0, 1, 2 }, BAD_PROCEDURE_INDEX_ID,
-new ProcedureTupleTranslator(true));
+() -> new ProcedureTupleTranslator(true));
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2909
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id:
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3613/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TXN] Fix extension datasets tuple translators
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TXN] Fix extension datasets tuple translators .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7188/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2908 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb8a8342d0f00468e1561d91eb802c52e66b149d Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedA...
abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][EXT] Prevent NPE in close() when using TestTypedAdapter .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2903 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2d62ce00858ff9a9f8033bd21d5da5f1f207c56 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Xikui Wang Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb-bad[master]: Fix tuple translators with extension datasets
abdullah alamoudi has posted comments on this change. Change subject: Fix tuple translators with extension datasets .. Patch Set 1: Code-Review+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2909 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39f6707392085416c01e834ac85767f79a64f9d6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/hDJGbG : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf fix
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf fix .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7189/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8299/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4920/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4582/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4363/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/577/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4756/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/578/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: Analytics Compatibility Compilation Successful https://goo.gl/uxW4AQ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks
Jenkins has posted comments on this change. Change subject: [NO ISSUE][OTH] Log directory tweak, minor perf tweaks .. Patch Set 2: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3611/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2910 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I174d4527fb2c00aed26d83a49c92872ad1ddee00 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Analytics Compatibility Compilation Successful https://goo.gl/GmbPpE : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FUN] Allow extensions to add aggregate functions
Jenkins has posted comments on this change. Change subject: [NO ISSUE][FUN] Allow extensions to add aggregate functions .. Patch Set 5: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7193/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2840 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bec031c833938e38c989acd7aa43b8e93669602 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] Misc Fixes for Point MBR RTree
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Misc Fixes for Point MBR RTree .. Patch Set 4: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3612/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2911 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice24112152a2d93c7d2316b7506e6d6e81f2df44 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
