Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has submitted this change and it was merged.

Change subject: Fix the names of Let to Servlet
..


Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1486
Sonar-Qube: Jenkins 
Reviewed-by: Michael Blow 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSTestServer.java
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
28 files changed, 299 insertions(+), 325 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
index 95eb6fb..395365a 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
@@ -53,11 +53,12 @@
 import org.apache.hyracks.api.client.IHyracksClientConnection;
 import org.apache.hyracks.api.dataset.IHyracksDataset;
 import org.apache.hyracks.client.dataset.HyracksDataset;
-import org.apache.hyracks.http.api.IServlet;
 import org.apache.hyracks.http.api.IServletRequest;
 import org.apache.hyracks.http.api.IServletResponse;
 import org.apache.hyracks.http.server.AbstractServlet;
-import org.apache.hyracks.http.server.util.ServletUtils;
+import org.apache.hyracks.http.server.utils.HttpUtil;
+import org.apache.hyracks.http.server.utils.HttpUtil.ContentType;
+import org.apache.hyracks.http.server.utils.HttpUtil.Encoding;
 
 import io.netty.handler.codec.http.HttpMethod;
 import io.netty.handler.codec.http.HttpResponseStatus;
@@ -111,7 +112,7 @@
 String printJob = request.getParameter("print-job");
 String executeQuery = request.getParameter("execute-query");
 try {
-ServletUtils.setContentType(response, 
IServlet.ContentType.TEXT_HTML, IServlet.Encoding.UTF8);
+HttpUtil.setContentType(response, ContentType.TEXT_HTML, 
Encoding.UTF8);
  

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1904/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1904/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 7: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4299/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> also string switches I think are less efficient...
You're right but we only do this once during bootstrap


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> because those enums were actually just a wrapper around a string
Is there a compelling reason to revert that?  Enums make switch generation much 
easier.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
> Why the change from Enum to Strings?
because those enums were actually just a wrapper around a string


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java:

PS6, Line 23: public static final String AQL = "/aql";
Why the change from Enum to Strings?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1860/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1860/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6: BAD-1

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/519/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/519/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4256/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1486

to look at the new patch set (#6).

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/Servlets.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSTestServer.java
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
28 files changed, 299 insertions(+), 325 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/6
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 5:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/518/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4254/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1486

to look at the new patch set (#5).

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletPathUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSTestServer.java
M asterixdb/asterix-server/pom.xml
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
28 files changed, 299 insertions(+), 325 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4252/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1486

to look at the new patch set (#4).

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
D 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/LetUtil.java
A 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletPathUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSTestServer.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
27 files changed, 299 insertions(+), 320 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8
> The sake of brevity, as I mentioned in HttpUtil.
Done. Only for you Mike


https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java:

PS3, Line 23: Servlets
> Why not just make this enum a top-level class?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8
> Why?
The sake of brevity, as I mentioned in HttpUtil.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8
> HttpUtil.ContentType & HttpUtil.Encoding should either be statically import
Why?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:

PS3, Line 113: HttpUtil.ContentType.TEXT_HTML, HttpUtil.Encoding.UTF8
HttpUtil.ContentType & HttpUtil.Encoding should either be statically imported, 
or should be non-nested.  See my comments in HttpUtil.  Applies to all uses of 
HttpUtil.ContentType & HttpUtil.Encoding in this patch.


https://asterix-gerrit.ics.uci.edu/#/c/1486/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
File 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java:

PS3, Line 23: Servlets
Why not just make this enum a top-level class?


https://asterix-gerrit.ics.uci.edu/#/c/1486/3/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
File 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java:

PS3, Line 49: Encoding
Why not an Enum?  Should either be a top-level entity or statically imported- 
otherwise the consumption is verbose.


PS3, Line 56: ContentType
Why not an Enum?  Should either be a top-level entity or statically imported- 
otherwise the consumption is verbose.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1808/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/476/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1808/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/476/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4187/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1486

to look at the new patch set (#3).

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSFeedServlet.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/server/RSSTestServer.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
26 files changed, 173 insertions(+), 186 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1795/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/1795/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/466/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/466/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4169/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1486

to look at the new patch set (#2).

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ClusterControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ConnectorApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/DiagnosticsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/FeedServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NodeControllerDetailsApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryWebInterfaceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ShutdownApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/VersionApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/GetRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerHandler.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
R 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
24 files changed, 169 insertions(+), 182 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 1: BAD+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/465/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/465/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/4165/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Fix the names of Let to Servlet
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1486
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix the names of Let to Servlet

[abdullah alamoudi (Code Review)]

abdullah alamoudi has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1486

Change subject: Fix the names of Let to Servlet
..

Fix the names of Let to Servlet

Change-Id: Ib2f63f37ee9ef063930478028e3e05ca9dd4742c
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
R 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/utils/ServletUtil.java
M 
asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
M 
asterixdb/asterix-server/src/test/java/org/apache/asterix/server/test/SampleLocalClusterIT.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServlet.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
6 files changed, 62 insertions(+), 61 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/86/1486/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
index 7955ad6..dce0502 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplicationEntryPoint.java
@@ -55,7 +55,7 @@
 import org.apache.asterix.common.config.MetadataProperties;
 import org.apache.asterix.common.context.IStorageComponentProvider;
 import org.apache.asterix.common.library.ILibraryManager;
-import org.apache.asterix.common.utils.LetUtil.Lets;
+import org.apache.asterix.common.utils.ServletUtil.Servlets;
 import org.apache.asterix.external.library.ExternalLibraryManager;
 import org.apache.asterix.file.StorageComponentProvider;
 import org.apache.asterix.messaging.CCMessageBroker;
@@ -166,7 +166,7 @@
 externalProperties.getWebInterfacePort());
 IHyracksClientConnection hcc = getNewHyracksClientConnection();
 webServer.setAttribute(HYRACKS_CONNECTION_ATTR, hcc);
-webServer.addLet(new ApiServlet(webServer.ctx(), new String[] { "/*" },
+webServer.addServlet(new ApiServlet(webServer.ctx(), new String[] { 
"/*" },
 ccExtensionManager.getAqlCompilationProvider(), 
ccExtensionManager.getSqlppCompilationProvider(),
 ccExtensionManager.getQueryTranslatorFactory(), 
componentProvider));
 return webServer;
@@ -182,33 +182,33 @@
 ((ClusterControllerService) 
appCtx.getControllerService()).getExecutor());
 
 // AQL rest APIs.
-addLet(jsonAPIServer, Lets.AQL_QUERY);
-addLet(jsonAPIServer, Lets.AQL_UPDATE);
-addLet(jsonAPIServer, Lets.AQL_DDL);
-addLet(jsonAPIServer, Lets.AQL);
+addServlet(jsonAPIServer, Servlets.AQL_QUERY);
+addServlet(jsonAPIServer, Servlets.AQL_UPDATE);
+addServlet(jsonAPIServer, Servlets.AQL_DDL);
+addServlet(jsonAPIServer, Servlets.AQL);
 
 // SQL+x+ rest APIs.
-addLet(jsonAPIServer, Lets.SQLPP_QUERY);
-addLet(jsonAPIServer, Lets.SQLPP_UPDATE);
-addLet(jsonAPIServer, Lets.SQLPP_DDL);
-addLet(jsonAPIServer, Lets.SQLPP);
+addServlet(jsonAPIServer, Servlets.SQLPP_QUERY);
+addServlet(jsonAPIServer, Servlets.SQLPP_UPDATE);
+addServlet(jsonAPIServer, Servlets.SQLPP_DDL);
+addServlet(jsonAPIServer, Servlets.SQLPP);
 
 // Other APIs.
-addLet(jsonAPIServer, Lets.QUERY_STATUS);
-addLet(jsonAPIServer, Lets.QUERY_RESULT);
-addLet(jsonAPIServer, Lets.QUERY_SERVICE);
-addLet(jsonAPIServer, Lets.CONNECTOR);
-addLet(jsonAPIServer, Lets.SHUTDOWN);
-addLet(jsonAPIServer, Lets.VERSION);
-addLet(jsonAPIServer, Lets.CLUSTER_STATE);
-addLet(jsonAPIServer, Lets.CLUSTER_STATE_NODE_DETAIL); // this must 
not precede add of CLUSTER_STATE
-addLet(jsonAPIServer, Lets.CLUSTER_STATE_CC_DETAIL); // this must not 
precede add of CLUSTER_STATE
-addLet(jsonAPIServer, Lets.DIAGNOSTICS);
+addServlet(jsonAPIServer, Servlets.QUERY_STATUS);
+addServlet(jsonAPIServer, Servlets.QUERY_RESULT);
+addServlet(jsonAPIServer, Servlets.QUERY_SERVICE);
+addServlet(jsonAPIServer, Servlets.CONNECTOR);
+addServlet(jsonAPIServer, Servlets.SHUTDOWN);
+addServlet(jsonAPIServer, Servlets.VERSION);
+addServlet(jsonAPIServer, Servlets.CLUSTER_STATE);
+addServlet(jsonAPIServer, Servlets.CLUSTER_STATE_NODE_DETAIL); // this 
must not precede add of CLUSTER_STATE
+addServlet(jsonAPIServer, Servlets.CLUSTER_STATE_CC_DETAIL); // this 
must not precede add of CLUSTER_STATE
+addServlet(jsonAPIServer, Servlets.DIAGNOSTICS);
 return jsonAPIServer;
 }
 
-