Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2166/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2165/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2164/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2163/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2162/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2160/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Contrib+1 Analytics Compatibility Tests Successful Build 2932 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2107/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2107/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4549/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2177/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4549/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS50, Line 996: for internal dataset > One "internal dataset" too many? Done https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: PS50, Line 102: /** : * Submit merge requests for all disk components within [minID, maxID] : * of all indexes of a given dataset in the given partition : * : * @param minID : * @param maxID : * @param partition : * @param indexInfos : * @throws HyracksDataException : */ > fix the javadocs? Done https://asterix-gerrit.ics.uci.edu/#/c/2025/50/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java: PS50, Line 29: MISSING_COMPONENT_ID > Would it be correct to call this "invalid"? Or is "missing" more appropriat Missing seems to be more approapriate in this case. It mainly handles the situation where the component Id is not found from the metadata (e.g., from a legacy dataset)? Instead of returning null, we return a specify Id to represent this... -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Hello Anon. E. Moose #1000171, abdullah alamoudi, Till Westmann, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2025 to look at the new patch set (#51). Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. [ASTERIXDB-2115] Add Component Ids to LSM Indexes - user model changes: no - storage format changes: no - interface changes: yes Details: - Add LSMComponentId to all LSM components. Component Ids are managed through IO operation callbacks. - For memory component, it's ID is reset every time it's recycled. - For disk component, it's ID is copied from the source component(s) during flush/merge - For indexes of a dataset, we need to guarantee all their memory components should recieve the same ID. This is achieved using a shared component Id generator. - Fix memory component recycled callback, make sure it's called only when we've indeed recycled the memory component A design wiki for this patch: https://cwiki.apache.org/confluence/display/ ASTERIXDB/Component+Id-based+secondary-to-primary+index+acceleration Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBtreeIoOpCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/context/CorrelatedPrefixMergePolicyTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMInvertedIndexIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMRTreeIOOperationCallbackTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorNodePushable.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java M
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2388/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7057/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1506/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/701/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1515/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1520/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2193/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2176/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1840/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2120/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 51: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5561/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 51 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Code-Review+1 (4 comments) Looks good to me, only cosmetic comments/questions. https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS50, Line 996: for internal dataset One "internal dataset" too many? https://asterix-gerrit.ics.uci.edu/#/c/2025/50/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java: PS50, Line 102: /** : * Submit merge requests for all disk components within [minID, maxID] : * of all indexes of a given dataset in the given partition : * : * @param minID : * @param maxID : * @param partition : * @param indexInfos : * @throws HyracksDataException : */ fix the javadocs? https://asterix-gerrit.ics.uci.edu/#/c/2025/50/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentId.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMComponentId.java: PS50, Line 38: notFound Would it be correct to call this "invalid" instead? https://asterix-gerrit.ics.uci.edu/#/c/2025/50/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMComponentId.java: PS50, Line 29: MISSING_COMPONENT_ID Would it be correct to call this "invalid"? Or is "missing" more appropriate? -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4546/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Contrib-1 Analytics Compatibility Tests Failed Build 2931 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2106/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2106/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4546/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1511/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2385/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2116/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5557/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1502/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7053/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1836/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2190/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2173/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2025 to look at the new patch set (#50). Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. [ASTERIXDB-2115] Add Component Ids to LSM Indexes - user model changes: no - storage format changes: no - interface changes: yes Details: - Add LSMComponentId to all LSM components. Component Ids are managed through IO operation callbacks. - For memory component, it's ID is reset every time it's recycled. - For disk component, it's ID is copied from the source component(s) during flush/merge - For indexes of a dataset, we need to guarantee all their memory components should recieve the same ID. This is achieved using a shared component Id generator. - Fix memory component recycled callback, make sure it's called only when we've indeed recycled the memory component A design wiki for this patch: https://cwiki.apache.org/confluence/display/ ASTERIXDB/Component+Id-based+secondary-to-primary+index+acceleration Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBtreeIoOpCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/context/CorrelatedPrefixMergePolicyTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMInvertedIndexIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMRTreeIOOperationCallbackTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorNodePushable.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java M
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1516/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 50: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/697/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4545/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2115/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1501/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/696/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7052/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1515/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1510/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2384/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2189/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2172/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1835/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 49: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5556/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 49 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2383/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2171/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2188/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2114/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/695/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1514/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar// (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1500/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1834/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7051/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2025 to look at the new patch set (#48). Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. [ASTERIXDB-2115] Add Component Ids to LSM Indexes - user model changes: no - storage format changes: no - interface changes: yes Details: - Add LSMComponentId to all LSM components. Component Ids are managed through IO operation callbacks. - For memory component, it's ID is reset every time it's recycled. - For disk component, it's ID is copied from the source component(s) during flush/merge - For indexes of a dataset, we need to guarantee all their memory components should recieve the same ID. This is achieved using a shared component Id generator. - Fix memory component recycled callback, make sure it's called only when we've indeed recycled the memory component A design wiki for this patch: https://cwiki.apache.org/confluence/display/ ASTERIXDB/Component+Id-based+secondary-to-primary+index+acceleration Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBtreeIoOpCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/context/CorrelatedPrefixMergePolicyTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMInvertedIndexIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMRTreeIOOperationCallbackTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorNodePushable.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java M
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 48: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1509/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 48 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2170/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2382/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1513/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7050/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/694/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1499/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1833/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2113/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1508/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2025 to look at the new patch set (#47). Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. [ASTERIXDB-2115] Add Component Ids to LSM Indexes - user model changes: no - storage format changes: no - interface changes: yes Details: - Add LSMComponentId to all LSM components. Component Ids are managed through IO operation callbacks. - For memory component, it's ID is reset every time it's recycled. - For disk component, it's ID is copied from the source component(s) during flush/merge - For indexes of a dataset, we need to guarantee all their memory components should recieve the same ID. This is achieved using a shared component Id generator. - Fix memory component recycled callback, make sure it's called only when we've indeed recycled the memory component A design wiki for this patch: https://cwiki.apache.org/confluence/display/ ASTERIXDB/Component+Id-based+secondary-to-primary+index+acceleration Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBtreeIoOpCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/context/CorrelatedPrefixMergePolicyTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMInvertedIndexIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMRTreeIOOperationCallbackTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorNodePushable.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java M
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2187/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 47: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5554/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 47 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4544/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2186/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2381/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2169/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1498/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1507/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/693/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1512/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Hello Anon. E. Moose #1000171, abdullah alamoudi, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2025 to look at the new patch set (#46). Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. [ASTERIXDB-2115] Add Component Ids to LSM Indexes - user model changes: no - storage format changes: no - interface changes: yes Details: - Add LSMComponentId to all LSM components. Component Ids are managed through IO operation callbacks. - For memory component, it's ID is reset every time it's recycled. - For disk component, it's ID is copied from the source component(s) during flush/merge - For indexes of a dataset, we need to guarantee all their memory components should recieve the same ID. This is achieved using a shared component Id generator. - Fix memory component recycled callback, make sure it's called only when we've indeed recycled the memory component A design wiki for this patch: https://cwiki.apache.org/confluence/display/ ASTERIXDB/Component+Id-based+secondary-to-primary+index+acceleration Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestDataset.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/TestLsmBtreeIoOpCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IDatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/CorrelatedPrefixMergePolicy.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLSMComponentIdGeneratorFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetResource.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/PrimaryIndexOperationTracker.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIOOperationCallback.java A asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/AbstractLSMIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMInvertedIndexIOOperationCallbackFactory.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMRTreeIOOperationCallbackFactory.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/context/CorrelatedPrefixMergePolicyTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMInvertedIndexIOOperationCallbackTest.java M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/ioopcallbacks/LSMRTreeIOOperationCallbackTest.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataProvider.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Dataset.java M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/SecondaryIndexOperationsHelper.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorDescriptor.java A asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMIndexBulkLoadOperatorNodePushable.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java M
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5553/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1832/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7049/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 46: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2112/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 46 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2115] Add Component Ids to LSM Indexes
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2115] Add Component Ids to LSM Indexes .. Patch Set 45: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4540/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2025 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8aec6261a84a0729ce35f4b1cb708be299ddb98d Gerrit-PatchSet: 45 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo ChenGerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No