Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-19 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson:

PS6, Line 10: NaN
> Not sure either. We can look at it separately.
Just for the reference (see "IEEE754 Conformance" section discussing the 
comparison of NaN): 
https://docs.oracle.com/database/121/SQLRF/sql_elements001.htm#SQLRF50985


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-19 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

(18 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson:

PS6, Line 1: {
> Could this be an adm file?
I will change all .regexjson to .adm later


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson:

PS6, Line 3: false
> This is because there's no '-0' in the integer domain?
I would assume so.


PS6, Line 10: NaN
> Not sure how 'NaN' should compare. Is this result consistent with the Java 
Not sure either. We can look at it separately.


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson:

PS6, Line 8: "[1,2] < [1,2,missing]", "r": true
> This is interesting. It seems that the length comparison kicks in before lo
Yes, length comparison kicks in when all pairs evaluate to equal (plus other 
conditions). Not sure about how others do it.


PS6, Line 13: "[null,1] = [1,1,3]", "r": false
> Should this be 'null'?
I guess we always know the answer no matter what null value is.


PS6, Line 18: false
> null?
99 != 1. So, no matter what null is, we will end up with a false answer.


PS6, Line 24: false
> null?
3 != 99 regardless of the null value.


PS6, Line 25: false
> missing?
The answer is always known due to the fact that 3 != 99


PS6, Line 26: false
> missing?
4 != 99


PS6, Line 27: false
> missing?
We've got 5 != 99 which should make the statement false.


PS6, Line 28: false
> missing?
We've got 5 != 9 which should make the statement false.


PS6, Line 32: true
> null?
The statement is always true because 3 != 99 is always true regardless of the 
null value.


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson:

PS6, Line 6: false
> null?
Same idea here. If we know the answer for sure, null value does not make a 
difference.


PS6, Line 8: false
> null?
Same here.


PS6, Line 9: false
> null?
Same here.


PS6, Line 10: "t9"
> stopping here.
It's null here because 'string' is incomparable to 2, not because of the null.


https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java:

Line 104: throw new IllegalStateException("Two different 
non-numeric tags but they are compatible");
> The message should say " ... NOT compatible", right?
I think I meant compatible. I check at line 87 if the two types are compatible 
and then proceed. So, starting line 95, the two types are compatible for sure. 
They could be (1) numbers (2) non-numbers.
The exception here is for (2) since I don't think we have compatible tags which 
are not number yet, like DATE and DATETIME.


https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java:

Line 41: boolean free(E element);
> minor. add javadoc.
Sure. I'll add it in the following change.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-19 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has submitted this change and it was merged.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


[ASTERIXDB-2516][RT] add support for array deep comparison

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
Add support for array deep comparison.
- modified LogicalComplexBinaryComparator.java to allow array comparison
- added test cases for array comparison
- changed interface IObjectPool.java to allow freeing a specific object

Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3173
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Contrib: Michael Blow 
Reviewed-by: Dmitry Lychagin 
Reviewed-by: Till Westmann 
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.001.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.002.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.003.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.004.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.005.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.006.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.007.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.008.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.009.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.010.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.011.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.012.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.013.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.014.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.015.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.016.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.017.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.018.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.019.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.020.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.021.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.022.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.023.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.003.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.008.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.009.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.010.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.011.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.012.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.013.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.015.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.016.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.017.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.018.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.019.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-19 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Code-Review+2

(21 comments)

There are a number of comments and open questions on the test results. 
But, as a) this change does not break existing functionality and b) we know 
that follow-up changes will be submitted soon, we can merge this change now and 
address the comments in the follow-up changes.

https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson:

PS6, Line 1: {
Could this be an adm file?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson:

PS6, Line 1: {
Could this be an adm file?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson:

PS6, Line 1: {
Could this be an adm file?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson:

PS6, Line 1: {
Could this be an adm file?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.020.regexjson:

PS6, Line 1: {
Could this be an adm file?


PS6, Line 3: false
This is because there's no '-0' in the integer domain?


PS6, Line 10: NaN
Not sure how 'NaN' should compare. Is this result consistent with the Java 
(and/or SQL) developer expectation?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.021.regexjson:

PS6, Line 1: {
Could this be an adm file?


PS6, Line 8: "[1,2] < [1,2,missing]", "r": true
This is interesting. It seems that the length comparison kicks in before 
looking at remaining values. Do other languages do this similarly?


PS6, Line 13: "[null,1] = [1,1,3]", "r": false
Should this be 'null'?


PS6, Line 18: false
null?


PS6, Line 24: false
null?


PS6, Line 25: false
missing?


PS6, Line 26: false
missing?


PS6, Line 27: false
missing?


PS6, Line 28: false
missing?


PS6, Line 32: true
null?


https://asterix-gerrit.ics.uci.edu/#/c/3173/6/asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson
File 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.022.regexjson:

PS6, Line 6: false
null?


PS6, Line 8: false
null?


PS6, Line 9: false
null?


PS6, Line 10: "t9"
stopping here.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-19 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Code-Review+1

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalScalarBinaryComparator.java:

Line 104: throw new IllegalStateException("Two different 
non-numeric tags but they are compatible");
The message should say " ... NOT compatible", right?


https://asterix-gerrit.ics.uci.edu/#/c/3173/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java:

Line 41: boolean free(E element);
minor. add javadoc.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-17 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Contrib+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-17 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Analytics Compatibility Tests Failed
https://goo.gl/TJckcu : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3989/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3989/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8009/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/2ELV7L : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/52/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5132/ 
(14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Analytics Compatibility Compilation Successful
https://goo.gl/oGPzdP : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5593/ 
(1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5222/
 (15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/535/
 (10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3235/ 
(9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10706/ (2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5224/ 
(13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/220/ 
(3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9177/ (4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5444/
 (5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5186/ 
(12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5445/ 
(8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/390/ (11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5801/ (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/598/
 (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-16 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Analytics Compatibility Tests Failed
https://goo.gl/d1eCgW : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7993/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3980/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3980/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/46/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/214/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/LdZrP7 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7993/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5436/
 (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/577/
 (13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/523/
 (3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9148/ (5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5195/
 (12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Analytics Compatibility Compilation Successful
https://goo.gl/w7aG3m : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5105/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5773/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5196/ 
(7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5417/ 
(8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5565/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5158/ 
(9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3207/ 
(6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10677/ (10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/361/ (2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Analytics Compatibility Compilation Successful
https://goo.gl/dCYLCc : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10676/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5194/
 (12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5104/ 
(11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5157/ 
(9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3206/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5772/ (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/360/ (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5195/ 
(2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/522/
 (8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5564/ 
(5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5416/ 
(10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 5:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9147/ (3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-14 Thread Ali Alsuliman (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3173

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..

[ASTERIXDB-2516][RT] add support for array deep comparison

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
Add support for array deep comparison.
- modified LogicalComplexBinaryComparator.java to allow array comparison
- added test cases for array comparison
- changed interface IObjectPool.java to allow freeing a specific object

Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.001.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.002.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.003.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.004.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.005.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.006.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.007.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.008.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.009.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.010.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.011.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.012.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.013.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.014.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.015.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.016.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.017.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.018.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.019.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.020.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.021.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.022.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.023.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.003.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.008.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.009.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.010.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.011.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.012.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.013.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.015.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.016.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.017.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.018.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.019.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3977/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7969/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3977/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/37/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7969/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/206/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/552/
 (13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5427/
 (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5529/ 
(12/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/UksdRU : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5162/
 (11/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Analytics Compatibility Compilation Successful
https://goo.gl/56i57P : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-13 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5072/ 
(10/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Ali Alsuliman (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, Dmitry Lychagin,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/3173

to look at the new patch set (#4).

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..

[ASTERIXDB-2516][RT] add support for array deep comparison

- user model changes: no
- storage format changes: no
- interface changes: yes

Details:
Add support for array deep comparison.
- modified LogicalComplexBinaryComparator.java to allow array comparison
- added test cases for array comparison
- changed interface IObjectPool.java to allow freeing a specific object

Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.001.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.002.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.003.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.004.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.005.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.006.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.007.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.008.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.009.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.010.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.011.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.012.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.013.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.014.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.015.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.016.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.017.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.018.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.019.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.020.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.021.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.022.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/comparison/arrays/arrays.023.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.003.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.004.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.005.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.006.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.007.regexjson
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.008.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.009.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.010.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.011.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.012.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.013.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.014.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.015.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.016.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.017.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.018.adm
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/comparison/arrays/arrays.019.adm
A 

Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5740/ (6/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5125/ 
(3/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/5384/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3174/ 
(2/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/328/ (8/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/512/
 (7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5163/ 
(5/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/10644/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9114/ (9/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7949/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-12 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3: Contrib+1

Analytics Compatibility Tests Successful
https://goo.gl/XWhM8b : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7949/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/31/ 
(16/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/532/
 (13/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Ali Alsuliman (Code Review)
Ali Alsuliman has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 2:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3173/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/comparators/LogicalComplexBinaryComparator.java:

PS2, Line 67: comparisonResult
> It seems that we're adding another option to the Result enum (one that we c
I don't see we are adding another option. This is internal.
Would that another option be useful for the calling functions (EQ, LT, )


Line 72: // maybe we can invoke the scalar comparison? or we can 
even reduce this comparator to be the generic one?
> when can this happen? LogicalComparatorUtil creates this comparator only if
I changed it to illegal state exception.


PS2, Line 101: if (result == Result.LT) {
 : return Result.GT;
 : } else if (result == Result.GT) {
 : return Result.LT;
 : }
 : return result;
> maybe
Done


PS2, Line 122: byte[] leftBytes, int leftStart,
 : int leftLen
> Should we pass a Pointable here?
Let's see how it would look like when I introduce the other parts (records and 
multisets). I would have to create/get a pointable in the pool in that case.


Line 125: if (!ATypeHierarchy.isCompatible(leftRuntimeTag, 
rightRuntimeTag)) {
> is this just checking whether the two types are the same? because there're 
Yes. I changed it now.


PS2, Line 206: if (result != Result.EQ) {
> I think NULL is the right answer based on the pair-wise comparison. Let's d
Sure.


https://asterix-gerrit.ics.uci.edu/#/c/3173/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/util/container/IObjectPool.java:

PS2, Line 41: markFree
> Just call it "free"?
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/201/ 
(15/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5422/
 (14/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/5720/ (1/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/5509/ 
(4/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5104/ 
(7/16)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2516][RT] add support for array deep comparison

2019-02-11 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2516][RT] add support for array deep comparison
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/36jKgm : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3173
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fef48d7c6189362f44786b8d89d89c5f91d4b10
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


  1   2   >