[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082853325 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082853325 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] janl opened a new issue, #4396: Add comments to mixed-cluster upgrade code

2023-01-20 Thread GitBox
janl opened a new issue, #4396: URL: https://github.com/apache/couchdb/issues/4396 Via https://github.com/apache/couchdb/pull/4394#pullrequestreview-1263473784 It’d be nice if we tagged code that can be removed after we can expect everybody to have gone through a rolling cluster

[GitHub] [couchdb] janl closed issue #4391: Get reduce count for mango query

2023-01-20 Thread GitBox
janl closed issue #4391: Get reduce count for mango query URL: https://github.com/apache/couchdb/issues/4391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb] janl commented on issue #4391: Get reduce count for mango query

2023-01-20 Thread GitBox
janl commented on issue #4391: URL: https://github.com/apache/couchdb/issues/4391#issuecomment-1398677113 this feature does not exist at the moment but would be a great addition. Closing in favour of the earlier https://github.com/apache/couchdb/issues/1254 -- This is an automated

[GitHub] [couchdb] janl merged pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
janl merged PR #4394: URL: https://github.com/apache/couchdb/pull/4394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] chiraganand commented on issue #4373: POST _revs_diff request stuck without timing out

2023-01-20 Thread GitBox
chiraganand commented on issue #4373: URL: https://github.com/apache/couchdb/issues/4373#issuecomment-1398666738 > Could try also tweaking the number of replication workers, maybe try 1 instead of 4 > > https://docs.couchdb.org/en/stable/config/replicator.html > > ``` >

[GitHub] [couchdb] chiraganand commented on issue #4373: POST _revs_diff request stuck without timing out

2023-01-20 Thread GitBox
chiraganand commented on issue #4373: URL: https://github.com/apache/couchdb/issues/4373#issuecomment-1398665264 I tried v3.3.1 and was able to reproduce the error exactly after 800 requests on an EC2 _m4.large VM_. Some more observations: 1. If I reduced the number of concurrent

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082822189 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key,

[GitHub] [couchdb] janl commented on pull request #4395: ci(freebsd): re-enable full platform ci on FreeBSD

2023-01-20 Thread GitBox
janl commented on PR #4395: URL: https://github.com/apache/couchdb/pull/4395#issuecomment-1398652971 Clean bill of health & nice and fast https://user-images.githubusercontent.com/11321/213755187-48c2ef9c-4198-4c68-9524-924aee0847f4.png;>

[GitHub] [couchdb] janl commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
janl commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082660139 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] github-code-scanning[bot] commented on a diff in pull request #4291: Import nouveau

2023-01-20 Thread GitBox
github-code-scanning[bot] commented on code in PR #4291: URL: https://github.com/apache/couchdb/pull/4291#discussion_r1082646943 ## java/nouveau/server/src/main/java/org/apache/couchdb/nouveau/core/IndexManager.java: ## @@ -0,0 +1,268 @@ +// +// Licensed under the Apache

[GitHub] [couchdb] janl commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
janl commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082607599 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082582977 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key,

[GitHub] [couchdb] janl commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
janl commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082422633 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] tophe closed issue #4385: replication restart from start after server restart

2023-01-20 Thread GitBox
tophe closed issue #4385: replication restart from start after server restart URL: https://github.com/apache/couchdb/issues/4385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [couchdb] tophe commented on issue #4385: replication restart from start after server restart

2023-01-20 Thread GitBox
tophe commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1398211068 hi, sorry for the local.ini, if you have get it, you should see that I haven't set the uuid, as you guessed. I set it on each cluster, and restart. Now every thing work as

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082305003 ## src/mango/src/mango_cursor_view.erl: ## @@ -441,7 +496,12 @@ doc_member(Cursor, RowProps) -> case mango_util:defer(fabric, open_doc, [Db, Id, Opts])

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082305003 ## src/mango/src/mango_cursor_view.erl: ## @@ -441,7 +496,12 @@ doc_member(Cursor, RowProps) -> case mango_util:defer(fabric, open_doc, [Db, Id, Opts])

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-20 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082300742 ## src/mango/src/mango_cursor_view.erl: ## @@ -422,16 +472,21 @@ apply_opts([{_, _} | Rest], Args) -> % Ignore unknown options apply_opts(Rest, Args).

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082069624 ## src/mango/src/mango_cursor_view.erl: ## @@ -441,7 +496,12 @@ doc_member(Cursor, RowProps) -> case mango_util:defer(fabric, open_doc, [Db, Id, Opts]) of

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082069624 ## src/mango/src/mango_cursor_view.erl: ## @@ -441,7 +496,12 @@ doc_member(Cursor, RowProps) -> case mango_util:defer(fabric, open_doc, [Db, Id, Opts]) of

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1082067804 ## src/mango/src/mango_cursor_view.erl: ## @@ -422,16 +472,21 @@ apply_opts([{_, _} | Rest], Args) -> % Ignore unknown options apply_opts(Rest, Args).

[GitHub] [couchdb] nickva commented on issue #4385: replication restart from start after server restart

2023-01-19 Thread GitBox
nickva commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1397565505 In dock.zip I had noticed local.ini wasn't at text file but some kind of a binary. ``` % cat local.ini �E�c'K�cnO�cuxUT ``` One thing to pay attention is if

[GitHub] [couchdb] nickva merged pull request #4387: ci(mac): re-enable mac CI for the full build

2023-01-19 Thread GitBox
nickva merged PR #4387: URL: https://github.com/apache/couchdb/pull/4387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva closed pull request #4389: ci(mac): re-enable mac CI for the full build

2023-01-19 Thread GitBox
nickva closed pull request #4389: ci(mac): re-enable mac CI for the full build URL: https://github.com/apache/couchdb/pull/4389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [couchdb] nickva commented on pull request #4389: ci(mac): re-enable mac CI for the full build

2023-01-19 Thread GitBox
nickva commented on PR #4389: URL: https://github.com/apache/couchdb/pull/4389#issuecomment-1397474748 Original PR's full CI now passes. Closing this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [couchdb] nickva merged pull request #4393: docs(mango): match description of `$mod` with reality (3.2.2)

2023-01-19 Thread GitBox
nickva merged PR #4393: URL: https://github.com/apache/couchdb/pull/4393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva merged pull request #4392: docs(mango): match description of `$mod` with reality (3.3.x)

2023-01-19 Thread GitBox
nickva merged PR #4392: URL: https://github.com/apache/couchdb/pull/4392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081599218 ## src/mango/src/mango_cursor_view.erl: ## @@ -35,6 +35,19 @@ -define(HEARTBEAT_INTERVAL_IN_USEC, 400). +% viewcbargs wraps up the arguments that view_cb

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081596322 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key,

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081579998 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] mikerhodes commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
mikerhodes commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081539012 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key,

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081520232 ## src/mango/src/mango_cursor_view.erl: ## @@ -248,6 +266,19 @@ view_cb({row, Row}, #mrargs{extra = Options} = Acc) -> key = couch_util:get_value(key, Row),

[GitHub] [couchdb] nickva commented on a diff in pull request #4394: Mango fields pushdown

2023-01-19 Thread GitBox
nickva commented on code in PR #4394: URL: https://github.com/apache/couchdb/pull/4394#discussion_r1081514712 ## src/mango/src/mango_cursor_view.erl: ## @@ -35,6 +35,19 @@ -define(HEARTBEAT_INTERVAL_IN_USEC, 400). +% viewcbargs wraps up the arguments that view_cb uses

[GitHub] [couchdb] janl commented on pull request #4387: ci(mac): re-enable mac CI for the full build

2023-01-19 Thread GitBox
janl commented on PR #4387: URL: https://github.com/apache/couchdb/pull/4387#issuecomment-1397116512 PATH issue, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] mikerhodes opened a new pull request, #4394: Mango fields pushdown

2023-01-19 Thread GitBox
mikerhodes opened a new pull request, #4394: URL: https://github.com/apache/couchdb/pull/4394 ## Overview This PR aims to improve Mango by reducing the data transferred to the coordinator during query execution. It may reduce memory or CPU use at the coordinator but that isn't

[GitHub] [couchdb] pgj opened a new pull request, #4393: docs(mango): match description of `$mod` with reality

2023-01-19 Thread GitBox
pgj opened a new pull request, #4393: URL: https://github.com/apache/couchdb/pull/4393 Backport of aff7a6e7183e6c471a9675e37216baa0bad563a3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb] pgj opened a new pull request, #4392: docs(mango): match description of `$mod` with reality

2023-01-19 Thread GitBox
pgj opened a new pull request, #4392: URL: https://github.com/apache/couchdb/pull/4392 Backport of aff7a6e7183e6c471a9675e37216baa0bad563a3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb] tophe commented on issue #4385: replication restart from start after server restart

2023-01-19 Thread GitBox
tophe commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1397041792 I have just find the problem, it is docker dependent. when you do a docker stop/start everything is ok with replication. but when you update the container, running a docker

[GitHub] [couchdb] tophe closed issue #4385: replication restart from start after server restart

2023-01-19 Thread GitBox
tophe closed issue #4385: replication restart from start after server restart URL: https://github.com/apache/couchdb/issues/4385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [couchdb] tophe commented on issue #4385: replication restart from start after server restart

2023-01-19 Thread GitBox
tophe commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1396964894 hello, I have do many test stopping and starting all the replication nodes in different order and I can't reproduce the problem, it seem every things are working fine. After

[GitHub] [couchdb-glazier] big-r81 merged pull request #20: docs: update installation instructions

2023-01-19 Thread GitBox
big-r81 merged PR #20: URL: https://github.com/apache/couchdb-glazier/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb-glazier] pgj opened a new pull request, #20: docs: update installation instructions

2023-01-19 Thread GitBox
pgj opened a new pull request, #20: URL: https://github.com/apache/couchdb-glazier/pull/20 - Unify spelling of SpiderMonkey. - Take a note about the missing SSL certificates that would be required for the SpiderMonkey build due to Rust. - Note that questions on `mach bootstrap` might

[GitHub] [couchdb] ishaiavrahami opened a new issue, #4391: Get reduce count for mango query

2023-01-19 Thread GitBox
ishaiavrahami opened a new issue, #4391: URL: https://github.com/apache/couchdb/issues/4391 [NOTE]: # ( ^^ Provide a general summary of the request in the title above. ^^ ) ## Summary Hello i'm trying to get a count of the query like the reduce option in mango query just like the

[GitHub] [couchdb] nickva opened a new issue, #4390: Simplify TLS peer verification for replication

2023-01-18 Thread GitBox
nickva opened a new issue, #4390: URL: https://github.com/apache/couchdb/issues/4390 By default replicator TLS connections do not verify the TLS peer certificates

[GitHub] [couchdb] nickva commented on issue #4373: POST _revs_diff request stuck without timing out

2023-01-18 Thread GitBox
nickva commented on issue #4373: URL: https://github.com/apache/couchdb/issues/4373#issuecomment-1396069370 It's strange that it times out before even making a connection. Could try also tweaking the number of replication workers, maybe try 1 instead of 4

[GitHub] [couchdb] nickva commented on issue #4259: make check failed in arm64

2023-01-18 Thread GitBox
nickva commented on issue #4259: URL: https://github.com/apache/couchdb/issues/4259#issuecomment-1396062541 @Tom-python0121 sorry for the delayed response. It looks like there is some exception throw. The eunit (the test framework used to run the tests) dumps extra logs in

[GitHub] [couchdb] nickva opened a new pull request, #4389: ci(mac): re-enable mac CI for the full build

2023-01-18 Thread GitBox
nickva opened a new pull request, #4389: URL: https://github.com/apache/couchdb/pull/4389 Full CI test for the https://github.com/apache/couchdb/pull/4387 PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [couchdb] nickva merged pull request #4388: Bump recon to 2.5.3

2023-01-18 Thread GitBox
nickva merged PR #4388: URL: https://github.com/apache/couchdb/pull/4388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on issue #4385: replication restart from start after server restart

2023-01-18 Thread GitBox
nickva commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1387498995 @tophe would you be able to share more details how to reproduce the issue or show some sanitized logs. See if there are any errors / exceptions in the logs which may prevent

[GitHub] [couchdb] nickva commented on issue #4385: replication restart from start after server restart

2023-01-18 Thread GitBox
nickva commented on issue #4385: URL: https://github.com/apache/couchdb/issues/4385#issuecomment-1387497652 @tophe thanks for your report. I had tried setting up a local replication with the 3.3.1 release and I couldn't not reproduce the same issue. I had created database a

[GitHub] [couchdb] nickva opened a new pull request, #4388: Bump rebar to 2.5.3

2023-01-18 Thread GitBox
nickva opened a new pull request, #4388: URL: https://github.com/apache/couchdb/pull/4388 Changes since 2.5.2: https://github.com/ferd/recon/compare/2.5.2...2.5.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [couchdb] big-r81 merged pull request #4384: Adding build-report makefile target on Windows

2023-01-18 Thread GitBox
big-r81 merged PR #4384: URL: https://github.com/apache/couchdb/pull/4384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] big-r81 closed issue #4377: Missing `build-report` makefile target on Windows

2023-01-18 Thread GitBox
big-r81 closed issue #4377: Missing `build-report` makefile target on Windows URL: https://github.com/apache/couchdb/issues/4377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb-nano] jkeczan commented on issue #322: Replication Enable creating incorrect document

2023-01-18 Thread GitBox
jkeczan commented on issue #322: URL: https://github.com/apache/couchdb-nano/issues/322#issuecomment-1387315923 I had already figured that one out as a workaround after I posted the issue but thought it was odd that the replicate function didn't create a document that could be replicated.

[GitHub] [couchdb] rnewson merged pull request #4379: docs(mango): match description of `$mod` with reality

2023-01-18 Thread GitBox
rnewson merged PR #4379: URL: https://github.com/apache/couchdb/pull/4379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on a diff in pull request #4386: chore(readme): update mac dev install instructions

2023-01-18 Thread GitBox
nickva commented on code in PR #4386: URL: https://github.com/apache/couchdb/pull/4386#discussion_r1073714355 ## README-DEV.rst: ## @@ -115,15 +115,18 @@ Unless you want to install the optional dependencies, skip to the next section. Install what else we can with Homebrew::

[GitHub] [couchdb] janl commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-18 Thread GitBox
janl commented on code in PR #4380: URL: https://github.com/apache/couchdb/pull/4380#discussion_r1073670697 ## configure: ## @@ -230,6 +235,26 @@ then exit 1 fi +if [ "${ERLANG_OS}" = "unix" ] +then Review Comment: most other ifs use the other way around, let’s take

[GitHub] [couchdb] nickva commented on pull request #4387: ci(mac): re-enable mac CI for the full build

2023-01-18 Thread GitBox
nickva commented on PR #4387: URL: https://github.com/apache/couchdb/pull/4387#issuecomment-1387223459 Use the `jenkins-*`-like branch name so the full CI will run on the PR. That's a good way to test full CI changes in a PR. -- This is an automated message from the Apache Git Service.

[GitHub] [couchdb] janl opened a new pull request, #4387: ci(mac): re-enable mac CI for the full build

2023-01-18 Thread GitBox
janl opened a new pull request, #4387: URL: https://github.com/apache/couchdb/pull/4387 ## Overview ## Testing recommendations ## Related Issues or Pull Requests ## Checklist - [ ] Code is written and works correctly - [ ]

[GitHub] [couchdb] janl opened a new pull request, #4386: chore(readme): update mac dev install instructions

2023-01-18 Thread GitBox
janl opened a new pull request, #4386: URL: https://github.com/apache/couchdb/pull/4386 ## Overview ## Testing recommendations ## Related Issues or Pull Requests ## Checklist - [ ] Code is written and works correctly - [ ]

[GitHub] [couchdb-mango] hklarner closed pull request #48: adds operators $sizeLte and $sizeGte

2023-01-18 Thread GitBox
hklarner closed pull request #48: adds operators $sizeLte and $sizeGte URL: https://github.com/apache/couchdb-mango/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] hklarner closed pull request #3582: adds operators $sizeLte and $sizeGte

2023-01-18 Thread GitBox
hklarner closed pull request #3582: adds operators $sizeLte and $sizeGte URL: https://github.com/apache/couchdb/pull/3582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [couchdb] big-r81 commented on issue #4376: Missing `weatherreport-test` makefile target on Windows

2023-01-18 Thread GitBox
big-r81 commented on issue #4376: URL: https://github.com/apache/couchdb/issues/4376#issuecomment-1387150304 Update: Discussion with Robert on Slack: > weatherreport was built with Linux in mind and nothing else afaicr since it was for when Cloudant had customers running a build

[GitHub] [couchdb] tophe opened a new issue, #4385: replication restart from start after server restart

2023-01-18 Thread GitBox
tophe opened a new issue, #4385: URL: https://github.com/apache/couchdb/issues/4385 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description Hello, since the upgrade in v3.3.1, I see that when a server restart, all replications restart from

[GitHub] [couchdb-nano] glynnbird closed issue #322: Replication Enable creating incorrect document

2023-01-18 Thread GitBox
glynnbird closed issue #322: Replication Enable creating incorrect document URL: https://github.com/apache/couchdb-nano/issues/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [couchdb-nano] glynnbird commented on issue #322: Replication Enable creating incorrect document

2023-01-18 Thread GitBox
glynnbird commented on issue #322: URL: https://github.com/apache/couchdb-nano/issues/322#issuecomment-1386719578 Thanks for the reports @jkeczan but I don't think "replication.enable" is doing anything unexpected here. As you can see from the

[GitHub] [couchdb] big-r81 opened a new pull request, #4384: Adding build-report makefile target on Windows

2023-01-17 Thread GitBox
big-r81 opened a new pull request, #4384: URL: https://github.com/apache/couchdb/pull/4384 Backporting the `build-report` target from the *nix makefile to the Windows pendant. ## Overview Run this on Windows: ``` PS C:\relax\couchdb> make -f Makefile.win build-report

[GitHub] [couchdb] nickva commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
nickva commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1386457446 I extracted the commit which modified the `Jenkinsfile.pr` into a separate PR to allow this PR to run in the CI again https://github.com/apache/couchdb/pull/4383 -- This is an

[GitHub] [couchdb] nickva merged pull request #4383: Set the SpiderMonkey version for the first phase of PR builds

2023-01-17 Thread GitBox
nickva merged PR #4383: URL: https://github.com/apache/couchdb/pull/4383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on pull request #4382: Pr 4380 spidermonkey check

2023-01-17 Thread GitBox
nickva commented on PR #4382: URL: https://github.com/apache/couchdb/pull/4382#issuecomment-1386434026 Closing PR now that the check is complete. Pulled out the Jenkinsfile.pr bit into a separate PR https://github.com/apache/couchdb/pull/4383 to help the original one make progress.

[GitHub] [couchdb] nickva closed pull request #4382: Pr 4380 spidermonkey check

2023-01-17 Thread GitBox
nickva closed pull request #4382: Pr 4380 spidermonkey check URL: https://github.com/apache/couchdb/pull/4382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb] nickva opened a new pull request, #4383: Set the SpiderMonkey version for the first phase of PR builds

2023-01-17 Thread GitBox
nickva opened a new pull request, #4383: URL: https://github.com/apache/couchdb/pull/4383 Merging this separately to help out the original PR https://github.com/apache/couchdb/pull/4380 This is my +1 for this commit. The discussion is still taking place in the original PR -- This

[GitHub] [couchdb] nickva opened a new pull request, #4382: Pr 4380 spidermonkey check

2023-01-17 Thread GitBox
nickva opened a new pull request, #4382: URL: https://github.com/apache/couchdb/pull/4382 The `configure` script does not check whether SpiderMonkey actually exists at the presumed location. This may go wrong when the user has a version different from the default one. The mistake is

[GitHub] [couchdb-nano] jkeczan opened a new issue, #322: Replication Enable creating correct document

2023-01-17 Thread GitBox
jkeczan opened a new issue, #322: URL: https://github.com/apache/couchdb-nano/issues/322 We are having issues with creating replications using ```replication.enable```. The server accepts the request but the replication document does not contain the correct replication information

[GitHub] [couchdb-helm] willholley merged pull request #108: Automatically finalize the cluster with a post-install job

2023-01-17 Thread GitBox
willholley merged PR #108: URL: https://github.com/apache/couchdb-helm/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] nickva commented on issue #4378: v3.3.1 compaction smoosh config

2023-01-17 Thread GitBox
nickva commented on issue #4378: URL: https://github.com/apache/couchdb/issues/4378#issuecomment-1385724686 Thank you for reaching out, @tophe. Good idea to add this info documentation, that's would have helped in this case. -- This is an automated message from the Apache Git Service. To

[GitHub] [couchdb] pgj commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on code in PR #4380: URL: https://github.com/apache/couchdb/pull/4380#discussion_r1072397056 ## configure: ## @@ -230,6 +235,26 @@ then exit 1 fi +if [ "${ERLANG_OS}" = "unix" ] +then Review Comment: Hrm, I see exactly the opposite. For example, see the

[GitHub] [couchdb] pgj commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on code in PR #4380: URL: https://github.com/apache/couchdb/pull/4380#discussion_r1072377400 ## configure: ## @@ -30,10 +30,15 @@ WITH_DOCS=1 ERLANG_MD5="false" SKIP_DEPS=0 +run_erlang() { +erl -noshell -eval "$1" -eval "halt()." +} +

[GitHub] [couchdb] pgj commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on code in PR #4380: URL: https://github.com/apache/couchdb/pull/4380#discussion_r1072377400 ## configure: ## @@ -30,10 +30,15 @@ WITH_DOCS=1 ERLANG_MD5="false" SKIP_DEPS=0 +run_erlang() { +erl -noshell -eval "$1" -eval "halt()." +} +

[GitHub] [couchdb] janl commented on a diff in pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
janl commented on code in PR #4380: URL: https://github.com/apache/couchdb/pull/4380#discussion_r1072364924 ## configure: ## @@ -30,10 +30,15 @@ WITH_DOCS=1 ERLANG_MD5="false" SKIP_DEPS=0 +run_erlang() { +erl -noshell -eval "$1" -eval "halt()." +} +

[GitHub] [couchdb] big-r81 commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
big-r81 commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385538700 Yeah, I'm wondering too atm... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385529390 Hrm, that is interesting. I have checked the corresponding `rebar` scripts and only these paths were included on the C compiler flags. -- This is an automated message from the Apache Git

[GitHub] [couchdb] big-r81 commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
big-r81 commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385520096 Are these the only possibilities for the paths? On my macOs it's ``` /usr/local/Cellar/spidermonkey/91.13.0_1/include/mozjs-91/ ``` -- This is an automated message from the

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385509568 @big-r81 do you have any ideas why this current version fails on the CI? Initially I thought that is due to `--skip-deps` but by browsing the code, it seems to be unrelated. -- This is

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385507303 Sure, I am happy to consider the Windows bits as well. Maybe I can find a Windows system somewhere to poke around with this. -- This is an automated message from the Apache Git Service.

[GitHub] [couchdb] big-r81 commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
big-r81 commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385496488 It's only a reminder, because it ends in like this and this #4376 and #4377. We hopefully have our Windows CI soon in our

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385488222 Hi @big-r81 : I tried to mention that this is for Unix-based systems -- I do not have a Windows instance around to experiment with the changes. But I can take a chance with that. -- This

[GitHub] [couchdb] pgj commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385486336 Oh, and it seems I also did not consider the `--skip-deps` flag either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [couchdb] big-r81 commented on pull request #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
big-r81 commented on PR #4380: URL: https://github.com/apache/couchdb/pull/4380#issuecomment-1385473347 Hi, we should always port changes in configure and Makefile to the windows powershell scripts too… -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [couchdb] StephanU opened a new issue, #4381: CouchDB 3.3.1 for MacOS is missing Spidermonkey

2023-01-17 Thread GitBox
StephanU opened a new issue, #4381: URL: https://github.com/apache/couchdb/issues/4381 [NOTE]: # ( ^^ Provide a general summary of the issue in the title above. ^^ ) ## Description [NOTE]: # ( Describe the problem you're encountering. ) [TIP]: # ( Do NOT give us access or

[GitHub] [couchdb] pgj opened a new pull request, #4380: chore(configure): be more defensive about SpiderMonkey location

2023-01-17 Thread GitBox
pgj opened a new pull request, #4380: URL: https://github.com/apache/couchdb/pull/4380 The `configure` script does not check whether SpiderMonkey actually exists at the presumed location. This may go wrong when the user has a version different from the default one. The mistake is spotted

[GitHub] [couchdb] chiraganand commented on issue #4373: POST _revs_diff request stuck without timing out

2023-01-17 Thread GitBox
chiraganand commented on issue #4373: URL: https://github.com/apache/couchdb/issues/4373#issuecomment-1385324941 > Perhaps we're hitting a limit somewhere - disk usage, CPU, network. What about other requests, just _revs_diffs or do _bulk_docs also do this sometimes? I checked

[GitHub] [couchdb-helm] willholley merged pull request #109: chore: update chart-testing dependencies

2023-01-17 Thread GitBox
willholley merged PR #109: URL: https://github.com/apache/couchdb-helm/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [couchdb] tophe commented on issue #4378: v3.3.1 compaction smoosh config

2023-01-17 Thread GitBox
tophe commented on issue #4378: URL: https://github.com/apache/couchdb/issues/4378#issuecomment-1385202465 so, I have disable the [smoosh.upgrade_dbs] concurrency = 0 don't change anything. then [smoosh.ratio_dbs] concurrency = 0 don't change anything

[GitHub] [couchdb] tophe closed issue #4378: v3.3.1 compaction smoosh config

2023-01-17 Thread GitBox
tophe closed issue #4378: v3.3.1 compaction smoosh config URL: https://github.com/apache/couchdb/issues/4378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [couchdb] pgj opened a new pull request, #4379: docs(mango): match description of `$mod` with reality

2023-01-17 Thread GitBox
pgj opened a new pull request, #4379: URL: https://github.com/apache/couchdb/pull/4379 The remainder argument for the `$mod` operator can be zero, while its documentation suggests otherwise. It actually covers a very realistic use case where divisibility is expressed. [Neither

[GitHub] [couchdb-helm] yekibud commented on a diff in pull request #105: Support existing persistent volume

2023-01-16 Thread GitBox
yekibud commented on code in PR #105: URL: https://github.com/apache/couchdb-helm/pull/105#discussion_r1071513684 ## couchdb/templates/persistentvolumeclaim.yaml: ## @@ -0,0 +1,29 @@ +{{- if and .Values.persistentVolume.enabled .Values.persistentVolume.existing -}}

[GitHub] [couchdb] nickva commented on issue #4378: v3.3.1 compaction smoosh config

2023-01-16 Thread GitBox
nickva commented on issue #4378: URL: https://github.com/apache/couchdb/issues/4378#issuecomment-1384308086 @tophe the reason is likely because of how the default channels were disabled by removing them from the config. As of 3.3 those channel are always present (to allow adding new

  1   2   3   4   5   6   7   8   9   10   >