Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016996626 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] feat:Update FileTest [dubbo]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #13978: URL: https://github.com/apache/dubbo/pull/13978#issuecomment-2017107329 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]

2024-03-24 Thread via GitHub
songxiaosheng merged PR #297: URL: https://github.com/apache/dubbo-spi-extensions/pull/297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix universal buf [dubbo-kubernetes]

2024-03-24 Thread via GitHub
sjmshsh opened a new pull request, #230: URL: https://github.com/apache/dubbo-kubernetes/pull/230 修复了zk节点不存在的bug -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 [dubbo-samples]

2024-03-24 Thread via GitHub
kwings6 closed pull request #1086: Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 URL: https://github.com/apache/dubbo-samples/pull/1086 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2017004041 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Upgrade 3-extensions/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter to jdk17 and springboot3 [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj merged PR #: URL: https://github.com/apache/dubbo-samples/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(dubbo-samples) branch master updated: Upgrade 3-extensions/dubbo-samples-nacos/dubbo-samples-nacos-conditionrouter to jdk17 and springboot3 (#1111)

2024-03-24 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 8f29abbe2 Upgrade

[PR] Fix the triple protocol request failed in the native scenario [dubbo]

2024-03-24 Thread via GitHub
CrazyHZM opened a new pull request, #13984: URL: https://github.com/apache/dubbo/pull/13984 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## Checklist - [x] Make sure there is a

Re: [PR] Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 [dubbo-samples]

2024-03-24 Thread via GitHub
kwings6 commented on code in PR #1086: URL: https://github.com/apache/dubbo-samples/pull/1086#discussion_r1537053964 ## 3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-registry/dubbo-samples-nacos-registry-consumer/pom.xml: ## @@ -0,0 +1,69 @@ + +

Re: [PR] fix universal buf [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #230: URL: https://github.com/apache/dubbo-kubernetes/pull/230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1537001318 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [I] [Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor [dubbo]

2024-03-24 Thread via GitHub
CrazyHZM commented on issue #13959: URL: https://github.com/apache/dubbo/issues/13959#issuecomment-2017156050 > Could you assign it to me? Thanks~ Done. @heliang666s -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016993564 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Task] Some of the sample guidance conforms to business usage [dubbo]

2024-03-24 Thread via GitHub
CrazyHZM commented on issue #13859: URL: https://github.com/apache/dubbo/issues/13859#issuecomment-2017121187 @yuluo-yx Yes, you can refer to other samples that has been completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] feat:Remove zk3.4 support in 3.3 [dubbo]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #13970: URL: https://github.com/apache/dubbo/pull/13970#issuecomment-2017109751 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
walklown commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536997259 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [I] [Feature][3.3] Enhance JsonCompatibilityUtil to support triple protocol [dubbo]

2024-03-24 Thread via GitHub
CrazyHZM commented on issue #13963: URL: https://github.com/apache/dubbo/issues/13963#issuecomment-2017153777 @hengyoush Go ahead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Upgrade to springboot 3.2.3 and dubbo 3.3.0-beta.1 [dubbo-samples]

2024-03-24 Thread via GitHub
kwings6 commented on code in PR #1086: URL: https://github.com/apache/dubbo-samples/pull/1086#discussion_r1537053563 ## 3-extensions/registry/dubbo-samples-nacos/dubbo-samples-nacos-registry/dubbo-samples-nacos-registry-consumer/pom.xml: ## @@ -0,0 +1,69 @@ + +

Re: [PR] merge api files [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #221: URL: https://github.com/apache/dubbo-kubernetes/pull/221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] feat(#220): [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #224: URL: https://github.com/apache/dubbo-kubernetes/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] updated [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj merged PR #1114: URL: https://github.com/apache/dubbo-samples/pull/1114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(dubbo-samples) branch master updated: updated (#1114)

2024-03-24 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 3c2ef69b0 updated (#1114) 3c2ef69b0 is

(dubbo-samples) branch master updated: update apache snapshot repository

2024-03-24 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new d3eab5ef1 update apache snapshot

[PR] validator and mutator [dubbo-kubernetes]

2024-03-24 Thread via GitHub
sjmshsh opened a new pull request, #228: URL: https://github.com/apache/dubbo-kubernetes/pull/228 ## What is the purpose of the change ## Brief changelog ## Verifying this change ## CheckList - [x] Make sure there is a

Re: [PR] feat(filter): move new seata samples into transcation directory [dubbo-go-samples]

2024-03-24 Thread via GitHub
chickenlj merged PR #732: URL: https://github.com/apache/dubbo-go-samples/pull/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016724430 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Upgrade pom and README of module 'dubbo-samples-stub' [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj merged PR #1112: URL: https://github.com/apache/dubbo-samples/pull/1112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] add auddo-wasm/README_zh.md [dubbo-spi-extensions]

2024-03-24 Thread via GitHub
wcy666103 opened a new pull request, #298: URL: https://github.com/apache/dubbo-spi-extensions/pull/298 ## What is the purpose of the change X ## Brief changelog X ## Verifying this change X Follow this checklist to help us incorporate

Re: [PR] into master from 3.2.0-release [dubbo-spi-extensions]

2024-03-24 Thread via GitHub
songxiaosheng commented on code in PR #297: URL: https://github.com/apache/dubbo-spi-extensions/pull/297#discussion_r1536775856 ## dubbo-configcenter-extensions/dubbo-configcenter-etcd/src/test/java/org/apache/dubbo/configcenter/support/etcd/EtcdDynamicConfigurationTest.java:

Re: [PR] add auddo-wasm/README_zh.md [dubbo-spi-extensions]

2024-03-24 Thread via GitHub
codecov-commenter commented on PR #298: URL: https://github.com/apache/dubbo-spi-extensions/pull/298#issuecomment-2016751471 ##

Re: [PR] Upgrade pom and README of module 'dubbo-samples-stub' [dubbo-samples]

2024-03-24 Thread via GitHub
JerryOops commented on PR #1112: URL: https://github.com/apache/dubbo-samples/pull/1112#issuecomment-2016733201 @chickenlj I have did so in the newest commit, please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016734160 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016738545 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016740266 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

(dubbo-samples) branch master updated: Upgrade pom and README of module 'dubbo-samples-stub' (#1112)

2024-03-24 Thread liujun
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new c79de2129 Upgrade pom and README of

Re: [PR] Bump apache parent to 31, jdk to 17 and springboot to 3.2.3 [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj commented on code in PR #1110: URL: https://github.com/apache/dubbo-samples/pull/1110#discussion_r1536772943 ## 1-basic/dubbo-samples-spring-boot-idl/pom.xml: ## @@ -53,6 +53,13 @@ + +org.apache +apache +

Re: [PR] 3.2.0 release [dubbo-spi-extensions]

2024-03-24 Thread via GitHub
songxiaosheng closed pull request #296: 3.2.0 release URL: https://github.com/apache/dubbo-spi-extensions/pull/296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] Dubbo/Triple direct & auto proxy [dubbo-go-pixiu]

2024-03-24 Thread via GitHub
mark4z commented on issue #600: URL: https://github.com/apache/dubbo-go-pixiu/issues/600#issuecomment-2016790311 > 1. 兼容性问题:之前的实现 path 是 `/${appName}/${className}/${method}/${version}` ,新的实现会是 `/${appName}/${className}/${method}`,version 放到 header 里,会和之前的版本不兼容性 > 2.

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016706525 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] feat(filter): move new seata samples into transcation directory [dubbo-go-samples]

2024-03-24 Thread via GitHub
iku50 opened a new pull request, #732: URL: https://github.com/apache/dubbo-go-samples/pull/732 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] 完善k8s模式 [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #227: URL: https://github.com/apache/dubbo-kubernetes/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Feat security [dubbo-go]

2024-03-24 Thread via GitHub
sonarcloud[bot] commented on PR #2643: URL: https://github.com/apache/dubbo-go/pull/2643#issuecomment-2016705327 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] validator and mutator [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #228: URL: https://github.com/apache/dubbo-kubernetes/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] webhook config [dubbo-kubernetes]

2024-03-24 Thread via GitHub
sjmshsh opened a new pull request, #229: URL: https://github.com/apache/dubbo-kubernetes/pull/229 **项目启动** Universal模式 - 本地启动一个zk - make run/dubbo-cp **half模式** - 本地启动一个zk - kubectl apply -f test/control-plane - make run/dubbo-cp **k8s模式** -

Re: [PR] Upgrade pom and README of module 'dubbo-samples-stub' [dubbo-samples]

2024-03-24 Thread via GitHub
chickenlj commented on PR #1112: URL: https://github.com/apache/dubbo-samples/pull/1112#issuecomment-2016726538 Please update `case-versions.cof` by referencing this demo https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-mock/case-versions.conf -- This is an

Re: [PR] webhook config [dubbo-kubernetes]

2024-03-24 Thread via GitHub
chickenlj merged PR #229: URL: https://github.com/apache/dubbo-kubernetes/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [feat]: add new sample multirpc [dubbo-go-samples]

2024-03-24 Thread via GitHub
DMwangnima commented on code in PR #725: URL: https://github.com/apache/dubbo-go-samples/pull/725#discussion_r1536815461 ## multirpc/go-client/cmd/main.go: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

Re: [PR] [feat]: add new sample multirpc [dubbo-go-samples]

2024-03-24 Thread via GitHub
DMwangnima commented on PR #725: URL: https://github.com/apache/dubbo-go-samples/pull/725#issuecomment-2016817390 BTW, you can describe what you did in each commit. Not just "[feat]: add new sample multirpc" since it does not help reviewers or yourself to figure out what this commit did.

[PR] [Feat/ecosystem seata] adding triple sample, adjust non-idl sample [dubbo-go-samples]

2024-03-24 Thread via GitHub
iku50 opened a new pull request, #733: URL: https://github.com/apache/dubbo-go-samples/pull/733 Adjusted the previous sample because it was found that under the new non-idl invocation mode, it cannot be used by the Seata-go proxy (Seata-go's proxy directly uses its methods for invocation).

Re: [I] [Task] Some of the sample guidance conforms to business usage [dubbo]

2024-03-24 Thread via GitHub
yuluo-yx commented on issue #13859: URL: https://github.com/apache/dubbo/issues/13859#issuecomment-2016822795 @AlbumenJ Is embedded-zookeeper being removed here in dubbo-examples? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to