jinmeiliao commented on a change in pull request #5309:
URL: https://github.com/apache/geode/pull/5309#discussion_r446475807
##
File path:
geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
##
@@ -145,9 +145,7 @@ public GfshExecution execute(GfshScr
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r446474804
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##
@@ -113,7 +113,7 @@
public clas
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r446474804
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##
@@ -113,7 +113,7 @@
public clas
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r446474804
##
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##
@@ -113,7 +113,7 @@
public clas
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470963
##
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/VersionOrdinalImpl.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the A
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470857
##
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/internal/AbstractSerializationContext.java
##
@@ -25,10 +26,10 @@
*/
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470545
##
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientSideHandshakeImpl.java
##
@@ -270,7 +271,7 @@ public ServerQueueStatus han
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470594
##
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/VersionOrdinalImpl.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the A
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470589
##
File path:
geode-core/src/main/java/org/apache/geode/internal/HeapDataOutputStream.java
##
@@ -48,7 +49,7 @@
org.apache.geode.internal.serialization.B
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446470516
##
File path:
geode-core/src/integrationTest/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
##
@@ -578,9 +502,6 @@ org/apache/geode/i
dschneider-pivotal commented on a change in pull request #5316:
URL: https://github.com/apache/geode/pull/5316#discussion_r446465548
##
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java
##
@@ -188,6 +188,13 @@ private void
dschneider-pivotal merged pull request #5311:
URL: https://github.com/apache/geode/pull/5311
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dschneider-pivotal commented on pull request #5318:
URL: https://github.com/apache/geode/pull/5318#issuecomment-650466512
Looks like the new HashesAndCrashesDUnitTest needs some work so it can pass
StressNewTest
This is an a
dschneider-pivotal opened a new pull request #5320:
URL: https://github.com/apache/geode/pull/5320
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
kirklund edited a comment on pull request #5309:
URL: https://github.com/apache/geode/pull/5309#issuecomment-650259569
AcceptanceTest job hit a SIGABRT for invalid pointer.
StatusLocatorExitCodeAcceptanceTest also failed.
Th
rhoughton-pivot merged pull request #5319:
URL: https://github.com/apache/geode/pull/5319
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
smgoller opened a new pull request #5319:
URL: https://github.com/apache/geode/pull/5319
Authored-by: Sean Goller
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have bee
lgtm-com[bot] commented on pull request #5318:
URL: https://github.com/apache/geode/pull/5318#issuecomment-650448574
This pull request **introduces 2 alerts** when merging
01d526275c8ea3a6f384e0f8c0c0641393fc6da2 into
f1a2c477f677ccf6b6f80b6bb16946654571f47c - [view on
LGTM.com](https://l
luissson commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446445811
##
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/internal/AbstractSerializationContext.java
##
@@ -25,10 +26,10 @@
jdeppe-pivotal opened a new pull request #5318:
URL: https://github.com/apache/geode/pull/5318
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all
luissson commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446436509
##
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/VersionOrdinalImpl.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to t
dschneider-pivotal merged pull request #5315:
URL: https://github.com/apache/geode/pull/5315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dschneider-pivotal merged pull request #5314:
URL: https://github.com/apache/geode/pull/5314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dschneider-pivotal merged pull request #5307:
URL: https://github.com/apache/geode/pull/5307
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dschneider-pivotal commented on pull request #5314:
URL: https://github.com/apache/geode/pull/5314#issuecomment-650418294
Yes, ping supporting subscribers is a stretch goal for GA and will be done
on its own PR
This is an au
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446354173
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##
@@ -549,7 +550,7 @@ public void setV
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446354173
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##
@@ -549,7 +550,7 @@ public void setV
yozaner1324 opened a new pull request #5317:
URL: https://github.com/apache/geode/pull/5317
…ules' attirbutes to manifest file.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following s
bschuchardt commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446406321
##
File path:
geode-core/src/integrationTest/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
##
@@ -578,9 +502,6 @@ org/apache/
jdeppe-pivotal opened a new pull request #5316:
URL: https://github.com/apache/geode/pull/5316
- Add ability to [P]UNSUBSCRIBE from multiple channels.
- Match Redis semantics when subscribing to empty channel name - (`""`)
- Interact with plain channel names as `byte[]`s instead of `St
dschneider-pivotal opened a new pull request #5315:
URL: https://github.com/apache/geode/pull/5315
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For
dschneider-pivotal opened a new pull request #5314:
URL: https://github.com/apache/geode/pull/5314
Added ping integration tests.
Now if ping is given a parameter it will be returned instead of PONG.
Thank you for submitting a contribution to Apache Geode.
In order to streaml
mivanac merged pull request #5248:
URL: https://github.com/apache/geode/pull/5248
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446356827
##
File path:
geode-core/src/integrationTest/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt
##
@@ -578,9 +502,6 @@ org/apache/geode/i
Bill commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446354173
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/InternalDistributedMember.java
##
@@ -549,7 +550,7 @@ public void setV
mhansonp commented on a change in pull request #5300:
URL: https://github.com/apache/geode/pull/5300#discussion_r446309399
##
File path:
geode-web-management/src/main/java/org/apache/geode/management/internal/rest/controllers/RestoreRedundancyOperationController.java
##
@@ -0,
jdeppe-pivotal merged pull request #5216:
URL: https://github.com/apache/geode/pull/5216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
moleske opened a new pull request #624:
URL: https://github.com/apache/geode-native/pull/624
Authored-by: M. Oleske
Seemed since we merged they enforce no shadow declarations might as well
finish off the rest of shadow fields. Also switched to `_` convention per
style guide for me
smgoller merged pull request #5312:
URL: https://github.com/apache/geode/pull/5312
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
DonalEvans edited a comment on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150
When the attached diff is applied, the modified test
`testPartitionedSerialPropagationHA()` also fails with incorrectly conflated
events. Since this test does not set `g
pivotal-amurmann merged pull request #5308:
URL: https://github.com/apache/geode/pull/5308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DonalEvans edited a comment on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150
When the following diff is applied, the modified test
`testPartitionedSerialPropagationHA()` also fails with incorrectly conflated
events. Since this test does not set `
DonalEvans edited a comment on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
DonalEvans edited a comment on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150
When the following diff is applied, the modified test
`testPartitionedSerialPropagationHA()` also fails with incorrectly conflated
events. Since this test does not set `
DonalEvans commented on pull request #5313:
URL: https://github.com/apache/geode/pull/5313#issuecomment-650264150
When the following diff is applied, the modified test
`testPartitionedSerialPropagationHA()` also fails with incorrectly conflated
events. Since this test does not set `groupTr
kirklund commented on pull request #5309:
URL: https://github.com/apache/geode/pull/5309#issuecomment-650259569
AcceptanceTest job hit a SIGABRT for invalid pointer.
StatusLocatorExitCodeAcceptanceTest also failed -- this PR doesn't change that
test.
-
bschuchardt commented on a change in pull request #5273:
URL: https://github.com/apache/geode/pull/5273#discussion_r446240838
##
File path:
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientSideHandshakeImpl.java
##
@@ -270,7 +271,7 @@ public ServerQueueSta
Bill commented on pull request #5273:
URL: https://github.com/apache/geode/pull/5273#issuecomment-650234882
> Is there any reason for this commented out line to be left here=
@albertogpz for some reason I'm not able to request you as a reviewer.
Thanks for the comments. Keep them com
lgtm-com[bot] commented on pull request #5270:
URL: https://github.com/apache/geode/pull/5270#issuecomment-650218615
This pull request **introduces 9 alerts** and **fixes 2** when merging
f5bd6884b10c1b5b100a678bb6ff1eba4b85ab18 into
c9ed7d7d068cee0b8bb2f626e78a1c0090fad92d - [view on
LGT
bschuchardt merged pull request #5306:
URL: https://github.com/apache/geode/pull/5306
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jinmeiliao commented on pull request #5305:
URL: https://github.com/apache/geode/pull/5305#issuecomment-650199831
I am not sure if merge it here would be the right way to do it. You probably
would trigger some commit checks if you don't add some specific commit message
saying it's cherry p
jmelchio merged pull request #5288:
URL: https://github.com/apache/geode/pull/5288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
albertogpz opened a new pull request #5313:
URL: https://github.com/apache/geode/pull/5313
…saction-events is true
Batch conflation is not compatible with group-transaction-events.
It must be prevented that both are enabled at the same time for
a given gateway sender.
Tha
smgoller opened a new pull request #5312:
URL: https://github.com/apache/geode/pull/5312
Authored-by: Sean Goller
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have bee
54 matches
Mail list logo
