[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-635901434 > Hey @mkevo > Thanks for working on this, I'll start the review once all `CI` tests are green. > Cheers. It looks that last five opened PRs failed on LGTM check.

[GitHub] [geode] jvarenina opened a new pull request #5182: GEODE-7591: Fix for hang in ClusterDistributionManager

jvarenina opened a new pull request #5182: URL: https://github.com/apache/geode/pull/5182 Added timeout after which it will be periodically checked whether distribution manager is disconnecting while waiting on the membership view installation to avoid hanging Thank you for

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-635849316 Hey @mkevo Thanks for working on this, I'll start the review once all `CI` tests are green. Cheers.

[GitHub] [geode] jdeppe-pivotal merged pull request #5180: GEODE-8199: optimize ByteArrayWrapper serialization and memory usage

jdeppe-pivotal merged pull request #5180: URL: https://github.com/apache/geode/pull/5180 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal merged pull request #5181: GEODE-8201: change internal redis region name to start with double underscore

jdeppe-pivotal merged pull request #5181: URL: https://github.com/apache/geode/pull/5181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal merged pull request #5179: GEODE-8127: Reintroduces changes that account for primary bucket changing

jdeppe-pivotal merged pull request #5179: URL: https://github.com/apache/geode/pull/5179 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] alb3rtobr commented on pull request #5178: GEODE-8179: gfsh query cmd returns incorrect results if '=' sign is missing

alb3rtobr commented on pull request #5178: URL: https://github.com/apache/geode/pull/5178#issuecomment-635962850 Im going to close this PR by the moment, I want to check the code again. I tested with a simple spring-shell 1.2.0 app trying to confirm the problem exists there, but I saw

[GitHub] [geode] alb3rtobr closed pull request #5178: GEODE-8179: gfsh query cmd returns incorrect results if '=' sign is missing

alb3rtobr closed pull request #5178: URL: https://github.com/apache/geode/pull/5178 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jhuynh1 opened a new pull request #5183: GEODE-8203: Provide ability to prevent disabling geode console appender

jhuynh1 opened a new pull request #5183: URL: https://github.com/apache/geode/pull/5183 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] kirklund merged pull request #5162: GEODE-6070: Fix ShutdownCommandOverHttpDUnitTest flakiness

kirklund merged pull request #5162: URL: https://github.com/apache/geode/pull/5162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] dschneider-pivotal opened a new pull request #5184: change more string commands to have CommandFunction support

dschneider-pivotal opened a new pull request #5184: URL: https://github.com/apache/geode/pull/5184 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] nabarunnag commented on a change in pull request #5183: GEODE-8203: Provide ability to prevent disabling geode console appender

nabarunnag commented on a change in pull request #5183: URL: https://github.com/apache/geode/pull/5183#discussion_r432687453 ## File path: geode-core/src/main/java/org/apache/geode/logging/internal/LoggingSession.java ## @@ -34,6 +35,9 @@ */ public class LoggingSession

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757866 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/SupportedCommandsJUnitTest.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757514 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java ## @@ -107,132 +107,161 @@ */ public enum

[GitHub] [geode] jinmeiliao opened a new pull request #5188: GEODE-8099: add dlock around cms create/delete operations.

jinmeiliao opened a new pull request #5188: URL: https://github.com/apache/geode/pull/5188 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] alb3rtobr opened a new pull request #5187: GEODE-8179: gfsh query cmd returns incorrect results if '=' sign is missing

alb3rtobr opened a new pull request #5187: URL: https://github.com/apache/geode/pull/5187 When parsing the user input in gfsh, the first `=` character position was used to split strings which were expected to follow the pattern `--parameter=value`. But if the `=` sign is not introduced,

[GitHub] [geode] echobravopapa opened a new pull request #5186: GEODE-8195: Remove code removing entries during iteration

echobravopapa opened a new pull request #5186: URL: https://github.com/apache/geode/pull/5186 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5159: GEODE-7956: correct legal region names

dschneider-pivotal commented on a change in pull request #5159: URL: https://github.com/apache/geode/pull/5159#discussion_r432739787 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java ## @@ -24,7 +24,7 @@ public class

[GitHub] [geode] jchen21 opened a new pull request #5189: GEODE-7669 Test coverage for Partitioned Region clear with Overflow enabled

jchen21 opened a new pull request #5189: URL: https://github.com/apache/geode/pull/5189 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

dschneider-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432720582 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java ## @@ -107,132 +107,161 @@ */ public enum

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5159: GEODE-7956: correct legal region names

dschneider-pivotal commented on a change in pull request #5159: URL: https://github.com/apache/geode/pull/5159#discussion_r432741553 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/RegionNameValidation.java ## @@ -24,7 +24,7 @@ public class

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757057 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/ExecutionHandlerContext.java ## @@ -196,22 +197,26 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757343 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java ## @@ -107,132 +107,161 @@ */ public enum

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757184 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java ## @@ -107,132 +107,161 @@ */ public enum

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5185: GEODE-8205: Feature flag unsupported Redis commands

jdeppe-pivotal commented on a change in pull request #5185: URL: https://github.com/apache/geode/pull/5185#discussion_r432757239 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java ## @@ -107,132 +107,161 @@ */ public enum

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5185: Hide unsupported commands behind flag

jdeppe-pivotal opened a new pull request #5185: URL: https://github.com/apache/geode/pull/5185 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For