[GitHub] [geode] onichols-pivotal edited a comment on pull request #5018: GEODE-8039: update incorrect versions in LICENSE

onichols-pivotal edited a comment on pull request #5018: URL: https://github.com/apache/geode/pull/5018#issuecomment-620951680 It seems that anything we distribute that is licensed under Apache 2.0 License does not need to be called out. However, I found 3 jars that will be in the 1.13 re

[GitHub] [geode] onichols-pivotal commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE

onichols-pivotal commented on pull request #5018: URL: https://github.com/apache/geode/pull/5018#issuecomment-620951680 It seems that anything we distribute that is licensed under Apache 2.0 License does not need to be called out. However, I found 3 jars that will be in the 1.13 release t

[GitHub] [geode] onichols-pivotal opened a new pull request #5018: GEODE-8039: update incorrect versions in LICENSE

onichols-pivotal opened a new pull request #5018: URL: https://github.com/apache/geode/pull/5018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [geode] karensmolermiller opened a new pull request #5017: GEODE-8038: Fix product name in docs

karensmolermiller opened a new pull request #5017: URL: https://github.com/apache/geode/pull/5017 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [geode] onichols-pivotal commented on pull request #4234: GEODE-6636: Create multiple buffer pools

onichols-pivotal commented on pull request #4234: URL: https://github.com/apache/geode/pull/4234#issuecomment-620900280 Here's a summary of the benchmark results from the above run (positive number = improvement) -3.6% Benchmark_base PartitionedFunctionExecutionBenchmark +2.1% Benchma

[GitHub] [geode] kirklund commented on pull request #5011: GEODE-8032: Fix unit test and reclassify some tests as integration tests

kirklund commented on pull request #5011: URL: https://github.com/apache/geode/pull/5011#issuecomment-620894692 Tomcat session tests are still failing in UpgradeTestOpen. This is an automated message from the Apache Git Servi

[GitHub] [geode] onichols-pivotal commented on pull request #4978: Fix for regression introduced by GEODE-7565

onichols-pivotal commented on pull request #4978: URL: https://github.com/apache/geode/pull/4978#issuecomment-620893200 looks like this PR needs to be rebased to latest develop to fix merge confict with DataSerializableFixedID.java, until then PR checks cannot run. ---

[GitHub] [geode] gesterzhou commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

gesterzhou commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r416956303 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java ## @@ -521,12 +521,12 @@ void create(InternalCache ca

[GitHub] [geode] gesterzhou commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

gesterzhou commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r416954212 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java ## @@ -10373,4 +10377,27 @@ void updatePartitionRegionConf

[GitHub] [geode] jhutchison opened a new pull request #5016: Feature parity redis srem command

jhutchison opened a new pull request #5016: URL: https://github.com/apache/geode/pull/5016 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all cha

[GitHub] [geode] prettyClouds opened a new pull request #5015: GEODE-8036: Close Zombie TCP Client Connections

prettyClouds opened a new pull request #5015: URL: https://github.com/apache/geode/pull/5015 Use KEEPALIVE settings to close TCP connections Follow Netty's Asynchronous pattern to write to the channel Thank you for submitting a contribution to Apache Geode. In order t

[GitHub] [geode] DonalEvans commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

DonalEvans commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r416931125 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreFactoryImpl.java ## @@ -144,7 +144,10 @@ public DiskStore create(String

[GitHub] [geode] DonalEvans commented on a change in pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

DonalEvans commented on a change in pull request #5014: URL: https://github.com/apache/geode/pull/5014#discussion_r416930455 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheCreation.java ## @@ -521,12 +521,12 @@ void create(InternalCache ca

[GitHub] [geode-native] davebarnes97 opened a new pull request #595: .NET client user guide: Update Pdx Serialization and autoserialization

davebarnes97 opened a new pull request #595: URL: https://github.com/apache/geode-native/pull/595 .NET client - rewrite Serialization to show IPdx serialization and ReflectionBasedAutoSerializer as the opinionated happy path for .NET clients. --

[GitHub] [geode] jchen21 opened a new pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts

jchen21 opened a new pull request #5014: URL: https://github.com/apache/geode/pull/5014 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all change

[GitHub] [geode] boglesby commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r416901247 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -1282,22 +1277,90 @@ public List

[GitHub] [geode] boglesby commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r416898601 ## File path: geode-core/src/main/resources/org/apache/geode/cache/doc-files/cache8_0.dtd ## @@ -675,6 +675,7 @@ As of 6.5 roll-oplogs is deprecated. Use

[GitHub] [geode] boglesby commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620813007 When I start site 2, I see 3 batches received: ``` ServerConnection on port 5185 Thread 1: GatewayReceiverCommand.cmdExecute received batch 0 containing 5 events ServerCo

[GitHub] [geode] boglesby commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620812923 The next peeked batch doesn't contain 11 events. It only contains 5. This is because the previous batch failed to be sent which causes addPeekedEvents to actually do something. I

[GitHub] [geode] boglesby commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620812755 Here are the details. The first batch has the 11 events. 5 events are peeked initially: ``` Event Processor for GatewaySender_ny_3: ParallelGatewaySenderQueue.p

[GitHub] [geode] boglesby commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

boglesby commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620812494 If I do this: - start site 1 with a sender with batch size = 5 - do a transaction with 1 customer and 10 orders - don't start site 2 immediately I see behavior

[GitHub] [geode] sabbeyPivotal opened a new pull request #5013: GEODE-8034: Create distributed tests for SREM command

sabbeyPivotal opened a new pull request #5013: URL: https://github.com/apache/geode/pull/5013 SREM (https://redis.io/commands/srem) removes members from a set. We created distributed tests to ensure SREM can happen concurrently on multiple servers. --

[GitHub] [geode] DonalEvans commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

DonalEvans commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r416766676 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/ReplicateCacheListenerDistributedTest.java ## @@ -302,4 +349,64 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

gesterzhou commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r416827787 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache S

[GitHub] [geode] gesterzhou commented on a change in pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.

gesterzhou commented on a change in pull request #4987: URL: https://github.com/apache/geode/pull/4987#discussion_r416821768 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/ClearPartitionedRegion.java ## @@ -0,0 +1,342 @@ +/* + * Licensed to the Apache S

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

pivotal-jbarrett commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r416772000 ## File path: cppcache/test/QueueConnectionRequestTest.cpp ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

pivotal-jbarrett commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r416771316 ## File path: cppcache/src/QueueConnectionRequest.cpp ## @@ -28,10 +28,10 @@ void QueueConnectionRequest::toData(DataOutput& output) const {

[GitHub] [geode] alb3rtobr commented on pull request #4978: Fix for regression introduced by GEODE-7565

alb3rtobr commented on pull request #4978: URL: https://github.com/apache/geode/pull/4978#issuecomment-620729123 > I've added a small `DistributedTest` to my [branch](https://github.com/apache/geode/pull/4990/files#diff-b478e9ee8bbd7e0de69c1bac78ee0db2), you can use it as the starting poin

[GitHub] [geode] kirklund commented on pull request #4963: GEODE-7503: Block Cache.close() until everything is disconnected

kirklund commented on pull request #4963: URL: https://github.com/apache/geode/pull/4963#issuecomment-620709035 I'm currently running a lot of manual tests against this change (ie hydra tests). This is an automated message f

[GitHub] [geode] kirklund commented on pull request #5011: GEODE-8032: Fix unit test and reclassify some tests as integration tests

kirklund commented on pull request #5011: URL: https://github.com/apache/geode/pull/5011#issuecomment-620702140 Tomcat session tests failed in UpgradeTestOpen. Unrelated to this PR. This is an automated message from the Apach

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416633437 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/GeodeRedisHashSynchronized.java ## @@ -89,6 +89,11 @@ public in

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416602742 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/GeodeRedisSetSynchronized.java ## @@ -59,8 +60,19 @@ public long

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5009: Deltas

dschneider-pivotal commented on a change in pull request #5009: URL: https://github.com/apache/geode/pull/5009#discussion_r416719855 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/DeltaSet.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5009: Deltas

dschneider-pivotal commented on a change in pull request #5009: URL: https://github.com/apache/geode/pull/5009#discussion_r416713302 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/SaddFunction.java ## @@ -0,0 +1,54 @@ +/* + * Licensed to t

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416633437 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/hash/GeodeRedisHashSynchronized.java ## @@ -89,6 +89,11 @@ public in

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416632847 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/GeodeRedisSetSynchronized.java ## @@ -59,8 +60,19 @@ public long

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416602742 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/GeodeRedisSetSynchronized.java ## @@ -59,8 +60,19 @@ public long

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #4989: GEODE 8014: Sets and Hashes should be deleted once they are empty

sabbeyPivotal commented on a change in pull request #4989: URL: https://github.com/apache/geode/pull/4989#discussion_r416598548 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/GeodeRedisSetSynchronized.java ## @@ -59,8 +60,19 @@ public long

[GitHub] [geode] prettyClouds commented on a change in pull request #5009: Deltas

prettyClouds commented on a change in pull request #5009: URL: https://github.com/apache/geode/pull/5009#discussion_r416573027 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/set/DeltaSet.java ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache

[GitHub] [geode] jujoramos commented on a change in pull request #4990: [DO NOT REVIEW]

jujoramos commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416534712 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ## @@ -0,0 +1,219 @@ +/* + * Li

[GitHub] [geode] alb3rtobr commented on a change in pull request #4990: [DO NOT REVIEW]

alb3rtobr commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416533519 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ## @@ -0,0 +1,219 @@ +/* + * Li

[GitHub] [geode] alb3rtobr commented on a change in pull request #4990: [DO NOT REVIEW]

alb3rtobr commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416533519 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ## @@ -0,0 +1,219 @@ +/* + * Li

[GitHub] [geode-native] jvarenina commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

jvarenina commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r416532403 ## File path: cppcache/test/QueueConnectionRequestTest.cpp ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [geode-native] jvarenina commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

jvarenina commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r416531456 ## File path: cppcache/src/QueueConnectionRequest.cpp ## @@ -28,10 +28,10 @@ void QueueConnectionRequest::toData(DataOutput& output) const { outp

[GitHub] [geode-native] jvarenina commented on a change in pull request #593: GEODE-7944: Fix for QueueConnectionRequest message

jvarenina commented on a change in pull request #593: URL: https://github.com/apache/geode-native/pull/593#discussion_r416530594 ## File path: cppcache/src/QueueConnectionRequest.cpp ## @@ -28,10 +28,10 @@ void QueueConnectionRequest::toData(DataOutput& output) const { outp

[GitHub] [geode] albertogpz edited a comment on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz edited a comment on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620529529 Thanks for your comments. Please, see below: > I ran a test with this scenario: > > * 2 colocated partitioned regions called customer and order attached

[GitHub] [geode] jujoramos commented on a change in pull request #4990: [DO NOT REVIEW]

jujoramos commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416517816 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ## @@ -0,0 +1,219 @@ +/* + * Li

[GitHub] [geode] albertogpz commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-620529529 Thanks for your comments. Please, see below: > I ran a test with this scenario: > > * 2 colocated partitioned regions called customer and order attached to a pa

[GitHub] [geode] alb3rtobr commented on a change in pull request #4990: [DO NOT REVIEW]

alb3rtobr commented on a change in pull request #4990: URL: https://github.com/apache/geode/pull/4990#discussion_r416513148 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/tier/sockets/PingOpDistributedTest.java ## @@ -0,0 +1,219 @@ +/* + * Li

[GitHub] [geode-native] lgtm-com[bot] commented on pull request #594: GEODE-2484: Removes ACE_Token

lgtm-com[bot] commented on pull request #594: URL: https://github.com/apache/geode-native/pull/594#issuecomment-620438196 This pull request **fixes 1 alert** when merging 537a2f0245f0209ed950e1c8d92658494a426c42 into 8be5d4076188b44fdbb788b830d1af77da9fac29 - [view on LGTM.com](https://lg