[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423014670 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -1282,22 +1278,89 @@ public Li

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423011955 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -709,7 +719,10 @@ public static void create

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423011534 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -519,7 +521,9 @@ public static void createR

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423011450 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -497,7 +498,8 @@ public static void createPe

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423010749 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java ## @@ -299,19 +312,316 @@ p

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r423010939 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java ## @@ -503,17 +815,16 @@ pu

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422994223 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANStatsDUnitTest.java ## @@ -299,19 +312,316 @@ p

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422886472 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -373,7 +373,8 @@ public static Integer creat

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422882651 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java ## @@ -862,14 +868,14 @@ private voi

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422867687 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/TXLastEventInTransactionUtils.java ## @@ -0,0 +1,120 @@ +/* + * Licensed to the A

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422866672 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/InternalRegion.java ## @@ -307,6 +307,11 @@ void cacheWriteBeforePut(EntryEventIm

[GitHub] [geode] mivanac commented on pull request #5040: GEODE-7414_2: modify init() method argument

mivanac commented on pull request #5040: URL: https://github.com/apache/geode/pull/5040#issuecomment-626542919 Hi, could you help me how to bypass this API check, since origin class is not marked @Experimental. This is an au

[GitHub] [geode] albertogpz commented on a change in pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on a change in pull request #4928: URL: https://github.com/apache/geode/pull/4928#discussion_r422851648 ## File path: geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java ## @@ -153,6 +155,13 @@ .getInteger(GeodeGlossary.GEMFIRE_PR

[GitHub] [geode] albertogpz commented on pull request #4928: GEODE-7971: Gw sender deliver TX events atomically to Gw receivers

albertogpz commented on pull request #4928: URL: https://github.com/apache/geode/pull/4928#issuecomment-626524327 > Methods named `isGroupTransactionEvents` might be better named `shouldGroupTransactionEvents`. Similarly, fields/variables named `isGroupTransactionEvents` might be better na