[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list, sorted set, and hyperLog commands and code

lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632493771 This pull request **fixes 1 alert** when merging c0476d31b3bae585f747d4a42256369e2829926b into 358fd7067cc56b1ceb8c3d7c271c3a5254d7ee93 - [view on

[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list and sorted set commands and code

lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632442249 This pull request **fixes 1 alert** when merging 7796d04e1e54b0360c74fa47071735dfc6e260b0 into 358fd7067cc56b1ceb8c3d7c271c3a5254d7ee93 - [view on

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

pivotal-jbarrett commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r429007050 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1943,6 +1931,36 @@ * Default: ""

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5131: GEODE-8144: endpoint identification in servers is not working

pivotal-jbarrett commented on a change in pull request #5131: URL: https://github.com/apache/geode/pull/5131#discussion_r429004979 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ## @@ -791,7 +792,19 @@ private boolean

[GitHub] [geode] lgtm-com[bot] commented on pull request #5146: removed list and sorted set commands and code

lgtm-com[bot] commented on pull request #5146: URL: https://github.com/apache/geode/pull/5146#issuecomment-632418350 This pull request **fixes 1 alert** when merging 95a9d7538a784420f2d27e94c03bbc866a64b28c into 358fd7067cc56b1ceb8c3d7c271c3a5254d7ee93 - [view on

[GitHub] [geode] agingade commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

agingade commented on a change in pull request #5147: URL: https://github.com/apache/geode/pull/5147#discussion_r428981578 ## File path: geode-core/src/main/java/org/apache/geode/cache/Region.java ## @@ -1359,10 +1359,30 @@ Object selectValue(String queryPredicate) throws

[GitHub] [geode] gesterzhou opened a new pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

gesterzhou opened a new pull request #5147: URL: https://github.com/apache/geode/pull/5147 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal opened a new pull request #5146: removed list and sorted set commands and code

dschneider-pivotal opened a new pull request #5146: URL: https://github.com/apache/geode/pull/5146 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] dschneider-pivotal commented on pull request #5133: GEODE-8127: ensure that function executes on primary

dschneider-pivotal commented on pull request #5133: URL: https://github.com/apache/geode/pull/5133#issuecomment-632360192 the UpgradeTestOpenJDK11 timeout is unrelated to this PR. This is an automated message from the Apache

[GitHub] [geode-native] pdxcodemonkey merged pull request #601: GEODE-2484: Replaces ACE_TSS with C++11 thread_local.

pdxcodemonkey merged pull request #601: URL: https://github.com/apache/geode-native/pull/601 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] bschuchardt merged pull request #5132: GEODE-8131: reader thread blocked attempting to issue an alert

bschuchardt merged pull request #5132: URL: https://github.com/apache/geode/pull/5132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] pdxcodemonkey merged pull request #594: GEODE-2484: Removes ACE_Token

pdxcodemonkey merged pull request #594: URL: https://github.com/apache/geode-native/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] rhoughton-pivot merged pull request #5134: GEODE-8146: use latest winrm in tools image

rhoughton-pivot merged pull request #5134: URL: https://github.com/apache/geode/pull/5134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] rhoughton-pivot commented on pull request #4969: GEODE-7995: Creates concurrencyTest facet

rhoughton-pivot commented on pull request #4969: URL: https://github.com/apache/geode/pull/4969#issuecomment-632317913 @pivotal-jbarrett Want to pair on reviving this PR? This is an automated message from the Apache Git

[GitHub] [geode] dschneider-pivotal merged pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html

dschneider-pivotal merged pull request #5130: URL: https://github.com/apache/geode/pull/5130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbeyPivotal commented on pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html

sabbeyPivotal commented on pull request #5130: URL: https://github.com/apache/geode/pull/5130#issuecomment-632296428 This DUnit failure is a known issue: https://issues.apache.org/jira/browse/GEODE-6222 This is an automated

[GitHub] [geode] dschneider-pivotal merged pull request #5125: GEODE-8170: Change all hash and set commands to use function+delta

dschneider-pivotal merged pull request #5125: URL: https://github.com/apache/geode/pull/5125 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] lgtm-com[bot] commented on pull request #5143: GEODE-8148 - Implement unloadModule.

lgtm-com[bot] commented on pull request #5143: URL: https://github.com/apache/geode/pull/5143#issuecomment-632270684 This pull request **introduces 1 alert** and **fixes 1** when merging fb260ca6d6e0a25184cac31c71e696713d2f9318 into e04a789a51c60394e6feece070e1f28afe1767b0 - [view on

[GitHub] [geode] lgtm-com[bot] commented on pull request #5136: GEODE-8137 - Implement loadService.

lgtm-com[bot] commented on pull request #5136: URL: https://github.com/apache/geode/pull/5136#issuecomment-632233792 This pull request **introduces 1 alert** and **fixes 1** when merging 7d66148d8942bf0db9bd4253a0c5e9f9efe6bceb into e04a789a51c60394e6feece070e1f28afe1767b0 - [view on

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html

sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428790389 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -33,24 +33,26 @@ commands. Use gfsh to start at least one server with a

[GitHub] [geode] lgtm-com[bot] commented on pull request #5145: GEODE-8168: Redis pipelined command responses can be corrupted

lgtm-com[bot] commented on pull request #5145: URL: https://github.com/apache/geode/pull/5145#issuecomment-63963 This pull request **introduces 1 alert** when merging 88207102901c01f9ece3f771ecaf8eb6288d790e into 07bf3dd827f29a5deb8619f79203d94847a1a823 - [view on

[GitHub] [geode] DonalEvans closed pull request #5127: GEODE-8141: Move region separator definition to geode-common module and replace uses of hardcoded /

DonalEvans closed pull request #5127: URL: https://github.com/apache/geode/pull/5127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt commented on a change in pull request #5132: GEODE-8131: reader thread blocked attempting to issue an alert

bschuchardt commented on a change in pull request #5132: URL: https://github.com/apache/geode/pull/5132#discussion_r428776911 ## File path: geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java ## @@ -3027,13 +3027,17 @@ private void readMessage(ByteBuffer

[GitHub] [geode] yozaner1324 commented on a change in pull request #5136: GEODE-8137 - Implement loadService.

yozaner1324 commented on a change in pull request #5136: URL: https://github.com/apache/geode/pull/5136#discussion_r428772188 ## File path: geode-modules/src/main/java/org/apache/geode/services/module/impl/JBossModuleService.java ## @@ -92,18 +98,20 @@ public boolean

[GitHub] [geode] yozaner1324 commented on a change in pull request #5136: GEODE-8137 - Implement loadService.

yozaner1324 commented on a change in pull request #5136: URL: https://github.com/apache/geode/pull/5136#discussion_r428772297 ## File path: geode-modules/src/main/java/org/apache/geode/services/module/impl/JBossModuleService.java ## @@ -92,18 +98,20 @@ public boolean

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html

pivotal-jbarrett commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428768805 ## File path: geode-docs/tools_modules/redis_api_for_geode.html.md.erb ## @@ -33,24 +33,26 @@ commands. Use gfsh to start at least one server

[GitHub] [geode] pivotal-eshu merged pull request #5102: GEODE-8112: Add --member option in query command.

pivotal-eshu merged pull request #5102: URL: https://github.com/apache/geode/pull/5102 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt commented on pull request #5131: GEODE-8144: endpoint identification in servers is not working

bschuchardt commented on pull request #5131: URL: https://github.com/apache/geode/pull/5131#issuecomment-632166879 The locator setting is inserted in `InternalLocator.startDistributedSystem()` ``` private void startDistributedSystem() throws IOException {

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5145: GEODE-8168: Redis pipelined command responses can be corrupted

jdeppe-pivotal opened a new pull request #5145: URL: https://github.com/apache/geode/pull/5145 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jujoramos merged pull request #5138: GEODE-8150: Downgrade classgraph to 4.8.52

jujoramos merged pull request #5138: URL: https://github.com/apache/geode/pull/5138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428653882 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java ## @@ -301,6 +301,13 @@ ResultModel

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428640516 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java ## @@ -275,7 +275,8 @@ public GeodeRedisServer(String

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428639899 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java ## @@ -241,7 +241,7 @@ private int

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428637710 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java ## @@ -301,6 +301,13 @@ ResultModel

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428635821 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java ## @@ -2557,14 +2557,14 @@ "The

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428632736 ## File path: geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java ## @@ -1312,11 +1313,13 @@ static Class

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5130: GEODE-8145: Add Redis configuration properties to gemfire_properties.html

sabbeyPivotal commented on a change in pull request #5130: URL: https://github.com/apache/geode/pull/5130#discussion_r428631488 ## File path: geode-docs/reference/topics/gemfire_properties.html.md.erb ## @@ -488,26 +488,31 @@ off-heap-memory-size=120g redis-bind-address

[GitHub] [geode] jujoramos commented on pull request #5138: GEODE-8150: Downgrade classgraph to 4.8.61

jujoramos commented on pull request #5138: URL: https://github.com/apache/geode/pull/5138#issuecomment-632028556 The `AcceptanceTestOpenJDK11` is failing with `java.lang.OutOfMemoryError` and, after looking at the heap dump taken during the failure, it looks like the biggest objects

[GitHub] [geode] mkevo merged pull request #5106: GEODE-8119:closing threads when offline disk store is executed

mkevo merged pull request #5106: URL: https://github.com/apache/geode/pull/5106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mivanac merged pull request #4387: GEODE-7458: Adding option in gfsh command "start gateway sender" to control clearing of existing queues

mivanac merged pull request #4387: URL: https://github.com/apache/geode/pull/4387 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to