I don't see any double newlines
[ Full content available at: https://github.com/apache/geode/pull/2509 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2509 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This removes the LocalizedStrings class and most uses of LogWriterI18n.
The I18n interfaces are still in place and still work since they're only
deprecated but there are no longer any uses of the StringID logging methods.
Thank you for submitting a contribution to Apache Geode.
In order to stream
> > "saved in queue" -> "save in a queue"
> This one is actually just right out of our manual so I think the same fix
> needs to go there.
Yes, thanks for the pointer.
> > "A simple cache listener is used to print output to terminal create events
> > are received" -> "output to the terminal as
This most recent commit is acknowledged as overkill. I just want to confirm or
deny whether or not there would be any `*core:test` failures with resources
moved this way. This is more to expose any other possible failures than I
necessarily believe this is where all these resources belong.
[
Thanks for clarifying @davebarnes97! Appreciate the feedback.
[ Full content available at: https://github.com/apache/geode-examples/pull/69 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Done.
The CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION property can't be used for the
*.csproj.in projects in tests/cli. We created a new ticket
(https://issues.apache.org/jira/browse/GEODE-5818) finish porting those to
cmake. For now, those projects use the DOTNE_TARGET_FRAMEWORK_VERSION.
[ Full con
Done. Except for the projects that aren't ported to cmake yet.
[ Full content available at: https://github.com/apache/geode-native/pull/365 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Signed-off-by: Kirk Lund
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
c
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Moved SocketCloser tests to integration tests
* Renamed SocketCloserJUnitTest to SockerCloserIntegrationTest
* Renamed SocketCloserWithWaitJUnitTest to SocketCloserWithWaitIntegrationTest
* Removed an unused private deprecated method from SocketCloser
Signed-off-by: Sai Boorlagadda
Thank y
Signed-off-by: Kirk Lund
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
c
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2491 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Co-authored-by: Patrick Rhomberg
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced i
Co-authored-by: Patrick Rhomberg
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced i
[ Full content available at: https://github.com/apache/geode-native/pull/367 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We were downloading full installs of tomcat and jetty on every test run.
This occasionally resulted in test failures if the download site was
down. Now we get this installs as gradle dependencies, which will be
cached.
Thank you for submitting a contribution to Apache Geode.
In order to streamlin
16bit?
[ Full content available at: https://github.com/apache/geode-native/pull/366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Add `updateExpectedPom` task to perform copy of actual to expected.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket as
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2566 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Uses static_cast<> over C-style cast.
* Fixes ACE thread id to string.
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@echobravopapa Please re-review.
[ Full content available at: https://github.com/apache/geode-native/pull/366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2570 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
For consistency, these versions should make sure of the project properties
present in `dependency-versions.properties`, e.g.,
```
webServerJetty group: 'org.eclipse.jetty', name: 'jetty-distribution',
version: project.'jetty.version', ext: 'zip'
```
I note that neither of these Tomcat7 version
* Always send CommitProcessQueryMessage to other replicates to see if anyone
received second
message as transaction originator for client transaction will be different
from transaction host.
* Do not wait for transaction originator to depart when processing
CommitProcessQueryMessage if
The way you have this designed every region has its own tombstone service. I
think we wanted most regions to share a service (like they currently do) and
only have the lucene regions have their own. It would be best if this could be
done when the region is created instead of after it is created.
what does using overflow to disk have to do with per region tombstone sweepers?
This should be a seperate checkin
[ Full content available at: https://github.com/apache/geode/pull/2552 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think you want to add this to basicRegionDestroy instead of close.
If you destroy OR close a region you would want to cleanup its tombstone
sweeper.
[ Full content available at: https://github.com/apache/geode/pull/2552 ]
This message was relayed via gitbox.apache.org for
notifications@geode.
If possible redesign so these could be "final" again. This would require you to
know the tombstone timeout when you create a per region sweeper.
If this is not possible then rename these to not be all caps which is reserved
for final constants. Since they were being set in the constructor they a
I can see why you might need a collection of all the ReplicateTimbstoneSweeper
instances in this class. But I don't think you need to have a reference to
every Region instance. If a region has its own ReplicateTombstoneSweeper
couldn't the region keep a reference to it so that it does not need t
If you keep this, allowing these variables to be changed after the constructor,
then change the constructor to calll this method instead of duplicating the
code that computes PURGE_INTERVAL.
[ Full content available at: https://github.com/apache/geode/pull/2552 ]
This message was relayed via git
minor nit: method names should start with a lower-case character. Upper case
should be reserved for Class/Interface names
[ Full content available at: https://github.com/apache/geode/pull/2552 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I don't like that this code passes in a Region and then you ask that region for
a bunch of other components.
Instead you should make clear what you need when creating a
ReplicateTombstoneSweeper for a region.
It looks like you need InternalCache, CachePerfStats, CancelCriterion, and an
ExecutorS
instead of "getDm()" use the parameter "distributionManager"
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
simplify to: return null != message && message.isProcessing();
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
rename "getDm" to "getDistributionManager"
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What class is this method "doCommitProcessQuery" on? I think it is
TXCommitMessage.
So no need for this funny business of "TXCommitMessage.this" which was needed
before because is was in an anonymous inner class.
Now everywhere you have "message" you can just have "this".
I already did this refac
You are right that it is no longer in inner class. Cleaned up the code.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Remove GUID
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The project GUID should not be in here as each time the project is generated
the GUID will change.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Remove GUID
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is line should be deleted.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2565 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is a partial conversion to using `CMAKE_DOTNET_TARGET_FRAMEWORK_VERSION` ,
there are some remaining csproj.in files belonging to `cli` test framework that
will be addressed in https://issues.apache.org/jira/browse/GEODE-5818 until
then we need both
[ Full content available at: https://git
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pivotal-jbarrett how's this look now?
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think the old code was better that passed along the "dm" parameter.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
it would be better to just use the "distributionManager" parameter. At some
point we may find that this class no longer needs to keep a reference to the dm
in an instance field.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.or
txTracker.commitProcessReceived method no longer need distribution manager
anymore.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Will address this concern with additional dunit test.
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Do we really need to add this whitespace here and the next file. If not then
these two files would have no changes.
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/369 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-eshu ]
[ Full content available at: https://github.com/apache/geode/pull/2571 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/366 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We have a lot of Awaitility calls in our tests. Each test was picking
its own timeout. That lead to some tests picking too small of a timeout
and failing spuriously.
With this change, all tests will use a new factory,
GeodeAwaility.await(), rather than Awaitility.await(). This new factory
sets a d
[ pull request closed by jchen21 ]
[ Full content available at: https://github.com/apache/geode/pull/2556 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why does the expected file need to exist in order to update/place. We could use
this task to generate the baseline for a newly-minted module.
[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dschneider-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2535 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I suppose it doesn't!
[ Full content available at: https://github.com/apache/geode/pull/2569 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is divided up into smaller commits:
GEODE-2644: Add LogWriterLevel enum and test
GEODE-2644: Cleanup LogLevel and expand LogLevelTest
GEODE-2644: Cleanup custom log4j2 config logging tests
GEODE-2644: Cleanup Marker Filter logging tests
GEODE-2644: Cleanup logging tests
GEODE-2644: Cleanup Al
… SAN in the certificate
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
co
This branch started out as work on unit test coverage for RegionMapDestroy.
That test coverage has been checked in with a different pull request.
This pull request has the refactoring that was done while writing the unit
tests.
Thank you for submitting a contribution to Apache Geode.
In order to
I had been poking at it to make sure it's still good. I was getting some
strange behavior where `./gradlew uEP` updates the assembly pom with
```
diff --git a/geode-assembly/src/test/resources/expected-pom.xml
b/geode-assembly/src/test/resources/expected-pom.xml
index 3f8abf5e57..b22bc8f393 1006
It seems like the actual `checkPom` task is only examining ``
blocks and not any other data. So, on the one hand, the existing behavior was
"copy the actual pom to the expected pom" is what's happening, but a developer
will then need to examine which difference should actually be added to their
we can change it to java 9+
[ Full content available at: https://github.com/apache/geode/pull/2567 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
[ pull request closed by bschuchardt ]
[ Full content available at: https://github.com/apache/geode/pull/2562 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2567 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
- There is a subtle, low-level networking issue on Windows. See here
https://stackoverflow.com/questions/52653506/udp-socket-binding-and-sending-behavior-on-windows-1709
and here
https://serverfault.com/questions/934207/socket-binding-and-sending-on-different-addresses
Thank you for submit
* Disconnect would wait until there was a system, then disconnect it.
Sometimes it would wait until the next test started a new instance, then
immediately disconnect it.
* Wait for the member to finish disconnecting before ending the test.
* Remove the listener at the end of the test, so that it
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2573 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Because 'should be' isn't the same as 'is', and it matches on regular files
named 'build' and 'out' also. `out` is a required file name of a
concourse-resource, and it was being excluded by this line.
[ Full content available at: https://github.com/apache/geode/pull/2548 ]
This message was relay
Well that’s just downright a big in Gradle then. Any open tickets on the issue?
[ Full content available at: https://github.com/apache/geode/pull/2548 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Eh, I would rather find a way to keep the build file simple. Instead of
writing gradle code to work around this, how `bout changing the file names...?
[ Full content available at: https://github.com/apache/geode/pull/2548 ]
This message was relayed via gitbox.apache.org for
notifications@geode.
Tombstone cleanup has been a sore point for users who want very predictable
latency. How will this change affect latency of ongoing operations like
put/get?
[ Full content available at: https://github.com/apache/geode/pull/2552 ]
This message was relayed via gitbox.apache.org for
notifications
p the build file simple. Instead of
> writing gradle code to work around this, how `bout changing the file
> names...?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/254
While I am not a fan of complicated builds I would rather keep the hacks for
bugs closer to the source. In this case the bug is in Gradle so let's keep the
fix in Gradle. Changing the Docker build to rename files to match the Concourse
API would be making another build processes, removed from Gr
Is this worth some discussion on the `dev` list? I would think that any pre
`1.8` or `1.9` version of Geode shouldn't be expected to support Java 9+. Even
if this is all it takes to pass the tests as they currently stand, it feels
like a suckerpunch waiting to happen to run tests that aren't v
Removes unused sources.
[ Full content available at: https://github.com/apache/geode-native/pull/370 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2574 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2577 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I'm fine with this change, but I do wonder if there is simpler way to do this
in gradle - I think the exclude can take a closure, so maybe something like
this would work?
```
exclude {it.path.contains('/out/') && !it.path.contains('/ci'}
```
https://docs.gradle.org/current/javadoc/org/gradle/ap
[ pull request closed by dhemery ]
[ Full content available at: https://github.com/apache/geode/pull/2579 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
excellent rename(s)
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
unfortunate that the comment made this wrap
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
letters used to be so expensive
[ Full content available at: https://github.com/apache/geode-native/pull/370 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2564 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Oh, no it is worse. There was a directory, deleted by this, called `fwk` that
linked to this library. This library was always named `framework` but was a
transitive dependency through `fwk`. The `framework` library is in a directory
called, wait for it "fwklib".
[ Full content available at:
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/370 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/368 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Added unit tests to cover different working directory cases
* Removed acceptance tests related to working directory as they
seem to be fragile as paths are environment specific
Signed-off-by: Kirk Lund
Thank you for submitting a contribution to Apache Geode.
In order to streamline
Let me ask the question in dev list.
[ Full content available at: https://github.com/apache/geode/pull/2576 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
601 - 700 of 9074 matches
Mail list logo
