[GitHub] [groovy] danielsun1106 closed pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…

2019-03-27 Thread GitBox
danielsun1106 closed pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902 This is an automated message from the Apache Git Service. To

[jira] [Closed] (GROOVY-9056) Rename method `visit` of `ASTNode` to `accept` and add an alias method `visit`

2019-03-27 Thread Daniel Sun (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun closed GROOVY-9056. -- Resolution: Won't Fix Fix Version/s: (was: 3.0.0-beta-1) As [~paulk] said, making this

[GitHub] [groovy] paulk-asert commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…

2019-03-27 Thread GitBox
paulk-asert commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902#issuecomment-477335342 Eric makes some good points. Maybe making this change is more trouble than it is worth. The visit/accept names

[GitHub] [groovy] eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…

2019-03-27 Thread GitBox
eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902#issuecomment-477328705 Another problem this change will introduce: Any class that extends one of the `ASTNode` subclasses and intends

[GitHub] [groovy] eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…

2019-03-27 Thread GitBox
eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902#issuecomment-477324407 If someone has an existing class that extends {{ASTNode}} and provides custom visitation, it will be extending

[GitHub] [groovy] nguillaumin commented on issue #895: GROOVY-7954 Fix equality check in special case

2019-03-27 Thread GitBox
nguillaumin commented on issue #895: GROOVY-7954 Fix equality check in special case URL: https://github.com/apache/groovy/pull/895#issuecomment-477320029 Thanks! This is an automated message from the Apache Git Service. To

[jira] [Commented] (GROOVY-9058) each parameter type not correctly inferenced

2019-03-27 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-9058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803107#comment-16803107 ] Eric Milles commented on GROOVY-9058: - I think the issue lies within

[jira] [Created] (GROOVY-9058) each parameter type not correctly inferenced

2019-03-27 Thread Mauro Molinari (JIRA)
Mauro Molinari created GROOVY-9058: -- Summary: each parameter type not correctly inferenced Key: GROOVY-9058 URL: https://issues.apache.org/jira/browse/GROOVY-9058 Project: Groovy Issue