danielsun1106 opened a new pull request #847: GROOVY-8942: Highlight matched
parentheses, brackets and curly braces…
URL: https://github.com/apache/groovy/pull/847
… in Groovy Console when caret touching them
This is an
asfgit closed pull request #842: Fix typo
URL: https://github.com/apache/groovy/pull/842
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff
paulk-asert commented on issue #842: Fix typo
URL: https://github.com/apache/groovy/pull/842#issuecomment-450223658
Merged, thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
dpolivaev opened a new pull request #848: Run dependency management call as
privileged action
URL: https://github.com/apache/groovy/pull/848
Because we run scripts with restricted permissions it would be nice if grape
could run within a privileged action. Currently we use a metaclass
asfgit closed pull request #849: GROOVY-8945: Improve performance of DGM
`groupBy` and `countBy`
URL: https://github.com/apache/groovy/pull/849
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
danielsun1106 opened a new pull request #850: GROOVY-8947: Fail to resolve
non-static inner class outside of outer …
URL: https://github.com/apache/groovy/pull/850
…class
This is an automated message from the Apache Git
dpolivaev commented on issue #848: Run dependency management call as privileged
action
URL: https://github.com/apache/groovy/pull/848#issuecomment-451726834
https://issues.apache.org/jira/projects/GROOVY/issues/GROOVY-8949
asfgit closed pull request #848: Run dependency management call as privileged
action
URL: https://github.com/apache/groovy/pull/848
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
danielsun1106 commented on issue #848: Run dependency management call as
privileged action
URL: https://github.com/apache/groovy/pull/848#issuecomment-451730288
Merged:
https://github.com/apache/groovy/commit/9018229f2adf703e9ac51423b8934aafe62413de
Thanks for your contribution!
danielsun1106 commented on issue #848: Run dependency management call as
privileged action
URL: https://github.com/apache/groovy/pull/848#issuecomment-451720460
+1
It is better to create a JIRA ticket to track the improvement:
danielsun1106 opened a new pull request #855: GROOVY-8962: Provide an option to
generate Java stubs in memory for b…
URL: https://github.com/apache/groovy/pull/855
…etter compilation performance
This is an automated message
paulk-asert opened a new pull request #857: GROOVY-7996: Using with method with
a closure that references a prote…
URL: https://github.com/apache/groovy/pull/857
…cted property produces ClassCastException
This is an
danielsun1106 opened a new pull request #858: GROOVY-4287: CLONE - import of
static nested classes in external groo…
URL: https://github.com/apache/groovy/pull/858
…vy files is broken
This is an automated message from the
asfgit closed pull request #855: GROOVY-8962: Provide an option to generate
Java stubs in memory for b…
URL: https://github.com/apache/groovy/pull/855
This is an automated message from the Apache Git Service.
To respond to
asfgit merged pull request #857: GROOVY-7996: Using with method with a closure
that references a prote…
URL: https://github.com/apache/groovy/pull/857
This is an automated message from the Apache Git Service.
To respond to
danielsun1106 commented on issue #855: GROOVY-8962: Provide an option to
generate Java stubs in memory for b…
URL: https://github.com/apache/groovy/pull/855#issuecomment-455981690
72 hours have gone.
As no one rejects the PR, I'll merge it tonight.
paulk-asert opened a new pull request #854: GROOVY-8873: Fails at runtime with
@CompileStatic and two nested with…
URL: https://github.com/apache/groovy/pull/854
… statements with ClassCastException
This is an automated
danielsun1106 opened a new pull request #856: GROOVY-8963: Use
`CompilerConfiguration.DEFAULT_SOURCE_ENCODING` as d…
URL: https://github.com/apache/groovy/pull/856
…efault encoding
This is an automated message from the
danielsun1106 closed pull request #856: GROOVY-8963: Use
`CompilerConfiguration.DEFAULT_SOURCE_ENCODING` as d…
URL: https://github.com/apache/groovy/pull/856
This is an automated message from the Apache Git Service.
To
danielsun1106 commented on issue #856: GROOVY-8963: Use
`CompilerConfiguration.DEFAULT_SOURCE_ENCODING` as d…
URL: https://github.com/apache/groovy/pull/856#issuecomment-455794055
OK, I see.
This is an automated message from
paulk-asert opened a new pull request #859: GROOVY-8704: IntRange should be
Serializable
URL: https://github.com/apache/groovy/pull/859
This is an automated message from the Apache Git Service.
To respond to the message,
jslopezgithub opened a new pull request #842: Fix typo
URL: https://github.com/apache/groovy/pull/842
The *export and the '""' in the documentation seems wrong, I believe this
was the original intent.
This is an automated
jglick opened a new pull request #844:
MissingPropertyExceptionTest.testNullMessage
URL: https://github.com/apache/groovy/pull/844
Otherwise you get errors like
```
groovy.lang.MissingPropertyExceptionTest > testNullMessage FAILED
java.lang.NullPointerException
paulk-asert opened a new pull request #845: GROOVY-8935: Provide a @NullCheck
AST transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845
…k's NonNull
This is an automated message from the Apache Git
danielsun1106 commented on issue #845: GROOVY-8935: Provide a @NullCheck AST
transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845#issuecomment-449552202
+1
BTW, if we could check null in compilation time, that would be great!
asfgit closed pull request #844: MissingPropertyExceptionTest.testNullMessage
URL: https://github.com/apache/groovy/pull/844
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
danielsun1106 commented on issue #844:
MissingPropertyExceptionTest.testNullMessage
URL: https://github.com/apache/groovy/pull/844#issuecomment-449554407
Merged. Thanks for your contribution!
This is an automated message
danielsun1106 commented on issue #845: GROOVY-8935: Provide a @NullCheck AST
transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845#issuecomment-449552295
The relevant test is missing?
This is an
adithyank opened a new pull request #846: GROOVY-8939: Add methods in
StringGroovyMethods for better API Usage
URL: https://github.com/apache/groovy/pull/846
Interm PR reviewed https://github.com/adithyank/groovy/pull/1
This
asfgit closed pull request #845: GROOVY-8935: Provide a @NullCheck AST
transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
paulk-asert commented on issue #845: GROOVY-8935: Provide a @NullCheck AST
transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845#issuecomment-450019176
@danielsun1106 The "groovyTestCase" within the Javadoc contains the test.
paulk-asert edited a comment on issue #845: GROOVY-8935: Provide a @NullCheck
AST transformation similar to Lombo…
URL: https://github.com/apache/groovy/pull/845#issuecomment-450019176
@danielsun1106 The "groovyTestCase" within the Javadoc contains the test. We
should add support for
asfgit closed pull request #843: GROOVY-7233: Configurable Access Modifier for
Log AST Transformations
URL: https://github.com/apache/groovy/pull/843
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
paulk-asert commented on issue #846: GROOVY-8939: Add methods in
StringGroovyMethods for better API Usage
URL: https://github.com/apache/groovy/pull/846#issuecomment-450089520
Thanks @adithyank. PR applied.
This is an
asfgit closed pull request #846: GROOVY-8939: Add methods in
StringGroovyMethods for better API Usage
URL: https://github.com/apache/groovy/pull/846
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
asfgit closed pull request #811: GROOVY-8843: Fix illegal reflective access
within o.c.g.vmplugin.v7.J…
URL: https://github.com/apache/groovy/pull/811
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
danielsun1106 commented on issue #843: GROOVY-7233: Configurable Access
Modifier for Log AST Transformations
URL: https://github.com/apache/groovy/pull/843#issuecomment-447728688
+1
This is an automated message from the
paulk-asert opened a new pull request #843: GROOVY-7233: Configurable Access
Modifier for Log AST Transformations
URL: https://github.com/apache/groovy/pull/843
All of the logging AST transformations now support @VisibilityOptions.
This allows the log field to be public, private (the
adithyank commented on issue #806: GROOVY-8831: Add instance methods from
`String` to `GString`
URL: https://github.com/apache/groovy/pull/806#issuecomment-447206756
> FYI, `'abc'.md5()`
```bash
adithyan@adithyan:~$ groovy -e 'println "abc".md5()'
Caught:
adithyank commented on issue #806: GROOVY-8831: Add instance methods from
`String` to `GString`
URL: https://github.com/apache/groovy/pull/806#issuecomment-447206884
Also, my point is not only for this one method. It is about the availability
of all the methods in `String` in groovy
danielsun1106 commented on issue #806: GROOVY-8831: Add instance methods from
`String` to `GString`
URL: https://github.com/apache/groovy/pull/806#issuecomment-447210722
Groovy 2.5.4 is required to use `md5` DGM.
This is an
asfgit closed pull request #850: GROOVY-8947: Fail to resolve non-static inner
class outside of outer …
URL: https://github.com/apache/groovy/pull/850
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
paulk-asert opened a new pull request #851: GROOVY-8951: Traits defining getter
conflicts with generated getter (…
URL: https://github.com/apache/groovy/pull/851
…improvements for pre-compiled case)
This is an automated
danielsun1106 opened a new pull request #849: GROOVY-8945: Improve performance
of DGM `groupBy` and `countBy`
URL: https://github.com/apache/groovy/pull/849
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #847: GROOVY-8942: Highlight matched parentheses,
brackets and curly braces…
URL: https://github.com/apache/groovy/pull/847
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
paulk-asert opened a new pull request #852: GROOVY-8954: VerifyError due to
incorrect bytecode produced when a tr…
URL: https://github.com/apache/groovy/pull/852
…ait super property call also comes from an interface
This is
asfgit closed pull request #852: GROOVY-8954: VerifyError due to incorrect
bytecode produced when a tr…
URL: https://github.com/apache/groovy/pull/852
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
asfgit closed pull request #851: GROOVY-8951: Traits defining getter conflicts
with generated getter (…
URL: https://github.com/apache/groovy/pull/851
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
danielsun1106 commented on a change in pull request #853: GROOVY-7812: Static
inner classes cannot be accessed from other files…
URL: https://github.com/apache/groovy/pull/853#discussion_r247377408
##
File path: src/test/groovy/bugs/Groovy7812Bug.groovy
##
@@ -19,12
danielsun1106 commented on a change in pull request #853: GROOVY-7812: Static
inner classes cannot be accessed from other files…
URL: https://github.com/apache/groovy/pull/853#discussion_r247377408
##
File path: src/test/groovy/bugs/Groovy7812Bug.groovy
##
@@ -19,12
danielsun1106 opened a new pull request #853: GROOVY-7812: Static inner classes
cannot be accessed from other files…
URL: https://github.com/apache/groovy/pull/853
… when running by 'groovy' command
This is an automated
blackdrag commented on issue #853: GROOVY-7812: Static inner classes cannot be
accessed from other files…
URL: https://github.com/apache/groovy/pull/853#issuecomment-453829509
+1
This is an automated message from the Apache
danielsun1106 commented on issue #851: GROOVY-8951: Traits defining getter
conflicts with generated getter (…
URL: https://github.com/apache/groovy/pull/851#issuecomment-452655339
+1
This is an automated message from the
danielsun1106 opened a new pull request #863: Trivial refactoring: replace
explicit type with `<>` for simplicity
URL: https://github.com/apache/groovy/pull/863
This is an automated message from the Apache Git Service.
To
danielsun1106 opened a new pull request #860: Fix non-atomic operation on
volatile field 'count'
URL: https://github.com/apache/groovy/pull/860
This is an automated message from the Apache Git Service.
To respond to the
danielsun1106 opened a new pull request #861: Trivial refactoring: handle `Sql`
with try-with-resources for simplicity
URL: https://github.com/apache/groovy/pull/861
This is an automated message from the Apache Git Service.
danielsun1106 opened a new pull request #862: Trivial refactoring: remove
unnecessary boxing and unboxing for simpl…
URL: https://github.com/apache/groovy/pull/862
…icity
This is an automated message from the Apache Git
danielsun1106 opened a new pull request #864: GROOVY-8970: Fix typo in
MANIFEST.MF: Main-class
URL: https://github.com/apache/groovy/pull/864
This is an automated message from the Apache Git Service.
To respond to the
eric-milles commented on issue #903: GROOVY-9060: Make the initial capacity of
LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#issuecomment-479132066
Doesn't this just move the math from inside of HashMap to
InvokerHelper.initialCapacity? Where is the
danielsun1106 commented on issue #903: GROOVY-9060: Make the initial capacity
of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#issuecomment-479243881
See
https://github.com/apache/groovy/commit/5c8f08633a320be8836a249d577a549fe5966b76
eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of
`ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#issuecomment-477328705
Another problem this change will introduce: Any class that extends one of
the `ASTNode` subclasses and intends
eric-milles commented on issue #902: GROOVY-9056: Rename method `visit` of
`ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#issuecomment-477324407
If someone has an existing class that extends {{ASTNode}} and provides
custom visitation, it will be extending
paulk-asert commented on issue #902: GROOVY-9056: Rename method `visit` of
`ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#issuecomment-477335342
Eric makes some good points. Maybe making this change is more trouble than
it is worth. The visit/accept names
nguillaumin commented on issue #895: GROOVY-7954 Fix equality check in special
case
URL: https://github.com/apache/groovy/pull/895#issuecomment-477320029
Thanks!
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #891: GROOVY-9022: Added option under View menu of
whether or not to have v…
URL: https://github.com/apache/groovy/pull/891
This is an automated message from the Apache Git Service.
To respond to
paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu
of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-475946048
Merged, thanks!
This is an automated message
danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename
method `visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268429007
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@
danielsun1106 opened a new pull request #902: GROOVY-9056: Rename method
`visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902
…n alias method `visit`
This is an automated message from
pzygielo commented on a change in pull request #902: GROOVY-9056: Rename method
`visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268427112
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@ -50,8
danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename
method `visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268428491
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@
paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu
of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-475945250
Looks like a call to `resetToPreferredSizes()` fixes those glitches above.
I'll merge your request and add in
adamldavis commented on issue #891: GROOVY-9022: Added option under View menu
of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-47673
Thanks so much! Feels great to contribute to Groovy in a small way.
danielsun1106 opened a new pull request #901: GROOVY-9049:
EncodingGroovyMethods.digest() truncates hashes over 128…
URL: https://github.com/apache/groovy/pull/901
… bits starting with 0's
This is an automated message from
asfgit closed pull request #901: GROOVY-9049: EncodingGroovyMethods.digest()
truncates hashes over 128…
URL: https://github.com/apache/groovy/pull/901
This is an automated message from the Apache Git Service.
To respond to
danielsun1106 opened a new pull request #904: GROOVY-9067: Compile Java stubs
with standard API
URL: https://github.com/apache/groovy/pull/904
This is an automated message from the Apache Git Service.
To respond to the
blackdrag commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270636444
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
##
danielsun1106 opened a new pull request #903: GROOVY-9060: Make the initial
capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903
… for better performance
This is an automated message from
danielsun1106 commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270651854
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
danielsun1106 closed pull request #902: GROOVY-9056: Rename method `visit` of
`ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #903: GROOVY-9060: Make the initial capacity of
LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903
This is an automated message from the Apache Git Service.
To respond to
blackdrag commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270663532
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
##
danielsun1106 commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270664227
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
danielsun1106 commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270664227
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
blackdrag commented on a change in pull request #903: GROOVY-9060: Make the
initial capacity of LinkedHashMap be power of 2…
URL: https://github.com/apache/groovy/pull/903#discussion_r270663532
##
File path: src/main/java/org/codehaus/groovy/runtime/InvokerHelper.java
##
paulk-asert commented on issue #882: GROOVY-9008: Support native method
reference and constructor reference (basic cases)
URL: https://github.com/apache/groovy/pull/882#issuecomment-480820963
+1, I have squashed a few of the commits but mostly left them as is. I'll
merge now. I have added
danielsun1106 commented on issue #882: GROOVY-9008: Support native method
reference and constructor reference (basic cases)
URL: https://github.com/apache/groovy/pull/882#issuecomment-480821826
Thanks, Paul
This is an
danielsun1106 closed pull request #882: GROOVY-9008: Support native method
reference and constructor reference (basic cases)
URL: https://github.com/apache/groovy/pull/882
This is an automated message from the Apache Git
paulk-asert commented on issue #887: upgraded ASM to 7.1, added Java 13 to
CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887#issuecomment-469128539
+1
This is an automated message from the Apache Git
danielsun1106 commented on issue #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#issuecomment-469082769
LGTM
This is an automated message from the Apache Git Service.
To respond to the message,
keeganwitt opened a new pull request #887: upgraded ASM to 7.1, added Java 13
to CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887
This is an automated message from the Apache Git Service.
To respond to
paulk-asert commented on a change in pull request #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#discussion_r261902762
##
File path:
subprojects/groovy-console/src/main/groovy/groovy/ui/ConsolePreferences.groovy
##
@@ -63,26 +64,36 @@ class
keeganwitt commented on issue #887: upgraded ASM to 7.1, added Java 13 to
CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887#issuecomment-469131194
Any objection to including this on the 2.5 line?
This is
keeganwitt edited a comment on issue #887: upgraded ASM to 7.1, added Java 13
to CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887#issuecomment-469131194
@paulk-asert Thanks. Any objection to including this on the 2.5 line?
asfgit closed pull request #887: upgraded ASM to 7.1, added Java 13 to
CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887
This is an automated message from the Apache Git Service.
To respond to the
tttao commented on issue #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#issuecomment-469153681
@paulk-asert Thanks for the feedback ! I will rop a mail to the mailing list
regarding saving the checkbox+filename under the OS preferences - knowing that
it might
paulk-asert commented on a change in pull request #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#discussion_r261902793
##
File path: subprojects/groovy-console/src/main/groovy/groovy/ui/Console.groovy
##
@@ -66,10 +66,12 @@ import
asfgit closed pull request #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tttao edited a comment on issue #886: Groovy 8180 log to file
URL: https://github.com/apache/groovy/pull/886#issuecomment-469153681
@paulk-asert Thanks for the feedback ! I will drop a mail to the mailing
list regarding saving the checkbox+filename under the OS preferences - knowing
that
paulk-asert commented on issue #887: upgraded ASM to 7.1, added Java 13 to
CompilerConfiguration
URL: https://github.com/apache/groovy/pull/887#issuecomment-469225853
Works for me. Let's wait a day or two and see if anyone else has an opinion.
neo1949 opened a new pull request #888: Fix assertion error for sample code
URL: https://github.com/apache/groovy/pull/888
The original sample code in [3.2.4. Delegation
strategy](http://www.groovy-lang.org/closures.html#_delegation_strategy_2)
assert failed:
```groovy
class Person
1 - 100 of 4265 matches
Mail list logo
