danielsun1106 commented on issue #974: GROOVY-8002: propagate source position
to method in chain assignment
URL: https://github.com/apache/groovy/pull/974#issuecomment-517723930
Agreed.
Merged. Thanks!
This is an
danielsun1106 opened a new pull request #984: GROOVY-9212: Bump gradle to
5.6-rc-1
URL: https://github.com/apache/groovy/pull/984
This is an automated message from the Apache Git Service.
To respond to the message, please
danielsun1106 merged pull request #984: GROOVY-9212: Bump gradle to 5.6-rc-1
URL: https://github.com/apache/groovy/pull/984
This is an automated message from the Apache Git Service.
To respond to the message, please log on
blackdrag commented on issue #994: GROOVY-9075: The exception message should be
more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#issuecomment-522004277
Actually one more comment on the change.. as done it will check only if
setting the property via the meta class.
danielsun1106 commented on issue #994: GROOVY-9075: The exception message
should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#issuecomment-522013107
To be frank, I am not sure how the PR will impact existing valid use cases...
Thanks for your reviewing :-)
danielsun1106 merged pull request #988: GROOVY-9218: Reduce the memory usage of
`MethodIndex` instances
URL: https://github.com/apache/groovy/pull/988
This is an automated message from the Apache Git Service.
To respond to
danielsun1106 opened a new pull request #988: Make inner class `MethodIndex`
`static`
URL: https://github.com/apache/groovy/pull/988
A static inner class does not keep an implicit reference to its enclosing
instance. This prevents a common cause of memory leaks and uses less memory per
paulk-asert commented on issue #992: GROOVY-9215: Incorrect compile time access
error is raised when using…
URL: https://github.com/apache/groovy/pull/992#issuecomment-521475061
+1, the other option would be to give some kind of compiler error but I
think I am in favor of the approach you
expexes commented on a change in pull request #993: GROOVY-9228: CLI options
for static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314809803
##
File path: src/main/java/groovy/ui/GroovyMain.java
##
@@ -223,8 +231,14 @@ static void
remkop commented on a change in pull request #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314791825
##
File path: src/main/java/groovy/ui/GroovyMain.java
##
@@ -223,8 +231,14 @@ static void
remkop commented on a change in pull request #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314790912
##
File path: src/main/java/groovy/ui/GroovyMain.java
##
@@ -121,15 +120,24 @@ public static void
remkop commented on a change in pull request #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314794014
##
File path: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java
##
@@ -359,9 +393,15 @@
remkop commented on a change in pull request #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314792926
##
File path: src/main/java/groovy/ui/GroovyMain.java
##
@@ -289,37 +304,82 @@ boolean
remkop commented on a change in pull request #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#discussion_r314791959
##
File path: src/main/java/groovy/ui/GroovyMain.java
##
@@ -223,8 +231,14 @@ static void
expexes commented on issue #993: GROOVY-9228: CLI options for static compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-522304093
@remkop Thanks for reviewing!
I tried another more natural way to apply transforms using smth like this:
```java
remkop edited a comment on issue #993: GROOVY-9228: CLI options for static
compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-522306343
@expexes No worries. I didn’t mean that as criticism, it’s simply outside my
area of expertise. :-)
remkop commented on issue #993: GROOVY-9228: CLI options for static compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-522306343
@expexes No worries. I didn’t mean that as criticism, it’s simply out of my
area of expertise. :-)
danielsun1106 commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r314945226
##
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##
@@ -477,11 +477,11 @@ public static void disableGlobally() {
blindpirate opened a new pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996
This is fixing some potential bugs from
https://sonarcloud.io/dashboard?id=danielsun1106_groovy
@danielsun1106
expexes opened a new pull request #993: Added --compile-static (-cs) and
--type-checked (-tc) cli options
URL: https://github.com/apache/groovy/pull/993
Options added to following classes:
- `groovy.ui.GroovyMain`
- `org.codehaus.groovy.tools.FileSystemCompiler`
*also trivial
blackdrag commented on issue #990: GROOVY-9223: Avoid generating common methods
for each groovy class
URL: https://github.com/apache/groovy/pull/990#issuecomment-521622589
I am actually a bit surprised there has been no problem with the meta class
invocation logic here, because I remember
danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common
methods for each groovy class
URL: https://github.com/apache/groovy/pull/990#issuecomment-521626662
Thanks for your definitive reviewing
When I saw you had approved the PR, I merged it.
expexes commented on issue #993: Added --compile-static (-cs) and
--type-checked (-tc) cli options
URL: https://github.com/apache/groovy/pull/993#issuecomment-521670249
JIRA ticket:
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static
compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-521673045
LGTM.
BTW, could you expand the imports, e.g. `import groovy.lang.*;`?
Groovy core team has a coding convention: import the
danielsun1106 merged pull request #992: GROOVY-9215: Incorrect compile time
access error is raised when using…
URL: https://github.com/apache/groovy/pull/992
This is an automated message from the Apache Git Service.
To
danielsun1106 commented on issue #990: GROOVY-9223: Avoid generating common
methods for each groovy class
URL: https://github.com/apache/groovy/pull/990#issuecomment-521557596
@blackdrag @paulk-asert
Please review the PR :-)
danielsun1106 opened a new pull request #994: GROOVY-9075: The exception
message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994
…Object's metaClass is wrong
This is an automated message
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static
compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-521684831
Let's wait for a while to see what other committer think about the PR.
ping @paulk-asert , @remkop
danielsun1106 edited a comment on issue #993: GROOVY-9228: CLI options for
static compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-521684831
Let's wait for a while to see what other committers think about the PR.
ping @paulk-asert , @remkop
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314567245
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
paulk-asert commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314568581
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
paulk-asert commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314568581
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314572084
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
paulk-asert commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314558063
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
paulk-asert commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314558063
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314567178
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
danielsun1106 commented on a change in pull request #994: GROOVY-9075: The
exception message should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994#discussion_r314567245
##
File path: src/main/java/org/codehaus/groovy/runtime/MetaClassHelper.java
blindpirate opened a new pull request #995: Fix some bad code
URL: https://github.com/apache/groovy/pull/995
I did an analysis in IDEA and fixed some bad code.
This is an automated message from the Apache Git Service.
To
danielsun1106 commented on issue #991: GROOVY-9031: correct trait property
generics before writing stub methods
URL: https://github.com/apache/groovy/pull/991#issuecomment-520734308
Merged. Thanks!
This is an automated
danielsun1106 merged pull request #987: GROOVY-9217: Fix warning "An illegal
reflective access operation has …
URL: https://github.com/apache/groovy/pull/987
This is an automated message from the Apache Git Service.
To
danielsun1106 opened a new pull request #987: GROOVY-9217: Fix warning "An
illegal reflective access operation has …
URL: https://github.com/apache/groovy/pull/987
…occurred" when setting property
This is an automated
blindpirate commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315493440
##
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##
@@ -477,11 +477,11 @@ public static void disableGlobally() {
paulk-asert commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315515350
##
File path: src/main/java/groovy/lang/ObjectRange.java
##
@@ -302,7 +302,7 @@ public int size() {
// let's
paulk-asert commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315532208
##
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##
@@ -477,10 +477,10 @@ public static void disableGlobally() {
paulk-asert commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315516303
##
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##
@@ -477,10 +477,10 @@ public static void disableGlobally() {
blindpirate commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315517141
##
File path: src/main/java/groovy/lang/ObjectRange.java
##
@@ -302,7 +302,7 @@ public int size() {
// let's
blindpirate commented on a change in pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#discussion_r315517303
##
File path: src/main/java/groovy/lang/ExpandoMetaClass.java
##
@@ -477,10 +477,10 @@ public static void disableGlobally() {
danielsun1106 opened a new pull request #992: GROOVY-9215: Incorrect compile
time access error is raised when using…
URL: https://github.com/apache/groovy/pull/992
… @CompileStatic and/or @TypeChecked
This is an automated
danielsun1106 commented on issue #989: Fix issues in tests so Eclipse can
compile far enough to debug
URL: https://github.com/apache/groovy/pull/989#issuecomment-520836062
Merged. Thanks!
This is an automated message from
danielsun1106 merged pull request #989: Fix issues in tests so Eclipse can
compile far enough to debug
URL: https://github.com/apache/groovy/pull/989
This is an automated message from the Apache Git Service.
To respond to
asfgit closed pull request #971: Convert some recent tests to JUnit 4
URL: https://github.com/apache/groovy/pull/971
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
paulk-asert commented on issue #971: Convert some recent tests to JUnit 4
URL: https://github.com/apache/groovy/pull/971#issuecomment-520280640
I merged (thanks!) but just reverted the spacing in the license header. It's
a minor thing but I'd prefer to remain consistent even for the little
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveToOuter` only resolves classes whose name does not contains `.`
and `resolveFromStaticInnerClasses` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveToOuter` only resolves classes whose name does not contains `.`
and `resolveFromStaticInnerClasses` only resolves classes
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526532434
@blackdrag
Jochen, if you could set aside some time to review the PR too, that would be
great :-)
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
danielsun1106 opened a new pull request #1000: GROOVY-9242: Bump picocli to
4.0.3
URL: https://github.com/apache/groovy/pull/1000
This is an automated message from the Apache Git Service.
To respond to the message, please
danielsun1106 merged pull request #1000: GROOVY-9242: Bump picocli to 4.0.3
URL: https://github.com/apache/groovy/pull/1000
This is an automated message from the Apache Git Service.
To respond to the message, please log on
eric-milles opened a new pull request #1001: GROOVY-9240: relax signature of
RGM.traverse(File, Map, ...)
URL: https://github.com/apache/groovy/pull/1001
This is an automated message from the Apache Git Service.
To respond
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced.
```
import
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced.
```groovy
blackdrag commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526744548
your change looks like progress no doubt, but why is there still
"groovy.lang.GroovyObject$groovy$transform$CompileStatic" in there? ideally
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced. Then I got the result:
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526793412
As we can see, STC is enabled by `@CompileStatic`.
`groovy.lang.GroovyObject$groovy$transform$CompileStatic` is guessed by
blackdrag commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526738578
could you first show what you compiled with that? And I think we will need
more cases to for review. At the very least I would like to see the
danielsun1106 merged pull request #999: GROOVY-8815: preserve redirects for
generics placeholders
URL: https://github.com/apache/groovy/pull/999
This is an automated message from the Apache Git Service.
To respond to the
danielsun1106 commented on issue #999: GROOVY-8815: preserve redirects for
generics placeholders
URL: https://github.com/apache/groovy/pull/999#issuecomment-527364405
Merged. Thanks.
This is an automated message from the
eric-milles opened a new pull request #1003: GROOVY-9229, GROOVY-9233: added
missing closure parameter metadata
URL: https://github.com/apache/groovy/pull/1003
This is an automated message from the Apache Git Service.
To
eric-milles opened a new pull request #999: GROOVY-8815: preserve redirects for
generics placeholders
URL: https://github.com/apache/groovy/pull/999
When resolving method with generics, placeholder may have bounds. Ex:
def void doSomething(Predicate check) { ... }
If Type has
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526408438
The PR is ready to be reviewed.
Ping @paulk-asert ;-)
This is an
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526408884
The following guessed class lists show the difference caused by the PR.
As you can see, lots of classes will be avoided to guess
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526408884
The following lists show the difference caused by the PR.
* After changes:
```
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526408884
The following guessed class lists show the difference caused by the PR.
* After changes:
```
danielsun1106 commented on issue #999: GROOVY-8815: preserve redirects for
generics placeholders
URL: https://github.com/apache/groovy/pull/999#issuecomment-526453717
LGTM
This is an automated message from the Apache Git
danielsun1106 closed pull request #965: GROOVY-9192: Implement parser error
recovery for Parrot parser
URL: https://github.com/apache/groovy/pull/965
This is an automated message from the Apache Git Service.
To respond to
danielsun1106 closed pull request #994: GROOVY-9075: The exception message
should be more clear when a Groovy…
URL: https://github.com/apache/groovy/pull/994
This is an automated message from the Apache Git Service.
To
danielsun1106 opened a new pull request #997: Minor refactoring: Convert
`ProgressCallback` to functional interface
URL: https://github.com/apache/groovy/pull/997
This is an automated message from the Apache Git Service.
To
danielsun1106 merged pull request #997: Minor refactoring: Convert
`ProgressCallback` and `ClassgenCallback` to functional interface
URL: https://github.com/apache/groovy/pull/997
This is an automated message from the
danielsun1106 merged pull request #993: GROOVY-9228: CLI options for static
compilation
URL: https://github.com/apache/groovy/pull/993
This is an automated message from the Apache Git Service.
To respond to the message,
danielsun1106 commented on issue #993: GROOVY-9228: CLI options for static
compilation
URL: https://github.com/apache/groovy/pull/993#issuecomment-523391274
Merged. Thanks.
This is an automated message from the Apache Git
danielsun1106 merged pull request #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
danielsun1106 commented on issue #996: Fix potential bugs
URL: https://github.com/apache/groovy/pull/996#issuecomment-523375177
Merged. Thanks.
This is an automated message from the Apache Git Service.
To respond to the
danielsun1106 commented on issue #999: GROOVY-8815: preserve redirects for
generics placeholders
URL: https://github.com/apache/groovy/pull/999#issuecomment-526985257
@eric-milles 72 hours have gone and no objections raised, so feel free to
merge the PR and close the related JIRA issue
danielsun1106 opened a new pull request #1002: Fix the broken link to outer
nested types
URL: https://github.com/apache/groovy/pull/1002
Currently `ConstructedOuterNestedClassNode` instance can be linked to outer
nested type, but the type to resolve(i.e. the type we really care) is not
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-527198828
@melix
Hi Cédric, I am trying to reduce the cost of resolving[1], could you review
the PR too? Thanks in advance :-)
[1]
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-527198828
@melix
Hi Cédric, I am trying to reduce the cost of resolving[1], could you review
the PR too? Thanks in advance :-)
Here
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-527198828
@melix
Hi Cédric, I am trying to reducing the cost of resolving[1], could you
review the PR too? Thanks in advance :-)
[1]
danielsun1106 opened a new pull request #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998
This is an automated message from the Apache Git Service.
To respond to the message,
danielsun1106 merged pull request #1002: GROOVY-9243: Fail to resolve nested
type defined in base type written in Groovy
URL: https://github.com/apache/groovy/pull/1002
This is an automated message from the Apache Git
danielsun1106 opened a new pull request #1006: GROOVY-9251: Bump picocli to
4.0.4
URL: https://github.com/apache/groovy/pull/1006
This is an automated message from the Apache Git Service.
To respond to the message, please
danielsun1106 merged pull request #1006: GROOVY-9251: Bump picocli to 4.0.4
URL: https://github.com/apache/groovy/pull/1006
This is an automated message from the Apache Git Service.
To respond to the message, please log on
paulk-asert commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-530208773
Go ahead and commit. I still want to do more testing but won't get time
until next week. We can revert/tweak later if we really need to.
danielsun1106 merged pull request #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998
This is an automated message from the Apache Git Service.
To respond to the message, please log
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-530220095
> We can revert/tweak later if we really need to.
I think so too :-)
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-529890504
@paulk-asert
In theory, it is not a breaking chang and its build is green. But we can not
test all frameworks based on Groovy, so how
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-529890504
@paulk-asert
In theory, it is not a breaking change and its build is green. But we can
not test all frameworks based on Groovy,
danielsun1106 opened a new pull request #1007: Merge the latest 7 commits from
master into GROOVY_3_0_X
URL: https://github.com/apache/groovy/pull/1007
This is an automated message from the Apache Git Service.
To respond to
danielsun1106 commented on issue #1001: GROOVY-9240: relax signature of
RGM.traverse(File, Map, ...)
URL: https://github.com/apache/groovy/pull/1001#issuecomment-529713338
Merged. Thanks.
This is an automated message from
501 - 600 of 4265 matches
Mail list logo
